]> source.dussan.org Git - gitea.git/log
gitea.git
16 months agoImprove Actions CSS (#24864)
silverwind [Wed, 24 May 2023 09:00:29 +0000 (11:00 +0200)]
Improve Actions CSS (#24864)

- Various color tweaks
- Add sticky positioning to left sidebar, right header and right step
header
- Adjust margins and border radiuses

<img width="1235" alt="Screenshot 2023-05-23 at 11 18 06"
src="https://github.com/go-gitea/gitea/assets/115237/f601b00d-c7f2-43de-89f2-3ac55f2d9cdc">
<img width="1239" alt="Screenshot 2023-05-23 at 11 18 18"
src="https://github.com/go-gitea/gitea/assets/115237/a2d24cc9-29fa-4c17-906b-84feea14b889">

![](https://github.com/go-gitea/gitea/assets/115237/643910f2-a582-405d-bc93-36f2e54b5fda)

![](https://github.com/go-gitea/gitea/assets/115237/382a8a54-f1e3-4f08-affc-ea3108c02352)

---------

Co-authored-by: yp05327 <576951401@qq.com>
16 months agoFix <empty> in administration/config-cheat-sheet.en-us.md (#24905)
HesterG [Wed, 24 May 2023 08:29:44 +0000 (16:29 +0800)]
Fix <empty> in administration/config-cheat-sheet.en-us.md (#24905)

Before

<img width="206" alt="Screen Shot 2023-05-24 at 15 54 02"
src="https://github.com/go-gitea/gitea/assets/17645053/3493180e-e7a8-466d-b418-641c39d7788c">

<img width="272" alt="Screen Shot 2023-05-24 at 15 50 05"
src="https://github.com/go-gitea/gitea/assets/17645053/b1c80313-5b2c-41d8-aad3-4099c912c173">

<img width="264" alt="Screen Shot 2023-05-24 at 15 50 16"
src="https://github.com/go-gitea/gitea/assets/17645053/9a4b4223-ce67-40b3-a44e-03219694a37d">

After

<img width="295" alt="Screen Shot 2023-05-24 at 15 52 53"
src="https://github.com/go-gitea/gitea/assets/17645053/fbc8ef6e-2b9b-44f5-ba4f-6002cf2f19fe">
<img width="334" alt="Screen Shot 2023-05-24 at 15 53 03"
src="https://github.com/go-gitea/gitea/assets/17645053/6ebe45bf-b986-4afc-9b5c-d0c0134650c2">
<img width="282" alt="Screen Shot 2023-05-24 at 15 53 13"
src="https://github.com/go-gitea/gitea/assets/17645053/90ccc1ae-69f5-4730-8191-5e86ed0f6d49">

16 months agoOnly validate changed columns when update user (#24867)
Lunny Xiao [Wed, 24 May 2023 07:30:55 +0000 (15:30 +0800)]
Only validate changed columns when update user (#24867)

Fix #23211
Replace #23496

16 months agoRename docs packages title from xxx Packages Repository -> xxx Package Registry ...
Lunny Xiao [Wed, 24 May 2023 06:21:39 +0000 (14:21 +0800)]
Rename docs packages title from xxx Packages Repository -> xxx Package Registry (#24895)

As title.

16 months agoFix can’t move anymore items in repo project boards (#24892)
yp05327 [Wed, 24 May 2023 06:05:50 +0000 (15:05 +0900)]
Fix can’t move anymore items in repo project boards (#24892)

Fix #24879
Related to #24589

In #24589, I changed the css, but didn't reflect the changes in
repo-level projects template.

16 months agoMake environment-to-ini support loading key value from file (#24832)
wxiaoguang [Wed, 24 May 2023 03:37:22 +0000 (11:37 +0800)]
Make environment-to-ini  support loading key value from file (#24832)

Replace #19857

Close #19856
Close #10311
Close #10123

Major changes:

1. Move a lot of code from `environment-to-ini.go` to `config_env.go` to
make them testable.
2. Add `__FILE` support
3. Update documents
4. Add tests

16 months ago`zh-cn` translation for administration docs (#24881)
Zettat123 [Wed, 24 May 2023 02:35:43 +0000 (10:35 +0800)]
`zh-cn` translation for administration docs (#24881)

- [x] adding-legal-pages
- [x] cmd-embedded
- [x] command-line
- [x] email-setup
- [x] external-renderers
- [x] git-lfs-support
- [x] logging-config
- [x] mail-templates
- [x] repo-indexer
- [x] search-engines-indexation
- [x] signing

16 months agoFix `@font-face` overrides (#24855)
silverwind [Wed, 24 May 2023 01:48:51 +0000 (03:48 +0200)]
Fix `@font-face` overrides (#24855)

Fixes: https://github.com/go-gitea/gitea/issues/24850
Not sure how to do it for asian fonts only, so let's revert to previous
value for now.

### Before
<img width="414" alt="Screenshot 2023-05-22 at 10 34 10"
src="https://github.com/go-gitea/gitea/assets/115237/749f1556-a5cf-48fe-8b10-8dc447221657">

### After
<img width="416" alt="Screenshot 2023-05-22 at 10 34 04"
src="https://github.com/go-gitea/gitea/assets/115237/a0a315bb-d95f-4d03-863e-0534f665ca71">

16 months agoFix logger refactoring regression: manager logging add (#24847)
wxiaoguang [Wed, 24 May 2023 00:09:33 +0000 (08:09 +0800)]
Fix logger refactoring regression: manager logging add (#24847)

The `rotate` option is optional.

Test result:

![image](https://github.com/go-gitea/gitea/assets/2114189/7cff8207-dcf3-4988-adef-247f1c9316e7)

16 months agoRemove publish docs CI workflow (#24889)
techknowlogick [Tue, 23 May 2023 20:41:27 +0000 (16:41 -0400)]
Remove publish docs CI workflow (#24889)

Now that the redirect to docs.gitea.com is in place this is no longer
needed.

16 months agoFix double border and adjust width for user profile page (#24870)
HesterG [Tue, 23 May 2023 17:55:51 +0000 (01:55 +0800)]
Fix double border and adjust width for user profile page (#24870)

Close #24848

16 months agoSupport changing git config through `app.ini`, use `diff.algorithm=histogram` by...
wxiaoguang [Tue, 23 May 2023 16:30:19 +0000 (00:30 +0800)]
Support changing git config through `app.ini`, use `diff.algorithm=histogram` by default (#24860)

Close #13454 , Close #23255, Close #14697 (and maybe more related
issues)

Many users have the requirement to customize the git config. This PR
introduces an easy way: put the options in Gitea's app.ini
`[git.config]`, then the config options will be applied to git config.

And it can support more flexible default config values, eg: now
`diff.algorithm=histogram` by default. According to:
https://stackoverflow.com/a/32367597/4754037 , `histogram diff` is
efficient and doesn't like to cause server-side problems.

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoFix flakey test in logger test (#24883)
wxiaoguang [Tue, 23 May 2023 16:01:20 +0000 (00:01 +0800)]
Fix flakey test in logger test (#24883)

Fix #24882

The goroutines are all asynchronized. So it needs a little "sleep" to
make sure the writer's goroutine has been paused before sending messages
to it.

Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoRun stylelint on .vue files (#24865)
silverwind [Tue, 23 May 2023 13:54:21 +0000 (15:54 +0200)]
Run stylelint on .vue files (#24865)

- Run stylelint on .vue files
- Fix discovered issues
- Suppress warning spam from `declaration-strict-value` rule

Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoUpdate `CONTRIBUTING.md` (#24492)
John Olheiser [Tue, 23 May 2023 12:22:40 +0000 (07:22 -0500)]
Update `CONTRIBUTING.md` (#24492)

Previously, the `CONTRIBUTING` was severely outdated in certain aspects
such as workflows.
These sections have been brought up to date.
Furthermore, the `CONTRIBUTING` now mentions the TOC, how it is
structured, elected, and its duties.

---------

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: delvh <dev.lh@web.de>
16 months agoDo not call nil handler for a dummy queue (#24880)
wxiaoguang [Tue, 23 May 2023 11:40:55 +0000 (19:40 +0800)]
Do not call nil handler for a dummy queue (#24880)

A dummy queue doesn't really have a handler (see line 211), so the
`safeHandler` can safely drop all items

16 months agoRemove unnecessary usage prefix from doc titles (#24869)
Lunny Xiao [Tue, 23 May 2023 10:14:57 +0000 (18:14 +0800)]
Remove unnecessary usage prefix from doc titles (#24869)

As title.

16 months agoAdd API for Label templates (#24602)
JakobDev [Tue, 23 May 2023 10:10:23 +0000 (12:10 +0200)]
Add API for Label templates (#24602)

This adds API that allows getting the Label templates of the Gitea
Instance

16 months agoFix install page context, make the install page tests really test (#24858)
wxiaoguang [Tue, 23 May 2023 01:29:15 +0000 (09:29 +0800)]
Fix install page context, make the install page tests really test (#24858)

Fix #24856

Rename "context.contextKey" to "context.WebContextKey", this context is
for web context only. But the Context itself is not renamed, otherwise
it would cause a lot of changes (if we really want to rename it, there
could be a separate PR).

The old test code doesn't really test, the "install page" gets broken
not only one time, so use new test code to make sure the "install page"
could work.

16 months agoAdd validations.required check to dropdown field (#24849)
yp05327 [Mon, 22 May 2023 21:26:48 +0000 (06:26 +0900)]
Add validations.required check to dropdown field (#24849)

If dropdown is marked as required, we should not provide the `remove`
button.
This will cause user may post empty value which seems like a bug.

Definition:

![image](https://github.com/go-gitea/gitea/assets/18380374/cf48b478-244e-44e0-9a0e-7a0f02bc471a)
Post request form:

![image](https://github.com/go-gitea/gitea/assets/18380374/31d6f823-835f-422a-879c-3b1e18950ac8)
Result:

![image](https://github.com/go-gitea/gitea/assets/18380374/a9944fe9-24d0-4776-9eec-d31b70144eb4)

16 months agoUse Go 1.20 for next release (#24859)
wxiaoguang [Mon, 22 May 2023 16:29:53 +0000 (00:29 +0800)]
Use Go 1.20 for next release (#24859)

16 months agoAdd gitea manager reload-templates command (#24843)
Brecht Van Lommel [Mon, 22 May 2023 15:51:40 +0000 (17:51 +0200)]
Add gitea manager reload-templates command (#24843)

This can be useful to update custom templates in production mode, when
they are updated frequently and a full Gitea restart each time is
disruptive.

16 months agoRemove `In your repositories` link in milestones dashboard (#24853)
yp05327 [Mon, 22 May 2023 11:42:57 +0000 (20:42 +0900)]
Remove `In your repositories` link in milestones dashboard (#24853)

It is unnecessary to it.

16 months agoFix 500 error when select `No assignee` filter in issue list page (#24854)
yp05327 [Mon, 22 May 2023 11:08:27 +0000 (20:08 +0900)]
Fix 500 error when select `No assignee` filter in issue list page (#24854)

Access the issue list page and select `No assignee`, you will get 500
error:

![image](https://github.com/go-gitea/gitea/assets/18380374/a7435fd3-c3d5-4801-894e-9353a8ddc1af)

You can see this page in try.gitea.io:

https://try.gitea.io/yp05327/testrepo/issues?q=&type=all&sort=&state=open&labels=&milestone=0&project=0&assignee=-1&poster=0

Caused by
https://github.com/go-gitea/gitea/pull/24707/files#diff-d7c7dc2da4fcfdc09997648e11a018414dc116472054350b5590ab407adcd44dR1748

Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoAdd IsErrRepoFilesAlreadyExist check when fork repo (#24678)
yp05327 [Mon, 22 May 2023 10:21:46 +0000 (19:21 +0900)]
Add IsErrRepoFilesAlreadyExist check when fork repo (#24678)

Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/e9e3de75-eb6e-418e-9227-ef4e5f448a04)
After:

![image](https://github.com/go-gitea/gitea/assets/18380374/74b1cd6c-c5b1-4ee0-a1d8-6b3fb8d3a8e9)

16 months agoFix missing yes/no in delete time log modal (#24851)
yp05327 [Mon, 22 May 2023 09:46:50 +0000 (18:46 +0900)]
Fix missing yes/no in delete time log modal (#24851)

Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/bcbcddcc-b328-4751-92fe-6e55b7a84671)

After:

![image](https://github.com/go-gitea/gitea/assets/18380374/571ef27a-2411-472e-819d-f694e7be3697)

Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoFix document and improve comment (#24844)
wxiaoguang [Mon, 22 May 2023 08:47:33 +0000 (16:47 +0800)]
Fix document and improve comment (#24844)

* Fix broken doc link:
https://github.com/go-gitea/gitea/actions/runs/5041309438/jobs/9040887385
* Improve comments about how font weight works:
https://github.com/go-gitea/gitea/pull/24827#pullrequestreview-1435584800

---------

Co-authored-by: silverwind <me@silverwind.io>
16 months agoShow new pull request button also on subdirectories and files (#24842)
Brecht Van Lommel [Mon, 22 May 2023 07:57:00 +0000 (09:57 +0200)]
Show new pull request button also on subdirectories and files (#24842)

Instead of only on the repository home page. Saves a click and makes
this functionality a bit easier to find when editing files in a
subdirectory.

16 months agoImprovements for action detail page (#24718)
HesterG [Mon, 22 May 2023 04:17:24 +0000 (12:17 +0800)]
Improvements for action detail page (#24718)

Close #24625

Main changes:

1. For the left panel, show rerun icon only on hover, and add style when
the job is selected, and removed icon on the "rerun all" button and
modify the text on the button

https://github.com/go-gitea/gitea/assets/17645053/cc437a17-d2e9-4f1b-a8cf-f56e53962767

2. Adjust fonts, and add on hover effects to the log lines. And add
loading effect when the job is done and the job step log is expanded for
the first time. (With reference to github)

https://github.com/go-gitea/gitea/assets/17645053/2808d77d-f402-4fb0-8819-7aa0a018cf0c

3. Add `gt-ellipsis` to `step-summary-msg` and `job-brief-name`

<img width="898" alt="ellipsis"
src="https://github.com/go-gitea/gitea/assets/17645053/e2fb7049-3125-4252-970d-15b0751febc7">

4. Fixed
https://github.com/go-gitea/gitea/issues/24625#issuecomment-1541380010
by adding explicit conditions to `ActionRunStatus.vue` and `status.tmpl`

5. Adjust some css styles

---------

Co-authored-by: silverwind <me@silverwind.io>
16 months agoAdd CRAN package registry (#22331)
KN4CK3R [Mon, 22 May 2023 02:57:49 +0000 (04:57 +0200)]
Add CRAN package registry (#22331)

This PR adds a [CRAN](https://cran.r-project.org/) package registry.

![grafik](https://user-images.githubusercontent.com/1666336/210450039-d6fa6f77-20cd-4741-89a8-1624def267f7.png)

16 months agoFix regression: access log template, gitea manager cli command (#24838)
wxiaoguang [Mon, 22 May 2023 01:38:38 +0000 (09:38 +0800)]
Fix regression: access log template, gitea manager cli command (#24838)

Close #24836

![image](https://github.com/go-gitea/gitea/assets/2114189/95b025d2-f25f-4246-a08a-fe44ecb787a9)

![image](https://github.com/go-gitea/gitea/assets/2114189/c3afe1fa-2a23-420d-a016-3b67dcd04cd5)

16 months agoMerge message template support for rebase without merge commit (#22669)
Brecht Van Lommel [Mon, 22 May 2023 01:01:46 +0000 (03:01 +0200)]
Merge message template support for rebase without merge commit (#22669)

Use `default_merge_message/REBASE_TEMPLATE.md` for amending the message
of the last commit in the list of commits that was merged. Previously
this template was mentioned in the documentation but not actually used.

In this template additional variables `CommitTitle` and `CommitBody` are
available, for the title and body of the commit.

Ideally the message of every commit would be updated using the template,
but doing an interactive rebase or merging commits one by one is
complicated, so that is left as a future improvement.

16 months ago[skip ci] Updated licenses and gitignores
GiteaBot [Mon, 22 May 2023 00:25:26 +0000 (00:25 +0000)]
[skip ci] Updated licenses and gitignores

16 months agoSupport wildcard in email domain allow/block list (#24831)
wxiaoguang [Mon, 22 May 2023 00:05:44 +0000 (08:05 +0800)]
Support wildcard in email domain allow/block list (#24831)

Replace #20257 (which is stale and incomplete)

Close #20255

Major changes:

* Deprecate the "WHITELIST", use "ALLOWLIST"
* Add wildcard support for EMAIL_DOMAIN_ALLOWLIST/EMAIL_DOMAIN_BLOCKLIST
* Update example config file and document
* Improve tests

16 months agoChange `--font-weight-bold` to `--font-weight-semibold` and 600 value, introduce...
silverwind [Sun, 21 May 2023 23:37:32 +0000 (01:37 +0200)]
Change `--font-weight-bold` to `--font-weight-semibold` and 600 value, introduce new font weight variables (#24827)

There was some recent discussion about this in Discord `ui-design`
channel and the conclusion was that
https://github.com/go-gitea/gitea/issues/24305 should have fixed their
OS font installation to have semibold weights.

I have now tested this 601 weight on a Windows 10 machine on Firefox
myself, and I immediately noticed that bold was excessivly bold and
rendering as 700 because browsers are biased towards bolder fonts. So
revert this back to the previous value.

16 months agoRewrite logger system (#24726)
wxiaoguang [Sun, 21 May 2023 22:35:11 +0000 (06:35 +0800)]
Rewrite logger system (#24726)

## ⚠️ Breaking

The `log.<mode>.<logger>` style config has been dropped. If you used it,
please check the new config manual & app.example.ini to make your
instance output logs as expected.

Although many legacy options still work, it's encouraged to upgrade to
the new options.

The SMTP logger is deleted because SMTP is not suitable to collect logs.

If you have manually configured Gitea log options, please confirm the
logger system works as expected after upgrading.

## Description

Close #12082 and maybe more log-related issues, resolve some related
FIXMEs in old code (which seems unfixable before)

Just like rewriting queue #24505 : make code maintainable, clear legacy
bugs, and add the ability to support more writers (eg: JSON, structured
log)

There is a new document (with examples): `logging-config.en-us.md`

This PR is safer than the queue rewriting, because it's just for
logging, it won't break other logic.

## The old problems

The logging system is quite old and difficult to maintain:
* Unclear concepts: Logger, NamedLogger, MultiChannelledLogger,
SubLogger, EventLogger, WriterLogger etc
* Some code is diffuclt to konw whether it is right:
`log.DelNamedLogger("console")` vs `log.DelNamedLogger(log.DEFAULT)` vs
`log.DelLogger("console")`
* The old system heavily depends on ini config system, it's difficult to
create new logger for different purpose, and it's very fragile.
* The "color" trick is difficult to use and read, many colors are
unnecessary, and in the future structured log could help
* It's difficult to add other log formats, eg: JSON format
* The log outputer doesn't have full control of its goroutine, it's
difficult to make outputer have advanced behaviors
* The logs could be lost in some cases: eg: no Fatal error when using
CLI.
* Config options are passed by JSON, which is quite fragile.
* INI package makes the KEY in `[log]` section visible in `[log.sub1]`
and `[log.sub1.subA]`, this behavior is quite fragile and would cause
more unclear problems, and there is no strong requirement to support
`log.<mode>.<logger>` syntax.

## The new design

See `logger.go` for documents.

## Screenshot

<details>

![image](https://github.com/go-gitea/gitea/assets/2114189/4462d713-ba39-41f5-bb08-de912e67e1ff)

![image](https://github.com/go-gitea/gitea/assets/2114189/b188035e-f691-428b-8b2d-ff7b2199b2f9)

![image](https://github.com/go-gitea/gitea/assets/2114189/132e9745-1c3b-4e00-9e0d-15eaea495dee)

</details>

## TODO

* [x] add some new tests
* [x] fix some tests
* [x] test some sub-commands (manually ....)

---------

Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoSupport Copy Link for video attachments (#24833)
Brecht Van Lommel [Sun, 21 May 2023 22:06:17 +0000 (00:06 +0200)]
Support Copy Link for video attachments (#24833)

Creating a `<video>` tag with controls and title.

16 months agoFix video width overflow in markdown, and other changes to match img (#24834)
Brecht Van Lommel [Sun, 21 May 2023 21:19:37 +0000 (23:19 +0200)]
Fix video width overflow in markdown, and other changes to match img (#24834)

This change makes the CSS for `<video>` in markup match that of `<img>`,
and also allows additional attributes to be used. This way the width,
padding, alignment should work equally well for both.

16 months agoImprove accessibility when (re-)viewing files (#24817)
delvh [Sun, 21 May 2023 20:47:41 +0000 (22:47 +0200)]
Improve accessibility when (re-)viewing files (#24817)

Visually, nothing should have changed.
Changes include
- Convert most `<a [no href]>` to `<button>` when (re-)viewing files:
- `<a [no href]>` are, by HTML definition, not a link and hence cannot
be focused
- `<a class="ui button">` can now be clicked (again?) using
<kbd>Enter</kbd>
- Previously, the installed keypress handler on `.ui.button` elements
disabled it for links somehow
- The `(un)escape file`, the `expand section` and the `expand/collapse
file` buttons can now be focused (and subsequently clicked using only
the keyboard)
- You can now press <kbd>Space</kbd> on a focused `View file` checkbox
to mark the file as viewed.
- previously, this was impossible as this checkbox listened on the wrong
event listener

The `add code comment` button has been left inaccessible for now as it
requires quite a bit of extra logic so that it is unhidden when it is
focused (you can otherwise focus it without seeing it as you are not
hovering on the corresponding line).

---------

Co-authored-by: silverwind <me@silverwind.io>
16 months agoRefactor rename user and rename organization (#24052)
Lunny Xiao [Sun, 21 May 2023 15:13:47 +0000 (23:13 +0800)]
Refactor rename user and rename organization (#24052)

This PR is a refactor at the beginning. And now it did 4 things.
- [x] Move renaming organizaiton and user logics into services layer and
merged as one function
- [x] Support rename a user capitalization only. For example, rename the
user from `Lunny` to `lunny`. We just need to change one table `user`
and others should not be touched.
- [x] Before this PR, some renaming were missed like `agit`
- [x] Fix bug the API reutrned from `http.StatusNoContent` to `http.StatusOK`

16 months agoUse `CommentList` instead of `[]*Comment` (#24828)
Lunny Xiao [Sun, 21 May 2023 12:48:28 +0000 (20:48 +0800)]
Use `CommentList` instead of `[]*Comment` (#24828)

As title.

16 months agoFix topics deleted via API not being deleted in org page (#24825)
Yarden Shoham [Sun, 21 May 2023 09:03:20 +0000 (12:03 +0300)]
Fix topics deleted via API not being deleted in org page (#24825)

The topics are saved in the `repo_topic` table.
They are also saved directly in the `repository` table.

Before this PR, only `AddTopic` and `SaveTopics` made sure the `topics`
field in the `repository` table was synced with the `repo_topic` table.

This PR makes sure `GenerateTopics` and `DeleteTopic`
also sync the `topics` in the repository table.

`RemoveTopicsFromRepo` doesn't need to sync the data
as it is only used to delete a repository.

Fixes #24820

16 months agoReturn `404` in the API if the requested webhooks were not found (#24823)
Yevhen Pavlov [Sun, 21 May 2023 02:54:28 +0000 (05:54 +0300)]
Return `404` in the API if the requested webhooks were not found (#24823)

Should resolve first point of the issue
https://github.com/go-gitea/gitea/issues/24574

16 months agoDecouple the different contexts from each other (#24786)
wxiaoguang [Sun, 21 May 2023 01:50:53 +0000 (09:50 +0800)]
Decouple the different contexts from each other (#24786)

Replace #16455

Close #21803

Mixing different Gitea contexts together causes some problems:

1. Unable to respond proper content when error occurs, eg: Web should
respond HTML while API should respond JSON
2. Unclear dependency, eg: it's unclear when Context is used in
APIContext, which fields should be initialized, which methods are
necessary.

To make things clear, this PR introduces a Base context, it only
provides basic Req/Resp/Data features.

This PR mainly moves code. There are still many legacy problems and
TODOs in code, leave unrelated changes to future PRs.

16 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Sun, 21 May 2023 00:26:26 +0000 (00:26 +0000)]
[skip ci] Updated translations via Crowdin

16 months agoAdd RTL rendering support to Markdown (#24816)
silverwind [Sat, 20 May 2023 21:02:52 +0000 (23:02 +0200)]
Add RTL rendering support to Markdown (#24816)

Support RTL content in Markdown:

![image](https://github.com/go-gitea/gitea/assets/115237/dedb1b0c-2f05-40dc-931a-0d9dc81f7c97)

Example document:
https://try.gitea.io/silverwind/symlink-test/src/branch/master/bidi-text.md
Same on GitHub:
https://github.com/silverwind/symlink-test/blob/master/bidi-text.md

`dir=auto` enables a browser heuristic that sets the text direction
automatically. It is the only way to get automatic text direction.

Ref: https://codeberg.org/Codeberg/Community/issues/1021

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
16 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 20 May 2023 00:22:02 +0000 (00:22 +0000)]
[skip ci] Updated translations via Crowdin

16 months agoUpdate JS dependencies (#24815)
silverwind [Fri, 19 May 2023 21:58:12 +0000 (23:58 +0200)]
Update JS dependencies (#24815)

- Update all JS dependencies
- Remove `@vue/compiler-sfc` as per [this
notice](https://github.com/vuejs/core/tree/main/packages/compiler-sfc#vuecompiler-sfc),
still builds as normal
- Tested build and text/image copy

16 months agoFix duplicate tooltip hiding (#24814)
silverwind [Fri, 19 May 2023 20:12:30 +0000 (22:12 +0200)]
Fix duplicate tooltip hiding (#24814)

A tippy instance's role is actually on `props.role`. This makes
duplicate tooltip hiding work again after
https://github.com/go-gitea/gitea/pull/24688.

16 months agoMute repo names in dashboard repo list (#24811)
Yarden Shoham [Fri, 19 May 2023 17:03:09 +0000 (20:03 +0300)]
Mute repo names in dashboard repo list (#24811)

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/24b80212-4a4d-44a7-99d5-a8c6b207225e)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/565b242a-f65d-450c-b43b-c4539a0f8b28)

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoRework label colors (#24790)
silverwind [Fri, 19 May 2023 16:30:24 +0000 (18:30 +0200)]
Rework label colors (#24790)

Introduce `--color-label-fg`, `--color-label-bg` and
`--color-label-hover-bg`, decoupling the label styles from other color
variables. I've set the colors so that non-interactive labels like on
tabs are dark-on-light on light theme, which imho looks better than
previous light-on-dark.

In the screenshot below, the leftmost label has hover, the second one
has active.

<img width="786" alt="Screenshot 2023-05-18 at 12 48 26"
src="https://github.com/go-gitea/gitea/assets/115237/d989bb68-504a-4406-b5f6-419ed9609f90">
<img width="789" alt="Screenshot 2023-05-18 at 13 04 07"
src="https://github.com/go-gitea/gitea/assets/115237/689a281a-a2b7-45e8-a5ee-dafb7a35e105">

---------

Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoFix max width and margin of comment box on conversation page (#24809)
HesterG [Fri, 19 May 2023 16:02:34 +0000 (00:02 +0800)]
Fix max width and margin of comment box on conversation page (#24809)

Fix regression from #23937

The changes should only be limited to `.conversation-holder
.comment-code-cloud`, otherwise it will affect the `.comment-code-cloud`
in conversation tab

Before:

<img width="962" alt="Screen Shot 2023-05-19 at 18 22 25"
src="https://github.com/go-gitea/gitea/assets/17645053/0db01d04-2581-48f9-b46c-497836b1f12b">

After:

<img width="997" alt="Screen Shot 2023-05-19 at 18 35 01"
src="https://github.com/go-gitea/gitea/assets/17645053/5d14b67b-88c1-46c6-b859-fd41752b3ebb">

---------

Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoAllow all URL schemes in Markdown links by default (#24805)
Yarden Shoham [Fri, 19 May 2023 15:17:07 +0000 (18:17 +0300)]
Allow all URL schemes in Markdown links by default (#24805)

- Closes #21146
- Closes #16721

## :warning: BREAKING :warning:
This changes the default behavior to now create links for any URL scheme
when the user uses the markdown form for links (`[label](URL)`), this
doesn't affect the rendering of inline links. To opt-out set the
`markdown.CUSTOM_URL_SCHEMES` setting to a list of allowed schemes, all
other schemes (except `http` and `https`) won't be allowed.

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/35fa18ce-7dda-4995-b5b3-3f360f38296d)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/0922216b-0b35-4b77-9919-21a5c21dd5d0)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
16 months agoSome refactors for issues stats (#24793)
Lunny Xiao [Fri, 19 May 2023 14:17:48 +0000 (22:17 +0800)]
Some refactors for issues stats (#24793)

This PR

- [x] Move some functions from `issues.go` to `issue_stats.go` and
`issue_label.go`
- [x] Remove duplicated issue options `UserIssueStatsOption` to keep
only one `IssuesOptions`

16 months agoImplement actions artifacts (#22738)
FuXiaoHei [Fri, 19 May 2023 13:37:57 +0000 (21:37 +0800)]
Implement actions artifacts (#22738)

Implement action artifacts server api.

This change is used for supporting
https://github.com/actions/upload-artifact and
https://github.com/actions/download-artifact in gitea actions. It can
run sample workflow from doc
https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts.
The api design is inspired by
https://github.com/nektos/act/blob/master/pkg/artifacts/server.go and
includes some changes from gitea internal structs and methods.

Actions artifacts contains two parts:

- Gitea server api and storage (this pr implement basic design without
some complex cases supports)
- Runner communicate with gitea server api (in comming)

Old pr https://github.com/go-gitea/gitea/pull/22345 is outdated after
actions merged. I create new pr from main branch.

![897f7694-3e0f-4f7c-bb4b-9936624ead45](https://user-images.githubusercontent.com/2142787/219382371-eb3cf810-e4e0-456b-a8ff-aecc2b1a1032.jpeg)

Add artifacts list in actions workflow page.

16 months agoFix Actions being enabled accidentally (#24802)
Jason Song [Fri, 19 May 2023 11:35:12 +0000 (19:35 +0800)]
Fix Actions being enabled accidentally (#24802)

Regression of #24536. If the user doesn't explicitly disable Actions, it
will be enabled.

1. Gitea will call `loadRepositoryFrom` before `loadActionsFrom`.

https://github.com/go-gitea/gitea/blob/25d4f95df25dae5226e96e813dde87b071d9155e/modules/setting/setting.go#L234-L237
2. In `loadRepositoryFrom`,
`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` will set
`actions.ENABLED` with `true`.

https://github.com/go-gitea/gitea/blob/25d4f95df25dae5226e96e813dde87b071d9155e/modules/setting/repository.go#L313-L315
3. In `loadActionsFrom`, `rootCfg.Section("actions")` will get a section
with Actions enabled.

https://github.com/go-gitea/gitea/blob/25d4f95df25dae5226e96e813dde87b071d9155e/modules/setting/actions.go#L23-L26

Although the cause of the problem was using `true` by copy-paste
mistake, it also surprised me that
**`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` doesn't
only read, but also write.**

16 months agoChange `add_on` in `keys_ssh.tmpl` (#24803)
Zettat123 [Fri, 19 May 2023 09:20:18 +0000 (17:20 +0800)]
Change `add_on` in `keys_ssh.tmpl` (#24803)

Follow #24562

17 months agoreplace `drone exec` to `act_runner exec` in test README.md (#24791)
a1012112796 [Thu, 18 May 2023 19:48:47 +0000 (03:48 +0800)]
replace `drone exec` to `act_runner exec` in test README.md (#24791)

17 months agoFix OAuth loading state (#24788)
silverwind [Thu, 18 May 2023 11:50:11 +0000 (13:50 +0200)]
Fix OAuth loading state (#24788)

Fix regression from https://github.com/go-gitea/gitea/pull/24740 where
the loading state was not showing because the `oauth-login-image` class
was removed. Replaced the Fomantic loader with a pure CSS loader and
cleaned up the HTML.

Diff:
https://github.com/go-gitea/gitea/pull/24788/files?diff=unified&w=1

![](https://github.com/go-gitea/gitea/assets/115237/b5b4137f-9821-464b-9777-858fe85d9e03)

Co-authored-by: Giteabot <teabot@gitea.io>
17 months agoRemove duplicated issues options and some more refactors (#24787)
Lunny Xiao [Thu, 18 May 2023 10:45:25 +0000 (18:45 +0800)]
Remove duplicated issues options and some more refactors (#24787)

This PR

- [x] Move some code from `issue.go` to `issue_search.go` and
`issue_update.go`
- [x] Use `IssuesOptions` instead of `IssueStatsOptions` becuase they
are too similiar.
- [x] Rename some functions

17 months agoRevert "Mark `models/fixtures` as generated (#24775)" (#24782)
wxiaoguang [Thu, 18 May 2023 08:12:39 +0000 (16:12 +0800)]
Revert "Mark `models/fixtures` as generated (#24775)" (#24782)

They are not generated in some cases (although they can).

And we should keep an eye on these files when reviewing.

When reviewing, files can be marked as "Viewed" and then it is
collapsed.

17 months agoRemove background on user dashboard filter bar (#24779)
silverwind [Thu, 18 May 2023 07:27:29 +0000 (09:27 +0200)]
Remove background on user dashboard filter bar (#24779)

Was only an issue on arc-green:

### Before
<img width="313" alt="Screenshot 2023-05-17 at 23 33 15"
src="https://github.com/go-gitea/gitea/assets/115237/0f6916c6-c6c3-43c8-84cc-24b0a9800a43">

### After
<img width="310" alt="Screenshot 2023-05-17 at 23 32 52"
src="https://github.com/go-gitea/gitea/assets/115237/207d3d7f-ce6f-4170-b426-e743be760185">

Co-authored-by: Giteabot <teabot@gitea.io>
17 months agoEnable two vue eslint rules (#24780)
silverwind [Thu, 18 May 2023 02:00:34 +0000 (04:00 +0200)]
Enable two vue eslint rules (#24780)

These two rules are no longer violated, so we can enable them again.

17 months agoAdd two eslint plugins (#24776)
silverwind [Thu, 18 May 2023 01:14:31 +0000 (03:14 +0200)]
Add two eslint plugins (#24776)

Add these two plugins and autofix issues:

-
[eslint-plugin-no-use-extend-native](https://github.com/dustinspecker/eslint-plugin-no-use-extend-native)
-
[eslint-plugin-array-func](https://github.com/freaktechnik/eslint-plugin-array-func)

17 months agoMark `models/fixtures` as generated (#24775)
silverwind [Wed, 17 May 2023 20:59:12 +0000 (22:59 +0200)]
Mark `models/fixtures` as generated (#24775)

Makes diffs like https://github.com/go-gitea/gitea/pull/24676/files more
readable. I'm not sure if those are actually generated, but they are
good to collapse in diffs anyways.

17 months agoFix TestMinioStorageIterator skip message (#24765)
silverwind [Wed, 17 May 2023 16:22:17 +0000 (18:22 +0200)]
Fix TestMinioStorageIterator skip message (#24765)

Followup to https://github.com/go-gitea/gitea/pull/24762, fix this
message.

17 months agoFix missed table name on iterate lfs meta objects (#24768)
Lunny Xiao [Wed, 17 May 2023 15:51:22 +0000 (23:51 +0800)]
Fix missed table name on iterate lfs meta objects (#24768)

17 months agoRevert "Fix missed table name on iterate lfs meta objects" (#24764)
Yarden Shoham [Wed, 17 May 2023 13:20:11 +0000 (16:20 +0300)]
Revert "Fix missed table name on iterate lfs meta objects" (#24764)

This reverts commit 3364092013aa4d5d27ad02806b0f47967c04de18.

It was accidentally pushed to `main` without a review.

17 months agoMake the color of zero-contribution-squares in the activity heatmap more subtle ...
Evur [Wed, 17 May 2023 10:55:34 +0000 (12:55 +0200)]
Make the color of zero-contribution-squares in the activity heatmap more subtle (#24758)

The previous color had a too high contrast with the background.

---------

Co-authored-by: silverwind <me@silverwind.io>
17 months agoFix missed table name on iterate lfs meta objects
Lunny Xiao [Wed, 17 May 2023 10:26:43 +0000 (18:26 +0800)]
Fix missed table name on iterate lfs meta objects

17 months agoSkip TestMinioStorageIterator on CI (#24762)
Lunny Xiao [Wed, 17 May 2023 10:00:58 +0000 (18:00 +0800)]
Skip TestMinioStorageIterator on CI (#24762)

Fix https://github.com/go-gitea/gitea/pull/24691#issuecomment-1550987681

---------

Co-authored-by: silverwind <me@silverwind.io>
17 months agoSupport no label/assignee filter and batch clearing labels/assignees (#24707)
Lunny Xiao [Wed, 17 May 2023 09:21:35 +0000 (17:21 +0800)]
Support no label/assignee filter and batch clearing labels/assignees (#24707)

Since milestones has been implemented, this PR will fix #3407

---------

Co-authored-by: Jason Song <i@wolfogre.com>
17 months agoSupport for status check pattern (#24633)
Zettat123 [Wed, 17 May 2023 08:11:13 +0000 (16:11 +0800)]
Support for status check pattern (#24633)

This PR is to allow users to specify status checks by patterns. Users
can enter patterns in the "Status Check Pattern" `textarea` to match
status checks and each line specifies a pattern. If "Status Check" is
enabled, patterns cannot be empty and user must enter at least one
pattern.
Users will no longer be able to choose status checks from the table. But
a __*`Matched`*__ mark will be added to the matched checks to help users
enter patterns.

Benefits:
- Even if no status checks have been completed, users can specify
necessary status checks in advance.
- More flexible. Users can specify a series of status checks by one
pattern.

Before:

![image](https://github.com/go-gitea/gitea/assets/15528715/635738ad-580c-49cd-941d-c721e5b99be4)

After:

![image](https://github.com/go-gitea/gitea/assets/15528715/16aa7b1b-abf1-4170-9bfa-ae6fc9803a82)

---------

Co-authored-by: silverwind <me@silverwind.io>
17 months agoUpdates to doc (#24757)
Alejandro Leal [Wed, 17 May 2023 05:45:26 +0000 (01:45 -0400)]
Updates to doc (#24757)

## Misspelling fixes to:
- docs/content/doc/administration/config-cheat-sheet.en-us.md
- docs/content/doc/installation/from-source.en-us.md
- docs/content/doc/usage/packages/cargo.en-us.md
- docs/content/doc/usage/packages/storage.en-us.md

---------

Co-authored-by: delvh <dev.lh@web.de>
17 months agoIgnore build for docs only (#24761)
Lunny Xiao [Wed, 17 May 2023 05:42:08 +0000 (13:42 +0800)]
Ignore build for docs only (#24761)

Fix https://github.com/go-gitea/gitea/pull/24530#issuecomment-1550227919

17 months agoFix team members API endpoint pagination (#24754)
Yarden Shoham [Wed, 17 May 2023 00:12:37 +0000 (03:12 +0300)]
Fix team members API endpoint pagination (#24754)

Now it's 1-based instead of 0-based

- Fixes #24747

### Before

![image](https://github.com/go-gitea/gitea/assets/20454870/9b58ecfa-666c-4b78-bd0f-93233efeecbd)

### After

![image](https://github.com/go-gitea/gitea/assets/20454870/103b767a-e02e-4473-9f9f-5a676a61c174)

## :warning: BREAKING :warning:
Previous API consumers may have relied on the 0-based pagination of this
endpoint. The page numbering now starts at 1, as documented.

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
17 months agoMake mailer SMTP check have timed context (#24751)
wxiaoguang [Tue, 16 May 2023 20:55:51 +0000 (04:55 +0800)]
Make mailer SMTP check have timed context (#24751)

Make mailer SMTP check have timed context

Otherwise Gitea may block for long time if the DNS request blocks.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
17 months agoAdd @garymoon to MAINTAINERS (#24752)
Gary Moon [Tue, 16 May 2023 15:46:46 +0000 (11:46 -0400)]
Add @garymoon to MAINTAINERS (#24752)

Hi all.

I would like to apply to be a maintainer please. I have [four accepted
PRs](https://github.com/go-gitea/gitea/pulls?q=is%3Apr+author%3Agarymoon)
(such as they are), sign my commits, and have MFA enabled everywhere. My
hope is to continue with code contributions where I can (I'm not a
developer, just a wannabe), take some work off kdumont's hands, and
contribute on the infrastructure side where there is room 💚 :tea:

Thank you!

17 months agoSkip TestRepoCommitsStatusParallel on CI (#24741)
silverwind [Tue, 16 May 2023 12:42:16 +0000 (14:42 +0200)]
Skip TestRepoCommitsStatusParallel on CI (#24741)

Related: https://github.com/go-gitea/gitea/issues/22109

Co-authored-by: Giteabot <teabot@gitea.io>
17 months agoRespect original content when creating secrets (#24745)
Jason Song [Tue, 16 May 2023 06:49:40 +0000 (14:49 +0800)]
Respect original content when creating secrets (#24745)

Fix #24721.

Follow what GitHub does:
- Don't trim spaces for secrets.
- Newline should be `\n` instead of `\r\n`.

Did some tests with:

```yaml
name: secrets
on: push
jobs:
  show_secrets:
    runs-on: ubuntu-latest
    steps:
      - name: Dump secrets context
        run: echo '${{ toJSON(secrets) }}' | base64
```

`AAAAAA`:
```text
   AAAAAA
AAAAAA

```
`BBBBBB`:
```text

BBBBBB
BBBBBB
```

On GitHub:

<img width="675" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0ec60652-c2a3-47bb-9f9d-7e81665355a8">

On Gitea (before):

<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/cce818bf-5edc-4656-86e1-2c81c304cdb2">

On Gitea (after):

<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0b3b15af-4d48-4bab-a334-4738a1b0eb4a">

17 months agoRemove meta charset from HTML5 documents (#24744)
silverwind [Tue, 16 May 2023 05:13:23 +0000 (07:13 +0200)]
Remove meta charset from HTML5 documents (#24744)

When `<!DOCTYPE html>` is present, the default (and only valid) charset
it `utf-8` so it does not need to be specified.

Also we do serve with HTML with `Content-Type: text/html;
charset=utf-8`, so it is duplicate info anyways.

17 months agoFix WEBP image copying (#24743)
silverwind [Tue, 16 May 2023 04:45:36 +0000 (06:45 +0200)]
Fix WEBP image copying (#24743)

Fix regression from https://github.com/go-gitea/gitea/pull/23801, where
I forgot that the new module will not throw, so the `catch` handlers
were never triggered and in turn, the WEBP was not converted to PNG.

17 months agoReorganize CSS files (#24739)
silverwind [Tue, 16 May 2023 04:13:30 +0000 (06:13 +0200)]
Reorganize CSS files (#24739)

Reorganize various CSS files for clarity, group together by subdirectory
in `index.css`. This reorders some of the rules, but I don't think it
should introduce any issues because of that.

17 months agoDon't run build and test if only docs changed (#24530)
Lunny Xiao [Tue, 16 May 2023 02:53:18 +0000 (10:53 +0800)]
Don't run build and test if only docs changed (#24530)

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
17 months ago[skip ci] Updated translations via Crowdin
GiteaBot [Tue, 16 May 2023 00:23:56 +0000 (00:23 +0000)]
[skip ci] Updated translations via Crowdin

17 months agoRework Oauth login buttons, swap github logo to monocolor (#24740)
silverwind [Mon, 15 May 2023 22:46:51 +0000 (00:46 +0200)]
Rework Oauth login buttons, swap github logo to monocolor (#24740)

Diff without whitespace:
https://github.com/go-gitea/gitea/pull/24740/files?diff=unified&w=1

- Use SVGs for GitHub and GitLab oauth providers
- Replace section wrapping with a divider
- Rework icon rendering, increase size from 32px to 40px

Before:

<img width="853" alt="Screenshot 2023-05-15 at 21 54 23"
src="https://github.com/go-gitea/gitea/assets/115237/6ab5cfb4-46ff-469a-bd1f-06780d4a6a0b">

After (more providers):

<img width="849" alt="Screenshot 2023-05-15 at 21 51 21"
src="https://github.com/go-gitea/gitea/assets/115237/fa84f92f-98e0-4aed-9357-5d62ddd98195">

<img width="856" alt="Screenshot 2023-05-15 at 21 56 45"
src="https://github.com/go-gitea/gitea/assets/115237/d3edd7ed-dadd-4302-aca7-08f20adc220e">

Ref: https://codeberg.org/Codeberg/Community/issues/1023

---------

Co-authored-by: Giteabot <teabot@gitea.io>
17 months agoImplement systemd-notify protocol (#21151)
zeripath [Mon, 15 May 2023 22:20:30 +0000 (23:20 +0100)]
Implement systemd-notify protocol (#21151)

This PR adds support for the systemd notify protocol. Several status
messagess are provided. We should likely add a common notify/status
message for graceful.

Replaces #21140

Signed-off-by: Andrew Thornton <art27@cantab.net>
---------

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: ltdk <usr@ltdk.xyz>
Co-authored-by: Giteabot <teabot@gitea.io>
17 months agoBump vm2 from 3.9.17 to 3.9.18 (#24742)
dependabot[bot] [Mon, 15 May 2023 21:55:56 +0000 (23:55 +0200)]
Bump vm2 from 3.9.17 to 3.9.18 (#24742)

Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.17 to 3.9.18.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/patriksimek/vm2/releases">vm2's
releases</a>.</em></p>
<blockquote>
<h2>3.9.18</h2>
<p><strong>New Features</strong></p>
<p><a
href="https://github.com/patriksimek/vm2/commit/dd81ff616ff528de5dc7a1cf2939de3d3701539d">https://github.com/patriksimek/vm2/commit/dd81ff616ff528de5dc7a1cf2939de3d3701539d</a>:
Add resolver API to create a shared resolver for multiple
<code>NodeVM</code> instances allowing to cache scripts and increase
sandbox startup times.
<a
href="https://github.com/patriksimek/vm2/commit/4d662e34d369b920943eee139ef60fb557666a43">https://github.com/patriksimek/vm2/commit/4d662e34d369b920943eee139ef60fb557666a43</a>:
Allow to pass a function to <code>require.context</code> which is called
with the filename allowing to specify the context pre file. (Thanks to
<a
href="https://github.com/blakebyrnes"><code>@​blakebyrnes</code></a>)</p>
<p><strong>Fixes</strong></p>
<p><a
href="https://github.com/patriksimek/vm2/commit/d88105f99752305c5b8a77b63ddee3ec86912daf">https://github.com/patriksimek/vm2/commit/d88105f99752305c5b8a77b63ddee3ec86912daf</a>:
Fix issue leaking host array through <code>Proxy</code>. (Thanks to <a
href="https://github.com/arkark"><code>@​arkark</code></a> (Takeshi
Kaneko) of GMO Cybersecurity by Ierae, Inc.)
<a
href="https://github.com/patriksimek/vm2/commit/5206ba25afd86ef547a2c9d48d46ca7a9e6ec238">https://github.com/patriksimek/vm2/commit/5206ba25afd86ef547a2c9d48d46ca7a9e6ec238</a>:
Fix issue with <code>inspect</code> being writeable. (Thanks to <a
href="https://github.com/arkark"><code>@​arkark</code></a> (Takeshi
Kaneko) of GMO Cybersecurity by Ierae, Inc.)</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md">vm2's
changelog</a>.</em></p>
<blockquote>
<h2>v3.9.18 (2023-05-15)</h2>
<p>[fix] Multiple security fixes.
[new] Add resolver API to create a shared resolver for multiple
<code>NodeVM</code> instances allowing to cache scripts and increase
sandbox startup times.
[new] Allow to pass a function to <code>require.context</code> which is
called with the filename allowing to specify the context pre file.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/patriksimek/vm2/commit/2f446e5d19e6539b5164b45b1f8bd4ded4dfc085"><code>2f446e5</code></a>
Release 3.9.18</li>
<li><a
href="https://github.com/patriksimek/vm2/commit/587bb1337da2dd78c166f35e6459cce28940d9bf"><code>587bb13</code></a>
Add tests for past vulnerabilities</li>
<li><a
href="https://github.com/patriksimek/vm2/commit/f5a129af752150293f2c2bb58d18a8098a93be93"><code>f5a129a</code></a>
Merge branch 'master' of <a
href="https://github.com/patriksimek/vm2">https://github.com/patriksimek/vm2</a></li>
<li><a
href="https://github.com/patriksimek/vm2/commit/dd81ff616ff528de5dc7a1cf2939de3d3701539d"><code>dd81ff6</code></a>
Merge pull request <a
href="https://redirect.github.com/patriksimek/vm2/issues/519">#519</a>
from XmiliaH/resolver-api</li>
<li><a
href="https://github.com/patriksimek/vm2/commit/af983a8a1eb397c1b955709348f1e812e465db99"><code>af983a8</code></a>
Merge remote-tracking branch 'upstream/master' into resolver-api</li>
<li><a
href="https://github.com/patriksimek/vm2/commit/5206ba25afd86ef547a2c9d48d46ca7a9e6ec238"><code>5206ba2</code></a>
Inspect method should be readonly</li>
<li><a
href="https://github.com/patriksimek/vm2/commit/d88105f99752305c5b8a77b63ddee3ec86912daf"><code>d88105f</code></a>
Ensure host array does not leak through proxy</li>
<li><a
href="https://github.com/patriksimek/vm2/commit/4d662e34d369b920943eee139ef60fb557666a43"><code>4d662e3</code></a>
Merge pull request <a
href="https://redirect.github.com/patriksimek/vm2/issues/521">#521</a>
from ulixee/pathContext</li>
<li><a
href="https://github.com/patriksimek/vm2/commit/1728bdf8d2e59c74264396948394f005e3f9a431"><code>1728bdf</code></a>
chore: simplify default function for path context</li>
<li><a
href="https://github.com/patriksimek/vm2/commit/7d16a56fa5076f8be662ddb04e435bd71802592e"><code>7d16a56</code></a>
Merge branch 'patriksimek:master' into pathContext</li>
<li>Additional commits viewable in <a
href="https://github.com/patriksimek/vm2/compare/3.9.17...3.9.18">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=vm2&package-manager=npm_and_yarn&previous-version=3.9.17&new-version=3.9.18)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/go-gitea/gitea/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
17 months agoRefactor Pull Mirror and fix out-of-sync bugs (#24732)
wxiaoguang [Mon, 15 May 2023 19:02:10 +0000 (03:02 +0800)]
Refactor Pull Mirror and fix out-of-sync bugs (#24732)

The "mirror" table and "repository" table might be out-of-sync in some
cases.

It means that "IsMirror=true" but "Mirror=nil"

This PR removes unnecessary "Mirror" field, rename "Mirror" to
"PullMirror" and fix nil panic bug.

Screenshot of changed templates:

![image](https://github.com/go-gitea/gitea/assets/2114189/c0f2bdfc-5911-43ea-b989-b19619de4235)

![image](https://github.com/go-gitea/gitea/assets/2114189/1078b41a-484f-4c06-8c2f-edb9e658275d)

17 months agoUnification of registration fields order (#24737)
Yevhen Pavlov [Mon, 15 May 2023 18:29:39 +0000 (21:29 +0300)]
Unification of registration fields order (#24737)

Place email filed in same order on all user creation pages.

Registration on installation page (before):

![image](https://github.com/go-gitea/gitea/assets/1969460/b0e6c8e5-4f6f-4225-b365-946036aa6490)

Registration on main page:

![image](https://github.com/go-gitea/gitea/assets/1969460/8bd43ab7-e706-4088-8f64-a61ca5c90d1b)

Create user account on site administration page:

![image](https://github.com/go-gitea/gitea/assets/1969460/ab0a90c4-748d-43aa-b267-432d529888f0)

Registration on installation page (after):

![image](https://github.com/go-gitea/gitea/assets/1969460/1f5e29c2-988c-46d2-960b-11b12789d7a7)

17 months agoSwitch to `@eslint-community/eslint-comments` (#24736)
silverwind [Mon, 15 May 2023 17:29:23 +0000 (19:29 +0200)]
Switch to `@eslint-community/eslint-comments` (#24736)

[eslint-plugin-eslint-comments](https://github.com/mysticatea/eslint-plugin-eslint-comments)
is unmaintained, switch to the community fork.

See
https://github.com/mysticatea/eslint-plugin-eslint-comments/issues/72
for discussion.

17 months agoDocs for creating a user to run Gitea on Fedora/RHEL/CentOS (#24725)
Jason Song [Mon, 15 May 2023 15:03:38 +0000 (23:03 +0800)]
Docs for creating a user to run Gitea on Fedora/RHEL/CentOS (#24725)

The current command doesn't work on Fedora/RHEL/CentOS.

- `--gecos`: use `--comment` instead.
- `--group`: use `--gid` instead, `--group` means "A list of
supplementary groups" on F/R/C.
- `--disabled-password`: leave `--password` empty instead, "The default
is to disable the password".
- `--home`: use `--home-dir` and `--create-home` instead.

17 months agoUpdate packages overview page (#24730)
Yevhen Pavlov [Mon, 15 May 2023 10:53:50 +0000 (13:53 +0300)]
Update packages overview page (#24730)

Add missed Go package reference to packages overview page

17 months agoMove actions as usage's subdirectory and update comparsion zh-cn version (#24719)
Lunny Xiao [Mon, 15 May 2023 07:36:20 +0000 (15:36 +0800)]
Move actions as usage's subdirectory and update comparsion zh-cn version (#24719)

As title.

Co-authored-by: Giteabot <teabot@gitea.io>
17 months agoDocument `redis-cluster` explicitly in config (#24717) 24404/head
Patrick Schratz [Mon, 15 May 2023 05:45:48 +0000 (07:45 +0200)]
Document `redis-cluster` explicitly in config (#24717)

Co-authored-by: delvh <dev.lh@web.de>
17 months agoDon't filter action runs based on state (#24711)
Yarden Shoham [Sun, 14 May 2023 16:04:24 +0000 (19:04 +0300)]
Don't filter action runs based on state (#24711)

We should just show all runs. This removes the filtering altogether.

- Replaces https://github.com/go-gitea/gitea/pull/24553

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/be4fb69a-ea84-44bb-9606-65a0626be721)

![image](https://github.com/go-gitea/gitea/assets/20454870/68942224-e519-43f1-87fe-f3cffef5879a)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/b3c3b200-ad44-4163-86ec-44a76362eae6)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
17 months agoAdd Go package registry (#24687)
KN4CK3R [Sun, 14 May 2023 15:38:40 +0000 (17:38 +0200)]
Add Go package registry (#24687)

Fixes #7608

This PR adds a Go package registry usable with the Go proxy protocol.

![grafik](https://github.com/go-gitea/gitea/assets/1666336/328feb5c-3df2-4f9d-8eae-fe3126d14c37)

17 months agoFix flash of unstyled content in action view page (#24712)
Yarden Shoham [Sun, 14 May 2023 14:58:59 +0000 (17:58 +0300)]
Fix flash of unstyled content in action view page (#24712)

# Before

![rec](https://github.com/go-gitea/gitea/assets/20454870/32f8e521-f743-4101-bd3c-923fd5abd893)

# After

![rec](https://github.com/go-gitea/gitea/assets/20454870/070721d1-6749-43c1-ac18-d8c58e5f0901)

Ref: https://github.com/go-gitea/gitea/issues/24625

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
17 months agoClean up various avatar dimensions (#24701)
silverwind [Sun, 14 May 2023 14:15:59 +0000 (16:15 +0200)]
Clean up various avatar dimensions (#24701)

Clean up a few cases where avatar dimensions were overwritten via CSS,
which were no longer needed or were possible to set via HTML width.

Also included are two small fixes:

- Fix one more case of incorrect avatar offset on review timeline
- Vertically center avatars in review sidebar

There is more to be done here, but some of the work depends on Fomantic
`comment` module removal, or in the case of org member lists, a refactor
of the `avatarlink` template to accept a size.

<img width="371" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/9c5902fb-2b89-4a7d-a152-60e74c3b2c56">
<img width="306" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/c8d92e2a-91c9-4f4a-a7de-6ae1a6bc0479">

---------

Co-authored-by: Giteabot <teabot@gitea.io>
17 months agoRemove the parallelizing when loading repo for dashboard (#24705)
wxiaoguang [Sun, 14 May 2023 13:45:47 +0000 (21:45 +0800)]
Remove the parallelizing when loading repo for dashboard (#24705)

Ref: #24638

IMO, parallelizing might run out server resources more quickly. Gitea
shouldn't use a lot of go-routine in a web handler.

And add a comment about how many repositories there could be at most.

Co-authored-by: Yarden Shoham <git@yardenshoham.com>