]> source.dussan.org Git - vaadin-framework.git/log
vaadin-framework.git
10 years agoUse dashes instead of underscore in function names
Henri Sara [Wed, 25 Jun 2014 08:36:50 +0000 (11:36 +0300)]
Use dashes instead of underscore in function names

Change-Id: I3dd08e39b519d1bdac8e2e4a1c4c5ae05c517ae0

10 years agoUpdate ValoThemeTest
Jouni Koivuviita [Fri, 13 Jun 2014 14:21:21 +0000 (17:21 +0300)]
Update ValoThemeTest

New tab sheet test with more flexibility in testing all the different
combinations of styles.

Test slider min-max ranges with the “ticks” style.

Change-Id: Id64f28f79fc7c660948519dea85110516966093f

10 years agoAdded a new "framed" tab sheet style for Valo
Jouni Koivuviita [Fri, 13 Jun 2014 14:19:43 +0000 (17:19 +0300)]
Added a new "framed" tab sheet style for Valo

Renamed the tab sheet mixins also to follow the convensions.

TabSheet now also has a “loading” state when the tab content takes a
little longer to render on the server.

Change-Id: I77a3508e2009c780347ca61a82b8a1d3458d92b4

10 years agoFix spinner mixin for IE8 and IE9
Jouni Koivuviita [Fri, 13 Jun 2014 08:49:43 +0000 (11:49 +0300)]
Fix spinner mixin for IE8 and IE9

Fixes indeterminate ProgressBar style as well (using the spinner mixin).

Change-Id: I35729e465e2249515fc4668167b1d18aa3783a97

10 years agoFix notification default delay
Jouni Koivuviita [Fri, 13 Jun 2014 08:18:54 +0000 (11:18 +0300)]
Fix notification default delay

The default hiding delay should be 0ms instead of 1000ms, according to
the server side class at least.

Change-Id: I064c01b2fdc9df4cbcbd74def8e494add22ee749

10 years agoFix VOverlay animation-out jitter
Jouni Koivuviita [Fri, 13 Jun 2014 07:23:19 +0000 (10:23 +0300)]
Fix VOverlay animation-out jitter

An improper fix to an issue with the closing animation that was left
there mistakenly.

Change-Id: I645c6983058fb128cf060a3c7bb2766cb47e3a81

10 years agoUpdate ValoThemeTest with a few new styles
Jouni Koivuviita [Thu, 12 Jun 2014 12:53:58 +0000 (15:53 +0300)]
Update ValoThemeTest with a few new styles

Change-Id: Icfc9a960d7d022ec5394be2853f80775be41549d

10 years agoVarious fixes and tweaks to Valo
Jouni Koivuviita [Thu, 12 Jun 2014 12:53:06 +0000 (15:53 +0300)]
Various fixes and tweaks to Valo

- Added a new “quiet” style button, and an “icon-align-top” style, and
added an additional parameter for the borderless button style

- PopupView now has a proper animation-in and animation-out, with a
spinner showing the loading state

- Small fix to slider minimum size

- Fixed TextField text centering for IE8 and IE9

- Fixed Tree expand/collapse arrow clicking in IE10

- Tweaked Window shadow and modality curtain style

Change-Id: I48dab61c648363b8eb0c03dc3b3cbbc1289b94ed

10 years agoFix overlay animation-in/out for VNotification and PopupView
Jouni Koivuviita [Thu, 12 Jun 2014 12:44:14 +0000 (15:44 +0300)]
Fix overlay animation-in/out for VNotification and PopupView

- Notification delay now applied to browsers without CSS animation
support

- PopupView now also supports animation-in and animation-out, and also
shows the “loading” widget when the popup is opened and the server
response takes a little longer. The popupComponentWidget is also kept
in the popup during the animation-out

Change-Id: Idb26d87a8cf75cfa3e145ea670dacc1c87ce75d6

10 years agoMultiple fixes to Valo theme
Jouni Koivuviita [Tue, 10 Jun 2014 19:53:58 +0000 (22:53 +0300)]
Multiple fixes to Valo theme

- Added initial Sass API for Accordion and TabSheet (previously only
one mixin)

- Renamed ‘darker-of’ function to ‘darkest-color’, which now supports
more than two colors

- Refactored notifications to use the new position classes as well as
the new animation-in/out functionality

- Refactored overlay styles to use animation-in/out functionality

- Fixed all unwanted white-space and scrollbar issues in all browsers
(font-size:0 or line-height:0 no longer necessary), and fixes vertical
centering in horizontal layout (#13671)

- Fixed borderless menubar clicking bug (Firefox and Opera)

- Fixed table column selector, which no longer produces scrollbars if
placed directly inside a scrollable area in full size

- Fixed table outline overflow in Opera (now using box-shadow instead
in all other browsers except IE8)

- Added toolbar support for windows (header and footer)

- Moved optional notification styles to common-stylenames.scss

-Various other small tweaks

Change-Id: I42343199be12f6d909b9584b7dce3e258846da81

10 years agoUpdate Valo theme test application
Jouni Koivuviita [Tue, 10 Jun 2014 19:38:11 +0000 (22:38 +0300)]
Update Valo theme test application

- Add DragAndDropWrapper examples
- Improve Window example with toolbar support

Change-Id: I1d6dc7d5e7449bd479f3510d9cbf1fda3cccddd6

10 years agoFix multiple VOverlay animation-in/out related issues
Jouni Koivuviita [Tue, 10 Jun 2014 19:34:59 +0000 (22:34 +0300)]
Fix multiple VOverlay animation-in/out related issues

Any running animation-in is now finished before animation-out is
triggered.

Moved windowClone variable into WindowConnector where it should be.

Change-Id: I0ee733d05558d46a08e5e46f821104ad98783118

10 years agoRemove FontAwesome files from Valo (use directly from Base)
Jouni Koivuviita [Tue, 10 Jun 2014 19:26:06 +0000 (22:26 +0300)]
Remove FontAwesome files from Valo (use directly from Base)

Deprecate ‘font’ mixin in favor of ‘v-font’. The deprecated mixin will
print a warning message to the console.

Change-Id: I28ae1d39606c2c6ff7bee2e8cc811acf7e2479a2

10 years agoNotification position should be controllable with CSS (#13990)
Jouni Koivuviita [Mon, 9 Jun 2014 10:22:25 +0000 (13:22 +0300)]
Notification position should be controllable with CSS (#13990)

Change-Id: Ic04f97d00745c2b7d1b4c143b2a458ab47188fd2

10 years agoMerge branch 'master' into valo
Jouni Koivuviita [Mon, 16 Jun 2014 07:29:28 +0000 (10:29 +0300)]
Merge branch 'master' into valo

Conflicts:
build.properties

Change-Id: I2477f2b420506d1b41d29d9bb1e361d66bedb68d

10 years agoRefactored Layout tests. Remove errors (#13823)
Dmitrii Rogozin [Tue, 3 Jun 2014 11:51:42 +0000 (14:51 +0300)]
Refactored Layout tests. Remove errors (#13823)

Split tests into separate classes. Create hierarcy for tests.

Change-Id: I71e20a5410612f9a246bab051173e60768532185

10 years agoTweak quick setup instructions (#13616)
Leif Åstrand [Fri, 13 Jun 2014 09:40:51 +0000 (12:40 +0300)]
Tweak quick setup instructions (#13616)

- Change the order to install IvyDE before importing the project
- Explicitly mention the Ant tasks since it's such a common mistake

Change-Id: I1a9edc39f72c5fd4b31cdfe3db9b4fa87d6d8cf2

10 years agoUse more exact paths for ivysettings.xml and build.properties (#13616)
Leif Åstrand [Fri, 13 Jun 2014 06:44:54 +0000 (09:44 +0300)]
Use more exact paths for ivysettings.xml and build.properties (#13616)

Defining the paths to be relative to the workspace is needed for
compatibility with older versions of IvyDE / Eclipse. All other
dependencies are already defined in this way, it's only this new gwt
dependency that isn't consistent with the others.

Change-Id: Iad976566fc7927745fe5534951be1f476c810ff5

10 years agoEasier instructions thanks to GWT dependency (#13616)
Artur Signell [Thu, 12 Jun 2014 18:39:31 +0000 (21:39 +0300)]
Easier instructions thanks to GWT dependency (#13616)

Change-Id: I42034e50e314c13282614d5a7ab64368daca1b31

10 years agoUse GWT as maven dependency (#13616)
Sauli Tähkäpää [Tue, 6 May 2014 11:28:29 +0000 (14:28 +0300)]
Use GWT as maven dependency (#13616)

Change-Id: I283820c7dcca7ecd341949bb15275406fe378902

10 years agoRevert "Fix for 'Aborting layout after 100 passess' (#13359)"
Sauli Tähkäpää [Thu, 12 Jun 2014 10:55:12 +0000 (13:55 +0300)]
Revert "Fix for 'Aborting layout after 100 passess' (#13359)"

Causes regression with IE8:
http://r2d2.devnet.vaadin.com:8111/viewLog.html?buildTypeId=Vaadin72_Vaadin72DevelopmentBuildTb2Tests&buildId=86020

Change-Id: I6d848777b28a1d3f27a25fec778cba8d68a45690

10 years agoFix for handling selectors with both width and height ranges (#13587)
Teemu Pöntelin [Tue, 3 Jun 2014 18:00:48 +0000 (21:00 +0300)]
Fix for handling selectors with both width and height ranges (#13587)

This fix splits the used regular expressions into a more manageable
parts while fixing the handling of a case where both width-range and
height-range are defined. Also refactored some duplicate code into
a helper function.

Change-Id: I98295b8b0772b33a9985c0630e065eea2281d11d

10 years agoFix tooltip test problems caused by #12458
Henri Sara [Mon, 24 Mar 2014 14:32:20 +0000 (16:32 +0200)]
Fix tooltip test problems caused by #12458

Tooltips are no longer removed but moved outside the viewport,
which broke several tests.

Rewrite related tests using TB4 to be stable across all
browsers. There are differences between browsers (e.g.
position -999 or -1000, gwt-uid-* varied between browsers
etc.) so TB2 tests kept failing on some or all browsers.

Some tests have been renamed to better indicate what they
do.

Change-Id: Ia7276871f3c26d506dc70e1719347d020b547bfc

10 years agoMake tooltips stationary when hovering (#13981)
Juuso Valli [Fri, 6 Jun 2014 09:55:56 +0000 (12:55 +0300)]
Make tooltips stationary when hovering (#13981)

Change-Id: I44acce87ea5c37d7b210e6c6c3dd9cd511192524

10 years agoRemoves double spacing from gridLayout which has empty rows or columns (#8855)
Dmitrii Rogozin [Thu, 22 May 2014 11:04:48 +0000 (14:04 +0300)]
Removes double spacing from gridLayout which has empty rows or columns (#8855)

If row has no elements or only invisible elements, its size will be set to zero.

 When row expand ratio was set, its size will be assigned to the value according to an expand ratio.

If component takes several rows of the gridLayout, these rows are considered as non-empty and won't be removed.

Change-Id: I10ddd22a6c9535b9978769bab7b496e11a28b78a

10 years agoAdd scrollbars to ComboBox suggestion popup if low on screen estate (#11929)
Antti Tanhuanpää [Wed, 4 Jun 2014 14:10:17 +0000 (17:10 +0300)]
Add scrollbars to ComboBox suggestion popup if low on screen estate (#11929)

Change-Id: I8563f1e2cfc66ca89399590401fd77ec67e50e82

10 years agoAssigning both primary style and style name is now handled correctly (#12190)
Teemu Pöntelin [Tue, 10 Jun 2014 21:20:41 +0000 (00:20 +0300)]
Assigning both primary style and style name is now handled correctly (#12190)

Change-Id: Iceba6be78a49bc1aacf837b9fcd9790749be01c0

10 years agoAllow inlining of JsonCodec#encode (#13814)
Fabian Lange [Thu, 22 May 2014 22:36:56 +0000 (00:36 +0200)]
Allow inlining of JsonCodec#encode (#13814)

JsonCodec#encode() is a frequently called (hot) method. However in its
current form it is too long to be inlined.

This review reduces the length of the method from 454 bytes instructions
to 311 and optimises flow of common calls.

It however has a behaviour change for esoteric edge cases where the
order would matter. Like a custom collection which extends JSONArray and
implements collection. Previously it would have been handled by the
collection case, now its the JSONArray case. However it can be assumed
that the result: serialized to valid JSON is the same.

Change-Id: Ia552eec6322d0760581336b8b038fa03761c1d69

10 years agoFix tooltip positioning near screen edges (#12870)
Juuso Valli [Mon, 2 Jun 2014 15:46:07 +0000 (18:46 +0300)]
Fix tooltip positioning near screen edges (#12870)

Change-Id: I3f5244565dd393e9fcb7386d352f835b5afd9faa

10 years agoPrevent tooltip open if cursor leaves element (#13695)
Juuso Valli [Fri, 6 Jun 2014 08:40:18 +0000 (11:40 +0300)]
Prevent tooltip open if cursor leaves element (#13695)

Change-Id: I81b1955aba56207cb63d78113f698c0ae65a599b

10 years agoMoved initialization of a static map to the static initialization block (#12270)
Teemu Pöntelin [Sat, 31 May 2014 11:37:49 +0000 (14:37 +0300)]
Moved initialization of a static map to the static initialization block (#12270)

Change-Id: I82c77edf5c17c712350cb64831b305b4c8363cf7

10 years agoUse Sass Compiler version 0.9.6
Henri Sara [Fri, 6 Jun 2014 06:59:29 +0000 (09:59 +0300)]
Use Sass Compiler version 0.9.6

Change-Id: I92bd1a76c79785ee5d2cdc7000cb4746ef25192e

10 years agoFix copyright header in AnimationUtil
Henri Sara [Fri, 6 Jun 2014 07:25:28 +0000 (10:25 +0300)]
Fix copyright header in AnimationUtil

Change-Id: I768d93e8eb7f4b6415f17c80bc4564053313dc56

10 years agoUpdate versions in OSGi manifest for vaadin-shared (#13812)
Antti Tanhuanpää [Thu, 5 Jun 2014 15:12:44 +0000 (18:12 +0300)]
Update versions in OSGi manifest for vaadin-shared (#13812)

Change-Id: I75551cb500d3d35071dabcf53d71a8536806a0ca

10 years agoImplement Notification animation with CSS (#13660)
Jouni Koivuviita [Thu, 5 Jun 2014 14:23:01 +0000 (17:23 +0300)]
Implement Notification animation with CSS (#13660)

Default opacity (90%), fade duration (400ms) and fade delay (1000ms) are
defined in the base theme.

“In” animations can be defined by using a dependent stylename
‘animate-in’ (prefixed with the widgets own primary stylename), e.g.
'v-Notification-animate-in'. That CSS class should then have a CSS
animation specified, and the CSS animation name should contain
'animate-in', e.g.

.v-Notification-animate-in {
animation: notification-animate-in 400ms;
}

@keyframes notification-animate-in {
...
}

“Out” animations are defined similarly, but with 'animate-out' as the
keyword.

The base theme contains mixins for declaring keyframes rules as well as
animation values, which include needed vendor prefixes.

Refactored deprecated GWT API’s to use newer API’s.

Change-Id: Iba929e8de8b6ce100852d472d65c9c9d0630c48f

10 years agoFix for 'Aborting layout after 100 passess' (#13359)
Tomi Virtanen [Fri, 16 May 2014 08:25:01 +0000 (11:25 +0300)]
Fix for 'Aborting layout after 100 passess' (#13359)

'Aborting layout after 100 passes.' is caused by LayoutManager falling
into a loop on rounding fractional layout slot sizes up and down while
trying to fit layout's content in the space available. LayoutManager
round always up, that causes this issue with IE9+ and Chrome. This
change helps LayoutManager to round fractional sizes down for browsers
that causes problems if rounded up.

Browsers may fall into the loop especially with a zoom level other than
100%. Not with any zoom level though. Problematic zoom level varies by
browser. OrderedLayoutExpandTest uses zoom levels other than 100%. Test
for Chrome is the only one that really is able to reproduce error
without the fix. IE9/10 would too, but the zoom level could not be set
exactly to the required 95% for IE. Test works best as a regression test
for other browsers.

Change-Id: Ie840b074df5fed5ea3b15fba9a6fd372a5c0b76a

10 years agoDon't generate GWT.create for bean superclasses (#13813)
Leif Åstrand [Thu, 22 May 2014 14:48:36 +0000 (17:48 +0300)]
Don't generate GWT.create for bean superclasses (#13813)

Change-Id: I20e03a79562d6bc71ae1454cbbe2d6903649c771

10 years agoAdded new test app/ui for Valo
Jouni Koivuviita [Mon, 2 Jun 2014 11:37:00 +0000 (14:37 +0300)]
Added new test app/ui for Valo

New “tests-valo” theme also included multiple variations to test with.

Change-Id: I3dd3b91526b32ae8d080d2fa431d2a64f6f7fef4

10 years agoAdd load-on-startup on web.xml to make demo run on Wildfly.
Sauli Tähkäpää [Wed, 4 Jun 2014 11:39:34 +0000 (14:39 +0300)]
Add load-on-startup on web.xml to make demo run on Wildfly.

Change-Id: I0cb42d918ed1af31577e5a67ddf4dbac3c9ab02f

10 years agoValo Sass API refactoring (#13668)
Jouni Koivuviita [Mon, 2 Jun 2014 11:35:38 +0000 (14:35 +0300)]
Valo Sass API refactoring (#13668)

Also fixes #13672 (added ‘notification’ v-included-components list)

Fixes #13746 as well (DragAndDropWrapper won’t hide the drag source any
more)

Loads of smaller tweaks and fixes, went through almost all components
again and fixed any issues I could find in testing.

Testing done with the following:
Desktop (OS X Mavericks)
-Safari 7
-Chrome 35
-Firefox 24.5
-Opera 21, 12
-Internet Explorer 8,10

Mobile:
-iOS 7
-Android 4
-Android 2.3
-Windows Phone 8

Change-Id: Ide32cacd1958b5b8db85afe23f455ad3140a7d21

10 years agoPass useLocalWebDriver parameter to JUnit.
Sauli Tähkäpää [Tue, 3 Jun 2014 13:20:37 +0000 (16:20 +0300)]
Pass useLocalWebDriver parameter to JUnit.

Change-Id: I4840da6281c8be676384aa5b71bf689f7083ee36

10 years agoRename $v-app-background-color to $v-background-color (#13670)
Jouni Koivuviita [Mon, 12 May 2014 13:25:58 +0000 (16:25 +0300)]
Rename $v-app-background-color to $v-background-color (#13670)

Top level background-color variable, which is then specialized by
different components in the theme.

Mass search-and-replace, tested that the theme works as expected.

Added a new test UI class for the Valo theme.

Updated .gitignore to ignore .sass-cache (command line Sass creates a
cache folder when watching for changes)

Change-Id: I574a393de059aec7b24cb6014d3192d9717688e5

10 years agoFixed broken OSGi dependencies in vaadin-shared (#13852)
Norman Specht [Tue, 27 May 2014 12:07:45 +0000 (14:07 +0200)]
Fixed broken OSGi dependencies in vaadin-shared (#13852)

The package com.google.gwt.thirdparty.streamhtmlparser_0.0.10.vaadin1 exports version 0.0.10.vaadin1, not 0.1.5.r10-rebased

Change-Id: I25c2964636d27a172cc83d69c5c0db64155a6fc2

10 years agoFix menu item tooltips showing up too early (#13914)
Juuso Valli [Mon, 2 Jun 2014 14:28:49 +0000 (17:28 +0300)]
Fix menu item tooltips showing up too early (#13914)

Change-Id: Id324ed06e45e73a9383667e86651ea794c3ff322

10 years agoFix broken TB2 tests
Juuso Valli [Tue, 3 Jun 2014 12:46:42 +0000 (15:46 +0300)]
Fix broken TB2 tests

Change-Id: I1ce52065e529d471876e8aae1b53b5808089cc53

10 years agoMerge branch 'master' into valo
Jouni Koivuviita [Tue, 3 Jun 2014 09:58:56 +0000 (12:58 +0300)]
Merge branch 'master' into valo

Conflicts:
WebContent/release-notes.html
build.properties
client/src/com/vaadin/client/ApplicationConfiguration.java

Change-Id: I36f075a03350e45c8666832142d7368891af3e59

10 years agoScript for installing build artifacts to the local Maven repository
Artur Signell [Mon, 26 May 2014 13:27:30 +0000 (16:27 +0300)]
Script for installing build artifacts to the local Maven repository

Change-Id: I6cc4553a54d7d4ed7271ea0eb59386516fd96ca5

10 years agoFix for handling a breakpoint with 0 as the lower bound (#13588)
Teemu Pöntelin [Sun, 1 Jun 2014 20:57:25 +0000 (23:57 +0300)]
Fix for handling a breakpoint with 0 as the lower bound (#13588)

Added explicit isNaN checks to the results of parseInt function
because JavaScript would always convert 0 to false.

Change-Id: Ic904c321c0195ce50d9a498005459425b0c30d4c

10 years agoFix regression with error tooltips (#13695)
Juuso Valli [Wed, 28 May 2014 11:57:12 +0000 (14:57 +0300)]
Fix regression with error tooltips (#13695)

Change-Id: Ia076ba95ec3abd6625e81e17bdcf000a20349f4e

10 years agoFix VAbstractOrderedLayout scrollbar in IE8 (#10106)
Juuso Valli [Wed, 28 May 2014 11:32:30 +0000 (14:32 +0300)]
Fix VAbstractOrderedLayout scrollbar in IE8 (#10106)

Change-Id: I188e28736e8092b30a813aeeb78247f5aec33295

10 years agoAllow use of Collection<String> and others with addItems (#13865)
Artur Signell [Wed, 28 May 2014 12:29:28 +0000 (15:29 +0300)]
Allow use of Collection<String> and others with addItems (#13865)

Change-Id: Ie5c0a00b65d27f65522a14c4fbcd05fe21814cc0

10 years agoFix tooltip delay (#13695)
Juuso Valli [Fri, 23 May 2014 09:20:08 +0000 (12:20 +0300)]
Fix tooltip delay (#13695)

Change-Id: I1c3ed59d8a19d3355a3c729fb3635731b326a00e

10 years agoConvert DateFieldReadOnlyTest TB2 -> TB4.
Sauli Tähkäpää [Mon, 26 May 2014 13:06:06 +0000 (16:06 +0300)]
Convert DateFieldReadOnlyTest TB2 -> TB4.

Change-Id: Iab81b1e5992d47c956f9d0440ece98fa546ee927

10 years agoFix Push update race condition (#13562)
Juuso Valli [Mon, 26 May 2014 14:22:18 +0000 (17:22 +0300)]
Fix Push update race condition (#13562)

Change-Id: I50094bc2d236f6dbb02a8b82d6cc9b5f7e4733a5

10 years agoAllow using modifier + enter as shorcuts in TextArea (#13811)
Artur Signell [Mon, 26 May 2014 14:20:40 +0000 (17:20 +0300)]
Allow using modifier + enter as shorcuts in TextArea (#13811)

Change-Id: I99db3d6280f0066ed1249cb348da7e82381b45c2

10 years agoProperly deserialize push connection (#12235)
Johannes Dahlström [Mon, 19 May 2014 13:28:09 +0000 (16:28 +0300)]
Properly deserialize push connection (#12235)

The UI.pushConnection field is transient no longer; instead PushConnection
implementations must take care of serialization internally. When a session
is serialized, the client should notice that push was disconnected and
try to reconnect. A deserialized PushConnection should be in a "disconnected"
state so the eventual client reconnection works correctly.

Change-Id: I38cfc5a5cdbd3643311f830f8d580458dcd85c56

10 years agoChange ColorPickerInputFormatsTest for use Keys.RETURN.
Sauli Tähkäpää [Mon, 26 May 2014 11:40:43 +0000 (14:40 +0300)]
Change ColorPickerInputFormatsTest for use Keys.RETURN.

Change-Id: Ic8ad7163d35e0e1c2d44e928cd52ca66a637b7fa

10 years agoRevert "Fix Push inserts producing duplicate rows in Table (#13562)"
Sauli Tähkäpää [Mon, 26 May 2014 07:56:50 +0000 (10:56 +0300)]
Revert "Fix Push inserts producing duplicate rows in Table (#13562)"

This reverts commit ce1764fb1bad1b82462d73fbfe293b676c2a9c00.

Change-Id: I897e0f3a0876eaea4b68f0e3b75671ccb1398242

10 years agoFix caption listener leak and caption measurement (#13741)
Juuso Valli [Fri, 23 May 2014 08:00:48 +0000 (11:00 +0300)]
Fix caption listener leak and caption measurement (#13741)

Reverting the previous fix to caption measurement, it caused a leak with
the listeners.
Change-Id: If1c06db692c0e829d91528eceb49a9a07f58ed4a

10 years agoJavadoc correction
Artur Signell [Thu, 22 May 2014 13:06:51 +0000 (16:06 +0300)]
Javadoc correction

Change-Id: I58c89f6c8b2c72e233b1d9e5413da1d6cbc36285

10 years agoHelpers for retrieving the current PortletRequest (#13806)
Artur Signell [Thu, 22 May 2014 13:05:47 +0000 (16:05 +0300)]
Helpers for retrieving the current PortletRequest (#13806)

Change-Id: I5d400a05071844729d68abb1ba0c31c33e32e9c7

10 years agoOptimizes ConnectorTracker.cleanConnectorMap (#13803)
Fabian Lange [Wed, 21 May 2014 12:18:41 +0000 (14:18 +0200)]
Optimizes ConnectorTracker.cleanConnectorMap (#13803)

cleanConnectorMap is a hot method.
This change improves multiple code paths:
1) The global resource handler is no longer get()ed from the session for
   each connector (was in two loops).
2) The ConnectorTracker is no longer get()ed from the UI for each
   connector (was in one loop).
3) values() iterator for ClientConnectors replaces
   keySet() iterator + get(key) call
4) use getUI() from ClientConnector instead manual method.
5) moved removeUnregisteredConnectors to ease inlining and readability.

Change-Id: I25ff5bc32d27d30ecd8d354922ec6e4a02b05921

10 years agoModified Coding Conventions to not have a new line after annotations on
Anna Koskinen [Tue, 8 Apr 2014 12:34:16 +0000 (15:34 +0300)]
Modified Coding Conventions to not have a new line after annotations on
parameters (#13569).

Change-Id: Idc541f298591453c52285a8b1987052caad79e4f

10 years agoOptimize getAllChildrenIterable() performance. (#13803)
Fabian Lange [Wed, 21 May 2014 12:52:52 +0000 (14:52 +0200)]
Optimize getAllChildrenIterable() performance. (#13803)

getAllChildrenIterable() is invoked frequently, its used by
attach/detach and markAsDirty.
Because of the implementation detail in CombinedIterator, on every call
all iterators are checked. This means that on every component which has
multiple childs, each next() call will first check the extension
iterator, before advancing in the child iterator.
By having the childs first, this overhead is reduced. If no extensions
are existing (which is quite common) the iterator is not added at all.
(creating an iterator on an empty UnmodifiableCollection is waste of
time and memory)

Change-Id: I23bb91464052ad4282963ec4b5be8a52c6847d4f

10 years agoSuspend all validation in the project
Artur Signell [Tue, 11 Mar 2014 19:14:45 +0000 (21:14 +0200)]
Suspend all validation in the project

Change-Id: Idaa41933c5fb6236a06b13323c2d39f7869af1ac

10 years agoFix issue when typing fast in combobox edit box plus then press TAB (#12325)
Dmitrii Rogozin [Wed, 21 May 2014 09:53:25 +0000 (12:53 +0300)]
Fix issue when typing fast in combobox edit box plus then press TAB (#12325)

Change-Id: I35375d2b39fbd666d848f6ffa62aa0ce1c0d4fad

10 years agoPrevent adding/setting parent component as child (#12720).
Denis Anisimov [Wed, 12 Mar 2014 19:17:18 +0000 (21:17 +0200)]
Prevent adding/setting parent component as child (#12720).

Change-Id: I9b7b43f176e88d9edca591001297b94475a31854

10 years agoReplace use of deprecated DOM.setStyleAttribute method (#13781)
Leif Åstrand [Fri, 16 May 2014 08:31:14 +0000 (11:31 +0300)]
Replace use of deprecated DOM.setStyleAttribute method (#13781)

This change is only a brain dead replacement of one specific method. In
some cases, there were some oddities in the surrounding code as well,
but these were left unresolved on purpose.

It should also be noted that DOM.setStyleAttribute just delegates to
element.getStyle().setProperty(), so any null references would have
caused problems already in the existing code.

Change-Id: I340122ac0767af9928076376f76e5bd2c5e19f9f

10 years agoMake Hearbeat available to other modules (#13250)
Manolo Carrasco [Wed, 14 May 2014 10:55:47 +0000 (12:55 +0200)]
Make Hearbeat available to other modules (#13250)

- When a mobile app goes online/offline we need to change
  Heartbeat interval and restart the schedule.
- We also need to be notified about response status in
  order to show the appropriate offline UI, etc.

Related with Issue #13250 and review https://dev.vaadin.com/review/#/c/3376/

Change-Id: I428501306e37fb8c2ee0ed6022a4c588bd8456db

10 years agoRemove some unnecessary semicolons
Leif Åstrand [Fri, 16 May 2014 06:22:35 +0000 (09:22 +0300)]
Remove some unnecessary semicolons

Change-Id: I8698a9ecf691adde9a3bc2e92047be5f3036df1e

10 years agoUpdate mini tutorial code to use @OnStateChange
Leif Åstrand [Thu, 15 May 2014 11:21:04 +0000 (14:21 +0300)]
Update mini tutorial code to use @OnStateChange

Change-Id: I509213ade4ed9765db8a7773c42051f8f182b272

10 years agoTreat initial rendering and style changes separately. (#13444)
Markus Koivisto [Wed, 21 May 2014 12:33:31 +0000 (15:33 +0300)]
Treat initial rendering and style changes separately. (#13444)

This fixes a regression caused by a previous patch, which led to empty comboboxes being initialised with a zero width.

Change-Id: I7e5ca0c563625c453e0e3006d91ed52ad227d6f0

10 years agoUse method available in all browsers (#13804)
Artur Signell [Wed, 21 May 2014 19:18:05 +0000 (22:18 +0300)]
Use method available in all browsers (#13804)

String.contains work in Firefox, not in Chrome or Opera

Change-Id: I074d3c79629fd699841d3b39a36620511233ce6c

10 years agoFix caption measurement in VAbstractOrderedLayout (#13741)
Juuso Valli [Mon, 19 May 2014 11:40:03 +0000 (14:40 +0300)]
Fix caption measurement in VAbstractOrderedLayout (#13741)

Change-Id: I7bb9a404c789f352477b752537ffdedfc60da91c

10 years agoKeep all checkbox related data in Map don't address it via the index #11772
Denis Anisimov [Mon, 7 Apr 2014 19:04:33 +0000 (22:04 +0300)]
Keep all checkbox related data in Map don't address it via the index #11772

Change-Id: I2c9c68134d9fe958e2881975d1d845dea819a761

10 years agoFix WAR file location in uitest build scripts.
Sauli Tähkäpää [Tue, 20 May 2014 08:05:45 +0000 (11:05 +0300)]
Fix WAR file location in uitest build scripts.

Change-Id: I0febbbaf85374c395454c889c36add277ca9b131

10 years agoAdds methods for setting only width or height undefined #13546
John Ahlroos [Fri, 4 Apr 2014 06:48:37 +0000 (09:48 +0300)]
Adds methods for setting only width or height undefined #13546

Change-Id: Ieebe48c75370c0744a2a2619e1ed81dbd090a544

10 years agoFix keyboard navigating in combo box (#11333).
Dmitrii Rogozin [Fri, 9 May 2014 16:13:59 +0000 (19:13 +0300)]
Fix keyboard navigating in combo box (#11333).

Extract code which focuses on item after changing the page. Deferring  this method allows to update the list of items before focusing.

Change-Id: I7d249c2abbd5c24ca2d798736e483f2b7dfa59f1

10 years agoRefactor tests to make them less likely to have timing issues
Teemu Suo-Anttila [Mon, 19 May 2014 08:37:36 +0000 (11:37 +0300)]
Refactor tests to make them less likely to have timing issues

Change-Id: Idf24ab4f7c2c48f8246f0c38906d2b8a46f46587

10 years agoMove ComboBox tests to correct package
Teemu Suo-Anttila [Mon, 19 May 2014 08:17:57 +0000 (11:17 +0300)]
Move ComboBox tests to correct package

Change-Id: I2ad5164a637b2b4c96b46f30df036ccbc5cbcd66

10 years agoAdd build parameters to allow running test on local PhantomJS
Teemu Suo-Anttila [Thu, 15 May 2014 12:22:49 +0000 (15:22 +0300)]
Add build parameters to allow running test on local PhantomJS

Change-Id: I99f37403d58385a814347d36b0f8b1a35c63c282

10 years agoChange forceUpdate flag to always force recalculation of width. Fix tests. (#13444)
Markus Koivisto [Fri, 25 Apr 2014 13:58:53 +0000 (16:58 +0300)]
Change forceUpdate flag to always force recalculation of width. Fix tests. (#13444)

Change-Id: Ie666e2867908160b1544d3bf8251802ea771660f

10 years agoAvoid Vaadin entry-point being run twice (#13730)
Manolo Carrasco [Fri, 9 May 2014 07:47:14 +0000 (09:47 +0200)]
Avoid Vaadin entry-point being run twice (#13730)

- Prevent bootstrap script fail if registerWidgetset is called twice
  with the same widgetset.

Change-Id: I8b8069b442ea91c1aa0f0b7dd73c41902e75094b

10 years agoDon't use deprecated Assert class
Leif Åstrand [Fri, 16 May 2014 06:38:58 +0000 (09:38 +0300)]
Don't use deprecated Assert class

Change-Id: I0dbef06d0fa319628f6fa528f5ab3adfd5752c11

10 years agoRemove servlet annotations from AsyncPushUpdates test (#13562)
Jonatan Kronqvist [Fri, 16 May 2014 07:50:09 +0000 (10:50 +0300)]
Remove servlet annotations from AsyncPushUpdates test (#13562)

Change-Id: Idfdd37fad9917843c71cee6fd9ba6700f9df8a87

10 years agoDisable closure compiler (#13778)
Artur Signell [Thu, 15 May 2014 15:45:12 +0000 (18:45 +0300)]
Disable closure compiler (#13778)

Change-Id: Id0fb991c4c6323bf8658c92938cf2cd9d80b76a1

10 years agoMade user-initiated column resizing take precedence over other updates (#13432)
Juho Nurminen [Wed, 14 May 2014 11:14:43 +0000 (14:14 +0300)]
Made user-initiated column resizing take precedence over other updates (#13432)

VScrollTable ignores server-initiated changes to column size while the user is
dragging a table resizer element.

Change-Id: I2866246e7975a8ddddbfdc12a9d99fb2c813a870

10 years agoUse Sass Compiler version 0.9.4
Henri Sara [Fri, 16 May 2014 07:53:52 +0000 (10:53 +0300)]
Use Sass Compiler version 0.9.4

Change-Id: I17e3156b1bfe9b6613277e742f304ac063f21710

10 years agoUse Sass Compiler version 0.9.3
Henri Sara [Thu, 15 May 2014 13:14:14 +0000 (16:14 +0300)]
Use Sass Compiler version 0.9.3

Change-Id: Ib6ad95f9dec175d823df0fe4daf0fe576494e455

10 years agoSet "v-formlayout" as the first style for VFormLayout (#13509).
Denis Anisimov [Sun, 20 Apr 2014 16:14:44 +0000 (19:14 +0300)]
Set "v-formlayout" as the first style for VFormLayout (#13509).

Change-Id: I63f0b1c8da52d426b5c370097256b08dbd44b5d7

10 years agoPopupViewAndFragment TB2 -> TB4
Artur Signell [Mon, 12 May 2014 19:30:48 +0000 (22:30 +0300)]
PopupViewAndFragment TB2 -> TB4

Change-Id: I9299d8c78e92816e368208f1cbc07b8c969a9600

10 years agoAdd refresh method to mini tutorial code
Leif Åstrand [Wed, 14 May 2014 11:15:15 +0000 (14:15 +0300)]
Add refresh method to mini tutorial code

Change-Id: I7d2e00b13d2d0b3e3b0e3c20dd431c77721e7d91

10 years agoMake Vaadin TB3/4 tests work and run on PhantomJS (#13291)
Teemu Suo-Anttila [Wed, 14 May 2014 13:31:28 +0000 (16:31 +0300)]
Make Vaadin TB3/4 tests work and run on PhantomJS (#13291)

Change-Id: I0d1747d41b3b9e0a32d995a5cea9081292c8c2c6

10 years agoFix Push inserts producing duplicate rows in Table (#13562)
Juuso Valli [Wed, 7 May 2014 06:39:14 +0000 (09:39 +0300)]
Fix Push inserts producing duplicate rows in Table (#13562)

Change-Id: I050553b233fb7024049c31d9495d90f4d88239c8

10 years agoUpdate tutorial code to show more user-friendly API
Leif Åstrand [Thu, 10 Apr 2014 08:47:29 +0000 (11:47 +0300)]
Update tutorial code to show more user-friendly API

Change-Id: I95c82d2256221b0068d6c2762f6dbb8a1e29b6b8

10 years agoFix table scrolling up on select (#10106)
Juuso Valli [Tue, 29 Apr 2014 09:48:07 +0000 (12:48 +0300)]
Fix table scrolling up on select (#10106)

Change-Id: I4d13bee983817ce299d1f7e52ddd6cdc725fee6f

10 years agoAllow editing colorpicker values in colorpicker in textfield #13469
John Ahlroos [Thu, 24 Apr 2014 18:12:15 +0000 (21:12 +0300)]
Allow editing colorpicker values in colorpicker in textfield #13469

This fix adds support for typing in color values according to
http://www.w3schools.com/cssref/css_colors_legal.asp into the
colorpicker popup input textfield.

Change-Id: If14ead791725c3052c05aa31e12e237e90c32348

10 years agoFixed disabled and read-only modes of InlineDateField (#10262)
Teemu Pöntelin [Mon, 5 May 2014 20:58:00 +0000 (23:58 +0300)]
Fixed disabled and read-only modes of InlineDateField (#10262)

Change-Id: If95d50954a4122b1039174ffcacd7874f7f1f71e

10 years agoDisable authors because of build agent problems
Artur Signell [Tue, 13 May 2014 22:13:10 +0000 (01:13 +0300)]
Disable authors because of build agent problems

Change-Id: I5426d8a85f7b57193c1bbfe201258a09f93b54cb

10 years agoUse more appropriate dependencies for Jetty (#13682)
Artur Signell [Tue, 13 May 2014 15:33:08 +0000 (18:33 +0300)]
Use more appropriate dependencies for Jetty (#13682)

Change-Id: Ic977ae403068e41a64eabc42cd00c4a933d02a95