source.dussan.org Git

Nick Burch [Thu, 24 Apr 2014 15:42:53 +0000 (15:42 +0000)]

Fix bug #56450 - Avoid a NPE if a comment has no associated NoteRecord (but we still don't know where it belongs)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589770 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Apr 2014 15:07:20 +0000 (15:07 +0000)]

Fix some Eclipse identified warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589765 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Apr 2014 14:52:09 +0000 (14:52 +0000)]

Two more test files from Stefan Kopf for bug #56164, and unit tests which use them

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589759 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Apr 2014 14:50:52 +0000 (14:50 +0000)]

Correct an eclipse warning around close(), and a related bug that this identified

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589756 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 21 Apr 2014 14:37:33 +0000 (14:37 +0000)]

Bug 56437 - [PATCH] Streaming write support in NPOIFS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588887 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 21 Apr 2014 12:16:54 +0000 (12:16 +0000)]

Some encryption fixes:
- don't rely on SecretKey object having the right algorithm set
- leave encryption-description parsing of string/stream to xmlbeans and refactor it to one location
- use namespaces of schema instead of hard-coded strings
- use CryptoFunctions.getMessageDigest() instead of code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588874 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Apr 2014 23:44:08 +0000 (23:44 +0000)]

Tweak 'assertAlmostEquals' bast on Jenkins results

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588595 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Apr 2014 20:46:57 +0000 (20:46 +0000)]

Unit test for column autosizing of % values

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588562 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 18 Apr 2014 18:20:15 +0000 (18:20 +0000)]

Bug 56315: Make rounding in MathX.round() behave equal to Excel, adjust/enhance some more tests in MathX

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588538 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 18 Apr 2014 18:19:17 +0000 (18:19 +0000)]

Try to exclude some generated files from Sonar runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588537 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 15 Apr 2014 21:59:52 +0000 (21:59 +0000)]

Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 15 Apr 2014 16:29:05 +0000 (16:29 +0000)]

More stax jar removal for Java 6

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587631 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 15 Apr 2014 15:19:30 +0000 (15:19 +0000)]

Now that we require Java 1.6, we no longer need to include the STAX-API jar as JRE 1.6 has it build in

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587605 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 4 Apr 2014 07:26:53 +0000 (07:26 +0000)]

Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1584544 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 4 Apr 2014 07:26:24 +0000 (07:26 +0000)]

exclude new broken test-file for this test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1584543 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 1 Apr 2014 23:27:05 +0000 (23:27 +0000)]

Add another test file for bug #47251, from Joe Yuan, and a disabled test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583825 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 1 Apr 2014 10:40:13 +0000 (10:40 +0000)]

Fix two javadoc warnings reported in Jenkins build and add some @Overrides

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583598 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 1 Apr 2014 08:28:52 +0000 (08:28 +0000)]

Undo a toString() removal for a case where it is actually necessary.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583571 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Cédric Walter [Mon, 31 Mar 2014 16:16:52 +0000 (16:16 +0000)]

performance issue: removed instantiation of new String object by copying an existing string.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583366 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Cédric Walter [Mon, 31 Mar 2014 16:01:39 +0000 (16:01 +0000)]

performance issue: call toString() on a String object. This is entirely redundant.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583358 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Cédric Walter [Mon, 31 Mar 2014 15:54:52 +0000 (15:54 +0000)]

performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 28 Mar 2014 21:54:30 +0000 (21:54 +0000)]

Patch from bug #56328 from David North - the maximum row number in a formula depends on HSSF vs XSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1582892 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 26 Mar 2014 19:03:03 +0000 (19:03 +0000)]

Update Yegor's gpg key in the Keys file, with the latest version from the key servers (more signatures, correct expiry etc)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1582014 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 22 Mar 2014 20:48:58 +0000 (20:48 +0000)]

Patch for #55594 from Paul Vonnahme - Fix SXSSF encodings on EBC
IDIC platforms, by setting the required encoding explicitly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1580314 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 18 Mar 2014 14:40:27 +0000 (14:40 +0000)]

Avoid an IndexOutOfBoundsException if there are no property nodes when searching for the start index, return -1 instead

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578929 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 18 Mar 2014 14:26:28 +0000 (14:26 +0000)]

Support adding tabs to a XWPFRun, and add unit tests on toString() for addTab and addCarriageReturn

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578921 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 18 Mar 2014 14:17:36 +0000 (14:17 +0000)]

Fix whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578915 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 17 Mar 2014 19:02:21 +0000 (19:02 +0000)]

Fix bug #56278 - Support loading .xlsx files with no Styles Table

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578518 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 16 Mar 2014 19:46:56 +0000 (19:46 +0000)]

Bug 56195: replace System.err with propert logging

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578147 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 16 Mar 2014 19:46:46 +0000 (19:46 +0000)]

Exclude some generated classes from coverage measurements, now instruction coverage is at around 72%, also update JaCoCo to latest version 0.6.5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578146 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Mar 2014 17:31:43 +0000 (17:31 +0000)]

Remove two files added inadvertedely

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577909 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Mar 2014 17:31:25 +0000 (17:31 +0000)]

Add missing test-file for bug 56169

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577908 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Mar 2014 17:29:17 +0000 (17:29 +0000)]

Bug 56169: Fix NPE during export to XML with xs:all

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577907 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Mar 2014 17:00:22 +0000 (17:00 +0000)]

Bug 56114: Add testcase to verify that the flag is correctly stored in the XLS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577901 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 15 Mar 2014 08:16:43 +0000 (08:16 +0000)]

When looking for text run related records after a TextHeaderAtom, provide a cleaner way to skip ones we don't care about, and a cleaner way to find the StyleTextPropAtom. Should fix #56260

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577803 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 15 Mar 2014 08:14:36 +0000 (08:14 +0000)]

Implement MasterTextPropAtom, which provides the indents for a run of text, needed for #56260

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577802 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 14 Mar 2014 13:59:24 +0000 (13:59 +0000)]

#56260 Partial fix for a slide with a TextHeaderAtom but no other atoms related to it, which is followed by another TextHeaderAtom straight away

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577537 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 14 Mar 2014 13:59:08 +0000 (13:59 +0000)]

Sample file for #56260, provided by Atlassian in CONF-18721

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577536 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 13 Mar 2014 00:16:56 +0000 (00:16 +0000)]

Bug 56075 - Add Change Tracking support to XWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577010 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 10 Mar 2014 19:35:25 +0000 (19:35 +0000)]

Try one more way of excluding generated sources in the Maven pom.xml files for Sonar analysis

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1576063 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 9 Mar 2014 09:53:25 +0000 (09:53 +0000)]

Fix inconsistent whitespace, and add a close call in the main method to avoid a resource-leak warning

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575684 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 9 Mar 2014 09:49:06 +0000 (09:49 +0000)]

Patch from Shaun Kalley from bug #56023 - On CellReference, implement hashCode, fix the equals(Object) logic, and fix inconsistent whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575683 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 8 Mar 2014 20:03:40 +0000 (20:03 +0000)]

Fix the inconsistent indents in the test file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575600 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 8 Mar 2014 20:01:38 +0000 (20:01 +0000)]

Add more unit tests for XWPF Headers and Footers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575599 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 8 Mar 2014 19:52:09 +0000 (19:52 +0000)]

When adding a new XPWFRun to a paragraph, update both the Runs and IRuns lists with it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575597 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 8 Mar 2014 19:33:07 +0000 (19:33 +0000)]

Add some javadocs for the XWPF Header/Footer creation methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575594 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 8 Mar 2014 16:46:59 +0000 (16:46 +0000)]

Adjust for JDK 8 where an empty locale is added to the array returned by DateFormat.getAvailableLocales()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575563 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 8 Mar 2014 08:41:25 +0000 (08:41 +0000)]

Fix Sonar issues about finalize() usage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575501 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 8 Mar 2014 08:41:08 +0000 (08:41 +0000)]

Enhance test to print out more information, it seems to fail on Apache Jenkins JDK8 build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575500 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 8 Mar 2014 08:22:03 +0000 (08:22 +0000)]

Adjust TestExtractorFactory to provide more output to see why it fails on Maven builds on nemo.sonarsource.org

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575497 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 6 Mar 2014 00:53:09 +0000 (00:53 +0000)]

Added MD4-option and some cleanups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574732 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Tue, 4 Mar 2014 22:23:29 +0000 (22:23 +0000)]

disable font downloading, because of Jenkins connection (download) problems

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574226 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 4 Mar 2014 11:57:44 +0000 (11:57 +0000)]

POI is now on JDK 1.6, so remove 1.5 workaround

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574049 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 3 Mar 2014 20:43:09 +0000 (20:43 +0000)]

Try to set the Sonar-Exclusion property differently to see if that makes the exclusions work

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1573741 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 28 Feb 2014 16:10:22 +0000 (16:10 +0000)]

Sonar-pom: Add some metadata, try to add Sonar exclusions for generated sources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1572979 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 27 Feb 2014 14:03:27 +0000 (14:03 +0000)]

Try to improve Maven files for Sonar: Copy in (test)sources instead of linking to sources outside the sonar-directory which confuses Sonar, remove source-dir setting for ooxml-schema and ooxml-schema-encryption as both have generate sources and not actual ones, scratchpad is not needed for ooxml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1572580 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 27 Feb 2014 13:32:27 +0000 (13:32 +0000)]

Report how long the CSV conversion took, helpful for a quick read performance test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1572555 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 21 Feb 2014 23:19:57 +0000 (23:19 +0000)]

Bug 56076 - Add document protection with password support to XWPF
Bug 56077 - Add password hash function to HWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570750 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 20 Feb 2014 23:37:20 +0000 (23:37 +0000)]

Zero length code page fix has been committed, so this file can once again be included in the overall test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570390 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 20 Feb 2014 23:20:19 +0000 (23:20 +0000)]

More helpful visio v5 exception, see bug #56171

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570388 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 20 Feb 2014 00:06:34 +0000 (00:06 +0000)]

Another content types test, for #55026

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570002 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 20 Feb 2014 00:03:42 +0000 (00:03 +0000)]

The junit test failed with the original test-file (CDT_Data_Retention-PPT.ppt), so another check was necessary

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569999 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 19 Feb 2014 23:54:46 +0000 (23:54 +0000)]

Fix bug #56164 - Tidy up the OPC SAX setup code with a new common Helper

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569991 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 19 Feb 2014 23:45:07 +0000 (23:45 +0000)]

Bug 55732 - PPT can't open, fails with "Couldn't instantiate .... StyleTextProp9Atom : java.lang.ArrayIndexOutOfBoundsException: 56"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569984 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 19 Feb 2014 23:34:53 +0000 (23:34 +0000)]

Complete support for OOXML content types with parameters, including parts of the patch from Sebastien Schneider from bug #55026

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569976 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 19 Feb 2014 23:30:12 +0000 (23:30 +0000)]

upgraded to junit4 (before other changes)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569972 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 19 Feb 2014 23:12:56 +0000 (23:12 +0000)]

Begin to implement some of the tests and logic for content types with parameters, based on the test file for bug #55026

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569965 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 19 Feb 2014 22:51:08 +0000 (22:51 +0000)]

link forrest.properties from https://svn.apache.org/repos/asf/poi/site/forrest.properties

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569947 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 17 Feb 2014 22:11:57 +0000 (22:11 +0000)]

Downgrade the replacer plugin to 1.5.1, otherwise replacing does not find any files sometimes
Also svn-ignore the maven-target directories

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569118 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 16 Feb 2014 23:36:32 +0000 (23:36 +0000)]

FindBugs fix
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 16 Feb 2014 19:35:55 +0000 (19:35 +0000)]

Patch and test from Jon Iles from bug #56138 - HPSF code page strings can be zero length

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568813 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 16 Feb 2014 19:35:16 +0000 (19:35 +0000)]

FindBugs fix
- fixed "equals() method does not check for null argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 16 Feb 2014 17:00:53 +0000 (17:00 +0000)]

Sweeping is also needed for empty column-list ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568791 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 16 Feb 2014 16:30:24 +0000 (16:30 +0000)]

FindBugs fix
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 16 Feb 2014 13:04:47 +0000 (13:04 +0000)]

- Changed status/changes xdocs/xslt, to link to the bug entry
todo at the bottom of status was out of date anyway
- references to changes-v13.dtd results in a processing error in forest 0.5, so removed it and any references to it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568757 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 16 Feb 2014 09:11:28 +0000 (09:11 +0000)]

Fix unit tests broken by newly added test-file, ignore TestFontRendering as it is inherently unstable currently

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568744 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 16 Feb 2014 08:39:47 +0000 (08:39 +0000)]

Fix unit test which failed after new corrupted file was added.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568741 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 16 Feb 2014 08:39:17 +0000 (08:39 +0000)]

Adjust test to write the failing PNG in case expected and actual do not match

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568740 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 15 Feb 2014 13:29:32 +0000 (13:29 +0000)]

Test file from bug #56138 from Jon Iles, with a zero length codepage string

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568634 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Feb 2014 10:43:58 +0000 (10:43 +0000)]

Instead of using initCause() when re-throwing exceptions, it leads to better stacktraces if a simple constructor-argument is used

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568614 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Feb 2014 10:42:43 +0000 (10:42 +0000)]

Add a set of maven pom.xml files for Sonar, a few workaround are
necessary, but overall this now allows to compile and run test for
all Apache POI components using Maven, which is a pre-requisite to
be analyzed at http://nemo.sonarqube.org/

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568613 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Feb 2014 00:21:19 +0000 (00:21 +0000)]

Provide more output on test that failed for me locally

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568558 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Feb 2014 00:20:24 +0000 (00:20 +0000)]

Adjust some tests to not hardcode the 'test-data' directory. This breaks the Sonar-maven build that I am working on locally

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568557 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Feb 2014 00:19:50 +0000 (00:19 +0000)]

build.xml: Add missing depends on init for compile-main target

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568556 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Feb 2014 00:19:32 +0000 (00:19 +0000)]

Update Javadoc somewhat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568555 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 15 Feb 2014 00:18:34 +0000 (00:18 +0000)]

Add assertions, remove Sonar warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568554 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 14 Feb 2014 23:21:30 +0000 (23:21 +0000)]

update *ssf-workbook tests to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568541 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 14 Feb 2014 22:45:05 +0000 (22:45 +0000)]

Bug 53130 - SXSSF Shared Strings option support, to make generated xlsx files compatible with Google Docs or iPad

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568539 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 14 Feb 2014 01:00:45 +0000 (01:00 +0000)]

FindBugs fix
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 13 Feb 2014 23:34:11 +0000 (23:34 +0000)]

FindBugs fix
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 13 Feb 2014 00:07:36 +0000 (00:07 +0000)]

disable not applicable findbugs check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567815 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 12 Feb 2014 14:56:40 +0000 (14:56 +0000)]

Fix the copyright notice year

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567636 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Tue, 11 Feb 2014 23:16:54 +0000 (23:16 +0000)]

Bug 55902 - Mixed fonts issue with Chinese characters (unable to form images from ppt)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567455 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 9 Feb 2014 21:19:20 +0000 (21:19 +0000)]

FindBugs fix
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 9 Feb 2014 00:52:07 +0000 (00:52 +0000)]

excluded findbugs (svn:ignore)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566177 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 8 Feb 2014 23:44:42 +0000 (23:44 +0000)]

Use findbugs in the jenkins build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566172 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 3 Feb 2014 20:56:43 +0000 (20:56 +0000)]

Bug 55923: Fix compare/sorting of nodes in exported XML

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564050 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 3 Feb 2014 20:17:59 +0000 (20:17 +0000)]

Bug 55924: Avoid errors during exporting XML if there are numeric cells without value, also verify in tests that XML can always be parsed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564045 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 3 Feb 2014 19:46:41 +0000 (19:46 +0000)]

Bug 55926: Handle numeric formula values when exporting to XML

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564028 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 3 Feb 2014 19:19:14 +0000 (19:19 +0000)]

Bug 55927: Handle date types when exporting to XML

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564011 13f79535-47bb-0310-9956-ffa450edef68