]> source.dussan.org Git - redmine.git/log
redmine.git
5 years agocode layout clean up IssuesController#index
Toshi MARUYAMA [Fri, 22 Nov 2019 04:24:42 +0000 (04:24 +0000)]
code layout clean up IssuesController#index

git-svn-id: http://svn.redmine.org/redmine/trunk@19148 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/views/issues/new.js.erb
Toshi MARUYAMA [Fri, 22 Nov 2019 04:24:31 +0000 (04:24 +0000)]
code layout clean up app/views/issues/new.js.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@19147 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up IssuesController#update
Toshi MARUYAMA [Fri, 22 Nov 2019 04:24:21 +0000 (04:24 +0000)]
code layout clean up IssuesController#update

git-svn-id: http://svn.redmine.org/redmine/trunk@19146 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/views/watchers/new.js.erb
Toshi MARUYAMA [Fri, 22 Nov 2019 03:02:54 +0000 (03:02 +0000)]
code layout clean up app/views/watchers/new.js.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@19145 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/views/watchers/_new.html.erb
Toshi MARUYAMA [Fri, 22 Nov 2019 03:02:43 +0000 (03:02 +0000)]
code layout clean up app/views/watchers/_new.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@19144 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/views/issues/_edit.html.erb
Toshi MARUYAMA [Fri, 22 Nov 2019 03:02:32 +0000 (03:02 +0000)]
code layout clean up app/views/issues/_edit.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@19143 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/unit/repository_git_test.rb from Layout/IndentFirstArrayElement...
Toshi MARUYAMA [Thu, 21 Nov 2019 12:47:03 +0000 (12:47 +0000)]
rubocop: remove test/unit/repository_git_test.rb from Layout/IndentFirstArrayElement fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@19142 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/IndentFirstArrayElement in RepositoryGitTest#test_fetch_...
Toshi MARUYAMA [Thu, 21 Nov 2019 12:46:52 +0000 (12:46 +0000)]
cleanup: rubocop: fix Layout/IndentFirstArrayElement in RepositoryGitTest#test_fetch_changesets_incremental

git-svn-id: http://svn.redmine.org/redmine/trunk@19141 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/IndentFirstArrayElement in RepositoryGitTest#test_fetch_...
Toshi MARUYAMA [Thu, 21 Nov 2019 12:46:41 +0000 (12:46 +0000)]
cleanup: rubocop: fix Layout/IndentFirstArrayElement in RepositoryGitTest#test_fetch_changesets_history_editing

git-svn-id: http://svn.redmine.org/redmine/trunk@19140 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/IndentFirstArrayElement in RepositoryGitTest#test_db_con...
Toshi MARUYAMA [Thu, 21 Nov 2019 12:46:30 +0000 (12:46 +0000)]
cleanup: rubocop: fix Layout/IndentFirstArrayElement in RepositoryGitTest#test_db_consistent_ordering_before_1_2

git-svn-id: http://svn.redmine.org/redmine/trunk@19139 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/IndentFirstArrayElement in RepositoryGitTest#test_latest...
Toshi MARUYAMA [Thu, 21 Nov 2019 12:46:19 +0000 (12:46 +0000)]
cleanup: rubocop: fix Layout/IndentFirstArrayElement in RepositoryGitTest#test_latest_changesets

git-svn-id: http://svn.redmine.org/redmine/trunk@19138 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/ClosingParenthesisIndentation in lib/redmine/scm/adapter...
Toshi MARUYAMA [Thu, 21 Nov 2019 12:46:07 +0000 (12:46 +0000)]
cleanup: rubocop: fix Layout/ClosingParenthesisIndentation in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19137 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/ClosingParenthesisIndentation in test/unit/lib/redmine...
Toshi MARUYAMA [Thu, 21 Nov 2019 12:45:55 +0000 (12:45 +0000)]
cleanup: rubocop: fix Layout/ClosingParenthesisIndentation in test/unit/lib/redmine/scm/adapters/git_adapter_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19136 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: generate .rubocop_todo.yml for Layout/EmptyLinesAroundModuleBody
Toshi MARUYAMA [Thu, 21 Nov 2019 12:45:45 +0000 (12:45 +0000)]
rubocop: generate .rubocop_todo.yml for Layout/EmptyLinesAroundModuleBody

git-svn-id: http://svn.redmine.org/redmine/trunk@19135 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in lib/redmine/sudo_mode.rb
Toshi MARUYAMA [Thu, 21 Nov 2019 12:45:34 +0000 (12:45 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in lib/redmine/sudo_mode.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19134 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in lib/redmine/themes.rb
Toshi MARUYAMA [Thu, 21 Nov 2019 12:45:23 +0000 (12:45 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in lib/redmine/themes.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19133 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in lib/redmine/utils.rb
Toshi MARUYAMA [Thu, 21 Nov 2019 12:45:12 +0000 (12:45 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in lib/redmine/utils.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19132 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in test/mocks/open_id_authent...
Toshi MARUYAMA [Thu, 21 Nov 2019 12:45:02 +0000 (12:45 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in test/mocks/open_id_authentication_mock.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19131 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in lib/redmine/syntax_highlig...
Toshi MARUYAMA [Thu, 21 Nov 2019 12:44:51 +0000 (12:44 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundModuleBody in lib/redmine/syntax_highlighting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19130 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in lib/redmine/scm/adapters/subversion_ad...
Toshi MARUYAMA [Thu, 21 Nov 2019 10:56:24 +0000 (10:56 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in lib/redmine/scm/adapters/subversion_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19129 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: generate .rubocop_todo.yml for Layout/EmptyLinesAroundClassBody
Toshi MARUYAMA [Thu, 21 Nov 2019 10:46:25 +0000 (10:46 +0000)]
rubocop: generate .rubocop_todo.yml for Layout/EmptyLinesAroundClassBody

git-svn-id: http://svn.redmine.org/redmine/trunk@19128 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/views...
Toshi MARUYAMA [Thu, 21 Nov 2019 10:46:14 +0000 (10:46 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/views/builders/xml_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19127 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_...
Toshi MARUYAMA [Thu, 21 Nov 2019 10:46:01 +0000 (10:46 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19126 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/helpe...
Toshi MARUYAMA [Thu, 21 Nov 2019 10:45:46 +0000 (10:45 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/helpers/calendar_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19125 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/mime_...
Toshi MARUYAMA [Thu, 21 Nov 2019 10:45:34 +0000 (10:45 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/mime_type_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19124 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/pagin...
Toshi MARUYAMA [Thu, 21 Nov 2019 10:45:23 +0000 (10:45 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/pagination_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19123 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/scm...
Toshi MARUYAMA [Thu, 21 Nov 2019 10:45:12 +0000 (10:45 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/scm/adapters/subversion_adapter_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19122 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/adapters...
Toshi MARUYAMA [Thu, 21 Nov 2019 10:45:00 +0000 (10:45 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/adapters/subversion_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19121 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: generate .rubocop_todo.yml for Style/AccessModifierDeclarations
Toshi MARUYAMA [Thu, 21 Nov 2019 05:38:34 +0000 (05:38 +0000)]
rubocop: generate .rubocop_todo.yml for Style/AccessModifierDeclarations

git-svn-id: http://svn.redmine.org/redmine/trunk@19120 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Style/AccessModifierDeclarations in lib/redmine/scm/adapters...
Toshi MARUYAMA [Thu, 21 Nov 2019 05:38:24 +0000 (05:38 +0000)]
cleanup: rubocop: fix Style/AccessModifierDeclarations in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19119 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/adapters...
Toshi MARUYAMA [Thu, 21 Nov 2019 04:06:03 +0000 (04:06 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19118 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/adapters...
Toshi MARUYAMA [Thu, 21 Nov 2019 04:05:52 +0000 (04:05 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/adapters/abstract_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19117 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/base.rb
Toshi MARUYAMA [Thu, 21 Nov 2019 04:05:42 +0000 (04:05 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/base.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19116 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/generators/redmine_plug...
Toshi MARUYAMA [Thu, 21 Nov 2019 04:05:31 +0000 (04:05 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/generators/redmine_plugin_model/redmine_plugin_model_generator.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19115 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/diff.rb
Toshi MARUYAMA [Thu, 21 Nov 2019 04:05:21 +0000 (04:05 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/diff.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19114 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/views/builders...
Toshi MARUYAMA [Thu, 21 Nov 2019 04:05:10 +0000 (04:05 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/views/builders/structure.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19113 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_...
Toshi MARUYAMA [Thu, 21 Nov 2019 04:05:00 +0000 (04:05 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_formatting/markdown_html_parser_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19112 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_...
Toshi MARUYAMA [Thu, 21 Nov 2019 04:04:49 +0000 (04:04 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_formatting/textile_html_parser_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19111 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/project_nested_se...
Toshi MARUYAMA [Thu, 21 Nov 2019 04:04:39 +0000 (04:04 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/project_nested_set_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19110 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: disable Style/TrailingCommaInHashLiteral
Toshi MARUYAMA [Wed, 20 Nov 2019 17:12:40 +0000 (17:12 +0000)]
rubocop: disable Style/TrailingCommaInHashLiteral

git-svn-id: http://svn.redmine.org/redmine/trunk@19109 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: use "EnforcedStyle: empty" for Style/EmptyElse
Toshi MARUYAMA [Wed, 20 Nov 2019 17:05:35 +0000 (17:05 +0000)]
rubocop: use "EnforcedStyle: empty" for Style/EmptyElse

git-svn-id: http://svn.redmine.org/redmine/trunk@19108 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove Style/AsciiComments comment
Toshi MARUYAMA [Wed, 20 Nov 2019 17:05:24 +0000 (17:05 +0000)]
rubocop: remove Style/AsciiComments comment

git-svn-id: http://svn.redmine.org/redmine/trunk@19107 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: move Layout/CaseIndentation exclude entry from .rubocop_todo.yml to .rubocop.yml
Toshi MARUYAMA [Wed, 20 Nov 2019 17:05:13 +0000 (17:05 +0000)]
rubocop: move Layout/CaseIndentation exclude entry from .rubocop_todo.yml to .rubocop.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@19106 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/project_query.rb
Toshi MARUYAMA [Wed, 20 Nov 2019 16:30:02 +0000 (16:30 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/project_query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19105 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/setting.rb
Toshi MARUYAMA [Wed, 20 Nov 2019 16:29:52 +0000 (16:29 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19104 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/time_entry_query.rb
Toshi MARUYAMA [Wed, 20 Nov 2019 16:29:41 +0000 (16:29 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/time_entry_query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19103 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_...
Toshi MARUYAMA [Wed, 20 Nov 2019 16:29:30 +0000 (16:29 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_formatting/html_parser_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19102 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/theme...
Toshi MARUYAMA [Wed, 20 Nov 2019 16:01:00 +0000 (16:01 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/themes_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19100 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/acces...
Toshi MARUYAMA [Wed, 20 Nov 2019 16:00:49 +0000 (16:00 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/access_control_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19099 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/codes...
Toshi MARUYAMA [Wed, 20 Nov 2019 16:00:39 +0000 (16:00 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/codeset_util_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19098 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/query.rb
Toshi MARUYAMA [Wed, 20 Nov 2019 16:00:28 +0000 (16:00 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19097 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/issue_query.rb
Toshi MARUYAMA [Wed, 20 Nov 2019 16:00:16 +0000 (16:00 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/issue_query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19096 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/controllers/previews_co...
Toshi MARUYAMA [Wed, 20 Nov 2019 16:00:05 +0000 (16:00 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/controllers/previews_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19095 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoMake sure we cannot create a ProjectQuery on a given project (#29482).
Jean-Philippe Lang [Wed, 20 Nov 2019 15:53:04 +0000 (15:53 +0000)]
Make sure we cannot create a ProjectQuery on a given project (#29482).

git-svn-id: http://svn.redmine.org/redmine/trunk@19093 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFixes the assertion so that it doesn't rely on the display order (#32436).
Jean-Philippe Lang [Wed, 20 Nov 2019 15:07:23 +0000 (15:07 +0000)]
Fixes the assertion so that it doesn't rely on the display order (#32436).

Patch by Kouhei Sutou.

git-svn-id: http://svn.redmine.org/redmine/trunk@19092 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoOnly admin users should be able to manage public queries on the project list (#29482).
Jean-Philippe Lang [Wed, 20 Nov 2019 15:01:24 +0000 (15:01 +0000)]
Only admin users should be able to manage public queries on the project list (#29482).

Like for issues, project members with the "Manage public" queries are allowed to manage public queries inside their projects, not public global queries that are proposed on /issues.

git-svn-id: http://svn.redmine.org/redmine/trunk@19091 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix that text copied from some applications such as MS Office and LibreOffice is...
Go MAEDA [Tue, 19 Nov 2019 02:33:50 +0000 (02:33 +0000)]
Fix that text copied from some applications such as MS Office and LibreOffice is pasted as an image in addition to plain text (#32469, #3816).

Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@19089 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd missing fixture to TimelogControllerTest in order to fix random test failure...
Go MAEDA [Tue, 19 Nov 2019 00:18:10 +0000 (00:18 +0000)]
Add missing fixture to TimelogControllerTest in order to fix random test failure (#32478).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@19088 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: fix Lint/IneffectiveAccessModifier in app/models/auth_source_ldap.rb (#32470)
Toshi MARUYAMA [Sat, 16 Nov 2019 13:10:51 +0000 (13:10 +0000)]
rubocop: fix Lint/IneffectiveAccessModifier in app/models/auth_source_ldap.rb (#32470)

git-svn-id: http://svn.redmine.org/redmine/trunk@19085 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoregenerate .rubocop_todo.yml (#32470)
Toshi MARUYAMA [Sat, 16 Nov 2019 12:46:43 +0000 (12:46 +0000)]
regenerate .rubocop_todo.yml (#32470)

git-svn-id: http://svn.redmine.org/redmine/trunk@19083 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Lint/ParenthesesAsGroupedExpression and Style/RedundantParenthe...
Toshi MARUYAMA [Sat, 16 Nov 2019 12:38:38 +0000 (12:38 +0000)]
cleanup: rubocop: fix Lint/ParenthesesAsGroupedExpression and Style/RedundantParentheses and Layout/SpaceAfterNot in test/helpers/application_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19082 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoReverts r18692 (#32470).
Jean-Philippe Lang [Sat, 16 Nov 2019 10:31:48 +0000 (10:31 +0000)]
Reverts r18692 (#32470).

git-svn-id: http://svn.redmine.org/redmine/trunk@19079 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate capybara (~> 3.29.0) (#32453).
Go MAEDA [Thu, 14 Nov 2019 00:23:40 +0000 (00:23 +0000)]
Update capybara (~> 3.29.0) (#32453).

Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@19073 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate Rouge to 3.13.0 (#32468).
Go MAEDA [Wed, 13 Nov 2019 23:40:31 +0000 (23:40 +0000)]
Update Rouge to 3.13.0 (#32468).

git-svn-id: http://svn.redmine.org/redmine/trunk@19072 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd missing fixture to Redmine::WikiFormatting::MacrosTest (#32444).
Go MAEDA [Wed, 13 Nov 2019 22:08:53 +0000 (22:08 +0000)]
Add missing fixture to Redmine::WikiFormatting::MacrosTest (#32444).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@19071 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix a Rubocop offense caused by r19065 (#16904).
Go MAEDA [Wed, 13 Nov 2019 13:22:05 +0000 (13:22 +0000)]
Fix a Rubocop offense caused by r19065 (#16904).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@19068 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix that QueriesControllerTest fails due to r19065 (#16904).
Go MAEDA [Wed, 13 Nov 2019 09:49:52 +0000 (09:49 +0000)]
Fix that QueriesControllerTest fails due to r19065 (#16904).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@19067 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd anonymous user to author list in issue/time query (#16904).
Jean-Philippe Lang [Sun, 10 Nov 2019 07:58:57 +0000 (07:58 +0000)]
Add anonymous user to author list in issue/time query (#16904).

Patch by Yuichi HARADA and Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@19065 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd support for grouping by issue on timelog view (#32436).
Jean-Philippe Lang [Sun, 10 Nov 2019 07:56:47 +0000 (07:56 +0000)]
Add support for grouping by issue on timelog view (#32436).

Patch by Kouhei Sutou.

git-svn-id: http://svn.redmine.org/redmine/trunk@19063 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemoved invalid association IssueCustomField#issue_custom_values (#32431).
Jean-Philippe Lang [Sun, 10 Nov 2019 07:54:24 +0000 (07:54 +0000)]
Removed invalid association IssueCustomField#issue_custom_values (#32431).

Patch by Akira Matsuda.

git-svn-id: http://svn.redmine.org/redmine/trunk@19061 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdds "Target Version" column to the list of "Available columns" in "Spent time" tab...
Go MAEDA [Sun, 10 Nov 2019 00:42:30 +0000 (00:42 +0000)]
Adds "Target Version" column to the list of "Available columns" in "Spent time" tab (#30346).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@19059 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: enable Layout/AlignArguments
Toshi MARUYAMA [Sat, 9 Nov 2019 18:17:25 +0000 (18:17 +0000)]
rubocop: enable Layout/AlignArguments

git-svn-id: http://svn.redmine.org/redmine/trunk@19058 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_principals_...
Toshi MARUYAMA [Sat, 9 Nov 2019 18:17:12 +0000 (18:17 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_principals_options_for_select_with_users_and_groups

git-svn-id: http://svn.redmine.org/redmine/trunk@19057 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_principals_...
Toshi MARUYAMA [Sat, 9 Nov 2019 18:17:01 +0000 (18:17 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_principals_options_for_select_with_selected

git-svn-id: http://svn.redmine.org/redmine/trunk@19056 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_principals_...
Toshi MARUYAMA [Sat, 9 Nov 2019 18:16:50 +0000 (18:16 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_principals_options_for_select_with_users

git-svn-id: http://svn.redmine.org/redmine/trunk@19055 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_thumbnail_tag
Toshi MARUYAMA [Sat, 9 Nov 2019 18:16:38 +0000 (18:16 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_thumbnail_tag

git-svn-id: http://svn.redmine.org/redmine/trunk@19054 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_link_to_att...
Toshi MARUYAMA [Sat, 9 Nov 2019 18:16:27 +0000 (18:16 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_link_to_attachment

git-svn-id: http://svn.redmine.org/redmine/trunk@19053 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_section_edi...
Toshi MARUYAMA [Sat, 9 Nov 2019 18:16:15 +0000 (18:16 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_section_edit_links

git-svn-id: http://svn.redmine.org/redmine/trunk@19052 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/integration/attachments_test.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:57:36 +0000 (17:57 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/integration/attachments_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19051 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/MultilineArrayBraceLayout in app/helpers/projects_helper.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:57:35 +0000 (17:57 +0000)]
cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in app/helpers/projects_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19050 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/IndentFirstArrayElement in app/models/project.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:57:24 +0000 (17:57 +0000)]
cleanup: rubocop: fix Layout/IndentFirstArrayElement in app/models/project.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19049 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundAccessModifier in lib/redmine/syntax_hig...
Toshi MARUYAMA [Sat, 9 Nov 2019 17:57:11 +0000 (17:57 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundAccessModifier in lib/redmine/syntax_highlighting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19048 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/BlockEndNewline in app/models/message.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:57:00 +0000 (17:57 +0000)]
cleanup: rubocop: fix Layout/BlockEndNewline in app/models/message.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19047 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/helpers/issues_helper_test.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:56:49 +0000 (17:56 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/helpers/issues_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19046 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/MultilineBlockLayout in app/controllers/auto_completes_c...
Toshi MARUYAMA [Sat, 9 Nov 2019 17:11:06 +0000 (17:11 +0000)]
cleanup: rubocop: fix Layout/MultilineBlockLayout in app/controllers/auto_completes_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19045 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/EmptyLinesAroundAccessModifier in app/controllers/previe...
Toshi MARUYAMA [Sat, 9 Nov 2019 17:10:54 +0000 (17:10 +0000)]
cleanup: rubocop: fix Layout/EmptyLinesAroundAccessModifier in app/controllers/previews_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19044 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in lib/redmine/views/labelled_form_builder.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:10:41 +0000 (17:10 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in lib/redmine/views/labelled_form_builder.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19043 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/helpers/custom_fields_helper_test.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:10:40 +0000 (17:10 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/helpers/custom_fields_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19042 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in lib/redmine/menu_manager.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:10:29 +0000 (17:10 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in lib/redmine/menu_manager.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19041 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/helpers/timelog_helper_test.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:10:25 +0000 (17:10 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/helpers/timelog_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19040 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in lib/redmine/helpers/gantt.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:10:17 +0000 (17:10 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in lib/redmine/helpers/gantt.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19039 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in lib/redmine/field_format.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 17:10:02 +0000 (17:10 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in lib/redmine/field_format.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19038 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_attachment_...
Toshi MARUYAMA [Sat, 9 Nov 2019 17:09:51 +0000 (17:09 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_attachment_links_to_images_with_email_format_should_not_be_parsed

git-svn-id: http://svn.redmine.org/redmine/trunk@19037 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/unit/issue_test.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 16:33:58 +0000 (16:33 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/unit/issue_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19036 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/unit/attachment_test.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 16:33:43 +0000 (16:33 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/unit/attachment_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19035 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in app/helpers/email_addresses_helper.rb
Toshi MARUYAMA [Sat, 9 Nov 2019 16:33:33 +0000 (16:33 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in app/helpers/email_addresses_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19034 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest link_to_if_autho...
Toshi MARUYAMA [Sat, 9 Nov 2019 16:33:22 +0000 (16:33 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest link_to_if_authorized

git-svn-id: http://svn.redmine.org/redmine/trunk@19033 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_attached_im...
Toshi MARUYAMA [Sat, 9 Nov 2019 16:33:11 +0000 (16:33 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_attached_images_with_hires_naming

git-svn-id: http://svn.redmine.org/redmine/trunk@19032 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/unit/lib/redmine/scm/adapters...
Toshi MARUYAMA [Sat, 9 Nov 2019 16:05:33 +0000 (16:05 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/unit/lib/redmine/scm/adapters/git_adapter_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19031 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/unit/lib/redmine/scm/adapters...
Toshi MARUYAMA [Sat, 9 Nov 2019 16:05:22 +0000 (16:05 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/unit/lib/redmine/scm/adapters/filesystem_adapter_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19030 e93f8b46-1217-0410-a6f0-8f06a7374b81