chore(app): Do not clear unused cache key

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #38469 from nextcloud/artonge/fix/versions_init

Fix initialisation of versions in the DB

Merge pull request #38496 from nextcloud/preview-mp3-catch-errors

fix: catch errors in id3parser library

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: catch errors in id3parser library

We use a forked version of getID3 to read embedded images from mp3 files to use them as previews.

If the library is unable to extract a image or fails on something different we should handle it properly.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38492 from nextcloud/dependabot/npm_and_yarn/puppeteer-20.4.0

chore(deps-dev): Bump puppeteer from 19.10.1 to 20.4.0

Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 19.10.1 to 20.4.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-v19.10.1...puppeteer-v20.4.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38333 from nextcloud/fix/weather-star-contrast

weather_status: Improve contrast of favorite icon

fix(weather_status): Improve contrast of favorite icon

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #38481 from nextcloud/bugfix/noid/avatar-size-in-sab

fix(dav): Fix avatar size in system address book

Merge branch 'master' into artonge/fix/versions_init

fix(dav): Fix avatar size in system address book

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38467 from nextcloud/artonge/fix/files_versions_preview

Add fallback when a there is no preview for a version

Merge pull request #38429 from tanganellilore/fix_delete_user_syslink

Fix deletion of User when system link are used in him user folder

Merge pull request #38300 from nextcloud/fix/better-error-message

fix: better error message on missing user files dir

Add fallback when a there is no preview for a version

Signed-off-by: Louis Chemineau <louis@chmn.me>

Improve handling of undefined version label

Signed-off-by: Louis Chemineau <louis@chmn.me>

Fix initialisation of versions in the DB

Broken after https://github.com/nextcloud/server/pull/36690

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #38460 from nextcloud/enh/noid/adjust-sidebar-visiblity

adjust active element visibility in the sidebar

Merge pull request #38459 from nextcloud/enh/noid/adjust-usermenu-visibility

adjust active element visibility in the usermenu

fix: better error message on missing user files dir

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

adjust active element visibility in the sidebar

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #38206 from nextcloud/fix/increase-iterations-for-pbkdf2

Increase from 100000 to 600000 iterations for hash_pbkdf2

adjust active element visibility in the usermenu

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #38448 from nextcloud/fix/carddav/no-sab-guest-users

fix(carddav): Don't show system address book cards to guests

Adapt encryption test to change in generateHeader

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #38454 from nextcloud/fix/capitalization-other-tel

fix(carddav): Make system contact phone number RFC compliant

Merge pull request #38458 from nextcloud/revert/37870-Fix_table_view

Revert "Fix table view"

fix(carddav): Don't show system address book cards to guests

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Revert "Fix table view"

This reverts commit cb852ef6

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

fix(carddav): Make system contact phone number RFC compliant

Signed-off-by: greta <gretadoci@gmail.com>

Merge pull request #38423 from nextcloud/fix/carddav/check-system-address-book-enumeration

fix(carddav): Check enumeration settings for all SAB methods

fix(carddav): Check enumeration settings for all SAB methods

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38441 from nextcloud/feat/make-open-folder-action

fix(files): make open folder a default action

Merge pull request #38438 from nextcloud/feature/openapi/specs

Add OpenAPI specs

fix(files): make open folder a default action

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Add OpenAPI specs

Signed-off-by: jld3103 <jld3103yt@gmail.com>

Merge pull request #38374 from nextcloud/pulsejet/patch-ubr-nonce

webpack: add nonce to unsupported-browser-redirect chunk

Merge pull request #38415 from nextcloud/object-store-init-root

don't always check if we need to setup the object store root

webpack: add nonce to unsupported-browser-redirect chunk

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #37458 from Fenn-CS/fix/37424/better-501-error-logging

Avoid db connections when logging db connection errors

Merge pull request #38329 from nextcloud/pulsejet/patch-webpack

invert elseif on rmdir for local storage
Signed-off-by: Lorenzo Tanganelli <lorenzo.tanganelli@hotmail.it>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #36316 from nextcloud/improve-fatal-logging

Log to `error_log` in fatal case

Increase from 100000 to 600000 iterations for hash_pbkdf2

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore: recompile

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix lint errors

Signed-off-by: Varun Patil <varunpatil@ucla.edu>

Optimize webpack chunks

Signed-off-by: Varun Patil <varunpatil@ucla.edu>

Use consistent imports for Vue components

This makes tree shaking possible

Signed-off-by: Varun Patil <varunpatil@ucla.edu>

Merge pull request #37665 from fsamapoor/patch-2

Refactors Command/Encryption/Enable.php to improve code readability.

don't always check if we need to setup the object store root

Signed-off-by: Robin Appelman <robin@icewind.nl>

Log to error_log in fatal case

Signed-off-by: Robin Windey <ro.windey@gmail.com>

Merge pull request #38413 from nextcloud/fix/38412/save-avatar-SAB

fix(SAB): Save avatar to SAB

Merge pull request #38075 from nextcloud/fix/36923-The_Default_quota_input_field_in_the_Settings_section_is_not_programmatically_linked_to_its_visual_label

Add label to "default quota" multiselect

Merge pull request #38308 from nextcloud/fix/check-for-php-auth-server-variables

fix(carddav): Check if SERVER variables are set before accessing them

Add label to "default quota" multiselect

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

fix(SAB): Save avatar to SAB

Signed-off-by: Johannes Merkel <mail@johannesgge.de>

Merge pull request #38393 from nextcloud/enh/noid/improve-issue-template

bug-report-template - move `Official All-in-One appliance` to the bottom

fix(carddav): Check if SERVER variables are set before accessing them

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #38400 from nextcloud/cleanup/drop-oc-appsettings

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38365 from JanisPlayer/patch-3

add imaginary_key

Allow to specify an imaginary key

Signed-off-by: JanisPlayer <54918417+JanisPlayer@users.noreply.github.com>

Merge pull request #38259 from nextcloud/webui-share-reload

reload filelist when adding or removing shares

Merge pull request #38291 from nextcloud/fix-loading-themed-logo

fix loading custom logo image

Avoid db connection when logging db connection errors

`\OC\Log\LogDetails::logDetails` depends on `\OC_App::getAppVersions()`
which makes a database connection causing the logger to break when the database
service is unavaiable.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Replace ILogger method calls index.php

This commit replaces more ILogger method calls with
 `Psr\Log\LoggerInterface` as we gradually move away from the
 custom ILogger.

This commit aslo, sets the customPsrLogger to not depend on the
 database to `logfile` config value.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

reload filelist when adding or removing shares

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix loading custom logo image

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #38162 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

Merge pull request #38164 from nextcloud/show-pending-popover-menu-when-password-is-enabled-by-default

Show pending popover menu when password is enabled by default

Merge pull request #38227 from nextcloud/allow-enforcing-share-passwords-only-when-already-asking-for-a-password

Allow enforcing share passwords only when already asking for a password

chore(assets): Recompile JS

Signed-off-by: Joas Schilling <coding@schilljs.com>

Show pending popover menu when password is enabled by default

When "Enforce password protection" is enabled in the sharing settings a
popover menu is shown to set a password before the share is created. On
the other hand, when "Always ask for a password" was enabled in the
sharing settings and a new link share was created the share was
immediately created with a default password; the user was not able to
specify a password (nor create the share without password).

The component template already provided the needed elements to also ask
for the password without enforcing it, but the popover menu was not
shown due to "enableLinkPasswordByDefault" being missing in "if"
conditions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Rename "pendingPassword" to "pendingEnforcedPassword"

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

chore(assets): Recompile JS

Signed-off-by: Joas Schilling <coding@schilljs.com>

Disable "Enforce password protection" if not asking for a password

"Enforce password protection" is a subcase of "Always ask for a
password", so it should be disabled if its parent option is unchecked.
Although other dependant options in the sharing settings are fully
hidden instead of just disabled this option is disabled but shown to
avoid confusion when updating from a previous Nextcloud version where
"Always ask for a password" was unchecked and "Enforce password
protection" was checked.

Besides that, due to their dependency the enforced password protection
is now automatically unchecked too if its parent option is unchecked.

Finally, the groups excluded from password requirements are also
disabled when "Always ask for a password" is unchecked, as they might be
still shown if "Enforce password protection" was checked due to an
update from a previous version.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Split long line

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Indent "Enforce password protection"

"Enforce password protection" is a subcase of "Always ask for a
password", so it should be indented to visually show the dependency.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Replace "div" with "span" inside "p"

The permitted contents of a paragraph are only phrasing contents, so
"div" elements can not be used, although "span" can. Besides being
invalid HTML it seems that the browser ends the paragraph at the div, so
the label/input that appears after it is treated as being in a new
paragraph, which is not indented by default, and thus is not aligned
with the rest of its sibling inputs.

Note that an additional div is nevertheless added once the page is
loaded to be able to select the groups, but this one does not break its
parent paragraph (maybe due to being added after the page load, but I do
not really know). Nevertheless, it needs to be explicitly indented, and
the second indentend wrapper needs to be removed, as it affects only the
label but not the div/input, and therefore the label had an extra
indentation over the input.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Move "br" immediately after "label" for consistency with other elements

The rest of "<br/>" elements in the file appear immediately after their
previous "</label>" rather than in a new line.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add missing end tag for "label"

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

bug-report-template - move archive to the top

Signed-off-by: Simon L <szaimen@e.mail.de>

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore: Remove deprecated OC.appSettings

Was deprecated since NC17 and scheduled for removal on NC18.
No apps use it and neither do core.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #38372 from nextcloud/dependabot/npm_and_yarn/tar-6.1.15

chore(deps-dev): Bump tar from 6.1.14 to 6.1.15

Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.14 to 6.1.15.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/isaacs/node-tar/compare/v6.1.14...v6.1.15)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38354 from nextcloud/pulsejet/patch-ubr

Make unsupported browser check asynchronous

Make unsupported browser check asynchronous

This check is very expensive, and will pass almost 100% of the time.

Related #36728
Depends on #38329

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #37758 from nextcloud/redis-atomic

redis: use atomic operations everywhere

Merge pull request #38332 from nextcloud/pulsejet/patch-dead1

Remove some dead code in files app

Merge pull request #32775 from nextcloud/fix/23877/unread-comments