]>
source.dussan.org Git - tigervnc.git/log
Pierre Ossman [Mon, 23 Jan 2023 18:55:20 +0000 (19:55 +0100)]
Remove custom CharArray type
It has now been replaced, mostly by std::string, so remove the actual
type definition.
Pierre Ossman [Tue, 17 Jan 2023 15:38:59 +0000 (16:38 +0100)]
Use std::string for string memory management
Avoids a bit of complexity by delegating that handling to a string
object.
Pierre Ossman [Fri, 13 Jan 2023 11:47:48 +0000 (12:47 +0100)]
Use std::string instead of CharArray
Let's use a more common type instead of something homegrown. Should be
more familiar to new developers.
Pierre Ossman [Sun, 15 Jan 2023 13:01:28 +0000 (14:01 +0100)]
Use std::vector for temporary char arrays
It's more standard and familiar than our custom CharArray type, and it
still gives us automatic freeing of the buffer.
We could probably have used std::unique_ptr instead, but we are
currently targeting older compilers where C++11 isn't standard yet.
Pierre Ossman [Sun, 15 Jan 2023 13:00:12 +0000 (14:00 +0100)]
Free char buffer directly
It's extreme overkill to inherit from CharArray just to get the
automatic freeing of the buffer when the object is destroyed.
Pierre Ossman [Wed, 11 Jan 2023 16:21:56 +0000 (17:21 +0100)]
Make strSplit() simpler and safer
Get rid of all the magical re-allocation and shuffling and instead just
return a new set of strings that is fully splitted. Will consume a bit
more memory, but is a lot safer to use as there is less confusion about
ownership of memory.
Pierre Ossman [Tue, 10 Jan 2023 13:30:37 +0000 (14:30 +0100)]
Return std::string instead of dynamic allocations
We mostly use classical C strings, but the memory management around them
can get confusing and error prone. Let's use std::string for the cases
where we need to return a newly allocated string.
Pierre Ossman [Tue, 10 Jan 2023 18:23:50 +0000 (19:23 +0100)]
Specify expected array size in arguments
The compiler doesn't enforce this, but it at least documents the
expected array size.
Pierre Ossman [Sun, 15 Jan 2023 13:41:47 +0000 (14:41 +0100)]
Use fixed size character buffer
We know the needed space here, so let's keep it simple with a constant
size string buffer.
Pierre Ossman [Tue, 17 Jan 2023 18:09:26 +0000 (19:09 +0100)]
Remove trailing slash from getvnchomedir()
It should return a path to the directory itself, just like its sister
function getuserhomedir().
Pierre Ossman [Tue, 17 Jan 2023 18:03:25 +0000 (19:03 +0100)]
Namespace directory functions
All library functions should be in a proper namespace.
Pierre Ossman [Fri, 13 Jan 2023 10:15:36 +0000 (11:15 +0100)]
Better fallback for missing peer address
A blank string might be very confusing, depending on where this will be
used. Let's give something more visible back in the cases where we
cannot get the proper name for the peer.
Pierre Ossman [Fri, 13 Jan 2023 10:14:21 +0000 (11:14 +0100)]
Return static char buffer from some methods
This mimics how some system functions (like inet_ntop()) work, and
avoids complexity around ownership of the returned string buffer.
The downside is that the string must be consumed directly as it will be
overwritten on the next call, but that is not an issue with the current
usage.
Pierre Ossman [Tue, 17 Jan 2023 17:37:04 +0000 (18:37 +0100)]
Replace tabs with spaces
Use the same indentation we use in all other files.
Pierre Ossman [Mon, 23 Jan 2023 19:08:43 +0000 (20:08 +0100)]
Use string literal instead of dynamic buffer
These don't need to be changed, so let's just keep it simple with a
constant string literal.
Pierre Ossman [Mon, 23 Jan 2023 19:00:49 +0000 (20:00 +0100)]
Remove unneded string duplication
It's unclear why this was initially added. The function takes string
constants, so it is not going to modify these.
Pierre Ossman [Tue, 17 Jan 2023 15:49:01 +0000 (16:49 +0100)]
Remove unneeded CharArray:s
Avoid complicating things by moving things in to a second buffer here as
there is no need for it.
Pierre Ossman [Tue, 10 Jan 2023 18:26:48 +0000 (19:26 +0100)]
Use StringParameters directly
We don't need to make extra copies of the string in most cases, so let's
simplify the code and access the string directly when we can.
Pierre Ossman [Tue, 10 Jan 2023 20:24:21 +0000 (21:24 +0100)]
Get rid of TCHAR magic
We never use Windows' "UNICODE" mode anyway, so let's get rid of this
complexity.
Pierre Ossman [Sun, 15 Jan 2023 15:55:34 +0000 (16:55 +0100)]
Return std::vector instead of dynamic allocation
This makes memory management more clear and robust when using these
helper functions.
Pierre Ossman [Thu, 5 Jan 2023 17:17:07 +0000 (18:17 +0100)]
Avoid duplicating configuration setting
Let the string helpers call the more fancy setParam(). This makes sure
we can avoid duplicating things.
Pierre Ossman [Sat, 4 Feb 2023 12:07:04 +0000 (13:07 +0100)]
Make sure length is reset on assignment
Otherwise the old length is preserved, which will result in NULL pointer
dereferencing if the parameter is ever accessed.
Pierre Ossman [Thu, 17 Nov 2022 14:32:48 +0000 (15:32 +0100)]
Clean up BinaryParameter typing
This is explicitly a byte sequence, so let's try to keep a consistent
typing.
Pierre Ossman [Thu, 17 Nov 2022 14:04:20 +0000 (15:04 +0100)]
Move hex conversion helpers to util
These are used here and there so let's make them more general rather
than hiding them in the stream classes.
Pierre Ossman [Mon, 9 Jan 2023 18:01:35 +0000 (19:01 +0100)]
Use std::vector for basic data arrays
Avoid our own custom types in favour of what's already included with
C++.
Pierre Ossman [Sat, 10 Sep 2022 11:19:41 +0000 (13:19 +0200)]
Use stdint types
Avoid having our own custom stuff and instead use the modern, standard
types, for familiarity.
Pierre Ossman [Sat, 10 Sep 2022 11:48:53 +0000 (13:48 +0200)]
Use templates for optimized code
Avoid preprocessor magic and instead rely on templating to generate
optimized functions for performance critical code.
Pierre Ossman [Tue, 17 Jan 2023 11:57:07 +0000 (12:57 +0100)]
Fix CRLF line endings
Everything else uses LF line endings, so fix up the few stray ones.
Pierre Ossman [Tue, 10 Jan 2023 19:00:42 +0000 (20:00 +0100)]
Merge branch 'libtool' of https://github.com/CendioOssman/tigervnc
Pierre Ossman [Wed, 16 Nov 2022 06:59:55 +0000 (07:59 +0100)]
Create .la files at the end of the cmake run
We might not have all the necessary information, e.g. all targets might
not exist yet, until we're done going through all CMakeLists.
Pierre Ossman [Wed, 16 Nov 2022 06:58:55 +0000 (07:58 +0100)]
Bail on missing libraries
They may be crucial, so refuse to continue if this happens.
Pierre Ossman [Wed, 16 Nov 2022 06:57:44 +0000 (07:57 +0100)]
Fall back to dynamic libraries in .la files
This is what the linker does, so we should do the same for correct
behaviour.
Pierre Ossman [Wed, 16 Nov 2022 06:56:41 +0000 (07:56 +0100)]
Respect library search paths
Things might be in odd places, so make sure we respect where we're told
to look for libraries.
Pierre Ossman [Wed, 16 Nov 2022 06:55:03 +0000 (07:55 +0100)]
Include other targets in .la files
We have internal dependencies that should be respected, as otherwise it
will be up to the user of the .la file to figure out the correct order
of the libraries.
Pierre Ossman [Wed, 16 Nov 2022 14:48:32 +0000 (15:48 +0100)]
Handle alternative library suffixes
I think this only affects macOS at the moment where they also have .tbd
files for linking.
Pierre Ossman [Wed, 16 Nov 2022 06:54:01 +0000 (07:54 +0100)]
Make sure frameworks are included in .la files
We don't really use the .la files for macOS at the moment, but let's try
to be prepared.
Pierre Ossman [Wed, 16 Nov 2022 06:52:02 +0000 (07:52 +0100)]
Remove unnecessary regexp \\
This serves no useful purpose as we have no reason to suspect there will
be a dangerous first character in these variables.
Pierre Ossman [Wed, 16 Nov 2022 06:48:31 +0000 (07:48 +0100)]
Fix static library check regexp
Not sure how the old one ever worked as it incorrectly just tried to
match last character and nothing else.
Pierre Ossman [Wed, 16 Nov 2022 06:46:50 +0000 (07:46 +0100)]
Get target libraries from INTERFACE_LINK_LIBRARIES
<target>_LIB_DEPENDS is an internal variable that contains lots of other
weird stuff.
Pierre Ossman [Wed, 16 Nov 2022 06:45:58 +0000 (07:45 +0100)]
Use correct FATAL_ERROR CMake option
Pierre Ossman [Thu, 5 Jan 2023 15:56:14 +0000 (16:56 +0100)]
Merge branch 'wextra' of https://github.com/CendioOssman/tigervnc
Pierre Ossman [Wed, 4 Jan 2023 15:22:13 +0000 (16:22 +0100)]
Use __attribute__:s directly
These are supported by gcc and clang, and I don't think MSVC works well
with our code anyway, so let's keep things simple and use these
directly.
Pierre Ossman [Wed, 4 Jan 2023 15:35:47 +0000 (16:35 +0100)]
Enable more warnings by default
These are also useful warnings that tend to find real bugs, so let's
enable then.
The downside is they require us to mark certain things so the compiler
knows if they were on purpose or not.
Pierre Ossman [Wed, 4 Jan 2023 18:43:16 +0000 (19:43 +0100)]
Work around -Wcast-function-type
That warning doesn't play well with Windows' GetProcAddress(), so add
some extra casting to work around it.
Pierre Ossman [Wed, 4 Jan 2023 18:24:34 +0000 (19:24 +0100)]
Remove old mingw compatibility code
This isn't needed with modern build environments, and can even conflict
with them.
Pierre Ossman [Wed, 4 Jan 2023 15:33:44 +0000 (16:33 +0100)]
Don't partially init monitor information
gcc will complain, and we will fill out all fields later anyway.
Pierre Ossman [Wed, 4 Jan 2023 15:32:54 +0000 (16:32 +0100)]
Fix incorrect types
These types caused an incorrect signed/unsigned behaviour, so let's make
sure we use the appropriate type.
Pierre Ossman [Wed, 4 Jan 2023 15:32:06 +0000 (16:32 +0100)]
Fix order of qualifiers
gcc can get upset if they aren't in this order.
Pierre Ossman [Wed, 4 Jan 2023 15:29:38 +0000 (16:29 +0100)]
Protect key variables from setjmp()
If we don't mark these as volatile then they might get reset on
longjmp() and the code will misbehave.
Pierre Ossman [Wed, 4 Jan 2023 15:28:13 +0000 (16:28 +0100)]
Remove useless const specifiers
These are just values, so setting const on them has no effect as the
caller will get a copy.
Pierre Ossman [Wed, 4 Jan 2023 15:27:27 +0000 (16:27 +0100)]
Remove useless checks
These are all truisms because of the valid range of the types.
Pierre Ossman [Wed, 4 Jan 2023 15:26:02 +0000 (16:26 +0100)]
Explicitly mark switch case fall through
This allows us to separate accidental fall through from explicit ones,
which allows us to turn on such checks in the compiler.
Pierre Ossman [Thu, 5 Jan 2023 08:41:26 +0000 (09:41 +0100)]
Fix RSA-AES state machines
If there isn't enough data, then the client reading the hash will fall
down and try to read the subtype instead, which isn't correct.
Invert the logic so we get a more consistent way through where we only
break out when there is insufficient data.
Do the same for the server code, for consistency.
Yuri Kozlov [Thu, 5 Jan 2023 07:07:00 +0000 (10:07 +0300)]
Update Russian translation
Pierre Ossman [Wed, 4 Jan 2023 19:36:26 +0000 (20:36 +0100)]
Add missing breaks to Windows key grab code
These were not meant to fall through. Likely didn't have any adverse
effects, but let's fix it anyway.
Pierre Ossman [Wed, 4 Jan 2023 15:18:46 +0000 (16:18 +0100)]
Explicitly mark unused parameters
This allows us to separate accidentally unused, from explicitly unused
parameters, which allows us to turn on such checks in the compiler.
Pierre Ossman [Wed, 4 Jan 2023 15:34:23 +0000 (16:34 +0100)]
Respect given server name
No practical difference currently, but let's respect what this API was
supposed to do.
Pierre Ossman [Wed, 4 Jan 2023 15:34:09 +0000 (16:34 +0100)]
Don't include unused file path parameter
Pierre Ossman [Wed, 4 Jan 2023 15:31:39 +0000 (16:31 +0100)]
Don't include palette to full color methods
They have no need for it, so let's simplify things.
Pierre Ossman [Wed, 4 Jan 2023 15:29:02 +0000 (16:29 +0100)]
Remove unused flags to decoder contexts
Everything in flags is already handled at a higher level.
Pierre Ossman [Wed, 4 Jan 2023 15:24:54 +0000 (16:24 +0100)]
Stop supplying flags to clipboard peek handler
The flags should always be empty anyway.
Pierre Ossman [Wed, 4 Jan 2023 18:16:13 +0000 (19:16 +0100)]
Mark system include paths correctly
This makes sure the compiler doesn't complain about problems in those
files.
Pierre Ossman [Wed, 4 Jan 2023 15:11:21 +0000 (16:11 +0100)]
Always enable -Wvla
It's only the -Werror part we want to be conditional on being debug
builds.
Pierre Ossman [Mon, 2 Jan 2023 11:55:17 +0000 (12:55 +0100)]
Remove debugging strdup()
This was not meant to be included in the previous commit. The static
storage for the font string is more than enough.
Pierre Ossman [Mon, 2 Jan 2023 11:28:25 +0000 (12:28 +0100)]
Keep font name in permanent memory
Fl::set_font() doesn't keep its own copy, so we need to make sure the
font string doesn't get freed or overwritten at a later point.
Pierre Ossman [Fri, 30 Dec 2022 13:11:05 +0000 (14:11 +0100)]
Use Rocky Linux for RHEL builds
CentOS Stream isn't fully compatible with RHEL, and there are no useful
RHEL images available, so that leaves us with one of the new RHEL forks.
Pierre Ossman [Tue, 27 Dec 2022 09:11:18 +0000 (10:11 +0100)]
Merge branch 'add-ard-mslogonii' of https://github.com/pdlan/tigervnc
Dinglan Peng [Tue, 27 Dec 2022 09:06:08 +0000 (04:06 -0500)]
Add client-side support for the MSLogonII security type.
Dinglan Peng [Tue, 27 Dec 2022 09:05:19 +0000 (04:05 -0500)]
Add client-side support for the DH security type.
Luna Jernberg [Fri, 23 Dec 2022 23:37:00 +0000 (00:37 +0100)]
Update Swedish translation
Brian Hinz [Fri, 23 Dec 2022 03:44:04 +0000 (22:44 -0500)]
Merge pull request #1525 from pdlan/add-ra2-java
Add support for RSA-AES security types (Java version)
Göran Uddeborg [Mon, 19 Dec 2022 20:23:00 +0000 (21:23 +0100)]
Update Swedish translation
Lauri Nurmi [Wed, 21 Dec 2022 20:34:00 +0000 (22:34 +0200)]
Update Finnish translation
Petr Pisar [Thu, 22 Dec 2022 12:47:00 +0000 (13:47 +0100)]
Update Czech translation
Pierre Ossman [Thu, 22 Dec 2022 12:43:02 +0000 (13:43 +0100)]
Merge branch 'newoptions' of https://github.com/CendioOssman/tigervnc
Pierre Ossman [Fri, 15 Jul 2022 12:50:46 +0000 (14:50 +0200)]
Respect system UI font
Use the font specified by the system for UI elements. For Windows and
macOS this is straight forward, but Linux is more complex as there is no
single source for this information.
Pierre Ossman [Fri, 17 Jun 2022 10:48:56 +0000 (12:48 +0200)]
Fix up padding for radio/check buttons
Try to follow the actual padding that FLTK adds to these widgets.
The extra one pixel on each is because of a bug in FLTK's focus drawing
code, where the box is always one pixel too small in both dimensions.
Pierre Ossman [Fri, 17 Jun 2022 10:48:13 +0000 (12:48 +0200)]
Reduce indent to same as a normal margin
This is how GNOME does things, so let's do the same so things look
similar.
Pierre Ossman [Fri, 17 Jun 2022 10:47:34 +0000 (12:47 +0200)]
Wider margin around window edges
To conform with how e.g. GNOME sets its margins.
Pierre Ossman [Thu, 16 Jun 2022 11:28:45 +0000 (13:28 +0200)]
Dynamically size Fl_Group:s
This makes the code much cleaner, and easier to update.
Pierre Ossman [Fri, 17 Jun 2022 11:31:53 +0000 (13:31 +0200)]
Make UserDialog use standard layout constants.
Makes it easier to adjust the UI from a central place.
Pierre Ossman [Thu, 16 Jun 2022 11:13:03 +0000 (13:13 +0200)]
Make ServerDialog use standard layout constants
Makes it easier to adjust the UI from a central place.
Pierre Ossman [Fri, 14 Jan 2022 18:50:15 +0000 (19:50 +0100)]
Modern look for options sections
Outlines are no longer commonly used. Instead visually separated
headlines are the norm.
Pierre Ossman [Fri, 14 Jan 2022 13:07:19 +0000 (14:07 +0100)]
Change to modern layout in options dialog
Classical tabs are very dated. They are also a practical problem as you
get very limited in the numbers of tabs we can have, and how long the
text can be on them.
Switch to one popular modern model with a list on the left instead where
pages can be selected.
Pierre Ossman [Mon, 19 Dec 2022 14:47:52 +0000 (15:47 +0100)]
Rebuild .desktop and metainfo when needed
If the translations change then these files need to be regenerated as
they include data from those.
Yi-Jyun Pan [Fri, 16 Dec 2022 11:30:00 +0000 (19:30 +0800)]
Update Chinese (traditional) translation
Yuri Chornoivan [Fri, 16 Dec 2022 11:54:00 +0000 (13:54 +0200)]
Update Ukranian translation
Remus-Gabriel Chelu [Fri, 16 Dec 2022 10:59:00 +0000 (11:59 +0100)]
Update Romanian translation
Andika Triwidada [Fri, 16 Dec 2022 11:11:00 +0000 (18:11 +0700)]
Update Indonesian translation
Yaron Shahrabani [Fri, 16 Dec 2022 09:33:00 +0000 (11:33 +0200)]
Update Hebrew translation
Cristian Othón Martínez Vera [Fri, 16 Dec 2022 14:54:00 +0000 (08:54 -0600)]
Update Spanish translation
Mario Blättermann [Fri, 16 Dec 2022 14:57:00 +0000 (15:57 +0100)]
Update German translation
Alexander Shopov [Fri, 16 Dec 2022 10:27:00 +0000 (12:27 +0200)]
Updated Bulgarian translation
Pierre Ossman [Thu, 15 Dec 2022 15:40:54 +0000 (16:40 +0100)]
Change development version to 1.13.80
Pierre Ossman [Thu, 15 Dec 2022 15:22:33 +0000 (16:22 +0100)]
Update translation template file
Pierre Ossman [Thu, 15 Dec 2022 15:36:16 +0000 (16:36 +0100)]
Don't translate "RSA-AES"
It's just the name of the system, so there is nothing in that string to
translate.
Pierre Ossman [Thu, 15 Dec 2022 15:05:09 +0000 (16:05 +0100)]
Merge branch 'improve-passwd-permission-error-message' of https://github.com/shuuji3/tigervnc
Pierre Ossman [Thu, 15 Dec 2022 15:03:13 +0000 (16:03 +0100)]
Move window to front on full screen
This should be happening implicitly, but isn't always for some reason on
macOS 13.
TAKAHASHI Shuuji [Wed, 14 Dec 2022 15:36:59 +0000 (15:36 +0000)]
Improve error message when `passwd `file has a bad permission
Pierre Ossman [Tue, 14 Dec 2021 16:06:36 +0000 (17:06 +0100)]
Handle macOS keyboard stealing
The system steals keyboard events for certain system keyboard shortcuts,
e.g. Cmd+Tab. Unfortunately this isn't considered a focus loss, so we
don't realise we've lost a few keyboard events and can end up in a
confused state.
Fortunately it is possible to detect when this happens and reset the
keyboard state, just like we do when focus is lost.