Merge pull request #40482 from nextcloud/fix/workflowengine_fileaccess

Merge pull request #41064 from nextcloud/fix/40705-_increase_contrast_on_Device_and_Last_activity

Remove opacity on table header

enh(IMountManager): Add method to get MountPoint from CachedMountInfo

Signed-off-by: Jonas <jonas@freesources.org>

fix(isLegitimatedForUserId): Setup mountpoints to check file access

This fixes workflows on groupfolders, as it will consider access to
files in groupfolders.

It also fixes false positives where access to files was limited by other
means not taken into account before, e.g. access control.

For postDelete events, check for permissions of the parent folder
instead, as the file itself no longer exists.

Fixes: nextcloud/flow_notifications#71
Signed-off-by: Jonas <jonas@freesources.org>

Merge pull request #40495 from nextcloud/fix/master-name-in-share-cache

Merge pull request #41063 from nextcloud/fix/37092/dashboard-html-validation

Merge pull request #40980 from nextcloud/fix/37092/remove-unnecessary-roles

Merge pull request #41017 from nextcloud/fix/move-token-iprovider-to-ocp

Move IToken and IProvider::getToken to OCP

Merge pull request #41034 from nextcloud/fix/37092/users--html-validation

fix(settings): users page html validation

Remove opacity on table header

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

chore(assets): Recompile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(dashboard): use span instead of div for icon to html

- div is not valid in h2
- div is not valid in label

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Allow passing null to PublicKeyToken::setScope, fixes tests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Improve docblock annotations for tokens and their exceptions

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Use more precise typing for setScope method parameter

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #41055 from nextcloud/feat/noid/profile-manager-ocp

feat(profile): Add public interface for profile manager so apps can check config

Merge pull request #41045 from nextcloud/fix/openapi/provisioning_api/quota-fields

fix(provisioning_api): Fix quota fields in OpenAPI

fix(profile): Directly migrate to OCP constants

Signed-off-by: Joas Schilling <coding@schilljs.com>

feat(profile): Add public interface for profile manager so apps can check config

Signed-off-by: Joas Schilling <coding@schilljs.com>

Update autoloaders

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Make sure that OC interfaces returns OC interfaces for backward compatibility

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(provisioning_api): Fix quota fields in OpenAPI

Signed-off-by: jld3103 <jld3103yt@gmail.com>

Move Exceptions used in OCP to OCP

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Adapt baseline to filename change

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Align PublicKeyToken with interface changes

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #40933 from nextcloud/check-datemax-enforcement-pubshare

Check expiry enforcement for all share types

Merge pull request #40966 from nextcloud/jr-security-policy-expansion

Add "no public GH Issues please" request, past advisories link, bounty mention, scope link to security.md

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #41039 from nextcloud/fix/run-cypress-always-parallel

feat(cypress): Always run cypress CI in parallel

Do not treat `isDefaultExpireDateEnforced` as fallback

`isDefaultExpireDateEnforced` and its corresponding `defaultExpirationDate`
is currently treated as the enforcement fallback when share type enforcements are not
set.

However, `isDefaultExpireDateEnforced` and `defaultExpirationDate` are actually more like
`isDefaultPublicExpireDateEnforced` and `defaultPublicExpirationDate` and therefore only applies
to public shares.

It might be ideal to rename this variables all the way from the backend config to the way we use
them in the frontend code.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Fix has expiration date logic

Current expiration date errorneously assumes that `defaultExpirationDate`
applies to all kinds of shares. But it only really applies to public shares despite
its name.

This commit, fixes that by paring expiration dates with the correct share types during
new share initialization and simplifying the `hasExpirationDate` (check) property.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Check expiry enforcement for all share types

We should check that a maximum expiry date has been enforced for
all shares and NOT JUST FOR internal shares before enforcing a UI max date,
like in commit 9757e680e2f643fe19432255c4142e96fbc88df5

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Merge pull request #41024 from nextcloud/fix/follow-up-app-order

Merge pull request #41032 from nextcloud/dependabot/npm_and_yarn/typescript-5.2.2

chore(deps-dev): Bump typescript from 5.1.6 to 5.2.2

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #41019 from nextcloud/fix-files-vl-h

fix(files): correct item height

fix(files): correct item height

1. grid: typo? The icon size is 160 - 44 + (44 / 2) = 138px
2. non-grid: border is already included in height because the tr
   is a border-box (made this explicit to be safe)

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #41029 from nextcloud/dependabot/npm_and_yarn/nextcloud/calendar-availability-vue-2.0.0-beta.3

chore(deps): Bump @nextcloud/calendar-availability-vue from 2.0.0-beta.2 to 2.0.0-beta.3

Merge pull request #41028 from nextcloud/dependabot/npm_and_yarn/types/dockerode-3.3.21

chore(deps-dev): Bump @types/dockerode from 3.3.20 to 3.3.21

chore(deps): Bump @nextcloud/calendar-availability-vue

Bumps [@nextcloud/calendar-availability-vue](https://github.com/nextcloud/calendar-availability-vue) from 2.0.0-beta.2 to 2.0.0-beta.3.
- [Changelog](https://github.com/nextcloud/calendar-availability-vue/blob/main/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/calendar-availability-vue/compare/v2.0.0-beta.2...v2.0.0-beta.3)

---
updated-dependencies:
- dependency-name: "@nextcloud/calendar-availability-vue"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #41027 from nextcloud/dependabot/github_actions/actions/checkout-4.1.1

chore(deps): Bump actions/checkout from 4.1.0 to 4.1.1

Merge pull request #41026 from nextcloud/dependabot/github_actions/peter-evans/create-or-update-comment-3.1.0

chore(deps): Bump peter-evans/create-or-update-comment from 3.0.2 to 3.1.0

Merge pull request #41030 from nextcloud/dependabot/npm_and_yarn/eslint-plugin-cypress-2.15.1

chore(deps-dev): Bump eslint-plugin-cypress from 2.14.0 to 2.15.1

Merge pull request #41036 from nextcloud/skjnldsv-patch-1

fix(l10n): invalid translation of a number

feat(cypress): Always run cypress CI in parallel (independent from cypress.io)

The server always exceeds the free Cypress.io time so there is no benefit using it
unless we go for the enterprise plan.
So this simply uses `cypress-split` to split the specs and run them in parallel CI workers (only e2e tests).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore(assets): Re-compile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(core): remove unnecessary role=contentinfo from page footer on login

`<footer>` has this role initially then it is a page footer, not inside `section`/`article`, and etc.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(core): remove unnecessary role=banner on top level header

By default, the HTML's `<header>` element has an identical meaning to the banner landmark,
unless it is a descendant of `<aside>`, `<article>`, `<main>`, `<nav>`, or `<section>`.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(l10n): invalid translation of a number

fix https://github.com/nextcloud/server/issues/35252

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>

chore(assets): Re-compile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(settings): label user quota progress with aria-labelledby

Labeling with `<label>` doesn't work in some screen readers.
`<label>` also doesn't work as a clickable link here.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore: Compile assets

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

feat(theming): Allow to reset the user defined app order to the default value

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(theming): App order settings - ensure the focus is kept on button

When pressing a button for changing the app order that button should keep the focus after reordering the list.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(settings): users page html validation

- Remove non-existing `button-class` from `NcAppNavigationNew`
- Type: use `input-id` instead of `id` on `NcSelect` to be labeled
- Encode uniqueId with user's ID, because user.id may contain space

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(deps-dev): Bump typescript from 5.1.6 to 5.2.2

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.1.6 to 5.2.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](https://github.com/Microsoft/TypeScript/compare/v5.1.6...v5.2.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps-dev): Bump eslint-plugin-cypress from 2.14.0 to 2.15.1

Bumps [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress) from 2.14.0 to 2.15.1.
- [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases)
- [Commits](https://github.com/cypress-io/eslint-plugin-cypress/compare/v2.14.0...v2.15.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps-dev): Bump @types/dockerode from 3.3.20 to 3.3.21

Bumps [@types/dockerode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/dockerode) from 3.3.20 to 3.3.21.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/dockerode)

---
updated-dependencies:
- dependency-name: "@types/dockerode"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): Bump actions/checkout from 4.1.0 to 4.1.1

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/8ade135a41bc03ea155e62e844d188df1ea18608...b4ffde65f46336ab88eb53be808477a3936bae11)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): Bump peter-evans/create-or-update-comment

Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 3.0.2 to 3.1.0.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases)
- [Commits](https://github.com/peter-evans/create-or-update-comment/compare/c6c9a1a66007646a28c153e2a8580a5bad27bcfa...23ff15729ef2fc348714a3bb66d2f655ca9066f2)

---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #40983 from nextcloud/fix/37092/personal-settings--html-validation

HTML Validation: Personal settings

chore(assets): Re-compile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(settings): remove unused savePrimaryEmailScope on Personal Settings page

If was replaced with universal `savePrimaryAccountPropertyScope`.
`<HeaderBar>` has no `handle-scope-change` prop.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(settings): remove placeholder from select

There is no placeholder attribute on select element

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(settings): typo in avatar prop

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(settings): remove invalid avatar prop

There was a typo, it must have been disable-menu, not disableD-menu.
But it is not required, because the menu is disabled for the current user anyway.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(settings): fix ids and aria-labels in personal emails

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(settings): remove empty aria-describedby

Empty string `''` is still rendered and is not a valid ID.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Merge pull request #40993 from nextcloud/pulsejet/oc-cap-refactor

refactor: remove remaining usage of OC::getCapabilities

Merge pull request #41018 from nextcloud/fix-files-list-header

fix(files): disable size containment on headers

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files): disable size containment on headers

Signed-off-by: Varun Patil <varunpatil@ucla.edu>

Move IToken and IProvider::getToken to OCP

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore: Compile assets

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

refactor: remove remaining usage of OC::getCapabilities

Signed-off-by: Varun Patil <varunpatil@ucla.edu>

Merge pull request #41008 from nextcloud/fix/36965-fix-trusted-server-input

Fix trusted server input field

Merge pull request #40994 from nextcloud/fix/37092/user-menu-validation

fix(user_menu): pass only actual prop to user menu entries

Apply suggestions

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

Fix trusted server input field

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

Merge pull request #40999 from nextcloud/files-list-will-change

fix(files): virtual list will-change value

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Merge pull request #41000 from nextcloud/fix/local-cypress-tests

Merge pull request #40979 from nextcloud/fix/36965-fix-global-search

Fix placement of actions within unified search

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #40978 from nextcloud/fix/37092/replace-non-standard-autocorrect-with-spellcheck

HTML Validation: replace non standard `autocorrect` with `spellcheck`

Merge pull request #40844 from nextcloud/feat/frontend-apporder-default-apps

feat: Allow to configure the app menu order in the frontend

fix: replace non-standard autocorrect with spellcheck attribute

`autocorrect` was actual for Safari long time ago when Safari didn't fully supported HTML 5 spellcheck.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore: Compile assets

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

feat(theming): Allow to configure default apps and app order in frontend settings

* Also add API for setting the value using ajax.
* Add cypress tests for app order and defaul apps

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

feat(NavigationManager): Always sort the default app first

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

feat(IAppManager): Allow to set the (user) default apps and get all global default apps

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(cypress): Also sync `3rdparty` directory for local cypress tests

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #40961 from nextcloud/fix/cypress-tests

fix(cypress): Replace flaky password-confirmation hack

Merge pull request #40992 from nextcloud/fix/37092/weather-status-html-validation

fix(weather_status): remove `li` wrapper

chore(assets): Re-compile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Fix placement of actions within unified search

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

fix(core): do not assign all navigation entry properties as html attributes

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Merge pull request #40924 from AIlkiv/shortcut-ctrl-f-for-different-keyboard-layouts

Shortcut Ctrl+F for different keyboard layouts

Merge pull request #40963 from nextcloud/fix/36965-fix-width-of-sharing-entry

Reduce width of sharing entry