]> source.dussan.org Git - poi.git/log
poi.git
6 years ago[bug-55713] Wrong ErrorStyle for DataValidations. Thanks to Philemon Schucker. This...
PJ Fanning [Wed, 31 Jan 2018 00:00:17 +0000 (00:00 +0000)]
[bug-55713] Wrong ErrorStyle for DataValidations. Thanks to Philemon Schucker. This closes #95

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822719 13f79535-47bb-0310-9956-ffa450edef68

6 years agoadd missing licenses to source code
PJ Fanning [Tue, 30 Jan 2018 13:31:16 +0000 (13:31 +0000)]
add missing licenses to source code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822641 13f79535-47bb-0310-9956-ffa450edef68

6 years ago[github-81] Formula adjusting in context of column shifting. Thanks to Dragan Jovanov...
PJ Fanning [Tue, 30 Jan 2018 13:16:49 +0000 (13:16 +0000)]
[github-81] Formula adjusting in context of column shifting. Thanks to Dragan Jovanović. This closes #81

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822639 13f79535-47bb-0310-9956-ffa450edef68

6 years agoadd byte-buddy and objenesis dependencies for mockito
PJ Fanning [Tue, 30 Jan 2018 12:57:47 +0000 (12:57 +0000)]
add byte-buddy and objenesis dependencies for mockito

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822636 13f79535-47bb-0310-9956-ffa450edef68

6 years ago[bug-62038] add mockito based unit test
PJ Fanning [Mon, 29 Jan 2018 15:21:59 +0000 (15:21 +0000)]
[bug-62038] add mockito based unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822517 13f79535-47bb-0310-9956-ffa450edef68

6 years agoignore broken test temporarily
PJ Fanning [Sat, 27 Jan 2018 14:18:05 +0000 (14:18 +0000)]
ignore broken test temporarily

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822409 13f79535-47bb-0310-9956-ffa450edef68

6 years agosome changes to allow shared string table to be subclassed
PJ Fanning [Sat, 27 Jan 2018 13:30:52 +0000 (13:30 +0000)]
some changes to allow shared string table to be subclassed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822404 13f79535-47bb-0310-9956-ffa450edef68

6 years ago[github-90] change default DSIG algorithm to SHA256. Thanks to Jörn Franke. This...
PJ Fanning [Fri, 26 Jan 2018 13:30:32 +0000 (13:30 +0000)]
[github-90] change default DSIG algorithm to SHA256. Thanks to Jörn Franke. This closes #90

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822293 13f79535-47bb-0310-9956-ffa450edef68

6 years agoadd gradle wrapper
PJ Fanning [Fri, 26 Jan 2018 12:53:02 +0000 (12:53 +0000)]
add gradle wrapper

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822290 13f79535-47bb-0310-9956-ffa450edef68

6 years agobouncycastle 1.59
PJ Fanning [Fri, 26 Jan 2018 12:38:49 +0000 (12:38 +0000)]
bouncycastle 1.59

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822285 13f79535-47bb-0310-9956-ffa450edef68

6 years ago[bug-62038] handle null font size in XSLFTextRun copy
PJ Fanning [Fri, 26 Jan 2018 07:51:57 +0000 (07:51 +0000)]
[bug-62038] handle null font size in XSLFTextRun copy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822253 13f79535-47bb-0310-9956-ffa450edef68

6 years agocode cleaning according to code review recommendations (closes #93)
Alain Béarez [Thu, 25 Jan 2018 19:59:52 +0000 (19:59 +0000)]
code cleaning according to code review recommendations (closes #93)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822224 13f79535-47bb-0310-9956-ffa450edef68

6 years agorelated to Bug 61991 -- include docx in test suite to trigger inclusion of CTPictureBase
Tim Allison [Tue, 23 Jan 2018 18:05:23 +0000 (18:05 +0000)]
related to Bug 61991 -- include docx in test suite to trigger inclusion of CTPictureBase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822033 13f79535-47bb-0310-9956-ffa450edef68

6 years ago[Bug 61972] Adding chart in Document of MS-Word File without reading Temp MS-Word...
PJ Fanning [Sat, 20 Jan 2018 23:01:18 +0000 (23:01 +0000)]
[Bug 61972] Adding chart in Document of MS-Word File without reading Temp MS-Word File. Thanks to Sandeep Tiwari. This closes #91

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1821764 13f79535-47bb-0310-9956-ffa450edef68

6 years agoRemove use of xmlbeans 2.3.0 in build to simplify our build dependencies
PJ Fanning [Thu, 11 Jan 2018 12:25:12 +0000 (12:25 +0000)]
Remove use of xmlbeans 2.3.0 in build to simplify our build dependencies

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820869 13f79535-47bb-0310-9956-ffa450edef68

6 years agoRemove use of xmlbeans 2.3.0 in build to simplify our build dependencies
PJ Fanning [Thu, 11 Jan 2018 12:17:46 +0000 (12:17 +0000)]
Remove use of xmlbeans 2.3.0 in build to simplify our build dependencies

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820868 13f79535-47bb-0310-9956-ffa450edef68

6 years agoremove unnecessary test override
PJ Fanning [Tue, 9 Jan 2018 12:23:37 +0000 (12:23 +0000)]
remove unnecessary test override

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820652 13f79535-47bb-0310-9956-ffa450edef68

6 years agointroduce XDDFShapeProperties as user model API (closes #72 from GitHub)
Alain Béarez [Sat, 6 Jan 2018 02:51:53 +0000 (02:51 +0000)]
introduce XDDFShapeProperties as user model API (closes #72 from GitHub)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820369 13f79535-47bb-0310-9956-ffa450edef68

6 years ago[github-86] expose language for Text Runs. Thanks to Geoff Baskwill. This closes #86
PJ Fanning [Thu, 4 Jan 2018 23:32:14 +0000 (23:32 +0000)]
[github-86] expose language for Text Runs. Thanks to Geoff Baskwill. This closes #86

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820242 13f79535-47bb-0310-9956-ffa450edef68

6 years agoDeprecate methods with typos and provide new ones.
Dominik Stadler [Mon, 1 Jan 2018 14:39:48 +0000 (14:39 +0000)]
Deprecate methods with typos and provide new ones.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819776 13f79535-47bb-0310-9956-ffa450edef68

6 years agoRemove unused property in build.xml
Dominik Stadler [Mon, 1 Jan 2018 14:39:42 +0000 (14:39 +0000)]
Remove unused property in build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819775 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61937: Add more javadoc
Dominik Stadler [Mon, 1 Jan 2018 14:39:38 +0000 (14:39 +0000)]
Bug 61937: Add more javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819774 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61543: do not fail with "part already exists" when tables are created/removed
Dominik Stadler [Mon, 1 Jan 2018 14:39:33 +0000 (14:39 +0000)]
Bug 61543: do not fail with "part already exists" when tables are created/removed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819773 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61550: Add more information to exception text and verify that it is thrown
Dominik Stadler [Mon, 1 Jan 2018 14:39:26 +0000 (14:39 +0000)]
Bug 61550: Add more information to exception text and verify that it is thrown

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819772 13f79535-47bb-0310-9956-ffa450edef68

6 years agoAdd .gitattribute file and set lf for one sample-file, see bug 61609
Dominik Stadler [Mon, 1 Jan 2018 14:39:19 +0000 (14:39 +0000)]
Add .gitattribute file and set lf for one sample-file, see bug 61609

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819771 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61648: Test Sheet.setArrayFormula for SXSSF
Dominik Stadler [Mon, 1 Jan 2018 14:39:15 +0000 (14:39 +0000)]
Bug 61648: Test Sheet.setArrayFormula for SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819770 13f79535-47bb-0310-9956-ffa450edef68

6 years agoAdd test which verifies that bug 61652 is not appearing any more on latest trunk
Dominik Stadler [Mon, 1 Jan 2018 14:39:08 +0000 (14:39 +0000)]
Add test which verifies that bug 61652 is not appearing any more on latest trunk

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819769 13f79535-47bb-0310-9956-ffa450edef68

6 years agoUpdate some tests and IntelliJ warnings
Dominik Stadler [Mon, 1 Jan 2018 14:38:58 +0000 (14:38 +0000)]
Update some tests and IntelliJ warnings
Ignore disabled test instead of not listing it in the test-report at all

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819768 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61947 remove deprecated method
PJ Fanning [Mon, 1 Jan 2018 13:05:31 +0000 (13:05 +0000)]
Bug-61947 remove deprecated method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819766 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61947 remove deprecated method
PJ Fanning [Mon, 1 Jan 2018 12:23:06 +0000 (12:23 +0000)]
Bug-61947 remove deprecated method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819763 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61947 remove deprecated method
PJ Fanning [Mon, 1 Jan 2018 12:13:53 +0000 (12:13 +0000)]
Bug-61947 remove deprecated method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819762 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61947 add back deprecated methods (removed by accident)
PJ Fanning [Mon, 1 Jan 2018 11:54:01 +0000 (11:54 +0000)]
Bug-61947 add back deprecated methods (removed by accident)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819761 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61947 remove deprecated method
PJ Fanning [Mon, 1 Jan 2018 11:47:53 +0000 (11:47 +0000)]
Bug-61947 remove deprecated method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819759 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61947 remove deprecated method
PJ Fanning [Mon, 1 Jan 2018 11:42:43 +0000 (11:42 +0000)]
Bug-61947 remove deprecated method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819758 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61797 - Embed Excel / Ole objects into powerpoint
Andreas Beeker [Sun, 31 Dec 2017 01:14:08 +0000 (01:14 +0000)]
#61797 - Embed Excel / Ole objects into powerpoint

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819710 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61943 - SL Common: narrow generics definition because of tighter java9 checks
Andreas Beeker [Sun, 31 Dec 2017 01:05:59 +0000 (01:05 +0000)]
#61943 - SL Common: narrow generics definition because of tighter java9 checks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819709 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61942 - Refactor PackagePartName handling and add getUnusedPartIndex method
Andreas Beeker [Sun, 31 Dec 2017 00:56:07 +0000 (00:56 +0000)]
#61942 - Refactor PackagePartName handling and add getUnusedPartIndex method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819708 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61941 - Move Ole marker generation to Ole10Native
Andreas Beeker [Sun, 31 Dec 2017 00:22:43 +0000 (00:22 +0000)]
#61941 - Move Ole marker generation to Ole10Native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819706 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61940 - Replace ClassID statics with enum
Andreas Beeker [Sun, 31 Dec 2017 00:13:38 +0000 (00:13 +0000)]
#61940 - Replace ClassID statics with enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819705 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61939 - Provide schema for AlternateContent - provide new ooxml-schemas-1.4.jar
Andreas Beeker [Sun, 31 Dec 2017 00:01:04 +0000 (00:01 +0000)]
#61939 - Provide schema for AlternateContent - provide new ooxml-schemas-1.4.jar

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819704 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61939 - Provide schema for AlternateContent - provide new ooxml-schemas-1.4.jar
Andreas Beeker [Sat, 30 Dec 2017 22:17:55 +0000 (22:17 +0000)]
#61939 - Provide schema for AlternateContent - provide new ooxml-schemas-1.4.jar

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819690 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 58106: when a cell with a 'master' shared formula is removed, the next cell...
Yegor Kozlov [Sat, 30 Dec 2017 16:34:57 +0000 (16:34 +0000)]
Bug 58106: when a cell with a 'master' shared formula is removed,  the next cell in the range becomes the master

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819623 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBugzilla 61116: Formula evaluation fails when using matrix addition within index...
Yegor Kozlov [Sat, 30 Dec 2017 13:11:56 +0000 (13:11 +0000)]
Bugzilla 61116: Formula evaluation fails when using matrix addition within index function call

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819596 13f79535-47bb-0310-9956-ffa450edef68

6 years agoDisable test which currently breaks with every little change to the resulting XML
Dominik Stadler [Thu, 28 Dec 2017 13:46:00 +0000 (13:46 +0000)]
Disable test which currently breaks with every little change to the resulting XML

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819424 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61665: Enhance SSPerformanceTest some more to add a warmup run and allow to run...
Dominik Stadler [Thu, 28 Dec 2017 10:53:40 +0000 (10:53 +0000)]
Bug 61665: Enhance SSPerformanceTest some more to add a warmup run and allow to run with unsynchronized XmlBeans

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819417 13f79535-47bb-0310-9956-ffa450edef68

6 years agoFix bug 61787, which was introduced by bug 58067: Change how deleted content is detec...
Dominik Stadler [Thu, 28 Dec 2017 08:45:51 +0000 (08:45 +0000)]
Fix bug 61787, which was introduced by bug 58067: Change how deleted content is detected to not incorrectly see too much text as deleted.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819405 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61798: Fix usage of getLastCellNum(), unfortunately this is a bit misleading...
Dominik Stadler [Thu, 28 Dec 2017 08:45:43 +0000 (08:45 +0000)]
Bug 61798: Fix usage of getLastCellNum(), unfortunately this is a bit misleading compared to getFirstCellNum()...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819404 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61911: Avoid IndexOutOfBounds access when reading pictures
Dominik Stadler [Thu, 28 Dec 2017 08:45:36 +0000 (08:45 +0000)]
Bug 61911: Avoid IndexOutOfBounds access when reading pictures

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819403 13f79535-47bb-0310-9956-ffa450edef68

6 years agoFix IntelliJ warnings and code formatting, generalize ExcelToHtmlUtils, use try-with...
Dominik Stadler [Thu, 28 Dec 2017 08:45:26 +0000 (08:45 +0000)]
Fix IntelliJ warnings and code formatting, generalize ExcelToHtmlUtils, use try-with-resources, update/enhance JavaDoc somewhat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819402 13f79535-47bb-0310-9956-ffa450edef68

6 years agoAdded a couple missing null checks.
Greg Woolsey [Thu, 28 Dec 2017 08:17:33 +0000 (08:17 +0000)]
Added a couple missing null checks.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819398 13f79535-47bb-0310-9956-ffa450edef68

6 years agoImplement DMAX and DSUM functions, following the pattern from DMIN.
Greg Woolsey [Wed, 27 Dec 2017 22:33:03 +0000 (22:33 +0000)]
Implement DMAX and DSUM functions, following the pattern from DMIN.

Refactored the D* function enum to have instances return the function implementation instances rather than using a case construct, now that Java 8 is required.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819376 13f79535-47bb-0310-9956-ffa450edef68

6 years agoRemove misleading SXSSF logging
PJ Fanning [Tue, 26 Dec 2017 11:02:45 +0000 (11:02 +0000)]
Remove misleading SXSSF logging

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819282 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61869: updating a cell with shared formula produces an unreadable file
Yegor Kozlov [Wed, 20 Dec 2017 16:30:13 +0000 (16:30 +0000)]
Bug 61869: updating a cell with shared formula produces an unreadable file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818818 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse try with resources
PJ Fanning [Wed, 20 Dec 2017 12:15:35 +0000 (12:15 +0000)]
use try with resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818786 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse try with resources
PJ Fanning [Wed, 20 Dec 2017 11:47:52 +0000 (11:47 +0000)]
use try with resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818781 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse StandardCharsets
PJ Fanning [Tue, 19 Dec 2017 00:33:16 +0000 (00:33 +0000)]
use StandardCharsets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818629 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse StandardCharsets
PJ Fanning [Tue, 19 Dec 2017 00:23:52 +0000 (00:23 +0000)]
use StandardCharsets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818628 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse non deprecated method for adding string to shared strings table
PJ Fanning [Mon, 18 Dec 2017 20:54:39 +0000 (20:54 +0000)]
use non deprecated method for adding string to shared strings table

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818623 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61859: support for evaluating comparison operators in array mode, detect array...
Yegor Kozlov [Mon, 18 Dec 2017 15:54:50 +0000 (15:54 +0000)]
Bug 61859: support for evaluating comparison operators in array mode, detect array mode from formula ptgs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818587 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61906 fix javadoc issue
PJ Fanning [Fri, 15 Dec 2017 09:13:16 +0000 (09:13 +0000)]
Bug-61906 fix javadoc issue

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818248 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61906 add API for working with RichStringText and deprecate API methods that...
PJ Fanning [Fri, 15 Dec 2017 09:09:50 +0000 (09:09 +0000)]
Bug-61906 add API for working with RichStringText and deprecate API methods that use CTRst

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818247 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61792 simplify sxssf code that writes chars
PJ Fanning [Fri, 15 Dec 2017 00:54:52 +0000 (00:54 +0000)]
Bug-61792 simplify sxssf code that writes chars

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818223 13f79535-47bb-0310-9956-ffa450edef68

6 years agodelete commented out code
Javen O'Neal [Wed, 13 Dec 2017 06:39:01 +0000 (06:39 +0000)]
delete commented out code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817976 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 57423: add unit test demonstrating corrupted workbook where CTRow xmlbeans are...
Javen O'Neal [Wed, 13 Dec 2017 06:21:19 +0000 (06:21 +0000)]
bug 57423: add unit test demonstrating corrupted workbook where CTRow xmlbeans are not in ascending order in the CTWorksheet; unit test adapted from Luca

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817975 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61765 Another HSSF Workbook name found from (unknown) third party software produced...
Nick Burch [Mon, 11 Dec 2017 19:52:53 +0000 (19:52 +0000)]
#61765 Another HSSF Workbook name found from (unknown) third party software produced files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817812 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
Greg Woolsey [Mon, 11 Dec 2017 17:33:00 +0000 (17:33 +0000)]
Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference

test file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817797 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
Greg Woolsey [Mon, 11 Dec 2017 17:30:04 +0000 (17:30 +0000)]
Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference

Protect against this in the future by introducing a factory method to create XSSFColor instances from a CTColor instance and the associated workbook style indexed color map.

If the CTColor instance is null, the factory returns null.  All callers already are prepared for a null instance, but many had their own null check on the CTColor object.  This centralizes that.

This also further forces the requirement for the indexed color map.  Any time a color is created, the workbook or styleTable is available in the same context, so passing this is extra parameter is trivial and allows XSSFColor to properly reference custom/themed indexed colors.

Did not remove any methods yet, only deprecated them.  Changed the signature to one internal test-only constructor.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817796 13f79535-47bb-0310-9956-ffa450edef68

6 years agoremove package name to ease the output
Andreas Beeker [Sat, 9 Dec 2017 12:06:59 +0000 (12:06 +0000)]
remove package name to ease the output

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817600 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61881 - handle invalid font names
Andreas Beeker [Sat, 9 Dec 2017 11:44:19 +0000 (11:44 +0000)]
#61881 - handle invalid font names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817599 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61841
Greg Woolsey [Thu, 7 Dec 2017 01:54:21 +0000 (01:54 +0000)]
#61841

Add @Override annotations, clean up imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817331 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61841 fix typo in method name
Greg Woolsey [Wed, 6 Dec 2017 23:53:25 +0000 (23:53 +0000)]
#61841 fix typo in method name

Fixing the typo pointed out by PJ Fanning, thanks for the proof read!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817325 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
Greg Woolsey [Wed, 6 Dec 2017 00:46:42 +0000 (00:46 +0000)]
Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference

always with the missing license...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817254 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
Greg Woolsey [Wed, 6 Dec 2017 00:15:51 +0000 (00:15 +0000)]
Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference

Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.

I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.

See the above bug for the performance analysis.  Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817252 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse try-with-resources in more places
PJ Fanning [Tue, 5 Dec 2017 22:31:59 +0000 (22:31 +0000)]
use try-with-resources in more places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817247 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse try-with-resources in more places
PJ Fanning [Tue, 5 Dec 2017 21:23:44 +0000 (21:23 +0000)]
use try-with-resources in more places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817238 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61840: close workbook to prevent resource leak in unit test
Javen O'Neal [Fri, 1 Dec 2017 17:51:19 +0000 (17:51 +0000)]
bug 61840: close workbook to prevent resource leak in unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816893 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61840: add unit test showing that shiftRows does not produce #REF! formula errors...
Javen O'Neal [Fri, 1 Dec 2017 17:47:29 +0000 (17:47 +0000)]
bug 61840: add unit test showing that shiftRows does not produce #REF! formula errors if cells are not shifted above the first row

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816892 13f79535-47bb-0310-9956-ffa450edef68

6 years agoJavadoc fixes
Nick Burch [Mon, 27 Nov 2017 14:05:17 +0000 (14:05 +0000)]
Javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816453 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBump library version to match Ant defined version
Nick Burch [Mon, 27 Nov 2017 12:42:47 +0000 (12:42 +0000)]
Bump library version to match Ant defined version

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816445 13f79535-47bb-0310-9956-ffa450edef68

6 years agoXDDF usermodel for Charts closes #68 on GitHub
Alain Béarez [Sun, 26 Nov 2017 14:03:01 +0000 (14:03 +0000)]
XDDF usermodel for Charts closes #68 on GitHub

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816383 13f79535-47bb-0310-9956-ffa450edef68

7 years ago#61809 - Infinite loop in SectionIDMap.get() and .put()
Andreas Beeker [Fri, 24 Nov 2017 01:02:20 +0000 (01:02 +0000)]
#61809 - Infinite loop in SectionIDMap.get() and .put()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816205 13f79535-47bb-0310-9956-ffa450edef68

7 years agouse try with resources in examples
PJ Fanning [Thu, 23 Nov 2017 20:03:25 +0000 (20:03 +0000)]
use try with resources in examples

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816189 13f79535-47bb-0310-9956-ffa450edef68

7 years agouse try with resources in examples
PJ Fanning [Thu, 23 Nov 2017 19:28:36 +0000 (19:28 +0000)]
use try with resources in examples

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816187 13f79535-47bb-0310-9956-ffa450edef68

7 years agoDon't try to collect junit results for Maven when we only run Sonar-tasks and thus...
Dominik Stadler [Thu, 23 Nov 2017 18:54:17 +0000 (18:54 +0000)]
Don't try to collect junit results for Maven when we only run Sonar-tasks and thus skip unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816186 13f79535-47bb-0310-9956-ffa450edef68

7 years agoChange order of handling shape-types in copy() as FreeFormShape derives from AutoShap...
Dominik Stadler [Thu, 23 Nov 2017 18:54:11 +0000 (18:54 +0000)]
Change order of handling shape-types in copy() as FreeFormShape derives from AutoShape and thus would have not been copied correctly currently
Fix some Javadoc, some warnings and code duplications

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816185 13f79535-47bb-0310-9956-ffa450edef68

7 years agoEnsure that the tempdir exists when we use ImageIO in one of the tests
Dominik Stadler [Wed, 22 Nov 2017 12:25:11 +0000 (12:25 +0000)]
Ensure that the tempdir exists when we use ImageIO in one of the tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816046 13f79535-47bb-0310-9956-ffa450edef68

7 years agoadd TestStringCodepointsIterable
PJ Fanning [Wed, 22 Nov 2017 09:57:45 +0000 (09:57 +0000)]
add TestStringCodepointsIterable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816020 13f79535-47bb-0310-9956-ffa450edef68

7 years agouse codepoint iterator in a few places
PJ Fanning [Wed, 22 Nov 2017 01:07:24 +0000 (01:07 +0000)]
use codepoint iterator in a few places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815998 13f79535-47bb-0310-9956-ffa450edef68

7 years agoadd forbidden api checks for non-Locale toLowerCase and toUpperCase
PJ Fanning [Tue, 21 Nov 2017 22:10:48 +0000 (22:10 +0000)]
add forbidden api checks for non-Locale toLowerCase and toUpperCase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815994 13f79535-47bb-0310-9956-ffa450edef68

7 years agoadd forbidden api checks for non-Locale toLowerCase and toUpperCase
PJ Fanning [Tue, 21 Nov 2017 21:33:51 +0000 (21:33 +0000)]
add forbidden api checks for non-Locale toLowerCase and toUpperCase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815989 13f79535-47bb-0310-9956-ffa450edef68

7 years agoremove more uses of Character.toUpperCase
PJ Fanning [Tue, 21 Nov 2017 21:11:07 +0000 (21:11 +0000)]
remove more uses of Character.toUpperCase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815988 13f79535-47bb-0310-9956-ffa450edef68

7 years agoTry to set java.io.tmpdir for tests to avoid the strange permission errors that we...
Dominik Stadler [Tue, 21 Nov 2017 17:32:48 +0000 (17:32 +0000)]
Try to set java.io.tmpdir for tests to avoid the strange permission errors that we see in CI-builds

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815963 13f79535-47bb-0310-9956-ffa450edef68

7 years agoEnsure that no old version of commons-codec is lingering around and causes hard to...
Dominik Stadler [Tue, 21 Nov 2017 16:29:01 +0000 (16:29 +0000)]
Ensure that no old version of commons-codec is lingering around and causes hard to find build errors locally

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815952 13f79535-47bb-0310-9956-ffa450edef68

7 years agoTry if using a local temporary directory avoids the permission errors in unit tests...
Dominik Stadler [Tue, 21 Nov 2017 16:28:07 +0000 (16:28 +0000)]
Try if using a local temporary directory avoids the permission errors in unit tests in the Maven runs:
* Collect JUnit results
* Set java.io.tmpdir in Maven unit test runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815951 13f79535-47bb-0310-9956-ffa450edef68

7 years ago[bug-61792] basic test
PJ Fanning [Mon, 20 Nov 2017 23:58:13 +0000 (23:58 +0000)]
[bug-61792] basic test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815873 13f79535-47bb-0310-9956-ffa450edef68

7 years ago[bug-61792] some changes to avoid iterating over chars of Strings
PJ Fanning [Mon, 20 Nov 2017 23:35:36 +0000 (23:35 +0000)]
[bug-61792] some changes to avoid iterating over chars of Strings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815871 13f79535-47bb-0310-9956-ffa450edef68

7 years agoupgrade to commons-codec 1.11
PJ Fanning [Mon, 20 Nov 2017 20:46:16 +0000 (20:46 +0000)]
upgrade to commons-codec 1.11

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815852 13f79535-47bb-0310-9956-ffa450edef68

7 years agoHandle case where the JaCoCo zip file is available, but the extracted files are missi...
Dominik Stadler [Sun, 19 Nov 2017 19:53:44 +0000 (19:53 +0000)]
Handle case where the JaCoCo zip file is available, but the extracted files are missing, not sure how that happens, but we see it on some CI machines...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815755 13f79535-47bb-0310-9956-ffa450edef68

7 years agojavadocs and Quick page improvements for XSSF Header/Footer
Mark Murphy [Sun, 19 Nov 2017 01:35:07 +0000 (01:35 +0000)]
javadocs and Quick page improvements for XSSF Header/Footer

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815706 13f79535-47bb-0310-9956-ffa450edef68

7 years agoadd Locale awareness to case insensitive conditional comparisons in formatting rule...
Greg Woolsey [Thu, 16 Nov 2017 01:22:52 +0000 (01:22 +0000)]
add Locale awareness to case insensitive conditional comparisons in formatting rule logic.  Needed anyway, and removes forbidden API issues.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815404 13f79535-47bb-0310-9956-ffa450edef68