Merge pull request #23999 from nextcloud/fix/old-legacy-scripts

Remove old legacy scripts references

Merge pull request #23994 from nextcloud/fix/comment_search

Update comment search to initFS

Merge pull request #23889 from nextcloud/fix/noid/shortcut-to-avoid-filesystem-setup

Shortcut to avoid file system setup when generating the logo URL

Removed config.js

Remove old legacy search script

Merge pull request #23937 from nextcloud/bugfix/noid/files-ocdb

Use query builder instead of OC_DB in OC\Files\*

Merge pull request #23976 from nextcloud/enh/reduce_getAppPath_and_autoload_reg

Reduce the getAppPath and autoloader calls

Merge pull request #23982 from nextcloud/fix/quota-storage-getsize

Make sure root storage is valid before checking its size

Merge pull request #23741 from Ashod/lock-leak

Unlock when promoting to exclusive lock fails

Merge pull request #23978 from nextcloud/enh/query_servercontainer_first

First query the server container

Merge pull request #23933 from nextcloud/bugfix/noid/user-ldap-ocdb

Use query builder instead of OC_DB in user_ldap

Shortcut to avoid file system setup when generating the logo URL

If an SVG is requested and the app config value for logoMime is set then the logo is there. Otherwise we need to check it and maybe also generate a PNG from the SVG (that's done in getImage() which needs to be called then).

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Update comment search to initFS

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #23574 from nextcloud/fix/23569

Fix link share label placeholder not showing

Use query builder instead of OC_DB in OC\Files\*

Signed-off-by: Joas Schilling <coding@schilljs.com>

Make sure root storage is valid before checking its size

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Test requires the DB

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Merge pull request #23983 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Fix link share label placeholder not showing

Signed-off-by: Gary Kim <gary@garykim.dev>

First query the server container

When the servercontainer wants to obtain something changes are very high
this is something from the server container. Esp on setups with a lot of
shares this can change quite a bit as it avoid a needless check on the
strpos OCA\\ etc.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Reduce the getAppPath and autoloader calls

The getAppPath will always return the same data for the same appId. It
is actually already cached. However we do some cleanup of the appId
(again). Same for the autoloading it is actually already checked.

This just removes the unneeded calls. Which can add up if you have a lot
of incomming shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #23923 from nextcloud/bugfix/oci/fix-greatest-order-for-oracle

Fix greatest/least order for oracle

Unlock when promoting to exclusive lock fails

In certain cases changeLock to EXCLUSIVE fails
and throws LockedException. This leaves the
file locked as SHARED in file_put_contents,
which prevents retrying (because on second
call file_put_contents takes another SHARED
lock on the same file, and changeLock doesn't
allow more than a single SHARED lock to promote
to EXCLUSIVE).

To avoid this case, we catch the LockedException
and unlock before re-throwing.

Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>

Merge pull request #23956 from nextcloud/dependabot/npm_and_yarn/node-sass-5.0.0

Bump node-sass from 4.14.1 to 5.0.0

Update parameters

Signed-off-by: Joas Schilling <coding@schilljs.com>

Bump node-sass from 4.14.1 to 5.0.0

Bumps [node-sass](https://github.com/sass/node-sass) from 4.14.1 to 5.0.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.14.1...v5.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #23961 from nextcloud/dependabot/npm_and_yarn/css-vars-ponyfill-2.4.1

Merge pull request #23957 from nextcloud/dependabot/npm_and_yarn/vue-loader-15.9.5

Bump vue-loader from 15.9.4 to 15.9.5

Merge pull request #23960 from nextcloud/dependabot/npm_and_yarn/bootstrap-4.5.3

Bump bootstrap from 4.5.2 to 4.5.3

Merge pull request #23962 from nextcloud/dependabot/npm_and_yarn/vue-router-3.4.9

Bump vue-router from 3.4.8 to 3.4.9

Merge pull request #23964 from nextcloud/dependabot/npm_and_yarn/marked-1.2.3

Bump marked from 1.2.0 to 1.2.3

Merge pull request #23936 from nextcloud/bugfix/noid/trashbin-ocdb

Use query builder instead of OC_DB in trashbin

Bump css-vars-ponyfill from 2.3.2 to 2.4.1

Bumps [css-vars-ponyfill](https://github.com/jhildenbiddle/css-vars-ponyfill) from 2.3.2 to 2.4.1.
- [Release notes](https://github.com/jhildenbiddle/css-vars-ponyfill/releases)
- [Changelog](https://github.com/jhildenbiddle/css-vars-ponyfill/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jhildenbiddle/css-vars-ponyfill/compare/v2.3.2...v2.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Bump vue-loader from 15.9.4 to 15.9.5

Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.9.4 to 15.9.5.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.9.4...v15.9.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #23965 from nextcloud/dependabot/npm_and_yarn/webpack-cli-4.2.0

Merge pull request #23934 from nextcloud/enh/avoid_scss_compile

Fix tests to return config default values

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Bump vue-router from 3.4.8 to 3.4.9

Bumps [vue-router](https://github.com/vuejs/vue-router) from 3.4.8 to 3.4.9.
- [Release notes](https://github.com/vuejs/vue-router/releases)
- [Changelog](https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-router/compare/v3.4.8...v3.4.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #23966 from nextcloud/dependabot/npm_and_yarn/vue-material-design-icons-4.10.0

Merge pull request #23963 from nextcloud/dependabot/npm_and_yarn/sinon-9.2.1

Merge pull request #23968 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Bump sinon from 9.2.0 to 9.2.1

Bumps [sinon](https://github.com/sinonjs/sinon) from 9.2.0 to 9.2.1.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #23959 from nextcloud/dependabot/npm_and_yarn/sass-loader-10.0.5

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Bump vue-material-design-icons from 4.9.0 to 4.10.0

Bumps [vue-material-design-icons](https://github.com/robcresswell/vue-material-design-icons) from 4.9.0 to 4.10.0.
- [Release notes](https://github.com/robcresswell/vue-material-design-icons/releases)
- [Changelog](https://github.com/robcresswell/vue-material-design-icons/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/robcresswell/vue-material-design-icons/compare/4.9.0...4.10.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump webpack-cli from 4.1.0 to 4.2.0

Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@4.1.0...webpack-cli@4.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump marked from 1.2.0 to 1.2.3

Bumps [marked](https://github.com/markedjs/marked) from 1.2.0 to 1.2.3.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js)
- [Commits](https://github.com/markedjs/marked/compare/v1.2.0...v1.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump bootstrap from 4.5.2 to 4.5.3

Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.5.2 to 4.5.3.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](https://github.com/twbs/bootstrap/compare/v4.5.2...v4.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump sass-loader from 10.0.4 to 10.0.5

Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 10.0.4 to 10.0.5.
- [Release notes](https://github.com/webpack-contrib/sass-loader/releases)
- [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/sass-loader/compare/v10.0.4...v10.0.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

[tx-robot] updated from transifex

Merge pull request #23821 from nextcloud/td/enh/no_fs_setup_by_default

Do not setup the default FS on normal routes

Merge pull request #23942 from nextcloud/techdebt/cookie-lax-php7.3

Remove the cookie paths for php<7.3

Merge pull request #23938 from nextcloud/bugfix/oci/sharing-ocdb

Replace some usages of OC_DB in OC\Share\* with query builder

Merge pull request #23851 from nextcloud/enh/read_env_only_once

Read the env variables only once

Use query builder instead of OC_DB in trashbin

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #23943 from nextcloud/bugfix/oci/fix-ilike-on-oracle

Fix iLike() falsely turning escaped % and _ into wildcards

Merge pull request #23922 from nextcloud/bugfix/noid/fix-query-type-detection

Improve query type detection

Merge pull request #23928 from nextcloud/bugfix/oci/dont-leave-stray-cursors-on-mimetype-update

Fix repair mimetype step to not leave stray cursors

Merge pull request #23940 from nextcloud/enh/skip_already_loaded_apps

Skip already loaded apps in loadApps

Merge pull request #23919 from nextcloud/dependabot/npm_and_yarn/css-loader-5.0.1

Merge pull request #23929 from nextcloud/techdebt/noid/deprecate-prepare-and-execute-audited-as-they-leak-cursors

Deprecate OC_DB::prepare and OC_DB::executeAudited as they leak cursors

Fix iLike() falsely turning escaped % and _ into wildcards

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #23932 from nextcloud/enh/s3/do_not_check_bucket_exists_on_every_request

Allow config to specify the bucket exists

Remove the cookie paths for php<7.3

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Skip already loaded apps in loadApps

Otherwise you might end up calling a lot of functions unneeded.
And while the individual calls are cheap if you multiply them by 20k
they still get somewhat expensive.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

fix insert values

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Replace some usages of OC_DB in OC\Share\* with query builder

Signed-off-by: Joas Schilling <coding@schilljs.com>

only delete specified config

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Make sure Oracle always casts everything in the best way

Signed-off-by: Joas Schilling <coding@schilljs.com>

Use Query builder function

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix order of GREATEST for Oracle

As per https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm
Oracle uses the first value to cast the rest or the values.
So when the first value is a plain int, instead of doing the math,
it will cast the expression to int and continue with a potential 0.

Signed-off-by: Joas Schilling <coding@schilljs.com>

Correctly place the array type

Merge pull request #23921 from nextcloud/techdebt/oci/fix-casting-to-integer

Fix casting to integer on Oracle

Avoid SCSS compilation if not needed

Now we do on each template load a compile with the SCSS variables to see
if they changed or not. However there is no real reason for this if the
variables didn't change.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Use query builder to interact with member management

Signed-off-by: Joas Schilling <coding@schilljs.com>

Use query builder instead of OC_DB in user_ldap

Signed-off-by: Joas Schilling <coding@schilljs.com>

Allow config to specify the bucket exists

In the 99% case the bucket is just always there. And if it is not the
read/write will fail hard anyways. Esp on big instances the Objectstore
is not always fast and this can save a few hundered ms of each request
that acess the objectstore.

In short it is adding

'verify_bucket_exists' => false

To the S3 config part

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Deprecate OC_DB::prepare and OC_DB::executeAudited as they leak cursors

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix repair mimetype step to not leave stray cursors

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #23920 from nextcloud/fix/match_bearer_front

Bearer must be in the start of the auth header

Merge pull request #23918 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Fix getstorage call

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Do not setup the default FS on normal routes

This should help with load times hopefully. Only initialize the FS if we
actually ned it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Bump css-loader from 3.6.0 to 5.0.1

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.6.0 to 5.0.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.6.0...v5.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Improve query type detection

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix casting to integer on Oracle

Signed-off-by: Joas Schilling <coding@schilljs.com>

Bearer must be in the start of the auth header

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #23347 from st3iny/enhancement/19526/new-share-pending-confirm-button

Merge pull request #23916 from nextcloud/dependabot/npm_and_yarn/mocha-8.2.1

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Merge pull request #23857 from nextcloud/dependabot/composer/vimeo/psalm-4.1.1

Bump vimeo/psalm from 4.0.1 to 4.1.1

Bump vimeo/psalm from 4.0.1 to 4.1.1

Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.0.1 to 4.1.1.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](https://github.com/vimeo/psalm/compare/4.0.1...4.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #23906 from nextcloud/techdebt/noid/simplify-can-change-user-pasword

Simplify the check if admin can change password based on encryption status

Merge pull request #23887 from ecsecta/fix_23797

Do not emit UserCreatedEvent twice

Simplify the check if admin can change password based on encryption status

Found by Psalm:
```
/home/runner/work/server/server/apps/settings/lib/Controller/UsersController.php:324:8:error - RedundantCondition: Type true for $isEncryptionModuleLoaded is never falsy
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>