]> source.dussan.org Git - tigervnc.git/log
tigervnc.git
3 years agoUse classic FILE I/O for storing server history
Pierre Ossman [Wed, 8 Sep 2021 07:02:11 +0000 (09:02 +0200)]
Use classic FILE I/O for storing server history

Error handling is more straight forward in the C file interface.

3 years agoMerge pull request #1253 from binary-manu/accented-chars
Brian Hinz [Tue, 7 Sep 2021 02:24:24 +0000 (22:24 -0400)]
Merge pull request #1253 from binary-manu/accented-chars

Handle keys reported only by KeyEvent.getExtendedKeyCode

3 years agoClean up global event handler structure
Pierre Ossman [Mon, 6 Sep 2021 08:15:36 +0000 (10:15 +0200)]
Clean up global event handler structure

Let's separate the standard global event handling from the hacky
workarounds, for clarity.

3 years agoRestore FLTK event dispatcher on exit
Pierre Ossman [Mon, 6 Sep 2021 08:14:23 +0000 (10:14 +0200)]
Restore FLTK event dispatcher on exit

3 years agoMerge branch 'fullscreens-added-removed' of https://github.com/x11clone/x11clone
Pierre Ossman [Thu, 2 Sep 2021 14:51:03 +0000 (16:51 +0200)]
Merge branch 'fullscreens-added-removed' of https://github.com/x11clone/x11clone

3 years agoTolerate carriage return in config files
Pierre Ossman [Thu, 2 Sep 2021 14:28:16 +0000 (16:28 +0200)]
Tolerate carriage return in config files

If the file has been transferred from a Windows system then it might
have \r\n line endings instead of \n. Make sure this doesn't leak in to
the parameter values.

3 years agoFix inconsistent line endings in vncviewer configuration file
Meng Dong [Mon, 12 Jul 2021 02:45:11 +0000 (10:45 +0800)]
Fix inconsistent line endings in vncviewer configuration file

3 years agoInclude translations in macOS and Windows builds 1318/head
Pierre Ossman [Fri, 27 Aug 2021 09:15:54 +0000 (11:15 +0200)]
Include translations in macOS and Windows builds

3 years agoDisable dangerous macOS SDK macros
Pierre Ossman [Fri, 27 Aug 2021 09:07:58 +0000 (11:07 +0200)]
Disable dangerous macOS SDK macros

They define macros such as "check()" which causes our code to break as
we have methods with that name.

3 years agoMerge branch 'fb-session-nfs' of https://github.com/zpytela/tigervnc
Pierre Ossman [Thu, 26 Aug 2021 10:10:16 +0000 (12:10 +0200)]
Merge branch 'fb-session-nfs' of https://github.com/zpytela/tigervnc

3 years agoExpose reconnect setting in options dialog
Pierre Ossman [Fri, 23 Jul 2021 11:32:50 +0000 (13:32 +0200)]
Expose reconnect setting in options dialog

3 years agoRetry connection in case of an error
Johannes [Sat, 30 Jan 2021 23:12:50 +0000 (00:12 +0100)]
Retry connection in case of an error

3 years agoMerge branch 'x0-interface-option' of https://github.com/sotho/tigervnc
Pierre Ossman [Fri, 23 Jul 2021 08:33:11 +0000 (10:33 +0200)]
Merge branch 'x0-interface-option' of https://github.com/sotho/tigervnc

3 years agoAdd -interface option to x0vncserver 1300/head
Alexander Elbs [Thu, 22 Jul 2021 15:32:35 +0000 (17:32 +0200)]
Add -interface option to x0vncserver

3 years agoMerge branches 'host-name-max', 'fix-build-viewer-off' and 'fix-case-insensitive...
Pierre Ossman [Fri, 23 Jul 2021 08:02:20 +0000 (10:02 +0200)]
Merge branches 'host-name-max', 'fix-build-viewer-off' and 'fix-case-insensitive-fs' of https://github.com/arichardson/tigervnc

3 years agoKeep ownership of second selection when first is lost
Pierre Ossman [Tue, 20 Jul 2021 14:38:04 +0000 (16:38 +0200)]
Keep ownership of second selection when first is lost

This fixes regression introduced by the extended clipboard extension.
Previously it was possible for the server to hold on to the CLIPBOARD
selection even if another application took ownership of PRIMARY. This is
important to handle the common use case of selecting something in order
to paste over it.

The new request based model doesn't readily support this as we assume
the client has lost its data once we push the new PRIMARY selection to
it. So to handle this we have the maintain a cache of the client's data,
and make sure to fill that cache before we do anything that might cause
the client to lose the data.

3 years agoSimply screen refresh handler
Pierre Ossman [Tue, 20 Jul 2021 12:24:10 +0000 (14:24 +0200)]
Simply screen refresh handler

We only need to check the event type once, and preferably early, and
avoid doing more work than necessary.

3 years agoOnly log error when setting FullScreenSelectedMonitors
Pierre Ossman [Mon, 19 Jul 2021 15:35:29 +0000 (17:35 +0200)]
Only log error when setting FullScreenSelectedMonitors

We don't want the log to spam every time this parameter is used so only
complain from the parses when the value is changed.

3 years agoDon't reference specific variable in class
Pierre Ossman [Mon, 19 Jul 2021 15:31:45 +0000 (17:31 +0200)]
Don't reference specific variable in class

This class is generic and should not reference a specific instance of
it.

3 years agoAvoiding final period in log messages
Pierre Ossman [Mon, 19 Jul 2021 15:28:15 +0000 (17:28 +0200)]
Avoiding final period in log messages

Try to be consistent with existing log messages.

3 years agoClean up style in recent monitor code
Pierre Ossman [Mon, 19 Jul 2021 15:22:43 +0000 (17:22 +0200)]
Clean up style in recent monitor code

Fix some indentation issues and make sure everything* uses CamelCase.

* MonitorArrangement is left as snake_case in order to pretend it is an
  independent FLTK widget class.

3 years agoRefresh MonitorArrangement on configuration change 1295/head
Hugo Lundin [Fri, 16 Jul 2021 14:31:16 +0000 (16:31 +0200)]
Refresh MonitorArrangement on configuration change

MonitorArrangement (in the options dialog) never changes when the system
monitor configuration changes. Therefore, the user can get into a state
where the reality doesn't match what is shown (when a monitor is
added/removed, resolution or position changed etc).

All these changes triggers an event in FLTK
(FL_SCREEN_CONFIGURATION_CHANGED). This commit adds an event handler in
MonitorArrangement and refreshes the widget whenever that event occurs.

Because Fl_Handler does not have a void*-argument (and we must be able
to access the widget from our handler callback) a static set of
instances have been added, which all will receive the events.

3 years agoMerge branch 'selected_monitors' of https://github.com/hugolundin/tigervnc
Pierre Ossman [Fri, 16 Jul 2021 14:10:36 +0000 (16:10 +0200)]
Merge branch 'selected_monitors' of https://github.com/hugolundin/tigervnc

3 years agoAdd monitor description to tooltip 1282/head
Hugo Lundin [Tue, 13 Jul 2021 13:55:54 +0000 (15:55 +0200)]
Add monitor description to tooltip

It might be useful to have more information about a monitor when
configuring its settings in the Options menu. Therefore, this commit
adds support for showing additional information about a monitor
(resolution and platform-specific name).

3 years agoExplicitly choose current monitor
Hugo Lundin [Thu, 15 Jul 2021 11:32:19 +0000 (13:32 +0200)]
Explicitly choose current monitor

There are no guarantees from the WM that calling `fullscreen_screens`
with all monitor indices set to `-1` results in the window's current
monitor being used. Because FullScreenMode uses the word "current"
we want to explicitly ask the WM to use that monitor.

3 years agoAdd fullscreen mode for selected monitors
Hugo Lundin [Tue, 13 Jul 2021 11:58:12 +0000 (13:58 +0200)]
Add fullscreen mode for selected monitors

The user might not always want to use all monitors when in fullscreen
mode, but instead only a few. This commit adds support for configuring
selected monitors from command line, in the config file and graphically
in the options menu.

Because it might be hard to guarantee the consistency of monitor
identifiers coming from third-parties (for example FLTK), it has been
decided to use our own numerical identifier. This identifier is based on
the monitor's positions. The mapping between this identifier and the
indices used by FLTK is done by MonitorIndicesParameter.

3 years agoAdd fullscreen mode parameter
Hugo Lundin [Thu, 15 Jul 2021 10:52:56 +0000 (12:52 +0200)]
Add fullscreen mode parameter

Before this commit, `FullScreen` and `FullScreenAllMonitors` could be
used to configure whether to use the current monitor in fullscreen,
or all monitors in fullscreen.

This commit deprecates `FullScreenAllMonitors` in favour of
`FullScreenMode` (which can either be `current` or `all`). This allows
for additional modes to be added, without the risk of having invalid
states (for example two activate two different fullscreen modes at the
same time).

A new concept has been added; read-only parameters. They are parameters
that will be read, but never written back. This allows for migration
paths to be constructed, where a parameter can be taken to consideration
but then for example be discarded, logged or changed into something else.

This has been used for `FullScreenAllMonitors` to provide a migration
path. On startup of vncviewer, if `FullScreenAllMonitors` is enabled,
`FullScreenMode=all` will be automatically enabled instead. The next
time the configuration file is written to disk, `FullScreenAllMonitors`
will then be removed.

3 years agoCalculate overlay position from window size
Hugo Lundin [Wed, 14 Jul 2021 12:55:56 +0000 (14:55 +0200)]
Calculate overlay position from window size

Previously, it was assumed that all monitors (and especially the primary
monitor, index 0) was inside the window when we calculate the position
of the overlay.

That might not always be the case, for example when using fullscreen
mode over a narrower set of monitors. This commit does so the overlay is
positioned correctly based on the actual window size, instead of what we
expect it to be.

3 years agoRelease displays not enclosed by the window
Hugo Lundin [Fri, 16 Jul 2021 11:26:08 +0000 (13:26 +0200)]
Release displays not enclosed by the window

cocoa_capture_displays it captures all displays enclosed by the
window_rect. If a set of displays were captured, but the configuration of
what monitors to use changed, a second call would only add to the set
of captured displays. Therefore, if the user enabled
FullScreenAllMonitors (all displays captured) and then disabled it (only
one display captured) they would get into a state were monitors not used
for the VNC session still were captured (which on macOS for example,
results in displays being unusable for other things).

This has now been fixed, resulting in monitors outside the window_rect
not being unnecessarily captured.

3 years agoFix priority string when using newer GnuTLS 1293/head
Jan Grulich [Thu, 15 Jul 2021 18:42:16 +0000 (20:42 +0200)]
Fix priority string when using newer GnuTLS

The call of gnutls_set_default_priority_append() expects a normal priority
string, which means it must not start with ':'.

3 years agoCapture all displays inside the viewport (macOS)
Hugo Lundin [Tue, 13 Jul 2021 11:07:41 +0000 (13:07 +0200)]
Capture all displays inside the viewport (macOS)

It was only possible to capture either the current, or all displays
previously. This could become an issue if you want to show a vnc session
over only a selected set of displays, because then we only want to
capture those displays.

The solution in the commit was chosen because it handles all cases - by
looking at what monitors are enclosed by the viewport the implementation
is independent on any configuration, but instead captures the monitors
actually being used.

3 years agoAllow building with -DBUILD_VIEWER=OFF 1290/head
Alex Richardson [Wed, 14 Jul 2021 13:03:43 +0000 (14:03 +0100)]
Allow building with -DBUILD_VIEWER=OFF

Without this change I get CMake errors due to use of ${FLTK_INCLUDE_DIR}
and references to the non-existent vncviewer target.

3 years agoRename Input.h to vncInput.h to fix building on case-insensitive FS 1291/head
Alex Richardson [Wed, 14 Jul 2021 13:13:54 +0000 (14:13 +0100)]
Rename Input.h to vncInput.h to fix building on case-insensitive FS

I am cross-compiling from macOS for a FreeBSD-derived system so my host
file system is case insensitive but the target isn't. Without this change
I get the following warnings which show that the vnc "Input.h" is being
included from mi/mi.h instead of the xserver "input.h":
```
In file included from /Users/alex/cheri/xvnc-server/hw/vnc/Input.c:33:
/Users/alex/cheri/xvnc-server/mi/mi.h:55:10: warning: non-portable path to file '"Input.h"'; specified path differs in case from file name on disk [-Wnonportable-include-path]
#include "input.h"
         ^~~~~~~~~
         "Input.h"
```

3 years agoFix build on systems without HOST_NAME_MAX 1289/head
Alex Richardson [Wed, 14 Jul 2021 13:01:15 +0000 (14:01 +0100)]
Fix build on systems without HOST_NAME_MAX

Some operating systems such as FreeBSD don't define a HOST_NAME_MAX
macro. The portable approach to determine the real host name limit is
calling sysconf(_SC_HOST_NAME_MAX) so do that instead.

3 years agoMerge branch 'utilize-system-wide-crypto' of https://github.com/grulja/tigervnc
Pierre Ossman [Wed, 14 Jul 2021 12:24:08 +0000 (14:24 +0200)]
Merge branch 'utilize-system-wide-crypto' of https://github.com/grulja/tigervnc

3 years agoUtilize system-wide crypto policies 1262/head
Jan Grulich [Mon, 12 Jul 2021 10:43:47 +0000 (12:43 +0200)]
Utilize system-wide crypto policies

3 years agoMerge branch 'xvfb' of https://github.com/CendioOssman/tigervnc
Pierre Ossman [Wed, 14 Jul 2021 10:26:46 +0000 (12:26 +0200)]
Merge branch 'xvfb' of https://github.com/CendioOssman/tigervnc

3 years agoRemove vfb references from symbol names 1288/head
Pierre Ossman [Tue, 13 Jul 2021 10:42:56 +0000 (12:42 +0200)]
Remove vfb references from symbol names

Xvnc was originally based on Xvfb, but it's just confusing to keep the
names. So change all prefix to "vnc" instead to clearly mark things as
part of TigerVNC.

3 years agoRemove zaphod mode from Xvnc
Pierre Ossman [Tue, 13 Jul 2021 10:36:10 +0000 (12:36 +0200)]
Remove zaphod mode from Xvnc

It isn't really useful as it behaves just like starting multiple
servers, so remove it in favour of keeping things simple.

3 years agoRemove undocumented -linebias argument
Pierre Ossman [Tue, 13 Jul 2021 08:32:42 +0000 (10:32 +0200)]
Remove undocumented -linebias argument

This is a development flag with no real use, so remove it to clean up
the code.

3 years agoClean up Xvnc screen struct
Pierre Ossman [Tue, 13 Jul 2021 07:44:00 +0000 (09:44 +0200)]
Clean up Xvnc screen struct

Remove stuff we don't use, and get it more in sync with Xvfb for easier
comparison.

3 years agoRemove unused headers
Pierre Ossman [Tue, 13 Jul 2021 07:28:06 +0000 (09:28 +0200)]
Remove unused headers

3 years agoRemove obsolete AIX hack
Pierre Ossman [Mon, 12 Jul 2021 15:35:59 +0000 (17:35 +0200)]
Remove obsolete AIX hack

3 years agoRemove obsolete comment about backing store
Pierre Ossman [Mon, 12 Jul 2021 15:35:44 +0000 (17:35 +0200)]
Remove obsolete comment about backing store

This was removed years ago.

3 years agoRemove CloseScreen() wrapper
Pierre Ossman [Mon, 12 Jul 2021 15:26:54 +0000 (17:26 +0200)]
Remove CloseScreen() wrapper

The memory leak this worked around was fixed in X.org 1.16.

3 years agoDo all RandR init in vncRandRInit()
Pierre Ossman [Mon, 12 Jul 2021 15:15:25 +0000 (17:15 +0200)]
Do all RandR init in vncRandRInit()

Keep everything in one place to make it easier to read.

This also removes the call to RRInit() as that is done implicitly
anyway.

3 years agoUse central SetRootClip()
Pierre Ossman [Mon, 12 Jul 2021 15:03:36 +0000 (17:03 +0200)]
Use central SetRootClip()

There's been a common one since X.org 1.11, so use that instead of our
own copy.

3 years agoRemove Darwin code from Xvnc
Pierre Ossman [Mon, 12 Jul 2021 14:29:55 +0000 (16:29 +0200)]
Remove Darwin code from Xvnc

We don't build for that platform anyway, so this is just a remnant from
Xvfb.

3 years agoHandle X.org patch level features
Pierre Ossman [Sun, 11 Jul 2021 18:59:48 +0000 (20:59 +0200)]
Handle X.org patch level features

With the 1.20.x releases there has been features and API changes even on
patch level versions, so we need to update our macros to handle these as
well.

3 years agoRemove shared memory framebuffer option
Pierre Ossman [Sun, 11 Jul 2021 18:33:07 +0000 (20:33 +0200)]
Remove shared memory framebuffer option

This is a pointless remnant of Xvfb. We never print the id of the shared
memory, so no other application can access this memory anyway.

3 years agoRemove more color map code from Xvnc
Pierre Ossman [Sun, 11 Jul 2021 18:19:10 +0000 (20:19 +0200)]
Remove more color map code from Xvnc

This hasn't been supported or used in many years, so clean out the final
remnants.

3 years agoRemove DDXTIME code
Pierre Ossman [Sun, 11 Jul 2021 18:05:54 +0000 (20:05 +0200)]
Remove DDXTIME code

This hasn't been used since xorg-server 1.1 so get rid of it.

3 years agoCall FatalError() on bad Xvnc arguments
Pierre Ossman [Sun, 11 Jul 2021 17:59:19 +0000 (19:59 +0200)]
Call FatalError() on bad Xvnc arguments

This is consistent with other ddx behaviour.

3 years agoUse CHECK_FOR_REQUIRED_ARGUMENTS() for arg check
Pierre Ossman [Sun, 11 Jul 2021 17:45:11 +0000 (19:45 +0200)]
Use CHECK_FOR_REQUIRED_ARGUMENTS() for arg check

This is what all the other ddx variants use, so do the same in Xvnc to
be consistent.

3 years agoApply Xorg coding style to xvnc.c
Pierre Ossman [Sun, 11 Jul 2021 17:41:34 +0000 (19:41 +0200)]
Apply Xorg coding style to xvnc.c

Makes it easier to compare with upstream files as the formatting will be
the same.

3 years agoRemove #ifdef RENDER
Pierre Ossman [Sun, 11 Jul 2021 17:21:58 +0000 (19:21 +0200)]
Remove #ifdef RENDER

RENDER has been mandatory since xorg-server 1.9, so remove these
checks.

3 years agoMove ddxInputThreadInit() to xvnc.c
Pierre Ossman [Sun, 11 Jul 2021 17:20:48 +0000 (19:20 +0200)]
Move ddxInputThreadInit() to xvnc.c

This should only be in the ddx parts of an X server, and Input.c is used
by libvnc.so as well and can cause conflicts there.

3 years agoRemove Ubuntu rethrow signals patch
Pierre Ossman [Tue, 13 Jul 2021 12:25:23 +0000 (14:25 +0200)]
Remove Ubuntu rethrow signals patch

This was removed from Ubunut's X.org packages years ago, so drop it from
our packing as well.

3 years agoCorrectly handle screen layout with offset
Pierre Ossman [Thu, 17 Jun 2021 13:39:30 +0000 (15:39 +0200)]
Correctly handle screen layout with offset

We miscalculated the screen layout if the geometry had an offset as we
adjusted the real screen layout to account for the offset, but compared
it to the unadjusted geometry.

3 years agoMerge branch 'smooth-edge-scrolling' of https://github.com/ToyKeeper/tigervnc
Pierre Ossman [Wed, 16 Jun 2021 12:13:31 +0000 (14:13 +0200)]
Merge branch 'smooth-edge-scrolling' of https://github.com/ToyKeeper/tigervnc

3 years agoMerge branch 'master' of https://github.com/jasonsikes/tigervnc
Pierre Ossman [Wed, 16 Jun 2021 12:10:47 +0000 (14:10 +0200)]
Merge branch 'master' of https://github.com/jasonsikes/tigervnc

3 years agoAvoid some variable aliasing
Pierre Ossman [Mon, 14 Jun 2021 07:43:10 +0000 (09:43 +0200)]
Avoid some variable aliasing

3 years agoRemove unnecessary header include
Pierre Ossman [Sun, 13 Jun 2021 16:29:40 +0000 (18:29 +0200)]
Remove unnecessary header include

3 years agoUse <user>@<hostname> as the default desktop name
Pierre Ossman [Sun, 13 Jun 2021 16:28:16 +0000 (18:28 +0200)]
Use <user>@<hostname> as the default desktop name

Is a lot more useful default than the previous "x11", or "x0vncserver".
At the same time give x0vncserver a parameter to change the name.

3 years agoClean up default value for X509 parameters
Pierre Ossman [Fri, 11 Jun 2021 15:40:02 +0000 (17:40 +0200)]
Clean up default value for X509 parameters

Let's avoid making this too complex and force every user to know about
magical functions.

3 years agoUse RFC7919-2048 group in GnuTLS for FIPS compliance. 1273/head
JASON SIKES [Sun, 13 Jun 2021 01:45:20 +0000 (18:45 -0700)]
Use RFC7919-2048 group in GnuTLS for FIPS compliance.

3 years agoKeep own memory for duplicate config value
Pierre Ossman [Fri, 11 Jun 2021 15:20:44 +0000 (17:20 +0200)]
Keep own memory for duplicate config value

Allows the default value to be dynamically generated in a buffer that is
reused.

3 years agoRemove unused LogParameter::setDefault()
Pierre Ossman [Fri, 11 Jun 2021 15:20:02 +0000 (17:20 +0200)]
Remove unused LogParameter::setDefault()

3 years agoDon't list clipboard parameters for x0vncserver
Pierre Ossman [Fri, 11 Jun 2021 14:54:55 +0000 (16:54 +0200)]
Don't list clipboard parameters for x0vncserver

Better to just hide these parameters rather than stating that they are
unused in the man page.

3 years agoMerge branch 'tls' of https://github.com/CendioOssman/tigervnc
Pierre Ossman [Fri, 11 Jun 2021 11:07:33 +0000 (13:07 +0200)]
Merge branch 'tls' of https://github.com/CendioOssman/tigervnc

3 years agoDon't wait for TLS close response 1272/head
Pierre Ossman [Fri, 11 Jun 2021 07:40:49 +0000 (09:40 +0200)]
Don't wait for TLS close response

Our current architecture doesn't support waiting for a response here, so
don't even try or we'll just get an error.

3 years agoHandle GnuTLS shutdown on dead session
Pierre Ossman [Thu, 10 Jun 2021 14:40:28 +0000 (16:40 +0200)]
Handle GnuTLS shutdown on dead session

The session might have died, or failed to initialise properly, so be
prepared for gnutls_bye() to be unable to do its job.

3 years agoProperly clean up client VeNCrypt handling
Pierre Ossman [Thu, 10 Jun 2021 14:37:34 +0000 (16:37 +0200)]
Properly clean up client VeNCrypt handling

We would leak the security module below the top client VeNCrypt module,
meaning that those modules would not get a chance to shut down
gracefully.

3 years agoRemove unneeded NULL checks
Pierre Ossman [Thu, 10 Jun 2021 14:36:46 +0000 (16:36 +0200)]
Remove unneeded NULL checks

It's perfectly safe to delete NULL pointers, so simplify things by
removing these checks.

3 years agoPropagate exceptions from GnuTLS push/pull functions
Pierre Ossman [Thu, 10 Jun 2021 14:34:15 +0000 (16:34 +0200)]
Propagate exceptions from GnuTLS push/pull functions

Gives us a more meaningful error rather than just "Error in push/pull
function".

3 years agoRemove early data check for TLSInStream
Pierre Ossman [Thu, 10 Jun 2021 14:32:29 +0000 (16:32 +0200)]
Remove early data check for TLSInStream

Having this early check means that we somewhat randomly get different
exception behaviours on errors in deeper layers as some exceptions are
allowed to propagate unhindered and some are not (since they are thrown
in the pull function).

3 years agoPropagate errno to GnuTLS
Pierre Ossman [Thu, 10 Jun 2021 14:31:24 +0000 (16:31 +0200)]
Propagate errno to GnuTLS

Give GnuTLS the correct errno from deeper layers, in the cases where we
know it. In most cases GnuTLS doesn't care, but just in case...

3 years agoMerge branch 'actions' of https://github.com/CendioOssman/tigervnc
Pierre Ossman [Tue, 8 Jun 2021 10:13:56 +0000 (12:13 +0200)]
Merge branch 'actions' of https://github.com/CendioOssman/tigervnc

3 years agoConvert CI to GitHub Actions 1266/head
Pierre Ossman [Mon, 7 Jun 2021 15:09:15 +0000 (17:09 +0200)]
Convert CI to GitHub Actions

Travis has unfortunately been severely rate limited by Docker Hub so we
have to switch to GitHub, which has an agreement with Docker to avoid
the rate limiting.

3 years agoDon't run container builds with a TTY
Pierre Ossman [Tue, 8 Jun 2021 08:32:57 +0000 (10:32 +0200)]
Don't run container builds with a TTY

No TTY is provided in GitHub's environment, so we cannot have this flag.

3 years agoForce update of libarchive in CentOS 8 image
Pierre Ossman [Tue, 8 Jun 2021 08:43:35 +0000 (10:43 +0200)]
Force update of libarchive in CentOS 8 image

Otherwise cmake breaks as it requires a newer version without properly
listing that in its dependencies.

3 years agoDisable nonliteral format warnings on clang
Pierre Ossman [Tue, 8 Jun 2021 08:14:17 +0000 (10:14 +0200)]
Disable nonliteral format warnings on clang

These are incompatible with functions such as gettext() as clang hasn't
implemented the function attribute function_arg.

3 years agoHandle AltGr + accented letter key combo on Windows 1253/head
binary-manu [Mon, 7 Jun 2021 19:55:13 +0000 (21:55 +0200)]
Handle AltGr + accented letter key combo on Windows

3 years agoBoot strap github actions
Pierre Ossman [Mon, 7 Jun 2021 15:07:50 +0000 (17:07 +0200)]
Boot strap github actions

A initial workflow needs to be defined for actions to trigger on pull
requests, so just add a minimal, dummy one.

3 years agoCharArray: pre-fill empty array with zeroes
Jan Grulich [Tue, 25 May 2021 12:18:48 +0000 (14:18 +0200)]
CharArray: pre-fill empty array with zeroes

CharArray should always be null-terminated. There is a potential
scenario where this all might lead to crash. In Password we call
memset(), passing length of the array we get with strlen(), but
this won't return correct value when the array is not properly
null-terminated.

3 years agoMerge branch 'view-only-password' of https://github.com/grulja/tigervnc
Pierre Ossman [Mon, 7 Jun 2021 13:33:09 +0000 (15:33 +0200)]
Merge branch 'view-only-password' of https://github.com/grulja/tigervnc

3 years agoRefer to HOWTO.md from config comments
Pierre Ossman [Mon, 7 Jun 2021 12:29:37 +0000 (14:29 +0200)]
Refer to HOWTO.md from config comments

Give people a chance to know about the documentation.

3 years agoInclude "session" in examples instead of "desktop"
Pierre Ossman [Mon, 7 Jun 2021 12:28:25 +0000 (14:28 +0200)]
Include "session" in examples instead of "desktop"

It's almost mandatory to specify "session", but fairly rare to need to
set "desktop", so let's tweak the examples to avoid confusion and
mistakes.

3 years agoMerge branch 'TigerVNC:master' into accented-chars
binary-manu [Wed, 26 May 2021 16:03:22 +0000 (18:03 +0200)]
Merge branch 'TigerVNC:master' into accented-chars

3 years agoPrefer a non-zero getKeyCode() over getExtendedKeyCode()
binary-manu [Tue, 25 May 2021 18:53:47 +0000 (20:53 +0200)]
Prefer a non-zero getKeyCode() over getExtendedKeyCode()

3 years agoLet user know that a view-only password is not used 1260/head
Jan Grulich [Tue, 25 May 2021 12:14:33 +0000 (14:14 +0200)]
Let user know that a view-only password is not used

3 years agoHandle keys reported only by KeyEvent.getExtendedKeyCode
binary-manu [Tue, 18 May 2021 19:46:35 +0000 (21:46 +0200)]
Handle keys reported only by KeyEvent.getExtendedKeyCode

3 years agoAdd vnc_home_t type 1250/head
Zdenek Pytela [Tue, 18 May 2021 11:49:09 +0000 (13:49 +0200)]
Add vnc_home_t type

The new vnc_home_t type for HOME/.vnc directory was added to the policy,
backed by a name transition. The vnc_session_t domain can manage files
and directories of this type.

3 years agoAllow vnc_session_t manage nfs dirs and files conditionally
Zdenek Pytela [Tue, 18 May 2021 11:39:11 +0000 (13:39 +0200)]
Allow vnc_session_t manage nfs dirs and files conditionally

The permissions set to manage directories and files with the nfs_t type
is allowed when the use_nfs_home_dirs boolean is turned on.

Resolves: https://github.com/TigerVNC/tigervnc/issues/1189

3 years agoselinux: further style and comprehensibility improvements
Zdenek Pytela [Tue, 18 May 2021 11:31:53 +0000 (13:31 +0200)]
selinux: further style and comprehensibility improvements

Sections and rules blocks reordered according to the Style guide.

https://github.com/TresysTechnology/refpolicy/wiki/StyleGuide

3 years agoselinux: Fix issues reported by SELint
Vit Mojzis [Tue, 18 May 2021 10:23:15 +0000 (12:23 +0200)]
selinux: Fix issues reported by SELint

Style guide [1] issues only. No impact on policy functionality.

[1] - https://github.com/TresysTechnology/refpolicy/wiki/StyleGuide

3 years agoUpdate RHEL package spec files 1249/head
Jan Grulich [Tue, 18 May 2021 07:16:57 +0000 (09:16 +0200)]
Update RHEL package spec files

3 years agoSELinux: Add missing compression and install policy to correct directory
Jan Grulich [Mon, 17 May 2021 11:44:32 +0000 (13:44 +0200)]
SELinux: Add missing compression and install policy to correct directory

3 years agoAvoid absolute path for vncserver.users
Pierre Ossman [Mon, 3 May 2021 13:04:45 +0000 (15:04 +0200)]
Avoid absolute path for vncserver.users

Build flags control where this file ends up, so avoid assuming a
specific path in the HOWTO.

3 years agoReflow HOWTO.md to 72 columns
Pierre Ossman [Mon, 3 May 2021 13:03:53 +0000 (15:03 +0200)]
Reflow HOWTO.md to 72 columns

The line width was very inconsitent in this file, so standardise on the
common 72 characters.