]> source.dussan.org Git - gitea.git/log
gitea.git
5 years agoNew review approvals shouldn't require a message (#8991)
John Olheiser [Thu, 14 Nov 2019 20:58:01 +0000 (14:58 -0600)]
New review approvals shouldn't require a message (#8991)

* New approvals don't require content

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix edge-bug

Signed-off-by: jolheiser <john.olheiser@gmail.com>
5 years agoShadow password correctly for session config (#8984)
zeripath [Thu, 14 Nov 2019 20:06:02 +0000 (20:06 +0000)]
Shadow password correctly for session config (#8984)

Fix #8718

This PR shadows passwords in session config correctly by detecting
the VirtualProvider, unmarshalling the original config and then
shadowing config within that.

5 years agoDrop Admin attribute based on LDAP when login (continue #1743) (#8849)
6543 [Thu, 14 Nov 2019 19:10:23 +0000 (20:10 +0100)]
Drop Admin attribute based on LDAP when login (continue #1743) (#8849)

* Update User information in Gitea based on LDAP when login

* Update Admin Flag only if exist in settings

* Fix affectation

* Update models/login_source.go

Co-Authored-By: JustKiddingCode <JustKiddingCode@users.noreply.github.com>
* Better ident

* Apply suggestions from code review

Update user information

Co-Authored-By: 6543 <24977596+6543@users.noreply.github.com>
* Make fmt

* add err handling

* if user exist but login is Prohibit return return nil, and Prohibit err

* keep login speed

* User sync is implemented at #1478 - so only make sure that admin acces is drpoed if changed

* handle error and still use async task

* no async

* only update admin if Sync is enabled

* update two comments

* add lafriks suggestions

Co-Authored-By: Lauris BH <lauris@nix.lv>
* if adminFilter is set - use it

Co-Authored-By: Lauris BH <lauris@nix.lv>
* Update models/login_source.go

well - I should look more detaild at suggestions :D

Co-Authored-By: Lauris BH <lauris@nix.lv>
* make it work again

* set is_admin value to user

* look nicer

5 years agofix bug when pack js (#8992)
Lunny Xiao [Thu, 14 Nov 2019 17:58:32 +0000 (01:58 +0800)]
fix bug when pack js (#8992)

5 years agoAdd ALLOW_ONLY_EXTERNAL_REGISTRATION to config cheat sheet (#8986)
zeripath [Thu, 14 Nov 2019 16:58:34 +0000 (16:58 +0000)]
Add ALLOW_ONLY_EXTERNAL_REGISTRATION to config cheat sheet (#8986)

ALLOW_ONLY_EXTERNAL_REGISTRATION was missed off the cheat sheet. This PR adds it.

Fix #8180

5 years agoChangelog for 1.10.0 (#8978) (#8987)
John Olheiser [Thu, 14 Nov 2019 15:34:30 +0000 (09:34 -0600)]
Changelog for 1.10.0 (#8978) (#8987)

* Changelog for 1.10.0 (#8978)

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Update security

Signed-off-by: jolheiser <john.olheiser@gmail.com>
5 years ago[Feature] Add Gitea Emoji (#8950)
6543 [Thu, 14 Nov 2019 13:44:46 +0000 (14:44 +0100)]
[Feature] Add Gitea Emoji (#8950)

* add gitea emoji

* alphabetic order

* Update emojify.js to 1.1.0

* mv to custom

* add gitea emoji

* minify

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Thu, 14 Nov 2019 08:01:32 +0000 (08:01 +0000)]
[skip ci] Updated translations via Crowdin

5 years agofix(docs): Fixed creating Windows service commands (#8979)
Wars [Thu, 14 Nov 2019 07:57:29 +0000 (15:57 +0800)]
fix(docs): Fixed creating Windows service commands (#8979)

escaping " to \"

5 years agodocs reference latest stable version (1.10.0)
techknowlogick [Thu, 14 Nov 2019 06:37:12 +0000 (01:37 -0500)]
docs reference latest stable version (1.10.0)

5 years agoRefactor pull request review (#8954)
Lunny Xiao [Thu, 14 Nov 2019 02:57:36 +0000 (10:57 +0800)]
Refactor pull request review (#8954)

* refactor submit review

* remove unnecessary code

* remove unused comment

* fix lint

* remove duplicated actions

* remove duplicated actions

* fix typo

* fix comment content

5 years agoBackport the backport of 1.9.6 (#8970)
John Olheiser [Wed, 13 Nov 2019 22:11:52 +0000 (16:11 -0600)]
Backport the backport of 1.9.6 (#8970)

Signed-off-by: jolheiser <john.olheiser@gmail.com>
5 years agoFix intermittent GPG Git test failure (#8968)
zeripath [Wed, 13 Nov 2019 21:06:35 +0000 (21:06 +0000)]
Fix intermittent GPG Git test failure (#8968)

5 years agoAdd CDNJS to script-src CSP (#8966)
John Olheiser [Wed, 13 Nov 2019 20:22:09 +0000 (14:22 -0600)]
Add CDNJS to script-src CSP (#8966)

5 years agoDon't send notification on pending reviews (#8943)
guillep2k [Wed, 13 Nov 2019 18:36:04 +0000 (15:36 -0300)]
Don't send notification on pending reviews (#8943)

5 years agoImplement documentation search (#8937)
John Olheiser [Wed, 13 Nov 2019 18:03:18 +0000 (12:03 -0600)]
Implement documentation search (#8937)

* Implement documentation search

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
5 years agoMove index.js to web_src and use webpack to pack them (#8598)
Lunny Xiao [Wed, 13 Nov 2019 14:52:13 +0000 (22:52 +0800)]
Move index.js to web_src and use webpack to pack them (#8598)

* Move index.js to web_src and use webpack

* Fix initHeatMap

* update eslint and move webpack to devDependencies

* update index.js

* add eslint env node

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 13 Nov 2019 13:16:43 +0000 (13:16 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoadd /etc/timezone and /etc/localtime volumes (#8911)
Florian Hübner [Wed, 13 Nov 2019 12:46:46 +0000 (13:46 +0100)]
add /etc/timezone and /etc/localtime volumes (#8911)

Passing these volumes to the container enable gitea to use hosts localtime and timezone.
This is a mandatory change when using the "Setup fail2ban" Guide, but it is not described in the documentation.

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 13 Nov 2019 07:22:32 +0000 (07:22 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoAdd Close() method to gogitRepository (#8901)
zeripath [Wed, 13 Nov 2019 07:01:19 +0000 (07:01 +0000)]
Add Close() method to gogitRepository (#8901)

In investigating #7947 it has become clear that the storage component of go-git repositories needs closing.

This PR adds this Close function and adds the Close functions as necessary.

In TransferOwnership the ctx.Repo.GitRepo is closed if it is open to help prevent the risk of multiple open files.

Fixes #7947

5 years agoConvert EOL to UNIX-style to render MD properly (#8925)
guillep2k [Wed, 13 Nov 2019 02:27:11 +0000 (23:27 -0300)]
Convert EOL to UNIX-style to render MD properly (#8925)

* Convert EOL to UNIX-style to render MD properly

* Update modules/markup/markdown/markdown.go

Co-Authored-By: zeripath <art27@cantab.net>
* Fix lint optimization

* Check for empty content before conversion

* Update modules/util/util.go

Co-Authored-By: zeripath <art27@cantab.net>
* Improved checks and tests

* Add paragraph render test

* Improve speed even more, improve tests

* Small improvement by @gary-kim

* Fix test for DOS

* More improvements

* Restart CI

5 years agoShow repository size in repo home page and settings (#8940)
Antoine GIRARD [Wed, 13 Nov 2019 00:45:19 +0000 (01:45 +0100)]
Show repository size in repo home page and settings (#8940)

* feat: display repository size on repo home and settings

* refactor: move repo size up in setting page

5 years agoFix Notify Create Ref Error on tag creation (#8936)
zeripath [Tue, 12 Nov 2019 23:49:40 +0000 (23:49 +0000)]
Fix Notify Create Ref Error on tag creation (#8936)

* Fix Notify Create Ref Error on tag creation

* Just use the provided full ref instead of BranchCommit

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Tue, 12 Nov 2019 22:51:56 +0000 (22:51 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoUpdate Github Migration Tests (#8938)
mrsdizzie [Tue, 12 Nov 2019 22:48:21 +0000 (17:48 -0500)]
Update Github Migration Tests (#8938)

Update all Github migration tests to use a new repo created just for
these tests that won't accidentially be modified by regular users
interacting with issues.

Fixes #8895

5 years agoFix spelling as suggested by @rmbleeker (#8934)
guillep2k [Tue, 12 Nov 2019 15:47:29 +0000 (12:47 -0300)]
Fix spelling as suggested by @rmbleeker (#8934)

5 years agoMove less from public/ to web_src/ so that it will not be packe… (#8908)
Lunny Xiao [Tue, 12 Nov 2019 09:22:16 +0000 (17:22 +0800)]
Move less from public/ to web_src/ so that it will not be packe… (#8908)

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Tue, 12 Nov 2019 08:36:01 +0000 (08:36 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoImprove notification (#8835)
Lunny Xiao [Tue, 12 Nov 2019 08:33:34 +0000 (16:33 +0800)]
Improve notification (#8835)

* Improve notifications

* batch load user

* Update notification only when read

* Fix reorder

* fix lint

* fix test

* fix lint

* make function meaningful

* fix comment

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Mon, 11 Nov 2019 17:09:24 +0000 (17:09 +0000)]
[skip ci] Updated translations via Crowdin

5 years agojs: Revert change to click behaviour in forceSelection (#8921)
Jookia [Mon, 11 Nov 2019 17:06:57 +0000 (17:06 +0000)]
js: Revert change to click behaviour in forceSelection (#8921)

Calling .click() in forceSelection() in blur() causes a focus loop,
this needs a proper fix later but for now just revert the change.

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Mon, 11 Nov 2019 15:19:00 +0000 (15:19 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoTemplate Repositories (#8768)
John Olheiser [Mon, 11 Nov 2019 15:15:29 +0000 (09:15 -0600)]
Template Repositories (#8768)

* Start work on templates

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Continue work

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix IsTemplate vs IsGenerated

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix tabs vs spaces

* Tabs vs Spaces

* Add templates to API & start adding tests

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix integration tests

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Remove unused User

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Move template tests to existing repos

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Minor re-check updates and cleanup

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* make fmt

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Test cleanup

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix optionalbool

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* make fmt

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Test fixes and icon change

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Add new user and repo for tests

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix tests (finally)

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Update meta repo with env variables

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Move generation to create page

Combine with repo create template
Modify API search to prioritize owner for repo

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix tests and coverage

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix swagger and JS lint

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix API searching for own private repos

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Change wording

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix repo search test. User had a private repo that didn't show up

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Another search test fix

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Clarify git content

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Feedback updates

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Add topics WIP

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Finish adding topics

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Update locale

Signed-off-by: jolheiser <john.olheiser@gmail.com>
5 years agoMigrate temp_repo.go to use git.NewCommand (#8918)
zeripath [Mon, 11 Nov 2019 11:46:28 +0000 (11:46 +0000)]
Migrate temp_repo.go to use git.NewCommand  (#8918)

This PR migrates temp_repo.go to use git.NewCommand instead creating processes by itself - this fixes the problem underlying PR #8905.

There are other places that run git outside of the controlled locale defined in #8548 but temp_repo.go is the only cause of failure of local testing in cases where English is not the default - implying that error messages from those other commands are not interpreted.

Replaces #8905

5 years agoOnly view branch or tag if it match refType requested. (#8899)
David Svantesson [Mon, 11 Nov 2019 07:37:28 +0000 (08:37 +0100)]
Only view branch or tag if it match refType requested. (#8899)

* only view branch or tag if it match refName.

* remove pointer in method

5 years agoMove notifywatchers from models to notification (#8907)
Lunny Xiao [Mon, 11 Nov 2019 03:39:41 +0000 (11:39 +0800)]
Move notifywatchers from models to notification (#8907)

5 years agoFix typo in doc (#8914)
Florian Hübner [Mon, 11 Nov 2019 01:33:28 +0000 (02:33 +0100)]
Fix typo in doc (#8914)

Fix typo in doc fail2ban-setup.md

5 years agoStop using git count-objects and use raw directory size for repository (#8848)
zeripath [Sun, 10 Nov 2019 21:33:47 +0000 (21:33 +0000)]
Stop using git count-objects and use raw directory size for repository (#8848)

* Migrate from git count-objects to a raw directory size
* As per @guillep2k ignore unusual files

5 years agoRephrase comment about RuntimeDirectory option (#8912)
Anthony Vanelverdinghe [Sun, 10 Nov 2019 16:49:39 +0000 (17:49 +0100)]
Rephrase comment about RuntimeDirectory option (#8912)

5 years agoAuto-subscribe user to repository when they commit/tag to it (#7657)
guillep2k [Sun, 10 Nov 2019 09:22:19 +0000 (06:22 -0300)]
Auto-subscribe user to repository when they commit/tag to it (#7657)

* Add support for AUTO_WATCH_ON_CHANGES and AUTO_WATCH_ON_CLONE

* Update models/repo_watch.go

Co-Authored-By: Lauris BH <lauris@nix.lv>
* Round up changes suggested by lafriks

* Added changes suggested from automated tests

* Updated deleteUser to take RepoWatchModeDont into account, corrected inverted DefaultWatchOnClone and DefaultWatchOnChanges behaviour, updated and added tests.

* Reinsert import "github.com/Unknwon/com" on http.go

* Add migration for new column `watch`.`mode`

* Remove serv code

* Remove WATCH_ON_CLONE; use hooks, add integrations

* Renamed watch_test.go to repo_watch_test.go

* Correct fmt

* Add missing EOL

* Correct name of test function

* Reword cheat and ini descriptions

* Add update to migration to ensure column value

* Clarify comment

Co-Authored-By: zeripath <art27@cantab.net>
* Simplify if condition

5 years agoAdjust error reporting from merge failures and use LC_ALL=C for git (#8548)
zeripath [Sun, 10 Nov 2019 08:42:51 +0000 (08:42 +0000)]
Adjust error reporting from merge failures and use LC_ALL=C for git (#8548)

There are two major components to this PR:

* This PR handles merge and rebase failures from merging a little more nicely with Flash errors rather a 500.
* All git commands are run in the LC_ALL="C" environment to ensure that error messages are in English. This DefaultLocale is defined in a way that if necessary (due to platform weirdness) it can be overridden at build time using LDFLAGS="-X "code.gitea.io/gitea/modules/git.DefaultLocale=C"" with C changed for the locale as necessary.

5 years agoFix API Bug (fail on empty assignees) (#8873)
6543 [Sun, 10 Nov 2019 08:07:21 +0000 (09:07 +0100)]
Fix API Bug (fail on empty assignees) (#8873)

* keep sure if assigneeIDs == nil -> do nothing

* fix #8872

* Revert "keep sure if assigneeIDs == nil -> do nothing"

-> go handle it itself preaty well

This reverts commit e72d94129c4666d5151f6131cb2f8c1de127d9d0.

* clarity comparson

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* simplify

* Update models/issue_assignees.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Update issue_assignees.go

* simplify more

* add --if oneAssignee != ""-- again

* Update models/issue_assignees.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* CI.restart()

* Update issue_assignees.go

* add Test for GetUserIDsByNames

* add Test for MakeIDsFromAPIAssigneesToAdd

* fix test

5 years agoMove code.gitea.io/gitea/routers/api/v1/convert to code.gitea.io/gitea/modules/conver...
Lunny Xiao [Sun, 10 Nov 2019 04:41:51 +0000 (12:41 +0800)]
Move code.gitea.io/gitea/routers/api/v1/convert to code.gitea.io/gitea/modules/convert (#8892)

* Move code.gitea.io/gitea/routers/api/v1/convert to code.gitea.io/gitea/modules/convert

* fix fmt

5 years agoFix issue with user.fullname (#8902)
zeripath [Sat, 9 Nov 2019 23:21:53 +0000 (23:21 +0000)]
Fix issue with user.fullname (#8902)

5 years agoEnable punctuations ending mentions (#8889)
guillep2k [Sat, 9 Nov 2019 22:12:05 +0000 (19:12 -0300)]
Enable punctuations ending mentions (#8889)

* Enable punctuations ending mentions

* Improve tests

5 years agoUpdate Github migration test (#8893)
mrsdizzie [Sat, 9 Nov 2019 20:13:35 +0000 (15:13 -0500)]
Update Github migration test (#8893)

* Update Github migration test

Earlier today #716 was reopened which updated the modification time for
an old milestone (1.6.0) that we use in testing with the assumption that
it is old and won't change. This breaks all builds now, so remove this
test since we have others that test the same code and this milestone
will likely be updated again as that issue changes etc...

* ci

5 years agoLeave non-dated issues for last (#8871)
guillep2k [Sat, 9 Nov 2019 13:09:01 +0000 (10:09 -0300)]
Leave non-dated issues for last (#8871)

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 9 Nov 2019 09:45:09 +0000 (09:45 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoFix require external registration password (#8885)
guillep2k [Sat, 9 Nov 2019 09:42:34 +0000 (06:42 -0300)]
Fix require external registration password (#8885)

* Fix require external registration password

* Fix ctx on error condition by @jolheiser

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 9 Nov 2019 03:44:04 +0000 (03:44 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoFix password complexity check on registration (#8887)
guillep2k [Sat, 9 Nov 2019 03:40:37 +0000 (00:40 -0300)]
Fix password complexity check on registration (#8887)

* Fix registration password complexity

* Fix integration to use a complex password ;)

5 years agoAllow to add and remove all repositories to/from team. (#8867)
David Svantesson [Sat, 9 Nov 2019 00:39:37 +0000 (01:39 +0100)]
Allow to add and remove all repositories to/from team. (#8867)

* Allow to add and remove all repositories to team.

* Change style, buttons on same row.

* Apply suggestions from code review

Grammar

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Move set num repos to lower function.

* Make general language sentences

5 years agoCreate third-party-tools.zh-cn.md (#6303)
MysticBoy [Fri, 8 Nov 2019 22:32:30 +0000 (06:32 +0800)]
Create third-party-tools.zh-cn.md (#6303)

* Create third-party-tools.zh-cn.md

* Update third-party-tools.zh-cn.md

* Update third-party-tools.zh-cn.md

5 years agoFix bug when migrate from API (#8631)
Lunny Xiao [Fri, 8 Nov 2019 22:21:00 +0000 (06:21 +0800)]
Fix bug when migrate from API (#8631)

* fix bug when migrate from API

* fix test

* fix test

* improve

* fix error message

5 years agoWebhook support custom proxy (#8760)
Lunny Xiao [Fri, 8 Nov 2019 21:25:53 +0000 (05:25 +0800)]
Webhook support custom proxy (#8760)

* Webhook support custom proxy

* Add glob support on webhook proxy host rules

* fix app.ini.sample

* improve code and app.ini.sample

* update cheetsheet about added webhook options

5 years agoMove some actions to notification/action (#8779)
Lunny Xiao [Fri, 8 Nov 2019 20:54:50 +0000 (04:54 +0800)]
Move some actions to notification/action (#8779)

* Move some actions to notification/action

* Fix test

* fix test

5 years agoAdd password reset to FAQ (#8883)
John Olheiser [Fri, 8 Nov 2019 19:44:18 +0000 (13:44 -0600)]
Add password reset to FAQ (#8883)

* Add password reset to FAQ

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Add links to email setup docs

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Add en-us to email setup

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Update docs/content/doc/help/faq.en-us.md

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Manually merge changes from @guillep2k and add small changes

Signed-off-by: jolheiser <john.olheiser@gmail.com>
5 years agoa11y: Improve accessibility of dropdown menus (#8638)
Jookia [Fri, 8 Nov 2019 17:33:21 +0000 (17:33 +0000)]
a11y: Improve accessibility of dropdown menus (#8638)

* js: Import Semantic-UI's dropdown.js (version 2.3.1)

* js: Set tabindex=-1 on dropdown items

Setting tabindex=-1 on focusable elements within dropdown menus allows
the user to treat dropdown menus as a single focusable item with its own
internal navigation using arrow keys.

* js: Don't use jQuery to click menu items

Menu items are often <a> elements, which jQuery refuses to trigger click
events on. Instead it just bubbles up to the menu.

Using HTMLElement's click method fixes this and makes menu items
clickable from the keyboard using dropdown menus.

* js: Set correct ARIA 1.1 roles on dropdown menus

Setting role= makes assistive technology aware there is a widget here.
In this case, Orca will now exit browse mode and allow us to capture
keydown events when focused on a dropdown menu. It will also inform the
user that there's a menu focused.

Since dropdowns can be used in multiple elements each with different
ARIA roles, a guessRole method is used to find the correct role.
All roles I consider possible are listed, but only menu is implemented.

* js: Set aria-expanded when dropdown menus show and hide

This is deliberately done before the transition finishes so that screen
readers get immediate feedback.

* js: Set aria-label or aria-labelledby on dropdown menus

This makes dropdown menu buttons screen reader accessible.

aria-labelledby refers to an element using an ID, so the chosen labels
are now assigned a unique ID- This ID is not stable, do not refer to it
with user scripts.

* js: Set aria-activedescendant on dropdown menus

As the menus grab focus and navigate by tracking a 'selected' div class,
assistive technology has no idea that what the current selection is.

Assign IDs to each menu item and set aria-activedescendant to the ID of
the currently selected menu item.

When the menu is unfocused, remove aria-activedescendant- This isn't
neccessary but in my experience it triggers Orca to remind the user of
their current selection when re-focusing the menu.

* Makefile: Make eslint ignore semantic.dropdown.js

This file is taken from Semantic UI which isn't linted upstream.
Ignore it as we won't fix these issues.

* js: Add version note to semantic.dropdown.js

* Add Md5 AppVer to templates/base/footer.tmpl

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Add Md5 AppVer to templates/pwa/serviceworker_js.tmpl

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* semantic.dropdown.js -> semantic.dropdown.custom.js

* Use eslintignore

* remove bogus submodule

5 years agoFix edit content button on migrated issue content (#8877)
mrsdizzie [Fri, 8 Nov 2019 07:01:24 +0000 (02:01 -0500)]
Fix edit content button on migrated issue content (#8877)

Typo on a closing span tag caused edit button not to work properly on
the original issue content for a migrated issue.

Fixes #8876

5 years agoShow due date in dashboard issues list (#8860)
mrsdizzie [Thu, 7 Nov 2019 20:12:23 +0000 (15:12 -0500)]
Show due date in dashboard issues list (#8860)

* Show due date in dashboard issues list

Include due date when vieiwiing all issues on dashboard (matching what
we show for repo issue lists).

Fixes #8859

* Put in same order as repo issue list

* Add suggested changes and also update repo issue list to match

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Thu, 7 Nov 2019 18:33:04 +0000 (18:33 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoFix count for commit graph last page (#8843)
jaqra [Thu, 7 Nov 2019 18:09:51 +0000 (21:09 +0300)]
Fix count for commit graph last page (#8843)

* Fix count for commit graph last page

* Remove used once variable

* Move func to model

* capitalize method name

* fix error message

5 years agoUse templates for issue e-mail subject and body (#8329)
guillep2k [Thu, 7 Nov 2019 13:34:28 +0000 (10:34 -0300)]
Use templates for issue e-mail subject and body (#8329)

* Add template capability for issue mail subject

* Remove test string

* Fix trim subject length

* Add comment to template and run make fmt

* Add information for the template

* Rename defaultMailSubject() to fallbackMailSubject()

* General rewrite of the mail template code

* Fix .Doer name

* Use text/template for subject instead of html

* Fix subject Re: prefix

* Fix mail tests

* Fix static templates

* [skip ci] Updated translations via Crowdin

* Expose db.SetMaxOpenConns and allow non MySQL dbs to set conn pool params (#8528)

* Expose db.SetMaxOpenConns and allow other dbs to set their connection params
* Add note about port exhaustion

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Prevent .code-view from overriding font on icon fonts (#8614)

* Correct some outdated statements in the contributing guidelines (#8612)

* More information for drone-cli in CONTRIBUTING.md

* Increases the version of drone-cli to 1.2.0
* Adds a note for the Docker Toolbox on Windows

Signed-off-by: LukBukkit <luk.bukkit@gmail.com>
* Fix the url for the blog repository (now on gitea.com)

Signed-off-by: LukBukkit <luk.bukkit@gmail.com>
* Remove TrN due to lack of lang context

* Redo templates to match previous code

* Fix extra character in template

* Unify PR & Issue tempaltes, fix format

* Remove default subject

* Add template tests

* Fix template

* Remove replaced function

* Provide User as models.User for better consistency

* Add docs

* Fix doc inaccuracies, improve examples

* Change mail footer to math AppName

* Add test for mail subject/body template separation

* Add support for code review comments

* Update docs/content/doc/advanced/mail-templates-us.md

Co-Authored-By: 6543 <24977596+6543@users.noreply.github.com>
5 years agoTheme arc-green: reverse heatmap colors (#8840)
Damien Pollet [Wed, 6 Nov 2019 17:23:06 +0000 (18:23 +0100)]
Theme arc-green: reverse heatmap colors (#8840)

* Theme arc-green: reverse heatmap colors

This uses the same colors as the updated palette in the base theme.

See #8709 and #5864, in particular [my comment showing the problem](https://github.com/go-gitea/gitea/issues/5864#issuecomment-462334171)

* Rebuild CSS

* Use link color as hot, interpolate between hot and cold colors

* Use color from a:hover

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 6 Nov 2019 13:42:48 +0000 (13:42 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoSplit sendCreateCommentAction as two parts, one for update comment related informatio...
Lunny Xiao [Wed, 6 Nov 2019 13:39:29 +0000 (21:39 +0800)]
Split sendCreateCommentAction as two parts, one for update comment related informations, another for actions (#8784)

* Split sendCreateCommentAction as two parts, one for update comment related informations, another for actions

* fix lint

5 years agoAdd team option to grant rights for all organization repositories (#8688)
David Svantesson [Wed, 6 Nov 2019 09:37:14 +0000 (10:37 +0100)]
Add team option to grant rights for all organization repositories (#8688)

* Add field IsAllRepositories to team

* Add AllRepositories to team UI

* Manage team with access to all repositories

* Add field IsAllRepositories to team API

* put backticks around table/column names

* rename IsAllRepositories to IncludesAllRepositories

* do not reload slice if already loaded

* add repo to teams with access to all repositories when changing repo owner

* improve tests for teams with access to all repositories

* Merge branch 'master'

* Change code for adding all repositories

Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* fmt after merge

* Change code in API EditTeam similar to EditTeamPost web interface

Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Clarify that all repositories will be added

Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* All repositories option under Permissions headline

* New setting group 'Repository access'

* Move check IncludeAllRepositories to removeRepository.

* Revert "Move check IncludeAllRepositories to removeRepository." and add comment instead.

This reverts commit 753b7d205be260b8be465b5291a02975a81f3093.

* Clarify help text what options do.

5 years agoMove release webhook to notification (#8817)
Lunny Xiao [Wed, 6 Nov 2019 08:25:50 +0000 (16:25 +0800)]
Move release webhook to notification (#8817)

* Move release webhook to notification

* Extract release webhook method

* fix bug

* fix import

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 6 Nov 2019 06:44:54 +0000 (06:44 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoMove repofiles webhooks to notification (#8807)
Lunny Xiao [Wed, 6 Nov 2019 06:43:03 +0000 (14:43 +0800)]
Move repofiles webhooks to notification (#8807)

5 years agoAdd migrate command to docs (#8842)
John Olheiser [Tue, 5 Nov 2019 18:54:54 +0000 (12:54 -0600)]
Add migrate command to docs (#8842)

* Add migrate command to docs

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Link to CLI

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Clarify idempotence

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Sneak in convert command

Signed-off-by: jolheiser <john.olheiser@gmail.com>
5 years agoupdate docs to latest version (#8845)
techknowlogick [Tue, 5 Nov 2019 18:54:20 +0000 (13:54 -0500)]
update docs to latest version (#8845)

5 years agoFix to close opened io resources as soon as not needed (#8839)
Lauris BH [Tue, 5 Nov 2019 12:54:47 +0000 (14:54 +0200)]
Fix to close opened io resources as soon as not needed (#8839)

* Fix to close opened io resources as soon as not needed

* Remove unneeded err checks

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Tue, 5 Nov 2019 12:09:43 +0000 (12:09 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoMove pull webhook to notification (#8805)
Lunny Xiao [Tue, 5 Nov 2019 11:04:08 +0000 (19:04 +0800)]
Move pull webhook to notification (#8805)

* Move pull webhook to notification

* fix fmt

5 years agoUpdate go-org to optimize code (#8824)
Lauris BH [Tue, 5 Nov 2019 08:39:03 +0000 (10:39 +0200)]
Update go-org to optimize code (#8824)

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Tue, 5 Nov 2019 06:52:00 +0000 (06:52 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoFix (open/closed) issue count when label excluded (#8815)
jaqra [Tue, 5 Nov 2019 06:48:51 +0000 (09:48 +0300)]
Fix (open/closed) issue count when label excluded (#8815)

* Fix (open/closed) issue count when label excluded

* Use capital sql keywords

5 years agoAdd additional periods to activity page (#8829)
Lauris BH [Tue, 5 Nov 2019 05:45:48 +0000 (07:45 +0200)]
Add additional periods to activity page (#8829)

5 years agoREADME: Update Screenshots and Badges in ZH (#8813)
6543 [Tue, 5 Nov 2019 00:12:58 +0000 (01:12 +0100)]
README: Update Screenshots and Badges in ZH (#8813)

* use relative instead of absolute paths

* update badges of ZH readme

* update screenshots

* use <style> for table

* remove useles stype

* absolute paths for images

5 years agoFix new user form for non-local users (#8826)
Lauris BH [Mon, 4 Nov 2019 19:10:37 +0000 (21:10 +0200)]
Fix new user form for non-local users (#8826)

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Mon, 4 Nov 2019 10:23:49 +0000 (10:23 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoFix: remove duplicated signed commit icons (#8820)
Wenxuan Zhao [Mon, 4 Nov 2019 10:20:12 +0000 (02:20 -0800)]
Fix: remove duplicated signed commit icons (#8820)

Signed-off-by: Wenxuan Zhao <viz@linux.com>
5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Mon, 4 Nov 2019 04:52:17 +0000 (04:52 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoExplicity indicate the socket unit to use the service unit "gitea.service" (#8804)
Ramon Fischer [Mon, 4 Nov 2019 04:42:30 +0000 (05:42 +0100)]
Explicity indicate the socket unit to use the service unit "gitea.service" (#8804)

* rename socket file, make example more precise, use long parameter name

* correct path

* use the correct path to the configuration file according to the documentation

* rename the socket unit back to 'gitea.main.socket', explicitly indicate that the socket unit should use the service file 'gitea.service'

5 years agoMove more webhook codes from models to webhook module (#8802)
Lunny Xiao [Sun, 3 Nov 2019 22:13:25 +0000 (06:13 +0800)]
Move more webhook codes from models to webhook module (#8802)

* Move more webhook codes from models to webhook module

5 years agoMove actions to notification (#8785)
Lunny Xiao [Sun, 3 Nov 2019 20:59:09 +0000 (04:59 +0800)]
Move actions to notification (#8785)

5 years agoFix API deadline removal (#8759)
David Svantesson [Sun, 3 Nov 2019 14:46:32 +0000 (15:46 +0100)]
Fix API deadline removal (#8759)

* Handle deadline is zero (to remove deadline)

* Better API documentation for issue deadline.

* Add parameter to unset due date.

* Update pull edit API comment

5 years agoFix SSH2 conditonal in key parsing code (#8806) 7349/head
mrsdizzie [Sun, 3 Nov 2019 11:08:18 +0000 (06:08 -0500)]
Fix SSH2 conditonal in key parsing code (#8806)

Avoid out of bounds error by using strings.HasPrefix to check for
starting SSH2 text rather than assuming user input has at least 31
characters.

Add tests for bad input as well.

Fixes #8800

5 years agoMove push commits events to notification (#8783)
Lunny Xiao [Sun, 3 Nov 2019 06:59:26 +0000 (14:59 +0800)]
Move push commits events to notification (#8783)

* Move push commits events to notification

* Update modules/notification/base/null.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
5 years ago[Fix] Checkbox at RepoSettings Protected Branch (#8799)
6543 [Sun, 3 Nov 2019 00:54:39 +0000 (01:54 +0100)]
[Fix] Checkbox at RepoSettings Protected Branch (#8799)

* add missing "d"

* CI.redo()

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 2 Nov 2019 22:49:35 +0000 (22:49 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoFIX download diff/patch from commit (#8792)
6543 [Sat, 2 Nov 2019 22:47:25 +0000 (23:47 +0100)]
FIX download diff/patch from commit (#8792)

* send fix

* restart CI

* us Commit only when available

* CI.redo()

* more specific if statement

Co-Authored-By: mrsdizzie <info@mrsdizzie.com>
5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 2 Nov 2019 15:29:18 +0000 (15:29 +0000)]
[skip ci] Updated translations via Crowdin

5 years agoAdd API for Issue set Subscription (#8729)
6543 [Sat, 2 Nov 2019 15:27:49 +0000 (16:27 +0100)]
Add API for Issue set Subscription (#8729)

* add issue subscriber API

* subscribers return []user.APIFormat

* add comments

* more meaningfull description

* without "reqToken()" api works ...
 * should be still secure beause ctx.user has to be there or nothing will hapen

* FIX: getIssueWatchers() get only aktive suscriber

* add return avter error on right position

* Revert "FIX: getIssueWatchers() get only aktive suscriber"

This reverts commit 5eca9291858a821981992b0aaa38cef610d84bca.

* Update routers/api/v1/repo/issue.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* test go linter again

* update swagger

* GetIssueWatchers -> GetIssueSubscribers

part one

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* GetIssueWatchers -> GetIssueSubscribers
part two

* Revert "test go linter again"

This reverts commit bab12356227e44334de113b76f12099de0b8aaa6.

* change description for unsubscribe too

* golangci-lint timeout avter 5min

* move issueSubscription to seperate file

* dont create black entitys

* use IsWatching until refactoring

* Update License Info

* better swagger description

* Update .golangci.yml

because functions moved from issue.go to issue_subscription.go

* add IssueWatchList type

* batch tasks

* use e Engien

* add error handling

* error should be the last type when returning multiple items

* short version

* reurn empy UserList instead of nil

5 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 2 Nov 2019 13:40:49 +0000 (13:40 +0000)]
[skip ci] Updated translations via Crowdin

5 years agofix 500 when edit hook (#8782)
Lunny Xiao [Sat, 2 Nov 2019 13:38:11 +0000 (21:38 +0800)]
fix 500 when edit hook (#8782)

5 years agoPrevent upload (overwrite) of lfs locked file (#8769)
David Svantesson [Sat, 2 Nov 2019 07:37:05 +0000 (08:37 +0100)]
Prevent upload (overwrite) of lfs locked file (#8769)

* Check if file is locked on upload file commit.

* Better user message if file is locked.

* Check lfs lock before creating temporary repository. fix some errors.

* move lines

* Add comment that enabled setting is checked.

5 years agoOn windows set core.longpaths true (#8776)
zeripath [Sat, 2 Nov 2019 05:40:49 +0000 (05:40 +0000)]
On windows set core.longpaths true (#8776)