]> source.dussan.org Git - redmine.git/log
redmine.git
5 years agoShow attachment thumbnails by default (#32249).
Go MAEDA [Thu, 31 Oct 2019 13:20:16 +0000 (13:20 +0000)]
Show attachment thumbnails by default (#32249).

git-svn-id: http://svn.redmine.org/redmine/trunk@18886 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDon't try to generate thumbnails if convert command is not available (#32289).
Go MAEDA [Thu, 31 Oct 2019 13:07:14 +0000 (13:07 +0000)]
Don't try to generate thumbnails if convert command is not available (#32289).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18885 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate RuboCop to 0.76.0 (#31509).
Go MAEDA [Thu, 31 Oct 2019 09:18:39 +0000 (09:18 +0000)]
Update RuboCop to 0.76.0 (#31509).

git-svn-id: http://svn.redmine.org/redmine/trunk@18884 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd estimated hours and spent hours to Versions API (#32242).
Go MAEDA [Thu, 31 Oct 2019 02:15:10 +0000 (02:15 +0000)]
Add estimated hours and spent hours to Versions API (#32242).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18883 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTraditional Chinese translation update (#32373).
Go MAEDA [Wed, 30 Oct 2019 09:17:29 +0000 (09:17 +0000)]
Traditional Chinese translation update (#32373).

Patch by ChunChang Lo.

git-svn-id: http://svn.redmine.org/redmine/trunk@18882 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd a fixture for QueryTest#test_filter_my_bookmarks (#29482).
Go MAEDA [Wed, 30 Oct 2019 02:23:23 +0000 (02:23 +0000)]
Add a fixture for QueryTest#test_filter_my_bookmarks (#29482).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18881 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoEases the regexp used to determine the start of a code block (#32359).
Go MAEDA [Tue, 29 Oct 2019 21:54:04 +0000 (21:54 +0000)]
Eases the regexp used to determine the start of a code block (#32359).

Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@18880 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix incomplete Italian translation for notice_successful keys (#32358).
Go MAEDA [Tue, 29 Oct 2019 08:07:29 +0000 (08:07 +0000)]
Fix incomplete Italian translation for notice_successful keys (#32358).

Patch by pasquale [:dedalus].

git-svn-id: http://svn.redmine.org/redmine/trunk@18879 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd permission to import time entries (#32196, #28234).
Go MAEDA [Mon, 28 Oct 2019 14:02:25 +0000 (14:02 +0000)]
Add permission to import time entries (#32196, #28234).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18878 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd a fixture for UserTest#test_bookmarked_project_ids (#29482).
Go MAEDA [Mon, 28 Oct 2019 13:41:41 +0000 (13:41 +0000)]
Add a fixture for UserTest#test_bookmarked_project_ids (#29482).

git-svn-id: http://svn.redmine.org/redmine/trunk@18877 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove trailing whitespaces from test/fixtures/roles.yml
Go MAEDA [Mon, 28 Oct 2019 13:27:08 +0000 (13:27 +0000)]
Remove trailing whitespaces from test/fixtures/roles.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18876 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix inconsistent capitalization in Italian translation (#32354).
Go MAEDA [Mon, 28 Oct 2019 09:16:55 +0000 (09:16 +0000)]
Fix inconsistent capitalization in Italian translation (#32354).

Patch by pasquale [:dedalus].

git-svn-id: http://svn.redmine.org/redmine/trunk@18875 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoBulgarian translation update (#32353).
Go MAEDA [Sun, 27 Oct 2019 08:04:14 +0000 (08:04 +0000)]
Bulgarian translation update (#32353).

Patch by Ivan Cenov.

git-svn-id: http://svn.redmine.org/redmine/trunk@18874 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd a link to projects administration page on projects page (#32306).
Go MAEDA [Sun, 27 Oct 2019 00:06:06 +0000 (00:06 +0000)]
Add a link to projects administration page on projects page (#32306).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18873 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/unit/member_test.rb
Toshi MARUYAMA [Sat, 26 Oct 2019 13:47:09 +0000 (13:47 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/unit/member_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18872 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in test/unit/project_query_test.rb
Toshi MARUYAMA [Sat, 26 Oct 2019 13:46:58 +0000 (13:46 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in test/unit/project_query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18871 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelper#progress_bar
Toshi MARUYAMA [Sat, 26 Oct 2019 12:54:22 +0000 (12:54 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelper#progress_bar

git-svn-id: http://svn.redmine.org/redmine/trunk@18870 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocleanup: rubocop: fix Layout/AlignArguments in ApplicationHelper#toggle_checkboxes_link
Toshi MARUYAMA [Sat, 26 Oct 2019 12:54:11 +0000 (12:54 +0000)]
cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelper#toggle_checkboxes_link

git-svn-id: http://svn.redmine.org/redmine/trunk@18869 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: revert r18854
Toshi MARUYAMA [Sat, 26 Oct 2019 12:54:00 +0000 (12:54 +0000)]
code cleanup: rubocop: revert r18854

git-svn-id: http://svn.redmine.org/redmine/trunk@18868 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: revert r18852
Toshi MARUYAMA [Sat, 26 Oct 2019 12:53:48 +0000 (12:53 +0000)]
rubocop: revert r18852

git-svn-id: http://svn.redmine.org/redmine/trunk@18867 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDon't paginate the board view for now (#29482).
Jean-Philippe Lang [Sat, 26 Oct 2019 07:09:52 +0000 (07:09 +0000)]
Don't paginate the board view for now (#29482).

Subprojects may appear as root projects if their parents are on a previous page.

git-svn-id: http://svn.redmine.org/redmine/trunk@18866 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDefault sorting on projects by id is not relevant (#29482).
Jean-Philippe Lang [Sat, 26 Oct 2019 07:07:17 +0000 (07:07 +0000)]
Default sorting on projects by id is not relevant (#29482).

git-svn-id: http://svn.redmine.org/redmine/trunk@18865 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoItalian translation update (#32326).
Go MAEDA [Sat, 26 Oct 2019 06:48:35 +0000 (06:48 +0000)]
Italian translation update (#32326).

Patch by pasquale [:dedalus].

git-svn-id: http://svn.redmine.org/redmine/trunk@18864 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoStyling .info selector is not specific enough.
Jean-Philippe Lang [Sat, 26 Oct 2019 06:31:39 +0000 (06:31 +0000)]
Styling .info selector is not specific enough.

git-svn-id: http://svn.redmine.org/redmine/trunk@18863 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoSpecific action for updating role permissions.
Jean-Philippe Lang [Fri, 25 Oct 2019 16:31:57 +0000 (16:31 +0000)]
Specific action for updating role permissions.

git-svn-id: http://svn.redmine.org/redmine/trunk@18862 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd roles filter on permissions report (#32343).
Jean-Philippe Lang [Fri, 25 Oct 2019 15:53:27 +0000 (15:53 +0000)]
Add roles filter on permissions report (#32343).

git-svn-id: http://svn.redmine.org/redmine/trunk@18861 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCzech translation update (#32340).
Go MAEDA [Thu, 24 Oct 2019 23:57:29 +0000 (23:57 +0000)]
Czech translation update (#32340).

Patch by Pavel Rosický.

git-svn-id: http://svn.redmine.org/redmine/trunk@18860 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDisable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprocket...
Go MAEDA [Thu, 24 Oct 2019 02:15:09 +0000 (02:15 +0000)]
Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0 (#32223).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18859 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: generate .rubocop_todo.yml with "--exclude-limit 20"
Toshi MARUYAMA [Wed, 23 Oct 2019 13:32:17 +0000 (13:32 +0000)]
rubocop: generate .rubocop_todo.yml with "--exclude-limit 20"

git-svn-id: http://svn.redmine.org/redmine/trunk@18858 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: set Layout/SpaceInsideHashLiteralBraces parameters used more than others
Toshi MARUYAMA [Wed, 23 Oct 2019 13:31:59 +0000 (13:31 +0000)]
rubocop: set Layout/SpaceInsideHashLiteralBraces parameters used more than others

git-svn-id: http://svn.redmine.org/redmine/trunk@18857 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArguments in test/unit/project_test.rb
Toshi MARUYAMA [Wed, 23 Oct 2019 13:27:22 +0000 (13:27 +0000)]
code cleanup: rubocop: fix Layout/AlignArguments in test/unit/project_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18856 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArguments in test/unit/query_test.rb
Toshi MARUYAMA [Wed, 23 Oct 2019 13:27:10 +0000 (13:27 +0000)]
code cleanup: rubocop: fix Layout/AlignArguments in test/unit/query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18855 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceBeforeBlockBraces in test/unit/query_test.rb
Toshi MARUYAMA [Wed, 23 Oct 2019 13:26:57 +0000 (13:26 +0000)]
code cleanup: rubocop: fix Layout/SpaceBeforeBlockBraces in test/unit/query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18854 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArguments in test/unit/time_entry_query_test.rb
Toshi MARUYAMA [Wed, 23 Oct 2019 13:26:46 +0000 (13:26 +0000)]
code cleanup: rubocop: fix Layout/AlignArguments in test/unit/time_entry_query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18853 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: set Layout/SpaceBeforeBlockBraces parameters used more than others
Toshi MARUYAMA [Wed, 23 Oct 2019 06:44:43 +0000 (06:44 +0000)]
rubocop: set Layout/SpaceBeforeBlockBraces parameters used more than others

git-svn-id: http://svn.redmine.org/redmine/trunk@18852 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: set Layout/SpaceInsideBlockBraces parameters used more than others
Toshi MARUYAMA [Wed, 23 Oct 2019 06:44:31 +0000 (06:44 +0000)]
rubocop: set Layout/SpaceInsideBlockBraces parameters used more than others

git-svn-id: http://svn.redmine.org/redmine/trunk@18851 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: move Layout/AlignArguments temporarily from .rubocop_todo.yml to .rubocop.yml
Toshi MARUYAMA [Wed, 23 Oct 2019 06:44:20 +0000 (06:44 +0000)]
rubocop: move Layout/AlignArguments temporarily from .rubocop_todo.yml to .rubocop.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18850 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc...
Toshi MARUYAMA [Wed, 23 Oct 2019 05:37:55 +0000 (05:37 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc in test/integration/lib/redmine/hook_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18849 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArguments in test/unit/repository_test.rb
Toshi MARUYAMA [Wed, 23 Oct 2019 05:37:44 +0000 (05:37 +0000)]
code cleanup: rubocop: fix Layout/AlignArguments in test/unit/repository_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18848 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArguments in test/unit/user_test.rb
Toshi MARUYAMA [Wed, 23 Oct 2019 05:37:34 +0000 (05:37 +0000)]
code cleanup: rubocop: fix Layout/AlignArguments in test/unit/user_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18847 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArguments in test/unit/version_test.rb
Toshi MARUYAMA [Wed, 23 Oct 2019 05:37:23 +0000 (05:37 +0000)]
code cleanup: rubocop: fix Layout/AlignArguments in test/unit/version_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18846 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: disable Bundler/OrderedGems
Toshi MARUYAMA [Wed, 23 Oct 2019 04:57:44 +0000 (04:57 +0000)]
rubocop: disable Bundler/OrderedGems

git-svn-id: http://svn.redmine.org/redmine/trunk@18845 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix comment typo in db/migrate/20150208105930_replace_move_issues_permission.rb
Toshi MARUYAMA [Wed, 23 Oct 2019 04:39:38 +0000 (04:39 +0000)]
fix comment typo in db/migrate/20150208105930_replace_move_issues_permission.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18844 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate locales (#32302, #29482, #31355).
Go MAEDA [Wed, 23 Oct 2019 01:27:06 +0000 (01:27 +0000)]
Update locales (#32302, #29482, #31355).

git-svn-id: http://svn.redmine.org/redmine/trunk@18843 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoOption to filter after my bookmarked projects (#32302, #29482, #31355).
Go MAEDA [Wed, 23 Oct 2019 01:20:07 +0000 (01:20 +0000)]
Option to filter after my bookmarked projects (#32302, #29482, #31355).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18842 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove trailing whitespaces from config/locales/en.yml
Go MAEDA [Wed, 23 Oct 2019 00:51:59 +0000 (00:51 +0000)]
Remove trailing whitespaces from config/locales/en.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18841 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove trailing whitespaces from test/fixtures/user_preferences.yml
Go MAEDA [Wed, 23 Oct 2019 00:50:51 +0000 (00:50 +0000)]
Remove trailing whitespaces from test/fixtures/user_preferences.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18840 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceBeforeComma in lib/redmine/export/pdf.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 16:06:34 +0000 (16:06 +0000)]
code cleanup: rubocop: fix Layout/SpaceBeforeComma in lib/redmine/export/pdf.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18839 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceBeforeComma in test/helpers/application_helper...
Toshi MARUYAMA [Tue, 22 Oct 2019 16:06:20 +0000 (16:06 +0000)]
code cleanup: rubocop: fix Layout/SpaceBeforeComma in test/helpers/application_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18838 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in lib/redmine/helpers...
Toshi MARUYAMA [Tue, 22 Oct 2019 15:55:11 +0000 (15:55 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in lib/redmine/helpers/gantt.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18837 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in lib/diff.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:54:59 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in lib/diff.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18836 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/wiki_page.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:54:48 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/wiki_page.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18835 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/time_entry.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:54:37 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/time_entry.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18834 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/query.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:54:24 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18833 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/project.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:54:12 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/project.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18832 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation in app/controllers/wiki_c...
Toshi MARUYAMA [Tue, 22 Oct 2019 15:54:00 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/controllers/wiki_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18831 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/models/role.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:53:48 +0000 (15:53 +0000)]
code layout clean up app/models/role.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18830 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/role.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:53:37 +0000 (15:53 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/role.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18829 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/NestedMethodDefinition in test/unit/lib/redmine/menu_...
Toshi MARUYAMA [Tue, 22 Oct 2019 15:35:38 +0000 (15:35 +0000)]
code cleanup: rubocop: fix Lint/NestedMethodDefinition in test/unit/lib/redmine/menu_manager/menu_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18828 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix random test failure of ProjectQueryTest (#29482)
Toshi MARUYAMA [Tue, 22 Oct 2019 15:35:27 +0000 (15:35 +0000)]
fix random test failure of ProjectQueryTest (#29482)

git-svn-id: http://svn.redmine.org/redmine/trunk@18827 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoSkip AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png when ImageMagick...
Go MAEDA [Tue, 22 Oct 2019 14:12:09 +0000 (14:12 +0000)]
Skip AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png when ImageMagick convert is not available (#32307, #22481).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18826 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesArou...
Toshi MARUYAMA [Tue, 22 Oct 2019 13:44:15 +0000 (13:44 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/timelog_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18825 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesArou...
Toshi MARUYAMA [Tue, 22 Oct 2019 13:44:04 +0000 (13:44 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/messages_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18824 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesArou...
Toshi MARUYAMA [Tue, 22 Oct 2019 13:43:52 +0000 (13:43 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/boards_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18823 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/applicatio...
Toshi MARUYAMA [Tue, 22 Oct 2019 13:43:40 +0000 (13:43 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/application_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18822 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/applicat...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:41:21 +0000 (12:41 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/application_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18821 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/scm/adapters...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:41:09 +0000 (12:41 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/scm/adapters/abstract_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18820 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builde...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:57 +0000 (12:40 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builders.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18819 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: add new detected files to Performance/RedundantBlockCall (#32308)
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:46 +0000 (12:40 +0000)]
rubocop: add new detected files to Performance/RedundantBlockCall (#32308)

git-svn-id: http://svn.redmine.org/redmine/trunk@18818 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "class << self" syntax for Redmine::Views::Builders#for (#32308)
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:33 +0000 (12:40 +0000)]
use "class << self" syntax for Redmine::Views::Builders#for (#32308)

git-svn-id: http://svn.redmine.org/redmine/trunk@18817 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "if block_given?" instead of "if block" in lib/redmine/views/builders.rb (#32308)
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:22 +0000 (12:40 +0000)]
use "if block_given?" instead of "if block" in lib/redmine/views/builders.rb (#32308)

git-svn-id: http://svn.redmine.org/redmine/trunk@18816 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "if block_given?" instead of "if block" in lib/redmine/views/builders/structure...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:11 +0000 (12:40 +0000)]
use "if block_given?" instead of "if block" in lib/redmine/views/builders/structure.rb (#32308)

git-svn-id: http://svn.redmine.org/redmine/trunk@18815 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in test/functional/reposito...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:16:56 +0000 (12:16 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in test/functional/repositories_git_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18814 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builde...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:10:14 +0000 (12:10 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builders/structure.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18813 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:10:03 +0000 (12:10 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine/views/builders/json_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18812 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:09:52 +0000 (12:09 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine/views/builders/xml_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18811 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLa...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:41:21 +0000 (11:41 +0000)]
code cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLayout in test/unit/lib/redmine/wiki_formatting/markdown_formatter_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18810 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/helpers/application_helper_test.rb from Layout/CaseIndentation...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:41:10 +0000 (11:41 +0000)]
rubocop: remove test/helpers/application_helper_test.rb from Layout/CaseIndentation and Layout/IndentHeredoc fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18809 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:58 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_syntax_highlight

git-svn-id: http://svn.redmine.org/redmine/trunk@18808 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:47 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_non_closing_pre_blocks_should_be_closed

git-svn-id: http://svn.redmine.org/redmine/trunk@18807 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:36 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_pre_content_should_not_parse_wiki_and_redmine_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18806 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:23 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_pre_tags

git-svn-id: http://svn.redmine.org/redmine/trunk@18805 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:12 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_syntax_highlight_ampersand_in_textile

git-svn-id: http://svn.redmine.org/redmine/trunk@18804 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:00 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_inline_images_inside_tags

git-svn-id: http://svn.redmine.org/redmine/trunk@18803 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:39:49 +0000 (11:39 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_table_of_content

git-svn-id: http://svn.redmine.org/redmine/trunk@18802 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:39:38 +0000 (11:39 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_table_of_content_should_generate_unique_anchors

git-svn-id: http://svn.redmine.org/redmine/trunk@18801 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:39:26 +0000 (11:39 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_table_of_content_should_contain_included_page_headings

git-svn-id: http://svn.redmine.org/redmine/trunk@18800 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:39:14 +0000 (11:39 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_section_edit_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18799 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/MultipleComparison in lib/redmine/scm/adapters/git_a...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:31:17 +0000 (11:31 +0000)]
code cleanup: rubocop: fix Style/MultipleComparison in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18798 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/UnneededSort in test/unit/repository_git_test.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:31:05 +0000 (11:31 +0000)]
code cleanup: rubocop: fix Style/UnneededSort in test/unit/repository_git_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18797 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/UnneededInterpolation in lib/redmine/scm/adapters...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:54 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Style/UnneededInterpolation in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18796 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in app/models/setting.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:41 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18795 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/setting.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:29 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18794 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArray in lib/redmine/default_data/loader.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:17 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Layout/AlignArray in lib/redmine/default_data/loader.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18793 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArray in app/models/setting.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:05 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Layout/AlignArray in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18792 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemoves duplicated 'group_by' id (#29482).
Go MAEDA [Tue, 22 Oct 2019 05:04:37 +0000 (05:04 +0000)]
Removes duplicated 'group_by' id (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18791 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix display type in query form view (#29482).
Go MAEDA [Tue, 22 Oct 2019 05:03:02 +0000 (05:03 +0000)]
Fix display type in query form view (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18790 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTraditional Chinese translation update (#32316).
Go MAEDA [Tue, 22 Oct 2019 04:11:43 +0000 (04:11 +0000)]
Traditional Chinese translation update (#32316).

Patch by ChunChang Lo.

git-svn-id: http://svn.redmine.org/redmine/trunk@18789 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove code for unsupported versions of Rails from open_id_authentication (#32297).
Go MAEDA [Tue, 22 Oct 2019 01:34:21 +0000 (01:34 +0000)]
Remove code for unsupported versions of Rails from open_id_authentication (#32297).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18788 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix random test failure of ProjectQueryTest (#29482).
Go MAEDA [Mon, 21 Oct 2019 07:20:57 +0000 (07:20 +0000)]
Fix random test failure of ProjectQueryTest (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18787 e93f8b46-1217-0410-a6f0-8f06a7374b81