]>
source.dussan.org Git - gitea.git/log
wxiaoguang [Thu, 24 Aug 2023 10:39:09 +0000 (18:39 +0800)]
Backport line height fix (#26708)
Backport the `line-height: normal`, because #26520 was backported
Giteabot [Wed, 23 Aug 2023 12:53:44 +0000 (20:53 +0800)]
Prefer variables over subprocesses (#26690) (#26693)
Backport #26690 by @thomas-mc-work
… because it doesn't require a separate shell, spawning a process which
cost unnecessary resources and takes time.
Co-authored-by: Thomas McWork <thomas.mc.work@posteo.de>
Giteabot [Wed, 23 Aug 2023 01:57:01 +0000 (09:57 +0800)]
add mfa doc (#26654) (#26674)
Backport #26654 by @lunny
copy and modified from #14572
> Whilst debating enforcing MFA within our team, I realised there isn't
a lot of context to the side effects of enabling it. Most of us use Git
over HTTP and would need to add a token.
I plan to add another PR that adds a sentence to the UI about needing to
generate a token when enabling MFA if HTTP is to be used.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: silverwind <me@silverwind.io>
Giteabot [Mon, 21 Aug 2023 18:15:14 +0000 (02:15 +0800)]
update config docs url (#26640) (#26642)
Backport #26640 by @techknowlogick
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Giteabot [Mon, 21 Aug 2023 17:38:06 +0000 (01:38 +0800)]
Fix unable to display individual-level project (#26198) (#26636)
Backport #26198 by @CaiCandong
As title
Before:
![image](https://github.com/go-gitea/gitea/assets/
50507092 /
94afc3bf -5597-4151-a59b-
5632840ffa21 )
After:
![image](https://github.com/go-gitea/gitea/assets/
50507092 /
df81aa0b -98a6-477d-a270-
2e45b3dca0fc )
fix #26189
Co-authored-by: caicandong <50507092+CaiCandong@users.noreply.github.com>
Giteabot [Mon, 21 Aug 2023 16:51:30 +0000 (00:51 +0800)]
Use correct minio error (#26634) (#26639)
Backport #26634 by @delvh
Previously, `err` was defined above, checked for `err == nil` and used
nowhere else.
Hence, the result of `convertMinioErr` would always be `nil`.
This leads to a NPE further down the line.
That is not intentional, it should convert the error of the most recent
operation, not one of its predecessors.
Found through
https://discord.com/channels/
322538954119184384 /
322538954119184384 /
1143185780206993550 .
Co-authored-by: delvh <dev.lh@web.de>
a1012112796 [Mon, 21 Aug 2023 13:13:34 +0000 (21:13 +0800)]
fix reopen logic for agit flow pull request (#26399) (#26613)
Backport #26399
Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: Giteabot <teabot@gitea.io>
Giteabot [Mon, 21 Aug 2023 12:17:19 +0000 (20:17 +0800)]
Add `branch_filter` to hooks API endpoints (#26599) (#26632)
Backport #26599 by @yardenshoham
We now include the branch filler in the response.
- Closes #26591
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
Giteabot [Mon, 21 Aug 2023 06:19:43 +0000 (14:19 +0800)]
Ignore the trailing slashes when comparing oauth2 redirect_uri (#26597) (#26618)
Backport #26597 by @wxiaoguang
Fix #26526
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
John Olheiser [Mon, 21 Aug 2023 04:02:40 +0000 (23:02 -0500)]
Set errwriter for urfave/cli v1 (#26616)
Resolves #26615
Giteabot [Sun, 20 Aug 2023 19:25:55 +0000 (03:25 +0800)]
Update 1.20.3 changelog (#26609) (#26610)
Backport #26609 by @delvh
Co-authored-by: delvh <dev.lh@web.de>
Giteabot [Sun, 20 Aug 2023 15:29:16 +0000 (23:29 +0800)]
Use "input" event instead of "keyup" event for migration form (#26602) (#26605)
Backport #26602 by @wxiaoguang
Otherwise, "pasted" content won't update the UI.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Sun, 20 Aug 2023 08:11:57 +0000 (16:11 +0800)]
Do not use deprecated log config options by default (#26592) (#26600)
Backport #26592 by @wxiaoguang
Simplify the log config
* Remove unnecessary `ROUTER` config, it defaults to the `MODE`.
* `XORM` config was deprecated
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
CaiCandong [Sat, 19 Aug 2023 10:21:45 +0000 (18:21 +0800)]
Fix project filter bugs (#26490) (#26558)
Backport #26490
related: #26012
1. missing project filter on the issue page.
https://github.com/go-gitea/gitea/blob/
1e76a824bcd71acd59cdfb2c4547806bc34b3d86 /modules/indexer/issues/dboptions.go#L11-L15
2. incorrect SQL condition: some issue does not belong to a project but
exists on the project_issue table.
https://github.com/go-gitea/gitea/blob/
f5dbac9d36f1678b928bee04e85fbd045c725698 /models/issues/issue_search.go#L233
![before](https://github.com/go-gitea/gitea/assets/
50507092 /
1dcde39e -3e2f-4151-b2c6-
4d67bf493c2f )
![after](https://github.com/go-gitea/gitea/assets/
50507092 /
badfb81f -056d-4a2f-9838-
1cba9c15768d )
Giteabot [Fri, 18 Aug 2023 09:54:52 +0000 (17:54 +0800)]
Add minimum polyfill to support "relative-time-element" in PaleMoon (#26575) (#26578)
Backport #26575 by @wxiaoguang
Close #26525
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Thu, 17 Aug 2023 13:13:00 +0000 (21:13 +0800)]
Fix "issueReposQueryPattern does not match query" (#26556) (#26564)
Backport #26556 by @wolfogre
Fix
`https://github.com/go-gitea/gitea/pull/26545#discussion_r1295734340`
Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Thu, 17 Aug 2023 05:12:14 +0000 (13:12 +0800)]
Sync repo's IsEmpty status correctly (#26517) (#26560)
Backport #26517 by @wxiaoguang
Close #26509
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Wed, 16 Aug 2023 06:28:39 +0000 (14:28 +0800)]
Fix typo of RunerOwnerID (#26508) (#26528)
Backport #26508 by @yp05327
Co-authored-by: yp05327 <576951401@qq.com>
KN4CK3R [Wed, 16 Aug 2023 06:01:20 +0000 (08:01 +0200)]
Fix NuGet search endpoints (#25613) (#26499)
Backport of #25613
Fixes #25564
Fixes #23191
- Api v2 search endpoint should return only the latest version matching
the query
- Api v3 search endpoint should return `take` packages not package
versions
Giteabot [Tue, 15 Aug 2023 23:31:29 +0000 (07:31 +0800)]
Fix dark theme highlight for "NameNamespace" (#26519) (#26527)
Backport #26519 by @wxiaoguang
The color is taken from "Name"
Before:
![image](https://github.com/go-gitea/gitea/assets/
2114189 /
b94d7521 -770c-4e14-a63b-
f30c44fe883f )
After:
![image](https://github.com/go-gitea/gitea/assets/
2114189 /
d99c1f13 -a0c0-4dc8-82ab-
bfdd451e46ec )
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Tue, 15 Aug 2023 13:34:08 +0000 (21:34 +0800)]
Use `hidden` over `clip` for text truncation (#26520) (#26522)
Backport #26520 by @silverwind
Avoid browser bugs:
- Firefox not cutting off -
https://github.com/go-gitea/gitea/pull/26354#issuecomment-
1678456052
- Safari not showing ellipsis -
https://github.com/go-gitea/gitea/pull/26354#issuecomment-
1678812801
Co-authored-by: silverwind <me@silverwind.io>
Giteabot [Tue, 15 Aug 2023 12:10:50 +0000 (20:10 +0800)]
Set "type=button" for editor's toolbar buttons (#26510) (#26518)
Backport #26510 by @wxiaoguang
The editor usually is in a form, so the buttons should have
"type=button", avoid conflicting with the form's submit.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Tue, 15 Aug 2023 03:15:26 +0000 (11:15 +0800)]
Detect ogg mime-type as audio or video (#26494) (#26505)
Backport #26494 by @wxiaoguang
"ogg" is just a "container" format for audio and video.
Golang's `DetectContentType` only reports "application/ogg" for
potential ogg files.
Actually it could do more "guess" to see whether it is a audio file or a
video file.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Mon, 14 Aug 2023 16:56:15 +0000 (00:56 +0800)]
Use `object-fit: contain` for oauth2 custom icons (#26493) (#26498)
Backport #26493 by @wxiaoguang
It works for various sizes.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Mon, 14 Aug 2023 15:55:18 +0000 (23:55 +0800)]
Move dropzone progress bar to bottom to show filename when uploading (#26492) (#26497)
Backport #26492 by @wxiaoguang
1. Make the "filename" visible
2. Avoiding UI flicker when the uploading is completing
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Mon, 14 Aug 2023 02:38:18 +0000 (10:38 +0800)]
Fix storage path logic especially for relative paths (#26441) (#26481)
Backport #26441 by @lunny
This PR rewrites the function `getStorage` and make it more clear.
Include tests from #26435, thanks @earl-warren
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Giteabot [Mon, 14 Aug 2023 00:55:17 +0000 (08:55 +0800)]
Add ThreadID parameter for Telegram webhooks (#25996) (#26480)
Backport #25996
Telegram has recently implemented threads (channels) for group chats.
Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com>
Co-authored-by: neveraskedtoexist <matikot415@gmail.com>
Giteabot [Sun, 13 Aug 2023 08:00:28 +0000 (16:00 +0800)]
Close stdout correctly for "git blame" (#26470) (#26473)
Backport #26470 by @wxiaoguang
Close stdout correctly for "git blame", otherwise the failed "git blame"
would cause the request hanging forever.
And "os.Stderr" should never (seldom) be used as git command's stderr
(there seems some similar problems in code, they could be fixed later).
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Sat, 12 Aug 2023 16:19:33 +0000 (00:19 +0800)]
Remove last newline from config file (#26468) (#26471)
Backport #26468 by @wxiaoguang
When users put the secrets into a file (GITEA__sec__KEY__FILE), the
newline sometimes is different to avoid (eg: echo/vim/...)
So the last newline could be removed when reading, it makes the users
easier to maintain the secret files.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Sat, 12 Aug 2023 09:00:51 +0000 (17:00 +0800)]
Check first if minio bucket exists before trying to create it (#26420) (#26465)
Backport #26420 by @lunny
For some reason, the permission of the client_id and secret may cannot
create bucket, so now we will check whether bucket does exist first and
then try to create a bucket if it doesn't exist.
Try to fix #25984
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
wxiaoguang [Sat, 12 Aug 2023 08:30:29 +0000 (16:30 +0800)]
Avoiding accessing undefined tributeValues #26461 (#26462)
Backport #26461
Giteabot [Fri, 11 Aug 2023 10:38:39 +0000 (18:38 +0800)]
Fix incorrect color of selected assignees when create issue (#26324) (#26372)
Backport #26324 by @yp05327
Before:
![image](https://github.com/go-gitea/gitea/assets/
18380374 /
75d610b2 -3823-4366-be85-
c77c9106feff )
After:
![image](https://github.com/go-gitea/gitea/assets/
18380374 /
15afc6ac -f5ad-4e24-8983-
fea8ace5921f )
Co-authored-by: yp05327 <576951401@qq.com>
crystal [Fri, 11 Aug 2023 08:58:50 +0000 (02:58 -0600)]
Improve profile readme rendering (#25988) (#26453)
manual backport of #25988 to v1.20
- Tell the renderer to use the `document` mode, so it's consistent with
other renderers.
- Use the same padding as `.file-view.markup`, so it's consistent with
other containers that contain markup rendering.
- Resolves https://codeberg.org/forgejo/forgejo/issues/833
Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com>
Giteabot [Fri, 11 Aug 2023 06:17:27 +0000 (14:17 +0800)]
Update upgrade documentation to add a check for deprecated configurations (#26451) (#26452)
Backport #26451 by @lunny
fix
https://github.com/go-gitea/gitea/issues/25995#issuecomment-
1674096710
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Lunny Xiao [Fri, 11 Aug 2023 05:27:23 +0000 (13:27 +0800)]
Add transaction when creating pull request created dirty data (#26259) (#26437)
Backport #26259
This PR will introduce a transaction on creating pull request so that if
some step failed, it will rollback totally. And there will be no dirty
pull request exist.
Co-authored-by: Giteabot <teabot@gitea.io>
Giteabot [Thu, 10 Aug 2023 23:16:12 +0000 (07:16 +0800)]
Call git.InitSimple for runRepoSyncReleases (#26396) (#26450)
Backport #26396 by @wxiaoguang
Fix #26394
Otherwise, the git module is not initialized and it doesn't respect the
"timeout" config in app.ini
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Thu, 10 Aug 2023 15:40:17 +0000 (23:40 +0800)]
Add changelog for 1.20.3 (#26373) (#26375)
Backport #26373 by @delvh
Co-authored-by: delvh <dev.lh@web.de>
Giteabot [Thu, 10 Aug 2023 14:11:22 +0000 (22:11 +0800)]
minio: add missing region on client initialization (#26412) (#26438)
Backport #26412 by @nekrondev
The MinIO client isn't redirecting to the correct AWS endpoint if a
non-default data center is used.
In my use case I created an AWS bucket at `eu-central-1` region. Because
of the missing region initialization of the client the default
`us-east-1` API endpoint is used returning a `301 Moved Permanently`
response that's not handled properly by MinIO client. This in return
aborts using S3 storage on AWS as the `BucketExists()` call will fail
with the http moved error.
MinIO client trace shows the issue:
```text
---------START-HTTP---------
HEAD / HTTP/1.1
Host: xxxxxxxxxxx-prod-gitea-data.s3.dualstack.us-east-1.amazonaws.com
User-Agent: MinIO (windows; amd64) minio-go/v7.0.61
Authorization: AWS4-HMAC-SHA256 Credential=**REDACTED**/
20230809 /accesspoint.eu-central-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=**REDACTED**
X-Amz-Content-Sha256:
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
X-Amz-Date: 20230809T141143Z
HTTP/1.1 301 Moved Permanently
Connection: close
Content-Type: application/xml
Date: Wed, 09 Aug 2023 14:11:43 GMT
Server: AmazonS3
X-Amz-Bucket-Region: eu-central-1
X-Amz-Id-2: UK7wfeYi0HcTcytNvQ3wTAZ5ZP1mOSMnvRZ9Fz4xXzeNsS47NB/KfFx2unFxo3L7XckHpMNPPVo=
X-Amz-Request-Id: S1V2MJV8SZ11GEVN
---------END-HTTP---------
```
Co-authored-by: nekrondev <heiko@noordsee.de>
Co-authored-by: Heiko Besemann <heiko.besemann@qbeyond.de>
Giteabot [Thu, 10 Aug 2023 11:26:22 +0000 (19:26 +0800)]
Fix wrong middleware sequence (#26428) (#26436)
Backport #26428 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
wxiaoguang [Thu, 10 Aug 2023 09:04:48 +0000 (17:04 +0800)]
Fix admin queue page title and fix CI failures (#26409) (#26421)
Backport #26409
* Fix #26408
* Bypass the data race issue in "ssh" package
Giteabot [Wed, 9 Aug 2023 09:00:34 +0000 (17:00 +0800)]
Add pull request review request webhook event (#26401) (#26407)
Backport #26401 by @yardenshoham
Add webhook events for pull request review requests
- Fixes #26371
- Added support for the "Pull request review requested" and "Pull
request review request removed" webhook events.
- Updated the `getPullRequestPayloadInfo` function in `general.go` to
handle these new webhook events.
# Before
![image](https://github.com/go-gitea/gitea/assets/
20454870 /
bd942971 -fb1d-40f3-8961-
46638e3588fa )
# After
![image](https://github.com/go-gitea/gitea/assets/
20454870 /
216e9c7d -0a4d-49f9-8492-
2d14c88bbf4e )
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
Giteabot [Wed, 9 Aug 2023 07:31:44 +0000 (15:31 +0800)]
Introduce ctx.PathParamRaw to avoid incorrect unescaping (#26392) (#26405)
Backport #26392 by @wxiaoguang
Fix #26389
And complete an old TODO: `ctx.Params does un-escaping,..., which is
incorrect.`
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Wed, 9 Aug 2023 00:57:47 +0000 (08:57 +0800)]
Fix incorrect sort link with `.profile` repository (#26374) (#26379)
Backport #26374 by @CaiCandong
fix #26360
Before:
![before](https://github.com/go-gitea/gitea/assets/
50507092 /
5606afe1 -9aa2-455e-8d6f-
123ff1ac7011 )
After:
![After](https://github.com/go-gitea/gitea/assets/
50507092 /
14ff544a -e614-4d41-8615-
5244b4ba56eb )
Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com>
Giteabot [Tue, 8 Aug 2023 02:14:25 +0000 (10:14 +0800)]
Fix text truncate (#26354) (#26384)
Backport #26354 by @Maks1mS
Fixes: https://github.com/go-gitea/gitea/issues/25597
Before:
![image](https://github.com/go-gitea/gitea/assets/
36362599 /
c8c27bcb -469f-4def-8521-
d9e054c16ecb )
After:
![image](https://github.com/go-gitea/gitea/assets/
36362599 /
2405b6e8 -fc5c-4b13-b66b-
007bc11edbc4 )
Co-authored-by: Maxim Slipenko <no-reply@maxim.slipenko.com>
Giteabot [Mon, 7 Aug 2023 10:55:25 +0000 (18:55 +0800)]
Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect IssueIndex (#26279) (#26368)
Backport #26279 by @wxiaoguang
Close #26277
Fix #26285
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
delvh [Sun, 6 Aug 2023 21:15:01 +0000 (23:15 +0200)]
Display human-readable text instead of cryptic filemodes (#26352) (#26358)
Backport #26352
Now, you don't need to be a git expert anymore to know what these numbers mean.
## Before
![grafik](https://github.com/go-gitea/gitea/assets/
51889757 /
9a964bf6 -10fd-40a6-aeb2-
ac8f437f8c32 )
## After
![grafik](https://github.com/go-gitea/gitea/assets/
51889757 /
84573cb9 -55b6-4dde-9866-
95f71b657554 )
or when the mode actually changed:
![grafik](https://github.com/go-gitea/gitea/assets/
51889757 /
0f327538 -ebdc-40e7-8c99-
f9e21b67f638 )
Giteabot [Sun, 6 Aug 2023 19:57:21 +0000 (03:57 +0800)]
[docs] Add missing backtick in quickstart.zh-cn.md (#26349) (#26357)
Brian Lachniet [Sun, 6 Aug 2023 16:02:43 +0000 (12:02 -0400)]
[docs] Fix Gmail configuration (#26356)
wxiaoguang [Sun, 6 Aug 2023 12:11:39 +0000 (20:11 +0800)]
Fix API leaking Usermail if not logged in (#25097) (#26350)
Backport #25097
The API should only return the real Mail of a User, if the caller is
logged in. The check do to this don't work. This PR fixes this. This not
really a security issue, but can lead to Spam.
Co-authored-by: JakobDev <jakobdev@gmx.de>
Co-authored-by: silverwind <me@silverwind.io>
Giteabot [Sat, 5 Aug 2023 16:08:17 +0000 (00:08 +0800)]
Hide `last indexed SHA` when a repo could not be indexed yet (#26340) (#26345)
Backport #26340 by @CaiCandong
Now, for a new repo without any commit, the Last indexed SHA field looks
like this:
Before:
![image](https://github.com/go-gitea/gitea/assets/
50507092 /
cecc6e24 -3366-4093-ae07-
c361ea34b373 )
After:
![image](https://github.com/go-gitea/gitea/assets/
50507092 /
9b6ba703 -b0d5-4648-ad6b-
9a2341dd60f9 )
fix #26336
Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com>
Giteabot [Sat, 5 Aug 2023 15:42:45 +0000 (23:42 +0800)]
Remove backslashed newlines on markdown (#26344) (#26348)
Backport #26344 by @lunny
Fix https://gitea.com/gitea/gitea-docusaurus/issues/56
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
wxiaoguang [Sat, 5 Aug 2023 15:37:04 +0000 (23:37 +0800)]
Fix incorrect CLI exit code and duplicate error message (#26346) (#26347)
Backport #26346
Follow the CLI refactoring, and add tests.
Giteabot [Sat, 5 Aug 2023 10:15:49 +0000 (18:15 +0800)]
Fix log typo in task.go (#26337) (#26343)
Backport #26337 by @cassiozareck
Signed-off-by: cassiozareck <cassiomilczareck@gmail.com>
Giteabot [Sat, 5 Aug 2023 09:41:30 +0000 (17:41 +0800)]
Prevent newline errors with Debian packages (#26332) (#26342)
Backport #26332 by @KN4CK3R
Fixes #26313
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Giteabot [Sat, 5 Aug 2023 07:35:08 +0000 (15:35 +0800)]
Fix bug with sqlite load read (#26305) (#26339)
Backport #26305 by @lunny
Possible fix #26280
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Giteabot [Fri, 4 Aug 2023 13:44:25 +0000 (21:44 +0800)]
Make git batch operations use parent context timeout instead of default timeout (#26325) (#26330)
Backport #26325 by @wxiaoguang
Fix #26064
Some git commands should use parent context, otherwise it would exit too
early (by the default timeout, 10m), and the "cmd.Wait" waits till the
pipes are closed.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Fri, 4 Aug 2023 06:24:13 +0000 (14:24 +0800)]
Fix the wrong derive path (#26271) (#26318)
Backport #26271 by @lunny
This PR will fix #26264, caused by #23911.
The package configuration derive is totally wrong when storage type is
local in that PR.
This PR fixed the inherit logic when storage type is local with some
unit tests.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Fri, 4 Aug 2023 05:00:49 +0000 (13:00 +0800)]
Fix the topic validation rule and suport dots (#26286) (#26303)
Backport #26286 by @wxiaoguang
1. Allow leading and trailing spaces by user input, these spaces have
already been trimmed at backend
2. Allow using dots in the topic
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Fri, 4 Aug 2023 03:27:45 +0000 (11:27 +0800)]
Support getting changed files when commit ID is `EmptySHA` (#26290) (#26316)
Backport #26290 by @Zettat123
Fixes #26270.
Co-Author: @wxiaoguang
Thanks @lunny for providing this solution
As
https://github.com/go-gitea/gitea/issues/26270#issuecomment-
1661695151
said, at present we cannot get the names of changed files correctly when
the `OldCommitID` is `EmptySHA`. In this PR, the `GetCommitFilesChanged`
method is added and will be used to get the changed files by commit ID.
References:
- https://stackoverflow.com/a/424142
Co-authored-by: Zettat123 <zettat123@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Lunny Xiao [Thu, 3 Aug 2023 10:05:07 +0000 (18:05 +0800)]
Upgrade x/net to 0.13.0 (#26301)
backport #26297
Giteabot [Tue, 1 Aug 2023 23:08:28 +0000 (07:08 +0800)]
Clarify the logger's MODE config option (#26267) (#26281)
Backport #26267 by @wxiaoguang
1. Fix the wrong document (add the missing `MODE=`)
2. Add a more friendly log message to tell users to add `MODE=` in their
config
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Tue, 1 Aug 2023 16:40:35 +0000 (00:40 +0800)]
Fix due date rendering the wrong date in issue (#26268) (#26274)
Backport #26268 by @yardenshoham
Closes #26263
We have to pass the date without the time.
# Before
![image](https://github.com/go-gitea/gitea/assets/
20454870 /
6b6cb43d -2b1c-4679-951d-
20f48c94bfdd )
# After
![image](https://github.com/go-gitea/gitea/assets/
20454870 /
50441baf -2c52-452b-bb0d-
6034a407abde )
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
Giteabot [Tue, 1 Aug 2023 15:32:23 +0000 (23:32 +0800)]
Update Arch linux URL from community to extra (#26273) (#26276)
Co-authored-by: minijaws <minijaws@gmail.com>
Giteabot [Mon, 31 Jul 2023 10:09:13 +0000 (18:09 +0800)]
Use shared template for webhook icons (#26242) (#26246)
Backport #26242 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/26241
Co-authored-by: silverwind <me@silverwind.io>
Giteabot [Mon, 31 Jul 2023 08:56:46 +0000 (16:56 +0800)]
Fix pull request check list is limited (#26179) (#26245)
Backport #26179 by @CaiCandong
In the original implementation, we can only get the first 30 records of
the commit status (the default paging size), if the commit status is
more than 30, it will lead to the bug #25990. I made the following two
changes.
- On the page, use the ` db.ListOptions{ListAll: true}` parameter
instead of `db.ListOptions{}`
- The `GetLatestCommitStatus` function makes a determination as to
whether or not a pager is being used.
fixed #25990
Co-authored-by: caicandong <50507092+CaiCandong@users.noreply.github.com>
Giteabot [Mon, 31 Jul 2023 08:02:25 +0000 (16:02 +0800)]
Don't autosize textarea in diff view (#26233) (#26244)
Backport #26233 by @silverwind
Resizing the comment editor can be a very expensive operation because it
triggers page reflows, which on large PRs can take upwards of seconds to
complete. Disable this mechanism on the diff page only where we know
that the page can get large.
Fixes https://github.com/go-gitea/gitea/issues/26201 for the textarea
editor.
I don't think this can be fixed for EasyMDE because as far as I can
tell, it exposes no option to disable this resizing.
Co-authored-by: silverwind <me@silverwind.io>
silverwind [Sun, 30 Jul 2023 22:12:01 +0000 (00:12 +0200)]
Fix attachment clipboard copy on insecure origin (#26224) (#26231)
Backport https://github.com/go-gitea/gitea/pull/26224.
Giteabot [Sat, 29 Jul 2023 21:54:35 +0000 (05:54 +0800)]
Fixed incorrect locale references (#26218) (#26222)
Backport #26218 by @kerwin612
Fixed two incorrect headers for setting the page navigation bar:
* User settings page, should not use the title "`org.settings`"
* Repo settings page, should not use the title "`org.settings`"
Co-authored-by: Kerwin Bryant <kerwin612@qq.com>
Giteabot [Sat, 29 Jul 2023 18:50:58 +0000 (02:50 +0800)]
Fix access check for org-level project (#26182) (#26223)
Backport #26182 by @Zettat123
Fix #25934
Add `ignoreGlobal` parameter to `reqUnitAccess` and only check global
disabled units when `ignoreGlobal` is true. So the org-level projects
and user-level projects won't be affected by global disabled
`repo.projects` unit.
Co-authored-by: Zettat123 <zettat123@gmail.com>
Giteabot [Sat, 29 Jul 2023 16:54:51 +0000 (00:54 +0800)]
Fix commit compare style (#26209) (#26226)
Backport #26209 by @puni9869
as title
Fixes : #25825
Before
<img width="1334" alt="image"
src="https://github.com/go-gitea/gitea/assets/
80308335 /
c54a41b0 -39bd-4094-a956-
081a8f4128f2 ">
After change
<img width="1340" alt="image"
src="https://github.com/go-gitea/gitea/assets/
80308335 /
c112d235 -6bbe-4bcb-9529-
78da3ab0fa14 ">
Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>
Giteabot [Sat, 29 Jul 2023 14:47:46 +0000 (22:47 +0800)]
Warn instead of reporting an error when a webhook cannot be found (#26039) (#26211)
Backport #26039 by @puni9869
Attemp fix: #25744
Fixing the log level when we delete any repo then we get error hook not
found by id. That should be warn level to reduce the noise in the logs.
Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>
Giteabot [Sat, 29 Jul 2023 11:23:54 +0000 (19:23 +0800)]
Add changelog for 1.20.2 (#26208) (#26217)
Backport #26208 by @delvh
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Sat, 29 Jul 2023 06:42:40 +0000 (14:42 +0800)]
Fix allowed user types setting problem (#26200) (#26206)
Backport #26200 by @lunny
Fix #25951
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Giteabot [Fri, 28 Jul 2023 09:08:11 +0000 (17:08 +0800)]
Prevent primary key update on migration (#26192) (#26199)
Backport #26192 by @KN4CK3R
Fixes #25918
The migration fails on MSSQL because xorm tries to update the primary
key column. xorm prevents this if the column is marked as auto
increment:
https://gitea.com/xorm/xorm/src/commit/
c622cdaf893fbfe3f40a6b79f6bc17ee10f53865 /internal/statements/update.go#L38-L40
I think it would be better if xorm would check for primary key columns
here because updating such columns is bad practice. It looks like if
that auto increment check should do the same.
fyi @lunny
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Giteabot [Thu, 27 Jul 2023 11:24:07 +0000 (19:24 +0800)]
Calculate MAX_WORKERS default value by CPU number (#26177) (#26183)
Lunny Xiao [Thu, 27 Jul 2023 02:36:54 +0000 (10:36 +0800)]
Fix bug when pushing to a pull request which enabled dismiss approval automatically (#25882) (#26158)
Fix #25858
Backport #25882
The option `dissmiss stale approvals` was listed on protected branch but
never implemented. This PR fixes that.
<img width="1006" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/
60bfa968 -4db7-4c24-b8be-
2e5978f91bb9 ">
<img width="1021" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/
8dabc14d -2dfe-40c2-94ed-
24fcbf6e0e8f ">
Giteabot [Wed, 26 Jul 2023 21:41:40 +0000 (05:41 +0800)]
Fix handling of plenty Nuget package versions (#26075) (#26173)
Backport #26075 by @KN4CK3R
Fixes #25953
- Do not load full version information (v3)
- Add pagination support (v2)
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Giteabot [Wed, 26 Jul 2023 19:46:13 +0000 (03:46 +0800)]
Fix typos in Contributing.md (#26170) (#26172)
Co-authored-by: Niko Hoffrén <niko.hoffren@gmail.com>
Giteabot [Wed, 26 Jul 2023 15:55:27 +0000 (23:55 +0800)]
Update email-setup.en-us.md (#26068) (#26166)
Backport #26068 by @felixvictor
The setting `MAILER_TYPE` is deprecated.
According to the config cheat sheet, it should be `PROTOCOL`.
Co-authored-by: Felix Victor <felix.victor.na@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Giteabot [Wed, 26 Jul 2023 11:53:15 +0000 (19:53 +0800)]
Fix bugs in LFS meta garbage collection (#26122) (#26157)
Backport #26122 by @Zettat123
This PR
- Fix #26093. Replace `time.Time` with `timeutil.TimeStamp`
- Fix #26135. Add missing `xorm:"extends"` to `CountLFSMetaObject` for
LFS meta object query
- Add a unit test for LFS meta object garbage collection
Co-authored-by: Zettat123 <zettat123@gmail.com>
Giteabot [Wed, 26 Jul 2023 10:34:55 +0000 (18:34 +0800)]
Fix UI regression of asciinema player (#26159) (#26162)
Backport #26159 by @wolfogre
It was caused by updating `asciinema-player`, the upstream changed the
CSS class prefix:
`https://github.com/asciinema/asciinema-player/commit/
40505e479e8ba6833f178a3b7e85503c72491614 `
<details>
<summary>Before:</summary>
<img width="1320" alt="image"
src="https://github.com/go-gitea/gitea/assets/
9418365 /
b91a2cf5 -c1da-43d6-bac2-
bc278728b11e ">
</details>
<details>
<summary>After:</summary>
<img width="1311" alt="image"
src="https://github.com/go-gitea/gitea/assets/
9418365 /
c9872d25 -e0bb-43d4-8b1e-
d87c6b03c0a2 ">
</details>
Co-authored-by: Jason Song <i@wolfogre.com>
Lunny Xiao [Wed, 26 Jul 2023 09:22:39 +0000 (17:22 +0800)]
Display deprecated warning in admin panel pages as well as in the log file (#26094) (#26154)
backport #26094
Temporily resolve #25915
Related #25994
This PR includes #26007 's changes but have a UI to prompt administrator
about the deprecated settings as well as the log or console warning.
Then users will have enough time to notice the problem and don't have
surprise like before.
<img width="1293" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/
c33355f0 -1ea7-4fb3-ad43-
cd23cd15391d ">
Lunny Xiao [Wed, 26 Jul 2023 07:40:23 +0000 (15:40 +0800)]
Update xorm version (#26128) (#26150)
backport #26128 to fix some serious bug.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Giteabot [Wed, 26 Jul 2023 05:32:41 +0000 (01:32 -0400)]
Remove "misc" scope check from public API endpoints (#26134) (#26149)
Backport #26134 by @wxiaoguang
Fix #26035
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Wed, 26 Jul 2023 04:58:48 +0000 (00:58 -0400)]
Fix LFS object list style (#26133) (#26147)
Backport #26133 by @wxiaoguang
Close #26104 . Only a quick fix, the UI is not perfect.
Before:
<details>
![image](https://github.com/go-gitea/gitea/assets/
2114189 /
7b10d42d -8317-4d99-80f9-
b6c5fe05c17e )
![image](https://github.com/go-gitea/gitea/assets/
2114189 /
b43f1242 -61a0-45e3-98b7-
aa74b29f3813 )
</details>
After:
<details>
![image](https://github.com/go-gitea/gitea/assets/
2114189 /
a8d27f70 -781d-4702-866f-
a56df6dd6c0a )
![image](https://github.com/go-gitea/gitea/assets/
2114189 /
379274e7 -c67b-4c11-9cee-
28a298b4ff5a )
</details>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
John Olheiser [Wed, 26 Jul 2023 02:00:14 +0000 (21:00 -0500)]
Docusaurus-ify 1.20 (#26052)
See https://github.com/go-gitea/gitea/pull/26051
---------
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: JonRB <4564448+eeyrjmr@users.noreply.github.com>
Giteabot [Wed, 26 Jul 2023 01:30:50 +0000 (21:30 -0400)]
Fix CLI allowing creation of access tokens with existing name (#26071) (#26144)
Backport #26071 by @yardenshoham
We are now:
- Making sure there is no existing access token with the same name
- Making sure the given scopes are valid (we already did this before but
now we have a message)
The logic is mostly taken from
https://github.com/go-gitea/gitea/blob/
a12a5f3652c339b17b187ff424a480631a3c1e1e /routers/api/v1/user/app.go#L101-L123
Closes #26044
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Giteabot [Wed, 26 Jul 2023 00:42:23 +0000 (20:42 -0400)]
Increase table cell horizontal padding (#26140) (#26142)
Backport #26140 by @silverwind
Extract from https://github.com/go-gitea/gitea/pull/26043, just the
padding increase.
Before and After (hard to notice, but it's there):
<img width="427" alt="Screenshot 2023-07-25 at 19 37 12"
src="https://github.com/go-gitea/gitea/assets/115237/
9543dcda -eccb-4739-b7dd-
06b076108ab4 ">
<img width="420" alt="Screenshot 2023-07-25 at 19 37 26"
src="https://github.com/go-gitea/gitea/assets/115237/
0a9c3724 -81a1-4c67-a13b-
4b728a51fc3a ">
Co-authored-by: silverwind <me@silverwind.io>
Giteabot [Wed, 26 Jul 2023 00:37:43 +0000 (20:37 -0400)]
Fix incorrect router logger (#26137) (#26143)
Backport #26137 by @wxiaoguang
A low-level mistake:
* `log.Info` is global `Info` function, which calls "default" logger
* `logger.Info` is the for router's logger
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Tue, 25 Jul 2023 16:32:39 +0000 (12:32 -0400)]
added ssh mirror workaround description (#26096) (#26136)
Backport #26096 by @thigg
related #1635 #18159
This will probably be obsolete at some point, but it should not break
anything and it may help some users
Co-authored-by: thigg <thigg@users.noreply.github.com>
Giteabot [Tue, 25 Jul 2023 11:43:39 +0000 (07:43 -0400)]
Improve commit graph alignment and truncating (#26112) (#26127)
Backport #26112 by @wxiaoguang
Fix #26101
![image](https://github.com/go-gitea/gitea/assets/
2114189 /
7507d201 -822e-4534-8b20-
e659d56b1268 )
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Tue, 25 Jul 2023 10:22:58 +0000 (06:22 -0400)]
Fix wrong workflow status when rerun a job in an already finished workflow (#26119) (#26124)
Backport #26119 by @yp05327
Before:
![image](https://github.com/go-gitea/gitea/assets/
18380374 /
fb687592 -b117-4cd5-b076-
2ca5ca847ea4 )
After:
![image](https://github.com/go-gitea/gitea/assets/
18380374 /
c9b0683e -e81d-410b-8c35-
fbe54327fab4 )
After workflow finished, if you rerun a single job, the workflow status
will become to `Running` which is not correct as no jobs are running in
this workflow.
Co-authored-by: yp05327 <576951401@qq.com>
Giteabot [Tue, 25 Jul 2023 06:14:18 +0000 (02:14 -0400)]
Fix escape problems in the branch selector (#25875) (#26103)
Backport #25875 by @yp05327
Fix #25865
Co-authored-by: yp05327 <576951401@qq.com>
Giteabot [Tue, 25 Jul 2023 05:31:50 +0000 (01:31 -0400)]
Avoid writing config file if not installed (#26107) (#26113)
Backport #26107 by @wxiaoguang
Just like others (oauth2 secret, internal token, etc), do not generate
if no install lock
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Giteabot [Mon, 24 Jul 2023 14:56:13 +0000 (10:56 -0400)]
Fix handling of Debian files with trailing slash (#26087) (#26098)
Backport #26087 by @KN4CK3R
Fixes #26022
- Fix handling of files with trailing slash
- Fix handling of duplicate package file errors
- Added test for both
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Giteabot [Mon, 24 Jul 2023 10:07:39 +0000 (06:07 -0400)]
fix Missing 404 swagger response docs for /admin/users/{username} (#26086) (#26089)
Backport #26086 by @CaiCandong
close #26079
Co-authored-by: caicandong <50507092+CaiCandong@users.noreply.github.com>
Giteabot [Mon, 24 Jul 2023 05:58:16 +0000 (01:58 -0400)]
Use stderr as fallback if the log file can't be opened (#26074) (#26083)
Backport #26074 by @wxiaoguang
If the log file can't be opened, what should it do? panic/exit? ignore
logs? fallback to stderr?
It seems that "fallback to stderr" is slightly better than others ....
Giteabot [Sun, 23 Jul 2023 10:27:34 +0000 (06:27 -0400)]
Fix duplicated url prefix on issue context menu (#26066) (#26067)
Backport #26066 by @lunny
Fix #26060
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Giteabot [Sat, 22 Jul 2023 09:18:59 +0000 (05:18 -0400)]
Add changelog for 1.20.1 (#26015) (#26056)
Backport #26015 by @delvh
Co-authored-by: delvh <dev.lh@web.de>
Giteabot [Fri, 21 Jul 2023 20:06:51 +0000 (16:06 -0400)]
Fix version in rpm repodata/primary.xml.gz (#26009) (#26048)
Co-authored-by: Peter Verraedt <peter.verraedt@gmail.com>