feat: Reset route if neither the Viewer of the Sidebar is open

When the viewer or the sidebar is opened, we add the fileid to the route.
When both of them are closed, we do not remove the fileid from the route.
This means that, upon reload, the sidebar will be opened even though it was closed previously.

This PR ensure that the fileid is removed from the route when both the Sidebar and the Viewer are closed.

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #47870 from nextcloud/backport/47834/stable28

Merge pull request #47866 from nextcloud/backport/47858/stable28

Merge pull request #47942 from nextcloud/backport/47933/stable28

[stable28] fix(config): Throw PreconditionException always when it didn't match

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48051 from nextcloud/backport/48045/stable28

[stable28] fix(dav): set string type for sanitizeMtime

fix(dav): set string type for sanitizeMtime

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #47893 from nextcloud/backport/47339/stable28

[stable28] fix: Display 'Leave share' instead of 'Delete'

Merge pull request #47876 from nextcloud/backport/47848/stable28

[stable28] fix(files): Reset context menu position on close

Merge pull request #47935 from nextcloud/backport/47854/stable28

[stable28] fix(appstore): Ensure returned apps from AppStore are valid

Merge pull request #47979 from nextcloud/backport/47971/stable28

[stable28] fix: Do not try to set HTTP response code on already closed connection

Merge pull request #48032 from nextcloud/backport/48013/stable28

[stable28] fix(BaseResponse): Cast XML element values to string

Merge pull request #47917 from nextcloud/backport/47914/stable28

Merge pull request #47811 from nextcloud/backport/47649/stable28

Merge pull request #47861 from nextcloud/backport/47860/stable28

Merge pull request #48019 from nextcloud/backport/48015/stable28

Merge pull request #47988 from nextcloud/automated/noid/stable28-update-psalm-baseline

[stable28] Update psalm-baseline.xml

fix(BaseResponse): Cast XML element values to string

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48022 from nextcloud/backport/48017/stable28

Merge pull request #48023 from nextcloud/backport/48014/stable28

fix(Tags): Return boolean for userHasTags()

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(Comment): Initialize childrenCount as integer

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(Storage\Local): Do not call getSourcePath() on SplFileInfo

Signed-off-by: provokateurin <kate@provokateurin.de>

chore(tests): Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: Do not try to set HTTP response code on already closed connection

This avoids a PHP warning in the logs about trying to set the response
 code while the output already started. It’s useless to try to print an
 error page anyway in this situation because the connection was closed
 already.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #47974 from nextcloud/backport/47968/stable28

fix(files_external): Check key exists before accessing it

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Merge pull request #47956 from nextcloud/backport/47954/stable28

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #47952 from nextcloud/backport/47945/stable28

[stable28] fix(files_external): broken credentials dialog

fix(files): Adjust Cache::searchQuery() parameter name to match interface

Signed-off-by: provokateurin <kate@provokateurin.de>

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files_external): broken credentials dialog

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
[skip ci]

fix(config): Throw PreconditionException always when it didn't match

Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix: check if key is set

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix(appstore): Ensure returned apps from AppStore are valid

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: lint

chore: remove space

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: check if response array is null

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
chore: Add log

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #47886 from nextcloud/release/28.0.10

fix(LDAP): check index before accessing it

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(files_sharing): adjust permissions from custom edit and delete check methods

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

fix: Display 'Leave share' instead of 'Delete'

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files): Make `openMenu` watcher null safe

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

build(hub): 28.0.10

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>

fix(files): Reset context menu position on close

* Resolves https://github.com/nextcloud/server/issues/46934

Ensure that after a right-click the context menu position is resetted,
so that pressing the "actions"-menu button it is displayed on the correct location.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #47797 from nextcloud/backport/47692/stable28

[stable28] fix(files): Correctly parse external shares for files UI

fix(appstore): disabled appstore log level bump from debug to info

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>

fix(appstore): return if appstore is manually disabled

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: camel case

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: log a debug log

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: typing

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: typo

fix: typing

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files): Correctly parse external shares for files UI

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(preview): gracefully handle file not being opened in ProviderV2

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

Merge pull request #47785 from nextcloud/backport/47770/stable28

[stable28] fix(dav): Always respond custom error page on exceptions

fix: Only write once to template instead of create/copy

Signed-off-by: Julius Knorr <jus@bitgrid.net>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: Replace conflicting tags in `xml_exception` template

The `<?xml` tag is interpreted as PHP short tags, so this causes errors.
Instead just print that part of the template.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(dav): Always respond custom error page on exceptions

Signed-off-by: Louis Chemineau <louis@chmn.me>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

chore: compile scss

Signed-off-by: Christopher Ng <chrng8@gmail.com>

fix: Fix inaccessible content on public pages due to overlapping footer

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #47759 from nextcloud/release/28.0.10_rc1

28.0.10 RC1

Merge pull request #47776 from nextcloud/backport/47769/stable28

[stable28] fix: Use sha256 to hash arguments of background jobs

Merge pull request #47779 from nextcloud/backport/47519/stable28

[stable28] feat(transfer-ownership): Correctly react to encrypted files

fix: missing use statements

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: Migrate existing bg jobs to use sha256

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix(transfer-ownership): Improve comments according to code review

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

feat(transfer-ownership): Correctly react to encrypted files

For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix: Use sha256 to hash arguments of background jobs

This is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database.

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #46483 from nextcloud/dependabot/npm_and_yarn/stable28/jquery-ui-dist-1.13.3

build(deps): bump jquery-ui-dist from 1.13.2 to 1.13.3

Bumps [jquery-ui-dist](https://github.com/jquery/jquery-ui) from 1.13.2 to 1.13.3.
- [Release notes](https://github.com/jquery/jquery-ui/releases)
- [Commits](https://github.com/jquery/jquery-ui/compare/1.13.2...1.13.3)

---
updated-dependencies:
- dependency-name: jquery-ui-dist
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #47749 from nextcloud/backport/47417/stable28

[stable28] fix(files): Create non-existent parents of mountpoints

Merge pull request #47735 from nextcloud/backport/46859/stable28

[stable28] Fix status check and saving of external storages

Merge pull request #47766 from nextcloud/backport/47754/stable28

[stable28] fix(appstore): Cache apps.json also on dev instances

fix(appstore): Cache apps.json also on dev instances

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>

fix: Hide status tooltip in row to add a new mount point

The row to add a new mount point is cloned when a new mountpoint is
added, so it is expected that it includes a status span. However, it
should not be displayed in that row, only in the cloned row when its
status is updated.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Fix unmodified placeholder replacing the actual value when updating

When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

test: Add integration tests for saving external userglobal storages

As the external storage uses the Nextcloud server itself the number of
workers of the PHP process running the Nextcloud server had to be
increased. Otherwise if a request is sent for the external storage while
handling a request from the integration tests a deadlock would occur.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Reset selected backend when adding a new storage

As a new storage is added by selecting a backend the selected backend
needs to be reset. Otherwise it is not possible to add another storage
with the same backend.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Add missing translation for UI string

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Restore default status tooltip when no status message is provided

If the status is updated but no explicit message is provided (for
example, if the status check succeeded) the default tooltip (from the
template) is now set to prevent a mismatch between the status and the
tooltip (for example, if the configuration is fixed after a failed
status check).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Set status tooltip to error message on failed actions

When saving, updating and rechecking an storage fails (which is
different to the soft-fail when the action itself succeeds but the
status check does not) further details are provided in the error message
of the response, which is now set as the tooltip.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Set status tooltip to status message when saving an storage

When a storage is saved the status check can fail even if saving the
storage succeeds. In those cases further details are provided in the
status message of the storage, which is now set as the tooltip,
similarly to how it is done when rechecking the storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Remove status check when configuration was changed

Setting a null status was supposed to remove the status check, but
nothing was changed in that case. Now the status check is properly
removed, and doing that by hiding the element rather than just turning
it invisible also prevents that clicking on the invisible status
triggers a check, as until the new configuration is saved the check will
still be performed with the old configuration, which could be misleading
for the user.

Additionally, an explicit width is set to the parent of the span element
to prevent its width from changing when the span is shown and hidden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Recheck userglobal storages when loaded

Userglobal storages are now automatically recheck when loaded, similarly
to how it is done for global storages.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

refactor: Store result in its own variable

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Remove broken jQuery tooltip

In Nextcloud 29 and later the tooltip usage threw an error that caused
the UI to be unusable, so it was removed. In Nextcloud 28 there is no
error, but using the jQuery tooltip call causes the tooltip to be
unreadable, so it was removed as well (which makes the native tooltip to
be shown instead).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

build(hub): 28.0.10 RC1

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix(files): Create non-existent parents of mountpoints

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #47746 from nextcloud/backport/47738/stable28

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files): undefined sidebar

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Merge pull request #47732 from nextcloud/backport/44344/stable28

[stable28] fix(dav): adjust usages of webdav.customRequest

fix(dav): adjust usages of webdav.customRequest

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>