]> source.dussan.org Git - poi.git/log
poi.git
7 years agoTry to define the view as part of the Jenkins DSL, also try to move the view into...
Dominik Stadler [Thu, 4 May 2017 08:40:12 +0000 (08:40 +0000)]
Try to define the view as part of the Jenkins DSL, also try to move the view into sub-folder, see also INFRA-14002

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793752 13f79535-47bb-0310-9956-ffa450edef68

7 years agotest integration fix
Andreas Beeker [Thu, 4 May 2017 01:13:48 +0000 (01:13 +0000)]
test integration fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793733 13f79535-47bb-0310-9956-ffa450edef68

7 years agoSonarQube fixes
Andreas Beeker [Wed, 3 May 2017 22:16:26 +0000 (22:16 +0000)]
SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793727 13f79535-47bb-0310-9956-ffa450edef68

7 years agoHPSF: Change CustomProperties to delegate
Andreas Beeker [Wed, 3 May 2017 19:18:45 +0000 (19:18 +0000)]
HPSF: Change CustomProperties to delegate

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793699 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRemove Unicode chars in comments
Andreas Beeker [Wed, 3 May 2017 14:08:04 +0000 (14:08 +0000)]
Remove Unicode chars in comments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793647 13f79535-47bb-0310-9956-ffa450edef68

7 years agofix javadocs
Andreas Beeker [Wed, 3 May 2017 00:14:55 +0000 (00:14 +0000)]
fix javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793604 13f79535-47bb-0310-9956-ffa450edef68

7 years ago#52372 - OutOfMemoryError parsing a word file
Andreas Beeker [Tue, 2 May 2017 23:32:13 +0000 (23:32 +0000)]
#52372 - OutOfMemoryError parsing a word file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793602 13f79535-47bb-0310-9956-ffa450edef68

7 years agoReverted DocumentSummary hack in codepage guessing code
Andreas Beeker [Tue, 2 May 2017 23:30:17 +0000 (23:30 +0000)]
Reverted DocumentSummary hack in codepage guessing code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793601 13f79535-47bb-0310-9956-ffa450edef68

7 years agoHPSF: Add CopyCompare to IntegrationTests
Andreas Beeker [Tue, 2 May 2017 23:29:19 +0000 (23:29 +0000)]
HPSF: Add CopyCompare to IntegrationTests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793600 13f79535-47bb-0310-9956-ffa450edef68

7 years ago#52117 - Invalid "last printed" summary field value
Andreas Beeker [Tue, 2 May 2017 23:28:48 +0000 (23:28 +0000)]
#52117 - Invalid "last printed" summary field value
added test file to corpus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793599 13f79535-47bb-0310-9956-ffa450edef68

7 years agoHPSF: Enable new number types in VariantSupport
Andreas Beeker [Tue, 2 May 2017 23:28:00 +0000 (23:28 +0000)]
HPSF: Enable new number types in VariantSupport

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793598 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix hpsf javadocs and code issues
Andreas Beeker [Tue, 2 May 2017 23:27:27 +0000 (23:27 +0000)]
Fix hpsf javadocs and code issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793596 13f79535-47bb-0310-9956-ffa450edef68

7 years agoIntegrationTest - move excludes to file handler
Andreas Beeker [Tue, 2 May 2017 23:25:45 +0000 (23:25 +0000)]
IntegrationTest - move excludes to file handler

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793595 13f79535-47bb-0310-9956-ffa450edef68

7 years agoHPSF: Use LittleEndianStream instead of offset calculation
Andreas Beeker [Tue, 2 May 2017 23:24:50 +0000 (23:24 +0000)]
HPSF: Use LittleEndianStream instead of offset calculation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793594 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 61059: add @Override annotations
Javen O'Neal [Mon, 1 May 2017 21:51:34 +0000 (21:51 +0000)]
bug 61059: add @Override annotations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793418 13f79535-47bb-0310-9956-ffa450edef68

7 years agoExclude one more test from no-scratchpad runs, not sure how this was even working...
Dominik Stadler [Sun, 30 Apr 2017 09:12:48 +0000 (09:12 +0000)]
Exclude one more test from no-scratchpad runs, not sure how this was even working before...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793253 13f79535-47bb-0310-9956-ffa450edef68

7 years agoImprove information contained in exception in CellRangeAddress()
Dominik Stadler [Sun, 30 Apr 2017 09:12:44 +0000 (09:12 +0000)]
Improve information contained in exception in CellRangeAddress()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793252 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60325: Add commented out test that reproduces the performance issue
Dominik Stadler [Sun, 30 Apr 2017 09:12:36 +0000 (09:12 +0000)]
60325: Add commented out test that reproduces the performance issue

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793251 13f79535-47bb-0310-9956-ffa450edef68

7 years agoJavadoc fix
Nick Burch [Sun, 30 Apr 2017 08:49:51 +0000 (08:49 +0000)]
Javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793249 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 61034: break out of for-loop when both <sheet name="", id=""/> are found
Javen O'Neal [Sat, 29 Apr 2017 18:56:09 +0000 (18:56 +0000)]
bug 61034: break out of for-loop when both <sheet name="", id=""/> are found

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793230 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 61034: Call to XSSFReader.getSheetsData() returns duplicate sheets.
Javen O'Neal [Sat, 29 Apr 2017 17:27:17 +0000 (17:27 +0000)]
bug 61034: Call to XSSFReader.getSheetsData() returns duplicate sheets.
Thanks to Mauricio Eastmond for the Excel test file and unit test.
Thanks to Sebastian Wikalinski for isolating the problem and providing a patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793223 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 61051 -- add new worksheet-like relations for xlsb
Tim Allison [Thu, 27 Apr 2017 18:50:22 +0000 (18:50 +0000)]
bug 61051 -- add new worksheet-like relations for xlsb

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792940 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 61049 fix ordering of builtin formulas
Tim Allison [Thu, 27 Apr 2017 16:18:25 +0000 (16:18 +0000)]
bug 61049 fix ordering of builtin formulas

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792918 13f79535-47bb-0310-9956-ffa450edef68

7 years agoPatch from Tim Jones from #61044 - Note on setCompressTempFiles
Nick Burch [Wed, 26 Apr 2017 09:43:56 +0000 (09:43 +0000)]
Patch from Tim Jones from #61044 - Note on setCompressTempFiles

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792720 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 61021 - extract abspath from xlsb
Tim Allison [Fri, 21 Apr 2017 13:02:29 +0000 (13:02 +0000)]
bug 61021 - extract abspath from xlsb

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792198 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd conditional formatting evaluation example code and output results
Greg Woolsey [Thu, 20 Apr 2017 18:05:50 +0000 (18:05 +0000)]
Add conditional formatting evaluation example code and output results

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792102 13f79535-47bb-0310-9956-ffa450edef68

7 years agoUse assertContains instead of assertTrue(text.contains) for better error messages...
Javen O'Neal [Thu, 20 Apr 2017 01:28:40 +0000 (01:28 +0000)]
Use assertContains instead of assertTrue(text.contains) for better error messages on failure

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792009 13f79535-47bb-0310-9956-ffa450edef68

7 years agoUse assertContains instead of assertTrue(text.contains) for better error messages...
Javen O'Neal [Wed, 19 Apr 2017 23:51:03 +0000 (23:51 +0000)]
Use assertContains instead of assertTrue(text.contains) for better error messages on failure

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792007 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix bug #61007
Greg Woolsey [Wed, 19 Apr 2017 20:04:46 +0000 (20:04 +0000)]
Fix bug #61007

Revert to previous "expected" test results even though they don't match excel for a specific case, to accommodate tighter logic about which format patterns to send to CellFormat vs. handle directly in DataFormatter.

Send what was checked previously plus only multi-segment conditional range formats.  Allows existing tests to pass plus the new test with the case for these conditional formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791964 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix bug #61007
Greg Woolsey [Wed, 19 Apr 2017 18:10:52 +0000 (18:10 +0000)]
Fix bug #61007

use CellFormat for all format strings containing multiple parts (";" delimited) and update unit test to expect the same values as Excel.  Also added tests for the failing formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791949 13f79535-47bb-0310-9956-ffa450edef68

7 years agoUse assertContains instead of assertTrue(text.contains) for better error messages...
Nick Burch [Wed, 19 Apr 2017 06:13:33 +0000 (06:13 +0000)]
Use assertContains instead of assertTrue(text.contains) for better error messages on failure

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791857 13f79535-47bb-0310-9956-ffa450edef68

7 years agoLet IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toStr...
Dominik Stadler [Mon, 17 Apr 2017 20:13:52 +0000 (20:13 +0000)]
Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68

7 years ago#60998 - HSLFTable.setRowHeight sets row height incorrect
Andreas Beeker [Mon, 17 Apr 2017 17:13:23 +0000 (17:13 +0000)]
#60998 - HSLFTable.setRowHeight sets row height incorrect

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791696 13f79535-47bb-0310-9956-ffa450edef68

7 years agofindbugs fixes
Andreas Beeker [Mon, 17 Apr 2017 11:02:22 +0000 (11:02 +0000)]
findbugs fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791679 13f79535-47bb-0310-9956-ffa450edef68

7 years agoadd 3.16 to doap file
Andreas Beeker [Mon, 17 Apr 2017 09:50:52 +0000 (09:50 +0000)]
add 3.16 to doap file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791674 13f79535-47bb-0310-9956-ffa450edef68

7 years agofix forbidden-apis-check error
Andreas Beeker [Sun, 16 Apr 2017 23:43:56 +0000 (23:43 +0000)]
fix forbidden-apis-check error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791646 13f79535-47bb-0310-9956-ffa450edef68

7 years ago#60996 - XSSF: Multiple embedded objects on same sheet are ignored
Andreas Beeker [Sun, 16 Apr 2017 22:41:28 +0000 (22:41 +0000)]
#60996 - XSSF: Multiple embedded objects on same sheet are ignored

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791644 13f79535-47bb-0310-9956-ffa450edef68

7 years agoWebsite update / release guide fix
Andreas Beeker [Sun, 16 Apr 2017 20:40:47 +0000 (20:40 +0000)]
Website update / release guide fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791631 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd initial file of excludes when running with file-leak-detector
Dominik Stadler [Sun, 16 Apr 2017 10:19:49 +0000 (10:19 +0000)]
Add initial file of excludes when running with file-leak-detector

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791594 13f79535-47bb-0310-9956-ffa450edef68

7 years agoExclude more temporary files from Git
Dominik Stadler [Sun, 16 Apr 2017 10:19:44 +0000 (10:19 +0000)]
Exclude more temporary files from Git

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791593 13f79535-47bb-0310-9956-ffa450edef68

7 years agoSet eclipse folder outside of build-folder to not have hickups in Eclipse whener...
Dominik Stadler [Sun, 16 Apr 2017 10:19:41 +0000 (10:19 +0000)]
Set eclipse folder outside of build-folder to not have hickups in Eclipse whener we run 'ant clean'

Conflicts:
.classpath

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791592 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRevert "Add hamcrest-all to Gradle build as well"
Dominik Stadler [Sun, 16 Apr 2017 09:46:54 +0000 (09:46 +0000)]
Revert "Add hamcrest-all to Gradle build as well"

This reverts commit e452090d41190820ec7f2591097fb9e63ad6c59c.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791587 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd hamcrest-all to Gradle build as well
Dominik Stadler [Sun, 16 Apr 2017 09:45:23 +0000 (09:45 +0000)]
Add hamcrest-all to Gradle build as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791586 13f79535-47bb-0310-9956-ffa450edef68

7 years agoroll back to hamcrest-core
Javen O'Neal [Sun, 16 Apr 2017 06:19:30 +0000 (06:19 +0000)]
roll back to hamcrest-core

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791572 13f79535-47bb-0310-9956-ffa450edef68

7 years agoroll back to hamcrest-core
Javen O'Neal [Sun, 16 Apr 2017 06:10:23 +0000 (06:10 +0000)]
roll back to hamcrest-core

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791570 13f79535-47bb-0310-9956-ffa450edef68

7 years agochange from hamcrest-core-1.3 to hamcrest-all-1.3
Javen O'Neal [Sun, 16 Apr 2017 05:02:07 +0000 (05:02 +0000)]
change from hamcrest-core-1.3 to hamcrest-all-1.3

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791567 13f79535-47bb-0310-9956-ffa450edef68

7 years ago#60993 - HSLF: Grid and rowspan calculation in table cells is wrong
Andreas Beeker [Sat, 15 Apr 2017 12:14:26 +0000 (12:14 +0000)]
#60993 - HSLF: Grid and rowspan calculation in table cells is wrong

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791500 13f79535-47bb-0310-9956-ffa450edef68

7 years agoimprove unit test error messages
Javen O'Neal [Sat, 15 Apr 2017 03:21:34 +0000 (03:21 +0000)]
improve unit test error messages

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791445 13f79535-47bb-0310-9956-ffa450edef68

7 years agochange from hamcrest-core-1.3 to hamcrest-all-1.3
Javen O'Neal [Sat, 15 Apr 2017 03:19:27 +0000 (03:19 +0000)]
change from hamcrest-core-1.3 to hamcrest-all-1.3

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791444 13f79535-47bb-0310-9956-ffa450edef68

7 years agouse hamcrest matchers to reduce custom code
Javen O'Neal [Sat, 15 Apr 2017 02:50:46 +0000 (02:50 +0000)]
use hamcrest matchers to reduce custom code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791443 13f79535-47bb-0310-9956-ffa450edef68

7 years agouse assertStartsWith and assertEndsWith for better unit test error messages
Javen O'Neal [Sat, 15 Apr 2017 02:19:24 +0000 (02:19 +0000)]
use assertStartsWith and assertEndsWith for better unit test error messages

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791440 13f79535-47bb-0310-9956-ffa450edef68

7 years ago#60973 XDGF Support for "PolylineTo" as well as existing alternate spelling "PolyLineTo"
Nick Burch [Wed, 12 Apr 2017 11:11:56 +0000 (11:11 +0000)]
#60973 XDGF Support for "PolylineTo" as well as existing alternate spelling "PolyLineTo"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791108 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFailing, disabled unit test for bug #60973
Nick Burch [Wed, 12 Apr 2017 09:40:54 +0000 (09:40 +0000)]
Failing, disabled unit test for bug #60973

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791098 13f79535-47bb-0310-9956-ffa450edef68

7 years agoprepare for 3.17-beta1
Andreas Beeker [Tue, 11 Apr 2017 22:14:38 +0000 (22:14 +0000)]
prepare for 3.17-beta1

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791047 13f79535-47bb-0310-9956-ffa450edef68

7 years agorelease prepare for 3.16 - updating build.xml and status.xml
Andreas Beeker [Tue, 11 Apr 2017 22:13:33 +0000 (22:13 +0000)]
release prepare for 3.16 - updating build.xml and status.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791045 13f79535-47bb-0310-9956-ffa450edef68

7 years agoThe new HeapDump class uses com.sun.* classes, which the previous settings flagged...
Greg Woolsey [Tue, 11 Apr 2017 20:35:06 +0000 (20:35 +0000)]
The new HeapDump class uses com.sun.* classes, which the previous settings flagged as an error in Eclipse.  This changes them to warnings so compilation can succeed.

Also adds a couple of prefs from newer Eclipse, apparently.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791026 13f79535-47bb-0310-9956-ffa450edef68

7 years agoIssue #60971, handle formula chart titles
Greg Woolsey [Tue, 11 Apr 2017 20:27:23 +0000 (20:27 +0000)]
Issue #60971, handle formula chart titles

implemented per issue, breaking out static text vs. formula based title getters and setters, with unit test updates and additions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791025 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 50955 - add logging per Javen's recommendation. Thank you!
Tim Allison [Tue, 11 Apr 2017 20:00:12 +0000 (20:00 +0000)]
bug 50955 - add logging per Javen's recommendation.  Thank you!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791021 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 50955 - incorporate info from the DocumentSummaryInformation for
Tim Allison [Tue, 11 Apr 2017 17:07:04 +0000 (17:07 +0000)]
bug 50955 - incorporate info from the DocumentSummaryInformation for
guessing the encoding.  Back off to the old method if DocSummInfo is
not available. Thanks to Andreas Beeker for recommending this direction.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791002 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 50955 - try originally guessed codepoint, backoff to 1252 if that fails
Tim Allison [Tue, 11 Apr 2017 01:30:02 +0000 (01:30 +0000)]
bug 50955 - try originally guessed codepoint, backoff to 1252 if that fails

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790904 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix AIOOBE while extracting hssf pictures which are externally linked
Andreas Beeker [Mon, 10 Apr 2017 21:43:22 +0000 (21:43 +0000)]
Fix AIOOBE while extracting hssf pictures which are externally linked

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790897 13f79535-47bb-0310-9956-ffa450edef68

7 years agoExclude some additional nodes from OpenJDK builds
Dominik Stadler [Fri, 7 Apr 2017 06:56:35 +0000 (06:56 +0000)]
Exclude some additional nodes from OpenJDK builds

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790511 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdjust checking for Zip-Bomb errors so it also works on JDK >= 8
Dominik Stadler [Fri, 7 Apr 2017 06:38:23 +0000 (06:38 +0000)]
Adjust checking for Zip-Bomb errors so it also works on JDK >= 8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790508 13f79535-47bb-0310-9956-ffa450edef68

7 years agoTest for another type of xml-bomb
Dominik Stadler [Thu, 6 Apr 2017 21:50:03 +0000 (21:50 +0000)]
Test for another type of xml-bomb

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790473 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not...
Dominik Stadler [Thu, 6 Apr 2017 21:49:53 +0000 (21:49 +0000)]
Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790472 13f79535-47bb-0310-9956-ffa450edef68

7 years agoJavadoc fixes
Nick Burch [Wed, 5 Apr 2017 13:17:17 +0000 (13:17 +0000)]
Javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790239 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 50955 convert Set to Singleton per Javen's code review
Tim Allison [Wed, 5 Apr 2017 11:02:48 +0000 (11:02 +0000)]
bug 50955 convert Set to Singleton per Javen's code review

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790215 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 50955 and bug 60953 improve Big5 reader; ensure one character
Tim Allison [Wed, 5 Apr 2017 01:45:55 +0000 (01:45 +0000)]
bug 50955 and bug 60953 improve Big5 reader; ensure one character
per byte pair

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790172 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 50955 -- turn off test that now passes in Java 1.8 and 1.7
Tim Allison [Tue, 4 Apr 2017 15:26:01 +0000 (15:26 +0000)]
bug 50955 -- turn off test that now passes in Java 1.8 and 1.7
but not 1.6 until we can fix it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790136 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 50955 -- fix for java 7
Tim Allison [Tue, 4 Apr 2017 14:41:53 +0000 (14:41 +0000)]
bug 50955 -- fix for java 7

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790130 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 50955 -- word 6.0 charset fix
Tim Allison [Tue, 4 Apr 2017 02:06:46 +0000 (02:06 +0000)]
bug 50955 -- word 6.0 charset fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790061 13f79535-47bb-0310-9956-ffa450edef68

7 years agoCater for two different locations of test-results in Gradle 2.x and 3.x
Dominik Stadler [Sun, 2 Apr 2017 19:38:37 +0000 (19:38 +0000)]
Cater for two different locations of test-results in Gradle 2.x and 3.x

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1789910 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60906 -- clean up, and add range checking for casting to ints.
Tim Allison [Thu, 23 Mar 2017 18:08:52 +0000 (18:08 +0000)]
Bug 60906 -- clean up, and add range checking for casting to ints.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788295 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60489 -- add @Test annotation so that this actually runs and includes ConnectsTyp...
Tim Allison [Thu, 23 Mar 2017 16:56:29 +0000 (16:56 +0000)]
Bug 60489 -- add @Test annotation so that this actually runs and includes ConnectsType...<facepalm/>

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788288 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60906 -- fix style index
Tim Allison [Thu, 23 Mar 2017 16:31:42 +0000 (16:31 +0000)]
Bug 60906 -- fix style index

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788282 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60881 -- fix unit test to use assumeTrue thanks to Javen's recommendation.
Tim Allison [Wed, 22 Mar 2017 16:21:25 +0000 (16:21 +0000)]
60881 -- fix unit test to use assumeTrue thanks to Javen's recommendation.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788133 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60881 -- strip out system.set props for local test.
Tim Allison [Tue, 21 Mar 2017 00:13:11 +0000 (00:13 +0000)]
60881 -- strip out system.set props for local test.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787891 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60881 -- fix new unit test. xlsb test file apparently requires unlimited jce. If...
Tim Allison [Tue, 21 Mar 2017 00:03:01 +0000 (00:03 +0000)]
60881 -- fix new unit test.  xlsb test file apparently requires unlimited jce.  If not installed, ignore new test.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787890 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60881 and 60891 -- on further look, no need to throw an exception for an encrypted...
Tim Allison [Mon, 20 Mar 2017 20:47:15 +0000 (20:47 +0000)]
60881 and 60891 -- on further look, no need to throw an exception for an encrypted xlsb.  On the second, let's fix readFully to read fully.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787846 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60879 -- figure out if we can support old beta xlsb or throw exception. For now...
Tim Allison [Mon, 20 Mar 2017 18:50:25 +0000 (18:50 +0000)]
60879 -- figure out if we can support old beta xlsb or throw exception.  For now, let's hope there's only one diff and/or the other bounds checking etc will throw exception if there are other problems.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787832 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60042: Add sample file to check if this bug is fixed via bug 55791 already.
Dominik Stadler [Sun, 19 Mar 2017 21:44:05 +0000 (21:44 +0000)]
Bug 60042: Add sample file to check if this bug is fixed via bug 55791 already.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787664 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60810: Check for duplicate relation-names for notes similar to the fix for slides...
Dominik Stadler [Sun, 19 Mar 2017 21:43:57 +0000 (21:43 +0000)]
Bug 60810: Check for duplicate relation-names for notes similar to the fix for slides themselves in bug 55791

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787663 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix typo to "length", closes #51
Dominik Stadler [Sun, 19 Mar 2017 20:30:04 +0000 (20:30 +0000)]
Fix typo to "length", closes #51
Fix a few IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787659 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60823: DGET function, correct behavior with multiple result entries but only one...
Dominik Stadler [Sun, 19 Mar 2017 20:29:55 +0000 (20:29 +0000)]
60823: DGET function, correct behavior with multiple result entries but only one non-blank

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787658 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix broken imports
Dominik Stadler [Sat, 18 Mar 2017 18:46:15 +0000 (18:46 +0000)]
Fix broken imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787585 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdjust integration-test files slightly, more failure-output, make it a bit easier...
Dominik Stadler [Sat, 18 Mar 2017 13:56:11 +0000 (13:56 +0000)]
Adjust integration-test files slightly, more failure-output, make it a bit easier to test single-files, add a HeapDump class for investigating memory leaks, adjust XSSFFileHandler to free memory more quickly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787556 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd docm-file which is actually a binary doc to check handling of wrong-format-exceptions
Dominik Stadler [Sat, 18 Mar 2017 13:56:04 +0000 (13:56 +0000)]
Add docm-file which is actually a binary doc to check handling of wrong-format-exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787555 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix ROOT_DIR
Dominik Stadler [Fri, 17 Mar 2017 12:03:07 +0000 (12:03 +0000)]
Fix ROOT_DIR

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787330 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60826 -- clean up. Many, many thanks to Javen O'Neal's code review!
Tim Allison [Fri, 17 Mar 2017 10:09:59 +0000 (10:09 +0000)]
60826 -- clean up. Many, many thanks to Javen O'Neal's code review!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787320 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60826 -- update stress tests to handle xlsb
Tim Allison [Thu, 16 Mar 2017 22:32:24 +0000 (22:32 +0000)]
60826 -- update stress tests to handle xlsb

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787264 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60826 -- add initial support for streaming reading of xlsb files.
Tim Allison [Thu, 16 Mar 2017 18:37:13 +0000 (18:37 +0000)]
60826 -- add initial support for streaming reading of xlsb files.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787228 13f79535-47bb-0310-9956-ffa450edef68

7 years agoadd missing license header
Greg Woolsey [Tue, 14 Mar 2017 22:36:38 +0000 (22:36 +0000)]
add missing license header

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786962 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFixed #60858, which showed a regression of the fix for #56420 introduced by my refact...
Greg Woolsey [Tue, 14 Mar 2017 21:40:32 +0000 (21:40 +0000)]
Fixed #60858, which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822.

Includes new unit test based on the bug sample file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786954 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFixed #60858, which showed a regression of the fix for #56420 introduced by my refact...
Greg Woolsey [Tue, 14 Mar 2017 21:39:33 +0000 (21:39 +0000)]
Fixed #60858, which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822.

Includes new unit test based on the bug sample file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786953 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix some Sonar issues in sample "HSSFReadWrite"
Dominik Stadler [Mon, 13 Mar 2017 14:09:27 +0000 (14:09 +0000)]
Fix some Sonar issues in sample "HSSFReadWrite"
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786695 13f79535-47bb-0310-9956-ffa450edef68

7 years agoGradle Build: Try with setting baseDir for Sonar-runs, but likely still does not...
Dominik Stadler [Mon, 13 Mar 2017 13:20:51 +0000 (13:20 +0000)]
Gradle Build: Try with setting baseDir for Sonar-runs, but likely still does not work
 Update wrapper to 3.4.1, although we do not store it yet anyway

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786681 13f79535-47bb-0310-9956-ffa450edef68

7 years agoJenkins DSL: Fix setting property for Sonar-Host-URL
Dominik Stadler [Mon, 13 Mar 2017 12:18:21 +0000 (12:18 +0000)]
Jenkins DSL: Fix setting property for Sonar-Host-URL

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786670 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd tests from bug 45353 to show that this now works fine
Dominik Stadler [Fri, 10 Mar 2017 20:14:00 +0000 (20:14 +0000)]
Add tests from bug 45353 to show that this now works fine

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786432 13f79535-47bb-0310-9956-ffa450edef68

7 years agoHSSF: Try to handle cases where the length does not match the actual data while cloni...
Dominik Stadler [Fri, 10 Mar 2017 20:13:52 +0000 (20:13 +0000)]
HSSF: Try to handle cases where the length does not match the actual data while cloning, we see this in some documents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786431 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAllow to enable Sonar as part of the Gradle build and add Jenkins DSL job to test it
Dominik Stadler [Fri, 10 Mar 2017 20:13:46 +0000 (20:13 +0000)]
Allow to enable Sonar as part of the Gradle build and add Jenkins DSL job to test it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786430 13f79535-47bb-0310-9956-ffa450edef68