source.dussan.org Git

Javen O'Neal [Sun, 6 Dec 2015 20:51:54 +0000 (20:51 +0000)]

bug 56454: shiftRows incorrectly handle merged regions that do not contain column 0. Add failing unit test from Jörg Selbach.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718217 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 6 Dec 2015 20:43:27 +0000 (20:43 +0000)]

make test easier to understand using A1 addresses instead of row+col numbers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718216 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 5 Dec 2015 21:58:20 +0000 (21:58 +0000)]

xml schemas - remove deprecated warnings, as we prefer the array methods - see #56854

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718125 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Fri, 4 Dec 2015 17:03:49 +0000 (17:03 +0000)]

New PGP key for David North

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717995 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 4 Dec 2015 16:18:46 +0000 (16:18 +0000)]

Add file missed from last checkin

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717991 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 4 Dec 2015 14:39:07 +0000 (14:39 +0000)]

Bug 58084: Fix cloning Cell Styles with Borders

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717973 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 4 Dec 2015 14:38:14 +0000 (14:38 +0000)]

Eclipse warnings, code formatting, javadoc, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717972 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 11:59:26 +0000 (11:59 +0000)]

add hashCode for corresponding equals function

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717940 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 11:56:59 +0000 (11:56 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717938 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 11:12:27 +0000 (11:12 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717931 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 10:54:21 +0000 (10:54 +0000)]

FindBugs warning: ExcelStyleDateFormatter doesn't override java.text.SimpleDAtaFormat.equals(Object)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717930 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 10:51:03 +0000 (10:51 +0000)]

make fields static

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717929 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 10:47:31 +0000 (10:47 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717928 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 10:46:58 +0000 (10:46 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717927 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 10:33:28 +0000 (10:33 +0000)]

findbugs: check return value of File.mkdir(s), and don't accidentally catch RuntimeException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717923 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 10:01:58 +0000 (10:01 +0000)]

add comments for names of missing functions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717920 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 07:20:36 +0000 (07:20 +0000)]

fix javadocs errors

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717907 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 07:10:26 +0000 (07:10 +0000)]

fix javadoc errors

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717903 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 07:05:52 +0000 (07:05 +0000)]

fix javadoc errors

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717902 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 06:36:27 +0000 (06:36 +0000)]

bug 58570: add get/setActiveCell to Sheet interface, add Cell.getAddress,

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717900 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 4 Dec 2015 06:30:34 +0000 (06:30 +0000)]

remove deprecated functions (since 2008)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717899 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 2 Dec 2015 21:47:52 +0000 (21:47 +0000)]

Add some additional rules for the forbidden-apis-check borrowed from Elasticsearch, also add a separate signature file with more rules for the 'prod' code and fix two newly found issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717689 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Tue, 1 Dec 2015 00:23:21 +0000 (00:23 +0000)]

Sonar fixes, direct array parameter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717359 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 30 Nov 2015 23:34:30 +0000 (23:34 +0000)]

- #47904 - Update text styles in HSLF MasterSlide
- common sl unification for TextParagraph.setTextAlign

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717351 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 07:03:37 +0000 (07:03 +0000)]

revert .project

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717195 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 07:03:09 +0000 (07:03 +0000)]

bug 58670: cleanup from r1717192

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717194 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 06:23:41 +0000 (06:23 +0000)]

revert .project

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717193 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 06:07:49 +0000 (06:07 +0000)]

bug 58670: replace SXSSFRow's storage of SXSSFCells[] with a TreeMap<Int, SXSSFCell>

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717192 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 05:28:57 +0000 (05:28 +0000)]

add @Override annotations to SXSSFRow

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717181 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 05:22:14 +0000 (05:22 +0000)]

add @Override annotation. Explicitly specify workbook type returned by SXSSFITestDataProvider.writeOutAndReadBack

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717179 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 05:21:01 +0000 (05:21 +0000)]

testBool/testErr: check values before writeOutAndReadBack

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717178 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 05:00:24 +0000 (05:00 +0000)]

fix testErr: createRow(1) -> createRow(0); replace assumeTrue with assertEquals for more informative test results

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717171 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 04:50:18 +0000 (04:50 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717167 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 04:43:32 +0000 (04:43 +0000)]

add @Override and @NotImplemented annotations to SXSSFCell, update javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717164 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 04:38:04 +0000 (04:38 +0000)]

break testBoolErr into 2 unit tests. The test shouldn't be aware of the underlying implementation for HSSFRows, and shorter tests are better

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717163 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 04:36:17 +0000 (04:36 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717162 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 04:24:06 +0000 (04:24 +0000)]

bug 58671: change MissingCellPolicy from class to enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717157 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 02:06:36 +0000 (02:06 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717151 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 01:05:10 +0000 (01:05 +0000)]

add missing ASF License headers for bug 57450

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717149 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Nov 2015 00:22:50 +0000 (00:22 +0000)]

patch from Stefan Thurnherr: bug 57450: autosize columns in SXSSF using rows that have been flushed to disk

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717146 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 29 Nov 2015 19:53:44 +0000 (19:53 +0000)]

Update some maven plugins to the latest version

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717113 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 29 Nov 2015 17:41:58 +0000 (17:41 +0000)]

Add helper method for opening the test files - maybe switched to InputStream if test-data files are changed unexpectedly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717099 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 29 Nov 2015 16:17:29 +0000 (16:17 +0000)]

XSLF: tables can now be removed from sheets/groups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717087 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 15:31:57 +0000 (15:31 +0000)]

bug 57844: add NotImplemented annotation to SXSSFSheet.shiftRows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717079 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 15:27:34 +0000 (15:27 +0000)]

add @Override annotations to Sheet classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717078 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 29 Nov 2015 15:26:53 +0000 (15:26 +0000)]

close resources
fix a few eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717077 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 15:24:08 +0000 (15:24 +0000)]

remove debugging print statements

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717076 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 14:45:24 +0000 (14:45 +0000)]

Patch from Lyle for bug 52903: HSSFSheet.shiftRows does not shift hyperlink references

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717069 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 14:33:28 +0000 (14:33 +0000)]

findbugs: add missing equals and hashCode for classes with a compareTo method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717068 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 13:15:03 +0000 (13:15 +0000)]

javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717062 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 13:02:12 +0000 (13:02 +0000)]

revert r1716119, since it would delete the output of compile-ooxml-xsds and require the target to be rebuilt every time "ant compile" was run

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717057 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 12:14:45 +0000 (12:14 +0000)]

bug 58667: make SX/X/HSSFRow implement Comparable interface

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717054 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 11:58:26 +0000 (11:58 +0000)]

HSSFRow: make instance variables final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717049 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 11:50:11 +0000 (11:50 +0000)]

SXSSFRow: privatize instance variables, make _sheet final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717044 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 11:48:02 +0000 (11:48 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717043 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 11:47:27 +0000 (11:47 +0000)]

make SXSSFRow._style private, add getRowStyleIndex() in its place

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717042 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 11:44:03 +0000 (11:44 +0000)]

javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717040 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 11:39:36 +0000 (11:39 +0000)]

javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717038 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 11:34:56 +0000 (11:34 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717035 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 02:43:17 +0000 (02:43 +0000)]

bug 52903/58557: add @Override decorators to XSSFHyperlink and HSSFHyperlink

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717026 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 29 Nov 2015 02:18:45 +0000 (02:18 +0000)]

bug 58636: make ClientAnchor enum constructor private, make byId Internal

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717024 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 29 Nov 2015 01:23:54 +0000 (01:23 +0000)]

#46210 - Title placeholder not recognized by Powerpoint 2003

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717020 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 29 Nov 2015 00:51:04 +0000 (00:51 +0000)]

#58663 - Pictures cannot be removed from a slide

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717018 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 28 Nov 2015 11:55:02 +0000 (11:55 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716948 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 28 Nov 2015 11:53:22 +0000 (11:53 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716947 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 27 Nov 2015 11:35:43 +0000 (11:35 +0000)]

make instance variables final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716843 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 27 Nov 2015 11:30:18 +0000 (11:30 +0000)]

+FIXME

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716838 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 27 Nov 2015 09:45:53 +0000 (09:45 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716811 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 25 Nov 2015 11:52:25 +0000 (11:52 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716365 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 25 Nov 2015 11:48:17 +0000 (11:48 +0000)]

bug 58651: replace for-looped sheet.getMergedRegion(index) with sheet.getMergedRegions()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716362 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 25 Nov 2015 09:48:36 +0000 (09:48 +0000)]

javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716342 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 25 Nov 2015 09:19:03 +0000 (09:19 +0000)]

add failing unit test for bug 58648

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716338 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 25 Nov 2015 07:16:43 +0000 (07:16 +0000)]

bug 58636: upgrade anchor types from int to AnchorType enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716313 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 24 Nov 2015 12:23:08 +0000 (12:23 +0000)]

Bump the ooxml-security version in the classpath definition to match the updated jar name

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716119 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 10:50:57 +0000 (10:50 +0000)]

close workbook at end of example

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716102 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 24 Nov 2015 09:10:27 +0000 (09:10 +0000)]

Remove useless double check on null introduced with the previous bugfix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716082 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 08:54:32 +0000 (08:54 +0000)]

bug 58637: replace deprecated getCellComment(row, col) usage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716075 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 08:52:45 +0000 (08:52 +0000)]

bug 58348: use copy constructor design pattern rather than cloneable pattern for CellCopyPolicy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716074 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 08:50:53 +0000 (08:50 +0000)]

javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716073 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 08:15:42 +0000 (08:15 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716060 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 08:13:10 +0000 (08:13 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716057 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 08:08:33 +0000 (08:08 +0000)]

revert accidental change to .project

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716055 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 08:04:42 +0000 (08:04 +0000)]

bug 58644: fix HSSFSheet.setZoom(int); update documentation to use non-deprecated method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716053 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 07:53:17 +0000 (07:53 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716051 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 07:43:53 +0000 (07:43 +0000)]

bug 58642: deprecate Sheet.setZoom(numerator, denominator) and replace with Sheet.setZoom(scale)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716048 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 07:34:09 +0000 (07:34 +0000)]

bug 58642: remove deprecated functions in Spreadsheet Sheet interface and implementing classes; add @Override annotations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716046 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 07:05:11 +0000 (07:05 +0000)]

rewrite ternary expression as simple Math.min call (yes, the ternary expression as written is equivalent to min, not max, despite the variable being called max. I'll leave that fix up to the original author).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716044 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 05:57:31 +0000 (05:57 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716035 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 05:51:54 +0000 (05:51 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716034 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 01:20:45 +0000 (01:20 +0000)]

FindBugs MALICIOUS_CODE, finalize method should have protected access

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716006 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 01:11:57 +0000 (01:11 +0000)]

FindBug warning: ICAST_IDIV_CAST_TO_DOUBLE: integral division result cast to double

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716005 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 01:10:47 +0000 (01:10 +0000)]

FindBug warning: EQ_SELF_USE_OBJECT: class defines equals(Region) and uses Object.equals(Object)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716004 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 01:08:34 +0000 (01:08 +0000)]

remove duplicate null check of srcStartRow (identified by FindBugs)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716003 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Nov 2015 00:08:22 +0000 (00:08 +0000)]

fix normal priority FindBugs warning: DMI_INVOKING_HASHCODE_ON_ARRAY

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715998 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 23 Nov 2015 23:57:40 +0000 (23:57 +0000)]

fix javadoc warnings from r1690486

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715996 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 23 Nov 2015 23:52:59 +0000 (23:52 +0000)]

fix javadoc warnings from r1715839 bug 58365

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715993 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 23 Nov 2015 23:34:33 +0000 (23:34 +0000)]

fix javadoc warnings from r1715839 bug 58365

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715987 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 23 Nov 2015 15:45:30 +0000 (15:45 +0000)]

fixed bad test case in BaseTestSheet.getCellComments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715854 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 23 Nov 2015 15:36:57 +0000 (15:36 +0000)]

catch IOException and rethrow as RuntimeException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715850 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 23 Nov 2015 15:11:28 +0000 (15:11 +0000)]

bug 58365: patch from Hannes Erven: add method to efficiently get all cell comments on a Sheet and return a dictionary with the location of each comment as the key and the comment itself as the value.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715839 13f79535-47bb-0310-9956-ffa450edef68