]> source.dussan.org Git - jquery.git/log
jquery.git
10 years agoBuild: Upgrade to commitplease 2.0.0
Jörn Zaefferer [Wed, 22 Oct 2014 15:57:23 +0000 (17:57 +0200)]
Build: Upgrade to commitplease 2.0.0

commitplease now accepts "[tmp]:" and similar to temporary commits,
useful while updating pull requests that are squashed later.

10 years agoMisc: Update all references to bugs.jquery.com
Arthur Verschaeve [Fri, 17 Oct 2014 05:01:37 +0000 (07:01 +0200)]
Misc: Update all references to bugs.jquery.com

Fixes gh-1681
Closes gh-1716

10 years agoMisc: Need for speed removed by 9ad6e7e
Dave Methvin [Sun, 19 Oct 2014 19:16:13 +0000 (15:16 -0400)]
Misc: Need for speed removed by 9ad6e7e

10 years agoAjax: remove event dependency from the ajax module 1697/head
Oleg Gaidarenko [Fri, 10 Oct 2014 17:01:59 +0000 (21:01 +0400)]
Ajax: remove event dependency from the ajax module

Closes gh-1695

10 years agoReadme: Fix minor style issues. Thanks @MightyBranch!
Dave Methvin [Mon, 6 Oct 2014 13:25:27 +0000 (09:25 -0400)]
Readme: Fix minor style issues. Thanks @MightyBranch!

10 years agoREADME: Improve build instructions
Oleg Gaidarenko [Tue, 23 Sep 2014 22:03:04 +0000 (15:03 -0700)]
README: Improve build instructions

Thanks @NickStefan

Closes gh-1663

10 years agoData: avoid non-alphanumeric chars in expando properties
Jason Bedard [Tue, 23 Sep 2014 03:05:59 +0000 (20:05 -0700)]
Data: avoid non-alphanumeric chars in expando properties

Ref chromium issue 378607
Ref #14839
Closes gh-1662

10 years agoEvent: Restore the `constructor` property on jQuery.Event prototype
Daniel Herman [Thu, 15 May 2014 16:26:20 +0000 (12:26 -0400)]
Event: Restore the `constructor` property on jQuery.Event prototype

The original definition of the jQuery.Event prototype was paving over the
`constructor` property which was causing jQuery.isPlainObject to
improperly report that an instance of jQuery.Event was a plain object.

Fixes #15090
Closes gh-1580

10 years agoManipulation: Tolerate XMLNode host object input to getAll
Richard Gibson [Tue, 17 Jun 2014 13:48:17 +0000 (09:48 -0400)]
Manipulation: Tolerate XMLNode host object input to getAll

Fixes #15151
Ref 25712d77c3bc0221b5b2b9b9492c20a9cfbe1b17
Closes gh-1602

10 years agoCONTRIBUTING: Close parenthesis
Amit Merchant [Wed, 3 Sep 2014 11:00:26 +0000 (16:30 +0530)]
CONTRIBUTING: Close parenthesis

Closes gh-1648

10 years agoCSS: Correct typo in the comment
Oleg Gaidarenko [Tue, 2 Sep 2014 20:20:23 +0000 (00:20 +0400)]
CSS: Correct typo in the comment

10 years agoCSS: Use pre-defined displays for html and body
Oleg Gaidarenko [Tue, 2 Sep 2014 20:11:05 +0000 (00:11 +0400)]
CSS: Use pre-defined displays for html and body

Ref 60f546acb1c7136092b4fd01cccff052e468cc72
Ref 274feb53cc9a99633dfac785d8b3b837d192c43c

10 years agoCSS: Remove use of getDefaultComputedStyle
Nazar Mokrynskyi [Mon, 1 Sep 2014 21:13:46 +0000 (23:13 +0200)]
CSS: Remove use of getDefaultComputedStyle

Remove optimization to make jQuery compatible with Google's Polymer project

Closes gh-1647
Fixes #15227

10 years agoAttr: Use typeof check for getAttribute method
Oleg Gaidarenko [Tue, 2 Sep 2014 17:44:02 +0000 (21:44 +0400)]
Attr: Use typeof check for getAttribute method

Ref 29838b6cab6f2e508f3e9692f32918c72b1a504b

10 years agoBuild: Moved JSHint directives to .jshintrc file
Chris Antaki [Fri, 25 Jul 2014 22:23:54 +0000 (15:23 -0700)]
Build: Moved JSHint directives to .jshintrc file

Closes gh-1595

10 years agoOffset: Simplified a conditional
Chris Antaki [Fri, 25 Jul 2014 20:08:42 +0000 (13:08 -0700)]
Offset: Simplified a conditional

10 years agoCore: Drop strundefined variable
Chris Antaki [Fri, 25 Jul 2014 19:21:22 +0000 (12:21 -0700)]
Core: Drop strundefined variable

10 years agoCSS: Removed redundant "to the number" in comment
Aurelio De Rosa [Tue, 10 Jun 2014 21:26:35 +0000 (22:26 +0100)]
CSS: Removed redundant "to the number" in comment

Closes gh-1594

10 years agoCss: Fix the "sanity check" test
Michał Gołębiowski [Mon, 28 Jul 2014 16:46:31 +0000 (18:46 +0200)]
Css: Fix the "sanity check" test

The #dl element has 0 height so it's now considered hidden regardless
of its width.

10 years agoCSS: elements are hidden when either offsetWidth or offsetHeight is zero
Timmy Willison [Thu, 17 Jul 2014 23:53:57 +0000 (16:53 -0700)]
CSS: elements are hidden when either offsetWidth or offsetHeight is zero

- Note: this is a breaking change that has been delayed for several versions.

Fixes #10406
Fixes #13132

10 years agoBuild: update source map options for the new grunt jshint
Timmy Willison [Thu, 17 Jul 2014 18:15:19 +0000 (11:15 -0700)]
Build: update source map options for the new grunt jshint

10 years agoBuild: update grunt-jscs-checker and pass with the new rules
Timmy Willison [Thu, 17 Jul 2014 17:25:59 +0000 (10:25 -0700)]
Build: update grunt-jscs-checker and pass with the new rules

10 years agoBuild: update node dependencies barring jscs
Timmy Willison [Thu, 17 Jul 2014 17:24:37 +0000 (10:24 -0700)]
Build: update node dependencies barring jscs

10 years agoBuild: update front-end dependencies 1620/head
Timmy Willison [Thu, 17 Jul 2014 16:03:29 +0000 (09:03 -0700)]
Build: update front-end dependencies

10 years agoBuild: drop bower; use npm for front-end deps
Timmy Willison [Thu, 17 Jul 2014 16:02:59 +0000 (09:02 -0700)]
Build: drop bower; use npm for front-end deps

Fixes #15186
Closes gh-1620

10 years agoAjax: Remove workaround for IE6/7
Chris Antaki [Fri, 13 Jun 2014 18:42:38 +0000 (11:42 -0700)]
Ajax: Remove workaround for IE6/7

Closes gh-1597
Ref #8138

10 years agoReadme: Fix punctuation in tile
upisfree [Sun, 29 Jun 2014 11:09:59 +0000 (14:09 +0300)]
Readme: Fix punctuation in tile

Closes gh-1607

10 years agoCore: Consistently use local reference to access()
Timo Tijhof [Tue, 24 Jun 2014 10:52:15 +0000 (12:52 +0200)]
Core: Consistently use local reference to access()

Ref 3b53b75160606610cc8f87404f89fc9e10441c4b
Closes gh-1605

10 years agoBuild: update Sizzle to 2.0.0
Timmy Willison [Tue, 1 Jul 2014 20:50:27 +0000 (16:50 -0400)]
Build: update Sizzle to 2.0.0

10 years agoSelector: Remove "#" exception for identifier tokens
Michał Gołębiowski [Mon, 30 Jun 2014 16:13:57 +0000 (18:13 +0200)]
Selector: Remove "#" exception for identifier tokens

Port Sizzle test change from:
https://github.com/jquery/sizzle/commit/f204a6112216f31685717d9fc1bf6cabf42b2ef1

10 years agoBuild: Update license
Scott González [Tue, 27 May 2014 19:03:12 +0000 (15:03 -0400)]
Build: Update license

Closes gh-1587

10 years agoBuild: update grunt-bowercopy
Timmy Willison [Wed, 25 Jun 2014 17:51:39 +0000 (13:51 -0400)]
Build: update grunt-bowercopy

10 years agoBuild: update Sizzle to 1.11.1 and include license
Timmy Willison [Wed, 25 Jun 2014 17:43:09 +0000 (13:43 -0400)]
Build: update Sizzle to 1.11.1 and include license

10 years agoBuild: ignore test dependencies for npm install
Timmy Willison [Tue, 24 Jun 2014 15:17:44 +0000 (11:17 -0400)]
Build: ignore test dependencies for npm install

10 years agoBuild: Move all external libraries to external directory
Scott González [Tue, 10 Jun 2014 19:32:25 +0000 (15:32 -0400)]
Build: Move all external libraries to external directory

Closes gh-1593

10 years agoBuild: Remove unused Sizzle test files
Scott González [Tue, 10 Jun 2014 19:13:03 +0000 (15:13 -0400)]
Build: Remove unused Sizzle test files

10 years agoBuild: Upgrade to grunt-bowercopy 1.0.0
Scott González [Tue, 10 Jun 2014 19:58:28 +0000 (15:58 -0400)]
Build: Upgrade to grunt-bowercopy 1.0.0

10 years agoBuild: Update commitplease dev dependency
Oleg Gaidarenko [Sun, 15 Jun 2014 23:01:53 +0000 (03:01 +0400)]
Build: Update commitplease dev dependency

10 years agoBuild: Move test to appropriate module
Oleg Gaidarenko [Sat, 14 Jun 2014 16:31:08 +0000 (20:31 +0400)]
Build: Move test to appropriate module

10 years agoEffects: Improve raf logic
Oleg Gaidarenko [Mon, 12 May 2014 17:53:40 +0000 (21:53 +0400)]
Effects: Improve raf logic

* Make animation behave as if jQuery.fx.off = true if document is hidden

* Use cancelAnimationFrame in jQuery.fx.stop

Closes gh-1578

10 years agoEffects: Reintroduce use of requestAnimationFrame
Oleg Gaidarenko [Fri, 9 May 2014 00:21:42 +0000 (04:21 +0400)]
Effects: Reintroduce use of requestAnimationFrame

Same as before, just use don't use prefixes, since they pretty match useless now
and use page visibility API to determine if animation should start.

Also null the requestAnimationFrame attribute in window for tests since
sinon does not provide fake method for it.

Fixes #15147

10 years agoAjax: Always use script injection in globalEval
Oleg Gaidarenko [Fri, 29 Nov 2013 08:15:05 +0000 (12:15 +0400)]
Ajax: Always use script injection in globalEval

Fixes #14757
Closes gh-1449

10 years agoCSS: Do not throw on frame elements in FF
Oleg Gaidarenko [Sun, 18 May 2014 16:47:37 +0000 (20:47 +0400)]
CSS: Do not throw on frame elements in FF

IE9-10 throws on elements created in popups (see #14150), FF meanwhile throws
on frame elements through "defaultView.getComputedStyle" (see #15098)

Use "defaultView" if in the popup which would fix IE issue,
use "window.getComputedStyle" which would fix FF issue.

And everybody wins, except performance, but who cares right?

Fixes #15098
Closes gh-1583

10 years agoSupport: clean up comments and Support notation
Dave Methvin [Fri, 25 Apr 2014 22:26:36 +0000 (18:26 -0400)]
Support: clean up comments and Support notation

Closes gh-1577

10 years agoTests: Clean up isNumeric tests
Richard Gibson [Sat, 7 Jun 2014 18:33:36 +0000 (14:33 -0400)]
Tests: Clean up isNumeric tests
(cherry picked from commit d05f4bda1cc0b1ef76dce41a53c17f75c105a377)

10 years agoCore: Work around loss of precision from parseFloat
Richard Gibson [Sat, 7 Jun 2014 18:22:49 +0000 (14:22 -0400)]
Core: Work around loss of precision from parseFloat

Fixes #15100
(cherry picked from commit b6e99eb43c35a3cd048c5c56d31c7e871f299a77)

10 years agoWrap: Declare a dependency on the manipulation module
TJ VanToll [Fri, 30 May 2014 20:13:00 +0000 (16:13 -0400)]
Wrap: Declare a dependency on the manipulation module

Fixes #15121
Closes gh-1589

10 years agoAjax: Support usage without jQuery.event 1588/head
TJ VanToll [Fri, 30 May 2014 13:48:43 +0000 (09:48 -0400)]
Ajax: Support usage without jQuery.event

Fixes #15118
Closes gh-1588

10 years agoAjax: move ajax event aliases to their own file
Timmy Willison [Mon, 2 Jun 2014 16:39:11 +0000 (12:39 -0400)]
Ajax: move ajax event aliases to their own file

Fixes #15126

10 years agoSelector: Use jQuery reference not Sizzle
Oleg Gaidarenko [Thu, 29 May 2014 17:54:45 +0000 (21:54 +0400)]
Selector: Use jQuery reference not Sizzle

10 years agoSelector: Fix test iframe submission for firefox
Oleg Gaidarenko [Thu, 29 May 2014 17:45:59 +0000 (21:45 +0400)]
Selector: Fix test iframe submission for firefox

Ref jquery/sizzle@20fbadb0870bd30e0e66c68891f121c0450374c4

10 years agoRelease: ensure Sizzle is the latest tag
Timmy Willison [Fri, 23 May 2014 16:45:51 +0000 (12:45 -0400)]
Release: ensure Sizzle is the latest tag

Fixes #14915

10 years agoBuild: run jshint and jscs on release scripts
Timmy Willison [Fri, 23 May 2014 16:45:19 +0000 (12:45 -0400)]
Build: run jshint and jscs on release scripts

10 years agoBuild: update AUTHORS.txt
Timmy Willison [Fri, 23 May 2014 17:00:55 +0000 (13:00 -0400)]
Build: update AUTHORS.txt

10 years agoEffects: Remove needless operations in tests
Oleg Gaidarenko [Fri, 9 May 2014 00:08:48 +0000 (04:08 +0400)]
Effects: Remove needless operations in tests

10 years agoAjax, Manipulation: don't test cross-document manip in Android 2.3 1572/head
Michał Gołębiowski [Mon, 5 May 2014 13:45:57 +0000 (15:45 +0200)]
Ajax, Manipulation: don't test cross-document manip in Android 2.3

10 years agoCore: Correct the number of expected tests
Michał Gołębiowski [Fri, 2 May 2014 14:03:52 +0000 (16:03 +0200)]
Core: Correct the number of expected tests

10 years agoCore: Remove repeated test
Liang Peng [Thu, 1 May 2014 11:37:23 +0000 (19:37 +0800)]
Core: Remove repeated test

Closes gh-1570

10 years agoBower: Update project version to 2.1.2-pre
Dave Methvin [Thu, 1 May 2014 20:42:42 +0000 (16:42 -0400)]
Bower: Update project version to 2.1.2-pre

10 years agoBuild: Updating the master version to 2.1.2-pre.
Dave Methvin [Thu, 1 May 2014 17:15:13 +0000 (13:15 -0400)]
Build: Updating the master version to 2.1.2-pre.

10 years agoData: Work around IE11 bug with onpageshow attribute
Dave Methvin [Wed, 30 Apr 2014 14:43:39 +0000 (10:43 -0400)]
Data: Work around IE11 bug with onpageshow attribute

Fixes #14894

10 years agoEffects: Respect display value on inline elements
Oleg Gaidarenko [Sat, 26 Apr 2014 17:24:05 +0000 (21:24 +0400)]
Effects: Respect display value on inline elements

Take "olddisplay" value into the account

Fixes #14824
Closes gh-1566
Ref 73fe17299a840a8a7f3ffffcac15e32a88bd3d66

10 years agoBuild: Spaces vs tabs
Oleg Gaidarenko [Thu, 24 Apr 2014 19:38:38 +0000 (23:38 +0400)]
Build: Spaces vs tabs

* Use tabs instead of spaces in jscs config

* Always use spaces in package.json (really hope this is temporary)

10 years agoBuild: Add "browser" keyword for npm
Dave Methvin [Wed, 23 Apr 2014 16:02:55 +0000 (12:02 -0400)]
Build: Add "browser" keyword for npm

10 years agoBuild: Remove json check for jscs config
Oleg Gaidarenko [Wed, 23 Apr 2014 16:02:06 +0000 (20:02 +0400)]
Build: Remove json check for jscs config

10 years agoSelector: Update Sizzle to 1.10.19
Richard Gibson [Fri, 18 Apr 2014 21:17:51 +0000 (17:17 -0400)]
Selector: Update Sizzle to 1.10.19

Fixes #14901
Fixes #14793

10 years agoCss: Use only positive integers as values for widows/orphans 1563/head
Michał Gołębiowski [Fri, 18 Apr 2014 00:07:17 +0000 (02:07 +0200)]
Css: Use only positive integers as values for widows/orphans

According to http://www.w3.org/TR/CSS2/page.html#propdef-orphans, widows
and orphans can take only positive integer values. Together with a Chrome 34
regression this caused the test to fail.

Fixes #15016
Closes gh-1563

10 years agoDimensions: Reverse a check to avoid potential reflows
Christian Kosmowski [Mon, 14 Apr 2014 14:00:42 +0000 (16:00 +0200)]
Dimensions: Reverse a check to avoid potential reflows

Fixes #14979
Closes gh-1560

10 years agoBuild: Update version from pre to -pre
Scott González [Thu, 17 Apr 2014 19:10:17 +0000 (15:10 -0400)]
Build: Update version from pre to -pre

Ref jquery/jquery-release#61
Fixes #15020
Closes gh-1561

10 years agoBuild: Remove Sizzle from run names passed to the testswarm task
Michał Gołębiowski [Tue, 15 Apr 2014 14:38:23 +0000 (16:38 +0200)]
Build: Remove Sizzle from run names passed to the testswarm task

10 years agoBuild: Update jscsrc
Oleg Gaidarenko [Tue, 15 Apr 2014 14:08:18 +0000 (18:08 +0400)]
Build: Update jscsrc

* Update "grunt-jscs-checker" package

* Use ".jscsrc" file instead of old ".jscs.json"

* Use jquery preset instead of explicitly defining all the jscs rules

10 years agoBuild: Fix code style issue
Oleg Gaidarenko [Tue, 15 Apr 2014 14:06:18 +0000 (18:06 +0400)]
Build: Fix code style issue

Remove needless empty line character

10 years agoTests: Fix failing ajax tests in oldIE
Oleg Gaidarenko [Fri, 4 Apr 2014 18:31:38 +0000 (22:31 +0400)]
Tests: Fix failing ajax tests in oldIE

(cherry-picked from the 71780965072b1271018f2cf360e82fbe31f4987e)

Picked up so tests from the 1.x-master would be more similar to this branch

10 years agoTests: Bring back some of the clean-up logic
Oleg Gaidarenko [Sat, 5 Apr 2014 14:23:03 +0000 (18:23 +0400)]
Tests: Bring back some of the clean-up logic

10 years agoTests: Remove unused variables
Oleg Gaidarenko [Wed, 26 Feb 2014 23:33:15 +0000 (03:33 +0400)]
Tests: Remove unused variables

10 years agoTests: Copy some Sizzle combinators tests
Oleg Gaidarenko [Wed, 26 Feb 2014 23:32:02 +0000 (03:32 +0400)]
Tests: Copy some Sizzle combinators tests

10 years agoTests: Add more tests for Sizzle attributes
Oleg Gaidarenko [Wed, 26 Feb 2014 23:23:10 +0000 (03:23 +0400)]
Tests: Add more tests for Sizzle attributes

10 years agoTests: Add test for selectors with commas
Oleg Gaidarenko [Wed, 26 Feb 2014 23:13:26 +0000 (03:13 +0400)]
Tests: Add test for selectors with commas

10 years agoTests: Copy Sizzle.uniqueSort tests
Oleg Gaidarenko [Wed, 26 Feb 2014 23:01:48 +0000 (03:01 +0400)]
Tests: Copy Sizzle.uniqueSort tests

10 years agoTests: Copy Sizzle.contains tests
Oleg Gaidarenko [Wed, 26 Feb 2014 23:01:07 +0000 (03:01 +0400)]
Tests: Copy Sizzle.contains tests

10 years agoTests: Move some of the Sizzle tests to selector
Oleg Gaidarenko [Mon, 24 Feb 2014 18:05:16 +0000 (22:05 +0400)]
Tests: Move some of the Sizzle tests to selector

10 years agoTests: Do global clean up in teardown function
Oleg Gaidarenko [Tue, 18 Feb 2014 17:52:48 +0000 (21:52 +0400)]
Tests: Do global clean up in teardown function

10 years agoTests: Improve jsonp tests
Oleg Gaidarenko [Tue, 18 Feb 2014 17:50:42 +0000 (21:50 +0400)]
Tests: Improve jsonp tests

Since global variable for callback always would be equal to undefined value
it better to check for boolean instead

10 years agoTests: Correct logic of a broken assertion
Oleg Gaidarenko [Tue, 18 Feb 2014 17:46:00 +0000 (21:46 +0400)]
Tests: Correct logic of a broken assertion

10 years agoBuild: Add lint task
Oleg Gaidarenko [Tue, 18 Feb 2014 16:34:49 +0000 (20:34 +0400)]
Build: Add lint task

10 years agoBuild: Use jscs to check test helpers
Oleg Gaidarenko [Tue, 18 Feb 2014 16:32:17 +0000 (20:32 +0400)]
Build: Use jscs to check test helpers

Also fix issues found by jscs

10 years agoTests: More improvments for testrunner
Oleg Gaidarenko [Tue, 18 Feb 2014 16:13:48 +0000 (20:13 +0400)]
Tests: More improvments for testrunner

Conform to style guide and simplify it

10 years agoTests: Remove Sizzle intergration tests
Oleg Gaidarenko [Tue, 18 Feb 2014 15:49:24 +0000 (19:49 +0400)]
Tests: Remove Sizzle intergration tests

Fixes #14818

10 years agoTests: Simplify globals cleanup
Oleg Gaidarenko [Mon, 27 Jan 2014 19:43:27 +0000 (23:43 +0400)]
Tests: Simplify globals cleanup

10 years agoTests: Remove QUnit start hook
Oleg Gaidarenko [Mon, 27 Jan 2014 19:32:46 +0000 (23:32 +0400)]
Tests: Remove QUnit start hook

10 years agoTests: Remove uselss "keys" helper
Oleg Gaidarenko [Mon, 27 Jan 2014 19:27:32 +0000 (23:27 +0400)]
Tests: Remove uselss "keys" helper

10 years agoTests: Simplify "testTimeout" option
Oleg Gaidarenko [Mon, 27 Jan 2014 19:26:27 +0000 (23:26 +0400)]
Tests: Simplify "testTimeout" option

10 years agoBuild: set default testswarm timeout to 15 minutes
Michał Gołębiowski [Tue, 15 Apr 2014 09:47:52 +0000 (11:47 +0200)]
Build: set default testswarm timeout to 15 minutes

We're not testing on IE6-7 anymore.

10 years agoBuild: use browserSets from config file; allow to override
Michał Gołębiowski [Tue, 15 Apr 2014 09:34:02 +0000 (11:34 +0200)]
Build: use browserSets from config file; allow to override

10 years agoBuild: change .gitattributes; use system line ends for non-JS files 1554/head
Michał Gołębiowski [Fri, 4 Apr 2014 09:38:15 +0000 (11:38 +0200)]
Build: change .gitattributes; use system line ends for non-JS files

10 years agoSupport: Add Android support tests results
Michał Gołębiowski [Mon, 31 Mar 2014 21:05:49 +0000 (23:05 +0200)]
Support: Add Android support tests results

10 years agoBuild: Update release script for new jquery-release API
Scott González [Tue, 18 Mar 2014 15:48:21 +0000 (11:48 -0400)]
Build: Update release script for new jquery-release API

Closes gh-1544

10 years agoSelector: Use Element.matches in selector-native if available
Philip Jägenstedt [Fri, 21 Feb 2014 18:43:51 +0000 (01:43 +0700)]
Selector: Use Element.matches in selector-native if available

Spec:
http://dom.spec.whatwg.org/#dom-element-matches

Support in Chromium:
https://code.google.com/p/chromium/issues/detail?id=326652

Fixes #14902
Closes gh-1524

10 years agoEvent: Fix isDefaultPrevented for bubbled events in Android 2.3
Michał Gołębiowski [Tue, 18 Mar 2014 21:38:08 +0000 (22:38 +0100)]
Event: Fix isDefaultPrevented for bubbled events in Android 2.3

Fixes #14897
Closes gh-1545

10 years agoEffects: Don't overwrite display:none when .hide()ing hidden elements
Richard Gibson [Thu, 20 Mar 2014 07:39:36 +0000 (03:39 -0400)]
Effects: Don't overwrite display:none when .hide()ing hidden elements

Fixes #14848
Closes gh-1548