]> source.dussan.org Git - poi.git/log
poi.git
3 years agointegration tests: NullPointerExceptions contain now a description in Java 16+
Andreas Beeker [Sat, 16 Jan 2021 09:55:42 +0000 (09:55 +0000)]
integration tests: NullPointerExceptions contain now a description in Java 16+

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885549 13f79535-47bb-0310-9956-ffa450edef68

3 years agoinclude externals on release build checkout
Andreas Beeker [Sat, 16 Jan 2021 00:19:04 +0000 (00:19 +0000)]
include externals on release build checkout

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885539 13f79535-47bb-0310-9956-ffa450edef68

3 years ago#65046 - Simplify integration tests
Andreas Beeker [Fri, 15 Jan 2021 23:50:42 +0000 (23:50 +0000)]
#65046 - Simplify integration tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885538 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Fri, 15 Jan 2021 22:34:35 +0000 (22:34 +0000)]
Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885537 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Fri, 15 Jan 2021 00:03:43 +0000 (00:03 +0000)]
Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885503 13f79535-47bb-0310-9956-ffa450edef68

3 years agoprepare for 5.0.1
Andreas Beeker [Tue, 12 Jan 2021 22:40:59 +0000 (22:40 +0000)]
prepare for 5.0.1

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885419 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd lz4-java for svn/release operations
Andreas Beeker [Tue, 12 Jan 2021 22:39:07 +0000 (22:39 +0000)]
add lz4-java for svn/release operations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885417 13f79535-47bb-0310-9956-ffa450edef68

3 years agorelease prepare for 5.0.0 - updating build.xml and changes.xml
Andreas Beeker [Tue, 12 Jan 2021 22:33:18 +0000 (22:33 +0000)]
release prepare for 5.0.0 - updating build.xml and changes.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885416 13f79535-47bb-0310-9956-ffa450edef68

3 years agoremove EPL license
Andreas Beeker [Tue, 12 Jan 2021 22:12:28 +0000 (22:12 +0000)]
remove EPL license

see https://lists.apache.org/thread.html/r605598dd36a371a8439652c8b362f4099d57662aeaf837fe5c22ad25%40%3Cdev.poi.apache.org%3E

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885412 13f79535-47bb-0310-9956-ffa450edef68

3 years agoUpdate license / NOTICE
Andreas Beeker [Tue, 12 Jan 2021 18:05:36 +0000 (18:05 +0000)]
Update license / NOTICE

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885402 13f79535-47bb-0310-9956-ffa450edef68

3 years agoUpdate maven dependencies
Andreas Beeker [Mon, 11 Jan 2021 23:53:29 +0000 (23:53 +0000)]
Update maven dependencies

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885371 13f79535-47bb-0310-9956-ffa450edef68

3 years agoUpdate maven dependencies
Andreas Beeker [Mon, 11 Jan 2021 22:58:02 +0000 (22:58 +0000)]
Update maven dependencies

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885369 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Mon, 11 Jan 2021 00:34:21 +0000 (00:34 +0000)]
Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885343 13f79535-47bb-0310-9956-ffa450edef68

3 years agorevert Sonar fixes on BaseIntegrationTest
Andreas Beeker [Sun, 10 Jan 2021 21:36:32 +0000 (21:36 +0000)]
revert Sonar fixes on BaseIntegrationTest

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885341 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sun, 10 Jan 2021 21:16:04 +0000 (21:16 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885340 13f79535-47bb-0310-9956-ffa450edef68

3 years agoignore inner classes in junitlauncher run
Andreas Beeker [Sun, 10 Jan 2021 13:34:04 +0000 (13:34 +0000)]
ignore inner classes in junitlauncher run

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885334 13f79535-47bb-0310-9956-ffa450edef68

3 years agoIBM JDK is slower than the other JDKs with "test58896WithFile" testcase
Andreas Beeker [Sun, 10 Jan 2021 13:28:48 +0000 (13:28 +0000)]
IBM JDK is slower than the other JDKs with "test58896WithFile" testcase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885333 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sun, 10 Jan 2021 01:42:30 +0000 (01:42 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885326 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sun, 10 Jan 2021 01:34:16 +0000 (01:34 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885325 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sun, 10 Jan 2021 01:15:55 +0000 (01:15 +0000)]
Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885324 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 9 Jan 2021 23:20:13 +0000 (23:20 +0000)]
Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885321 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 9 Jan 2021 20:25:15 +0000 (20:25 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885319 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 9 Jan 2021 20:19:07 +0000 (20:19 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885318 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 9 Jan 2021 19:20:09 +0000 (19:20 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885315 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 9 Jan 2021 18:24:51 +0000 (18:24 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885308 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 9 Jan 2021 15:49:35 +0000 (15:49 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885302 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 9 Jan 2021 15:35:07 +0000 (15:35 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885300 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 9 Jan 2021 00:46:52 +0000 (00:46 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885283 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Fri, 8 Jan 2021 23:50:02 +0000 (23:50 +0000)]
Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885281 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Fri, 8 Jan 2021 22:56:05 +0000 (22:56 +0000)]
Sonar fixes
Fixed offset of compare picture in resize_compare.xlsx

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885280 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Fri, 8 Jan 2021 00:26:16 +0000 (00:26 +0000)]
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885253 13f79535-47bb-0310-9956-ffa450edef68

3 years agoProperly close file handles in extractors and when handling password-protected files
Dominik Stadler [Thu, 7 Jan 2021 06:52:57 +0000 (06:52 +0000)]
Properly close file handles in extractors and when handling password-protected files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885229 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdd one more file-leak-detector exclude
Dominik Stadler [Thu, 7 Jan 2021 06:52:51 +0000 (06:52 +0000)]
Add one more file-leak-detector exclude

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885228 13f79535-47bb-0310-9956-ffa450edef68

3 years agoImprove EmptyFileException when the file actually does not exist at all
Dominik Stadler [Thu, 7 Jan 2021 06:52:46 +0000 (06:52 +0000)]
Improve EmptyFileException when the file actually does not exist at all

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885227 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Thu, 7 Jan 2021 00:27:13 +0000 (00:27 +0000)]
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885219 13f79535-47bb-0310-9956-ffa450edef68

3 years ago#65063 - WMF parsing failed on closed empty polygon
Andreas Beeker [Wed, 6 Jan 2021 23:14:45 +0000 (23:14 +0000)]
#65063 - WMF parsing failed on closed empty polygon

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885215 13f79535-47bb-0310-9956-ffa450edef68

3 years ago#65061 - Handle VmlDrawings containing spreadsheet-ml default namespace
Andreas Beeker [Wed, 6 Jan 2021 12:39:02 +0000 (12:39 +0000)]
#65061 - Handle VmlDrawings containing spreadsheet-ml default namespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885197 13f79535-47bb-0310-9956-ffa450edef68

3 years agoInclude file-name in EmptyFileException
Dominik Stadler [Wed, 6 Jan 2021 09:10:41 +0000 (09:10 +0000)]
Include file-name in EmptyFileException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885192 13f79535-47bb-0310-9956-ffa450edef68

3 years agoTry to avoid error "Start point cannot equalendpoint"
Dominik Stadler [Wed, 6 Jan 2021 09:10:35 +0000 (09:10 +0000)]
Try to avoid error "Start point cannot equalendpoint"

Happened when trying to apply a gradient to an empty text,
let's use at least 1 gradient step always to avoid this.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885191 13f79535-47bb-0310-9956-ffa450edef68

3 years agoRun all integration-test steps in manual test-method
Dominik Stadler [Wed, 6 Jan 2021 09:10:31 +0000 (09:10 +0000)]
Run all integration-test steps in manual test-method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885190 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSlightly adjust error message if requested allocations are too big
Dominik Stadler [Wed, 6 Jan 2021 09:10:28 +0000 (09:10 +0000)]
Slightly adjust error message if requested allocations are too big

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885189 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdjust one expected error message in integration-tests
Dominik Stadler [Wed, 6 Jan 2021 09:10:25 +0000 (09:10 +0000)]
Adjust one expected error message in integration-tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885188 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdjust assumption for one specific font-related exception on Windows
Dominik Stadler [Wed, 6 Jan 2021 09:10:21 +0000 (09:10 +0000)]
Adjust assumption for one specific font-related exception on Windows

Otherwise it triggers too much and hides actual regression bugs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885187 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAvoid unneeded Unicode characters which break compiling if encoding is not UTF-8
Dominik Stadler [Wed, 6 Jan 2021 09:10:17 +0000 (09:10 +0000)]
Avoid unneeded Unicode characters which break compiling if encoding is not UTF-8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885186 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Tue, 5 Jan 2021 23:40:36 +0000 (23:40 +0000)]
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885179 13f79535-47bb-0310-9956-ffa450edef68

3 years agoBug 64132: Fix regression introduced by changing factories
Dominik Stadler [Mon, 4 Jan 2021 05:51:24 +0000 (05:51 +0000)]
Bug 64132: Fix regression introduced by changing factories

We need to return EscherBlipRecord for all types in the defined range of recordId,
not UnknownEscherRecord.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885092 13f79535-47bb-0310-9956-ffa450edef68

3 years agoTry to make Gradle build work
Dominik Stadler [Sun, 3 Jan 2021 18:19:55 +0000 (18:19 +0000)]
Try to make Gradle build work

Add a dependency that is reported as missing locally with JDK 11
Combine common test-dependencies
Avoid running base-class BaseTestMissingWorkbook, only the derived class is actually a unit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885074 13f79535-47bb-0310-9956-ffa450edef68

3 years agoEnable XML result files for Gradle build to make them available for Jenkins CI
Dominik Stadler [Sun, 3 Jan 2021 17:02:24 +0000 (17:02 +0000)]
Enable XML result files for Gradle build to make them available for Jenkins CI

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885071 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAllow JUnit 5 access to the parmaeters also on newer JDKs
Dominik Stadler [Sun, 3 Jan 2021 17:02:21 +0000 (17:02 +0000)]
Allow JUnit 5 access to the parmaeters also on newer JDKs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885070 13f79535-47bb-0310-9956-ffa450edef68

3 years agoIgnore Font-issue with JDK 8 on Windows in another test
Dominik Stadler [Sun, 3 Jan 2021 17:02:18 +0000 (17:02 +0000)]
Ignore Font-issue with JDK 8 on Windows in another test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885069 13f79535-47bb-0310-9956-ffa450edef68

3 years agoApply some IDE suggestions
Dominik Stadler [Sun, 3 Jan 2021 17:02:14 +0000 (17:02 +0000)]
Apply some IDE suggestions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885068 13f79535-47bb-0310-9956-ffa450edef68

3 years agoFix file-leak-detector excludes
Dominik Stadler [Sun, 3 Jan 2021 17:02:08 +0000 (17:02 +0000)]
Fix file-leak-detector excludes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885067 13f79535-47bb-0310-9956-ffa450edef68

3 years agoBug 64494: Ensure "applyAlignment" in cell-styles is enabled when necessary
Dominik Stadler [Sun, 3 Jan 2021 12:01:08 +0000 (12:01 +0000)]
Bug 64494: Ensure "applyAlignment" in cell-styles is enabled when necessary

Also check it when fetching currently defined cell-alignment

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885059 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAvoid test failing on Windows with JDK 8 because of an ArrayIndexOutOfBoundsException...
Dominik Stadler [Sun, 3 Jan 2021 11:50:04 +0000 (11:50 +0000)]
Avoid test failing on Windows with JDK 8 because of an ArrayIndexOutOfBoundsException when handling fonts

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885058 13f79535-47bb-0310-9956-ffa450edef68

3 years agoooxml-schema: trigger loading stress-documents as part of the normal unit-tests
Dominik Stadler [Sun, 3 Jan 2021 11:49:59 +0000 (11:49 +0000)]
ooxml-schema: trigger loading stress-documents as part of the normal unit-tests

The integration-tests are not executed for determining the parts of the schema
to include in the "lite" package and so we need to have a normal unit-test as well.
Add more documents which drag in some more parts from the ooxml-schema

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885057 13f79535-47bb-0310-9956-ffa450edef68

3 years agoBug 64450: Allow to parse a file where the relationship-id is an empty string
Dominik Stadler [Sun, 3 Jan 2021 11:49:51 +0000 (11:49 +0000)]
Bug 64450: Allow to parse a file where the relationship-id is an empty string

Also improve exception reporting by including more information and not
"hiding" the actual exception-cause in a log-statement.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885056 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdjust Github Workflow to actually use newer version of Ant
Dominik Stadler [Sun, 3 Jan 2021 11:49:45 +0000 (11:49 +0000)]
Adjust Github Workflow to actually use newer version of Ant

setting the PATH or calling the ant-script did not work, one
actually needs to set ANT_HOME to make it work...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885055 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 2 Jan 2021 21:00:18 +0000 (21:00 +0000)]
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885035 13f79535-47bb-0310-9956-ffa450edef68

3 years agoforbidden-apis-fix
Andreas Beeker [Fri, 1 Jan 2021 23:26:25 +0000 (23:26 +0000)]
forbidden-apis-fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885022 13f79535-47bb-0310-9956-ffa450edef68

3 years agofix year agnostic date/test values
Andreas Beeker [Fri, 1 Jan 2021 23:20:02 +0000 (23:20 +0000)]
fix year agnostic date/test values

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885021 13f79535-47bb-0310-9956-ffa450edef68

3 years agoApply some IDE suggestions and fix some JavaDoc
Dominik Stadler [Fri, 1 Jan 2021 15:51:30 +0000 (15:51 +0000)]
Apply some IDE suggestions and fix some JavaDoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885012 13f79535-47bb-0310-9956-ffa450edef68

3 years agoBug 64750: Do not use CTDataValidations.getCount(), instead only rely on getDataValid...
Dominik Stadler [Fri, 1 Jan 2021 15:51:19 +0000 (15:51 +0000)]
Bug 64750: Do not use CTDataValidations.getCount(), instead only rely on getDataValidationArray

Field "count" seems to be optional according
to the schema, so by using only the array
Apache POI can read data validations from
workbooks that do not populate the
"count" field properly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885011 13f79535-47bb-0310-9956-ffa450edef68

3 years agoworkaround NullPointerException when font family (of bullets) can't be determined
Andreas Beeker [Wed, 30 Dec 2020 23:33:05 +0000 (23:33 +0000)]
workaround NullPointerException when font family (of bullets) can't be determined

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884974 13f79535-47bb-0310-9956-ffa450edef68

3 years agoworkaround "Width (0) and height (0) cannot be <= 0" error while rendering text with...
Andreas Beeker [Wed, 30 Dec 2020 23:13:23 +0000 (23:13 +0000)]
workaround "Width (0) and height (0) cannot be <= 0" error while rendering text with textures

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884966 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd failing regression test files
Andreas Beeker [Wed, 30 Dec 2020 22:56:36 +0000 (22:56 +0000)]
add failing regression test files
fix ooxml-lite packaging
fix PP97 dual storage file handling in extractor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884962 13f79535-47bb-0310-9956-ffa450edef68

3 years agoBug 64986: Support missing or blank match_type for function Match
Dominik Stadler [Wed, 30 Dec 2020 21:40:12 +0000 (21:40 +0000)]
Bug 64986: Support missing or blank match_type for function Match

Excel and LibreOffice use the default value in this case

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884959 13f79535-47bb-0310-9956-ffa450edef68

3 years agoBug 64838: Do not populate cells with a paragraph when loading an existing document
Dominik Stadler [Wed, 30 Dec 2020 21:40:06 +0000 (21:40 +0000)]
Bug 64838: Do not populate cells with a paragraph when loading an existing document

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884958 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdd unfixed test for bug 64759 and make the ones fail which depend on manual opening...
Dominik Stadler [Wed, 30 Dec 2020 21:40:01 +0000 (21:40 +0000)]
Add unfixed test for bug 64759 and make the ones fail which depend on manual opening of files in Microsoft Excel for verification

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884957 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAlso replace for JUnit 5 in comments
Dominik Stadler [Wed, 30 Dec 2020 21:39:56 +0000 (21:39 +0000)]
Also replace for JUnit 5 in comments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884956 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdjust error-message on old files and simplify code slightly
Dominik Stadler [Wed, 30 Dec 2020 17:03:30 +0000 (17:03 +0000)]
Adjust error-message on old files and simplify code slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884950 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSlightly re-arrange code to only perform computations if we do not exit the loop...
Dominik Stadler [Wed, 30 Dec 2020 17:03:27 +0000 (17:03 +0000)]
Slightly re-arrange code to only perform computations if we do not exit the loop anyway

Also simplify code somewhat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884949 13f79535-47bb-0310-9956-ffa450edef68

3 years agoBug 65009: Fix incorrect index for 1-based pictures
Dominik Stadler [Wed, 30 Dec 2020 17:03:23 +0000 (17:03 +0000)]
Bug 65009: Fix incorrect index for 1-based pictures

Adjusted somewhat from Github PR #211

Closes #211

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884948 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdd missing jar-file for JavaDoc generation
Dominik Stadler [Tue, 29 Dec 2020 19:29:29 +0000 (19:29 +0000)]
Add missing jar-file for JavaDoc generation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884919 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdjust some JavaDoc
Dominik Stadler [Tue, 29 Dec 2020 19:29:27 +0000 (19:29 +0000)]
Adjust some JavaDoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884918 13f79535-47bb-0310-9956-ffa450edef68

3 years agoImprove the speed of the styles-optimiser when there are many styles in a Workbook
Dominik Stadler [Tue, 29 Dec 2020 19:29:22 +0000 (19:29 +0000)]
Improve the speed of the styles-optimiser when there are many styles in a Workbook

Profiling showed that the call to isUserDefined() took most of the time,
so we now fetch this only once for each style and remember the result and
use it in the inner loop.

The attached sample-file took aprox. 1m30s on a decent machine, now it is down
to around 2s.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884917 13f79535-47bb-0310-9956-ffa450edef68

3 years agobump versions
Andreas Beeker [Mon, 28 Dec 2020 14:49:29 +0000 (14:49 +0000)]
bump versions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884878 13f79535-47bb-0310-9956-ffa450edef68

3 years agosonar fixes
Andreas Beeker [Mon, 28 Dec 2020 14:06:24 +0000 (14:06 +0000)]
sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884874 13f79535-47bb-0310-9956-ffa450edef68

3 years agogithub-207 - replace commons logging with slf4j - use jcl-over-slf4j
Andreas Beeker [Mon, 28 Dec 2020 14:03:36 +0000 (14:03 +0000)]
github-207 - replace commons logging with slf4j - use jcl-over-slf4j

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884873 13f79535-47bb-0310-9956-ffa450edef68

3 years agosonarcloud.io phases out support for Java 8
Andreas Beeker [Mon, 28 Dec 2020 10:45:43 +0000 (10:45 +0000)]
sonarcloud.io phases out support for Java 8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884859 13f79535-47bb-0310-9956-ffa450edef68

3 years agogather necessary .xsb for ooxml-lite jar via intercepting the calls to SchemaTypeSyst...
Andreas Beeker [Mon, 28 Dec 2020 00:47:23 +0000 (00:47 +0000)]
gather necessary .xsb for ooxml-lite jar via intercepting the calls to SchemaTypeSystemImpl.XsbReader

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884850 13f79535-47bb-0310-9956-ffa450edef68

3 years agoForbidden-apis fix - Graphics2D.finalize() is deprecated by Java14
Andreas Beeker [Sat, 26 Dec 2020 09:09:17 +0000 (09:09 +0000)]
Forbidden-apis fix - Graphics2D.finalize() is deprecated by Java14

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884813 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 26 Dec 2020 00:08:19 +0000 (00:08 +0000)]
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884807 13f79535-47bb-0310-9956-ffa450edef68

3 years agotry to fix gradle sonarqube job
Andreas Beeker [Fri, 25 Dec 2020 19:58:32 +0000 (19:58 +0000)]
try to fix gradle sonarqube job

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884804 13f79535-47bb-0310-9956-ffa450edef68

3 years agotry to fix gradle sonarqube job
Andreas Beeker [Fri, 25 Dec 2020 19:19:32 +0000 (19:19 +0000)]
try to fix gradle sonarqube job

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884803 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[bug-65023] add col bugfix. Thanks to Paula Muldoon, This closes #212
PJ Fanning [Fri, 25 Dec 2020 09:50:50 +0000 (09:50 +0000)]
[bug-65023] add col bugfix. Thanks to Paula Muldoon, This closes #212

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884794 13f79535-47bb-0310-9956-ffa450edef68

3 years agoupgrade pdfbox and pdfbox-graphics2d
Andreas Beeker [Fri, 25 Dec 2020 01:59:24 +0000 (01:59 +0000)]
upgrade pdfbox and pdfbox-graphics2d

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884786 13f79535-47bb-0310-9956-ffa450edef68

3 years agotry to fix distsourcebuild error
Andreas Beeker [Fri, 25 Dec 2020 01:42:10 +0000 (01:42 +0000)]
try to fix distsourcebuild error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884785 13f79535-47bb-0310-9956-ffa450edef68

3 years ago#65026 - Migrate tests to Junit 5
Andreas Beeker [Thu, 24 Dec 2020 18:42:29 +0000 (18:42 +0000)]
#65026 - Migrate tests to Junit 5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884783 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdd initial Github Actions to build PRs with all three build-systems
Dominik Stadler [Sun, 20 Dec 2020 18:48:00 +0000 (18:48 +0000)]
Add initial Github Actions to build PRs with all three build-systems

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884654 13f79535-47bb-0310-9956-ffa450edef68

3 years agoFix NullPointerException in Autosize introduced via #64981
Dominik Stadler [Sun, 20 Dec 2020 18:47:56 +0000 (18:47 +0000)]
Fix NullPointerException in Autosize introduced via #64981

Only happened when alignment is set
Add a test reproducing the problem
Also verify auto-size on SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884653 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[github-198] Remove jdk.charset module dependency for spreadsheets generation. Thanks...
PJ Fanning [Sat, 19 Dec 2020 19:45:09 +0000 (19:45 +0000)]
[github-198] Remove jdk.charset module dependency for spreadsheets generation. Thanks to Robert Marcano. This closes #198

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884631 13f79535-47bb-0310-9956-ffa450edef68

3 years agorevert accidental change
PJ Fanning [Sat, 19 Dec 2020 09:49:23 +0000 (09:49 +0000)]
revert accidental change

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884624 13f79535-47bb-0310-9956-ffa450edef68

3 years agofix log text
PJ Fanning [Sat, 19 Dec 2020 09:47:19 +0000 (09:47 +0000)]
fix log text

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884623 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd slf4j dependency
PJ Fanning [Fri, 18 Dec 2020 10:04:01 +0000 (10:04 +0000)]
add slf4j dependency

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884603 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd missing license
PJ Fanning [Fri, 18 Dec 2020 00:25:46 +0000 (00:25 +0000)]
add missing license

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884584 13f79535-47bb-0310-9956-ffa450edef68

3 years agoavoid string concats
PJ Fanning [Fri, 18 Dec 2020 00:17:50 +0000 (00:17 +0000)]
avoid string concats

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884581 13f79535-47bb-0310-9956-ffa450edef68

3 years ago#64876 - Unable to convert pptx to pdf
Andreas Beeker [Thu, 17 Dec 2020 23:42:26 +0000 (23:42 +0000)]
#64876 - Unable to convert pptx to pdf

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884578 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[github-208] Fix a few instances of incorrect NotImplemented documentation. Thanks...
PJ Fanning [Thu, 17 Dec 2020 22:05:35 +0000 (22:05 +0000)]
[github-208] Fix a few instances of incorrect NotImplemented documentation. Thanks to Marius Volkhart. This closes #208

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884575 13f79535-47bb-0310-9956-ffa450edef68

3 years agoavoid string concats
PJ Fanning [Thu, 17 Dec 2020 21:54:42 +0000 (21:54 +0000)]
avoid string concats

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884574 13f79535-47bb-0310-9956-ffa450edef68

3 years agoavoid string concats
PJ Fanning [Thu, 17 Dec 2020 21:42:19 +0000 (21:42 +0000)]
avoid string concats

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884573 13f79535-47bb-0310-9956-ffa450edef68