Merge pull request #33458 from nextcloud/object-store-validate-write

allow disabling object store write check

Merge pull request #33488 from nextcloud/dependabot/npm_and_yarn/testing-library/user-event-14.4.3

Bump @testing-library/user-event from 14.1.1 to 14.4.3

test disabling write check

Signed-off-by: Robin Appelman <robin@icewind.nl>

allow disabling object store write check

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #34825 from nextcloud/fix/noid/comments-empty-content

Fix empty content regressions in comments app

Merge pull request #34789 from nextcloud/fix/pre-commit-exclude-composer-autoload-from-codestyle

Do not apply codestyle to composer autoloaders

Fix empty content regressions in comments app

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #34788 from nextcloud/bugfix/noid/preview-attributes

Merge pull request #34809 from nextcloud/artonge/fix/getMetadata_return_type

Fix getMetadata return type

Merge pull request #34804 from nextcloud/bugfix/noid/ldap-login-filter-no-mail

Skip general login with email for non-valid addresses and LDAP

Skip general login with email for non-valid addresses and LDAP

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix getMetadata return type

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #34776 from nextcloud/enh/noid/improve-browser-warning

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Compile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Address review

Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>

update browser warning

Signed-off-by: szaimen <szaimen@e.mail.de>

Merge pull request #34691 from nextcloud/profiler/ldap-backtrace

Add backtrace to ldap profiler collector

Check share attributes on preview endpoints

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #34774 from nextcloud/fix/fair-use-ldap-fix

Expose mapped user count from LDAP and use that for user limit check

Do not apply codestyle to composer autoloaders

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix autoloaders

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Update lib/public/User/Backend/ICountMappedUsersBackend.php

Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #34756 from nextcloud/revert-33087-fix/30282/external-storages

Revert "fix external storages access"

Merge pull request #34706 from nextcloud/enh/noid/improve-one-click-instance-notification

update notifications for one-click instances

update notifications for one-click instances

Signed-off-by: szaimen <szaimen@e.mail.de>

Add missing file

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Expose mapped user count from LDAP and use that for user limit check

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #34742 from nextcloud/add_well-known_changepassword

Add .well-known/changepassword handler

Merge pull request #34740 from nextcloud/fix/image/x-icon

Add ico image/x-icon

Merge pull request #34626 from nextcloud/enhancement/rename-personal-groupware-settings-section-availability

Rename personal Groupware settings section to "Availability"

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Revert "fix external storages access"

Signed-off-by: szaimen <szaimen@e.mail.de>

Merge pull request #33087 from nextcloud/fix/30282/external-storages

fix external storages access

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Add .well-known/changepassword handler

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Sort alphabetically

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Add ico image/x-icon

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #33945 from nextcloud/fix/noid/fair-use-ldap

LDAP to not register new users when outside of fair use or over limits

Merge pull request #34136 from nextcloud/fix/default-channel

on installation save channel to config.php if not stable

Merge pull request #34579 from nextcloud/unencrypted-size-null

fix null error in getUnencryptedSize

Merge pull request #34662 from nextcloud/enh/error-pages

Use proper error pages instead of always redirecting

Merge pull request #34508 from starypatyk/dav_displayname

WebDAV - use file/folder name for dav:displayname

silence psalm

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Use proper error pages instead of always redirecting

Signed-off-by: Julius Härtl <jus@bitgrid.net>

on installation save channel to config.php if not stable

- the default channel to the NC server is what is provided in /version.php
  unless it is overridden in config.php
- the default channel to the NC Updater however is 'stable'
- this resultant in inconsistent results and confusing admin experience
- therefore "stable" is considered default and other channels are being
  written to config.php now upon installation

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #34717 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

extended hint message

Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: blizzz <blizzz@arthur-schiwon.de>

Merge pull request #34714 from nextcloud/fix/invert-more-icon

Fix more icon color

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix more icon color

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #34688 from nextcloud/bugfix/34673/dont-crash-with-outdated-share-providers

Don't crash with outdated share provider on update with the web updater

Merge pull request #34703 from nextcloud/bugfix/noid/use-vue-lib-multiselect-tags-component

Merge pull request #34685 from nextcloud/fix-alt-login-class

Fix alternative logins custom css class

Recompile

Signed-off-by: Joas Schilling <coding@schilljs.com>

Use @nextcloud/vue MultiselectTags component

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #34502 from nextcloud/fix/correct-attribute-resharing

Propagate attributes when resharing

Add backtrace to ldap profiler collector

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #34624 from nextcloud/fix/files_external_psalm

Multiple fix for files external

Merge pull request #30223 from nextcloud/nested_ldap_groups

Nested ldap groups

Merge pull request #33703 from nextcloud/fix/ldap-simplify-paged-results

Clean up paged result handling.

Fix psalm

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Check if cache is present with isset

Otherwise we get false for empty array

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Bring back small fixes by Carl

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix LDAP recursive nested group support

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Revert Carl changes on apps/user_ldap/lib/Group_LDAP.php

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Fix autoload

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Cleanup typing and improve logging

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix ldap_parse_result call

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Adapt interface to new search signature

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Pass paging information directly to search and get rid of adapter

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Renamed ambiguous $limit parameter to pageSize

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Unfold call to ldap_parse_result. Handle cookie outside of adapter.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Do not init a paged search for read operations

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Remove useless getReadArgs/setReadArgs methods from PagedResults

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Remove dead code in paged result handling

There is only one paged result API now that PHP 7.2 is long dead.
Starting by removing empty function calls.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix user_ldap tests

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Add back runtime cache for intermediate ldap read results

This is a small optimization that save a few LDAP queries

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Only cache base inGroup search

And not intermediate search for nested groups, this is causing issues
othewise with nested groups

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Add missing copyright author in Group_LDAP

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Removed unused use declaration

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix types in docblocks

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Add testing of nested group membership

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Refactor group membership listing for nested groups

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Add tests for nested groups

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Small optimisation of _groupMembers

This will not change the result as users are check to be existing
 afterwards but avoids this check when we know it’s a group.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Refactor _groupMembers to correctly use cache on intermediate results

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix merging list with null

This fixes some cases observed with the debugger where we end up merging
a non empty list with null. The result is then null and the looping over
the items would then end.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Unify a bit the types of the fetcher

Now it will only accept a string as parameter instead of either a string
(DN) or a array (complete record).

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Add more type hinting

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Cache intermediates

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Co-authored-by: Carl Schwan <carl@carlschwan.eu>

Refactor code to split common loop

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Make it possible to return nested records whem walking over groups

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Fix PHP CS

Signed-off-by: Joas Schilling <coding@schilljs.com>

Also catch in getProvider

Signed-off-by: Joas Schilling <coding@schilljs.com>

Don't crash with outdated share provider

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix alternative logins custom css class

In NC 25 login page was changed, and alternative login css class get from `class` prop but not `style`.
It is correct change in my opinion, so just add backend fix.

Signed-off-by: zorn-v <zorn7@yandex.ru>