]> source.dussan.org Git - nextcloud-server.git/log
nextcloud-server.git
4 years agoAdd setup check that links to the migration documentation
Morris Jobke [Wed, 12 Aug 2020 13:16:33 +0000 (15:16 +0200)]
Add setup check that links to the migration documentation

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoMake legacy cipher opt in
Roeland Jago Douma [Wed, 12 Aug 2020 11:22:24 +0000 (13:22 +0200)]
Make legacy cipher opt in

* Systems that upgrade have this enabled by default
* New systems disable it
* We'll have to add some wargning in the setup checks if this is enabled

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years agoMerge pull request #22299 from nextcloud/enh/noid/show-disabled-user-count-in-userreport
Roeland Jago Douma [Wed, 19 Aug 2020 09:23:27 +0000 (11:23 +0200)]
Merge pull request #22299 from nextcloud/enh/noid/show-disabled-user-count-in-userreport

Show disabled user count in occ user:report

4 years agoMerge pull request #22297 from nextcloud/feature/15929/allow-to-disable-share-emails
Joas Schilling [Wed, 19 Aug 2020 07:50:42 +0000 (09:50 +0200)]
Merge pull request #22297 from nextcloud/feature/15929/allow-to-disable-share-emails

Allow to disable share emails

4 years agoShow disabled user count in occ user:report 22299/head
Morris Jobke [Wed, 19 Aug 2020 07:31:41 +0000 (09:31 +0200)]
Show disabled user count in occ user:report

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoAllow to disable share emails 22297/head
Joas Schilling [Wed, 19 Aug 2020 07:03:58 +0000 (09:03 +0200)]
Allow to disable share emails

Signed-off-by: Joas Schilling <coding@schilljs.com>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 19 Aug 2020 02:17:11 +0000 (02:17 +0000)]
[tx-robot] updated from transifex

4 years agoMerge pull request #22285 from nextcloud/techdebt/noid/move-to-typed-event-in-list.php
Morris Jobke [Tue, 18 Aug 2020 19:29:48 +0000 (21:29 +0200)]
Merge pull request #22285 from nextcloud/techdebt/noid/move-to-typed-event-in-list.php

Use dispatchTyped instead of dispatch on the new event dispatcher

4 years agoUse dispatchTyped instead of dispatch on the new event dispatcher 22285/head
Morris Jobke [Tue, 18 Aug 2020 14:25:19 +0000 (16:25 +0200)]
Use dispatchTyped instead of dispatch on the new event dispatcher

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoMerge pull request #22291 from nextcloud/bugfix/22117/fix-activity-tests-again
Roeland Jago Douma [Tue, 18 Aug 2020 18:00:30 +0000 (20:00 +0200)]
Merge pull request #22291 from nextcloud/bugfix/22117/fix-activity-tests-again

Fix activity tests again

4 years agoFix activity tests again 22291/head
Joas Schilling [Tue, 18 Aug 2020 16:21:03 +0000 (18:21 +0200)]
Fix activity tests again

Signed-off-by: Joas Schilling <coding@schilljs.com>
4 years agoMerge pull request #22287 from nextcloud/techdebt/22236/update-psalm-baseline
Morris Jobke [Tue, 18 Aug 2020 15:01:59 +0000 (17:01 +0200)]
Merge pull request #22287 from nextcloud/techdebt/22236/update-psalm-baseline

Update psalm baseline due to fixes in #22236

4 years agoUpdate psalm baseline due to fixes in #22236 22287/head
Morris Jobke [Tue, 18 Aug 2020 14:49:36 +0000 (16:49 +0200)]
Update psalm baseline due to fixes in #22236

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoMerge pull request #22236 from nextcloud/bugfix/noid/dav_sharing_backend_canWrite_isOwner
Morris Jobke [Tue, 18 Aug 2020 14:48:43 +0000 (16:48 +0200)]
Merge pull request #22236 from nextcloud/bugfix/noid/dav_sharing_backend_canWrite_isOwner

CalDAV: Add ability to limit sharing to owner

4 years agoMerge pull request #21787 from nextcloud/enh/hello-psalm
Morris Jobke [Tue, 18 Aug 2020 11:38:03 +0000 (13:38 +0200)]
Merge pull request #21787 from nextcloud/enh/hello-psalm

Hello psalm

4 years agoAdd ability to limit sharing to owner 22236/head
Georg Ehrke [Tue, 11 Aug 2020 07:24:08 +0000 (09:24 +0200)]
Add ability to limit sharing to owner

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
4 years agoCheck only the baseline.xml and exclude the psalm.xml from the file check 21787/head
Morris Jobke [Tue, 18 Aug 2020 10:37:53 +0000 (12:37 +0200)]
Check only the baseline.xml and exclude the psalm.xml from the file check

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoAdd patches for stubs
Morris Jobke [Tue, 18 Aug 2020 09:24:44 +0000 (11:24 +0200)]
Add patches for stubs

* https://github.com/JetBrains/phpstorm-stubs/pull/893
* https://github.com/JetBrains/phpstorm-stubs/pull/894
* https://github.com/JetBrains/phpstorm-stubs/pull/895
* https://github.com/JetBrains/phpstorm-stubs/pull/896

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoAdd stubs for gd, intl, IntlChar, ldap, redis_cluster and xsl
Morris Jobke [Tue, 18 Aug 2020 08:10:38 +0000 (10:10 +0200)]
Add stubs for gd, intl, IntlChar, ldap, redis_cluster and xsl

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoAdd a check for fixes in the psalm baseline
Morris Jobke [Tue, 18 Aug 2020 07:09:59 +0000 (09:09 +0200)]
Add a check for fixes in the psalm baseline

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoAdd psalm baseline
Morris Jobke [Tue, 18 Aug 2020 07:02:31 +0000 (09:02 +0200)]
Add psalm baseline

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoMerge pull request #22195 from nextcloud/design/accessibility-highcontrast-class
John Molakvoæ [Tue, 18 Aug 2020 07:01:04 +0000 (09:01 +0200)]
Merge pull request #22195 from nextcloud/design/accessibility-highcontrast-class

Add highcontrast class to body just like with dark theme

4 years agoSuppress warning for template functions.
Daniel Kesselberg [Fri, 14 Aug 2020 14:18:23 +0000 (16:18 +0200)]
Suppress warning for template functions.

https://github.com/nextcloud/server/blob/6e8e34fef920a073118c22111f0f31eb3b3a91dc/lib/private/legacy/template/functions.php
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoFix variable name for referenced variable.
Daniel Kesselberg [Fri, 14 Aug 2020 14:06:33 +0000 (16:06 +0200)]
Fix variable name for referenced variable.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoSupress UndefinedGlobalVariable for register_command.php
Daniel Kesselberg [Fri, 14 Aug 2020 12:37:05 +0000 (14:37 +0200)]
Supress UndefinedGlobalVariable for register_command.php

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoRemove directory/file element.
Daniel Kesselberg [Fri, 14 Aug 2020 12:31:31 +0000 (14:31 +0200)]
Remove directory/file element.

It will suppress any error of that kind in the file. That was not intended.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoSuppress warning for $_ and $l
Daniel Kesselberg [Mon, 10 Aug 2020 20:25:51 +0000 (22:25 +0200)]
Suppress warning for $_ and $l

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoExclude stubs from code style check
Daniel Kesselberg [Wed, 15 Jul 2020 20:38:09 +0000 (22:38 +0200)]
Exclude stubs from code style check

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoFix: UndefinedFunction Function x does not exist in templates
Daniel Kesselberg [Fri, 10 Jul 2020 12:08:32 +0000 (14:08 +0200)]
Fix: UndefinedFunction Function x does not exist in templates

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoAdd psalm as composer dependency
Daniel Kesselberg [Fri, 10 Jul 2020 11:48:46 +0000 (13:48 +0200)]
Add psalm as composer dependency

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoAdd template functions
Daniel Kesselberg [Fri, 10 Jul 2020 11:44:29 +0000 (13:44 +0200)]
Add template functions

for some reason they are not loaded by default.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoAdd stubs for phpseclib
Daniel Kesselberg [Fri, 10 Jul 2020 10:30:38 +0000 (12:30 +0200)]
Add stubs for phpseclib

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoHello psalm
Daniel Kesselberg [Fri, 10 Jul 2020 08:58:33 +0000 (10:58 +0200)]
Hello psalm

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoAdd highcontrast class to body just like with dark theme 22195/head
Jan C. Borchardt [Tue, 11 Aug 2020 14:22:43 +0000 (16:22 +0200)]
Add highcontrast class to body just like with dark theme

Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
4 years agoMerge pull request #22244 from nextcloud/fix/16876/better_fetch_recent
Roeland Jago Douma [Tue, 18 Aug 2020 05:09:30 +0000 (07:09 +0200)]
Merge pull request #22244 from nextcloud/fix/16876/better_fetch_recent

Improve recent file fetching

4 years agoImprove recent file fetching 22244/head
Roeland Jago Douma [Fri, 14 Aug 2020 06:06:53 +0000 (08:06 +0200)]
Improve recent file fetching

Fixes #16876

Before we'd just fetch everything from all storages we'd have access to.
Then we'd sort. And filter in php. Now this of course is tricky if a
user shared just a file with you and then has a ton of activity.

Now we try to contruct the prefix path. So that the filtering can happen
right away in the databae.

Now this will make the DB more busy. But it should help overall as in
most cases less queries are needed then etc.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 18 Aug 2020 02:17:28 +0000 (02:17 +0000)]
[tx-robot] updated from transifex

4 years agoMerge pull request #22273 from nextcloud/bugfix/noid/status-nonexisting-icon
John Molakvoæ [Mon, 17 Aug 2020 20:18:43 +0000 (22:18 +0200)]
Merge pull request #22273 from nextcloud/bugfix/noid/status-nonexisting-icon

Do not try to load non-existing icon

4 years agoMerge pull request #22109 from nextcloud/feature/20931/followup-1
John Molakvoæ [Mon, 17 Aug 2020 20:13:45 +0000 (22:13 +0200)]
Merge pull request #22109 from nextcloud/feature/20931/followup-1

4 years agoLimit custom message input to 80 chars 22109/head
Georg Ehrke [Wed, 12 Aug 2020 11:02:41 +0000 (13:02 +0200)]
Limit custom message input to 80 chars

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
4 years agoDisplay user-status in sharing list
Georg Ehrke [Fri, 14 Aug 2020 15:03:57 +0000 (17:03 +0200)]
Display user-status in sharing list

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
4 years agoMerge pull request #22271 from nextcloud/phpdoc/22063/add-interface-method-and-phpdoc
Roeland Jago Douma [Mon, 17 Aug 2020 17:34:56 +0000 (19:34 +0200)]
Merge pull request #22271 from nextcloud/phpdoc/22063/add-interface-method-and-phpdoc

Properly add new methods to interface and document in PHPDoc for getR…

4 years agoMerge pull request #22272 from nextcloud/phpdoc/21787/fix-misplaced-variable-phpdoc
blizzz [Mon, 17 Aug 2020 17:01:06 +0000 (19:01 +0200)]
Merge pull request #22272 from nextcloud/phpdoc/21787/fix-misplaced-variable-phpdoc

Fix "misplaced variables" warning of Psalm in PHPDoc statements

4 years agoDo not try to load non-existing icon 22273/head
Julius Härtl [Mon, 17 Aug 2020 16:25:16 +0000 (18:25 +0200)]
Do not try to load non-existing icon

Signed-off-by: Julius Härtl <jus@bitgrid.net>
4 years agoMerge pull request #21861 from nextcloud/techdebt/files-psr-container
Morris Jobke [Mon, 17 Aug 2020 15:58:41 +0000 (17:58 +0200)]
Merge pull request #21861 from nextcloud/techdebt/files-psr-container

Migrate files to the PSR container

4 years agoFix "misplaced variables" warning of Psalm in PHPDoc statements 22272/head
Morris Jobke [Mon, 17 Aug 2020 15:16:50 +0000 (17:16 +0200)]
Fix "misplaced variables" warning of Psalm in PHPDoc statements

Ref #21787

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoMerge pull request #22253 from nextcloud/debt/noid/docblocks
Morris Jobke [Mon, 17 Aug 2020 15:45:11 +0000 (17:45 +0200)]
Merge pull request #22253 from nextcloud/debt/noid/docblocks

Fix some MissingDocblockType or InvalidDocblock warnings.

4 years agoProperly add new methods to interface and document in PHPDoc for getRootMounts() 22271/head
Morris Jobke [Mon, 17 Aug 2020 15:13:41 +0000 (17:13 +0200)]
Properly add new methods to interface and document in PHPDoc for getRootMounts()

Introduced in #22063 and was just forgotten.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoFix TagService DI name 21861/head
Morris Jobke [Mon, 17 Aug 2020 14:55:16 +0000 (16:55 +0200)]
Fix TagService DI name

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoMigrate files to the PSR container
Christoph Wurst [Thu, 16 Jul 2020 08:26:41 +0000 (10:26 +0200)]
Migrate files to the PSR container

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years agoMerge pull request #22262 from nextcloud/dependabot/npm_and_yarn/sinon-9.0.3
dependabot-preview[bot] [Mon, 17 Aug 2020 06:24:34 +0000 (06:24 +0000)]
Merge pull request #22262 from nextcloud/dependabot/npm_and_yarn/sinon-9.0.3

4 years agoMerge pull request #22261 from nextcloud/dependabot/npm_and_yarn/jsdom-16.4.0
Roeland Jago Douma [Mon, 17 Aug 2020 04:43:10 +0000 (06:43 +0200)]
Merge pull request #22261 from nextcloud/dependabot/npm_and_yarn/jsdom-16.4.0

Bump jsdom from 16.3.0 to 16.4.0

4 years agoMerge pull request #22260 from nextcloud/dependabot/npm_and_yarn/lodash-4.17.20
Roeland Jago Douma [Mon, 17 Aug 2020 04:42:27 +0000 (06:42 +0200)]
Merge pull request #22260 from nextcloud/dependabot/npm_and_yarn/lodash-4.17.20

Bump lodash from 4.17.19 to 4.17.20

4 years agoBump lodash from 4.17.19 to 4.17.20 22260/head
dependabot-preview[bot] [Sat, 15 Aug 2020 02:36:03 +0000 (02:36 +0000)]
Bump lodash from 4.17.19 to 4.17.20

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.19...4.17.20)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 17 Aug 2020 02:16:39 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 16 Aug 2020 02:16:28 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoBump sinon from 9.0.2 to 9.0.3 22262/head
dependabot-preview[bot] [Sat, 15 Aug 2020 02:38:21 +0000 (02:38 +0000)]
Bump sinon from 9.0.2 to 9.0.3

Bumps [sinon](https://github.com/sinonjs/sinon) from 9.0.2 to 9.0.3.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v9.0.2...v9.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
4 years agoBump jsdom from 16.3.0 to 16.4.0 22261/head
dependabot-preview[bot] [Sat, 15 Aug 2020 02:37:38 +0000 (02:37 +0000)]
Bump jsdom from 16.3.0 to 16.4.0

Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.3.0 to 16.4.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](https://github.com/jsdom/jsdom/compare/16.3.0...16.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 15 Aug 2020 02:17:13 +0000 (02:17 +0000)]
[tx-robot] updated from transifex

4 years agoFix more MissingDocblockType or InvalidDocblock warnings. 22253/head
Daniel Kesselberg [Fri, 14 Aug 2020 18:19:23 +0000 (20:19 +0200)]
Fix more MissingDocblockType or InvalidDocblock warnings.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoMerge pull request #22257 from nextcloud/debt/noid/add-parameter-to-set
Morris Jobke [Fri, 14 Aug 2020 18:15:16 +0000 (20:15 +0200)]
Merge pull request #22257 from nextcloud/debt/noid/add-parameter-to-set

Update documentation for QueryBuilder::set

4 years agoUpdate documentation for QueryBuilder::set 22257/head
Daniel Kesselberg [Fri, 14 Aug 2020 17:55:01 +0000 (19:55 +0200)]
Update documentation for QueryBuilder::set

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoExpose status via Collaborators API
Georg Ehrke [Wed, 5 Aug 2020 08:37:20 +0000 (10:37 +0200)]
Expose status via Collaborators API

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
4 years agoMerge pull request #22221 from nextcloud/fix/19097/ldap-depracted-event
blizzz [Fri, 14 Aug 2020 14:07:12 +0000 (16:07 +0200)]
Merge pull request #22221 from nextcloud/fix/19097/ldap-depracted-event

provide event class and typed event to LDAP loaded event; also fixing a logged deprecation message

4 years agoMerge pull request #18969 from nextcloud/enh/apps/use-sidebar
Morris Jobke [Fri, 14 Aug 2020 13:44:04 +0000 (15:44 +0200)]
Merge pull request #18969 from nextcloud/enh/apps/use-sidebar

Migrate app management settings to proper sidebar standards

4 years agoFix some MissingDocblockType or InvalidDocblock warnings.
Daniel Kesselberg [Fri, 14 Aug 2020 13:10:48 +0000 (15:10 +0200)]
Fix some MissingDocblockType or InvalidDocblock warnings.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoUse appsidebar for apps 18969/head
John Molakvoæ (skjnldsv) [Thu, 9 Apr 2020 10:58:05 +0000 (12:58 +0200)]
Use appsidebar for apps

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
4 years agoUse appsidebar for apps
John Molakvoæ (skjnldsv) [Sat, 18 Jan 2020 09:21:27 +0000 (10:21 +0100)]
Use appsidebar for apps

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
4 years agoMerge pull request #22243 from nextcloud/fix/20490/no_session_duplicate_warnings
Morris Jobke [Fri, 14 Aug 2020 07:22:24 +0000 (09:22 +0200)]
Merge pull request #22243 from nextcloud/fix/20490/no_session_duplicate_warnings

Silence duplicate session warnings

4 years agoMerge pull request #22198 from nextcloud/dependabot/npm_and_yarn/vue-router-3.4.3
dependabot-preview[bot] [Fri, 14 Aug 2020 06:02:44 +0000 (06:02 +0000)]
Merge pull request #22198 from nextcloud/dependabot/npm_and_yarn/vue-router-3.4.3

4 years agoBump vue-router from 3.3.4 to 3.4.3 22198/head
dependabot-preview[bot] [Fri, 14 Aug 2020 05:07:37 +0000 (05:07 +0000)]
Bump vue-router from 3.3.4 to 3.4.3

Bumps [vue-router](https://github.com/vuejs/vue-router) from 3.3.4 to 3.4.3.
- [Release notes](https://github.com/vuejs/vue-router/releases)
- [Changelog](https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-router/compare/v3.3.4...v3.4.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
4 years agoMerge pull request #22200 from cweiske/duplicated-sql-where-line
Roeland Jago Douma [Fri, 14 Aug 2020 03:43:42 +0000 (05:43 +0200)]
Merge pull request #22200 from cweiske/duplicated-sql-where-line

Remove duplicated SQL addWhere line

4 years agoSilence duplicate session warnings 22243/head
Roeland Jago Douma [Fri, 14 Aug 2020 03:23:11 +0000 (05:23 +0200)]
Silence duplicate session warnings

Fixes #20490

Basically restroring the old behavior.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 14 Aug 2020 02:31:59 +0000 (02:31 +0000)]
[tx-robot] updated from transifex

4 years agoMerge pull request #22242 from nextcloud/techdebt/noid/remove-deprecated-methods
Gary Kim [Fri, 14 Aug 2020 02:10:53 +0000 (10:10 +0800)]
Merge pull request #22242 from nextcloud/techdebt/noid/remove-deprecated-methods

Remove deprecated and unused method calls

4 years agoMerge pull request #20451 from exussum12/AllowPreviewWhenGeneratorHasBeenRemoved
Morris Jobke [Thu, 13 Aug 2020 21:49:56 +0000 (23:49 +0200)]
Merge pull request #20451 from exussum12/AllowPreviewWhenGeneratorHasBeenRemoved

Always try and show pre rendered preview

4 years agoFix existing test and add a specific one for the new case 20451/head
Morris Jobke [Thu, 13 Aug 2020 21:24:21 +0000 (23:24 +0200)]
Fix existing test and add a specific one for the new case

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoAlways try and show pre rendered preview
Scott Dutton [Sun, 12 Apr 2020 15:38:59 +0000 (16:38 +0100)]
Always try and show pre rendered preview

Currently if the following situation happens

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets a 404 error when preview exists
(Mime checked before preview)

This happens more often with documents, or video as the commands are not
native PHP, they require a binary on the server.

After the fix the following would happen

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets preview which has been generated
(Mime checked after preview)

This would also allow offline generation (for example a docker image
containing the extra binaries), allowing a reduction in attack surface
of the instance serving the preview data.

Signed-off-by: Scott Dutton <scott@exussum.co.uk>
4 years agoRemove getLastJob from IJobList 22242/head
Morris Jobke [Thu, 13 Aug 2020 19:50:06 +0000 (21:50 +0200)]
Remove getLastJob from IJobList

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoRemove setCustomJs of the files_external FrontendDefinitionTrait
Morris Jobke [Thu, 13 Aug 2020 19:49:50 +0000 (21:49 +0200)]
Remove setCustomJs of the files_external FrontendDefinitionTrait

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoMerge pull request #22128 from nextcloud/bugfix/noid/cleanup-chunks-on-failure
Morris Jobke [Thu, 13 Aug 2020 18:47:08 +0000 (20:47 +0200)]
Merge pull request #22128 from nextcloud/bugfix/noid/cleanup-chunks-on-failure

Delete chunks if the move on an upload failed

4 years agoReturn proper status when file didn't exist before 22128/head
Julius Härtl [Thu, 13 Aug 2020 13:26:42 +0000 (15:26 +0200)]
Return proper status when file didn't exist before

Signed-off-by: Julius Härtl <jus@bitgrid.net>
4 years agoMerge pull request #22235 from nextcloud/fix/22217/fix-naming-of-app-config-option
Morris Jobke [Thu, 13 Aug 2020 12:49:01 +0000 (14:49 +0200)]
Merge pull request #22235 from nextcloud/fix/22217/fix-naming-of-app-config-option

Fix name of app config option to properly reflect what it does

4 years agoFix name of app config option to properly reflect what it does 22235/head
Morris Jobke [Thu, 13 Aug 2020 11:34:31 +0000 (13:34 +0200)]
Fix name of app config option to properly reflect what it does

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoMerge pull request #22229 from nextcloud/bugfix/noid/dashboard-outdated-bundles
Morris Jobke [Thu, 13 Aug 2020 08:58:54 +0000 (10:58 +0200)]
Merge pull request #22229 from nextcloud/bugfix/noid/dashboard-outdated-bundles

Bump outdated dashboard bundles

4 years agoMerge pull request #22202 from nextcloud/enh/noid/cleanup-servercontainer
Morris Jobke [Thu, 13 Aug 2020 08:55:48 +0000 (10:55 +0200)]
Merge pull request #22202 from nextcloud/enh/noid/cleanup-servercontainer

Use autowiring where possible in server container

4 years agoBump outdated dashboard bundles 22229/head
Julius Härtl [Thu, 13 Aug 2020 08:10:40 +0000 (10:10 +0200)]
Bump outdated dashboard bundles

Signed-off-by: Julius Härtl <jus@bitgrid.net>
4 years agoMerge pull request #21788 from nextcloud/debt/noid/unused-method
Roeland Jago Douma [Thu, 13 Aug 2020 07:40:38 +0000 (09:40 +0200)]
Merge pull request #21788 from nextcloud/debt/noid/unused-method

Remove unused method uploadFile

4 years agoMerge pull request #22205 from nextcloud/activity-settings-cleanup
Morris Jobke [Thu, 13 Aug 2020 06:15:06 +0000 (08:15 +0200)]
Merge pull request #22205 from nextcloud/activity-settings-cleanup

merge file activity settings into a single 'favorite changed' item

4 years agoRemove unused method uploadFile 21788/head
Daniel Kesselberg [Fri, 10 Jul 2020 11:32:31 +0000 (13:32 +0200)]
Remove unused method uploadFile

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
4 years agoAdd @deprecated labels for server DI containter aliases 22202/head
Morris Jobke [Thu, 13 Aug 2020 05:43:37 +0000 (07:43 +0200)]
Add @deprecated labels for server DI containter aliases

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoMerge pull request #21344 from nextcloud/fix/twofactor-cleanup-event
Morris Jobke [Thu, 13 Aug 2020 05:25:01 +0000 (07:25 +0200)]
Merge pull request #21344 from nextcloud/fix/twofactor-cleanup-event

Emit an event for every disabled 2FA provider during cleanup

4 years agoUse registerDeprecatedAlias for non-namespaced aliases
Morris Jobke [Wed, 12 Aug 2020 20:46:32 +0000 (22:46 +0200)]
Use registerDeprecatedAlias for non-namespaced aliases

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years agoUse autowiring where possible in server container
Morris Jobke [Tue, 11 Aug 2020 20:38:14 +0000 (22:38 +0200)]
Use autowiring where possible in server container

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 13 Aug 2020 02:16:38 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agomerge file activity settings into a single 'favorite changed' item 22205/head
Robin Appelman [Tue, 11 Aug 2020 23:43:12 +0000 (01:43 +0200)]
merge file activity settings into a single 'favorite changed' item

Signed-off-by: Robin Appelman <robin@icewind.nl>
4 years agomove share notifcation settings to files group
Robin Appelman [Tue, 11 Aug 2020 22:15:53 +0000 (00:15 +0200)]
move share notifcation settings to files group

Signed-off-by: Robin Appelman <robin@icewind.nl>
4 years agoMerge pull request #22206 from nextcloud/enh/noid/tests-recent-contact-mapper
Morris Jobke [Wed, 12 Aug 2020 19:09:18 +0000 (21:09 +0200)]
Merge pull request #22206 from nextcloud/enh/noid/tests-recent-contact-mapper

Add some tests for RecentContactMapper

4 years agoMerge pull request #22217 from nextcloud/enh/noid/disable-admin-changed-email-appconfig
Morris Jobke [Wed, 12 Aug 2020 14:46:00 +0000 (16:46 +0200)]
Merge pull request #22217 from nextcloud/enh/noid/disable-admin-changed-email-appconfig

Add app config option to disable "Email was changed by admin" email

4 years agoprovide event class to LDAP loaded event to fix deprecation message 22221/head
Arthur Schiwon [Wed, 12 Aug 2020 13:07:55 +0000 (15:07 +0200)]
provide event class to LDAP loaded event to fix deprecation message

* and also dispatch the typed event as current approach to it

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>