Marco Collovati [Wed, 20 Sep 2017 05:32:04 +0000 (07:32 +0200)]
Show validation error selecting invalid date from DateField (#10013)
Component error was cleared after selecting a date from
calendar popup, even if the date is invalid due to
validation errors or if user programmatically sets an UserError.
This change inverts the order of setValue() and setComponentError(null) in order
to preserve errors set by ValueChangeListeners (e.g. Binder validators).
Dos Moonen [Mon, 11 Sep 2017 10:18:05 +0000 (12:18 +0200)]
Fix incorrect resource name generation (#9957)
Javadoc has this to say about ClassLoader#getResource(String): "The name of a resource is a '/'-separated path name that identifies the resource."
The test fails on Windows because its File.separator does not equal "/".
Adam Wagner [Mon, 11 Sep 2017 09:02:20 +0000 (12:02 +0300)]
Remove element explicitly when reordering tree grid rows (#9952)
Under certain circumstances IE 11 (11.0.45 / 11.0.9600.18762) produces an exception when collapsing/expanding rows (particularly the first child after the very first element) in a TreeGrid within a Window.
This workaround removes the row explicitly before inserting, instead of letting JS handle it.
Henri Sara [Thu, 31 Aug 2017 06:08:10 +0000 (09:08 +0300)]
Make BaseThemeTest more stable on IE11
Try to make the test more stable by using a different way of
detecting the presence of a notification. This approach is used e.g.
in GridComponentsTest.
Henri Sara [Wed, 23 Aug 2017 11:06:00 +0000 (14:06 +0300)]
Avoid detaching VL/HL children unnecessarily (#9862)
When child components are removed from a
VerticalLayout/HorizontalLayout, do not remove other children from the
DOM if no other hierarchy changes are made.
Henri Sara [Wed, 16 Aug 2017 12:42:03 +0000 (15:42 +0300)]
Add docker feature to demo build script (#9828)
This patch allows the demo build script to wrap the resulting war files into docker image. The image contains a jetty with the provided war files deployed on start.
Artur [Fri, 11 Aug 2017 13:07:51 +0000 (16:07 +0300)]
Do not wait for icons to load before interacting with a combo box (#9717)
Icon load detection code does not handle error events so broken images
will cause tests to fail forever. In other cases also, it seems very
rare to need icons to be loaded before interacting with a combo box. If
there really are use cases for this, it would be better to have a method
to query if all icons are loaded so that special tests can use this method.
Henri Sara [Fri, 11 Aug 2017 08:09:58 +0000 (11:09 +0300)]
Make CurrentTimeMillisTest more stable (#9812)
Sometimes Chrome reports 1ms for very short times to thwart
timing attacks, and sometimes Firefox seems to report 0ms. Make
the test accept these special cases.
Add support for PhantomJS 2 which does support high res time.
Henri Sara [Wed, 9 Aug 2017 11:28:17 +0000 (14:28 +0300)]
Fix occasional empty rows in Table and TreeTable (#9800)
Picked from #9551 in 7.7
There's an intermittently happening issue with both Table and TreeTable,
which results in row data disappearing.
This change removes a method which is probably a vestigial one from over
five years ago and other changes are handling the things the method used
to perform. Currently the method removes rows deemed unnecessary from
the row buffer. The problem is, those rows are visible to the user and
removing causes row contents to be lost.
Also included are manually runnable test cases which demonstrate that
this removal actually prevents the issue from happening.
Grim [Wed, 9 Aug 2017 08:43:07 +0000 (08:43 +0000)]
Re(set) calendar time after calculating rollAmount (#9479)
by calling calendar.setTime(today);
after rollAmount has been initialized and given a value, we can reset the calendar's internal time back to the correct date. As it is currently implemented; calling calendar.getTime() will result in a wrong date, it returns the first of the month with the correct time.
The function addInitialEvents() is called AFTER the calendar's time has been subtracted from (by calculating the rollAmount), as such this results in an incorrect internal time and the 'Day' button does not switch to the correct day. Instead it shows the first of the month here too.
Martin Vysny [Tue, 8 Aug 2017 12:39:15 +0000 (15:39 +0300)]
Fix touching Grid column header on Android (#9196)
The fix allows both column-reorder handler and column-sort handlers to run
in parallel; on touchend it is decided whether we will perform sort or
reodering. This will enable user to sort on touch screens even with column
reordering enabled.
Henri Sara [Mon, 7 Aug 2017 07:05:44 +0000 (10:05 +0300)]
Exclude Firefox from JavaScriptPreloadingTest (#9784)
The test works on Firefox under low load, but not when
the browser VM is slow due to load, in which case Firefox
sometimes executes scripts out of order. This seems to be
due to a Firefox bug - the generated HTML looks correct.
Fix RadioButtonGroup selection updates to client (#9749)
This patch provides a simple fix for the majority of issues. There are still issues that should be fixes by refactoring parts of the logic in AbstractSingleSelect.
This patch does not unify the handling of empty values in the TestBench elements of various AbstractSingleSelects.
projects / vaadin-framework.git / log