]> source.dussan.org Git - gitblit.git/log
gitblit.git
10 years agodoAuthenticate() method doesn't need to be protected
David Ostrovsky [Wed, 19 Mar 2014 07:38:07 +0000 (08:38 +0100)]
doAuthenticate() method doesn't need to be protected

10 years agoBe more verbose on gathering plugin's extension points
David Ostrovsky [Wed, 19 Mar 2014 07:11:51 +0000 (08:11 +0100)]
Be more verbose on gathering plugin's extension points

10 years agoDispatchCommand should be the ExtensionPoint
James Moger [Tue, 18 Mar 2014 21:40:35 +0000 (17:40 -0400)]
DispatchCommand should be the ExtensionPoint

10 years agoHook-up comprensive command cleanup (destroy)
James Moger [Tue, 18 Mar 2014 21:34:01 +0000 (17:34 -0400)]
Hook-up comprensive command cleanup (destroy)

10 years agoGet the command context with an accessor instead of direct field access
James Moger [Tue, 18 Mar 2014 21:25:17 +0000 (17:25 -0400)]
Get the command context with an accessor instead of direct field access

10 years agoStyle: changed manager order to reflect dependency chain
James Moger [Tue, 18 Mar 2014 21:21:47 +0000 (17:21 -0400)]
Style: changed manager order to reflect dependency chain

Managers are mostly declared in dependency order.  Managers with fewer dependencies are first.  They are likely to be components of other managers. Also eliminated import artifacts from the cherry-pick.

10 years agoExpose SSH command as plugin extension point
David Ostrovsky [Tue, 18 Mar 2014 07:33:42 +0000 (08:33 +0100)]
Expose SSH command as plugin extension point

Example plugin is provided [1].

[1] https://github.com/davido/gitblit-cookbook-plugin

10 years agoAdd plugins/extension infrastructure
David Ostrovsky [Mon, 10 Mar 2014 00:50:49 +0000 (01:50 +0100)]
Add plugins/extension infrastructure

Plugins are stored in `${baseFolder}/plugins` and are loaded
during startup by the PluginManager.

A plugin defines it's metadata in META-INF/MANIFEST.MF:

    Plugin-Class: com.gitblit.plugins.cookbook.CookbookPlugin
    Plugin-Dependencies: foo, bar
    Plugin-Id: gitblit-plugin
    Plugin-Provider: John Doe
    Plugin-Version: 1.0

Plugins can define extension points that can be implemented
by other plugins and they can depend on other plugins:

    Plugin-Dependencies: foo, bar

During the load phase, a directed acyclic graph is built and the loading
order of the dependency chain is reversed using a topological sort;
parent followed by children. The parent plugin classloader is the
combined classloader of all parent plugins.

Change-Id: I738821fa2bff02a5dbe339a944cc7e3c4dd8e299

10 years agoRevise dispatchers and move command classes
James Moger [Tue, 18 Mar 2014 02:27:58 +0000 (22:27 -0400)]
Revise dispatchers and move command classes

10 years agoCreate a simple ls-users admin command
James Moger [Tue, 18 Mar 2014 01:54:07 +0000 (21:54 -0400)]
Create a simple ls-users admin command

10 years agoElevate the public key manager to a top-level manager
James Moger [Tue, 18 Mar 2014 01:30:46 +0000 (21:30 -0400)]
Elevate the public key manager to a top-level manager

10 years agoCreate git and gitblit dispatchers
James Moger [Tue, 18 Mar 2014 01:23:44 +0000 (21:23 -0400)]
Create git and gitblit dispatchers

10 years agoShow root commands in welcome shell and improve command registration
James Moger [Tue, 18 Mar 2014 01:07:49 +0000 (21:07 -0400)]
Show root commands in welcome shell and improve command registration

10 years agoAdd a simple repository list command
James Moger [Sun, 16 Mar 2014 20:04:07 +0000 (16:04 -0400)]
Add a simple repository list command

10 years agoPass IGitblit into the SSH command context
James Moger [Sun, 16 Mar 2014 20:02:57 +0000 (16:02 -0400)]
Pass IGitblit into the SSH command context

10 years agoAdd a welcome shell
James Moger [Sun, 16 Mar 2014 19:17:58 +0000 (15:17 -0400)]
Add a welcome shell

Conflicts:
src/main/java/com/gitblit/transport/ssh/SshDaemon.java

10 years agoAdd SSH daemon test
David Ostrovsky [Sun, 16 Mar 2014 21:55:30 +0000 (22:55 +0100)]
Add SSH daemon test

10 years agoPrevent double authentication for the same public key
David Ostrovsky [Sun, 16 Mar 2014 17:28:03 +0000 (18:28 +0100)]
Prevent double authentication for the same public key

Openssh client sends two requests, one without a key signature to verify
that the public key is acceptable and the second one with the signature
after having loaded the private key and signed some data for actual
verification.

To prevent that the PublickeyAuthenticator#authenticate is called twice
cache the authentication status for session and public key.  Implement
SessionListener to clean up the cache entry when session is destroyed.

This is a workaround for SSHD bug [1].

Inspired-By: Guillaume Nodet <gnodet@apache.org>
[1] https://issues.apache.org/jira/browse/SSHD-300

10 years agoFix message formatting
David Ostrovsky [Sat, 15 Mar 2014 07:42:26 +0000 (08:42 +0100)]
Fix message formatting

Change-Id: I1ee1e4135525b7064c4f8e159ed9d8cbef510a81

10 years agoMove dispatcher creation to SshCommandFactory and revise permission
James Moger [Fri, 14 Mar 2014 21:48:23 +0000 (17:48 -0400)]
Move dispatcher creation to SshCommandFactory and revise permission
checks

10 years agoRename server session classes
James Moger [Fri, 14 Mar 2014 19:36:55 +0000 (15:36 -0400)]
Rename server session classes

10 years agoRename AbstractGitCommand->BaseGitCommand
James Moger [Fri, 14 Mar 2014 19:18:24 +0000 (15:18 -0400)]
Rename AbstractGitCommand->BaseGitCommand

10 years agoMerge AbstractSshCommand and BaseCommand into a single class
James Moger [Fri, 14 Mar 2014 19:17:00 +0000 (15:17 -0400)]
Merge AbstractSshCommand and BaseCommand into a single class

10 years agoRename authenticators for clarity
James Moger [Fri, 14 Mar 2014 18:55:38 +0000 (14:55 -0400)]
Rename authenticators for clarity

10 years agoMove cache to IKeyManager and implement isStale() in FileKeyManager
James Moger [Fri, 14 Mar 2014 18:53:26 +0000 (14:53 -0400)]
Move cache to IKeyManager and implement isStale() in FileKeyManager

10 years agoStart SSH usage documentation
James Moger [Fri, 14 Mar 2014 16:55:06 +0000 (12:55 -0400)]
Start SSH usage documentation

10 years agoSupport admin commands that respect user permissions
James Moger [Fri, 14 Mar 2014 16:52:50 +0000 (12:52 -0400)]
Support admin commands that respect user permissions

10 years agoSupport hidden commands and hide create-repo and review
James Moger [Fri, 14 Mar 2014 16:28:24 +0000 (12:28 -0400)]
Support hidden commands and hide create-repo and review

10 years agoAdd add-key and rm-key commands that apply only to the current user
James Moger [Fri, 14 Mar 2014 16:20:45 +0000 (12:20 -0400)]
Add add-key and rm-key commands that apply only to the current user

10 years agoRenamed SshContext->SshCommandContext for clarity of purpose
James Moger [Fri, 14 Mar 2014 16:49:50 +0000 (12:49 -0400)]
Renamed SshContext->SshCommandContext for clarity of purpose

10 years agoRename & simplify SshSession->SshDaemonClient
James Moger [Fri, 14 Mar 2014 16:43:55 +0000 (12:43 -0400)]
Rename & simplify SshSession->SshDaemonClient

10 years agoRevise SSH public key integration with AuthenticationManager
James Moger [Fri, 14 Mar 2014 16:10:25 +0000 (12:10 -0400)]
Revise SSH public key integration with AuthenticationManager

10 years agoSimplify version command and output
James Moger [Fri, 14 Mar 2014 16:15:57 +0000 (12:15 -0400)]
Simplify version command and output

10 years agoDisregard comment/description for add/remove in FileKeyManager
James Moger [Fri, 14 Mar 2014 16:15:04 +0000 (12:15 -0400)]
Disregard comment/description for add/remove in FileKeyManager

10 years agoFix deleteAllKeys method signature
James Moger [Fri, 14 Mar 2014 16:12:26 +0000 (12:12 -0400)]
Fix deleteAllKeys method signature

10 years agoFix incorrect displayed SSH transport permission
James Moger [Fri, 14 Mar 2014 16:11:20 +0000 (12:11 -0400)]
Fix incorrect displayed SSH transport permission

10 years agoRemove unused idGenerator from the SshSessionFactory
James Moger [Fri, 14 Mar 2014 16:54:34 +0000 (12:54 -0400)]
Remove unused idGenerator from the SshSessionFactory

10 years agoDisplay the selected SSH backend in the daemon startup message
James Moger [Fri, 14 Mar 2014 16:53:56 +0000 (12:53 -0400)]
Display the selected SSH backend in the daemon startup message

10 years agoAdd review SSH command
David Ostrovsky [Tue, 11 Mar 2014 23:35:57 +0000 (00:35 +0100)]
Add review SSH command

Change-Id: Ia03c15608814346522c548ff2439ee672ccb0d28

10 years agoAdd set account SSH command
David Ostrovsky [Tue, 11 Mar 2014 20:44:38 +0000 (21:44 +0100)]
Add set account SSH command

Change-Id: I33d343dd34f93eaff9581d54f825f8c486e7c17f

10 years agoAdd support for NIO2 IoSession
David Ostrovsky [Thu, 13 Mar 2014 23:34:50 +0000 (00:34 +0100)]
Add support for NIO2 IoSession

Starting from version 0.9.0 Apache SSHD project added support for NIO2
IoSession. To use the new NIO2 session the `backend` option must be set
to `NIO2`.

By default, `NIO2`.

Change-Id: I06cf92b02e80ecf9e8bfbd9f6d6d623dfe3ccff3

10 years agoBump SSHD version to 0.10.1
David Ostrovsky [Thu, 13 Mar 2014 22:39:26 +0000 (23:39 +0100)]
Bump SSHD version to 0.10.1

Change-Id: Ic7e204fb7ee2eb172f4c8424fc3d4b7e6c631ddd

10 years agoExtract key manager interface and implement a file-based key manager
James Moger [Sun, 9 Mar 2014 03:09:18 +0000 (22:09 -0500)]
Extract key manager interface and implement a file-based key manager

10 years agoListen for ssh clients on all interfaces, by default
James Moger [Sun, 9 Mar 2014 01:48:28 +0000 (20:48 -0500)]
Listen for ssh clients on all interfaces, by default

10 years agoCleanup imports
James Moger [Sun, 9 Mar 2014 01:34:26 +0000 (20:34 -0500)]
Cleanup imports

10 years agoDisplay ssh clone urls in the repository url panel
James Moger [Sun, 9 Mar 2014 01:12:36 +0000 (20:12 -0500)]
Display ssh clone urls in the repository url panel

10 years agoEstablish ssh keys folder, support multiple keys, revise key authenticator
James Moger [Sun, 9 Mar 2014 00:43:15 +0000 (19:43 -0500)]
Establish ssh keys folder, support multiple keys, revise key authenticator

10 years agoRefer to receive pack client requests as 'client'
James Moger [Sun, 9 Mar 2014 01:34:55 +0000 (20:34 -0500)]
Refer to receive pack client requests as 'client'

10 years agoAuthenticate SSH upload pack
James Moger [Sun, 9 Mar 2014 00:10:53 +0000 (19:10 -0500)]
Authenticate SSH upload pack

10 years agoMove Git daemon into different package
James Moger [Sun, 9 Mar 2014 00:10:20 +0000 (19:10 -0500)]
Move Git daemon into different package

10 years agoSSHD: Add support for git pack commands
David Ostrovsky [Sat, 22 Feb 2014 20:17:03 +0000 (21:17 +0100)]
SSHD: Add support for git pack commands

Add git-upload-pack and git-receive-pack commands.

Conflicts:
src/main/java/com/gitblit/manager/ServicesManager.java
src/main/java/com/gitblit/transport/ssh/CommandDispatcher.java
src/main/java/com/gitblit/transport/ssh/SshCommandFactory.java

Change-Id: I8c057b41f1dfad6d004e6aa91f96c8c673be9be2

10 years agoFix command dispatching
David Ostrovsky [Wed, 26 Feb 2014 07:19:44 +0000 (08:19 +0100)]
Fix command dispatching

DispatchCommand is supposed to be nested:

  ssh server gitblit version --verbose --format json

means that first the command that is seen by dispatching process is
"gitblit". Dispatch command look in its commands map for this command
and dispatch the rest of the command and options and arguments to this
command, version in this example.

Change-Id: I8ef8e0e369922c793ca7ad36c1a8f76b0206baa7

10 years agoEliminate use of Dagger and do not create inner classes
James Moger [Sat, 22 Feb 2014 21:19:03 +0000 (16:19 -0500)]
Eliminate use of Dagger and do not create inner classes

This change outlines somethings I'd like to see in your latest code.

1. Elimination of Dagger
2. Less noise from inner class instantiation
3. Formalizing filesystem location for keys instead of Unix-y /tmp/
4. Password authentication as alternative to Key authentication

Change-Id: I7a76e1811ad7cd545444fd8b59bbe8c4f45ccfec

10 years agoConvert SshDaemon to unix format
David Ostrovsky [Sat, 22 Feb 2014 16:08:49 +0000 (17:08 +0100)]
Convert SshDaemon to unix format

Change-Id: Icb415c2bc62321ddd0ae08445d97f1f8102adee8

10 years agoFactor out methods from SshCommandServer to SshDaemon
David Ostrovsky [Sat, 22 Feb 2014 16:03:37 +0000 (17:03 +0100)]
Factor out methods from SshCommandServer to SshDaemon

Change-Id: I02d545a8ab68b06d733ad8e7ed476767a34aa244

10 years agoSSHD: Add support for generic commands
David Ostrovsky [Mon, 17 Feb 2014 20:56:36 +0000 (21:56 +0100)]
SSHD: Add support for generic commands

Change-Id: I5a60710323ca674d70e34f7451422ec167105429

10 years agoSupport serving repositories over the SSH transport
Eric Myhre [Thu, 13 Jun 2013 22:03:24 +0000 (17:03 -0500)]
Support serving repositories over the SSH transport

Gitblit would greatly benefit from an integrated SSH server.  This would
complete the transport trifecta.

Change-Id: I6fb95abe65655fa74d47ea71522d8d9a1541450c

10 years agoRemove unused/garbage artifact from an earlier merge
James Moger [Thu, 10 Apr 2014 16:10:56 +0000 (12:10 -0400)]
Remove unused/garbage artifact from an earlier merge

10 years agoRemove remaining GoogleCharts code and update documentation
James Moger [Thu, 10 Apr 2014 16:07:54 +0000 (12:07 -0400)]
Remove remaining GoogleCharts code and update documentation

10 years agoMerge pull request #167 from Hybris95/master
James Moger [Thu, 10 Apr 2014 15:09:57 +0000 (11:09 -0400)]
Merge pull request #167 from Hybris95/master

Some French translation reviews

10 years agoSome French translation reviews 167/head
Hybris95 [Thu, 10 Apr 2014 14:49:16 +0000 (16:49 +0200)]
Some French translation reviews

10 years agoDocumentation
James Moger [Thu, 10 Apr 2014 01:02:18 +0000 (21:02 -0400)]
Documentation

10 years agoMerged #43 "Switch to flotr2 graphs from GoogleCharts"
James Moger [Thu, 10 Apr 2014 00:57:09 +0000 (18:57 -0600)]
Merged #43 "Switch to flotr2 graphs from GoogleCharts"

10 years agoSwitch to self-hosted flotr2 graphs from Google Charts 43/43/2
tryan [Mon, 7 Apr 2014 06:04:45 +0000 (16:04 +1000)]
Switch to self-hosted flotr2 graphs from Google Charts

10 years agoMerged #42 "Fix failure of RedisTicketService to determine hasTicket"
James Moger [Tue, 8 Apr 2014 04:50:59 +0000 (22:50 -0600)]
Merged #42 "Fix failure of RedisTicketService to determine hasTicket"

10 years agoFix failure of RedisTicketService to determine hasTicket 42/42/1
James Moger [Tue, 8 Apr 2014 04:48:19 +0000 (00:48 -0400)]
Fix failure of RedisTicketService to determine hasTicket

10 years agoMerged #41 "Warn on LDAP synchronization if the uid attribute is null/undefined"
James Moger [Tue, 8 Apr 2014 04:23:09 +0000 (22:23 -0600)]
Merged #41 "Warn on LDAP synchronization if the uid attribute is null/undefined"

10 years agoWarn on LDAP synchronization if the uid attribute is null/undefined 41/41/1
James Moger [Tue, 8 Apr 2014 04:21:40 +0000 (00:21 -0400)]
Warn on LDAP synchronization if the uid attribute is null/undefined

10 years agoMerged #40 "Fix intermittent NPE in getting commit date in RefModel"
James Moger [Tue, 8 Apr 2014 04:09:31 +0000 (22:09 -0600)]
Merged #40 "Fix intermittent NPE in getting commit date in RefModel"

10 years agoFix intermittent NPE in getting commit date in RefModel 40/40/1
James Moger [Tue, 8 Apr 2014 04:07:45 +0000 (00:07 -0400)]
Fix intermittent NPE in getting commit date in RefModel

10 years agoMerged #39 "Redirect on canceling edit repository to Summary Page"
James Moger [Tue, 8 Apr 2014 03:49:44 +0000 (21:49 -0600)]
Merged #39 "Redirect on canceling edit repository to Summary Page"

10 years agoRedirect on canceling edit repository to Summary Page 39/39/1
James Moger [Tue, 8 Apr 2014 03:48:10 +0000 (23:48 -0400)]
Redirect on canceling edit repository to Summary Page

10 years agoMerged #38 "Redirect to Summary page after editing a repository"
James Moger [Tue, 8 Apr 2014 03:45:34 +0000 (21:45 -0600)]
Merged #38 "Redirect to Summary page after editing a repository"

10 years agoRedirect to Summary page after editing a repository 38/38/1
James Moger [Tue, 8 Apr 2014 03:42:16 +0000 (23:42 -0400)]
Redirect to Summary page after editing a repository

10 years agoFix incorrect REWIND labeling in reflog on all ticket pushes
James Moger [Tue, 8 Apr 2014 03:32:48 +0000 (23:32 -0400)]
Fix incorrect REWIND labeling  in reflog on all ticket pushes

10 years agoEnsure repositories folder is created before executing a write test
James Moger [Tue, 8 Apr 2014 03:05:01 +0000 (23:05 -0400)]
Ensure repositories folder is created before executing a write test

10 years agoFix possible NPE when deleting a repository and cleaning-up branch-based tickets
James Moger [Tue, 8 Apr 2014 03:03:31 +0000 (23:03 -0400)]
Fix possible NPE when deleting a repository and cleaning-up branch-based tickets

10 years agoMerge pull request #164 from jaa127/ldap-bind-escape
James Moger [Mon, 31 Mar 2014 16:20:58 +0000 (12:20 -0400)]
Merge pull request #164 from jaa127/ldap-bind-escape

Ldap bind escape

10 years agoConfigure Tickets close-on-push commit message regex (issue-404)
James Moger [Mon, 31 Mar 2014 15:45:21 +0000 (11:45 -0400)]
Configure Tickets close-on-push commit message regex (issue-404)

10 years agoLDAP: Escape username in case we are using userbased bind. 164/head
Jani Averbach [Sun, 30 Mar 2014 21:55:43 +0000 (00:55 +0300)]
LDAP: Escape username in case we are using userbased bind.

10 years agoLDAP: Added test for binding without special account (e.g. userbased
Jani Averbach [Sun, 30 Mar 2014 21:53:21 +0000 (00:53 +0300)]
LDAP: Added test for binding without special account (e.g. userbased
bind)

10 years agoDocumentation
James Moger [Sun, 30 Mar 2014 18:58:00 +0000 (14:58 -0400)]
Documentation

10 years agoEnable the daily log for the Ubuntu and CentOS services (issue-348)
James Moger [Sat, 29 Mar 2014 00:20:53 +0000 (20:20 -0400)]
Enable the daily log for the Ubuntu and CentOS services (issue-348)

10 years agoFix close ticket on push by commit message parsing (issue-404)
James Moger [Fri, 28 Mar 2014 23:58:48 +0000 (19:58 -0400)]
Fix close ticket on push by commit message parsing (issue-404)

10 years agoImplement setting removal for configuration settings
James Moger [Fri, 21 Mar 2014 16:41:35 +0000 (12:41 -0400)]
Implement setting removal for configuration settings

10 years agoUpdate to JGit 3.3.1
James Moger [Thu, 27 Mar 2014 13:43:07 +0000 (09:43 -0400)]
Update to JGit 3.3.1

10 years agoMerged #28 "Replace JCommander with args4j"
James Moger [Thu, 27 Mar 2014 13:41:26 +0000 (07:41 -0600)]
Merged #28 "Replace JCommander with args4j"

10 years agoReplace JCommander with args4j 28/28/2
James Moger [Thu, 13 Mar 2014 00:12:50 +0000 (20:12 -0400)]
Replace JCommander with args4j

10 years agoChange build identifier to 1.5.0-SNAPSHOT
James Moger [Thu, 27 Mar 2014 13:31:57 +0000 (09:31 -0400)]
Change build identifier to 1.5.0-SNAPSHOT

10 years agoMerged #37 "Fix repository mailing list editing which prevented field reset"
James Moger [Thu, 27 Mar 2014 13:27:40 +0000 (07:27 -0600)]
Merged #37 "Fix repository mailing list editing which prevented field reset"

10 years agoFix repository mailing list editing which prevented field reset 37/37/1
James Moger [Thu, 27 Mar 2014 13:25:36 +0000 (09:25 -0400)]
Fix repository mailing list editing which prevented field reset

10 years agoLDAP: Authenticated Searches without a manager password
j3rem1e [Thu, 27 Mar 2014 13:16:53 +0000 (09:16 -0400)]
LDAP: Authenticated Searches without a manager password

Allow to use the LDAP AuthProvider with a LDAP Server
prohibiting anonymous searches but without providing
a manager password : searches are made on behalf of
the authenticated user.

10 years agoAdd a French translation
Johann Ollivier-Lapeyre [Thu, 27 Mar 2014 13:09:49 +0000 (09:09 -0400)]
Add a French translation

10 years agoEnsure Lucene ticket index is updated on repository deletion
James Moger [Thu, 27 Mar 2014 13:01:43 +0000 (09:01 -0400)]
Ensure Lucene ticket index is updated on repository deletion

10 years agoAdd a method to test for the existence of a setting
James Moger [Thu, 27 Mar 2014 13:01:28 +0000 (09:01 -0400)]
Add a method to test for the existence of a setting

10 years agoMerged #36 "Fix missing subject in html mailings"
James Moger [Fri, 21 Mar 2014 13:43:02 +0000 (07:43 -0600)]
Merged #36 "Fix missing subject in html mailings"

10 years agoFix missing subject in html mailings 36/36/1
James Moger [Fri, 21 Mar 2014 13:39:38 +0000 (09:39 -0400)]
Fix missing subject in html mailings

10 years agoDocumentation
James Moger [Thu, 20 Mar 2014 16:26:43 +0000 (12:26 -0400)]
Documentation

10 years agoReset build identifiers for next development cycle
James Moger [Wed, 19 Mar 2014 01:39:04 +0000 (21:39 -0400)]
Reset build identifiers for next development cycle

10 years agoPrepare 1.4.1 release v1.4.1
James Moger [Wed, 19 Mar 2014 01:39:04 +0000 (21:39 -0400)]
Prepare 1.4.1 release