]> source.dussan.org Git - nextcloud-server.git/log
nextcloud-server.git
11 years agoPHP Strict standards: Non-static method OC_Defaults::themeExist() should not be...
Thomas Mueller [Fri, 28 Jun 2013 14:23:26 +0000 (16:23 +0200)]
PHP Strict standards:  Non-static method OC_Defaults::themeExist() should not be called statically

11 years agoadd logo claim to defaults.php
Björn Schießle [Fri, 28 Jun 2013 08:06:57 +0000 (10:06 +0200)]
add logo claim to defaults.php

11 years agologo claim added
Björn Schießle [Thu, 27 Jun 2013 17:53:49 +0000 (19:53 +0200)]
logo claim added

11 years agomake mail footer aware of different themes
Björn Schießle [Thu, 27 Jun 2013 16:28:53 +0000 (18:28 +0200)]
make mail footer aware of different themes

11 years agoremove unneeded if condition
Björn Schießle [Thu, 27 Jun 2013 14:28:45 +0000 (16:28 +0200)]
remove unneeded if condition

11 years agolib/defaults.php should only contain the default strings and read the other strings...
Björn Schießle [Thu, 27 Jun 2013 14:24:03 +0000 (16:24 +0200)]
lib/defaults.php should only contain the default strings and read the other strings directly from the theme

11 years agocheck for updates only in the community edition
Björn Schießle [Wed, 26 Jun 2013 16:05:37 +0000 (18:05 +0200)]
check for updates only in the community edition

11 years agoconstruct the foother in defaults.php so that we use always the same footer
Björn Schießle [Wed, 26 Jun 2013 15:56:19 +0000 (17:56 +0200)]
construct the foother in defaults.php so that we use always the same footer

11 years agoFix ugly error style on install
Markus Goetz [Tue, 23 Apr 2013 09:06:28 +0000 (11:06 +0200)]
Fix ugly error style on install

By initializing the template engine first we can show the
'Can't write into config directory 'config'' error in a nice way instead
of plain unstyled HTML.

11 years agoMerge pull request #3816 from owncloud/fix_3815
blizzz [Sat, 22 Jun 2013 07:11:03 +0000 (00:11 -0700)]
Merge pull request #3816 from owncloud/fix_3815

LDAP: better check for emptiness, fixes #3815

11 years agoMerge pull request #3814 from owncloud/fix-german-du-and-deine-stable5
blizzz [Fri, 21 Jun 2013 22:13:34 +0000 (15:13 -0700)]
Merge pull request #3814 from owncloud/fix-german-du-and-deine-stable5

In German we want uppercase 'Du' and 'Deine*'

11 years agoLDAP: even better check for emptiness, fixes #3815
Arthur Schiwon [Fri, 21 Jun 2013 21:58:44 +0000 (23:58 +0200)]
LDAP: even better check for emptiness, fixes #3815

11 years agoRevert "LDAP: better check for emptiness, fixes #3815"
Arthur Schiwon [Fri, 21 Jun 2013 21:58:27 +0000 (23:58 +0200)]
Revert "LDAP: better check for emptiness, fixes #3815"

This reverts commit 4797f9d7db8b48c977e34303a9c80eaea704af19.

11 years agoLDAP: better check for emptiness, fixes #3815
Arthur Schiwon [Fri, 21 Jun 2013 21:19:53 +0000 (23:19 +0200)]
LDAP: better check for emptiness, fixes #3815

11 years agoIn German we want uppercase 'Du' and 'Deine*'
Thomas Mueller [Fri, 21 Jun 2013 20:55:26 +0000 (22:55 +0200)]
In German we want uppercase 'Du' and 'Deine*'

11 years agoReplace display name only
Victor Dubiniuk [Mon, 17 Jun 2013 21:17:08 +0000 (00:17 +0300)]
Replace display name only

11 years agoimprove error handling of webdavauth
Georg Ehrke [Fri, 21 Jun 2013 12:39:04 +0000 (14:39 +0200)]
improve error handling of webdavauth

11 years agoencryption is LDAP compatible
Björn Schießle [Fri, 21 Jun 2013 11:07:52 +0000 (13:07 +0200)]
encryption is LDAP compatible

11 years agocheck openssl dependency for the encryption app
Björn Schießle [Fri, 21 Jun 2013 08:37:51 +0000 (10:37 +0200)]
check openssl dependency for the encryption app

commit 1345201c9da99a82f198e41fba24da6b0d7ae59a
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Thu Jun 20 16:27:46 2013 +0200

    add l10n support

commit bf2c79c8de8710e839a4a55642a91874c374fa1c
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Thu Jun 20 16:19:10 2013 +0200

    only init session if openssl extension is loaded

commit cbd52af6afbaa310bb1a534db64ff5e476dfd5d7
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Thu Jun 20 12:25:40 2013 +0200

    first disable app and than show error page

commit 55baf593179c433642de59552592e6b0f1932880
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Thu Jun 20 12:17:34 2013 +0200

    typo fixed

commit 1d9bef0b058e7cc3d511b81ae12d5a07660c75b2
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Thu Jun 20 12:15:40 2013 +0200

    move dependency check to the encryption app

commit c186e95da526f0470e20f014f1bd9513db5518ff
Author: Björn Schießle <schiessle@owncloud.com>
Date:   Thu Jun 20 11:13:11 2013 +0200

    make sure that openssl is installed and loaded

Conflicts:

apps/files_encryption/appinfo/app.php

11 years agoadding unit test for folder remove: testRemovedFolder()
Thomas Mueller [Thu, 20 Jun 2013 08:47:37 +0000 (10:47 +0200)]
adding unit test for folder remove: testRemovedFolder()

11 years agoremove deleted files when re-scanning a folder
Robin Appelman [Wed, 19 Jun 2013 22:42:34 +0000 (00:42 +0200)]
remove deleted files when re-scanning a folder

11 years agouse json to encode user list
Robin Appelman [Wed, 19 Jun 2013 13:02:18 +0000 (15:02 +0200)]
use json to encode user list

11 years agoallow scanning files for multiple users
Robin Appelman [Tue, 18 Jun 2013 23:26:08 +0000 (01:26 +0200)]
allow scanning files for multiple users

11 years agoalways have a defined return value
Björn Schießle [Wed, 19 Jun 2013 14:55:31 +0000 (16:55 +0200)]
always have a defined return value

11 years agosome more error messages
Björn Schießle [Wed, 19 Jun 2013 13:58:34 +0000 (15:58 +0200)]
some more error messages

11 years agoadd some more error messages, in case something went wrong
Björn Schießle [Wed, 19 Jun 2013 13:52:33 +0000 (15:52 +0200)]
add some more error messages, in case something went wrong

11 years agofixed enghlish sentence, thanks to @MTGap
Björn Schießle [Wed, 19 Jun 2013 10:05:45 +0000 (12:05 +0200)]
fixed enghlish sentence, thanks to @MTGap

11 years agofix updaters test cases
Robin Appelman [Tue, 18 Jun 2013 22:26:47 +0000 (00:26 +0200)]
fix updaters test cases

11 years agoadd tests for reusing existing data in scanner
Robin Appelman [Mon, 17 Jun 2013 16:03:57 +0000 (18:03 +0200)]
add tests for reusing existing data in scanner

11 years agoreuse etag when doing a forced rescan
Robin Appelman [Fri, 14 Jun 2013 15:04:17 +0000 (17:04 +0200)]
reuse etag when doing a forced rescan

11 years agoscanner: give more percision about what data is reused during scanning
Robin Appelman [Fri, 14 Jun 2013 14:53:08 +0000 (16:53 +0200)]
scanner: give more percision about what data is reused during scanning

11 years agosplit of scanning the childs of a folder
Robin Appelman [Fri, 14 Jun 2013 13:30:41 +0000 (15:30 +0200)]
split of scanning the childs of a folder

11 years agohide the logo claim in case the theme is not loaded
Jan-Christoph Borchardt [Mon, 17 Jun 2013 18:35:08 +0000 (20:35 +0200)]
hide the logo claim in case the theme is not loaded

11 years agoMerge pull request #3770 from owncloud/fix_theme_loading
Björn Schießle [Wed, 19 Jun 2013 09:54:56 +0000 (02:54 -0700)]
Merge pull request #3770 from owncloud/fix_theme_loading

getTheme() should also return the default theme if a empty theme is set in the config.php

11 years agoFix OC_User::getDisplaynames when using numeric user id's
Robin Appelman [Tue, 16 Apr 2013 23:08:27 +0000 (01:08 +0200)]
Fix OC_User::getDisplaynames when using numeric user id's

fixes #2948

11 years agoMerge pull request #3771 from owncloud/fix_lost_password_page
Frank Karlitschek [Tue, 18 Jun 2013 21:06:00 +0000 (14:06 -0700)]
Merge pull request #3771 from owncloud/fix_lost_password_page

fix lost password page

11 years agofix lost password page, don't show checkbox is encryption is not enabled
Björn Schießle [Tue, 18 Jun 2013 09:43:11 +0000 (11:43 +0200)]
fix lost password page, don't show checkbox is encryption is not enabled

11 years agouse default value when we try to retrieve the theme from the config
Björn Schießle [Tue, 18 Jun 2013 09:18:31 +0000 (11:18 +0200)]
use default value when we try to retrieve the theme from the config

11 years agoalso use the default theme if the theme is set to an empty string in the config.php
Björn Schießle [Tue, 18 Jun 2013 08:57:37 +0000 (10:57 +0200)]
also use the default theme if the theme is set to an empty string in the config.php

11 years agodon't normalize absolute local path
Björn Schießle [Mon, 17 Jun 2013 12:42:18 +0000 (14:42 +0200)]
don't normalize absolute local path

11 years agoonly escape glob pattern
Björn Schießle [Fri, 14 Jun 2013 13:07:06 +0000 (15:07 +0200)]
only escape glob pattern

Conflicts:

apps/files_trashbin/lib/trash.php

11 years agoMerge pull request #3753 from owncloud/fix_translation_link
Björn Schießle [Mon, 17 Jun 2013 10:56:43 +0000 (03:56 -0700)]
Merge pull request #3753 from owncloud/fix_translation_link

fix link to translation

11 years agofix link to translation, bug was introduced by https://github.com/owncloud/core/commi...
Björn Schießle [Mon, 17 Jun 2013 09:48:23 +0000 (11:48 +0200)]
fix link to translation, bug was introduced by https://github.com/owncloud/core/commit/ca7699c8bdb85df9b69e3639f53d1b959287ba16#settings/templates/personal.php

11 years agoMerge pull request #3725 from owncloud/oracle_stable5
Jörn Friedrich Dreyer [Fri, 14 Jun 2013 14:07:49 +0000 (07:07 -0700)]
Merge pull request #3725 from owncloud/oracle_stable5

Oracle stable5

11 years agodon't use sequence suffix, MDB2 handles that internally
Jörn Friedrich Dreyer [Fri, 14 Jun 2013 11:43:50 +0000 (13:43 +0200)]
don't use sequence suffix, MDB2 handles that internally

11 years agoSquashed commit of the following:
Thomas Mueller [Fri, 14 Jun 2013 11:34:01 +0000 (13:34 +0200)]
Squashed commit of the following:

commit 85043af59846edd54b6f402829a698142fdb412f
Author: Michael Gapczynski <mtgap@owncloud.com>
Date:   Sat May 25 11:25:43 2013 -0400

    Clear opcode caches after writing to the config file, fixes #3372

commit e96ca0a217112a612e5018fb06115879be634f0b
Author: Michael Gapczynski <mtgap@owncloud.com>
Date:   Fri May 17 11:15:53 2013 -0400

    Add undefined verision variables

commit d7faeea0b8a79bcd84255120e396280fe62c8aa1
Author: Michael Gapczynski <mtgap@owncloud.com>
Date:   Tue May 14 09:34:01 2013 -0400

    Turn off theme before update

commit f620df4e88201a8d35ecb6173f258d5e5f67c7f9
Author: Bart Visscher <bartv@thisnet.nl>
Date:   Tue Apr 16 08:07:44 2013 +0200

    Also check for needed upgrade in the Sabre Maintenance connector

commit 223cfce8c89663beb95cf7438f47cea4bac6e0de
Author: Bart Visscher <bartv@thisnet.nl>
Date:   Tue Apr 9 21:05:11 2013 +0200

    Connect watcher failure function to the failure signal

commit 49b9a1e8af062c03ebc863e1139ca310944b784a
Author: Bart Visscher <bartv@thisnet.nl>
Date:   Tue Apr 9 20:51:43 2013 +0200

    Move start of the maintenance mode to the ajax call

    Make sure the update page is shown in a browser. And not an ajax request

11 years agocleanup codestyle
Jörn Friedrich Dreyer [Wed, 8 May 2013 14:29:15 +0000 (16:29 +0200)]
cleanup codestyle

11 years agouse to_char only for oracle, whitespace
Jörn Friedrich Dreyer [Wed, 8 May 2013 14:18:24 +0000 (16:18 +0200)]
use to_char only for oracle, whitespace

11 years agooracle fixes, missing backticks, LIMIT to param
Jörn Friedrich Dreyer [Mon, 29 Apr 2013 10:25:27 +0000 (12:25 +0200)]
oracle fixes, missing backticks, LIMIT to param

Conflicts:
lib/files/cache/cache.php

11 years agoallow install when only oracle is available
Jörn Friedrich Dreyer [Wed, 8 May 2013 13:30:04 +0000 (15:30 +0200)]
allow install when only oracle is available

11 years agoconvert LIMIT to parameter
Jörn Friedrich Dreyer [Mon, 10 Jun 2013 08:04:52 +0000 (10:04 +0200)]
convert LIMIT to parameter

11 years agofix fetchRow checks to also work with MDB2
Jörn Friedrich Dreyer [Mon, 10 Jun 2013 09:07:41 +0000 (11:07 +0200)]
fix fetchRow checks to also work with MDB2

11 years agoadd missing backticks all over the place
Jörn Friedrich Dreyer [Mon, 10 Jun 2013 07:53:29 +0000 (09:53 +0200)]
add missing backticks all over the place

Conflicts:
apps/files_encryption/lib/util.php
lib/files/cache/backgroundwatcher.php
lib/files/cache/cache.php

11 years agoshorten table identifiers in tests
Jörn Friedrich Dreyer [Mon, 10 Jun 2013 09:44:04 +0000 (11:44 +0200)]
shorten table identifiers in tests

11 years agodb structure, allow null in columns for '' values
Jörn Friedrich Dreyer [Mon, 3 Jun 2013 16:28:48 +0000 (18:28 +0200)]
db structure, allow null in columns for '' values

11 years agoSquashed commit of the following:
Thomas Mueller [Fri, 14 Jun 2013 09:18:30 +0000 (11:18 +0200)]
Squashed commit of the following:

commit 1c7d5da4d1687183f8701336fc14636f61095f4e
Author: infoneo <infoneo@yahoo.pl>
Date:   Sat Jun 8 19:44:58 2013 +0300

    Update mapper.php

commit 37f1f034f776b084ac7e25be136ce64b5772a446
Author: infoneo <infoneo@yahoo.pl>
Date:   Sat Jun 8 18:39:25 2013 +0300

    Update mapper.php

    Now slugify is performed on whole filename (including extension). Changed method of adding index number (using regular expressions pathinfo() method removed).

commit 4a5f872f1f55941d07992d7ac5e8f8b74ec8febc
Author: infoneo <infoneo@yahoo.pl>
Date:   Sun May 12 15:22:57 2013 +0300

    Fixed problems with a dots in a filenames

commit bc17f958349e36c1caacfc9263ae1de2df8e6a76
Author: infoneo <infoneo@yahoo.pl>
Date:   Sun May 12 01:47:48 2013 +0200

    Dots in a filenames fix

11 years agofix for path_hash not unique as reported at #3641
Florin Peter [Thu, 13 Jun 2013 18:52:34 +0000 (20:52 +0200)]
fix for path_hash not unique as reported at #3641

11 years agofix memory problems as reported at #3620
Florin Peter [Thu, 13 Jun 2013 18:51:22 +0000 (20:51 +0200)]
fix memory problems as reported at #3620

11 years agoimproved footer
Björn Schießle [Thu, 13 Jun 2013 14:10:33 +0000 (16:10 +0200)]
improved footer

11 years agoadd logo-claim
Björn Schießle [Wed, 12 Jun 2013 15:20:09 +0000 (17:20 +0200)]
add logo-claim

11 years agodon't show translation hints in enterprise edition
Björn Schießle [Wed, 12 Jun 2013 15:07:43 +0000 (17:07 +0200)]
don't show translation hints in enterprise edition

Conflicts:

settings/templates/personal.php

11 years agomove common settings footer fieldset out of conditional
Jan-Christoph Borchardt [Wed, 12 Jun 2013 14:59:23 +0000 (16:59 +0200)]
move common settings footer fieldset out of conditional

11 years agoshort explanation about OC_Defaults
Björn Schießle [Wed, 12 Jun 2013 14:33:09 +0000 (16:33 +0200)]
short explanation about OC_Defaults

11 years agomake pub link share footer aware of different owncloud editions
Björn Schießle [Wed, 12 Jun 2013 14:28:47 +0000 (16:28 +0200)]
make pub link share footer aware of different owncloud editions

11 years agomake main menu aware of the different owncloud editions
Björn Schießle [Wed, 12 Jun 2013 14:20:23 +0000 (16:20 +0200)]
make main menu aware of the different owncloud editions

11 years agoadd default doc url
Björn Schießle [Wed, 12 Jun 2013 14:19:28 +0000 (16:19 +0200)]
add default doc url

11 years agomake footer and urls aware of ownCloud editions
Björn Schießle [Wed, 12 Jun 2013 13:44:11 +0000 (15:44 +0200)]
make footer and urls aware of ownCloud editions

11 years agokeep all strings in one place to make it easier to change them
Björn Schießle [Wed, 12 Jun 2013 13:15:08 +0000 (15:15 +0200)]
keep all strings in one place to make it easier to change them

11 years agomake footer aware of ownCloud editions
Björn Schießle [Wed, 12 Jun 2013 12:49:30 +0000 (14:49 +0200)]
make footer aware of ownCloud editions

11 years agomage page title aware of ownCloud edition
Björn Schießle [Wed, 12 Jun 2013 12:33:24 +0000 (14:33 +0200)]
mage page title aware of ownCloud edition

Conflicts:

core/templates/layout.user.php

11 years agoonly check for recovery key if someone else than the user wants to change the password
Björn Schießle [Fri, 7 Jun 2013 18:17:48 +0000 (20:17 +0200)]
only check for recovery key if someone else than the user wants to change the password

Conflicts:

settings/ajax/changepassword.php

11 years agoadd a hint that the admin can recover your files; Don't let the user change the recov...
Björn Schießle [Wed, 5 Jun 2013 16:53:02 +0000 (18:53 +0200)]
add a hint that the admin can recover your files; Don't let the user change the recovery settings if no private key is set

11 years agoprint a warning if a user wants to reset his password and encryption is enabled
Björn Schießle [Wed, 5 Jun 2013 16:38:39 +0000 (18:38 +0200)]
print a warning if a user wants to reset his password and encryption is enabled

Conflicts:

core/lostpassword/templates/lostpassword.php

11 years agoallow to press enter to update the password
Björn Schießle [Wed, 5 Jun 2013 12:51:51 +0000 (14:51 +0200)]
allow to press enter to update the password

11 years agotell the user what he can do to regain access to his files
Björn Schießle [Wed, 5 Jun 2013 12:19:26 +0000 (14:19 +0200)]
tell the user what he can do to regain access to his files

11 years agoonly show personal settings if the recovery feature is enabled or if no private key...
Björn Schießle [Wed, 5 Jun 2013 11:51:28 +0000 (13:51 +0200)]
only show personal settings if the recovery feature is enabled or if no private key is set

11 years agoimproved error msg and removed duplicate string
Florin Peter [Tue, 4 Jun 2013 20:31:36 +0000 (22:31 +0200)]
improved error msg and removed duplicate string

11 years agoimproved label for the password recovery feature
Björn Schießle [Tue, 4 Jun 2013 19:19:42 +0000 (21:19 +0200)]
improved label for the password recovery feature

11 years agolink directly to the encryption settings
Björn Schießle [Tue, 4 Jun 2013 08:49:58 +0000 (10:49 +0200)]
link directly to the encryption settings

11 years agobetter handling for http post
Florin Peter [Mon, 3 Jun 2013 22:41:47 +0000 (00:41 +0200)]
better handling for http post

11 years agochanged redirect handling
Florin Peter [Mon, 3 Jun 2013 21:41:57 +0000 (23:41 +0200)]
changed redirect handling

11 years agofixed typo
Florin Peter [Mon, 3 Jun 2013 17:10:55 +0000 (19:10 +0200)]
fixed typo

11 years agofix password change when files_encryption app is disabled
Florin Peter [Mon, 3 Jun 2013 17:06:20 +0000 (19:06 +0200)]
fix password change when files_encryption app is disabled

Conflicts:

settings/ajax/changepassword.php

11 years agoreformat code
Florin Peter [Mon, 3 Jun 2013 16:42:13 +0000 (18:42 +0200)]
reformat code

Conflicts:

apps/files_encryption/lib/session.php
apps/files_encryption/lib/util.php

11 years agouse generated private key fro m setUp()
Björn Schießle [Mon, 3 Jun 2013 15:43:06 +0000 (17:43 +0200)]
use generated private key fro m setUp()

11 years agoadded test for decryptPrivateKey()
Björn Schießle [Mon, 3 Jun 2013 15:34:43 +0000 (17:34 +0200)]
added test for decryptPrivateKey()

11 years agolet user update private key password in case it was changed from outside, e.g. extern...
Björn Schießle [Mon, 3 Jun 2013 13:27:31 +0000 (15:27 +0200)]
let user update private key password in case it was changed from outside, e.g. external auth back-ends

11 years ago$session->setPrivateKey expects only one parameter
Björn Schießle [Mon, 3 Jun 2013 13:26:58 +0000 (15:26 +0200)]
$session->setPrivateKey expects only one parameter

11 years agocontrol files are no longer needed, remove them from the tests
Björn Schießle [Mon, 3 Jun 2013 12:21:30 +0000 (14:21 +0200)]
control files are no longer needed, remove them from the tests

11 years agointroduce decryptPrivateKey() method which also checks if the result is a valid priva...
Björn Schießle [Mon, 3 Jun 2013 12:19:31 +0000 (14:19 +0200)]
introduce decryptPrivateKey() method which also checks if the result is a valid private key to avoid additional checks on various places

Conflicts:

apps/files_encryption/lib/session.php

11 years agocode optimized and cleaned up unused vars
Florin Peter [Fri, 31 May 2013 14:52:33 +0000 (16:52 +0200)]
code optimized and cleaned up unused vars

11 years agoallow the user to login but do not allow upload and show error message on the web
Florin Peter [Fri, 31 May 2013 13:57:18 +0000 (15:57 +0200)]
allow the user to login but do not allow upload and show error message on the web

Conflicts:

apps/files_encryption/appinfo/app.php

11 years agocheck if the decrypted private key is valid on login and on read/write files
Florin Peter [Fri, 31 May 2013 11:58:58 +0000 (13:58 +0200)]
check if the decrypted private key is valid on login and on read/write files

11 years agocleanup unused method legacyKeyRecryptKeyfile
Florin Peter [Fri, 31 May 2013 20:49:32 +0000 (22:49 +0200)]
cleanup unused method legacyKeyRecryptKeyfile

11 years agonormalize path to prevent following split to fail
Florin Peter [Thu, 30 May 2013 23:57:32 +0000 (01:57 +0200)]
normalize path to prevent following split to fail

11 years agofix legacy key in until test
Florin Peter [Thu, 30 May 2013 23:55:48 +0000 (01:55 +0200)]
fix legacy key in until test

11 years agofix re-encrypt legacy files
Florin Peter [Thu, 30 May 2013 23:36:49 +0000 (01:36 +0200)]
fix re-encrypt legacy files

Conflicts:

apps/files_encryption/lib/util.php

11 years agouse legacyDecrypt to decrypt key file like the previous files_encryption
Florin Peter [Thu, 30 May 2013 23:35:48 +0000 (01:35 +0200)]
use legacyDecrypt to decrypt key file like the previous files_encryption

11 years agofix for autoloader while user logged in and system is in maintenance
Florin Peter [Thu, 30 May 2013 20:41:30 +0000 (22:41 +0200)]
fix for autoloader while user logged in and system is in maintenance

Conflicts:

apps/files_encryption/appinfo/app.php

11 years agoadd comment to explain the helper function
Björn Schießle [Thu, 13 Jun 2013 08:35:30 +0000 (10:35 +0200)]
add comment to explain the helper function