]> source.dussan.org Git - poi.git/log
poi.git
3 years agoadd back some new code
PJ Fanning [Mon, 15 Mar 2021 20:24:22 +0000 (20:24 +0000)]
add back some new code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887685 13f79535-47bb-0310-9956-ffa450edef68

3 years agorevert recent changes
PJ Fanning [Mon, 15 Mar 2021 18:21:37 +0000 (18:21 +0000)]
revert recent changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887682 13f79535-47bb-0310-9956-ffa450edef68

3 years agoRun the TestAllFiles tests as part of Gradle
Marius Volkhart [Mon, 15 Mar 2021 17:52:40 +0000 (17:52 +0000)]
Run the TestAllFiles tests as part of Gradle

I accidentally excluded these in r1887643. They should not be excluded.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887681 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[bug-65184] revert due to integration test failures
PJ Fanning [Sun, 14 Mar 2021 23:54:49 +0000 (23:54 +0000)]
[bug-65184] revert due to integration test failures

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887660 13f79535-47bb-0310-9956-ffa450edef68

3 years agoTry to fix sonar build
Andreas Beeker [Sun, 14 Mar 2021 23:49:43 +0000 (23:49 +0000)]
Try to fix sonar build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887659 13f79535-47bb-0310-9956-ffa450edef68

3 years agoreformat file
PJ Fanning [Sun, 14 Mar 2021 23:29:34 +0000 (23:29 +0000)]
reformat file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887658 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[bug-65184] Improve performance of POFSMiniStore getBlockAt. Thanks to sits
PJ Fanning [Sun, 14 Mar 2021 23:21:18 +0000 (23:21 +0000)]
[bug-65184] Improve performance of POFSMiniStore getBlockAt. Thanks to sits

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887657 13f79535-47bb-0310-9956-ffa450edef68

3 years agoImplement CONCAT function #65185
Nick Burch [Sun, 14 Mar 2021 22:53:27 +0000 (22:53 +0000)]
Implement CONCAT function #65185

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887656 13f79535-47bb-0310-9956-ffa450edef68

3 years agoChange Gradle to use java-library plugin
Marius Volkhart [Sun, 14 Mar 2021 20:43:43 +0000 (20:43 +0000)]
Change Gradle to use java-library plugin

This plugin is specifically built for libraries. The major difference to the regular java plugin is that is allows defining dependencies as part of the api or implementation. Both are used by the project at compile/runtime, but only api dependencies are made available to dependent projects.

In our current setup, this doesn't matter much. We deploy to maven central using pre-built POMs. It's more of a future-proofing, and it makes it a little bit clearer which gradle projects actually require which dependencies.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887650 13f79535-47bb-0310-9956-ffa450edef68

3 years agoxmlbeans 5.0.0 release
PJ Fanning [Sun, 14 Mar 2021 19:47:22 +0000 (19:47 +0000)]
xmlbeans 5.0.0 release

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887648 13f79535-47bb-0310-9956-ffa450edef68

3 years agoExclude batik-script dependency from OOXML artifact
Marius Volkhart [Sun, 14 Mar 2021 18:56:30 +0000 (18:56 +0000)]
Exclude batik-script dependency from OOXML artifact

We do not make use of the batik-script dependency. While this is likely to be true of a variety of the Batik dependencies, batik-script causes problems for our users who are using JPMS. See [bug-65103].

Fixes #230

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887643 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSpecify more granular Batik dependencies
Marius Volkhart [Sun, 14 Mar 2021 18:51:12 +0000 (18:51 +0000)]
Specify more granular Batik dependencies

Batik-all is a strange artifact. It's POM declares dependencies on all the sub-JARs, but its JAR has all of the sub-jars repackaged. This results in multiple JARs with the same packages being added to consuming applications. This leads to problems for JPMS users. See [bug-65183].

The Ant build does not use batik-all, so the Maven and Gradle builds should not either.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887642 13f79535-47bb-0310-9956-ffa450edef68

3 years agoDisable parallel tests on Gradle again
Marius Volkhart [Sun, 14 Mar 2021 11:31:18 +0000 (11:31 +0000)]
Disable parallel tests on Gradle again

Something is causing parallel tests to fail on CI. I haven't been able to track down what it is. The symptoms look similar to others where the cause was a test modifying the test-data directory.

The integration tests also sometimes run into OutOfMemoryErrors when I run them in parallel.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887631 13f79535-47bb-0310-9956-ffa450edef68

3 years agoLimit which tests can run in parallel
Marius Volkhart [Sun, 14 Mar 2021 10:42:15 +0000 (10:42 +0000)]
Limit which tests can run in parallel

Some tests modify global resources. Those tests cannot be run in parallel with others, as they cause problems or become flaky. Where possible, indicate to JUnit the resources in contention. Otherwise, mark the tests as needing to run in isolation.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887630 13f79535-47bb-0310-9956-ffa450edef68

3 years agoGet Gradle GitHub Action past downloading the XMLBeans JAR
Marius Volkhart [Sun, 14 Mar 2021 01:46:05 +0000 (01:46 +0000)]
Get Gradle GitHub Action past downloading the XMLBeans JAR

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887614 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[bug-65184] Improve performance of POFSMiniStore getBlockAt. Thanks to sits
PJ Fanning [Sat, 13 Mar 2021 18:09:13 +0000 (18:09 +0000)]
[bug-65184] Improve performance of POFSMiniStore getBlockAt. Thanks to sits

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887604 13f79535-47bb-0310-9956-ffa450edef68

3 years agoupdate key
PJ Fanning [Thu, 11 Mar 2021 21:39:48 +0000 (21:39 +0000)]
update key

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887516 13f79535-47bb-0310-9956-ffa450edef68

3 years agoStreamline HPSF CustomProperties collection retrieval
Marius Volkhart [Wed, 10 Mar 2021 21:42:19 +0000 (21:42 +0000)]
Streamline HPSF CustomProperties collection retrieval

Reduce the number of map lookups necessary to compute the return values for methods that return collections of property details. Since we maintain parity between the `props` and `dictionary` contents, when retrieving property details, we can reference the `props` directly and avoid the `dictionary` indirection.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887453 13f79535-47bb-0310-9956-ffa450edef68

3 years agoupdate key for kiwiwings - downrating sha1 - see https://infra.apache.org/release...
Andreas Beeker [Tue, 9 Mar 2021 22:04:11 +0000 (22:04 +0000)]
update key for kiwiwings - downrating sha1 - see https://infra.apache.org/release-signing.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887398 13f79535-47bb-0310-9956-ffa450edef68

3 years agoParse PPDrawing more deterministically
Marius Volkhart [Tue, 9 Mar 2021 20:59:24 +0000 (20:59 +0000)]
Parse PPDrawing more deterministically

The [MS-PPT] spec is very clear about what the format of the PPDrawing record must be, and parsing deterministically makes for clearer code.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887396 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdditional debug logging for unknown records in HSLF
Marius Volkhart [Tue, 9 Mar 2021 19:26:31 +0000 (19:26 +0000)]
Additional debug logging for unknown records in HSLF

Recently, while debugging app behavior on HSLF documents, I had to dig into the OOXML that Microsoft PowerPoint places into files saved in PPT format. Having information in the logs about when records were not parsed by POI was very helpful. The hex identifier was critical in being able to quickly search the [MS-PPT] spec for what type of record it was, and the integer identifier was helpful in quickly finding the Record type in RecordTypes.java.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887393 13f79535-47bb-0310-9956-ffa450edef68

3 years agoCleanup documentation of EscherChildAnchorRecord and EscherClientAnchorRecord
Marius Volkhart [Tue, 9 Mar 2021 18:28:59 +0000 (18:28 +0000)]
Cleanup documentation of EscherChildAnchorRecord and EscherClientAnchorRecord

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887391 13f79535-47bb-0310-9956-ffa450edef68

3 years agotry to fix windows path issues in exception messages
Andreas Beeker [Mon, 8 Mar 2021 23:14:11 +0000 (23:14 +0000)]
try to fix windows path issues in exception messages

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887346 13f79535-47bb-0310-9956-ffa450edef68

3 years agoraise XmlBeans to 5.0.0 (nightly) also in the gradle build
Andreas Beeker [Mon, 8 Mar 2021 22:36:08 +0000 (22:36 +0000)]
raise XmlBeans to 5.0.0 (nightly) also in the gradle build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887345 13f79535-47bb-0310-9956-ffa450edef68

3 years agoremove old batik jar
Andreas Beeker [Mon, 8 Mar 2021 22:29:26 +0000 (22:29 +0000)]
remove old batik jar

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887344 13f79535-47bb-0310-9956-ffa450edef68

3 years agoUse XmlBeans 5 nightly
Andreas Beeker [Mon, 8 Mar 2021 00:35:10 +0000 (00:35 +0000)]
Use XmlBeans 5 nightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887309 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd DeferredGeneration sample
PJ Fanning [Sat, 6 Mar 2021 09:10:58 +0000 (09:10 +0000)]
add DeferredGeneration sample

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887250 13f79535-47bb-0310-9956-ffa450edef68

3 years agoconvert tabs to spaces
PJ Fanning [Sat, 6 Mar 2021 01:51:17 +0000 (01:51 +0000)]
convert tabs to spaces

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887239 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd DeferredGeneration sample
PJ Fanning [Sat, 6 Mar 2021 01:48:57 +0000 (01:48 +0000)]
add DeferredGeneration sample

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887238 13f79535-47bb-0310-9956-ffa450edef68

3 years agoRemove unnecessary array conversion in HWPF FSPATable
Marius Volkhart [Mon, 1 Mar 2021 19:06:28 +0000 (19:06 +0000)]
Remove unnecessary array conversion in HWPF FSPATable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887044 13f79535-47bb-0310-9956-ffa450edef68

3 years agoRemove deprecated HWPF FSPA methods
Marius Volkhart [Mon, 1 Mar 2021 18:46:35 +0000 (18:46 +0000)]
Remove deprecated HWPF FSPA methods

These methods have been @Deprecated for years, and are part of @Internal structures.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887039 13f79535-47bb-0310-9956-ffa450edef68

3 years agoImprove performance of HSLFPictureData#write
Marius Volkhart [Mon, 1 Mar 2021 00:37:11 +0000 (00:37 +0000)]
Improve performance of HSLFPictureData#write

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887022 13f79535-47bb-0310-9956-ffa450edef68

3 years agoDeprecate functions that duplicate functionality
Marius Volkhart [Mon, 1 Mar 2021 00:25:23 +0000 (00:25 +0000)]
Deprecate functions that duplicate functionality

DrawingGroupRecord#processChildRecords and AbstractEscherHolderRecord#convertRawBytesToEscherRecords duplicate the functionality of AbstractEscherHolderRecord#decode. This makes the code harder to follow, as it is not clear when certain access patterns repeat. Accordingly, these functions are deprecated and flagged for removal.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887021 13f79535-47bb-0310-9956-ffa450edef68

3 years agoReview EscherContainerRecord#getChildRecords() call sites for unnecessary work
Marius Volkhart [Mon, 1 Mar 2021 00:04:51 +0000 (00:04 +0000)]
Review EscherContainerRecord#getChildRecords() call sites for unnecessary work

This started off as wanting to add the EscherContainerRecord#getChildCount() function in order to do an efficient check for how many children the container has. This was desirable in new code for editing HSSF pictures. The existing option of calling getChildRecords().size() was undesirable as this requires a list copy first.

In the process of finding call sites that would benefit from replacing getChildRecords().size(), I realized that several other patterns would benefit from eliminating a copy, such as iterating over the children in a for-each loop, and indexed access to specific children.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887020 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdd the ability to edit HSLFPictureData contents
Marius Volkhart [Sun, 28 Feb 2021 23:16:14 +0000 (23:16 +0000)]
Add the ability to edit HSLFPictureData contents

Pictures can now be edited by calling HSLFPictureData#setData(byte[]). The byte[] should contain the image data as an image viewer might read it.

To enable this functionality, a tighter coupling between the EscherBSERecords of the slideshow and the HSLFPictureData was required. This ensures that changes in image data size are accurately recorded in the records.

In the course of coupling the records and the HSLFPictureData, various scenarios arose where a mapping of records to pictures was non-trivial. Accordingly, the HSLFSlideShowImpl#matchPicturesAndRecords(...) function was added to perform a more sophisticated matching pass. This function is heavily exercised by org.apache.poi.hslf.usermodel.TestBugs.testFile[5] and PPTX2PNG.render[2], as well as the new TestPictures#testSlideshowWithIncorrectOffsets().

Closes #225

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887017 13f79535-47bb-0310-9956-ffa450edef68

3 years agoMake picture loading in HWPF PicturesTable easier to understand
Marius Volkhart [Sun, 28 Feb 2021 21:06:05 +0000 (21:06 +0000)]
Make picture loading in HWPF PicturesTable easier to understand

The recursion is no longer necessary due to the more defined structure of OfficeArtContent.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887016 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdd documentation to PICFAndOfficeArtData
Marius Volkhart [Sun, 28 Feb 2021 20:44:39 +0000 (20:44 +0000)]
Add documentation to PICFAndOfficeArtData

Adjust call sites based on defined behavior.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887015 13f79535-47bb-0310-9956-ffa450edef68

3 years agochange gradle build to get unreleased xmlbeans jar from ci-builds (like ant build...
PJ Fanning [Sun, 28 Feb 2021 19:48:22 +0000 (19:48 +0000)]
change gradle build to get unreleased xmlbeans jar from ci-builds (like ant build does)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887012 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSimplify OfficeArtContent#getBStoreContainer method
Marius Volkhart [Sun, 28 Feb 2021 19:40:23 +0000 (19:40 +0000)]
Simplify OfficeArtContent#getBStoreContainer method

Due to the new structure of the class, we can be more specific about how we load the BStore.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887011 13f79535-47bb-0310-9956-ffa450edef68

3 years agochange gradle build to get unreleased xmlbeans jar from ci-builds (like ant build...
PJ Fanning [Sun, 28 Feb 2021 19:28:39 +0000 (19:28 +0000)]
change gradle build to get unreleased xmlbeans jar from ci-builds (like ant build does)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887010 13f79535-47bb-0310-9956-ffa450edef68

3 years agoRename EscherRecordHolder to OfficeArtContent
Marius Volkhart [Sun, 28 Feb 2021 19:18:13 +0000 (19:18 +0000)]
Rename EscherRecordHolder to OfficeArtContent

While the class does indeed hold EscherRecords, due to recent refactoring it is much more structured now than it was before. The contents of the class now closely resemble the OfficeArtContent structure referenced in the MS-DOC spec. Naming the class after the specification structure makes it easier to find and understand.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887009 13f79535-47bb-0310-9956-ffa450edef68

3 years agoRework EscherRecordHolder parsing
Marius Volkhart [Sun, 28 Feb 2021 18:49:42 +0000 (18:49 +0000)]
Rework EscherRecordHolder parsing

Modify the parsing done by EscherRecordHolder to be more deterministic. The format of the OfficeArtContent structure, which the EscherRecordHolder represents, is well defined in the MS-DOC spec. A clear class structure makes it easier to reason about the availability of data.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887008 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdd documentation to EscherRecordTypes#DG_CONTAINER
Marius Volkhart [Sun, 28 Feb 2021 18:39:51 +0000 (18:39 +0000)]
Add documentation to EscherRecordTypes#DG_CONTAINER

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887007 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSimplify initialization of HWPF EscherRecordHolder
Marius Volkhart [Sun, 28 Feb 2021 16:47:43 +0000 (16:47 +0000)]
Simplify initialization of HWPF EscherRecordHolder

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886999 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdd documentation for HWPF FileInformationBlock DggInfo methods
Marius Volkhart [Sun, 28 Feb 2021 15:08:39 +0000 (15:08 +0000)]
Add documentation for HWPF FileInformationBlock DggInfo methods

This documentation comes from [MS-DOC] - v20191119.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886998 13f79535-47bb-0310-9956-ffa450edef68

3 years agoRevert "Replace magic constant with reference" changes
Marius Volkhart [Sat, 27 Feb 2021 19:08:49 +0000 (19:08 +0000)]
Revert "Replace magic constant with reference" changes

Reverts r1886986, r1886987 and r1886988. Incorrect conversion between int and shorts led to incorrect logic.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886989 13f79535-47bb-0310-9956-ffa450edef68

3 years agoReplace magic constant use of Escher Blip End type ID with reference
Marius Volkhart [Sat, 27 Feb 2021 18:33:56 +0000 (18:33 +0000)]
Replace magic constant use of Escher Blip End type ID with reference

Instead of referring to the magic constant 0xF117, reference the value in the EscherRecordTypes enum.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886988 13f79535-47bb-0310-9956-ffa450edef68

3 years agoReplace magic constant use of Escher Blip Start type ID with reference
Marius Volkhart [Sat, 27 Feb 2021 18:26:36 +0000 (18:26 +0000)]
Replace magic constant use of Escher Blip Start type ID with reference

Instead of referring to the magic constant 0xF018, reference the value in the EscherRecordTypes enum.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886987 13f79535-47bb-0310-9956-ffa450edef68

3 years agoReplace magic constant use of EscherBSERecord type ID with reference
Marius Volkhart [Sat, 27 Feb 2021 18:22:33 +0000 (18:22 +0000)]
Replace magic constant use of EscherBSERecord type ID with reference

Instead of referring to the magic constant 0xF007, reference the value in the EscherRecordTypes enum.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886986 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd missing license
PJ Fanning [Sat, 27 Feb 2021 01:29:21 +0000 (01:29 +0000)]
add missing license

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886965 13f79535-47bb-0310-9956-ffa450edef68

3 years agoFix bug with record indexes for HSSF Workbooks
Marius Volkhart [Sat, 27 Feb 2021 00:43:56 +0000 (00:43 +0000)]
Fix bug with record indexes for HSSF Workbooks

We have encountered workbooks that do not have a TabIdRecord (see 55982.xls). However, the WorkbookRecordList#updateRecordPos() method would still increment the position of the TabIdRecord for such workbooks. Changing the default position of the record from 0 to -1 indicates that the record position has now been set.

This bug was discovered while adding support for editing pictures in HSSF documents.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886963 13f79535-47bb-0310-9956-ffa450edef68

3 years agoEnable running more integration tests from Gradle.
Marius Volkhart [Fri, 26 Feb 2021 22:14:17 +0000 (22:14 +0000)]
Enable running more integration tests from Gradle.

This is particularly relevant for developers who import the Gradle project into their IDE and run tests using the Gradle test runner. Those developers were previously unable to debug integration tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886962 13f79535-47bb-0310-9956-ffa450edef68

3 years agoRemove the integrationTest task from the Gradle integrationtest project
Marius Volkhart [Fri, 26 Feb 2021 22:07:14 +0000 (22:07 +0000)]
Remove the integrationTest task from the Gradle integrationtest project

This task adds no additional configuration over the regular test task.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886961 13f79535-47bb-0310-9956-ffa450edef68

3 years agoRemove the test exclusion for RecordStresser and RecordsStresser from Gradle integrat...
Marius Volkhart [Fri, 26 Feb 2021 22:05:16 +0000 (22:05 +0000)]
Remove the test exclusion for RecordStresser and RecordsStresser from Gradle integration tests

These classes don't exist.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886960 13f79535-47bb-0310-9956-ffa450edef68

3 years agoEnable parallel tests from Gradle
Marius Volkhart [Fri, 26 Feb 2021 21:15:12 +0000 (21:15 +0000)]
Enable parallel tests from Gradle

Parallel tests are already enabled from Ant. This does the same for Gradle users.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886959 13f79535-47bb-0310-9956-ffa450edef68

3 years agoxmlsec version
PJ Fanning [Wed, 24 Feb 2021 21:42:01 +0000 (21:42 +0000)]
xmlsec version

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886893 13f79535-47bb-0310-9956-ffa450edef68

3 years agomissing ooxml-schemas-lite classes
PJ Fanning [Wed, 24 Feb 2021 21:26:33 +0000 (21:26 +0000)]
missing ooxml-schemas-lite classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886892 13f79535-47bb-0310-9956-ffa450edef68

3 years agoinclude batik in poi-bin artifact
Andreas Beeker [Tue, 23 Feb 2021 22:29:51 +0000 (22:29 +0000)]
include batik in poi-bin artifact

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886863 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd batik to forbidden-apis-check classpath
Andreas Beeker [Tue, 23 Feb 2021 21:59:56 +0000 (21:59 +0000)]
add batik to forbidden-apis-check classpath

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886862 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[bug-63046] Fix Java 16 build
Marius Volkhart [Mon, 22 Feb 2021 18:27:14 +0000 (18:27 +0000)]
[bug-63046] Fix Java 16 build

org.apache.santuario:xmlsec:2.2.0 has a dependency on SLF4J. We use this in SignatureInfo.java.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886811 13f79535-47bb-0310-9956-ffa450edef68

3 years agoUse upcoming XmlBeans 5.0.0 (working version 4.0.1)
Andreas Beeker [Mon, 22 Feb 2021 00:18:37 +0000 (00:18 +0000)]
Use upcoming XmlBeans 5.0.0 (working version 4.0.1)
Make batik optional as it doesn't work on the module-path
Use sub-components of batik as batik-all references them all again resulting in duplicated entries (maven poms haven't been migrated yet ...)
Remove SLF4j dependency

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886777 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[bug-63046] Use Log4j 2 for logging
Marius Volkhart [Sun, 21 Feb 2021 20:57:25 +0000 (20:57 +0000)]
[bug-63046] Use Log4j 2 for logging

This removes the POILogger and POILogFactory mechanism for logging. This mechanism was created at a time when the Java landscape looked very different than it does today.

Log4j 2 is an Apache Foundation project that is well maintained and is widely regarded as having good performance and capabilities. We use only the Log4j API artifact. This lets application developers choose how they want to capture logging events if at all. Integrations with Log4j 2 Core and Logback are available from the Log4j project.

Closes #224

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886770 13f79535-47bb-0310-9956-ffa450edef68

3 years agoUse UTF-8 when writing SVG files
Andreas Beeker [Sun, 21 Feb 2021 18:52:23 +0000 (18:52 +0000)]
Use UTF-8 when writing SVG files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886768 13f79535-47bb-0310-9956-ffa450edef68

3 years agotry re-eanbling xml entity config
PJ Fanning [Sun, 21 Feb 2021 18:31:49 +0000 (18:31 +0000)]
try re-eanbling xml entity config

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886766 13f79535-47bb-0310-9956-ffa450edef68

3 years agoFinanceLib: Simplify code and add a few more tests
Dominik Stadler [Thu, 18 Feb 2021 10:00:13 +0000 (10:00 +0000)]
FinanceLib: Simplify code and add a few more tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886658 13f79535-47bb-0310-9956-ffa450edef68

3 years agoManipulate individual data point properties
Alain Béarez [Wed, 17 Feb 2021 22:05:18 +0000 (22:05 +0000)]
Manipulate individual data point properties

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886642 13f79535-47bb-0310-9956-ffa450edef68

3 years agoCode cleanup AbstractEscherHolderRecord
Marius Volkhart [Wed, 17 Feb 2021 15:41:22 +0000 (15:41 +0000)]
Code cleanup AbstractEscherHolderRecord

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886623 13f79535-47bb-0310-9956-ffa450edef68

3 years agoDocumentation for some EscherRecordTypes
Marius Volkhart [Wed, 17 Feb 2021 15:10:17 +0000 (15:10 +0000)]
Documentation for some EscherRecordTypes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886620 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdd documentation for DrawingGroupRecord
Marius Volkhart [Wed, 17 Feb 2021 14:48:30 +0000 (14:48 +0000)]
Add documentation for DrawingGroupRecord

Documentation adapted from [MS-XLS].pdf v20190618.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886619 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[bug-63902] reference cloned sheet in cloned chart data series
Alain Béarez [Tue, 16 Feb 2021 23:39:19 +0000 (23:39 +0000)]
[bug-63902] reference cloned sheet in cloned chart data series

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886605 13f79535-47bb-0310-9956-ffa450edef68

3 years agoallow subclassing of code to gen comments table
PJ Fanning [Mon, 15 Feb 2021 21:48:26 +0000 (21:48 +0000)]
allow subclassing of code to gen comments table

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886547 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd method to test for strict ooxml format
PJ Fanning [Mon, 15 Feb 2021 21:05:57 +0000 (21:05 +0000)]
add method to test for strict ooxml format

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886545 13f79535-47bb-0310-9956-ffa450edef68

3 years agoDo not fail test which compares two documents if the timestamp in the ZIP header...
Dominik Stadler [Mon, 15 Feb 2021 15:23:49 +0000 (15:23 +0000)]
Do not fail test which compares two documents if the timestamp in the ZIP header field is different

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886532 13f79535-47bb-0310-9956-ffa450edef68

3 years agoDo not require NullPointerException to have a null-message on JDK < 16
Dominik Stadler [Mon, 15 Feb 2021 13:17:18 +0000 (13:17 +0000)]
Do not require NullPointerException to have a null-message on JDK < 16

It seems depending on the exact JDK some Exceptions have failure messages populated

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886527 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd test for reading core properties from ooxml strict file
PJ Fanning [Mon, 15 Feb 2021 00:34:12 +0000 (00:34 +0000)]
add test for reading core properties from ooxml strict file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886514 13f79535-47bb-0310-9956-ffa450edef68

3 years agoadd missing CTPhoneticRun
PJ Fanning [Sun, 14 Feb 2021 20:25:59 +0000 (20:25 +0000)]
add missing CTPhoneticRun

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886511 13f79535-47bb-0310-9956-ffa450edef68

3 years agofix typo
PJ Fanning [Sun, 14 Feb 2021 00:05:02 +0000 (00:05 +0000)]
fix typo

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886497 13f79535-47bb-0310-9956-ffa450edef68

3 years agosmall refactor
PJ Fanning [Sat, 13 Feb 2021 23:33:24 +0000 (23:33 +0000)]
small refactor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886495 13f79535-47bb-0310-9956-ffa450edef68

3 years agoallo XSSFReader to be sublclassed with implementation that allows OOXMl Strict files
PJ Fanning [Sat, 13 Feb 2021 19:43:07 +0000 (19:43 +0000)]
allo XSSFReader to be sublclassed with implementation that allows OOXMl Strict files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886493 13f79535-47bb-0310-9956-ffa450edef68

3 years agobatik 1.14
PJ Fanning [Sat, 13 Feb 2021 14:49:40 +0000 (14:49 +0000)]
batik 1.14

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886491 13f79535-47bb-0310-9956-ffa450edef68

3 years agoFix GitHub Action yaml for Gradle build
Marius Volkhart [Thu, 11 Feb 2021 22:27:46 +0000 (22:27 +0000)]
Fix GitHub Action yaml for Gradle build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886449 13f79535-47bb-0310-9956-ffa450edef68

3 years agoImport slide notes when importing slide content
Alain Béarez [Mon, 8 Feb 2021 20:34:14 +0000 (20:34 +0000)]
Import slide notes when importing slide content

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886338 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[github-219] Add GitHub Action to verify Gradle wrapper
Marius Volkhart [Sun, 7 Feb 2021 11:03:01 +0000 (11:03 +0000)]
[github-219] Add GitHub Action to verify Gradle wrapper

Thanks to Valery Yatsynovich. This closes #219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886276 13f79535-47bb-0310-9956-ffa450edef68

3 years agoCache Gradle wrapper & caches during GitHub Actions
Marius Volkhart [Sun, 7 Feb 2021 00:30:41 +0000 (00:30 +0000)]
Cache Gradle wrapper & caches during GitHub Actions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886266 13f79535-47bb-0310-9956-ffa450edef68

3 years agoCache Maven repo during GitHub Actions
Marius Volkhart [Sat, 6 Feb 2021 15:23:11 +0000 (15:23 +0000)]
Cache Maven repo during GitHub Actions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886257 13f79535-47bb-0310-9956-ffa450edef68

3 years agoremove accidental commit
PJ Fanning [Tue, 2 Feb 2021 21:14:16 +0000 (21:14 +0000)]
remove accidental commit

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886144 13f79535-47bb-0310-9956-ffa450edef68

3 years ago[bug-65120] PartAlreadyExistsException when creating cell comments (after some commen...
PJ Fanning [Tue, 2 Feb 2021 21:13:32 +0000 (21:13 +0000)]
[bug-65120] PartAlreadyExistsException when creating cell comments (after some comments removed). Thanks to Raúl Wegmann

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886143 13f79535-47bb-0310-9956-ffa450edef68

3 years agoFix inconsistent logging statement
Marius Volkhart [Mon, 1 Feb 2021 01:02:26 +0000 (01:02 +0000)]
Fix inconsistent logging statement

The conditions check for max, but the logging was copy/pasted and still uses the minimum.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886089 13f79535-47bb-0310-9956-ffa450edef68

3 years agoClone only content of imported chart
Alain Béarez [Mon, 1 Feb 2021 00:46:25 +0000 (00:46 +0000)]
Clone only content of imported chart

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886087 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 30 Jan 2021 22:58:14 +0000 (22:58 +0000)]
Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886070 13f79535-47bb-0310-9956-ffa450edef68

3 years agoBug 65099: Fix incorrect handling of styles in XWPFStyle.getUsedStyleList
Dominik Stadler [Sat, 30 Jan 2021 18:42:14 +0000 (18:42 +0000)]
Bug 65099: Fix incorrect handling of styles in XWPFStyle.getUsedStyleList

Closes github #216

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886063 13f79535-47bb-0310-9956-ffa450edef68

3 years agoAdjust integration-test slightly for running mass-regression-tests
Dominik Stadler [Sat, 30 Jan 2021 18:42:08 +0000 (18:42 +0000)]
Adjust integration-test slightly for running mass-regression-tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886062 13f79535-47bb-0310-9956-ffa450edef68

3 years agoApply IDE suggestions, add toString(), adjust JavaDoc and simplify code slightly
Dominik Stadler [Sat, 30 Jan 2021 18:42:05 +0000 (18:42 +0000)]
Apply IDE suggestions, add toString(), adjust JavaDoc and simplify code slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886061 13f79535-47bb-0310-9956-ffa450edef68

3 years agoEnable storing an SXSSF workbook twice
Dominik Stadler [Sat, 30 Jan 2021 18:41:57 +0000 (18:41 +0000)]
Enable storing an SXSSF workbook twice

Verify this via a unit-test for all types of workbooks
Add a test to verify the contents is byte-for-byte equal
Also remove an overwritten test which works the same now for all three workbook-types

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886060 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Thu, 28 Jan 2021 00:08:35 +0000 (00:08 +0000)]
Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885954 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Tue, 26 Jan 2021 23:26:50 +0000 (23:26 +0000)]
Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885922 13f79535-47bb-0310-9956-ffa450edef68

3 years agotry to fix windows integration tests
Andreas Beeker [Sun, 24 Jan 2021 22:25:08 +0000 (22:25 +0000)]
try to fix windows integration tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885888 13f79535-47bb-0310-9956-ffa450edef68

3 years agoReplace deprecated methods used in tests
Alain Béarez [Sun, 24 Jan 2021 20:01:36 +0000 (20:01 +0000)]
Replace deprecated methods used  in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885886 13f79535-47bb-0310-9956-ffa450edef68

3 years agoSonar fixes
Andreas Beeker [Sat, 23 Jan 2021 23:04:49 +0000 (23:04 +0000)]
Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885859 13f79535-47bb-0310-9956-ffa450edef68

3 years agoJunit5 - fix logging to console
Andreas Beeker [Sat, 23 Jan 2021 23:04:31 +0000 (23:04 +0000)]
Junit5 - fix logging to console

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885858 13f79535-47bb-0310-9956-ffa450edef68