source.dussan.org Git

Dominik Stadler [Wed, 8 Nov 2017 14:59:08 +0000 (14:59 +0000)]

Some JavaDoc adjustments, typos, IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 7 Nov 2017 07:26:48 +0000 (07:26 +0000)]

bug 61730: remove asSet function from unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814462 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 7 Nov 2017 07:21:24 +0000 (07:21 +0000)]

bug 61730: remove CellRangeAddressBase which is eager. The lazy iterator is safer, less likely to cause an OOM/DoS.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814461 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 7 Nov 2017 01:54:25 +0000 (01:54 +0000)]

bug 61730: add javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814451 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 7 Nov 2017 00:29:09 +0000 (00:29 +0000)]

bug 61730: add iterator interface to CellRangeAddressBase for iterating over CellAddresses

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814448 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 6 Nov 2017 22:19:06 +0000 (22:19 +0000)]

bug 61727: make TestCellRangeUtil unit tests more explicit

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814444 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 6 Nov 2017 20:26:32 +0000 (20:26 +0000)]

Enhance unit-test to Verify that bug 58785 is already via via some other change

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814440 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 6 Nov 2017 19:51:41 +0000 (19:51 +0000)]

bug 61727: CellRangeUtil Merge cell ranges broken. Thanks for Sven Rieckhoff for the patch

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814432 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 5 Nov 2017 20:33:35 +0000 (20:33 +0000)]

Adjust some tests to properly close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814374 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 5 Nov 2017 20:33:28 +0000 (20:33 +0000)]

Bug #57517: Fix various things in HSSFOptimiser to make many more cases work fine: Column styles, row styles, user defined styles, ...
Also call optimise in integration-tests and handle some cases of invalid content in files.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814373 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 4 Nov 2017 13:45:12 +0000 (13:45 +0000)]

Add test-case which shows that bug 55814 is fixed already by other changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814290 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 4 Nov 2017 13:45:04 +0000 (13:45 +0000)]

Fix some IntelliJ and JavaDoc warnings and avoid code-duplication and duplicated test-methods
Adjust tests slighlty, close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814289 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 10:11:20 +0000 (10:11 +0000)]

bug 61474, github #81: add ShiftMode#ColumnCopy for FormulaShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814268 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 09:32:05 +0000 (09:32 +0000)]

bug 61474, github #81: add shiftMergedRegions to BaseRowColShifter interface

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814264 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 09:17:09 +0000 (09:17 +0000)]

bug 61474, github #81: bump visibility of abstract methods in BaseRowColShifter abstract class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814262 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 09:07:32 +0000 (09:07 +0000)]

bug 61474, github #81: pull up methods from RowShifter to BaseRowColShifter, since both row and column shifting should be able to shift formulas, comments, merged regions, conditional formatting, etc; add @since decorators for new *ColumnShifter and *RowColShifter classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814261 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 08:54:20 +0000 (08:54 +0000)]

bug 61474, github #81: remove @Internal RowShifter#updateRowFormulas, move to XSSFRowColShifter; implement ColumnShifter#updateFormulas; remove duplicated JavaDocs (better to inherit)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814260 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 07:58:41 +0000 (07:58 +0000)]

bug 61474, github #81: implement updateConditionalFormatting for ColumnShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814259 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 07:42:33 +0000 (07:42 +0000)]

bug 61474, github #81: implement updateNamedRanges for ColumnShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814258 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 07:29:53 +0000 (07:29 +0000)]

bug 61474, github #81: fix ColumnShifter#removalNeeded to use columns instead of rows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814257 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 07:17:44 +0000 (07:17 +0000)]

bug 61474, github #81: add ColumnShifter interface; deduplicate some code in RowShifter, CFRecordsAggregate

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814256 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 05:48:18 +0000 (05:48 +0000)]

bug 61474, #81 on github: add @Override annotation; rename FormulaShifter shifter to FormulaShifter formulaShifter to reduce confusion with the shifter variable referring to the RowShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814255 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 05:29:52 +0000 (05:29 +0000)]

bug 61474,github-81: add FormulaShifter.createForColumnShift and ShiftMode.ColumnMove

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814254 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 04:29:45 +0000 (04:29 +0000)]

github-81: extract routines in HSSFRow#shiftRows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814253 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 02:57:01 +0000 (02:57 +0000)]

rename ambiguous variable name shifter -> formulaShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814247 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 4 Nov 2017 02:49:52 +0000 (02:49 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814245 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 2 Nov 2017 23:15:19 +0000 (23:15 +0000)]

#61671 - XSLFSlide does not contain isHidden and setHidden like HSLFSlide does

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814122 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 1 Nov 2017 11:21:25 +0000 (11:21 +0000)]

Javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813966 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 31 Oct 2017 11:10:08 +0000 (11:10 +0000)]

eventually we want to forbid StringBuffer usage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813875 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Tue, 31 Oct 2017 10:24:47 +0000 (10:24 +0000)]

use StringBuilder in more places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813869 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 31 Oct 2017 10:17:38 +0000 (10:17 +0000)]

github-68: add @Override to o.a.p.ss.usermodel.charts.DataSources. Thanks to Alain-Bearez.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813868 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Tue, 31 Oct 2017 09:51:51 +0000 (09:51 +0000)]

add test case for bug 61701

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813864 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Tue, 31 Oct 2017 09:48:23 +0000 (09:48 +0000)]

add test case for bug 61701 and use StringBuilder in more places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813863 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 31 Oct 2017 09:38:03 +0000 (09:38 +0000)]

github-77: Remove the 'public' modifier to make fields package protected (findbugs-MS_PKGPROTECT). Thanks to BruceKuiLiu for the PR. This closes #77 on github.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813859 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 31 Oct 2017 01:45:03 +0000 (01:45 +0000)]

consolidate duplicated code: XSSFWorkbook#setBookViewsIfMissing()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813841 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 31 Oct 2017 01:08:43 +0000 (01:08 +0000)]

bump the Eclipse compile source to Java 1.8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813840 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 26 Oct 2017 18:10:09 +0000 (18:10 +0000)]

bug 61630: Patch from Daniel to fix XSSFExportToXML IllegalArgumentException: Comparison method violates its general contract! (bug 61630, comment 17, attachment 35468). Found during manual testing.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813443 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 25 Oct 2017 20:19:23 +0000 (20:19 +0000)]

remove test-hssf ant target

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813351 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 25 Oct 2017 18:59:54 +0000 (18:59 +0000)]

remove test-ss and test-ooxml-ss ant targets, as these were causing problems with the build/ooxml-testokfile.txt being written, requiring test-ooxml to be rerun on subsequent ant calls even if had previously completed successfully and not modifications to the ooxml source had been made.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813342 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 25 Oct 2017 18:19:12 +0000 (18:19 +0000)]

bug 61630: further XSSFExportToXML performance improvements from Daniel (bug 61630 comment 15, attachment 35450)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813332 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Oct 2017 23:44:21 +0000 (23:44 +0000)]

bug 61630: revert r1813240, which failed the integration test with org.apache.poi.stress.XSSFFileHandler on test-data/spreadsheet/59025.xlsx

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813243 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 24 Oct 2017 23:00:12 +0000 (23:00 +0000)]

bug 61630: further XSSFExportToXML performance improvements from Daniel (comment 9, bug 61630 attachment 35450)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813240 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Mon, 23 Oct 2017 21:17:49 +0000 (21:17 +0000)]

Remove more deprecated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813102 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Mon, 23 Oct 2017 20:39:27 +0000 (20:39 +0000)]

Remove more deprecated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813092 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Mon, 23 Oct 2017 20:27:47 +0000 (20:27 +0000)]

Remove more deprecated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813085 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Sun, 22 Oct 2017 13:53:42 +0000 (13:53 +0000)]

Introduce new BorderFormatting methods to expose border styles

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812917 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Sun, 22 Oct 2017 13:03:33 +0000 (13:03 +0000)]

Remove use of deprecated methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812911 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Sun, 22 Oct 2017 12:45:35 +0000 (12:45 +0000)]

Remove use of deprecated methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812907 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Sun, 22 Oct 2017 12:07:14 +0000 (12:07 +0000)]

Remove use of deprecated methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812901 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 18 Oct 2017 18:26:41 +0000 (18:26 +0000)]

Add getter/setter for ReadingOrder to XSSF, closes issue #73

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812558 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 18 Oct 2017 18:21:29 +0000 (18:21 +0000)]

Bump up the Eclipse JVM version to 8 to match Ant

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812557 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 18 Oct 2017 18:16:48 +0000 (18:16 +0000)]

Bump up the Eclipse JVM version

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812556 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 16:04:06 +0000 (16:04 +0000)]

bug 61630: performance improvements in XSSFExportToXml. Thanks to Daniel for the patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812546 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 14:40:56 +0000 (14:40 +0000)]

cleanup for r1812470: avoid NPEs from string.isEmpty()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812532 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 14:40:05 +0000 (14:40 +0000)]

fix compile error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812531 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 14:29:56 +0000 (14:29 +0000)]

cleanup for r1812475: avoid NPEs from string.isEmpty()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812520 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 14:08:43 +0000 (14:08 +0000)]

cleanup for r1812476: avoid NPEs from string.isEmpty()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812516 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 08:41:42 +0000 (08:41 +0000)]

replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null if it is not already

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 08:41:25 +0000 (08:41 +0000)]

prefer literal.equals(variable) over variable.equals(literal)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812475 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 08:22:51 +0000 (08:22 +0000)]

convert "".equals(string) to string.isEmpty()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 08:10:36 +0000 (08:10 +0000)]

simplfy PackagingURIHelper#combine boolean logic using xor and replacing +FORWARD_SLASH_CHAR with FORWARD_SLASH_STRING

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812468 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 07:47:25 +0000 (07:47 +0000)]

fix typo

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812464 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 07:45:53 +0000 (07:45 +0000)]

string.equals("") -> string.isEmpty() or "".equals(string)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 18 Oct 2017 07:33:07 +0000 (07:33 +0000)]

for -> foreach
string.equals() -> string.isEmpty() or .equals(string)
ArrayList -> List

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812461 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 17 Oct 2017 07:43:41 +0000 (07:43 +0000)]

IntelliJ: simplify boolean logic

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812363 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 17 Oct 2017 07:10:25 +0000 (07:10 +0000)]

remove deprecated XSSFRowShifter.shiftMerged(int,int,int) method; replaced with RowShifter.shiftMergedRegions(int,int,int) in POI 3.15 beta 2

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812354 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 17 Oct 2017 06:13:09 +0000 (06:13 +0000)]

ignore gradle/, gradlew, and gradlew.bat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812351 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dustin Spicuzza [Mon, 16 Oct 2017 01:35:31 +0000 (01:35 +0000)]

Bug 61584: Fix XDGFPage variable typo causing crash

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812240 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 16 Oct 2017 01:34:13 +0000 (01:34 +0000)]

github-79: add String.toString() to forbidden API's

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812239 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Sun, 15 Oct 2017 20:50:58 +0000 (20:50 +0000)]

Make public static members final [thanks to Kui Liu]. This close #78.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812234 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Sun, 15 Oct 2017 20:34:10 +0000 (20:34 +0000)]

Remove unnecessary toString calls [thanks to Kui Liu]. This close #79.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812233 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Sun, 15 Oct 2017 20:25:33 +0000 (20:25 +0000)]

Remove unnecessary StringBuilder [thanks to Kui Liu]. This close #80.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812232 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 13 Oct 2017 09:40:22 +0000 (09:40 +0000)]

Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests.
This closes #74, This closes #75, This closes #76

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 11 Oct 2017 18:32:13 +0000 (18:32 +0000)]

Fix aparent copy/paste error in XSSFBorderFormatting

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811867 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 11 Oct 2017 18:32:01 +0000 (18:32 +0000)]

Bug 58068: Add a method to pass the actual Color to StylesTable.findFont().

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811866 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 11 Oct 2017 18:31:34 +0000 (18:31 +0000)]

adjust tests, javadoc, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811865 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 11 Oct 2017 05:32:05 +0000 (05:32 +0000)]

Remove "filling" in IntList as this has no effect whatsoever as far as I could see
Fix some IntelliJ warnings, missing JavaDoc, typos, Findbugs issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811793 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 9 Oct 2017 19:35:43 +0000 (19:35 +0000)]

Add more output to the pre-check to help in analysis some strange build-failures in CI, e.g. INFRA-15244

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811597 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 9 Oct 2017 19:35:39 +0000 (19:35 +0000)]

Fix target compile-ooxml-ss, it needs the crypt-code now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811596 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 9 Oct 2017 19:35:32 +0000 (19:35 +0000)]

Add test which shows that bug 51262 is fixed now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811595 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 7 Oct 2017 06:11:12 +0000 (06:11 +0000)]

Apply patch from bug 61096: Add support for modules in VBAMacroReader

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811383 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 6 Oct 2017 17:41:20 +0000 (17:41 +0000)]

Bug 61586: Add test which shows that it works as expected

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811355 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 4 Oct 2017 19:54:41 +0000 (19:54 +0000)]

Bug 61564: Try to get rid of the Java 9 illegal access warning now that we run Java 8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811145 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 4 Oct 2017 19:54:21 +0000 (19:54 +0000)]

Add some more code from the separate integration test project to be able to publish the femaining functionality as separate project at some point

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811144 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 28 Sep 2017 14:36:53 +0000 (14:36 +0000)]

Bug 61064: Support behavior of function CEILING in newer versions of Microsoft Excel

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1810007 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 28 Sep 2017 13:12:32 +0000 (13:12 +0000)]

Bug 61082: Adjust JavaDoc for getFirst/LastRow/Cell to explain that there might be empty rows/cells included in the counts

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809988 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 28 Sep 2017 09:56:45 +0000 (09:56 +0000)]

Fix bug 61516: when copying cells with formulas we should properly check for references that are invalid afterwards.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809967 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 26 Sep 2017 12:40:38 +0000 (12:40 +0000)]

Adjust some unit-tests, use try-with-resource, enable test which works now, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809739 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 26 Sep 2017 12:33:08 +0000 (12:33 +0000)]

Replace "getEntry() plus catch" by "hasEntry()" in HSSFWorkbook

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809738 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 26 Sep 2017 12:31:51 +0000 (12:31 +0000)]

Fixup change for CellReference to keep the behavior the same as before

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809737 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 26 Sep 2017 12:22:53 +0000 (12:22 +0000)]

Remove empty directories beneath "scratchpad"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809735 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 26 Sep 2017 08:26:05 +0000 (08:26 +0000)]

Replace deprecated CellReference class and some other warnings fixed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809714 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 25 Sep 2017 15:10:40 +0000 (15:10 +0000)]

Fix some Sonar issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809636 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 25 Sep 2017 14:45:14 +0000 (14:45 +0000)]

Replace the incompatible new interface method endSheet() with a Java 8 default method so existing implementations do not need to be adjusted. Also use this for headerFooter() and remove the empty implementations that are now obsolete.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809635 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Mon, 25 Sep 2017 12:53:10 +0000 (12:53 +0000)]

Bug 61349 -- bump limits on classes that caused regressions in Dominik's regression corpus. Many thanks to Dominik Stadler for running the regression tests!!!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809623 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

PJ Fanning [Sat, 23 Sep 2017 14:03:25 +0000 (14:03 +0000)]

Remove more deprecated classes and methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809428 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 23 Sep 2017 10:26:27 +0000 (10:26 +0000)]

Fix compiling Examples after adding new interface-method, fix compiler warnings and adjust some broken Javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809388 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 23 Sep 2017 07:44:09 +0000 (07:44 +0000)]

Tried to enable this test, but it is broken since a long time and I am not sure how this is expected to behave...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809372 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 23 Sep 2017 07:41:27 +0000 (07:41 +0000)]

Apply patch to add endSheet() to the XSSFEventBasedExcelExtractor, fixes bug 60737, thanks to user zakim for the patch

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809371 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 23 Sep 2017 07:38:01 +0000 (07:38 +0000)]

More IntelliJ warnings fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809370 13f79535-47bb-0310-9956-ffa450edef68