]> source.dussan.org Git - redmine.git/log
redmine.git
5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/project.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:54:12 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/project.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18832 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation in app/controllers/wiki_c...
Toshi MARUYAMA [Tue, 22 Oct 2019 15:54:00 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/controllers/wiki_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18831 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/models/role.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:53:48 +0000 (15:53 +0000)]
code layout clean up app/models/role.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18830 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/role.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 15:53:37 +0000 (15:53 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/role.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18829 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/NestedMethodDefinition in test/unit/lib/redmine/menu_...
Toshi MARUYAMA [Tue, 22 Oct 2019 15:35:38 +0000 (15:35 +0000)]
code cleanup: rubocop: fix Lint/NestedMethodDefinition in test/unit/lib/redmine/menu_manager/menu_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18828 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix random test failure of ProjectQueryTest (#29482)
Toshi MARUYAMA [Tue, 22 Oct 2019 15:35:27 +0000 (15:35 +0000)]
fix random test failure of ProjectQueryTest (#29482)

git-svn-id: http://svn.redmine.org/redmine/trunk@18827 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoSkip AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png when ImageMagick...
Go MAEDA [Tue, 22 Oct 2019 14:12:09 +0000 (14:12 +0000)]
Skip AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png when ImageMagick convert is not available (#32307, #22481).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18826 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesArou...
Toshi MARUYAMA [Tue, 22 Oct 2019 13:44:15 +0000 (13:44 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/timelog_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18825 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesArou...
Toshi MARUYAMA [Tue, 22 Oct 2019 13:44:04 +0000 (13:44 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/messages_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18824 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesArou...
Toshi MARUYAMA [Tue, 22 Oct 2019 13:43:52 +0000 (13:43 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/boards_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18823 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/applicatio...
Toshi MARUYAMA [Tue, 22 Oct 2019 13:43:40 +0000 (13:43 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/application_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18822 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/applicat...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:41:21 +0000 (12:41 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/application_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18821 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/scm/adapters...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:41:09 +0000 (12:41 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/scm/adapters/abstract_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18820 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builde...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:57 +0000 (12:40 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builders.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18819 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: add new detected files to Performance/RedundantBlockCall (#32308)
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:46 +0000 (12:40 +0000)]
rubocop: add new detected files to Performance/RedundantBlockCall (#32308)

git-svn-id: http://svn.redmine.org/redmine/trunk@18818 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "class << self" syntax for Redmine::Views::Builders#for (#32308)
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:33 +0000 (12:40 +0000)]
use "class << self" syntax for Redmine::Views::Builders#for (#32308)

git-svn-id: http://svn.redmine.org/redmine/trunk@18817 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "if block_given?" instead of "if block" in lib/redmine/views/builders.rb (#32308)
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:22 +0000 (12:40 +0000)]
use "if block_given?" instead of "if block" in lib/redmine/views/builders.rb (#32308)

git-svn-id: http://svn.redmine.org/redmine/trunk@18816 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "if block_given?" instead of "if block" in lib/redmine/views/builders/structure...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:40:11 +0000 (12:40 +0000)]
use "if block_given?" instead of "if block" in lib/redmine/views/builders/structure.rb (#32308)

git-svn-id: http://svn.redmine.org/redmine/trunk@18815 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in test/functional/reposito...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:16:56 +0000 (12:16 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in test/functional/repositories_git_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18814 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builde...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:10:14 +0000 (12:10 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builders/structure.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18813 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:10:03 +0000 (12:10 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine/views/builders/json_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18812 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine...
Toshi MARUYAMA [Tue, 22 Oct 2019 12:09:52 +0000 (12:09 +0000)]
code cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine/views/builders/xml_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18811 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLa...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:41:21 +0000 (11:41 +0000)]
code cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLayout in test/unit/lib/redmine/wiki_formatting/markdown_formatter_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18810 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/helpers/application_helper_test.rb from Layout/CaseIndentation...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:41:10 +0000 (11:41 +0000)]
rubocop: remove test/helpers/application_helper_test.rb from Layout/CaseIndentation and Layout/IndentHeredoc fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18809 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:58 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_syntax_highlight

git-svn-id: http://svn.redmine.org/redmine/trunk@18808 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:47 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_non_closing_pre_blocks_should_be_closed

git-svn-id: http://svn.redmine.org/redmine/trunk@18807 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:36 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_pre_content_should_not_parse_wiki_and_redmine_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18806 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:23 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_pre_tags

git-svn-id: http://svn.redmine.org/redmine/trunk@18805 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:12 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_syntax_highlight_ampersand_in_textile

git-svn-id: http://svn.redmine.org/redmine/trunk@18804 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:40:00 +0000 (11:40 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_inline_images_inside_tags

git-svn-id: http://svn.redmine.org/redmine/trunk@18803 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:39:49 +0000 (11:39 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_table_of_content

git-svn-id: http://svn.redmine.org/redmine/trunk@18802 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:39:38 +0000 (11:39 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_table_of_content_should_generate_unique_anchors

git-svn-id: http://svn.redmine.org/redmine/trunk@18801 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:39:26 +0000 (11:39 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_table_of_content_should_contain_included_page_headings

git-svn-id: http://svn.redmine.org/redmine/trunk@18800 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:39:14 +0000 (11:39 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in ApplicationHelperTest#test_section_edit_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18799 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/MultipleComparison in lib/redmine/scm/adapters/git_a...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:31:17 +0000 (11:31 +0000)]
code cleanup: rubocop: fix Style/MultipleComparison in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18798 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/UnneededSort in test/unit/repository_git_test.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:31:05 +0000 (11:31 +0000)]
code cleanup: rubocop: fix Style/UnneededSort in test/unit/repository_git_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18797 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/UnneededInterpolation in lib/redmine/scm/adapters...
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:54 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Style/UnneededInterpolation in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18796 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in app/models/setting.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:41 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18795 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/setting.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:29 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18794 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArray in lib/redmine/default_data/loader.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:17 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Layout/AlignArray in lib/redmine/default_data/loader.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18793 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArray in app/models/setting.rb
Toshi MARUYAMA [Tue, 22 Oct 2019 11:30:05 +0000 (11:30 +0000)]
code cleanup: rubocop: fix Layout/AlignArray in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18792 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemoves duplicated 'group_by' id (#29482).
Go MAEDA [Tue, 22 Oct 2019 05:04:37 +0000 (05:04 +0000)]
Removes duplicated 'group_by' id (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18791 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix display type in query form view (#29482).
Go MAEDA [Tue, 22 Oct 2019 05:03:02 +0000 (05:03 +0000)]
Fix display type in query form view (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18790 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTraditional Chinese translation update (#32316).
Go MAEDA [Tue, 22 Oct 2019 04:11:43 +0000 (04:11 +0000)]
Traditional Chinese translation update (#32316).

Patch by ChunChang Lo.

git-svn-id: http://svn.redmine.org/redmine/trunk@18789 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove code for unsupported versions of Rails from open_id_authentication (#32297).
Go MAEDA [Tue, 22 Oct 2019 01:34:21 +0000 (01:34 +0000)]
Remove code for unsupported versions of Rails from open_id_authentication (#32297).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18788 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix random test failure of ProjectQueryTest (#29482).
Go MAEDA [Mon, 21 Oct 2019 07:20:57 +0000 (07:20 +0000)]
Fix random test failure of ProjectQueryTest (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18787 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoJapanese translation update (#32303).
Go MAEDA [Sun, 20 Oct 2019 08:52:02 +0000 (08:52 +0000)]
Japanese translation update (#32303).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18786 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove label_show_closed_projects from all translation files (#29482).
Go MAEDA [Sun, 20 Oct 2019 04:32:37 +0000 (04:32 +0000)]
Remove label_show_closed_projects from all translation files (#29482).

The string has been removed from en.yml in r18761.

git-svn-id: http://svn.redmine.org/redmine/trunk@18785 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate locales (#29482).
Go MAEDA [Sat, 19 Oct 2019 23:32:44 +0000 (23:32 +0000)]
Update locales (#29482).

git-svn-id: http://svn.redmine.org/redmine/trunk@18784 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in app/models/attachment.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 13:34:16 +0000 (13:34 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in app/models/attachment.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18783 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mail_handler.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 13:34:05 +0000 (13:34 +0000)]
code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mail_handler.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18782 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/attachment.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 13:33:54 +0000 (13:33 +0000)]
code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/attachment.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18781 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/issue.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 13:33:43 +0000 (13:33 +0000)]
code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18780 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/user.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 13:33:32 +0000 (13:33 +0000)]
code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/user.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18779 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mailer.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 13:33:21 +0000 (13:33 +0000)]
code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mailer.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18778 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/scm/adapters...
Toshi MARUYAMA [Sat, 19 Oct 2019 13:33:10 +0000 (13:33 +0000)]
code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/scm/adapters/abstract_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18777 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/helpers...
Toshi MARUYAMA [Sat, 19 Oct 2019 13:32:59 +0000 (13:32 +0000)]
code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/helpers/gantt.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18776 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: enable Lint/IneffectiveAccessModifier
Toshi MARUYAMA [Sat, 19 Oct 2019 13:32:48 +0000 (13:32 +0000)]
rubocop: enable Lint/IneffectiveAccessModifier

git-svn-id: http://svn.redmine.org/redmine/trunk@18775 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/controllers/contex...
Toshi MARUYAMA [Sat, 19 Oct 2019 13:32:37 +0000 (13:32 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/controllers/context_menus_controller.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18774 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CommentIndentation in lib/redmine/wiki_formatting...
Toshi MARUYAMA [Sat, 19 Oct 2019 12:25:46 +0000 (12:25 +0000)]
code cleanup: rubocop: fix Layout/CommentIndentation in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18773 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CommentIndentation in app/models/mailer.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 12:25:34 +0000 (12:25 +0000)]
code cleanup: rubocop: fix Layout/CommentIndentation in app/models/mailer.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18772 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceBeforeComma in test/unit/lib/redmine/helpers...
Toshi MARUYAMA [Sat, 19 Oct 2019 12:25:22 +0000 (12:25 +0000)]
code cleanup: rubocop: fix Layout/SpaceBeforeComma in test/unit/lib/redmine/helpers/calendar_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18771 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up test/unit/time_entry_test.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 12:25:11 +0000 (12:25 +0000)]
code layout clean up test/unit/time_entry_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18770 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceBeforeComma in lib/redmine/utils.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 12:24:58 +0000 (12:24 +0000)]
code cleanup: rubocop: fix Layout/SpaceBeforeComma in lib/redmine/utils.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18769 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTest failure (#29482).
Jean-Philippe Lang [Sat, 19 Oct 2019 12:18:15 +0000 (12:18 +0000)]
Test failure (#29482).

git-svn-id: http://svn.redmine.org/redmine/trunk@18768 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUse radio buttons to choose display type (#29482).
Jean-Philippe Lang [Sat, 19 Oct 2019 12:14:21 +0000 (12:14 +0000)]
Use radio buttons to choose display type (#29482).

git-svn-id: http://svn.redmine.org/redmine/trunk@18767 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoSet default columns for the projects list (#29482).
Jean-Philippe Lang [Sat, 19 Oct 2019 11:43:23 +0000 (11:43 +0000)]
Set default columns for the projects list (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18766 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoOption to switch between table list and board list (#29482).
Jean-Philippe Lang [Sat, 19 Oct 2019 11:42:20 +0000 (11:42 +0000)]
Option to switch between table list and board list (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18765 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFilter after project custom fields (#29482).
Jean-Philippe Lang [Sat, 19 Oct 2019 11:39:02 +0000 (11:39 +0000)]
Filter after project custom fields (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18764 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFilter after parent project (#29482).
Jean-Philippe Lang [Sat, 19 Oct 2019 11:38:15 +0000 (11:38 +0000)]
Filter after parent project (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18763 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFilter after projects (#29482).
Jean-Philippe Lang [Sat, 19 Oct 2019 11:37:30 +0000 (11:37 +0000)]
Filter after projects (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18762 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFilters for Projects page (#29482).
Jean-Philippe Lang [Sat, 19 Oct 2019 11:36:13 +0000 (11:36 +0000)]
Filters for Projects page (#29482).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18761 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/utils.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 11:16:06 +0000 (11:16 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/utils.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18760 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/unified_diff.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 11:15:54 +0000 (11:15 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/unified_diff.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18759 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in app/models/project.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 11:15:43 +0000 (11:15 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in app/models/project.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18758 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix stderr_log_file and strip_credential of Redmine::Scm::Adapters::AbstractAdapter...
Toshi MARUYAMA [Sat, 19 Oct 2019 11:15:30 +0000 (11:15 +0000)]
fix stderr_log_file and strip_credential of Redmine::Scm::Adapters::AbstractAdapter are not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18757 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoReturn to version page after the issue is created (#28138).
Jean-Philippe Lang [Sat, 19 Oct 2019 10:23:06 +0000 (10:23 +0000)]
Return to version page after the issue is created (#28138).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18756 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDisplay new issue link in version page (#28138).
Jean-Philippe Lang [Sat, 19 Oct 2019 10:22:16 +0000 (10:22 +0000)]
Display new issue link in version page (#28138).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18755 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFixed that QueriesController can not handle subclass of IssueQuery (#25265).
Jean-Philippe Lang [Sat, 19 Oct 2019 10:13:12 +0000 (10:13 +0000)]
Fixed that QueriesController can not handle subclass of IssueQuery (#25265).

git-svn-id: http://svn.redmine.org/redmine/trunk@18754 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdates for 4.0.5 release.
Jean-Philippe Lang [Sat, 19 Oct 2019 09:29:07 +0000 (09:29 +0000)]
Updates for 4.0.5 release.

git-svn-id: http://svn.redmine.org/redmine/trunk@18749 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate ruby-openid to 2.9.2 (#32294).
Jean-Philippe Lang [Sat, 19 Oct 2019 09:17:04 +0000 (09:17 +0000)]
Update ruby-openid to 2.9.2 (#32294).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18746 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFixed that total estimated time column is shown even when estimated time field is...
Jean-Philippe Lang [Sat, 19 Oct 2019 08:30:15 +0000 (08:30 +0000)]
Fixed that total estimated time column is shown even when estimated time field is deactivated (#31779).

Patch by Felix Schäfer and Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18743 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in lib/redmine/wiki_formatting/textile...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:27:46 +0000 (07:27 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18742 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in test/unit/query_test.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 07:27:35 +0000 (07:27 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in test/unit/query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18741 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in test/functional/project_enumerations_...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:27:23 +0000 (07:27 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in test/functional/project_enumerations_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18740 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in test/functional/activities_controller...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:27:12 +0000 (07:27 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in test/functional/activities_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18739 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/wiki_formatting...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:26:59 +0000 (07:26 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18738 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/UnlessElse in lib/redmine/wiki_formatting/textile...
Toshi MARUYAMA [Sat, 19 Oct 2019 07:26:45 +0000 (07:26 +0000)]
code cleanup: rubocop: fix Style/UnlessElse in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18737 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 04:30:26 +0000 (04:30 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18736 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 04:30:13 +0000 (04:30 +0000)]
code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18735 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/MultilineTernaryOperator in lib/redmine/utils.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 04:30:01 +0000 (04:30 +0000)]
code cleanup: rubocop: fix Style/MultilineTernaryOperator in lib/redmine/utils.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18734 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/queries_helper.rb
Toshi MARUYAMA [Sat, 19 Oct 2019 04:29:47 +0000 (04:29 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/queries_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18733 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EndAlignment in lib/redmine/export/pdf/issues_pdf_h...
Toshi MARUYAMA [Thu, 17 Oct 2019 17:02:35 +0000 (17:02 +0000)]
code cleanup: rubocop: fix Layout/EndAlignment in lib/redmine/export/pdf/issues_pdf_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18732 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EndAlignment in app/helpers/versions_helper.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 17:02:23 +0000 (17:02 +0000)]
code cleanup: rubocop: fix Layout/EndAlignment in app/helpers/versions_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18731 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EndAlignment in app/helpers/repositories_helper.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 17:02:12 +0000 (17:02 +0000)]
code cleanup: rubocop: fix Layout/EndAlignment in app/helpers/repositories_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18730 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: add detected Layout/EndAlignment files to .rubocop_todo.yml
Toshi MARUYAMA [Thu, 17 Oct 2019 17:02:01 +0000 (17:02 +0000)]
rubocop: add detected Layout/EndAlignment files to .rubocop_todo.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18729 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in app/models/issue_query.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:46:05 +0000 (16:46 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in app/models/issue_query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18728 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/helpers/gantt.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:45:54 +0000 (16:45 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/helpers/gantt.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18727 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/menu_manager.rb
Toshi MARUYAMA [Thu, 17 Oct 2019 16:45:42 +0000 (16:45 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in lib/redmine/menu_manager.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18726 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceBeforeSemicolon and Style/WhenThen in app...
Toshi MARUYAMA [Thu, 17 Oct 2019 16:40:54 +0000 (16:40 +0000)]
code cleanup: rubocop: fix Layout/SpaceBeforeSemicolon and Style/WhenThen in app/models/issue_query.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18725 e93f8b46-1217-0410-a6f0-8f06a7374b81