]> source.dussan.org Git - poi.git/log
poi.git
8 years agocorrection to junit bugs in r1754691
Mark Murphy [Mon, 1 Aug 2016 02:53:55 +0000 (02:53 +0000)]
correction to junit bugs in r1754691

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754698 13f79535-47bb-0310-9956-ffa450edef68

8 years agoJavadoc fixes
Nick Burch [Mon, 1 Aug 2016 00:17:33 +0000 (00:17 +0000)]
Javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754694 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd new class Cell Style Template and supporting enum for drawing borders
Mark Murphy [Sun, 31 Jul 2016 23:59:02 +0000 (23:59 +0000)]
Add new class Cell Style Template and supporting enum for drawing borders

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754691 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd coverage of function WEEKDAY
Dominik Stadler [Sun, 31 Jul 2016 21:24:13 +0000 (21:24 +0000)]
Add coverage of function WEEKDAY

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754689 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix download-location of commons-logging4 jar and add it to FindBugs and bin-files...
Dominik Stadler [Sun, 31 Jul 2016 21:23:34 +0000 (21:23 +0000)]
Fix download-location of commons-logging4 jar and add it to FindBugs and bin-files target correctly
Add ant-jar to findbugs target as it is needed for excelant-code-check now
Fail on error when running Findbugs (still not on found warnings!)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754688 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAllow to specify -addmods for Java 9 support, update to JaCoCo 0.7.7 for initial...
Dominik Stadler [Sun, 31 Jul 2016 21:23:25 +0000 (21:23 +0000)]
Allow to specify -addmods for Java 9 support, update to JaCoCo 0.7.7 for initial Java 9 support and add target to create a combined JUnit report

Conflicts:
build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754687 13f79535-47bb-0310-9956-ffa450edef68

8 years agoExclude package sl.draw.binding from coverage-counting as this is generated code
Dominik Stadler [Sun, 31 Jul 2016 17:19:37 +0000 (17:19 +0000)]
Exclude package sl.draw.binding from coverage-counting as this is generated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754676 13f79535-47bb-0310-9956-ffa450edef68

8 years agoTest a few more cases of function INDIRECT()
Dominik Stadler [Sun, 31 Jul 2016 17:19:33 +0000 (17:19 +0000)]
Test a few more cases of function INDIRECT()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754675 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 59736: Incorrect evaluation of SUBTOTAL with composite interval
Dominik Stadler [Sun, 31 Jul 2016 17:19:27 +0000 (17:19 +0000)]
Bug 59736:  Incorrect evaluation of SUBTOTAL with composite interval

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68

8 years agoIDE warnings and fix a few places where we do not close resources in tests
Dominik Stadler [Sun, 31 Jul 2016 17:19:17 +0000 (17:19 +0000)]
IDE warnings and fix a few places where we do not close resources in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754673 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdjust build:
Dominik Stadler [Sun, 31 Jul 2016 17:19:05 +0000 (17:19 +0000)]
Adjust build:
* Use "skipexisting" in Get from Ant 1.8
* Do not always re-run ooxml-lite
* Findbugs does not require src- and javadocs-jars, so depend on "jar" instead of "assemble"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754672 13f79535-47bb-0310-9956-ffa450edef68

8 years agoSonar wants to know about the new commons collections dependency too!
Nick Burch [Sat, 30 Jul 2016 12:39:16 +0000 (12:39 +0000)]
Sonar wants to know about the new commons collections dependency too!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754620 13f79535-47bb-0310-9956-ffa450edef68

8 years agoMove commons collections 4 dependency to main
David North [Sat, 30 Jul 2016 08:54:50 +0000 (08:54 +0000)]
Move commons collections 4 dependency to main

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754602 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAs Nick suspected, the dependency is actually from HSSF too so commons collections...
David North [Fri, 29 Jul 2016 18:48:07 +0000 (18:48 +0000)]
As Nick suspected, the dependency is actually from HSSF too so commons collections 4 needs adding to the main POM

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754563 13f79535-47bb-0310-9956-ffa450edef68

8 years agoJavadoc fix
Nick Burch [Fri, 29 Jul 2016 14:03:28 +0000 (14:03 +0000)]
Javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754530 13f79535-47bb-0310-9956-ffa450edef68

8 years agoIntroduce name-based methods for access to named ranges in a workbook, and deprecate...
David North [Fri, 29 Jul 2016 13:24:00 +0000 (13:24 +0000)]
Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods.

Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 55384: Handle setting pre-evaluation string correctly in SXSSF as well
Dominik Stadler [Wed, 27 Jul 2016 18:15:54 +0000 (18:15 +0000)]
Bug 55384: Handle setting pre-evaluation string correctly in SXSSF as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754328 13f79535-47bb-0310-9956-ffa450edef68

8 years agoHWPFDocument.write(File) support and tests #57919
Nick Burch [Tue, 26 Jul 2016 10:58:08 +0000 (10:58 +0000)]
HWPFDocument.write(File) support and tests #57919

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754108 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 59634: Clarify and refine JavaDoc of various close() methods to consistently...
Dominik Stadler [Sun, 24 Jul 2016 11:38:50 +0000 (11:38 +0000)]
Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68

8 years agoIn-place write for HSLF #57919
Nick Burch [Thu, 21 Jul 2016 23:25:02 +0000 (23:25 +0000)]
In-place write for HSLF #57919

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753741 13f79535-47bb-0310-9956-ffa450edef68

8 years agoProvide a createOrUpdateDocument method at the POIFS level, and use to simplify writi...
Nick Burch [Thu, 21 Jul 2016 23:09:07 +0000 (23:09 +0000)]
Provide a createOrUpdateDocument method at the POIFS level, and use to simplify writing code #57919

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753739 13f79535-47bb-0310-9956-ffa450edef68

8 years agoJavadoc updates
Nick Burch [Thu, 21 Jul 2016 10:27:27 +0000 (10:27 +0000)]
Javadoc updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753659 13f79535-47bb-0310-9956-ffa450edef68

8 years agotest Cell.setCellValue(false)
Javen O'Neal [Thu, 21 Jul 2016 02:17:37 +0000 (02:17 +0000)]
test Cell.setCellValue(false)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753634 13f79535-47bb-0310-9956-ffa450edef68

8 years agoIf doing an in-place write, update the properties too
Nick Burch [Wed, 20 Jul 2016 23:31:57 +0000 (23:31 +0000)]
If doing an in-place write, update the properties too

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753623 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#57919 HSLF writing to new File
Nick Burch [Wed, 20 Jul 2016 23:20:02 +0000 (23:20 +0000)]
#57919 HSLF writing to new File

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753622 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#57919 HPSF writing better error handling, and start prep for HSLF more write methods
Nick Burch [Wed, 20 Jul 2016 23:09:33 +0000 (23:09 +0000)]
#57919 HPSF writing better error handling, and start prep for HSLF more write methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753621 13f79535-47bb-0310-9956-ffa450edef68

8 years agoWhitespace / indents
Nick Burch [Wed, 20 Jul 2016 22:39:12 +0000 (22:39 +0000)]
Whitespace / indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753620 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#57919 Add in-place and new-File write methods to POIDocument
Nick Burch [Wed, 20 Jul 2016 22:35:51 +0000 (22:35 +0000)]
#57919 Add in-place and new-File write methods to POIDocument

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753619 13f79535-47bb-0310-9956-ffa450edef68

8 years agoMark some more scratchpad document types as currently being read-only
Nick Burch [Wed, 20 Jul 2016 22:18:25 +0000 (22:18 +0000)]
Mark some more scratchpad document types as currently being read-only

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753618 13f79535-47bb-0310-9956-ffa450edef68

8 years agoHelper class for implementing extra write methods (#57919) for Scratchpad classes...
Nick Burch [Wed, 20 Jul 2016 22:13:03 +0000 (22:13 +0000)]
Helper class for implementing extra write methods (#57919) for Scratchpad classes which are read-only

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753617 13f79535-47bb-0310-9956-ffa450edef68

8 years agoPrepare for pushing write() and write(File) to POIDocument
Nick Burch [Wed, 20 Jul 2016 18:41:27 +0000 (18:41 +0000)]
Prepare for pushing write() and write(File) to POIDocument

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753595 13f79535-47bb-0310-9956-ffa450edef68

8 years agoSync the file-based "past-the-end" exception to match the stream one, so that extendi...
Nick Burch [Wed, 20 Jul 2016 12:01:36 +0000 (12:01 +0000)]
Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68

8 years agoStart on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first
Nick Burch [Wed, 20 Jul 2016 11:14:05 +0000 (11:14 +0000)]
Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#57919 Start on support for writing to a new File (faster than OutputStream)
Nick Burch [Wed, 20 Jul 2016 11:07:29 +0000 (11:07 +0000)]
#57919 Start on support for writing to a new File (faster than OutputStream)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753486 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd test case for bug 53564
Javen O'Neal [Tue, 19 Jul 2016 10:08:50 +0000 (10:08 +0000)]
add test case for bug 53564

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753359 13f79535-47bb-0310-9956-ffa450edef68

8 years agosvn propset svn:mime-type application/vnd.openxmlformats-officedocument.spreadsheetml...
Javen O'Neal [Tue, 19 Jul 2016 08:43:30 +0000 (08:43 +0000)]
svn propset svn:mime-type application/vnd.openxmlformats-officedocument.spreadsheetml.sheet *.xlsx

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753351 13f79535-47bb-0310-9956-ffa450edef68

8 years ago+svn:auto-props for common Microsoft Office files
Javen O'Neal [Tue, 19 Jul 2016 08:39:38 +0000 (08:39 +0000)]
+svn:auto-props for common Microsoft Office files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753350 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59881: fix D* functions for blank cells in headers in database; patch from Patric...
Javen O'Neal [Tue, 19 Jul 2016 08:02:41 +0000 (08:02 +0000)]
bug 59881: fix D* functions for blank cells in headers in database; patch from Patrick Zimmermann

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753346 13f79535-47bb-0310-9956-ffa450edef68

8 years ago+svn:eol-style=native
Javen O'Neal [Mon, 18 Jul 2016 18:26:18 +0000 (18:26 +0000)]
+svn:eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753299 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59881: fix spelling; patch from Patrick Zimmermann
Javen O'Neal [Mon, 18 Jul 2016 18:25:28 +0000 (18:25 +0000)]
bug 59881: fix spelling; patch from Patrick Zimmermann

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753298 13f79535-47bb-0310-9956-ffa450edef68

8 years ago52122: Excel does not handle conditional formatting based on formula correctly unless...
Dominik Stadler [Mon, 18 Jul 2016 10:32:55 +0000 (10:32 +0000)]
52122: Excel does not handle conditional formatting based on formula correctly unless recalculation is forced

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753199 13f79535-47bb-0310-9956-ffa450edef68

8 years agoSome warnings/improvements suggested by IntelliJ
Dominik Stadler [Mon, 18 Jul 2016 09:34:59 +0000 (09:34 +0000)]
Some warnings/improvements suggested by IntelliJ

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68

8 years ago59106: WorkdayFunction does not read the area with holidays correctly to calculate...
Dominik Stadler [Sun, 17 Jul 2016 21:18:27 +0000 (21:18 +0000)]
59106: WorkdayFunction does not read the area with holidays correctly to calculate work days

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753125 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdjust unused local variables to also make FindBugs happy
Dominik Stadler [Sun, 17 Jul 2016 21:18:19 +0000 (21:18 +0000)]
Adjust unused local variables to also make FindBugs happy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753124 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix one more place where stream were left open when an exception is thrown
Dominik Stadler [Sun, 17 Jul 2016 21:18:12 +0000 (21:18 +0000)]
Fix one more place where stream were left open when an exception is thrown

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753123 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
Dominik Stadler [Sun, 17 Jul 2016 21:18:07 +0000 (21:18 +0000)]
Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68

8 years agoEnable reproducer test for bug 56880 after it was fixed.
Dominik Stadler [Sun, 17 Jul 2016 21:17:51 +0000 (21:17 +0000)]
Enable reproducer test for bug 56880 after it was fixed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753121 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd commented reproducer for bug 57603
Dominik Stadler [Sun, 17 Jul 2016 21:17:45 +0000 (21:17 +0000)]
Add commented reproducer for bug 57603

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753120 13f79535-47bb-0310-9956-ffa450edef68

8 years agoonly calculate getTextHeight if it will be used
Javen O'Neal [Sun, 17 Jul 2016 20:33:32 +0000 (20:33 +0000)]
only calculate getTextHeight if it will be used

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68

8 years agoreduce statement complexity in drawContent, also has fewer FLOPS
Javen O'Neal [Sun, 17 Jul 2016 20:29:34 +0000 (20:29 +0000)]
reduce statement complexity in drawContent, also has fewer FLOPS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753114 13f79535-47bb-0310-9956-ffa450edef68

8 years agoif ever combined, VerticalAlignment and HorizontalAlignment would likely end up at...
Javen O'Neal [Sun, 17 Jul 2016 20:27:57 +0000 (20:27 +0000)]
if ever combined, VerticalAlignment and HorizontalAlignment would likely end up at org.apache.poi.common.usermodel

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753113 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 57919: add performance note to javadocs about using BufferedOutputStreams on...
Javen O'Neal [Sun, 17 Jul 2016 20:25:37 +0000 (20:25 +0000)]
bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68

8 years agomake instance variables final where possible
Javen O'Neal [Sun, 17 Jul 2016 20:24:14 +0000 (20:24 +0000)]
make instance variables final where possible

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753111 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#57919 Provide an initial in-place write method for HSSFWorkbook
Nick Burch [Sun, 17 Jul 2016 19:02:58 +0000 (19:02 +0000)]
#57919 Provide an initial in-place write method for HSSFWorkbook

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSl...
Javen O'Neal [Sun, 17 Jul 2016 13:25:02 +0000 (13:25 +0000)]
bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59170: remove deprecated TableSprmUncompressor#uncompressTAP(byte[] grpprl, int...
Javen O'Neal [Sun, 17 Jul 2016 13:12:27 +0000 (13:12 +0000)]
bug 59170: remove deprecated TableSprmUncompressor#uncompressTAP(byte[] grpprl, int offset) method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753070 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59170: fix compile error from r1753052 when removing deprecated TAP_TYPE constant
Javen O'Neal [Sun, 17 Jul 2016 13:11:18 +0000 (13:11 +0000)]
bug 59170: fix compile error from r1753052 when removing deprecated TAP_TYPE constant

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753069 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58190: add unit tests for XMLSlideShow#addPicture and XMLSlideShow#findPicture
Javen O'Neal [Sun, 17 Jul 2016 12:16:58 +0000 (12:16 +0000)]
bug 58190: add unit tests for XMLSlideShow#addPicture and XMLSlideShow#findPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753065 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum
Javen O'Neal [Sun, 17 Jul 2016 11:56:13 +0000 (11:56 +0000)]
bug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753062 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59264,59833,59837: upgrade deprecated methods in examples and testcases
Javen O'Neal [Sun, 17 Jul 2016 11:45:40 +0000 (11:45 +0000)]
bug 59264,59833,59837: upgrade deprecated methods in examples and testcases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753061 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59264,59833,59837: upgrade deprecated methods in examples and testcases
Javen O'Neal [Sun, 17 Jul 2016 11:43:50 +0000 (11:43 +0000)]
bug 59264,59833,59837: upgrade deprecated methods in examples and testcases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753060 13f79535-47bb-0310-9956-ffa450edef68

8 years agoclose workbook to avoid resource leak
Javen O'Neal [Sun, 17 Jul 2016 10:27:44 +0000 (10:27 +0000)]
close workbook to avoid resource leak

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753053 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59170: remove deprecated constants, make private variables final, whitespace
Javen O'Neal [Sun, 17 Jul 2016 10:27:18 +0000 (10:27 +0000)]
bug 59170: remove deprecated constants, make private variables final, whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753052 13f79535-47bb-0310-9956-ffa450edef68

8 years agoHexDump.writeHex is similar to Long#toHexString. Consider consolidating.
Javen O'Neal [Sun, 17 Jul 2016 10:22:43 +0000 (10:22 +0000)]
HexDump.writeHex is similar to Long#toHexString. Consider consolidating.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753050 13f79535-47bb-0310-9956-ffa450edef68

8 years agolog on unsupported Sprm operation, save operand to variable to reduce duplicated...
Javen O'Neal [Sun, 17 Jul 2016 10:10:21 +0000 (10:10 +0000)]
log on unsupported Sprm operation, save operand to variable to reduce duplicated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753048 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace (tabs to spaces)
Javen O'Neal [Sun, 17 Jul 2016 10:08:06 +0000 (10:08 +0000)]
whitespace (tabs to spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753047 13f79535-47bb-0310-9956-ffa450edef68

8 years agoHWPF SectionProperties implements Cloneable
Javen O'Neal [Sun, 17 Jul 2016 10:07:06 +0000 (10:07 +0000)]
HWPF SectionProperties implements Cloneable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753046 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58802: javadoc fix
Javen O'Neal [Sun, 17 Jul 2016 09:52:04 +0000 (09:52 +0000)]
bug 58802: javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753044 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59873: javadoc fix
Javen O'Neal [Sun, 17 Jul 2016 09:48:36 +0000 (09:48 +0000)]
bug 59873: javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753043 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59873: javadoc fix
Javen O'Neal [Sun, 17 Jul 2016 09:44:26 +0000 (09:44 +0000)]
bug 59873: javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753042 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
Javen O'Neal [Sun, 17 Jul 2016 09:42:13 +0000 (09:42 +0000)]
bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753041 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
Javen O'Neal [Sun, 17 Jul 2016 09:32:29 +0000 (09:32 +0000)]
bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753040 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 58802: HWPF: Allow reading of footnote and endnote properties
Dominik Stadler [Sun, 17 Jul 2016 09:27:17 +0000 (09:27 +0000)]
Bug 58802: HWPF: Allow reading of footnote and endnote properties

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753039 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos...
Dominik Stadler [Sun, 17 Jul 2016 09:27:07 +0000 (09:27 +0000)]
Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum
Javen O'Neal [Sun, 17 Jul 2016 09:20:21 +0000 (09:20 +0000)]
bug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753035 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace
Javen O'Neal [Sun, 17 Jul 2016 08:45:55 +0000 (08:45 +0000)]
whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753032 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace (tabs to spaces)
Javen O'Neal [Sun, 17 Jul 2016 08:45:00 +0000 (08:45 +0000)]
whitespace (tabs to spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753031 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd cause to exceptions, log exceptions that are caught and suppressed
Javen O'Neal [Sun, 17 Jul 2016 08:41:52 +0000 (08:41 +0000)]
add cause to exceptions, log exceptions that are caught and suppressed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753030 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace
Javen O'Neal [Sun, 17 Jul 2016 08:26:51 +0000 (08:26 +0000)]
whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753028 13f79535-47bb-0310-9956-ffa450edef68

8 years agojavadocs fix
Javen O'Neal [Sun, 17 Jul 2016 07:48:48 +0000 (07:48 +0000)]
javadocs fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753020 13f79535-47bb-0310-9956-ffa450edef68

8 years agomake private maps final
Javen O'Neal [Sun, 17 Jul 2016 07:29:40 +0000 (07:29 +0000)]
make private maps final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753018 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd @Override annotations to CreationHelper classes
Javen O'Neal [Sun, 17 Jul 2016 07:14:49 +0000 (07:14 +0000)]
add @Override annotations to CreationHelper classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753017 13f79535-47bb-0310-9956-ffa450edef68

8 years agothrow exception if hyperlink is invalid type when validating hyperlink
Javen O'Neal [Sun, 17 Jul 2016 06:04:56 +0000 (06:04 +0000)]
throw exception if hyperlink is invalid type when validating hyperlink

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753016 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59872: add @since annotation to Sheet#getHyperlink(CellAddress)
Javen O'Neal [Sun, 17 Jul 2016 05:47:03 +0000 (05:47 +0000)]
bug 59872: add @since annotation to Sheet#getHyperlink(CellAddress)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753015 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59775: correctly create XSSFHyperlinks when target is a URL containing a hash...
Javen O'Neal [Sun, 17 Jul 2016 05:43:03 +0000 (05:43 +0000)]
bug 59775: correctly create XSSFHyperlinks when target is a URL containing a hash mark; patch contributed by Guillermo Alvarez

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753013 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59775: fix cell address index error
Javen O'Neal [Sun, 17 Jul 2016 04:59:12 +0000 (04:59 +0000)]
bug 59775: fix cell address index error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753011 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59872: add Sheet.getHyperlink(CellAddress)
Javen O'Neal [Sun, 17 Jul 2016 04:41:20 +0000 (04:41 +0000)]
bug 59872: add Sheet.getHyperlink(CellAddress)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68

8 years agouse real TempFile
Andreas Beeker [Sun, 17 Jul 2016 00:27:52 +0000 (00:27 +0000)]
use real TempFile

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753004 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#59841 - OOXML: enable custom zip streams via OPCPackage.open(ZipEntrySource)
Andreas Beeker [Sun, 17 Jul 2016 00:14:06 +0000 (00:14 +0000)]
#59841 - OOXML: enable custom zip streams via OPCPackage.open(ZipEntrySource)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753003 13f79535-47bb-0310-9956-ffa450edef68

8 years agoApply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on...
Dominik Stadler [Sat, 16 Jul 2016 20:52:39 +0000 (20:52 +0000)]
Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 59733: Narrow down testcase some more, after the first shift, removing the first...
Dominik Stadler [Sat, 16 Jul 2016 20:52:28 +0000 (20:52 +0000)]
Bug 59733: Narrow down testcase some more, after the first shift, removing the first row is sufficient to trigger the problem

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752996 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd a test to check for a NullPointerException in XSLFTableCell
Dominik Stadler [Fri, 15 Jul 2016 18:24:11 +0000 (18:24 +0000)]
Add a test to check for a NullPointerException in XSLFTableCell

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752862 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 59861: Adjust testcase, it works now for me. Also combine the two TestProper...
Dominik Stadler [Fri, 15 Jul 2016 18:24:02 +0000 (18:24 +0000)]
Bug 59861: Adjust testcase, it works now for me. Also combine the two TestProper classes into one

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752861 13f79535-47bb-0310-9956-ffa450edef68

8 years agoJDK8 javadocs fixes
Javen O'Neal [Fri, 15 Jul 2016 10:13:58 +0000 (10:13 +0000)]
JDK8 javadocs fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752812 13f79535-47bb-0310-9956-ffa450edef68

8 years agoreplace for-loop over index with for-each loop
Javen O'Neal [Fri, 15 Jul 2016 07:41:26 +0000 (07:41 +0000)]
replace for-loop over index with for-each loop

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752788 13f79535-47bb-0310-9956-ffa450edef68

8 years agoannotate purpose of each PROPER() function test case, add a few more test cases,...
Javen O'Neal [Fri, 15 Jul 2016 07:25:16 +0000 (07:25 +0000)]
annotate purpose of each PROPER() function test case, add a few more test cases, identify some problems with ß handling

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752786 13f79535-47bb-0310-9956-ffa450edef68

8 years agoJDK8 javadocs
Javen O'Neal [Fri, 15 Jul 2016 06:35:21 +0000 (06:35 +0000)]
JDK8 javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752781 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFunction PROPER: Don't use a regular expression syntax that is not available on Andro...
Dominik Stadler [Fri, 15 Jul 2016 06:32:45 +0000 (06:32 +0000)]
Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s)
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59858: describe why VBA macro reading failed
Javen O'Neal [Fri, 15 Jul 2016 06:12:37 +0000 (06:12 +0000)]
bug 59858: describe why VBA macro reading failed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752778 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59858: add disabled unit test for bug 59858; file from Brooke
Javen O'Neal [Fri, 15 Jul 2016 05:28:29 +0000 (05:28 +0000)]
bug 59858: add disabled unit test for bug 59858; file from Brooke

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752776 13f79535-47bb-0310-9956-ffa450edef68