Merge pull request #39038 from nextcloud/fix/replace-deprecated-vue-code

Merge pull request #37969 from nextcloud/poc/noid/systemtags-perf-tag-endpoint

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: cannot apply limit+offset on multi-tag-search

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix(core): Migrate from deprecated `excludeClickOutsideClasses` to `excludeClickOutsideSelectors`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #39029 from nextcloud/feat/eslint-ts

Merge pull request #39020 from fsamapoor/refactor_lib_private_mail

chore: upgrade typescript, eslint and fix lint

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Merge pull request #38990 from fsamapoor/refactor_lib_private_calendar

Refactor lib/private/Calendar

Merge pull request #39005 from nextcloud/fix/dav/upgrade-catch-sab-sync-errors

fix(dav): Catch SAB sync errors during upgrade

Adds same object return annotations.

Based on: https://github.com/nextcloud/server/pull/38987#discussion_r1241866676

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #39015 from nextcloud/Jerome-Herbinet-qr-code-generation-button

Add "button" class to the QR code link

Merge pull request #38881 from nextcloud/fix/logcondition-user

Fix user log.condition feature

Merge pull request #38858 from nextcloud/scanner-performance3

file scanner performance improvements

npm run build

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Add "button" class to the QR code link

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Merge pull request #38679 from nextcloud/feat/add-spec-to-preview-fetched-event

feat: add width, height, crop and mode to BeforePreviewFetchedEvent

fix(dav): Catch SAB sync errors during upgrade

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #38775 from fsamapoor/constructor_property_promotion_in_core_command_part9

Uses PHP8's constructor property promotion in core/Command and /

Merge pull request #38958 from nextcloud/enh/noid/use-getsystemvalue-mailer

use getsystemvalue-functions in Mailer.php

Fix user log.condition feature

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38987 from fsamapoor/refactor_lib_private_mail

Refactors lib/private/Mail.

Merge pull request #38988 from nextcloud/fix/data-apps-slide-toggle

fix: restore AppsSlideToggle feature

fix: restore AppsSlideToggle feature

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #38665 from nextcloud/fix/weather_status-osm-api

fix(weather_status): Pass address as param to OSM API

Merge pull request #38986 from fsamapoor/refactor_lib_private_contacts

Refactors lib/private/Calendar.

Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Merge pull request #38869 from nextcloud/automated/noid/master-fix-npm-audit

Refactors lib/private/Mail.

Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Refactors lib/private/Contacts.

Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

chore(deps): fix npm audit

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38844 from nextcloud/enh/add-detected-mime-type-to-exception

feat: add detected mime type to exception

Fixes testcase error.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Update core/Command/TwoFactorAuth/Cleanup.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/TwoFactorAuth/Enable.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/TwoFactorAuth/Disable.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/TwoFactorAuth/State.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/TwoFactorAuth/Enforce.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/Check.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Adds constructor to the Based class.

Based on:
https://github.com/nextcloud/server/pull/38775#discussion_r1227641788

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

 Uses PHP8's constructor property promotion.
 in core/Command and /TwoFactorAuth classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

feat: add detected mime type to exception

The mimetype may not match the file extension.
Helps the user to find out why a provided image is not accepted.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #38852 from nextcloud/enh/noid/move-deprecation-warnings

address review

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix one more place

Signed-off-by: Simon L <szaimen@e.mail.de>

only print deprecation logs if debug mode is enabled

Signed-off-by: Simon L <szaimen@e.mail.de>

Move deprecation warnings to debug

Signed-off-by: Simon L <szaimen@e.mail.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38625 from nextcloud/fix/noid/querysearchehelper-narrow-type

fix: expect interface, not a specific implementation

Merge pull request #38965 from nextcloud/dav-directory-clean-cache-path

dav: clean path before putting it in the statcache

try to fix tests

Signed-off-by: Simon L <szaimen@e.mail.de>

feat: add width, height, crop and mode to BeforePreviewFetchedEvent

user_usage_report keeps a counter for files read.

The app uses

- OC_Filesystem::read hook
- Event listener (the legacy one) for IPreview::EVENT

Request for previews do not trigger the hook, hence the additional event listener.
The thumbnails for a list or grid view should not count, so we need the width and height.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #38948 from nextcloud/Jerome-Herbinet-collaborative-tags-alignment-change

dav: clean path before putting it in the statcache

Signed-off-by: Robin Appelman <robin@icewind.nl>

use getsystemvalue-functions in Mailer.php

Signed-off-by: Simon L <szaimen@e.mail.de>

Align collaborative tags differently

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Align collaborative tags differently

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
npm run build

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Following @skjnldsv suggestion

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Merge pull request #38800 from nextcloud/bugfix/noid/version-update-or-insert

Merge pull request #38951 from nextcloud/dependabot/npm_and_yarn/fast-xml-parser-and-webdav-4.2.5

chore(deps): Bump fast-xml-parser and webdav

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) to 4.2.5 and updates ancestor dependency [webdav](https://github.com/perry-mitchell/webdav-client). These dependencies need to be updated together.

Updates `fast-xml-parser` from 4.2.4 to 4.2.5
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/NaturalIntelligence/fast-xml-parser/compare/v4.2.4...v4.2.5)

Updates `webdav` from 5.1.0 to 5.2.1
- [Changelog](https://github.com/perry-mitchell/webdav-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/perry-mitchell/webdav-client/compare/v5.1.0...v5.2.1)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-type: indirect
- dependency-name: webdav
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #38939 from nextcloud/feat/f2v/more-actions

Merge pull request #38457 from nextcloud/fix/improve-ldap-offset-search-perf

Use default page size for jumping to desired offset

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

feat: add rename action with tests

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(files): action default is false if not set

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add favorite action with tests

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Merge pull request #38945 from nextcloud/dav-meta-directory-content

implement optimized getDirectoryContent for DAV

Do not create a new version if previousNode has the same mtime

Signed-off-by: Louis Chemineau <louis@chmn.me>

implement optimized getDirectoryContent for DAV

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #38771 from fsamapoor/constructor_property_promotion_in_core_command_part7

 Uses PHP8's constructor property promotion core/Command/Info, /Integrity, and /Preview

Merge pull request #38856 from nextcloud/fix/contacts/3404/put-location-in-proper-place

fix(sab): put location in proper address field

Merge pull request #38928 from nextcloud/fix/missing-systemtags-index

feat: add edit locally action with tests

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(systemtags): Keep non-existing index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(systemtags): Move index creation from new migration to existing original migration

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Merge pull request #38917 from nextcloud/bugfix/talk-9558/plural-issue-with-some-language-locale-combinations

fix(l10n): Fix plural issue with different locale and language

Merge pull request #38747 from nextcloud/perf/early-exit-mkcol

perf: skip request without write permission

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38826 from nextcloud/enh/a11y-new-user

refactor: save unnecessary method_exists

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: use array_unitersect against objects

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: obey offset and limit for results from favs and circles

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: cominbation of small fixes

- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: include invisible tags for admins

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: search with more than one search tags

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

enh(a11y): New user modal

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #38924 from nextcloud/automated/update-engines/default

chore: update node engines to next LTS

feat: add searchBySystemTag as PHP API

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: no search when LazyFolder was provided

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

chore: cleanup unused code

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: ensure searchBySystemTag() is available

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: favorites view and universal search against tags

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: change if with conditionless else to switch; and a parameter value

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

use efficient tag retrieval on DAV report request

- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

ci: pro forma check of existence of internal method

createNode() is protected and used by Folder, but being an internal-only
method it shall not be exposed in the Folder or IRootFolder interface.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

refactor: declare getMount() and getMountsIn() at IRootFolder

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

chore: ugly type juggling

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: add typehine for IRootFolder

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>