]> source.dussan.org Git - poi.git/log
poi.git
5 years ago#60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations
Greg Woolsey [Mon, 18 Mar 2019 19:09:11 +0000 (19:09 +0000)]
#60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations

The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.

Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.

Added unit test cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix forbidden apis error
Andreas Beeker [Sat, 16 Mar 2019 20:44:12 +0000 (20:44 +0000)]
Fix forbidden apis error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855672 13f79535-47bb-0310-9956-ffa450edef68

5 years agoUse JPG source, otherwise we have problems with Alpha conversion in OpenJDK.
Andreas Beeker [Sat, 16 Mar 2019 20:13:55 +0000 (20:13 +0000)]
Use JPG source, otherwise we have problems with Alpha conversion in OpenJDK.
https://stackoverflow.com/questions/3432388/imageio-not-able-to-write-a-jpeg-file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855668 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 61472: Convert date/time strings to numbers when evaluating formulas
Yegor Kozlov [Sat, 16 Mar 2019 15:41:46 +0000 (15:41 +0000)]
Bug 61472: Convert date/time strings to numbers when evaluating formulas

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855662 13f79535-47bb-0310-9956-ffa450edef68

5 years agoHandle possible invalid date value (#61652)
Greg Woolsey [Sat, 16 Mar 2019 06:55:16 +0000 (06:55 +0000)]
Handle possible invalid date value (#61652)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855627 13f79535-47bb-0310-9956-ffa450edef68

5 years ago#63264 Conditional Format rule evaluation calculates relative references incorrectly
Greg Woolsey [Sat, 16 Mar 2019 00:27:13 +0000 (00:27 +0000)]
#63264 Conditional Format rule evaluation calculates relative references incorrectly

Fixing the offset calculation and passing the top-left-most region rather than the region matching the current cell fixed these cases.  I've augmented unit tests to check for them to avoid future regressions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855619 13f79535-47bb-0310-9956-ffa450edef68

5 years agofix some cases where iterator usage does not check hasNext
PJ Fanning [Thu, 14 Mar 2019 04:01:10 +0000 (04:01 +0000)]
fix some cases where iterator usage does not check hasNext

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix URL for test
Dominik Stadler [Sun, 10 Mar 2019 16:13:02 +0000 (16:13 +0000)]
Fix URL for test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855155 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63221: Add margin-settings for top, bottom, left and right to XSSFPrintSetup
Dominik Stadler [Sun, 10 Mar 2019 16:12:57 +0000 (16:12 +0000)]
Bug 63221: Add margin-settings for top, bottom, left and right to XSSFPrintSetup

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855154 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdjust test to not fail with Xerces XML Parser, fix some IDE warnings
Dominik Stadler [Sun, 10 Mar 2019 08:18:54 +0000 (08:18 +0000)]
Adjust test to not fail with Xerces XML Parser, fix some IDE warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855139 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins DSL: Enable job for running API-Check again now that we compare 4.x to 4.0.0
Dominik Stadler [Sun, 10 Mar 2019 08:18:46 +0000 (08:18 +0000)]
Jenkins DSL: Enable job for running API-Check again now that we compare 4.x to 4.0.0

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855138 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[bug-63240] make SAXHelper.newXMLReader non-synchronized]
PJ Fanning [Wed, 6 Mar 2019 19:17:22 +0000 (19:17 +0000)]
[bug-63240] make SAXHelper.newXMLReader non-synchronized]

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854941 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[bug-63240] make DocumentHelper.newDocumentBuilder non-synchronized]
PJ Fanning [Wed, 6 Mar 2019 18:36:12 +0000 (18:36 +0000)]
[bug-63240] make DocumentHelper.newDocumentBuilder non-synchronized]

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854935 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins DSL: Add XMLBeans-JDK-12, still disabled, though
Dominik Stadler [Sun, 3 Mar 2019 14:09:58 +0000 (14:09 +0000)]
Jenkins DSL: Add XMLBeans-JDK-12, still disabled, though
Print out where we get Ant from
Use new 'jenkins' target for XMLBeans and fetch compiler warnings and JUnit results

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854720 13f79535-47bb-0310-9956-ffa450edef68

5 years agoUpdate file-leak excludes for XMLBeans/jaxb
Dominik Stadler [Sun, 3 Mar 2019 14:09:54 +0000 (14:09 +0000)]
Update file-leak excludes for XMLBeans/jaxb

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854719 13f79535-47bb-0310-9956-ffa450edef68

5 years agoClose more file-handles in tests
Dominik Stadler [Sun, 3 Mar 2019 14:09:50 +0000 (14:09 +0000)]
Close more file-handles in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854718 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix a regression test failure, toString() should never return null
Dominik Stadler [Sun, 3 Mar 2019 14:09:40 +0000 (14:09 +0000)]
Fix a regression test failure, toString() should never return null

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854717 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63200: Avoid NullPointerException in XSLFShape.selectPaint() and check some more...
Dominik Stadler [Sat, 2 Mar 2019 12:28:19 +0000 (12:28 +0000)]
Bug 63200: Avoid NullPointerException in XSLFShape.selectPaint() and check some more in integration tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854639 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62151: Fix warnings about illegal reflective access in Java 9+ by
Dominik Stadler [Sat, 2 Mar 2019 09:19:45 +0000 (09:19 +0000)]
Bug 62151: Fix warnings about illegal reflective access in Java 9+ by
using a similar approach as Apache Hadoop via a CleanerUtil class which encapsulates
the two different approaches for Java <= 8 and Java >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854630 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix detecting Java <= 8 vs. >= 9 to not detect Java 8 for version-string "11.x"
Dominik Stadler [Sat, 2 Mar 2019 09:18:15 +0000 (09:18 +0000)]
Fix detecting Java <= 8 vs. >= 9 to not detect Java 8 for version-string "11.x"
Add system property to junit to disable optimization in jaxb which causes illegal access in Java 9+
Add argument to junit to display all illegal accesses in Java 9+

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854629 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd batik-jars to findbugs-task
Dominik Stadler [Sat, 23 Feb 2019 07:52:29 +0000 (07:52 +0000)]
Add batik-jars to findbugs-task

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854193 13f79535-47bb-0310-9956-ffa450edef68

5 years agoClose file-handles for slideshows also when construction fails or when dual-storage...
Dominik Stadler [Sat, 23 Feb 2019 07:52:24 +0000 (07:52 +0000)]
Close file-handles for slideshows also when construction fails or when dual-storage is used
Also avoid file-leak reports in some tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854192 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRemove some remnants of NFileSystem
Dominik Stadler [Sat, 23 Feb 2019 07:52:06 +0000 (07:52 +0000)]
Remove some remnants of NFileSystem

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854191 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd some more testing for bug 63151: NullPointerException in HSSFOptimiser.optimiseFo...
Dominik Stadler [Sat, 23 Feb 2019 07:51:57 +0000 (07:51 +0000)]
Add some more testing for bug 63151: NullPointerException in HSSFOptimiser.optimiseFonts(), also execute it as part of large regression tests in the future

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854190 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdjust BaseIntegrationTest some more to better handle invalid file extensions
Dominik Stadler [Sat, 23 Feb 2019 07:51:48 +0000 (07:51 +0000)]
Adjust BaseIntegrationTest some more to better handle invalid file extensions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854189 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 60980: Fix parsing formulas with intersections in functions args
Yegor Kozlov [Thu, 21 Feb 2019 11:00:40 +0000 (11:00 +0000)]
Bug 60980: Fix parsing formulas with intersections in functions args

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854037 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[bug-63151] handle NPE in UnicodeString
PJ Fanning [Tue, 19 Feb 2019 06:27:04 +0000 (06:27 +0000)]
[bug-63151] handle NPE in UnicodeString

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853859 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[bug-63187] fix typos
PJ Fanning [Mon, 18 Feb 2019 09:56:11 +0000 (09:56 +0000)]
[bug-63187] fix typos

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853787 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63029: fixed failing test in test-ooxml-lite
Yegor Kozlov [Wed, 13 Feb 2019 18:37:20 +0000 (18:37 +0000)]
Bug 63029: fixed failing test in test-ooxml-lite

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853523 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63029: revert handling NotOfficeXmlFileException in ZipPackage as this change...
Yegor Kozlov [Wed, 13 Feb 2019 06:45:14 +0000 (06:45 +0000)]
Bug 63029: revert handling NotOfficeXmlFileException in ZipPackage as this change broke the build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853474 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63029: OPCPackage Potentially clobbers files on close()
Yegor Kozlov [Tue, 12 Feb 2019 16:55:13 +0000 (16:55 +0000)]
Bug 63029: OPCPackage Potentially clobbers files on close()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853454 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62980: Make D* functions ignore case in headings
Yegor Kozlov [Sat, 9 Feb 2019 13:00:09 +0000 (13:00 +0000)]
Bug 62980: Make D* functions ignore case in headings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853268 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins DSL: Add more output in test-env-build
Dominik Stadler [Sun, 27 Jan 2019 21:17:01 +0000 (21:17 +0000)]
Jenkins DSL: Add more output in test-env-build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852309 13f79535-47bb-0310-9956-ffa450edef68

5 years ago... link external again
Andreas Beeker [Sun, 27 Jan 2019 15:29:56 +0000 (15:29 +0000)]
... link external again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852300 13f79535-47bb-0310-9956-ffa450edef68

5 years agoremove new documentation directory and then ...
Andreas Beeker [Sun, 27 Jan 2019 15:27:09 +0000 (15:27 +0000)]
remove new documentation directory and then ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852299 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins DSL: Adjust the list of JDKs that we look for in the testevn-job
Dominik Stadler [Sun, 27 Jan 2019 10:28:50 +0000 (10:28 +0000)]
Jenkins DSL: Adjust the list of JDKs that we look for in the testevn-job

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852284 13f79535-47bb-0310-9956-ffa450edef68

5 years agoremoved accidentally added release-notes
Vladislav Galas [Sun, 27 Jan 2019 10:18:26 +0000 (10:18 +0000)]
removed accidentally added release-notes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852283 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd reproducing test-case for a bug we found newly introduced in JDK 12-ea+28
Dominik Stadler [Sun, 27 Jan 2019 09:58:08 +0000 (09:58 +0000)]
Add reproducing test-case for a bug we found newly introduced in JDK 12-ea+28
and fixed again in JDK 12-ea+29

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852281 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix some IDE warnings and better output in unit test
Dominik Stadler [Sun, 27 Jan 2019 09:58:02 +0000 (09:58 +0000)]
Fix some IDE warnings and better output in unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852280 13f79535-47bb-0310-9956-ffa450edef68

5 years agoExclude one more local file from rat-checks
Dominik Stadler [Sun, 27 Jan 2019 09:57:54 +0000 (09:57 +0000)]
Exclude one more local file from rat-checks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852279 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdjust handling of some exceptions in regression tests
Dominik Stadler [Sun, 27 Jan 2019 09:57:49 +0000 (09:57 +0000)]
Adjust handling of some exceptions in regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852278 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 60405: Add initial support for cetab functions so some macros can be
Dominik Stadler [Sun, 27 Jan 2019 09:57:39 +0000 (09:57 +0000)]
Bug 60405: Add initial support for cetab functions so some macros can be
parsed
Add some function-definitions for Excel 4 Macros and missing functions
found in regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852277 13f79535-47bb-0310-9956-ffa450edef68

5 years agoIgnore file-leaks from openjpa/derby/log4j for the regression tests
Dominik Stadler [Sun, 27 Jan 2019 09:57:19 +0000 (09:57 +0000)]
Ignore file-leaks from openjpa/derby/log4j for the regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852276 13f79535-47bb-0310-9956-ffa450edef68

5 years agopulled *Cell.setCellValue(String), setCellValue(RichTextString) to the common base
Vladislav Galas [Sat, 26 Jan 2019 23:20:07 +0000 (23:20 +0000)]
pulled *Cell.setCellValue(String), setCellValue(RichTextString) to the common base

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852255 13f79535-47bb-0310-9956-ffa450edef68

5 years agopulled *Cell.setCellValue(Date) and setCellValue(Calendar) to the common base
Vladislav Galas [Sat, 26 Jan 2019 23:19:59 +0000 (23:19 +0000)]
pulled *Cell.setCellValue(Date) and setCellValue(Calendar) to the common base

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852254 13f79535-47bb-0310-9956-ffa450edef68

5 years agopulled *Cell.setCellValue(double) to the common base
Vladislav Galas [Sat, 26 Jan 2019 23:19:53 +0000 (23:19 +0000)]
pulled *Cell.setCellValue(double) to the common base

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852253 13f79535-47bb-0310-9956-ffa450edef68

5 years agopulled *Cell.getCellTypeEnum() to common base
Vladislav Galas [Sat, 26 Jan 2019 23:19:47 +0000 (23:19 +0000)]
pulled *Cell.getCellTypeEnum() to common base

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852252 13f79535-47bb-0310-9956-ffa450edef68

5 years agopulled *Cell.getAddress to common base
Vladislav Galas [Sat, 26 Jan 2019 23:19:41 +0000 (23:19 +0000)]
pulled *Cell.getAddress to common base

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852251 13f79535-47bb-0310-9956-ffa450edef68

5 years agopurged usages of Cell.setCellType (left only in tests, where conversions are tested)
Vladislav Galas [Sat, 26 Jan 2019 19:41:36 +0000 (19:41 +0000)]
purged usages of Cell.setCellType (left only in tests, where conversions are tested)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852247 13f79535-47bb-0310-9956-ffa450edef68

5 years agomade call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType...
Vladislav Galas [Sat, 26 Jan 2019 19:41:25 +0000 (19:41 +0000)]
made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType(). Purged all redundant calls from project.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68

5 years agopurged calls to cell.setCellType(CellType.BLANK) from the project, replaced with...
Vladislav Galas [Sat, 26 Jan 2019 19:41:10 +0000 (19:41 +0000)]
purged calls to cell.setCellType(CellType.BLANK) from the project, replaced with setBlank()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852245 13f79535-47bb-0310-9956-ffa450edef68

5 years agoadded Cell.setBlank() - as an alias, for now
Vladislav Galas [Sat, 26 Jan 2019 19:40:56 +0000 (19:40 +0000)]
added Cell.setBlank() - as an alias, for now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852244 13f79535-47bb-0310-9956-ffa450edef68

5 years agosetCellFormula: blank cell gets value 0, non-blank value is preserved
Vladislav Galas [Sat, 26 Jan 2019 10:09:13 +0000 (10:09 +0000)]
setCellFormula: blank cell gets value 0, non-blank value is preserved

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852212 13f79535-47bb-0310-9956-ffa450edef68

5 years agotry to fix missing modules error and move addOpens detection into ant build
Andreas Beeker [Thu, 24 Jan 2019 20:35:18 +0000 (20:35 +0000)]
try to fix missing modules error and move addOpens detection into ant build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852072 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd required --add-opens and other settings for JDK 12 on Windows
Dominik Stadler [Tue, 22 Jan 2019 10:45:26 +0000 (10:45 +0000)]
Add required --add-opens and other settings for JDK 12 on Windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851804 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins: Try to disable coverage for JDK 13 for now as it seems to cause issues
Dominik Stadler [Tue, 22 Jan 2019 10:23:58 +0000 (10:23 +0000)]
Jenkins: Try to disable coverage for JDK 13 for now as it seems to cause issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851803 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins: Add initial build for JDK 13, add build for JDK 12 on Windows
Dominik Stadler [Tue, 22 Jan 2019 10:07:02 +0000 (10:07 +0000)]
Jenkins: Add initial build for JDK 13, add build for JDK 12 on Windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851798 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix invalid comment in build.xml
Dominik Stadler [Tue, 22 Jan 2019 10:04:53 +0000 (10:04 +0000)]
Fix invalid comment in build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851797 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix passing in --add-opens for Java 9+ after the poiunit refactoring, this
Dominik Stadler [Tue, 22 Jan 2019 10:01:36 +0000 (10:01 +0000)]
Fix passing in --add-opens for Java 9+ after the poiunit refactoring, this
only caused problems with Java 9+ on Windows, which we do not run in CI (yet)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851796 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix some IDE warnings and JVM deprecations
Dominik Stadler [Tue, 22 Jan 2019 10:00:01 +0000 (10:00 +0000)]
Fix some IDE warnings and JVM deprecations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851795 13f79535-47bb-0310-9956-ffa450edef68

5 years agotry to fix xmlbeans build
PJ Fanning [Sat, 19 Jan 2019 11:50:14 +0000 (11:50 +0000)]
try to fix xmlbeans build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851667 13f79535-47bb-0310-9956-ffa450edef68

5 years agoupdate xmlbeans targets
Andreas Beeker [Fri, 18 Jan 2019 23:14:06 +0000 (23:14 +0000)]
update xmlbeans targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851657 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[github-140] add .travis.yml. Thanks to krichter722. This closes #140
PJ Fanning [Tue, 15 Jan 2019 00:49:16 +0000 (00:49 +0000)]
[github-140] add .travis.yml. Thanks to krichter722. This closes #140

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851312 13f79535-47bb-0310-9956-ffa450edef68

5 years agofollow-up to Bug 62904. More tests and improved evaluation of IF in array mode
Yegor Kozlov [Mon, 14 Jan 2019 14:48:21 +0000 (14:48 +0000)]
follow-up to Bug 62904. More tests and improved evaluation of IF in array mode

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851263 13f79535-47bb-0310-9956-ffa450edef68

5 years agoDon't fail on row-nums larger than Integer.MAX_VALUE, we had one sample
Dominik Stadler [Sun, 13 Jan 2019 17:14:31 +0000 (17:14 +0000)]
Don't fail on row-nums larger than Integer.MAX_VALUE, we had one sample
file which triggered this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851211 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix some Findbugs and IDE issues, refactor some duplicated code,
Dominik Stadler [Sun, 13 Jan 2019 17:14:24 +0000 (17:14 +0000)]
Fix some Findbugs and IDE issues, refactor some duplicated code,
improve some exception texts, add comment for missing Ptg for SxName

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62810: AreaReference ctor looses sheet name if rows or columns swapped
Dominik Stadler [Sun, 13 Jan 2019 17:14:05 +0000 (17:14 +0000)]
Bug 62810: AreaReference ctor looses sheet name if rows or columns swapped

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851209 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd reproducer for bug 60355
Dominik Stadler [Sun, 13 Jan 2019 17:13:57 +0000 (17:13 +0000)]
Add reproducer for bug 60355

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851208 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRevert inadvertently commented lines
Dominik Stadler [Fri, 11 Jan 2019 19:31:18 +0000 (19:31 +0000)]
Revert inadvertently commented lines

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851092 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRemove obsolete settings from JDK 11/12 build
Dominik Stadler [Fri, 11 Jan 2019 19:31:14 +0000 (19:31 +0000)]
Remove obsolete settings from JDK 11/12 build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851091 13f79535-47bb-0310-9956-ffa450edef68

5 years agoEnable weekly run of Java 12 build
Dominik Stadler [Fri, 11 Jan 2019 19:31:09 +0000 (19:31 +0000)]
Enable weekly run of Java 12 build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851090 13f79535-47bb-0310-9956-ffa450edef68

5 years agoIDE and JavaDoc fixes, move/remove some unfixed tests
Dominik Stadler [Fri, 11 Jan 2019 19:31:05 +0000 (19:31 +0000)]
IDE and JavaDoc fixes, move/remove some unfixed tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851089 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd one more test for bug 62828 and fix some IDE warnings
Dominik Stadler [Fri, 11 Jan 2019 19:30:44 +0000 (19:30 +0000)]
Add one more test for bug 62828 and fix some IDE warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851088 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug #60977 writing XSSF with custom properties twice corrupts output
Greg Woolsey [Fri, 11 Jan 2019 18:20:03 +0000 (18:20 +0000)]
Bug #60977 writing XSSF with custom properties twice corrupts output

turns out the output XML data buffer for the custom properties document was appended to, not replaced, when writing in the presence of existing content.  Now clearing output buffer first in this case.  When first creating custom properties, i.e. first write after changes, there is no buffer yet, so nothing to clear.

Does not affect any read operations, or other writes beyond custom properties, as that was where the problem lay, not down in the Zip stuff.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851084 13f79535-47bb-0310-9956-ffa450edef68

5 years agouse spaces for indents
PJ Fanning [Thu, 10 Jan 2019 08:13:00 +0000 (08:13 +0000)]
use spaces for indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850926 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63054: updated formulas in test spreadsheet to keep build happy
Yegor Kozlov [Tue, 8 Jan 2019 16:36:34 +0000 (16:36 +0000)]
Bug 63054: updated formulas in test spreadsheet to keep build happy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850772 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63054: improved evaluation of array formulas with error in arguments
Yegor Kozlov [Tue, 8 Jan 2019 12:54:39 +0000 (12:54 +0000)]
Bug 63054: improved evaluation of array formulas with error in arguments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850742 13f79535-47bb-0310-9956-ffa450edef68

5 years agounified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc...
Vladislav Galas [Mon, 7 Jan 2019 19:10:19 +0000 (19:10 +0000)]
unified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc and tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850676 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62904: Support array arguments in IF and logical IS*** functions
Yegor Kozlov [Mon, 7 Jan 2019 14:34:19 +0000 (14:34 +0000)]
Bug 62904: Support array arguments in IF and logical IS*** functions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850646 13f79535-47bb-0310-9956-ffa450edef68

5 years agoupdated mockito to 2.23.4 to fix java 11 build
Vladislav Galas [Sun, 6 Jan 2019 18:56:29 +0000 (18:56 +0000)]
updated mockito to 2.23.4 to fix java 11 build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850590 13f79535-47bb-0310-9956-ffa450edef68

5 years agothrow IllegalArgumnetException if null directory specified
PJ Fanning [Fri, 4 Jan 2019 16:07:53 +0000 (16:07 +0000)]
throw IllegalArgumnetException if null directory specified

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850394 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFixed build (explicitly specified charset for new String(byte[]))
Vladislav Galas [Fri, 4 Jan 2019 14:25:11 +0000 (14:25 +0000)]
Fixed build (explicitly specified charset for new String(byte[]))

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850366 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63057: made SXSSFCell.setCellValue(String|RichTextString) exception-safe.
Vladislav Galas [Fri, 4 Jan 2019 10:10:30 +0000 (10:10 +0000)]
Bug 63057: made SXSSFCell.setCellValue(String|RichTextString) exception-safe.
Also removed unused code.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850342 13f79535-47bb-0310-9956-ffa450edef68

5 years agoImproved test coverage for *Cell classes
Vladislav Galas [Fri, 4 Jan 2019 09:17:48 +0000 (09:17 +0000)]
Improved test coverage for *Cell classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850338 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying...
Vladislav Galas [Thu, 3 Jan 2019 00:08:52 +0000 (00:08 +0000)]
Bug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying XSSFSheet. Thanks to Axel Howind.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850212 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62828: CellReference(Cell) now initializes sheet name.
Vladislav Galas [Wed, 2 Jan 2019 22:08:38 +0000 (22:08 +0000)]
Bug 62828: CellReference(Cell) now initializes sheet name.
Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62307: made Cell#getNumericCellValue() behavior consistent across HSSF/XSSF/SXSSF...
Vladislav Galas [Wed, 2 Jan 2019 20:45:52 +0000 (20:45 +0000)]
Bug 62307: made Cell#getNumericCellValue() behavior consistent across HSSF/XSSF/SXSSF.\nAll three implementations throw ISE when trying to get numeric value from a boolean-valued cell, have it a formula set or not.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850207 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd missing revert() in OPCPackage to close Zip-streams always
Dominik Stadler [Tue, 1 Jan 2019 20:10:58 +0000 (20:10 +0000)]
Add missing revert() in OPCPackage to close Zip-streams always

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850115 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd missing file-close in ZipInputStreamZipEntrySource seen in some mass regression...
Dominik Stadler [Tue, 1 Jan 2019 20:10:51 +0000 (20:10 +0000)]
Add missing file-close in ZipInputStreamZipEntrySource seen in some mass regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850114 13f79535-47bb-0310-9956-ffa450edef68

5 years agofix since annotation
PJ Fanning [Mon, 31 Dec 2018 14:27:32 +0000 (14:27 +0000)]
fix since annotation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850048 13f79535-47bb-0310-9956-ffa450edef68

5 years agoexclude integrationtest/build from rat-check
Andreas Beeker [Mon, 31 Dec 2018 12:27:31 +0000 (12:27 +0000)]
exclude integrationtest/build from rat-check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850041 13f79535-47bb-0310-9956-ffa450edef68

5 years ago#63047 - Make POILogger subclassable
Andreas Beeker [Mon, 31 Dec 2018 12:07:37 +0000 (12:07 +0000)]
#63047 - Make POILogger subclassable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850040 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdjust test for bug 60460 to also run fine on Windows
Dominik Stadler [Mon, 31 Dec 2018 09:05:05 +0000 (09:05 +0000)]
Adjust test for bug 60460 to also run fine on Windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850022 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 60460: Handle null workbook or sheet names and emit #REF as Excel does
Dominik Stadler [Sun, 30 Dec 2018 22:44:40 +0000 (22:44 +0000)]
Bug 60460: Handle null workbook or sheet names and emit #REF as Excel does
instead of throwing NullPointerException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850008 13f79535-47bb-0310-9956-ffa450edef68

5 years agoIDE and JavaDoc fixes
Dominik Stadler [Sun, 30 Dec 2018 22:44:29 +0000 (22:44 +0000)]
IDE and JavaDoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850007 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins DSL: Disable XMLBeans-JDK-11 as it will not work yet
Dominik Stadler [Sun, 30 Dec 2018 10:07:56 +0000 (10:07 +0000)]
Jenkins DSL: Disable XMLBeans-JDK-11 as it will not work yet

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849970 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 60845: Apply patch and adjust tests
Dominik Stadler [Sun, 30 Dec 2018 10:07:52 +0000 (10:07 +0000)]
Bug 60845: Apply patch and adjust tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849969 13f79535-47bb-0310-9956-ffa450edef68

5 years agoIDE and JavaDoc fixes, make base test classes abstract
Dominik Stadler [Sun, 30 Dec 2018 10:07:42 +0000 (10:07 +0000)]
IDE and JavaDoc fixes, make base test classes abstract

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849968 13f79535-47bb-0310-9956-ffa450edef68

5 years ago #63028 - Provide font embedding for slideshows
Andreas Beeker [Fri, 28 Dec 2018 23:43:31 +0000 (23:43 +0000)]
 #63028 - Provide font embedding for slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849898 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd Enum method to help identifying unknown records with POI-Visualizer
Andreas Beeker [Fri, 28 Dec 2018 23:42:57 +0000 (23:42 +0000)]
Add Enum method to help identifying unknown records with POI-Visualizer

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849897 13f79535-47bb-0310-9956-ffa450edef68