]> source.dussan.org Git - sonarqube.git/log
sonarqube.git
13 months agoSONAR-20327 Upgrade FE dependency jest-axe
Ambroise C [Wed, 6 Sep 2023 14:02:32 +0000 (16:02 +0200)]
SONAR-20327 Upgrade FE dependency jest-axe

13 months agoBUILD-3759 Run Mend scan with the nightly cron
Philippe Perrin [Mon, 11 Sep 2023 09:44:06 +0000 (11:44 +0200)]
BUILD-3759 Run Mend scan with the nightly cron

13 months agoSONAR-20430 fix flaky elasticsearch test by simplifying the test to only verify we...
Pierre [Mon, 11 Sep 2023 09:39:11 +0000 (11:39 +0200)]
SONAR-20430 fix flaky elasticsearch test by simplifying the test to only verify we use the correct es client parameters, without testing elasticsearch itself

13 months agoSONAR-20328 Update com.h2database:h2 to 2.2.2.222
Matteo Mara [Mon, 11 Sep 2023 07:55:00 +0000 (09:55 +0200)]
SONAR-20328 Update com.h2database:h2 to 2.2.2.222

13 months agoSONAR-20421 Fix telemetry measures not fetched from main branch
Léo Geoffroy [Fri, 8 Sep 2023 09:28:02 +0000 (11:28 +0200)]
SONAR-20421 Fix telemetry measures not fetched from main branch

13 months agoNO-JIRA Fix quality gate failure
Léo Geoffroy [Fri, 8 Sep 2023 08:57:40 +0000 (10:57 +0200)]
NO-JIRA Fix quality gate failure

13 months agoSONAR-20328 upgrade jfrog artifactory
Pierre Guillot [Fri, 8 Sep 2023 10:36:20 +0000 (12:36 +0200)]
SONAR-20328 upgrade jfrog artifactory

13 months agoUpdate eslint-plugin-local-rules to 2.0.0
David Cho-Lerat [Thu, 7 Sep 2023 09:43:54 +0000 (11:43 +0200)]
Update eslint-plugin-local-rules to 2.0.0

13 months agoNO-JIRA Harden QGChangeEventListenersImplTest usage of LogTester
antoine.vinot [Thu, 7 Sep 2023 08:22:58 +0000 (10:22 +0200)]
NO-JIRA Harden QGChangeEventListenersImplTest usage of LogTester

13 months agoSONAR-20328 Upgrade sonar-orchestrator version and update affected tests from breakin...
Dimitris Kavvathas [Wed, 6 Sep 2023 13:44:34 +0000 (15:44 +0200)]
SONAR-20328 Upgrade sonar-orchestrator version and update affected tests from breaking changes.

13 months agoSONAR-20328 Update org.kohsuke:github-api to 1.316
Matteo Mara [Wed, 6 Sep 2023 13:15:04 +0000 (15:15 +0200)]
SONAR-20328 Update org.kohsuke:github-api to 1.316

13 months agoSONAR-20328 Update org.yaml:snakeyaml to 2.2
Matteo Mara [Wed, 6 Sep 2023 13:14:46 +0000 (15:14 +0200)]
SONAR-20328 Update org.yaml:snakeyaml to 2.2

13 months agoSONAR-20328 Update org.slf4j to 2.0.9
Matteo Mara [Wed, 6 Sep 2023 13:13:45 +0000 (15:13 +0200)]
SONAR-20328 Update org.slf4j to 2.0.9

13 months agoSONAR-20328 Update org.mockito:mockito-core to 5.5.0
Matteo Mara [Wed, 6 Sep 2023 13:13:20 +0000 (15:13 +0200)]
SONAR-20328 Update org.mockito:mockito-core to 5.5.0

13 months agoSONAR-20328 Update commons-codec:commons-codec to 1.16.0
Matteo Mara [Wed, 6 Sep 2023 13:13:02 +0000 (15:13 +0200)]
SONAR-20328 Update commons-codec:commons-codec to 1.16.0

13 months agoSONAR-20328 Update commons-dbutils:commons-dbutils to 1.8.0
Matteo Mara [Wed, 6 Sep 2023 13:12:46 +0000 (15:12 +0200)]
SONAR-20328 Update commons-dbutils:commons-dbutils to 1.8.0

13 months agoSONAR-20328 Update org.eclipse.jgit:org.eclipse.jgit to 6.6.1.202309021850-r
Matteo Mara [Wed, 6 Sep 2023 13:12:12 +0000 (15:12 +0200)]
SONAR-20328 Update org.eclipse.jgit:org.eclipse.jgit to 6.6.1.202309021850-r

13 months agoSONAR-20328 Update org.elasticsearch.plugin:transport-netty4-client to 7.17.12
Matteo Mara [Wed, 6 Sep 2023 13:11:53 +0000 (15:11 +0200)]
SONAR-20328 Update org.elasticsearch.plugin:transport-netty4-client to 7.17.12

13 months agoSONAR-20328 Update org.elasticsearch.client:elasticsearch-rest-high-level-client...
Matteo Mara [Wed, 6 Sep 2023 13:11:18 +0000 (15:11 +0200)]
SONAR-20328 Update org.elasticsearch.client:elasticsearch-rest-high-level-client to 7.17.12

13 months agoSONAR-20328 Update io.netty:netty-all to 4.1.97.Final
Matteo Mara [Wed, 6 Sep 2023 13:10:55 +0000 (15:10 +0200)]
SONAR-20328 Update io.netty:netty-all to 4.1.97.Final

13 months agoSONAR-20328 Update org.aspectj to 1.9.20.1
Matteo Mara [Wed, 6 Sep 2023 13:10:34 +0000 (15:10 +0200)]
SONAR-20328 Update org.aspectj to 1.9.20.1

13 months agoSONAR-20328 Update org.bouncycastle:bcpkix-jdk18on to 1.76
Matteo Mara [Wed, 6 Sep 2023 13:09:46 +0000 (15:09 +0200)]
SONAR-20328 Update org.bouncycastle:bcpkix-jdk18on to 1.76

13 months agoSONAR-20328 Update com.microsoft.sqlserver:mssql-jdbc to 12.4.1.jre11
Matteo Mara [Wed, 6 Sep 2023 13:06:22 +0000 (15:06 +0200)]
SONAR-20328 Update com.microsoft.sqlserver:mssql-jdbc to 12.4.1.jre11

13 months agoSONAR-20328 Update com.hazelcast to 5.3.2
Matteo Mara [Wed, 6 Sep 2023 13:06:02 +0000 (15:06 +0200)]
SONAR-20328 Update com.hazelcast to 5.3.2

13 months agoSONAR-20328 Update com.squareup.okio:okio to 3.5.0
Matteo Mara [Wed, 6 Sep 2023 13:05:43 +0000 (15:05 +0200)]
SONAR-20328 Update com.squareup.okio:okio to 3.5.0

13 months agoSONAR-20328 Update ch.qos.logback to 1.3.11
Matteo Mara [Wed, 6 Sep 2023 13:05:12 +0000 (15:05 +0200)]
SONAR-20328 Update ch.qos.logback to 1.3.11

13 months agoSONAR-20328 Update com.google.protobuf:protobuf-java to 3.24.2
Matteo Mara [Wed, 6 Sep 2023 13:04:52 +0000 (15:04 +0200)]
SONAR-20328 Update com.google.protobuf:protobuf-java to 3.24.2

13 months agoSONAR-20328 Update io.spring.dependency-management to 1.1.3
Matteo Mara [Wed, 6 Sep 2023 13:02:59 +0000 (15:02 +0200)]
SONAR-20328 Update io.spring.dependency-management to 1.1.3

13 months agoSONAR-20328 Update de.undercouch.download to 5.5.0
Matteo Mara [Wed, 6 Sep 2023 13:02:25 +0000 (15:02 +0200)]
SONAR-20328 Update de.undercouch.download to 5.5.0

13 months agoSONAR-20328 upgrade keycloak
Pierre [Wed, 6 Sep 2023 12:58:30 +0000 (14:58 +0200)]
SONAR-20328 upgrade keycloak

13 months agoUpdate regenerator-runtime to 0.14.0
David Cho-Lerat [Wed, 6 Sep 2023 10:16:57 +0000 (12:16 +0200)]
Update regenerator-runtime to 0.14.0

13 months agoUpdate react-select to 5.7.4
David Cho-Lerat [Wed, 6 Sep 2023 09:06:19 +0000 (11:06 +0200)]
Update react-select to 5.7.4

13 months agoUpdate react-day-picker to 8.8.1
David Cho-Lerat [Wed, 6 Sep 2023 08:58:48 +0000 (10:58 +0200)]
Update react-day-picker to 8.8.1

13 months agoUpdate core-js to 3.32.1
David Cho-Lerat [Wed, 6 Sep 2023 08:32:21 +0000 (10:32 +0200)]
Update core-js to 3.32.1

13 months agoUpdate @tanstack/react-query to 4.33.0
David Cho-Lerat [Wed, 6 Sep 2023 08:30:36 +0000 (10:30 +0200)]
Update @tanstack/react-query to 4.33.0

13 months agoUpdate dompurify to 3.0.5
David Cho-Lerat [Wed, 6 Sep 2023 10:07:24 +0000 (12:07 +0200)]
Update dompurify to 3.0.5

13 months agoUpdate @primer/octicons-react to 19.7.0
David Cho-Lerat [Wed, 6 Sep 2023 10:04:44 +0000 (12:04 +0200)]
Update @primer/octicons-react to 19.7.0

13 months agoNO-JIRA Fix test sending data to ES
antoine.vinot [Wed, 6 Sep 2023 08:49:08 +0000 (10:49 +0200)]
NO-JIRA Fix test sending data to ES

13 months agoSONAR-20327 Update patch/minor front-end dev dependencies
David Cho-Lerat [Wed, 6 Sep 2023 09:46:59 +0000 (11:46 +0200)]
SONAR-20327 Update patch/minor front-end dev dependencies

13 months agoSONAR-20268 Add new module for test failure monitoring
Steve Marion [Wed, 30 Aug 2023 13:27:35 +0000 (15:27 +0200)]
SONAR-20268 Add new module for test failure monitoring

13 months agoNO-JIRA Fix CCT typo
7PH [Tue, 5 Sep 2023 13:51:50 +0000 (15:51 +0200)]
NO-JIRA Fix CCT typo

13 months agoNO-JIRA remove test datadog apikey
jeremy cotineau [Mon, 4 Sep 2023 14:53:10 +0000 (16:53 +0200)]
NO-JIRA remove test datadog apikey

13 months agoSONAR-20285 PATCH endpoint to update users
Wojtek Wajerowicz [Mon, 4 Sep 2023 11:55:21 +0000 (13:55 +0200)]
SONAR-20285 PATCH endpoint to update users

Co-authored-by: Aurelien Poscia <aurelien.poscia@sonarsource.com>
13 months agoSONAR-20335 Upgrade gradle scanner to 4.3.1.3277
Matteo Mara [Mon, 4 Sep 2023 08:50:24 +0000 (10:50 +0200)]
SONAR-20335 Upgrade gradle scanner to 4.3.1.3277

13 months ago[NO JIRA] Splitting issues app IT in multiple file
Revanshu Paliwal [Thu, 24 Aug 2023 09:11:23 +0000 (11:11 +0200)]
[NO JIRA] Splitting issues app IT in multiple file

13 months agoSQDEVOPS-224 push qa metrics to datadog
jeremy cotineau [Fri, 1 Sep 2023 13:51:43 +0000 (15:51 +0200)]
SQDEVOPS-224 push qa metrics to datadog

13 months agoSONAR-20322 Migrate Context Providers tests to RTL
Jeremy Davis [Fri, 1 Sep 2023 09:13:05 +0000 (11:13 +0200)]
SONAR-20322 Migrate Context Providers tests to RTL

13 months agoSONAR-20249 Hide NCD banner on save (#9186)
Ambroise C [Fri, 1 Sep 2023 12:18:58 +0000 (14:18 +0200)]
SONAR-20249 Hide NCD banner on save (#9186)

13 months agoSONAR-18769 Use t2.xlarge node for qa_ha task
Jacek Poreda [Thu, 31 Aug 2023 09:15:24 +0000 (11:15 +0200)]
SONAR-18769 Use t2.xlarge node for qa_ha task

13 months agoSONAR-19879 Stabilize flaky test: StaticResourcesServletTest
Jeremy Davis [Thu, 31 Aug 2023 15:08:34 +0000 (17:08 +0200)]
SONAR-19879 Stabilize flaky test: StaticResourcesServletTest

13 months agoSONAR-20261 Fix FP test_as_project_admin
stanislavh [Thu, 31 Aug 2023 11:09:16 +0000 (13:09 +0200)]
SONAR-20261 Fix FP test_as_project_admin

13 months ago[NO JIRA] Fix Flaky Test - User load more in managed mode
guillaume-peoch-sonarsource [Fri, 1 Sep 2023 08:09:40 +0000 (10:09 +0200)]
[NO JIRA] Fix Flaky Test - User load more in managed mode

13 months agoNO-JIRA Update version to 10.3
Dimitris Kavvathas [Fri, 1 Sep 2023 07:12:32 +0000 (09:12 +0200)]
NO-JIRA Update version to 10.3

13 months agoSONAR-19888 Update test framework to not use addProjectPermission(java.lang.String... 10.2.0.77647
Léo Geoffroy [Thu, 31 Aug 2023 10:00:49 +0000 (12:00 +0200)]
SONAR-19888 Update test framework to not use addProjectPermission(java.lang.String, org.sonar.db.component.ComponentDto...)

13 months agoSONAR-20281 Upgrade sonar-cfamily to 6.48.1.62610
Dimitris Kavvathas [Thu, 31 Aug 2023 12:49:49 +0000 (14:49 +0200)]
SONAR-20281 Upgrade sonar-cfamily to 6.48.1.62610

13 months agoSONAR-20308 Upgrade sonar-cobol to 5.5.0.6450
Matteo Mara [Thu, 31 Aug 2023 08:12:46 +0000 (10:12 +0200)]
SONAR-20308 Upgrade sonar-cobol to 5.5.0.6450

13 months agoSONAR-20294 Fix flaky jest test UserApp
guillaume-peoch-sonarsource [Wed, 30 Aug 2023 16:11:32 +0000 (18:11 +0200)]
SONAR-20294 Fix flaky jest test UserApp

13 months agoSONAR-19764 Fix flaky test incorrect_quality_gate_information
Alain Kermis [Thu, 31 Aug 2023 13:28:40 +0000 (15:28 +0200)]
SONAR-19764 Fix flaky test incorrect_quality_gate_information

13 months agoSONAR-20309 Do not sync GH permissions when admins did not explicitly consent to it
guillaume-peoch-sonarsource [Wed, 30 Aug 2023 16:07:04 +0000 (18:07 +0200)]
SONAR-20309 Do not sync GH permissions when admins did not explicitly consent to it

13 months agoNO-JIRA improve wording of messages for enabling SCIM/GitHub provisioning
Aurelien Poscia [Thu, 31 Aug 2023 08:41:03 +0000 (10:41 +0200)]
NO-JIRA improve wording of messages for enabling SCIM/GitHub provisioning

13 months agoSONAR-20309 Fail GH sync bg task, in case user consent is needed
Aurelien Poscia [Wed, 30 Aug 2023 14:38:41 +0000 (16:38 +0200)]
SONAR-20309 Fail GH sync bg task, in case user consent is needed

13 months agoSONAR-20312 add migration to require user consent for GH synchronization
Aurelien Poscia [Wed, 30 Aug 2023 13:41:11 +0000 (15:41 +0200)]
SONAR-20312 add migration to require user consent for GH synchronization

13 months agoSONAR-20283 Fix API call consistently failing after navigating back to an application
7PH [Thu, 31 Aug 2023 11:49:59 +0000 (13:49 +0200)]
SONAR-20283 Fix API call consistently failing after navigating back to an application

13 months agoSONAR-20254 Migrate app-level component tests to RTL
Jay [Thu, 31 Aug 2023 13:52:25 +0000 (15:52 +0200)]
SONAR-20254 Migrate app-level component tests to RTL

13 months agoSONAR-19467 deprecated uuids in audit logs
lukasz-jarocki-sonarsource [Thu, 31 Aug 2023 12:26:31 +0000 (14:26 +0200)]
SONAR-19467 deprecated uuids in audit logs

13 months agoSONAR-20058 simplify upgrade to 10.2 by removing index creation that is deleted later
Pierre [Wed, 30 Aug 2023 14:52:08 +0000 (16:52 +0200)]
SONAR-20058 simplify upgrade to 10.2 by removing index creation that is deleted later

13 months agoSONAR-20058 improve webhook purge mechanism
Pierre [Tue, 29 Aug 2023 07:03:58 +0000 (09:03 +0200)]
SONAR-20058 improve webhook purge mechanism

13 months agoSONAR-20164 add `created_at` to indexes
Pierre [Mon, 28 Aug 2023 15:19:00 +0000 (17:19 +0200)]
SONAR-20164 add `created_at` to indexes

13 months agoSONAR-20164 replace in-memory pagination with sql pagination
Pierre [Mon, 28 Aug 2023 15:18:13 +0000 (17:18 +0200)]
SONAR-20164 replace in-memory pagination with sql pagination

13 months agoSONAR-20295 Fix flaky test in ComponentMeasures-it
David Cho-Lerat [Thu, 31 Aug 2023 12:10:52 +0000 (14:10 +0200)]
SONAR-20295 Fix flaky test in ComponentMeasures-it

13 months agoSONAR-20254 Using RTL for component container
Revanshu Paliwal [Tue, 29 Aug 2023 15:13:39 +0000 (17:13 +0200)]
SONAR-20254 Using RTL for component container

13 months agoSONAR-19435 Infer component type from URL to make component not found error more...
7PH [Wed, 30 Aug 2023 07:14:39 +0000 (09:14 +0200)]
SONAR-19435 Infer component type from URL to make component not found error more explicit

13 months agoSONAR-19372 apply anticipated transitions only to eligible issues
Matteo Mara [Wed, 30 Aug 2023 10:37:47 +0000 (12:37 +0200)]
SONAR-19372 apply anticipated transitions only to eligible issues

13 months agoSONAR-19888 Fix tests usage on PermissionIndexerTester
Léo Geoffroy [Wed, 30 Aug 2023 14:08:07 +0000 (16:08 +0200)]
SONAR-19888 Fix tests usage on PermissionIndexerTester

13 months agoSONAR-19840 Ensure project activity takes branch into account
Philippe Perrin [Wed, 30 Aug 2023 15:14:48 +0000 (17:14 +0200)]
SONAR-19840 Ensure project activity takes branch into account

13 months agoSONAR-20057 Security hostpot header remains visible
David Cho-Lerat [Thu, 31 Aug 2023 08:56:43 +0000 (10:56 +0200)]
SONAR-20057 Security hostpot header remains visible

13 months agoSONAR-19600 Change wording for DevOps platform settings description depending on...
David Cho-Lerat [Wed, 30 Aug 2023 15:19:23 +0000 (17:19 +0200)]
SONAR-19600 Change wording for DevOps platform settings description depending on edition

13 months agoSONAR-19978 Fix flaky `SupportedTopologyClusterTest#app_node_can_join_and_quit_cluster`
Jacek Poreda [Wed, 30 Aug 2023 09:32:20 +0000 (11:32 +0200)]
SONAR-19978 Fix flaky `SupportedTopologyClusterTest#app_node_can_join_and_quit_cluster`

- Increased memory on WEB and CE processes due OOM
link: https://github.com/hazelcast/hazelcast/blob/master/docs/design/cluster/02-partial-member-disconnection-resolution.md
13 months agoSONAR-20310 Provide PIDDIR environment variable in the bootstrap script to allow...
Zipeng WU [Wed, 30 Aug 2023 12:49:07 +0000 (14:49 +0200)]
SONAR-20310 Provide PIDDIR environment variable in the bootstrap script to allow customization

13 months agoSONAR-20254 Migrate FormattingHelp test to RTL
Jeremy Davis [Wed, 30 Aug 2023 12:16:43 +0000 (14:16 +0200)]
SONAR-20254 Migrate FormattingHelp test to RTL

13 months agoSONAR-20254 Migrate Landing test to RTL
Jeremy Davis [Wed, 30 Aug 2023 12:11:27 +0000 (14:11 +0200)]
SONAR-20254 Migrate Landing test to RTL

13 months agoSONAR-20254 Migrate StartupModal test to RTL
Jeremy Davis [Wed, 30 Aug 2023 10:38:29 +0000 (12:38 +0200)]
SONAR-20254 Migrate StartupModal test to RTL

13 months agoSONAR-20254 Migrate ResetPassword test to RTL
Jeremy Davis [Wed, 30 Aug 2023 09:46:45 +0000 (11:46 +0200)]
SONAR-20254 Migrate ResetPassword test to RTL

13 months agoSONAR-20254 Migrate PluginRiskConsent test to RTL
Jeremy Davis [Wed, 30 Aug 2023 09:20:49 +0000 (11:20 +0200)]
SONAR-20254 Migrate PluginRiskConsent test to RTL

13 months agoSONAR-20254 Migrate Global Footer test to RTL
Jeremy Davis [Wed, 30 Aug 2023 09:06:10 +0000 (11:06 +0200)]
SONAR-20254 Migrate  Global Footer test to RTL

13 months agoSONAR-20220 Show warnings for non compliant Quality Gate only when user can edit it
Zipeng WU [Tue, 22 Aug 2023 15:49:26 +0000 (17:49 +0200)]
SONAR-20220 Show warnings for non compliant Quality Gate only when user can edit it

13 months agoSONAR-20256 Migrate Workspace tests to RTL
Jeremy Davis [Tue, 29 Aug 2023 15:56:00 +0000 (17:56 +0200)]
SONAR-20256 Migrate Workspace tests to RTL

13 months agoSONAR-19708 Use read-all permission within Github Actions tutorial sample YAML
7PH [Tue, 29 Aug 2023 13:51:30 +0000 (15:51 +0200)]
SONAR-19708 Use read-all permission within Github Actions tutorial sample YAML

13 months agoSONAR-19707 Remove usage of GITHUB_TOKEN in GitHub Actions tutorials
7PH [Tue, 29 Aug 2023 07:04:32 +0000 (09:04 +0200)]
SONAR-19707 Remove usage of GITHUB_TOKEN in GitHub Actions tutorials

13 months agoSONAR-20260 Fix quality gate
Léo Geoffroy [Tue, 29 Aug 2023 15:51:55 +0000 (17:51 +0200)]
SONAR-20260 Fix quality gate

13 months agoSONAR-20255 - Indexation migration enzyme to rtl
Kevin Silva [Fri, 25 Aug 2023 11:44:06 +0000 (13:44 +0200)]
SONAR-20255 - Indexation migration enzyme to rtl

13 months agoSONAR-19839 branch renaming gets propagated to new code periods branch references
Matteo Mara [Tue, 29 Aug 2023 09:36:56 +0000 (11:36 +0200)]
SONAR-19839 branch renaming  gets propagated to new code periods branch references

13 months agoSONAR-20023 Keep support for the old severity filter if provided in the URL
7PH [Tue, 29 Aug 2023 12:34:05 +0000 (14:34 +0200)]
SONAR-20023 Keep support for the old severity filter if provided in the URL

13 months agoSONAR-19324 Fix api/projects/search low performances
Alain Kermis [Thu, 24 Aug 2023 06:35:56 +0000 (08:35 +0200)]
SONAR-19324 Fix api/projects/search low performances

13 months agoSONAR-18446 Migrate web-api tests to RTL
Jeremy Davis [Mon, 28 Aug 2023 17:00:18 +0000 (19:00 +0200)]
SONAR-18446 Migrate web-api tests to RTL

13 months agoSONAR-20260 clean code fields are not populated for security hotspot
Léo Geoffroy [Mon, 28 Aug 2023 12:41:14 +0000 (14:41 +0200)]
SONAR-20260 clean code fields are not populated for security hotspot

13 months agoSONAR-20071 Update references to JDK 17 and scanner cli version 5.0 in tutorials
Matteo Mara [Wed, 23 Aug 2023 12:50:57 +0000 (14:50 +0200)]
SONAR-20071 Update references to JDK 17 and scanner cli version 5.0 in tutorials

13 months agoSONAR-20264 Upgrade sonar-php to 3.32.0.10180
Matteo Mara [Mon, 28 Aug 2023 13:15:32 +0000 (15:15 +0200)]
SONAR-20264 Upgrade sonar-php to 3.32.0.10180

13 months agoSONAR-19068 Fix scrolling issue
Jeremy Davis [Mon, 28 Aug 2023 15:00:55 +0000 (17:00 +0200)]
SONAR-19068 Fix scrolling issue

13 months agoSONAR-19930 New code definition: Simplify title above list of choices
David Cho-Lerat [Mon, 28 Aug 2023 14:43:38 +0000 (16:43 +0200)]
SONAR-19930 New code definition: Simplify title above list of choices