]> source.dussan.org Git - redmine.git/log
redmine.git
5 years agoMerged r17702.
Jean-Philippe Lang [Sat, 8 Dec 2018 09:34:44 +0000 (09:34 +0000)]
Merged r17702.

git-svn-id: http://svn.redmine.org/redmine/branches/4.0-stable@17703 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRandom test failure.
Jean-Philippe Lang [Sat, 8 Dec 2018 07:24:52 +0000 (07:24 +0000)]
Random test failure.

git-svn-id: http://svn.redmine.org/redmine/trunk@17702 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoSet stable version.
Jean-Philippe Lang [Sat, 8 Dec 2018 06:51:41 +0000 (06:51 +0000)]
Set stable version.

git-svn-id: http://svn.redmine.org/redmine/branches/4.0-stable@17701 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoMerged r17699.
Jean-Philippe Lang [Sat, 8 Dec 2018 06:51:06 +0000 (06:51 +0000)]
Merged r17699.

git-svn-id: http://svn.redmine.org/redmine/branches/4.0-stable@17700 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoBump version to 4.0.0
Jean-Philippe Lang [Sat, 8 Dec 2018 06:50:23 +0000 (06:50 +0000)]
Bump version to 4.0.0

git-svn-id: http://svn.redmine.org/redmine/trunk@17699 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCreated 4.0-stable branch.
Jean-Philippe Lang [Sat, 8 Dec 2018 06:46:55 +0000 (06:46 +0000)]
Created 4.0-stable branch.

git-svn-id: http://svn.redmine.org/redmine/branches/4.0-stable@17698 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTests broken for SQLite3 (#30119).
Jean-Philippe Lang [Sat, 8 Dec 2018 06:40:29 +0000 (06:40 +0000)]
Tests broken for SQLite3 (#30119).

git-svn-id: http://svn.redmine.org/redmine/trunk@17697 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDon't explicitly install csv gem in Ruby 2.6 (#30118).
Go MAEDA [Sat, 8 Dec 2018 05:51:01 +0000 (05:51 +0000)]
Don't explicitly install csv gem in Ruby 2.6 (#30118).

Redmine installs csv gem since r17245 as a workaround for a bug of csv 1.0.0 which is bundled with Ruby 2.5 (see #28112). But in Ruby 2.6, installing the gem is not necessary because the bundled csv gem was updated to 3.0.

git-svn-id: http://svn.redmine.org/redmine/trunk@17696 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate Rails to 5.2.2 (#30119).
Go MAEDA [Fri, 7 Dec 2018 09:40:02 +0000 (09:40 +0000)]
Update Rails to 5.2.2 (#30119).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17695 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd missing fixture for reports_controller_test (#30120).
Go MAEDA [Fri, 7 Dec 2018 09:18:52 +0000 (09:18 +0000)]
Add missing fixture for reports_controller_test (#30120).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17694 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoInclude closed projects in search for scope subprojects (#28636).
Go MAEDA [Thu, 6 Dec 2018 23:21:53 +0000 (23:21 +0000)]
Include closed projects in search for scope subprojects (#28636).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17692 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix typo (#29503).
Go MAEDA [Thu, 6 Dec 2018 13:23:25 +0000 (13:23 +0000)]
Fix typo (#29503).

git-svn-id: http://svn.redmine.org/redmine/trunk@17691 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDiscourage search engines from indexing old versions of wiki pages (#29503).
Go MAEDA [Thu, 6 Dec 2018 00:40:39 +0000 (00:40 +0000)]
Discourage search engines from indexing old versions of wiki pages (#29503).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17690 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCurrent user should be nil to prevent ActiveJob::DeserializationError errors in tests.
Go MAEDA [Thu, 6 Dec 2018 00:34:21 +0000 (00:34 +0000)]
Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.

git-svn-id: http://svn.redmine.org/redmine/trunk@17689 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCurrent user should be nil to prevent ActiveJob::DeserializationError errors in tests.
Go MAEDA [Tue, 4 Dec 2018 10:29:56 +0000 (10:29 +0000)]
Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.

git-svn-id: http://svn.redmine.org/redmine/trunk@17688 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoWrong columns after CSV export (#26785).
Go MAEDA [Tue, 4 Dec 2018 09:23:18 +0000 (09:23 +0000)]
Wrong columns after CSV export (#26785).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17686 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUse sorted instead of sort (#29406).
Go MAEDA [Sun, 2 Dec 2018 22:31:44 +0000 (22:31 +0000)]
Use sorted instead of sort (#29406).

Patch by Pavel Rosický.

git-svn-id: http://svn.redmine.org/redmine/trunk@17685 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix for r17683: s/button_search/label_search/ (#26620).
Go MAEDA [Sun, 2 Dec 2018 15:31:48 +0000 (15:31 +0000)]
Fix for r17683: s/button_search/label_search/ (#26620).

git-svn-id: http://svn.redmine.org/redmine/trunk@17684 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoChange the text of the submit button on search page from button_submit to label_searc...
Go MAEDA [Sun, 2 Dec 2018 14:15:12 +0000 (14:15 +0000)]
Change the text of the submit button on search page from button_submit to label_search (#26620).

Patch by Dmitry Lisichkin.

git-svn-id: http://svn.redmine.org/redmine/trunk@17683 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoLet admins unarchive the project when trying to access an archived project (#29993).
Jean-Philippe Lang [Sun, 2 Dec 2018 11:23:10 +0000 (11:23 +0000)]
Let admins unarchive the project when trying to access an archived project (#29993).

git-svn-id: http://svn.redmine.org/redmine/trunk@17682 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoLet admin users unarchive subprojects of archived projects (#29993).
Jean-Philippe Lang [Sun, 2 Dec 2018 11:13:28 +0000 (11:13 +0000)]
Let admin users unarchive subprojects of archived projects (#29993).

git-svn-id: http://svn.redmine.org/redmine/trunk@17681 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDon't send notifications when using Issue.generate! in tests in order to speed up...
Jean-Philippe Lang [Sun, 2 Dec 2018 08:36:14 +0000 (08:36 +0000)]
Don't send notifications when using Issue.generate! in tests in order to speed up tests.

git-svn-id: http://svn.redmine.org/redmine/trunk@17680 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCurrent user should be nil to prevent ActiveJob::DeserializationError errors in tests.
Jean-Philippe Lang [Sun, 2 Dec 2018 07:54:49 +0000 (07:54 +0000)]
Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.

git-svn-id: http://svn.redmine.org/redmine/trunk@17679 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoMoves some action links on the wiki page to a dropdown menu (#26575).
Jean-Philippe Lang [Sun, 2 Dec 2018 07:34:36 +0000 (07:34 +0000)]
Moves some action links on the wiki page to a dropdown menu (#26575).

git-svn-id: http://svn.redmine.org/redmine/trunk@17678 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoReplace cancel button with cancel link in modals (#28662).
Go MAEDA [Sun, 2 Dec 2018 06:24:21 +0000 (06:24 +0000)]
Replace cancel button with cancel link in modals (#28662).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17677 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCzech translation update (#30075).
Go MAEDA [Sun, 2 Dec 2018 00:33:38 +0000 (00:33 +0000)]
Czech translation update (#30075).

Patch by Pavel Rosický.

git-svn-id: http://svn.redmine.org/redmine/trunk@17676 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTests failure with SQLite3.
Jean-Philippe Lang [Sat, 1 Dec 2018 12:38:16 +0000 (12:38 +0000)]
Tests failure with SQLite3.

ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALUES (?, ?)

git-svn-id: http://svn.redmine.org/redmine/trunk@17675 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTests failure with SQLite3.
Jean-Philippe Lang [Sat, 1 Dec 2018 12:35:45 +0000 (12:35 +0000)]
Tests failure with SQLite3.

ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALUES (?, ?)

git-svn-id: http://svn.redmine.org/redmine/trunk@17674 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTests failure with SQLite3.
Jean-Philippe Lang [Sat, 1 Dec 2018 12:33:57 +0000 (12:33 +0000)]
Tests failure with SQLite3.

ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALUES (?, ?)

git-svn-id: http://svn.redmine.org/redmine/trunk@17673 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix random test failure, assertion must be made against displayed values.
Jean-Philippe Lang [Sat, 1 Dec 2018 11:43:22 +0000 (11:43 +0000)]
Fix random test failure, assertion must be made against displayed values.

IssuesControllerTest#test_index_sort_by_spent_hours_should_sort_by_visible_spent_hours
Expected: [3.0, 0.0, 0.0]
  Actual: [3.0, 4.0, 0.0]

git-svn-id: http://svn.redmine.org/redmine/trunk@17672 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCurrent user should be nil to prevent ActiveJob::DeserializationError errors in tests.
Jean-Philippe Lang [Sat, 1 Dec 2018 11:25:30 +0000 (11:25 +0000)]
Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.

git-svn-id: http://svn.redmine.org/redmine/trunk@17671 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdds view_projects_copy_only_items hook (#28895).
Go MAEDA [Sat, 1 Dec 2018 10:03:34 +0000 (10:03 +0000)]
Adds view_projects_copy_only_items hook (#28895).

Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@17670 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoJapanese translation update (#30000).
Go MAEDA [Sat, 1 Dec 2018 08:38:26 +0000 (08:38 +0000)]
Japanese translation update (#30000).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17669 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUse "abort" instead of "exit" in order to make error log more informative (# 26791).
Go MAEDA [Sat, 1 Dec 2018 06:45:52 +0000 (06:45 +0000)]
Use "abort" instead of "exit" in order to make error log more informative (# 26791).

git-svn-id: http://svn.redmine.org/redmine/trunk@17668 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAllow single Chinese character as a search keyword (#30037).
Go MAEDA [Fri, 30 Nov 2018 15:42:30 +0000 (15:42 +0000)]
Allow single Chinese character as a search keyword (#30037).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17667 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCurrent user should be nil to prevent ActiveJob::DeserializationError errors in tests.
Jean-Philippe Lang [Thu, 29 Nov 2018 22:20:14 +0000 (22:20 +0000)]
Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.

git-svn-id: http://svn.redmine.org/redmine/trunk@17666 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCurrent user should be nil to prevent ActiveJob::DeserializationError errors in tests.
Jean-Philippe Lang [Thu, 29 Nov 2018 19:24:30 +0000 (19:24 +0000)]
Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.

git-svn-id: http://svn.redmine.org/redmine/trunk@17665 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate Redmine::Plugin documentation (#28996).
Jean-Philippe Lang [Thu, 29 Nov 2018 17:19:08 +0000 (17:19 +0000)]
Update Redmine::Plugin documentation (#28996).

git-svn-id: http://svn.redmine.org/redmine/trunk@17661 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRestore History link at the top of a wiki page (#26575).
Jean-Philippe Lang [Thu, 29 Nov 2018 16:36:36 +0000 (16:36 +0000)]
Restore History link at the top of a wiki page (#26575).

git-svn-id: http://svn.redmine.org/redmine/trunk@17660 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdds a test for #30001.
Jean-Philippe Lang [Thu, 29 Nov 2018 16:06:52 +0000 (16:06 +0000)]
Adds a test for #30001.

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17659 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCSV importer ignores shared version names of other projects (#30001).
Jean-Philippe Lang [Thu, 29 Nov 2018 16:06:30 +0000 (16:06 +0000)]
CSV importer ignores shared version names of other projects (#30001).

Patch by Yuuki NARA and Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17658 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdds a test for #29918.
Jean-Philippe Lang [Thu, 29 Nov 2018 15:57:04 +0000 (15:57 +0000)]
Adds a test for #29918.

git-svn-id: http://svn.redmine.org/redmine/trunk@17657 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRelated issues section ignores the date format setting (#29918).
Jean-Philippe Lang [Thu, 29 Nov 2018 15:51:16 +0000 (15:51 +0000)]
Related issues section ignores the date format setting (#29918).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17656 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd missing fixtures for test_create_with_one_attachment (#30054).
Go MAEDA [Thu, 29 Nov 2018 06:58:04 +0000 (06:58 +0000)]
Add missing fixtures for test_create_with_one_attachment (#30054).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17649 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd missing fixtures for test_create_should_send_notification (#29990).
Go MAEDA [Thu, 29 Nov 2018 06:52:33 +0000 (06:52 +0000)]
Add missing fixtures for test_create_should_send_notification (#29990).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17648 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTests for #29674.
Jean-Philippe Lang [Wed, 28 Nov 2018 18:15:56 +0000 (18:15 +0000)]
Tests for #29674.

Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@17646 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoMissing validation for custom field formats based on RecordList (#29674).
Jean-Philippe Lang [Wed, 28 Nov 2018 18:15:34 +0000 (18:15 +0000)]
Missing validation for custom field formats based on RecordList (#29674).

Patch by Alexander Achenbach.

git-svn-id: http://svn.redmine.org/redmine/trunk@17645 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix list rendering inside project description in projects#index (#29950).
Jean-Philippe Lang [Wed, 28 Nov 2018 18:11:05 +0000 (18:11 +0000)]
Fix list rendering inside project description in projects#index (#29950).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17644 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoREST API with JSON content missing false values (#20788).
Jean-Philippe Lang [Wed, 28 Nov 2018 18:03:07 +0000 (18:03 +0000)]
REST API with JSON content missing false values (#20788).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17643 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate Rails to 5.2.1.1 (#30042).
Jean-Philippe Lang [Wed, 28 Nov 2018 17:56:34 +0000 (17:56 +0000)]
Update Rails to 5.2.1.1 (#30042).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17641 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUnpin rdoc gem version (#29999).
Go MAEDA [Tue, 27 Nov 2018 11:11:27 +0000 (11:11 +0000)]
Unpin rdoc gem version (#29999).

git-svn-id: http://svn.redmine.org/redmine/trunk@17640 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove blank keys from sort criteria (#30009).
Go MAEDA [Mon, 26 Nov 2018 05:22:04 +0000 (05:22 +0000)]
Remove blank keys from sort criteria (#30009).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17638 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTags start with 'pre' are handled as 'pre' tag in Textile (#8395).
Go MAEDA [Mon, 26 Nov 2018 04:40:09 +0000 (04:40 +0000)]
Tags start with 'pre' are handled as 'pre' tag in Textile (#8395).

Patch by Takenori TAKAKI and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17636 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd wiki class also for half width custom fields with text formatting enabled (#30027).
Go MAEDA [Mon, 26 Nov 2018 00:23:08 +0000 (00:23 +0000)]
Add wiki class also for half width custom fields with text formatting enabled (#30027).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17634 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove trailing whitespaces from app/helpers/issues_helper.rb
Go MAEDA [Mon, 26 Nov 2018 00:21:28 +0000 (00:21 +0000)]
Remove trailing whitespaces from app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@17633 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFix: Attachments are added even if validation fails when updating an issue via email...
Go MAEDA [Fri, 23 Nov 2018 06:07:32 +0000 (06:07 +0000)]
Fix: Attachments are added even if validation fails when updating an issue via email (#28576).

Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@17630 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoUnpin roadie gem version (#29947).
Go MAEDA [Mon, 19 Nov 2018 12:31:19 +0000 (12:31 +0000)]
Unpin roadie gem version (#29947).

git-svn-id: http://svn.redmine.org/redmine/trunk@17629 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoUpgrade to Rouge 3.3.0 (#24681).
Go MAEDA [Sat, 10 Nov 2018 06:50:23 +0000 (06:50 +0000)]
Upgrade to Rouge 3.3.0 (#24681).

git-svn-id: http://svn.redmine.org/redmine/trunk@17626 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoStrip whitespace from integer custom field (#8317).
Go MAEDA [Thu, 8 Nov 2018 13:01:06 +0000 (13:01 +0000)]
Strip whitespace from integer custom field (#8317).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17625 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoSort issues by due date in email reminders (#29771).
Go MAEDA [Tue, 6 Nov 2018 03:13:46 +0000 (03:13 +0000)]
Sort issues by due date in email reminders (#29771).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17624 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoRemove trailing whitespaces from test/unit/mailer_test.rb
Go MAEDA [Tue, 6 Nov 2018 02:45:26 +0000 (02:45 +0000)]
Remove trailing whitespaces from test/unit/mailer_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@17623 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoRemove trailing whitespaces from app/models/mailer.rb
Go MAEDA [Tue, 6 Nov 2018 02:44:04 +0000 (02:44 +0000)]
Remove trailing whitespaces from app/models/mailer.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@17622 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoAdd missing closing tag in app/views/roles/_form.html.erb (#29912).
Go MAEDA [Mon, 5 Nov 2018 13:40:15 +0000 (13:40 +0000)]
Add missing closing tag in app/views/roles/_form.html.erb (#29912).

Patch by Vincent Robert.

git-svn-id: http://svn.redmine.org/redmine/trunk@17621 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoPrevious/Next link on repository page disappears when switching to "View differences...
Go MAEDA [Mon, 5 Nov 2018 02:40:04 +0000 (02:40 +0000)]
Previous/Next link on repository page disappears when switching to "View differences" tab (#26576, #29730).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17620 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoMove attachments to their own section in issue page (#29033).
Go MAEDA [Sun, 4 Nov 2018 07:26:29 +0000 (07:26 +0000)]
Move attachments to their own section in issue page (#29033).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17619 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFix typo in French text_tracker_no_workflow (#29901).
Go MAEDA [Sat, 3 Nov 2018 09:33:14 +0000 (09:33 +0000)]
Fix typo in French text_tracker_no_workflow (#29901).

Patch by Samuel Marchal.

git-svn-id: http://svn.redmine.org/redmine/trunk@17618 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoRemoves request and response accessors from Structure class (#28564).
Go MAEDA [Sat, 3 Nov 2018 08:11:22 +0000 (08:11 +0000)]
Removes request and response accessors from Structure class (#28564).

Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@17617 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFix that the following tests fail randomly due to uninitialized User.current (#29853):
Go MAEDA [Sat, 3 Nov 2018 07:15:00 +0000 (07:15 +0000)]
Fix that the following tests fail randomly due to uninitialized User.current (#29853):

* AttachmentsVisibilityTest#test_attachment_should_be_visible
*
Redmine::AttachmentFieldFormatTest#test_should_accept_a_hash_with_upload_on_create
*
Redmine::AttachmentFieldFormatTest#test_should_replace_attachment_on_update

Patch by Gilad Shanan.

git-svn-id: http://svn.redmine.org/redmine/trunk@17616 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoHide "Files" section in wiki pages when printing (#29791).
Go MAEDA [Wed, 31 Oct 2018 07:16:52 +0000 (07:16 +0000)]
Hide "Files" section in wiki pages when printing (#29791).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17614 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoRemove trailing whitespaces from app/views/wiki/show.html.erb
Go MAEDA [Wed, 31 Oct 2018 07:15:19 +0000 (07:15 +0000)]
Remove trailing whitespaces from app/views/wiki/show.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@17613 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoUse Project::STATUS_ACTIVE constant instead of harcoded 1 (#29449).
Go MAEDA [Mon, 29 Oct 2018 07:01:51 +0000 (07:01 +0000)]
Use Project::STATUS_ACTIVE constant instead of harcoded 1 (#29449).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17612 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFilter out issues from closed projects in the following widgets (#29449):
Go MAEDA [Mon, 29 Oct 2018 06:14:56 +0000 (06:14 +0000)]
Filter out issues from closed projects in the following widgets (#29449):

* Issues assigned to me
* Reported issues
* Watched issues

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17611 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoRemove trailing whitespaces from test/functional/my_controller_test.rb
Go MAEDA [Mon, 29 Oct 2018 05:48:31 +0000 (05:48 +0000)]
Remove trailing whitespaces from test/functional/my_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@17610 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoRevert unwanted changes in r17607 (#20081).
Go MAEDA [Mon, 29 Oct 2018 05:00:04 +0000 (05:00 +0000)]
Revert unwanted changes in r17607 (#20081).

git-svn-id: http://svn.redmine.org/redmine/trunk@17609 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFilter time entries after project status (#20081).
Go MAEDA [Mon, 29 Oct 2018 04:05:18 +0000 (04:05 +0000)]
Filter time entries after project status (#20081).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17608 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFilter issues after project status (#20081).
Go MAEDA [Mon, 29 Oct 2018 04:03:52 +0000 (04:03 +0000)]
Filter issues after project status (#20081).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17607 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoReverted r17605 that breaks some tests (#26576, #29730).
Go MAEDA [Mon, 29 Oct 2018 00:18:48 +0000 (00:18 +0000)]
Reverted r17605 that breaks some tests (#26576, #29730).

git-svn-id: http://svn.redmine.org/redmine/trunk@17606 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoPrevious/Next link on repository page disappears when switching to "View differences...
Go MAEDA [Sun, 28 Oct 2018 11:59:29 +0000 (11:59 +0000)]
Previous/Next link on repository page disappears when switching to "View differences" tab (#26576, #29730).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17605 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years ago\f or \v character in Textile markup may cause RegexpError exception (#29756).
Go MAEDA [Sun, 28 Oct 2018 11:01:54 +0000 (11:01 +0000)]
\f or \v character in Textile markup may cause RegexpError exception (#29756).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17603 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoUpdate locales (#29781).
Go MAEDA [Sun, 28 Oct 2018 06:03:56 +0000 (06:03 +0000)]
Update locales (#29781).

git-svn-id: http://svn.redmine.org/redmine/trunk@17602 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoHandles the case when an expired token is in the users session (#29781).
Go MAEDA [Sun, 28 Oct 2018 05:59:11 +0000 (05:59 +0000)]
Handles the case when an expired token is in the users session (#29781).

Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@17601 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFix that MyHelper::render_activity_block is not timezone aware (#2471, #29816).
Go MAEDA [Sat, 20 Oct 2018 23:43:25 +0000 (23:43 +0000)]
Fix that MyHelper::render_activity_block is not timezone aware (#2471, #29816).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17600 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoAdd missing enabled_modules fixture to TrackerTest (#29820).
Go MAEDA [Sat, 20 Oct 2018 01:10:20 +0000 (01:10 +0000)]
Add missing enabled_modules fixture to TrackerTest (#29820).

Patch by Gilad Shanan.

git-svn-id: http://svn.redmine.org/redmine/trunk@17599 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoBulgarian translation update (#29779).
Go MAEDA [Tue, 16 Oct 2018 21:50:39 +0000 (21:50 +0000)]
Bulgarian translation update (#29779).

Patch by Ivan Cenov.

git-svn-id: http://svn.redmine.org/redmine/trunk@17598 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoRails 5: Update INSTALL doc: s/WEBrick/Puma/ (#29772).
Go MAEDA [Tue, 16 Oct 2018 05:51:33 +0000 (05:51 +0000)]
Rails 5: Update INSTALL doc: s/WEBrick/Puma/ (#29772).

git-svn-id: http://svn.redmine.org/redmine/trunk@17597 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoEnsure that vendor-defined characters in ISO-2022-JP email subject don't break issue...
Go MAEDA [Mon, 15 Oct 2018 10:00:18 +0000 (10:00 +0000)]
Ensure that vendor-defined characters in ISO-2022-JP email subject don't break issue's subject (#29442).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17596 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoUpdate mail gem (~> 2.7.1) (#29443).
Go MAEDA [Mon, 15 Oct 2018 08:00:11 +0000 (08:00 +0000)]
Update mail gem (~> 2.7.1) (#29443).

git-svn-id: http://svn.redmine.org/redmine/trunk@17595 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFix broken tests due to r17593 (#29739).
Go MAEDA [Thu, 11 Oct 2018 16:14:37 +0000 (16:14 +0000)]
Fix broken tests due to r17593 (#29739).

git-svn-id: http://svn.redmine.org/redmine/trunk@17594 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoChange general_lang_name for zh and zh-TW to "Chinese/Simplified" and "Chinese/Tradit...
Go MAEDA [Thu, 11 Oct 2018 04:07:35 +0000 (04:07 +0000)]
Change general_lang_name for zh and zh-TW to "Chinese/Simplified" and "Chinese/Traditional" (#29739).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17593 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years ago#last_email already asserts that mail is not nil.
Jean-Philippe Lang [Wed, 10 Oct 2018 19:06:21 +0000 (19:06 +0000)]
#last_email already asserts that mail is not nil.

git-svn-id: http://svn.redmine.org/redmine/trunk@17592 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoRemoves method_missing override (#26791).
Jean-Philippe Lang [Wed, 10 Oct 2018 19:04:25 +0000 (19:04 +0000)]
Removes method_missing override (#26791).

git-svn-id: http://svn.redmine.org/redmine/trunk@17591 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoReplaces remaining #deliver with #deliver_later (#26791).
Jean-Philippe Lang [Wed, 10 Oct 2018 18:45:34 +0000 (18:45 +0000)]
Replaces remaining #deliver with #deliver_later (#26791).

git-svn-id: http://svn.redmine.org/redmine/trunk@17590 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoJournal must be saved.
Jean-Philippe Lang [Wed, 10 Oct 2018 18:41:12 +0000 (18:41 +0000)]
Journal must be saved.

git-svn-id: http://svn.redmine.org/redmine/trunk@17589 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoSend emails asynchronously (#26791).
Jean-Philippe Lang [Wed, 10 Oct 2018 17:13:09 +0000 (17:13 +0000)]
Send emails asynchronously (#26791).

Custom async_* delivery methods are removed in favor of ActiveJob (Async by default).

git-svn-id: http://svn.redmine.org/redmine/trunk@17588 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFixed that test_email raises an error with #deliver_later (#26791).
Jean-Philippe Lang [Sat, 6 Oct 2018 16:07:45 +0000 (16:07 +0000)]
Fixed that test_email raises an error with #deliver_later (#26791).

git-svn-id: http://svn.redmine.org/redmine/trunk@17587 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoUse find_by instead of where.first to remove unnecessary sorting (#26747).
Go MAEDA [Sat, 6 Oct 2018 16:03:26 +0000 (16:03 +0000)]
Use find_by instead of where.first to remove unnecessary sorting (#26747).

Patch by  Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17586 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoEnsure that ActiveRecord::Base objects are fully serialized for mail sending (#26791).
Jean-Philippe Lang [Sat, 6 Oct 2018 13:10:22 +0000 (13:10 +0000)]
Ensure that ActiveRecord::Base objects are fully serialized for mail sending (#26791).

Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@17585 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoCleanup: Remove Issue#each_notification and Journal#each_notification (#26791).
Jean-Philippe Lang [Sat, 6 Oct 2018 13:09:38 +0000 (13:09 +0000)]
Cleanup: Remove Issue#each_notification and Journal#each_notification (#26791).

Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@17584 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoSend individual emails for each mail recipient (#26791).
Jean-Philippe Lang [Sat, 6 Oct 2018 13:08:52 +0000 (13:08 +0000)]
Send individual emails for each mail recipient (#26791).

We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.

We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:

We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.

By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.

Patch by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81

6 years agoFixed that textarea may overflow.
Jean-Philippe Lang [Sat, 6 Oct 2018 11:17:35 +0000 (11:17 +0000)]
Fixed that textarea may overflow.

git-svn-id: http://svn.redmine.org/redmine/trunk@17582 e93f8b46-1217-0410-a6f0-8f06a7374b81