Fix existing test and add a specific one for the new case

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Always try and show pre rendered preview

Currently if the following situation happens

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets a 404 error when preview exists
(Mime checked before preview)

This happens more often with documents, or video as the commands are not
native PHP, they require a binary on the server.

After the fix the following would happen

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets preview which has been generated
(Mime checked after preview)

This would also allow offline generation (for example a docker image
containing the extra binaries), allowing a reduction in attack surface
of the instance serving the preview data.

Signed-off-by: Scott Dutton <scott@exussum.co.uk>

Merge pull request #22128 from nextcloud/bugfix/noid/cleanup-chunks-on-failure

Delete chunks if the move on an upload failed

Return proper status when file didn't exist before

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #22235 from nextcloud/fix/22217/fix-naming-of-app-config-option

Fix name of app config option to properly reflect what it does

Fix name of app config option to properly reflect what it does

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #22229 from nextcloud/bugfix/noid/dashboard-outdated-bundles

Bump outdated dashboard bundles

Merge pull request #22202 from nextcloud/enh/noid/cleanup-servercontainer

Use autowiring where possible in server container

Bump outdated dashboard bundles

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #21788 from nextcloud/debt/noid/unused-method

Remove unused method uploadFile

Merge pull request #22205 from nextcloud/activity-settings-cleanup

merge file activity settings into a single 'favorite changed' item

Remove unused method uploadFile

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Add @deprecated labels for server DI containter aliases

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21344 from nextcloud/fix/twofactor-cleanup-event

Emit an event for every disabled 2FA provider during cleanup

Use registerDeprecatedAlias for non-namespaced aliases

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Use autowiring where possible in server container

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

[tx-robot] updated from transifex

merge file activity settings into a single 'favorite changed' item

Signed-off-by: Robin Appelman <robin@icewind.nl>

move share notifcation settings to files group

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #22206 from nextcloud/enh/noid/tests-recent-contact-mapper

Add some tests for RecentContactMapper

Merge pull request #22217 from nextcloud/enh/noid/disable-admin-changed-email-appconfig

Add app config option to disable "Email was changed by admin" email

Merge pull request #22199 from nextcloud/techdebt/noid/PHPUnit_Framework_MockObject_MockObject

Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to …

Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add app config option to disable "Email was changed by admin" email

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add some tests for RecentContactMapper

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #22211 from nextcloud/fix/noid/rm-useless-log

remove logging message carrying no valuable information

remove logging message carrying no valuable information

the exception caught is not an error, but due to valid configuration and
code flow is expecting this. For an admin it is confusing, and it carries
no information worth for debugging.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #22196 from nextcloud/enh/sse/do_not_concatenate_ints

SSE enhancement of file signature

Adjust chunking test for non-existing target node

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Delete chunks if the move on an upload failed

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

Merge pull request #21559 from nextcloud/fix/noid/ldap-group-shortcut-ad

shortcut in reading nested group members when IN_CHAIN is available

Merge pull request #22162 from nextcloud/enh/noid/password-generator-sharebymail

ShareByMail: Migrate to GenerateSecurePasswordEvent

Generate password by password_policy app

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #22143 from nextcloud/design/dashboard-design

Dashboard design enhancements

SSE enhancement

Do not blind concatenate ints. Lets add a _ between them. So that we can
distrinquis them properly

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

do not flip available state to unavailable, allow empty results

- the detection relies that the first, requested result is not empty
- it might be empty though – groups without members
- protect switching from available to unavailable
  - switching the other way around was also not envisaged either

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

LDAP: shortcut in reading nested group members when IN_CHAIN is available

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Dashboard: Add photo credit

Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>

Merge pull request #22151 from nextcloud/dependabot/npm_and_yarn/webpack-merge-5.1.1

Bump webpack-merge from 5.0.9 to 5.1.1

Merge pull request #22190 from nextcloud/fix/noid/log-rotate-size

Fix default log_rotate_size in config.sample.php

Fix default log_rotate_size in config.sample.php

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #22117 from nextcloud/activity-settings-grouping

allow grouping of activity settings

Merge pull request #21775 from nextcloud/bugfix/noid/transfer-object-storage

Do not exit if available space cannot be determined on file transfer

Dashboard: Fix wording issue on greetings

Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>

Merge pull request #22148 from nextcloud/dependabot/npm_and_yarn/bootstrap-4.5.2

Bump bootstrap from 4.5.0 to 4.5.2

Merge pull request #22176 from nextcloud/debt/noid/table-render-too-many-arguments

Remove unexpected argument

Merge pull request #22167 from nextcloud/debt/noid/coverage-filter

Exclude apps/*/tests for coverage calculation

Merge pull request #22175 from nextcloud/fix/noid/warning-continue-break

use break not continue in switch to avoid warning

Merge pull request #22169 from nextcloud/enh/noid/prefer-typed-events

Prefer typed event over string based ones

Use constant instead of magic number

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Do not exit if available space cannot be determined on file transfer

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Dynamically generate background image url

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

Remove unexpected argument

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Exclude apps/files_external/3rdparty again

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Rename Core/ to core/

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

use break not continue in switch to avoid warning

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Prefer typed event over string based ones

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #22159 from nextcloud/enh/22014/generate-passwords-policy

Generate password on addUser by password_policy app

Merge pull request #22168 from nextcloud/enh/noid/phpdoc-for-events

Add PHP doc for events

Add PHP doc for events

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Exclude apps/*/tests for coverage calculation

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Bump bootstrap from 4.5.0 to 4.5.2

Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.5.0 to 4.5.2.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](https://github.com/twbs/bootstrap/compare/v4.5.0...v4.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Bump webpack-merge from 5.0.9 to 5.1.1

Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 5.0.9 to 5.1.1.
- [Release notes](https://github.com/survivejs/webpack-merge/releases)
- [Changelog](https://github.com/survivejs/webpack-merge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/survivejs/webpack-merge/compare/v5.0.9...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #22149 from nextcloud/dependabot/npm_and_yarn/babel/core-7.11.1

Bump @babel/core from 7.11.0 to 7.11.1

Merge pull request #22146 from nextcloud/dependabot/npm_and_yarn/webpack-node-externals-2.5.1

Bump webpack-node-externals from 2.5.0 to 2.5.1

Merge pull request #22145 from nextcloud/dependabot/npm_and_yarn/sass-loader-9.0.3

Bump sass-loader from 9.0.2 to 9.0.3

[tx-robot] updated from transifex

Generate password on addUser by password_policy app

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

[tx-robot] updated from transifex

Bump @babel/core from 7.11.0 to 7.11.1

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.11.0 to 7.11.1.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.11.1/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump webpack-node-externals from 2.5.0 to 2.5.1

Bumps [webpack-node-externals](https://github.com/liady/webpack-node-externals) from 2.5.0 to 2.5.1.
- [Release notes](https://github.com/liady/webpack-node-externals/releases)
- [Commits](https://github.com/liady/webpack-node-externals/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump sass-loader from 9.0.2 to 9.0.3

Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 9.0.2 to 9.0.3.
- [Release notes](https://github.com/webpack-contrib/sass-loader/releases)
- [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/sass-loader/compare/v9.0.2...v9.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Dashboard: Fix dark mode, add background

Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>

Merge pull request #16737 from tofuSCHNITZEL/feature-zimbraldap

new Group-Member association attribute (zimbraMailForwardingAddress)

added "zimbraMailForwardingAddress" as a Group-Member association attribute to enable the use of Zimbra Distribution Lists as groups in nextcloud when connecting to a zimbra LDAP

Signed-off-by: Tobias Perschon <tobias@perschon.at>
fix cs:check

Signed-off-by: Tobias Perschon <tobias@perschon.at>
Update apps/user_ldap/lib/Group_LDAP.php

Co-authored-by: blizzz <blizzz@arthur-schiwon.de>
Signed-off-by: Tobias Perschon <tobias@perschon.at>

Merge pull request #22004 from nextcloud/enh/noid/setup-checks-php

Add setup checks for php default charset and output buffering.

Dashboard: add background image, improve panel design

Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>

Merge pull request #21738 from nextcloud/techdebt/14552/migrate-OC_Group-post_removeFromGroup

Migrate OC_Group post_removeFromGroup hook to actual event object

Add proper deprecation message

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Change const/let to var for PhantomJS

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Dashboard: remove header fade

Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>

Merge pull request #22139 from nextcloud/fix/noid/check-for-preview-multibucket-fallback-as-second-step

Check previews in multibucket fallback folder as the last step and not as first step

Dashboard: Remove icons from greeting

Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>

Merge pull request #20741 from nextcloud/enh/appstore/unstable

Allow to update to nightly

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Merge pull request #21954 from nextcloud/techdebt/noid/bootstrap-files_trashbin

Use IBootstrap for the files_trashbin app

Merge pull request #21037 from nextcloud/login-credentails-save

Only save login credentials in database once there is an external storage that needs it

Merge pull request #22133 from nextcloud/boot-app-once

only boot apps once

Merge pull request #22135 from nextcloud/enh/noid/occ-preview-repair

Add occ preview:migrate to migrate previews from the old flat structure to a subfolder structure

Merge pull request #22137 from nextcloud/enh/noid/file-entity-icon

File entity to implement IIcon

only boot apps once

in some cases `loadApp` is called more then once which is currently causing apps to be "booted" multiple times which can lead to unexepected behaviour with things like registering hooks

Signed-off-by: Robin Appelman <robin@icewind.nl>

Use array_filter instead

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add tests for occ preview:migrate - initial check for empty directories

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Check previews in multibucket fallback folder as the last step and not as first step

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #22063 from nextcloud/enh/22033/multibucket-appdata-previews

Distribute preview folders in appdata in multibucket setup to multiple buckets

[tx-robot] updated from transifex

File entity to implement IIcon

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Add config option to enable multibucket preview distribution

Signed-off-by: Morris Jobke <hey@morrisjobke.de>