]> source.dussan.org Git - sonarqube.git/log
sonarqube.git
13 years agoSONAR-2327, SONAR-2382 Refactor code
Fabrice Bellingard [Fri, 29 Apr 2011 10:26:47 +0000 (12:26 +0200)]
SONAR-2327, SONAR-2382 Refactor code

Purpose: review service and web service use the same DB request method

13 years agoUse parameter target instead of deprecated tasks for maven-antrun-plugin
Evgeny Mandrikov [Fri, 29 Apr 2011 10:14:39 +0000 (14:14 +0400)]
Use parameter target instead of deprecated tasks for maven-antrun-plugin

13 years agoSlightly improve fix bug of violation tracking when past violation has no checksum.
Freddy Mallet [Fri, 29 Apr 2011 09:14:42 +0000 (11:14 +0200)]
Slightly improve fix bug of violation tracking when past violation has no checksum.

13 years agoFix bug of violation tracking. NPE when past violation has no checksum.
simonbrandhof [Fri, 29 Apr 2011 06:19:00 +0000 (08:19 +0200)]
Fix bug of violation tracking. NPE when past violation has no checksum.

13 years agoSONAR-2261 Exclusion patterns must be trimmed
Evgeny Mandrikov [Thu, 28 Apr 2011 14:46:35 +0000 (18:46 +0400)]
SONAR-2261 Exclusion patterns must be trimmed

Trim them on Java and Ruby side.

13 years agoSONAR-2321 Fix test for Windows
Evgeny Mandrikov [Thu, 28 Apr 2011 17:55:41 +0000 (21:55 +0400)]
SONAR-2321 Fix test for Windows

13 years agoSONAR-2321 Cobertura plugin must not search for XML reports when Cobertura has not...
Evgeny Mandrikov [Thu, 28 Apr 2011 15:01:03 +0000 (19:01 +0400)]
SONAR-2321 Cobertura plugin must not search for XML reports when Cobertura has not been executed

13 years agoSONAR-2382 Create a new "reviews" web service API
Fabrice Bellingard [Thu, 28 Apr 2011 16:47:52 +0000 (18:47 +0200)]
SONAR-2382 Create a new "reviews" web service API

13 years agoSONAR-2327 Improve rendering for violations when source code is missing
Fabrice Bellingard [Thu, 28 Apr 2011 14:38:09 +0000 (16:38 +0200)]
SONAR-2327 Improve rendering for violations when source code is missing

13 years agoImprove display of resource viewers on projects and directories.
simonbrandhof [Thu, 28 Apr 2011 14:09:26 +0000 (16:09 +0200)]
Improve display of resource viewers on projects and directories.

SONAR-2338 Unable to drilldown by dependency metrics from sub-project

SONAR-2201 Display project violations

13 years agoExclude sonar-testing-harness from analysis. It's used for unit tests.
simonbrandhof [Thu, 28 Apr 2011 12:13:46 +0000 (14:13 +0200)]
Exclude sonar-testing-harness from analysis. It's used for unit tests.

13 years agoDefine new constants in DecoratorBarriers
simonbrandhof [Thu, 28 Apr 2011 10:55:50 +0000 (12:55 +0200)]
Define new constants in DecoratorBarriers

START_VIOLATION_TRACKING and END_OF_VIOLATION_TRACKING are used to benefit from tracking data of Violation :

- Violation#isSwitchedOff()
- Violation#getCreatedAt()

More information in Javadoc.

13 years agoSONAR-2381 The "violations" web service API must return violations decorated with...
Fabrice Bellingard [Thu, 28 Apr 2011 14:09:04 +0000 (16:09 +0200)]
SONAR-2381 The "violations" web service API must return violations decorated with review

13 years agoSONAR-1973, SONAR-2327 Fix issues based on Evgeny's feedback
Fabrice Bellingard [Thu, 28 Apr 2011 13:14:19 +0000 (15:14 +0200)]
SONAR-1973, SONAR-2327 Fix issues based on Evgeny's feedback

13 years agoSONAR-1973, SONAR-2327 Fix issues based on Freddy's feedback
Fabrice Bellingard [Thu, 28 Apr 2011 08:00:21 +0000 (10:00 +0200)]
SONAR-1973, SONAR-2327 Fix issues based on Freddy's feedback

13 years agoSONAR-2382 Create a new "reviews" web service API
Fabrice Bellingard [Thu, 28 Apr 2011 06:50:54 +0000 (08:50 +0200)]
SONAR-2382 Create a new "reviews" web service API

13 years agoSONAR-2381 Improve the violations WS decorated with reviews
Fabrice Bellingard [Wed, 27 Apr 2011 12:25:18 +0000 (14:25 +0200)]
SONAR-2381 Improve the violations WS decorated with reviews

13 years agoFix NPE
Evgeny Mandrikov [Thu, 28 Apr 2011 13:14:29 +0000 (17:14 +0400)]
Fix NPE

13 years agoForce creation of project workDir
Evgeny Mandrikov [Thu, 28 Apr 2011 10:34:51 +0000 (14:34 +0400)]
Force creation of project workDir

13 years agoSet project description to empty string if property was not specified
Evgeny Mandrikov [Thu, 28 Apr 2011 08:57:16 +0000 (12:57 +0400)]
Set project description to empty string if property was not specified

13 years agoMove derby logs generated during unit tests to target/
simonbrandhof [Thu, 28 Apr 2011 09:59:48 +0000 (11:59 +0200)]
Move derby logs generated during unit tests to target/

13 years agoIgnore plugins/sonar-core-plugin/derby.log generated during unit tests
simonbrandhof [Thu, 28 Apr 2011 09:32:29 +0000 (11:32 +0200)]
Ignore plugins/sonar-core-plugin/derby.log generated during unit tests

13 years agoRemove System.out.println
Evgeny Mandrikov [Thu, 28 Apr 2011 09:00:18 +0000 (13:00 +0400)]
Remove System.out.println

13 years agoFix loading of locale in charts
simonbrandhof [Wed, 27 Apr 2011 23:23:16 +0000 (01:23 +0200)]
Fix loading of locale in charts

13 years agoIncrease timeout of CommandExecutorTest for slow boxes
simonbrandhof [Wed, 27 Apr 2011 23:22:45 +0000 (01:22 +0200)]
Increase timeout of CommandExecutorTest for slow boxes

13 years agoSONAR-2202 Calculate variations on quality model measures
simonbrandhof [Wed, 27 Apr 2011 23:22:08 +0000 (01:22 +0200)]
SONAR-2202 Calculate variations on quality model measures

13 years agoSONAR-2384 append target='_blank' when building an hyperlink
Freddy Mallet [Wed, 27 Apr 2011 21:58:01 +0000 (23:58 +0200)]
SONAR-2384 append target='_blank' when building an hyperlink

13 years agoFix scheduling of ViolationDecorator
simonbrandhof [Wed, 27 Apr 2011 21:41:28 +0000 (23:41 +0200)]
Fix scheduling of ViolationDecorator

ViolationPersisterDecorator must be executed before computing measures on violations, so the flag switched_off is correctly loaded from database.

13 years agoFix some ruby warnings (don't put space before argument parentheses)
simonbrandhof [Wed, 27 Apr 2011 21:40:32 +0000 (23:40 +0200)]
Fix some ruby warnings (don't put space before argument parentheses)

13 years agoSONAR-2386 Web service should return lineId for violation only if value exists
Evgeny Mandrikov [Wed, 27 Apr 2011 21:15:01 +0000 (01:15 +0400)]
SONAR-2386 Web service should return lineId for violation only if value exists

13 years agoFix vertical alignment of severity icons
simonbrandhof [Wed, 27 Apr 2011 21:01:21 +0000 (23:01 +0200)]
Fix vertical alignment of severity icons

13 years agoAdd header to comparison of quality profiles
simonbrandhof [Wed, 27 Apr 2011 21:00:43 +0000 (23:00 +0200)]
Add header to comparison of quality profiles

13 years agoEnsure that cost to fix violation cannot be set to negative or NaN value
Evgeny Mandrikov [Wed, 27 Apr 2011 19:59:31 +0000 (23:59 +0400)]
Ensure that cost to fix violation cannot be set to negative or NaN value

13 years agoMerge branch 'master' of github.com:SonarSource/sonar
Freddy Mallet [Wed, 27 Apr 2011 19:41:14 +0000 (21:41 +0200)]
Merge branch 'master' of github.com:SonarSource/sonar

13 years agoSONAR-2299 Show Hibernate SQL only if debug logging level enabled, but not info level
Evgeny Mandrikov [Wed, 27 Apr 2011 19:23:24 +0000 (23:23 +0400)]
SONAR-2299 Show Hibernate SQL only if debug logging level enabled, but not info level

13 years agoSONAR-2384 use backtick instead of simple quote in the HtmlCodeChannel
Freddy Mallet [Wed, 27 Apr 2011 19:40:15 +0000 (21:40 +0200)]
SONAR-2384 use backtick instead of simple quote in the HtmlCodeChannel

13 years agoSONAR-2386 Define contract for lineId in Violation
Evgeny Mandrikov [Wed, 27 Apr 2011 16:29:11 +0000 (20:29 +0400)]
SONAR-2386 Define contract for lineId in Violation

Value can be null or greater than zero, so setter must log warning if
not null and less than 1. It will throw an exception in future releases.

13 years agoSONAR-2266 ProjectFileSystem should return only existing source and test directories
Evgeny Mandrikov [Wed, 27 Apr 2011 11:39:59 +0000 (15:39 +0400)]
SONAR-2266 ProjectFileSystem should return only existing source and test directories

13 years agoFix violations
Evgeny Mandrikov [Wed, 27 Apr 2011 09:11:11 +0000 (13:11 +0400)]
Fix violations

13 years agoSONAR-2369 User list is not correctly sorted in the Groups page
simonbrandhof [Wed, 27 Apr 2011 10:41:44 +0000 (12:41 +0200)]
SONAR-2369 User list is not correctly sorted in the Groups page

13 years agoSONAR-2323 Remove logs specific to Maven
simonbrandhof [Wed, 27 Apr 2011 09:55:16 +0000 (11:55 +0200)]
SONAR-2323 Remove logs specific to Maven

13 years agoWrite valid HTML : a tag is badly closed
simonbrandhof [Wed, 27 Apr 2011 09:48:01 +0000 (11:48 +0200)]
Write valid HTML : a tag is badly closed

13 years agoSONAR-2179 the 'bulk change' option of quality profiles fail when there are too many...
simonbrandhof [Wed, 27 Apr 2011 09:45:01 +0000 (11:45 +0200)]
SONAR-2179 the 'bulk change' option of quality profiles fail when there are too many selected rules

13 years agoSONAR-2327 Provide a new "Reviews" service
Fabrice Bellingard [Wed, 27 Apr 2011 09:06:47 +0000 (11:06 +0200)]
SONAR-2327 Provide a new "Reviews" service

13 years agoSONAR-2327 Provide a new "Reviews" service
Fabrice Bellingard [Wed, 27 Apr 2011 06:59:49 +0000 (08:59 +0200)]
SONAR-2327 Provide a new "Reviews" service

13 years agoSONAR-2382 Highlight selected line in source panel
simonbrandhof [Wed, 27 Apr 2011 07:22:40 +0000 (09:22 +0200)]
SONAR-2382 Highlight selected line in source panel

13 years agoSONAR-2382 Display source in review detail
simonbrandhof [Wed, 27 Apr 2011 06:50:14 +0000 (08:50 +0200)]
SONAR-2382 Display source in review detail

13 years agoSONAR-2298 Rename MavenProjectBuilder to ProjectBuilder
Evgeny Mandrikov [Tue, 26 Apr 2011 19:48:49 +0000 (23:48 +0400)]
SONAR-2298 Rename MavenProjectBuilder to ProjectBuilder

13 years agoSONAR-2327 Provide a new "Reviews" service
Fabrice Bellingard [Tue, 26 Apr 2011 17:09:32 +0000 (19:09 +0200)]
SONAR-2327 Provide a new "Reviews" service

13 years agoSONAR-1973 Rework action link positions
Fabrice Bellingard [Tue, 26 Apr 2011 13:37:57 +0000 (15:37 +0200)]
SONAR-1973 Rework action link positions

13 years agoFix rendering of age (variable {count} not interpreted)
simonbrandhof [Tue, 26 Apr 2011 15:32:27 +0000 (17:32 +0200)]
Fix rendering of age (variable {count} not interpreted)

13 years agoMerge branch 'master' of github.com:SonarSource/sonar
Freddy Mallet [Tue, 26 Apr 2011 14:40:16 +0000 (16:40 +0200)]
Merge branch 'master' of github.com:SonarSource/sonar

13 years agoDo not feed RULE_FAILURES.PERMANENT_ID when rendering violations
simonbrandhof [Tue, 26 Apr 2011 14:22:27 +0000 (16:22 +0200)]
Do not feed RULE_FAILURES.PERMANENT_ID when rendering violations

13 years agoSONAR-2384 Fix a bug on HtmlListChannel which was due to CodeBuffer.length() method...
Freddy Mallet [Tue, 26 Apr 2011 14:21:59 +0000 (16:21 +0200)]
SONAR-2384 Fix a bug on HtmlListChannel which was due to CodeBuffer.length() method and make the HtmlEmphasisChannel handle sentence

13 years agoSONAR-2382 Complete review web service
simonbrandhof [Tue, 26 Apr 2011 13:24:57 +0000 (15:24 +0200)]
SONAR-2382 Complete review web service

13 years agoSONAR-1973 Fix bug in DB request
Fabrice Bellingard [Tue, 26 Apr 2011 12:59:17 +0000 (14:59 +0200)]
SONAR-1973 Fix bug in DB request

13 years agoSONAR-2327 add help on markdown
simonbrandhof [Tue, 26 Apr 2011 10:05:51 +0000 (12:05 +0200)]
SONAR-2327 add help on markdown

13 years agoSONAR-2327 split actions for resource viewer and reviews page
simonbrandhof [Mon, 25 Apr 2011 21:12:50 +0000 (23:12 +0200)]
SONAR-2327 split actions for resource viewer and reviews page

13 years agoSONAR-2298 Add support for multi-modules for non-Maven projects
Evgeny Mandrikov [Fri, 8 Apr 2011 22:19:28 +0000 (02:19 +0400)]
SONAR-2298 Add support for multi-modules for non-Maven projects

* Use ProjectDefinition in ProjectTree instead of MavenProject

* Allow to specify extensions for project's container via
  ProjectDefinition, so MavenProject not passed directly to batch in mojos

* ProjectDefinition should store all information in properties

* Replace DefaultProjectFileSystem by DefaultProjectFileSystem2, which
  works not only for Maven projects

* Add DefaultProjectClasspath, which works not only for Maven projects

* Enable ProjectLinksSensor only for Maven

13 years agoSONAR-2371 UnitTestDecorator should not save anything if tests measure already exists
Evgeny Mandrikov [Sun, 24 Apr 2011 03:07:02 +0000 (07:07 +0400)]
SONAR-2371 UnitTestDecorator should not save anything if tests measure already exists

13 years agoSonar Markdown : Fix typo in the javadoc (Thanks Evgeny)
Freddy Mallet [Sun, 24 Apr 2011 09:00:36 +0000 (11:00 +0200)]
Sonar Markdown : Fix typo in the javadoc (Thanks Evgeny)

13 years agoSONAR-2358 Add unit test
Evgeny Mandrikov [Sun, 24 Apr 2011 02:51:32 +0000 (06:51 +0400)]
SONAR-2358 Add unit test

13 years agoSONAR-2384 Add support for html list and fix javadoc by escaping html tags
Freddy Mallet [Sat, 23 Apr 2011 22:42:00 +0000 (00:42 +0200)]
SONAR-2384 Add support for html list and fix javadoc by escaping html tags

13 years agoAdd some javadoc to the Sonar Markdown module
Freddy Mallet [Sat, 23 Apr 2011 21:34:08 +0000 (23:34 +0200)]
Add some javadoc to the Sonar Markdown module

13 years agoSonar Channel : Add license header to package-info.java file
Freddy Mallet [Sat, 23 Apr 2011 21:17:57 +0000 (23:17 +0200)]
Sonar Channel : Add license header to package-info.java file

13 years agoAdd some javadoc to the Sonar Channel module
Freddy Mallet [Sat, 23 Apr 2011 21:11:25 +0000 (23:11 +0200)]
Add some javadoc to the Sonar Channel module

13 years agoMerge branch 'master' of github.com:SonarSource/sonar
Freddy Mallet [Sat, 23 Apr 2011 19:32:34 +0000 (21:32 +0200)]
Merge branch 'master' of github.com:SonarSource/sonar

13 years agoSONAR-2358 Reapply patch 'Mechanism to calculate checksums for violations is unstable'
Freddy Mallet [Sat, 23 Apr 2011 19:32:25 +0000 (21:32 +0200)]
SONAR-2358 Reapply patch 'Mechanism to calculate checksums for violations is unstable'

13 years agoSONAR-2384 Support markdown in review comments
simonbrandhof [Sat, 23 Apr 2011 16:18:10 +0000 (18:18 +0200)]
SONAR-2384 Support markdown in review comments

13 years agoSONAR-2384 Add a new HtmlCodeChannel to transform ''printf()'' into <code>printf...
Freddy Mallet [Sat, 23 Apr 2011 13:33:33 +0000 (15:33 +0200)]
SONAR-2384 Add a new HtmlCodeChannel to transform ''printf()'' into <code>printf()</code>

13 years agoSONAR-2384 Complete the support of emphasis
simonbrandhof [Sat, 23 Apr 2011 06:23:52 +0000 (08:23 +0200)]
SONAR-2384 Complete the support of emphasis

13 years agoSONAR-2384 Fix CI failure by updating the header of the RegexChannel file
Freddy Mallet [Fri, 22 Apr 2011 22:59:38 +0000 (00:59 +0200)]
SONAR-2384 Fix CI failure by updating the header of the RegexChannel file

13 years agoSONAR-2384 First implementation : Create a markdown dedicated to Sonar needs
Freddy Mallet [Fri, 22 Apr 2011 22:47:42 +0000 (00:47 +0200)]
SONAR-2384 First implementation : Create a markdown dedicated to Sonar needs

13 years agoSONAR-2384 First implementation : Create a markdown dedicated to Sonar needs
Freddy Mallet [Fri, 22 Apr 2011 22:46:05 +0000 (00:46 +0200)]
SONAR-2384 First implementation : Create a markdown dedicated to Sonar needs

13 years agoSonar Channel : Slightly improve the readability of the source code in charge to...
Freddy Mallet [Fri, 22 Apr 2011 20:56:10 +0000 (22:56 +0200)]
Sonar Channel : Slightly improve the readability of the source code in charge to increment the line number

13 years agoSONAR-2344 Improve the algorithm in charge to define/update the creation date of...
Freddy Mallet [Fri, 22 Apr 2011 20:53:26 +0000 (22:53 +0200)]
SONAR-2344 Improve the algorithm in charge to define/update the creation date of each violation

13 years agoSONAR-2327 improve CSS
simonbrandhof [Fri, 22 Apr 2011 15:27:28 +0000 (17:27 +0200)]
SONAR-2327 improve CSS

13 years agoTests should be independent from EOL in resources
Evgeny Mandrikov [Wed, 20 Apr 2011 23:17:53 +0000 (03:17 +0400)]
Tests should be independent from EOL in resources

13 years agoSONAR-2381 temporarily deactivate switch-off property from violations ws
simonbrandhof [Fri, 22 Apr 2011 08:48:25 +0000 (10:48 +0200)]
SONAR-2381 temporarily deactivate switch-off property from violations ws

13 years agoSONAR-2381 The "violations" web service API must return violations
Fabrice Bellingard [Thu, 21 Apr 2011 16:39:08 +0000 (18:39 +0200)]
SONAR-2381 The "violations" web service API must return violations
decorated with review

Ruby controller updated, need now to add the WS client part of it

13 years agoSONAR-2380 The "violations" web service API must not return
Fabrice Bellingard [Thu, 21 Apr 2011 14:56:21 +0000 (16:56 +0200)]
SONAR-2380 The "violations" web service API must not return
"false-positive" violation

Also modified the batch side ViolationQuery class that I created so
that they have the same API.

13 years agoSONAR-2380 The "violations" web service API must not return
Fabrice Bellingard [Thu, 21 Apr 2011 13:17:53 +0000 (15:17 +0200)]
SONAR-2380 The "violations" web service API must not return
"false-positive" violation

13 years agoSONAR-2327 rotate the icon status/open.png
simonbrandhof [Thu, 21 Apr 2011 16:39:25 +0000 (18:39 +0200)]
SONAR-2327 rotate the icon status/open.png

13 years agoSONAR-2327 first step to refactor reviews page
simonbrandhof [Wed, 20 Apr 2011 21:48:39 +0000 (23:48 +0200)]
SONAR-2327 first step to refactor reviews page

SONAR-2327 add link to review

SONAR-2327 render review results in a table

13 years agoMerge remote branch 'upstream/master'
Fabrice Bellingard [Thu, 21 Apr 2011 08:19:37 +0000 (10:19 +0200)]
Merge remote branch 'upstream/master'

13 years agoSONAR-1973 Improve Resource Viewer
Fabrice Bellingard [Thu, 21 Apr 2011 08:18:23 +0000 (10:18 +0200)]
SONAR-1973 Improve Resource Viewer

13 years agoSONAR-2341 Deprecate Project.getPackaging and don't use it in findbugs plugin
Evgeny Mandrikov [Wed, 20 Apr 2011 21:47:18 +0000 (01:47 +0400)]
SONAR-2341 Deprecate Project.getPackaging and don't use it in findbugs plugin

13 years agoIncrease coverage for a new code in UnitTestDecorator
Evgeny Mandrikov [Wed, 20 Apr 2011 21:37:08 +0000 (01:37 +0400)]
Increase coverage for a new code in UnitTestDecorator

13 years agoUpdate some Maven plugins to latest versions for thread safety
Evgeny Mandrikov [Wed, 20 Apr 2011 12:32:41 +0000 (16:32 +0400)]
Update some Maven plugins to latest versions for thread safety

* maven-assembly-plugin 2.2.1
* maven-plugin-plugin 2.7
* maven-antrun-plugin 1.6
* maven-war-plugin 2.1.1

13 years agoSONAR-2379 Fix ClassCastException in DependencyUnmarshaller
Evgeny Mandrikov [Wed, 20 Apr 2011 17:12:40 +0000 (21:12 +0400)]
SONAR-2379 Fix ClassCastException in DependencyUnmarshaller

GwtUtils.getString returns string representation of a numeric field,
so this is a contract in WSUtils.getString and JdkUtils.getString
must not cast Object to String.

13 years agoSONAR-1973 Improve Resource Viewer
Fabrice Bellingard [Wed, 20 Apr 2011 16:49:33 +0000 (18:49 +0200)]
SONAR-1973 Improve Resource Viewer

13 years agoSONAR-2293,SONAR-2282 Re-apply changes, which were lost
Evgeny Mandrikov [Wed, 20 Apr 2011 16:02:36 +0000 (20:02 +0400)]
SONAR-2293,SONAR-2282 Re-apply changes, which were lost

13 years agoSONAR-2347 Add unit test to ReviewsDecorator
Fabrice Bellingard [Wed, 20 Apr 2011 15:07:07 +0000 (17:07 +0200)]
SONAR-2347 Add unit test to ReviewsDecorator

13 years agoSONAR-2378 Fix directory attributes in zip archive
Evgeny Mandrikov [Wed, 20 Apr 2011 13:38:07 +0000 (17:38 +0400)]
SONAR-2378 Fix directory attributes in zip archive

Apply workaround for http://jira.codehaus.org/browse/MASSEMBLY-422
described in comments for http://jira.codehaus.org/browse/MASSEMBLY-449

13 years agoSONAR-2255 the metric 'classes' must not be 0 on unit tests
simonbrandhof [Wed, 20 Apr 2011 13:25:30 +0000 (15:25 +0200)]
SONAR-2255 the metric 'classes' must not be 0 on unit tests

13 years agoSONAR-1973 Add possibility to show only switched-off violations
Fabrice Bellingard [Wed, 20 Apr 2011 13:24:07 +0000 (15:24 +0200)]
SONAR-1973 Add possibility to show only switched-off violations

13 years agoRemove unused file
Evgeny Mandrikov [Wed, 20 Apr 2011 12:03:45 +0000 (16:03 +0400)]
Remove unused file

13 years agoFix crlf
Evgeny Mandrikov [Wed, 20 Apr 2011 09:49:13 +0000 (13:49 +0400)]
Fix crlf

13 years agoFix crlf
Evgeny Mandrikov [Tue, 19 Apr 2011 15:36:14 +0000 (19:36 +0400)]
Fix crlf

13 years agoSONAR-2367 Filter error when a column is on a disabled metric
simonbrandhof [Tue, 19 Apr 2011 13:58:07 +0000 (15:58 +0200)]
SONAR-2367 Filter error when a column is on a disabled metric