]> source.dussan.org Git - jquery-ui.git/log
jquery-ui.git
11 years agoProgressbar: Add link to custom label demo in demo index.
Kris Borchers [Thu, 6 Dec 2012 17:07:25 +0000 (11:07 -0600)]
Progressbar: Add link to custom label demo in demo index.

11 years agoProgressbar: Take min into account when calculating percentage.
Kris Borchers [Thu, 6 Dec 2012 17:07:07 +0000 (11:07 -0600)]
Progressbar: Take min into account when calculating percentage.

11 years agoDatepicker: Run JSHint test in unit tests.
Scott González [Thu, 6 Dec 2012 16:56:56 +0000 (11:56 -0500)]
Datepicker: Run JSHint test in unit tests.

11 years agoProgressbar: Cleanup, byte shaving.
Scott González [Thu, 6 Dec 2012 15:10:07 +0000 (10:10 -0500)]
Progressbar: Cleanup, byte shaving.

11 years agoProgress tests: Cleanup.
Scott González [Thu, 6 Dec 2012 14:50:33 +0000 (09:50 -0500)]
Progress tests: Cleanup.

11 years agoProgressbar: Only remove aria-valuenow for indeterminate progressbars. Added more...
Scott González [Thu, 6 Dec 2012 14:35:41 +0000 (09:35 -0500)]
Progressbar: Only remove aria-valuenow for indeterminate progressbars. Added more accessibility tests.

11 years agoProgressbar: Define defaults for callbacks.
Scott González [Thu, 6 Dec 2012 14:21:25 +0000 (09:21 -0500)]
Progressbar: Define defaults for callbacks.

11 years agoTabs: Decode URIs before comparing. Fixes #8877 - Tabs: isLocal function issue in...
Scott González [Wed, 5 Dec 2012 22:19:14 +0000 (17:19 -0500)]
Tabs: Decode URIs before comparing. Fixes #8877 - Tabs: isLocal function issue in Safari 5.1.7.

11 years agoDialog: Restore inline styles for dimensions/display. Fixes #8119 - Dialog: Destroyin...
Scott González [Wed, 5 Dec 2012 16:53:34 +0000 (11:53 -0500)]
Dialog: Restore inline styles for dimensions/display. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed.

11 years agoDatepicker: Added Norwegian Bokmål and Norwegian Nynorsk locales. Fixes #8886 - Datep...
Bjørn Johansen [Mon, 3 Dec 2012 07:05:06 +0000 (08:05 +0100)]
Datepicker: Added Norwegian Bokmål and Norwegian Nynorsk locales. Fixes #8886 - Datepicker: Add Norwegian Bokmål (nb) and Norwegian Nynorsk (nn) locales.

Signed-off-by: Bjørn Johansen <bjorn.johansen@metronet.no>
11 years agoDatepicker: Added Belarusian locale. Fixes #8885 - Datepicker: Add Belarusian locale.
Pavel Selitskas [Sun, 2 Dec 2012 14:02:39 +0000 (17:02 +0300)]
Datepicker: Added Belarusian locale. Fixes #8885 - Datepicker: Add Belarusian locale.

11 years agoDatepicker: Handle changes to the disabled option. Fixes #8883 - Datepicker: Changing...
Scott González [Wed, 5 Dec 2012 15:38:31 +0000 (10:38 -0500)]
Datepicker: Handle changes to the disabled option. Fixes #8883 - Datepicker: Changing disabled option doesn't work.

11 years agoDialog: Remove width, min-height, height styles on destroy. Fixes #8119 - Dialog...
Scott González [Tue, 4 Dec 2012 15:03:05 +0000 (10:03 -0500)]
Dialog: Remove width, min-height, height styles on destroy. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed.

11 years agoDialog: Remove unnecessary margin on title.
Scott González [Tue, 4 Dec 2012 14:27:57 +0000 (09:27 -0500)]
Dialog: Remove unnecessary margin on title.

11 years agoRevert "Dialog: Cleanup style properties on _destroy. Reenables style check in domEqu...
Scott González [Tue, 4 Dec 2012 14:21:33 +0000 (09:21 -0500)]
Revert "Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers."

This reverts commit d687a1b10d1e176a6a8dd4420f1ea3a890640da0.

11 years agoRevert "Menu: Remove display property on hidden submenus instead of setting display...
Scott González [Tue, 4 Dec 2012 14:21:16 +0000 (09:21 -0500)]
Revert "Menu: Remove display property on hidden submenus instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b)."

This reverts commit 53b940fa27fc50b4663eef77249a9afce4129240.

11 years agoRevert "Tabs: Remove display property on hidden panels instead of setting display...
Scott González [Tue, 4 Dec 2012 14:20:56 +0000 (09:20 -0500)]
Revert "Tabs: Remove display property on hidden panels instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b)."

This reverts commit b9068c1523f39da8a04c799eebc9adc8b83c7279.

11 years agoProgressbar: Custom label demo cleanup
Kris Borchers [Tue, 4 Dec 2012 03:25:55 +0000 (21:25 -0600)]
Progressbar: Custom label demo cleanup

11 years agoDialog: Refactor _createOverlay and _destroyOverlay to use widget methods and properties.
Jörn Zaefferer [Tue, 4 Dec 2012 00:17:00 +0000 (01:17 +0100)]
Dialog: Refactor _createOverlay and _destroyOverlay to use widget methods and properties.

11 years agoDialog: Remove the instance-storing for the overlay, just create one whenever it...
Jörn Zaefferer [Tue, 4 Dec 2012 00:08:34 +0000 (01:08 +0100)]
Dialog: Remove the instance-storing for the overlay, just create one whenever it is needed. Heavily simplifies the code, while the memorly leak should be hardly an issue anymore, since fixed positioning restricts the overlay size to the window dimensions. Fixes #6058 - Dialog overlays are not properly reused when multiple instances of a Dialog exist.

11 years agoTabs: Remove display property on hidden panels instead of setting display:block....
Jörn Zaefferer [Mon, 3 Dec 2012 23:56:14 +0000 (00:56 +0100)]
Tabs: Remove display property on hidden panels instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b).

11 years agoMenu: Remove display property on hidden submenus instead of setting display:block...
Jörn Zaefferer [Mon, 3 Dec 2012 23:49:37 +0000 (00:49 +0100)]
Menu: Remove display property on hidden submenus instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b).

11 years agoDialog: Cleanup style properties on _destroy. Reenables style check in domEqual,...
Jörn Zaefferer [Mon, 3 Dec 2012 23:35:33 +0000 (00:35 +0100)]
Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers.

11 years agoWidget: Don't modify the prototype passed to $.widget(). Fixes #8876 - Calling _super...
Scott González [Mon, 3 Dec 2012 19:18:24 +0000 (14:18 -0500)]
Widget: Don't modify the prototype passed to $.widget(). Fixes #8876 - Calling _super calls wrong inherited widget.

11 years agoWidget tests: Fixed order of actual and expected.
Scott González [Mon, 3 Dec 2012 18:57:28 +0000 (13:57 -0500)]
Widget tests: Fixed order of actual and expected.

11 years agoDialog: Adjust southeast resize handle to not be visible and more closely match other...
Scott González [Mon, 3 Dec 2012 18:09:49 +0000 (13:09 -0500)]
Dialog: Adjust southeast resize handle to not be visible and more closely match other resize handles. Fixes #4575 - Dialog: Scrollbar is difficult to use with overflow content and resize handle.

11 years agoDialog: Restrict title to a single line. Fixes #7773 - Dialog: If titlebar changes... 856/head
Jörn Zaefferer [Sun, 2 Dec 2012 11:50:17 +0000 (12:50 +0100)]
Dialog: Restrict title to a single line. Fixes #7773 - Dialog: If titlebar changes height during resize, button pane positioning changes.

11 years agoResizable: Respect containment for alsoResize option. Fixes #4603 - Resizable: alsoRe...
Scott González [Mon, 3 Dec 2012 15:36:55 +0000 (10:36 -0500)]
Resizable: Respect containment for alsoResize option. Fixes #4603 - Resizable: alsoResize option doesn't work with containment. Fixes #5559 - Dialog: Content grows bigger than widget on resize at document edge.

11 years agoGrunt: Set testswarm/browserSets from JSON file.
Timo Tijhof [Sat, 17 Nov 2012 20:47:23 +0000 (21:47 +0100)]
Grunt: Set testswarm/browserSets from JSON file.

File on jq03.jquery.com is already updated.

11 years agoDialog: Ensure all animations finish and clean up themselve when destroying dialog...
Jörn Zaefferer [Fri, 30 Nov 2012 12:08:56 +0000 (13:08 +0100)]
Dialog: Ensure all animations finish and clean up themselve when destroying dialog. Fixes #5860 - Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM.

11 years agoProgressbar: Add custom label demo.
Kris Borchers [Fri, 30 Nov 2012 04:12:30 +0000 (22:12 -0600)]
Progressbar: Add custom label demo.

11 years agoProgressbar: Create and destroy indeterminate overlay as needed and code cleanup.
Kris Borchers [Fri, 30 Nov 2012 04:12:02 +0000 (22:12 -0600)]
Progressbar: Create and destroy indeterminate overlay as needed and code cleanup.

11 years agoTheme: removed or changed occurrences of zoom. Fixes #7975 - Remove invalid CSS for...
Anika Henke [Thu, 29 Nov 2012 19:26:29 +0000 (19:26 +0000)]
Theme: removed or changed occurrences of zoom. Fixes #7975 - Remove invalid CSS for legacy browsers

Because of overlapping issues, this also reverts most of e77edc60 and fixes it in a different way.

11 years agoButton: fixed inconsistent button styling in most browsers. Fixes #7996 - Button...
Anika Henke [Thu, 29 Nov 2012 17:30:17 +0000 (17:30 +0000)]
Button: fixed inconsistent button styling in most browsers. Fixes #7996 - Button: Inconsistent styling based on markup

11 years agoProgressbar demos: Cleanup.
Scott González [Thu, 29 Nov 2012 17:06:22 +0000 (12:06 -0500)]
Progressbar demos: Cleanup.

11 years agoDialog: Use consistent code for appending to body
Jörn Zaefferer [Thu, 29 Nov 2012 16:40:31 +0000 (17:40 +0100)]
Dialog: Use consistent code for appending to body

11 years agoProgressbar demos: Removed resize demo.
Scott González [Thu, 29 Nov 2012 14:51:04 +0000 (09:51 -0500)]
Progressbar demos: Removed resize demo.

11 years agoProgressbar demos: Removed animated demo.
Scott González [Thu, 29 Nov 2012 14:49:25 +0000 (09:49 -0500)]
Progressbar demos: Removed animated demo.

11 years agoButton tests: Work around a quirk in Opera.
Scott González [Thu, 29 Nov 2012 14:08:48 +0000 (09:08 -0500)]
Button tests: Work around a quirk in Opera.

11 years agoButton tests: simulated clicks aren't perfect in oldIE and Opera
Mike Sherov [Wed, 28 Nov 2012 16:21:52 +0000 (11:21 -0500)]
Button tests: simulated clicks aren't perfect in oldIE and Opera

11 years agoAutocomplete: When appendTo is a jQuery object or a DOM element, don't search against...
Scott González [Wed, 28 Nov 2012 15:33:44 +0000 (10:33 -0500)]
Autocomplete: When appendTo is a jQuery object or a DOM element, don't search against the document. Fixes #8858 - Autocomplete: Fails when appendTo is detached from the DOM.

11 years agoButton: Strange space between buttons in IE 7. Fixed #5253 - Toolbar demo ugly in IE
Pawel Maruszczyk [Tue, 27 Nov 2012 20:37:44 +0000 (21:37 +0100)]
Button: Strange space between buttons in IE 7. Fixed #5253 - Toolbar demo ugly in IE

11 years agoTooltip: Escape the title attribute so that it's treated as text and not HTML. Fixes...
Scott González [Tue, 27 Nov 2012 16:21:33 +0000 (11:21 -0500)]
Tooltip: Escape the title attribute so that it's treated as text and not HTML. Fixes #8861 - Tooltip: XSS vulnerability in default content.

11 years agoAutocomplete demo: Combobox: Encode search term inside tooltips. Fixes #8859 - Autoco...
Scott González [Tue, 27 Nov 2012 15:52:19 +0000 (10:52 -0500)]
Autocomplete demo: Combobox: Encode search term inside tooltips. Fixes #8859 - Autocomplete: XSS in combobox demo.

11 years agoTheme: removed obsolete vendor-specific prefixes. Fixed #8834 - Theme: Remove unneede...
Anika Henke [Tue, 27 Nov 2012 03:10:50 +0000 (03:10 +0000)]
Theme: removed obsolete vendor-specific prefixes. Fixed #8834 - Theme: Remove unneeded vendor prefixing

11 years agoEffects: Use $ instead of jQuery in $.effects.animateClass. Fixes #8860 - Effects...
Viktor Kojouharov [Mon, 26 Nov 2012 16:34:31 +0000 (18:34 +0200)]
Effects: Use $ instead of jQuery in $.effects.animateClass. Fixes #8860 - Effects: Class animation has broken noConflict support.

11 years agoDatepicker: Remove JSHint overrides.
Scott González [Tue, 27 Nov 2012 13:22:21 +0000 (08:22 -0500)]
Datepicker: Remove JSHint overrides.

11 years agoDatepicker: Remove support for setting options via custom attributes.
Scott González [Tue, 27 Nov 2012 03:49:47 +0000 (22:49 -0500)]
Datepicker: Remove support for setting options via custom attributes.

11 years agoButton Tests: move aria-pressed test to correct module
Mike Sherov [Tue, 27 Nov 2012 01:24:31 +0000 (20:24 -0500)]
Button Tests: move aria-pressed test to correct module

11 years agoButton: Let change handler handle display and aria update. Fixed #5518 - Button:...
Fabrício Matté [Tue, 27 Nov 2012 01:14:58 +0000 (20:14 -0500)]
Button: Let change handler handle display and aria update. Fixed #5518 - Button: Incorrect state after double click in Firefox

11 years agoFixed order of authors.
Scott González [Mon, 26 Nov 2012 21:41:26 +0000 (16:41 -0500)]
Fixed order of authors.

11 years agoTabs: Calculate border and padding on tabs container. Fixed #8836: Height overflows...
David Petersen [Mon, 26 Nov 2012 01:02:36 +0000 (19:02 -0600)]
Tabs: Calculate border and padding on tabs container. Fixed #8836: Height overflows parent with heightStyle: 'fill'.

11 years agoDialog: Moved resizable handle test from resizable.
Scott González [Mon, 26 Nov 2012 21:27:18 +0000 (16:27 -0500)]
Dialog: Moved resizable handle test from resizable.

11 years agoAutocomplete demo: Combobox cleanup.
Scott González [Mon, 26 Nov 2012 21:13:21 +0000 (16:13 -0500)]
Autocomplete demo: Combobox cleanup.

11 years agoFix AUTHORS.txt, remove the various duplicate entries - follow-up to 2ca5fbf8
Jörn Zaefferer [Mon, 26 Nov 2012 11:52:54 +0000 (12:52 +0100)]
Fix AUTHORS.txt, remove the various duplicate entries - follow-up to 2ca5fbf8

11 years agoResizable: Modified the default z-index value of resizable handles. Fixed #7960...
TJ VanToll [Sat, 24 Nov 2012 21:23:03 +0000 (16:23 -0500)]
Resizable: Modified the default z-index value of resizable handles.  Fixed #7960 - Dialog: Modal dialogs do not disable resizables on the page.

11 years agoDialog: Add unit test to cover #8789 and #8838.
Kris Borchers [Sun, 25 Nov 2012 05:18:51 +0000 (23:18 -0600)]
Dialog: Add unit test to cover #8789 and #8838.

11 years agoDialog: Extract setting the title into a _title method, use .text() to prevent XSS... 794/head
Jörn Zaefferer [Mon, 26 Nov 2012 09:14:36 +0000 (10:14 +0100)]
Dialog: Extract setting the title into a _title method, use .text() to prevent XSS. Fixes #6016 - Dialog: Title XSS Vulnerability.

11 years agoDialog: Don't focus dialog when mousedown is on close button. Fixes #8838 - Dialog...
Jörn Zaefferer [Mon, 26 Nov 2012 09:08:34 +0000 (10:08 +0100)]
Dialog: Don't focus dialog when mousedown is on close button. Fixes #8838 - Dialog: Close icon does not work in dialog larger than the window in IE.

11 years agoDialog: Update position when size is changed. Fixes #8789 - Dialog does not close...
Kris Borchers [Sun, 25 Nov 2012 05:18:51 +0000 (23:18 -0600)]
Dialog: Update position when size is changed. Fixes #8789 - Dialog does not close for first click on chrome.

11 years agoDialog: Follow-up to c77ca67 - exclude button options from properties to create the...
Jörn Zaefferer [Thu, 22 Nov 2012 09:39:45 +0000 (10:39 +0100)]
Dialog: Follow-up to c77ca67 - exclude button options from properties to create the button.

11 years agoDialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position option.
Jörn Zaefferer [Wed, 21 Nov 2012 15:33:46 +0000 (16:33 +0100)]
Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position option.

11 years agoDialog: Update focus-tabbable test with a timer workaround to get IE8 to pass.
Jörn Zaefferer [Sat, 17 Nov 2012 17:04:10 +0000 (18:04 +0100)]
Dialog: Update focus-tabbable test with a timer workaround to get IE8 to pass.

11 years agoDialog: Exclude deprecated units from phantomjs
Jörn Zaefferer [Sat, 17 Nov 2012 14:57:26 +0000 (15:57 +0100)]
Dialog: Exclude deprecated units from phantomjs

11 years agoDialog: Add missing unit test for aria-describedby attribute
Jörn Zaefferer [Sat, 17 Nov 2012 12:23:57 +0000 (13:23 +0100)]
Dialog: Add missing unit test for aria-describedby attribute

11 years agoDialog: Improve _destroy method, detaching dialog content from wrapper instead of...
Jörn Zaefferer [Sat, 17 Nov 2012 12:14:04 +0000 (13:14 +0100)]
Dialog: Improve _destroy method, detaching dialog content from wrapper instead of appending to body.

11 years agoDialog: Refactor overlay handling into two instance methods. Remove unaddressable...
Jörn Zaefferer [Sat, 17 Nov 2012 12:07:03 +0000 (13:07 +0100)]
Dialog: Refactor overlay handling into two instance methods. Remove unaddressable TODOs.

11 years agoDialog: Move array notation support for position option to backCompat check. Fixes...
Jörn Zaefferer [Sat, 17 Nov 2012 11:10:26 +0000 (12:10 +0100)]
Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option.

11 years agoDialog: Removed broken disabled option from dialog, defuse disable/enable methods...
Jörn Zaefferer [Sat, 17 Nov 2012 10:31:57 +0000 (11:31 +0100)]
Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported.

11 years agoDialog: Extend autofocus, starting with [autofocus], then :tabbable content, then...
Jörn Zaefferer [Fri, 16 Nov 2012 19:24:57 +0000 (20:24 +0100)]
Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open

11 years agoDialog: Cleanup in ticket tests: TODO to merge one test, fix whitespace
Jörn Zaefferer [Fri, 16 Nov 2012 18:46:01 +0000 (19:46 +0100)]
Dialog: Cleanup in ticket tests: TODO to merge one test, fix whitespace

11 years agoDialog: Extend visual test to verify DOM position restore on destroy; overhaul unit...
Jörn Zaefferer [Fri, 16 Nov 2012 18:33:55 +0000 (19:33 +0100)]
Dialog: Extend visual test to verify DOM position restore on destroy; overhaul unit test for destroy method.

11 years agoDialog: Pass through icons and showText (as 'text') options to button. Fixes #6830...
Jörn Zaefferer [Fri, 16 Nov 2012 18:26:22 +0000 (19:26 +0100)]
Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons.

11 years agoDialog: Tiny code improvements
Jörn Zaefferer [Fri, 16 Nov 2012 09:55:11 +0000 (10:55 +0100)]
Dialog: Tiny code improvements

11 years agoDialog: Remove uuid and getTitleId. Leftovers from 240b22b1439df22408c5782e640e98cb33...
Jörn Zaefferer [Thu, 15 Nov 2012 23:09:01 +0000 (00:09 +0100)]
Dialog: Remove uuid and getTitleId. Leftovers from 240b22b1439df22408c5782e640e98cb335c7a2e.

11 years agoDialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed outdated...
Jörn Zaefferer [Thu, 15 Nov 2012 23:05:40 +0000 (00:05 +0100)]
Dialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed outdated TODOs.

11 years agoDialog: Button is now a fixed dependency, so remove the check
Jörn Zaefferer [Thu, 15 Nov 2012 22:56:54 +0000 (23:56 +0100)]
Dialog: Button is now a fixed dependency, so remove the check

11 years agoDialog: Remove useless tmp vars.
Jörn Zaefferer [Thu, 15 Nov 2012 22:55:15 +0000 (23:55 +0100)]
Dialog: Remove useless tmp vars.

11 years agoDialog: Extracting wrapper creation into _createWrapper. Merging the two keydown...
Jörn Zaefferer [Thu, 15 Nov 2012 22:33:09 +0000 (23:33 +0100)]
Dialog: Extracting wrapper creation into _createWrapper. Merging the two keydown handlers into one.

11 years agoDialog: Extract button pane creation into _createButtonPane
Jörn Zaefferer [Thu, 15 Nov 2012 22:23:25 +0000 (23:23 +0100)]
Dialog: Extract button pane creation into _createButtonPane

11 years agoDialog: Refactor _create, extracting title bar creation in _createTitlebar
Jörn Zaefferer [Thu, 15 Nov 2012 22:20:00 +0000 (23:20 +0100)]
Dialog: Refactor _create, extracting title bar creation in _createTitlebar

11 years agoDialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn...
Jörn Zaefferer [Thu, 15 Nov 2012 22:12:54 +0000 (23:12 +0100)]
Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn't needed anymore (previous refactorings).

11 years agoDialog: Refactor the mousedown-bind call to use _on, removing the need for the uiDial...
Jörn Zaefferer [Thu, 15 Nov 2012 22:10:22 +0000 (23:10 +0100)]
Dialog: Refactor the mousedown-bind call to use _on, removing the need for the uiDialog closure. Use this.uiDialog and remove the variable.

11 years agoDialog: Remove outdated TODO
Jörn Zaefferer [Thu, 15 Nov 2012 22:04:11 +0000 (23:04 +0100)]
Dialog: Remove outdated TODO

11 years agoDialog: Have _makeResizable look at options instead of passing handles.
Jörn Zaefferer [Thu, 15 Nov 2012 22:00:47 +0000 (23:00 +0100)]
Dialog: Have _makeResizable look at options instead of passing handles.

11 years agoDialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthro...
Jörn Zaefferer [Thu, 15 Nov 2012 21:58:25 +0000 (22:58 +0100)]
Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthroughs).

11 years agoDialog: Have _createButtons access the buttons option directly. Start refactoring...
Jörn Zaefferer [Thu, 15 Nov 2012 21:54:49 +0000 (22:54 +0100)]
Dialog: Have _createButtons access the buttons option directly. Start refactoring _setOption, no need for switch.

11 years agoDialog: Refactor _setOption to call _super early. Move dialogClass update above that...
Jörn Zaefferer [Thu, 15 Nov 2012 21:51:26 +0000 (22:51 +0100)]
Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value.

11 years agoDialog: Use button widget for close button (was already listed as dependency)
Jörn Zaefferer [Thu, 15 Nov 2012 21:29:24 +0000 (22:29 +0100)]
Dialog: Use button widget for close button (was already listed as dependency)

11 years agoDialog: Focus tabbable only when dialog lost focus before.
Jörn Zaefferer [Fri, 9 Nov 2012 17:44:29 +0000 (18:44 +0100)]
Dialog: Focus tabbable only when dialog lost focus before.

11 years agoDialog: Remove attroperty workaround for title attribute. Make the default null,...
Jörn Zaefferer [Fri, 9 Nov 2012 17:26:30 +0000 (18:26 +0100)]
Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change.

11 years agoDialog: Only add the new dialogClass, not the base classes when changing the option.
Jörn Zaefferer [Fri, 9 Nov 2012 16:48:25 +0000 (17:48 +0100)]
Dialog: Only add the new dialogClass, not the base classes when changing the option.

11 years agoDialog: Use $.isEmptyObject() to check if there a button-option properties
Jörn Zaefferer [Fri, 9 Nov 2012 16:42:11 +0000 (17:42 +0100)]
Dialog: Use $.isEmptyObject() to check if there a button-option properties

11 years agoDialog: Trigger focus event when dialog is moved to top.
Jörn Zaefferer [Fri, 9 Nov 2012 16:39:59 +0000 (17:39 +0100)]
Dialog: Trigger focus event when dialog is moved to top.

11 years agoDialog: Remove deprecated disableSelection() usage.
Jörn Zaefferer [Fri, 9 Nov 2012 16:26:52 +0000 (17:26 +0100)]
Dialog: Remove deprecated disableSelection() usage.

11 years agoDialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test
Jörn Zaefferer [Fri, 9 Nov 2012 16:17:32 +0000 (17:17 +0100)]
Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test

11 years agoDialog: Inline code review
Jörn Zaefferer [Sat, 27 Oct 2012 15:07:13 +0000 (17:07 +0200)]
Dialog: Inline code review

11 years agoDialog: move to top when opening again, and focus as if opened from scratch.
Jörn Zaefferer [Fri, 26 Oct 2012 15:08:35 +0000 (11:08 -0400)]
Dialog: move to top when opening again, and focus as if opened from scratch.

11 years agoDialog: Keep focus inside modal dialog, by handling focus events on elements outside...
Jörn Zaefferer [Fri, 26 Oct 2012 14:59:41 +0000 (10:59 -0400)]
Dialog: Keep focus inside modal dialog, by handling focus events on elements outside of it

11 years agoDialog: Improve accessibilty - add an aria-describedby attribute on the dialog if...
Jörn Zaefferer [Fri, 26 Oct 2012 00:30:10 +0000 (20:30 -0400)]
Dialog: Improve accessibilty - add an aria-describedby attribute on the dialog if there is nothing yet in the dialog content. Partial fix for: