]> source.dussan.org Git - redmine.git/log
redmine.git
5 years agocode layout clean up test/unit/project_test.rb
Toshi MARUYAMA [Tue, 15 Oct 2019 05:07:40 +0000 (05:07 +0000)]
code layout clean up test/unit/project_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18676 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/models/version.rb
Toshi MARUYAMA [Tue, 15 Oct 2019 05:07:29 +0000 (05:07 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/models/version.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18675 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs and Layout/EmptyLines in app...
Toshi MARUYAMA [Tue, 15 Oct 2019 05:07:17 +0000 (05:07 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs and Layout/EmptyLines in app/models/version.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18674 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/mailer_test.rb
Toshi MARUYAMA [Tue, 15 Oct 2019 05:07:06 +0000 (05:07 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/mailer_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18673 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: use AllowAdjacentOneLineDefs of Layout/EmptyLineBetweenDefs
Toshi MARUYAMA [Mon, 14 Oct 2019 18:57:13 +0000 (18:57 +0000)]
rubocop: use AllowAdjacentOneLineDefs of Layout/EmptyLineBetweenDefs

git-svn-id: http://svn.redmine.org/redmine/trunk@18672 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove files from Layout/EmptyLines fixed by previous revisions
Toshi MARUYAMA [Mon, 14 Oct 2019 18:57:02 +0000 (18:57 +0000)]
rubocop: remove files from Layout/EmptyLines fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18671 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/helpers/application_helper.rb from Style/WhenThen fixed by r18664
Toshi MARUYAMA [Mon, 14 Oct 2019 18:56:51 +0000 (18:56 +0000)]
rubocop: remove app/helpers/application_helper.rb from Style/WhenThen fixed by r18664

git-svn-id: http://svn.redmine.org/redmine/trunk@18670 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_priority.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 18:11:44 +0000 (18:11 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_priority.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18669 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_import.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 18:11:33 +0000 (18:11 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_import.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18668 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up ApplicationHelper#parse_wiki_links
Toshi MARUYAMA [Mon, 14 Oct 2019 18:11:21 +0000 (18:11 +0000)]
code layout clean up ApplicationHelper#parse_wiki_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18667 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/helpers/application_helper.rb from Layout/ElseAlignment fixed...
Toshi MARUYAMA [Mon, 14 Oct 2019 17:48:02 +0000 (17:48 +0000)]
rubocop: remove app/helpers/application_helper.rb from Layout/ElseAlignment fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18666 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_redmine_links
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:51 +0000 (17:47 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_redmine_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18665 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_wiki_links
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:40 +0000 (17:47 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_wiki_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18664 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in app/helpers/versions_helper.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:28 +0000 (17:47 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in app/helpers/versions_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18663 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/CaseIndentation in test/test_helper.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:17 +0000 (17:47 +0000)]
code cleanup: rubocop: fix Layout/CaseIndentation in test/test_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18662 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse full text in fill_in at Issue system "update issue with form update" test
Toshi MARUYAMA [Mon, 14 Oct 2019 17:47:05 +0000 (17:47 +0000)]
use full text in fill_in at Issue system "update issue with form update" test

git-svn-id: http://svn.redmine.org/redmine/trunk@18661 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/users_contr...
Toshi MARUYAMA [Mon, 14 Oct 2019 14:52:23 +0000 (14:52 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/users_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18660 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/settings_co...
Toshi MARUYAMA [Mon, 14 Oct 2019 14:52:11 +0000 (14:52 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/settings_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18659 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/email_addre...
Toshi MARUYAMA [Mon, 14 Oct 2019 14:51:59 +0000 (14:51 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/email_addresses_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18658 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceAfterSemicolon in app/models/mail_handler.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 14:51:48 +0000 (14:51 +0000)]
code cleanup: rubocop: fix Layout/SpaceAfterSemicolon in app/models/mail_handler.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18657 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoadd new "update issue status" test to Issue system test
Toshi MARUYAMA [Mon, 14 Oct 2019 14:51:35 +0000 (14:51 +0000)]
add new "update issue status" test to Issue system test

git-svn-id: http://svn.redmine.org/redmine/trunk@18656 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "test do" syntax for Issue system test "update issue with form update"
Toshi MARUYAMA [Mon, 14 Oct 2019 14:51:25 +0000 (14:51 +0000)]
use "test do" syntax for Issue system test "update issue with form update"

git-svn-id: http://svn.redmine.org/redmine/trunk@18655 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/user_test.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 11:14:24 +0000 (11:14 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/user_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18654 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/query_test.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 11:14:12 +0000 (11:14 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18653 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_t...
Toshi MARUYAMA [Mon, 14 Oct 2019 11:14:00 +0000 (11:14 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/my_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18652 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_t...
Toshi MARUYAMA [Mon, 14 Oct 2019 11:13:49 +0000 (11:13 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/attachments_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18651 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/files_te...
Toshi MARUYAMA [Mon, 14 Oct 2019 11:13:38 +0000 (11:13 +0000)]
code cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/files_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18650 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentHeredoc and Layout/IndentationConsistency...
Toshi MARUYAMA [Mon, 14 Oct 2019 11:13:25 +0000 (11:13 +0000)]
code cleanup: rubocop: fix Layout/IndentHeredoc and Layout/IndentationConsistency in test/integration/api_test/custom_fields_attribute_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18649 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/project_test.rb
Toshi MARUYAMA [Mon, 14 Oct 2019 11:13:14 +0000 (11:13 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/project_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18648 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoadd additional assert to Issue system "test_update_issue_with_form_update"
Toshi MARUYAMA [Mon, 14 Oct 2019 11:13:02 +0000 (11:13 +0000)]
add additional assert to Issue system "test_update_issue_with_form_update"

git-svn-id: http://svn.redmine.org/redmine/trunk@18647 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in app/models/setting.rb
Toshi MARUYAMA [Sun, 13 Oct 2019 16:22:54 +0000 (16:22 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18646 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceAroundBlockParameters in test/unit/query_test.rb
Toshi MARUYAMA [Sun, 13 Oct 2019 16:22:42 +0000 (16:22 +0000)]
code cleanup: rubocop: fix Layout/SpaceAroundBlockParameters in test/unit/query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18645 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentationConsistency in test/helpers/application_...
Toshi MARUYAMA [Sun, 13 Oct 2019 16:22:31 +0000 (16:22 +0000)]
code cleanup: rubocop: fix Layout/IndentationConsistency in test/helpers/application_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18644 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/functional/project_enumerations_controller_test.rb from Lint...
Toshi MARUYAMA [Sun, 13 Oct 2019 16:22:19 +0000 (16:22 +0000)]
rubocop: remove test/functional/project_enumerations_controller_test.rb from Lint/Void fixed by r18636

git-svn-id: http://svn.redmine.org/redmine/trunk@18643 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd TOC to Markdown Wiki formatting help (#32119).
Go MAEDA [Thu, 10 Oct 2019 14:01:19 +0000 (14:01 +0000)]
Add TOC to Markdown Wiki formatting help (#32119).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18642 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd TOC to Textile Wiki formatting help (#32119).
Go MAEDA [Thu, 10 Oct 2019 13:59:45 +0000 (13:59 +0000)]
Add TOC to Textile Wiki formatting help (#32119).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18641 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentationConsistency in app/models/attachment.rb
Toshi MARUYAMA [Wed, 9 Oct 2019 07:39:28 +0000 (07:39 +0000)]
code cleanup: rubocop: fix Layout/IndentationConsistency in app/models/attachment.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18640 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/functional/project_enumerations_controller_test.rb from Layout...
Toshi MARUYAMA [Wed, 9 Oct 2019 07:39:13 +0000 (07:39 +0000)]
rubocop: remove test/functional/project_enumerations_controller_test.rb from Layout/IndentationConsistency fixed by r18636

git-svn-id: http://svn.redmine.org/redmine/trunk@18639 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix assert_equal parameter is broken in test/functional/project_enumerations_controll...
Toshi MARUYAMA [Wed, 9 Oct 2019 07:18:57 +0000 (07:18 +0000)]
fix assert_equal parameter is broken in test/functional/project_enumerations_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18636 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in app/models/changeset.rb
Toshi MARUYAMA [Wed, 9 Oct 2019 02:16:59 +0000 (02:16 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in app/models/changeset.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18633 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: add Style/AsciiComments to .rubocop_todo.yml
Toshi MARUYAMA [Wed, 9 Oct 2019 02:05:49 +0000 (02:05 +0000)]
rubocop: add Style/AsciiComments to .rubocop_todo.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18632 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/AsciiComments in lib/redmine/search.rb
Toshi MARUYAMA [Wed, 9 Oct 2019 02:05:37 +0000 (02:05 +0000)]
code cleanup: rubocop: fix Style/AsciiComments in lib/redmine/search.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18631 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/AsciiComments in test/unit/mail_handler_test.rb
Toshi MARUYAMA [Wed, 9 Oct 2019 02:05:25 +0000 (02:05 +0000)]
code cleanup: rubocop: fix Style/AsciiComments in test/unit/mail_handler_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18630 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDon't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError...
Go MAEDA [Wed, 9 Oct 2019 02:02:16 +0000 (02:02 +0000)]
Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError (#32223).

git-svn-id: http://svn.redmine.org/redmine/trunk@18629 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up test/unit/issue_status_test.rb
Toshi MARUYAMA [Tue, 8 Oct 2019 14:10:02 +0000 (14:10 +0000)]
code layout clean up test/unit/issue_status_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18628 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up test/functional/issue_statuses_controller_test.rb
Toshi MARUYAMA [Tue, 8 Oct 2019 14:09:51 +0000 (14:09 +0000)]
code layout clean up test/functional/issue_statuses_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18627 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/RedundantBegin in lib/redmine/scm/adapters/git_adapt...
Toshi MARUYAMA [Tue, 8 Oct 2019 14:09:40 +0000 (14:09 +0000)]
code cleanup: rubocop: fix Style/RedundantBegin in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18626 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix wong link destinations in wiki_syntax_markdown.html (#32169).
Go MAEDA [Tue, 8 Oct 2019 12:54:10 +0000 (12:54 +0000)]
Fix wong link destinations in wiki_syntax_markdown.html (#32169).

git-svn-id: http://svn.redmine.org/redmine/trunk@18625 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoadd additional assert to Issue system "test_update_issue_with_form_update"
Toshi MARUYAMA [Tue, 8 Oct 2019 12:18:01 +0000 (12:18 +0000)]
add additional assert to Issue system "test_update_issue_with_form_update"

git-svn-id: http://svn.redmine.org/redmine/trunk@18624 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoreduce sleep seconds of Issue system "test_update_journal_notes_with_preview"
Toshi MARUYAMA [Tue, 8 Oct 2019 12:17:51 +0000 (12:17 +0000)]
reduce sleep seconds of Issue system "test_update_journal_notes_with_preview"

git-svn-id: http://svn.redmine.org/redmine/trunk@18623 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/views/issues/_action_menu.html.erb
Toshi MARUYAMA [Tue, 8 Oct 2019 07:39:23 +0000 (07:39 +0000)]
code layout clean up app/views/issues/_action_menu.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@18622 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/views/issues/_attributes.html.erb
Toshi MARUYAMA [Tue, 8 Oct 2019 05:29:40 +0000 (05:29 +0000)]
code layout clean up app/views/issues/_attributes.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@18621 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode clean up test/integration/issues_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 13:07:12 +0000 (13:07 +0000)]
code clean up test/integration/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18620 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/issues_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 13:07:00 +0000 (13:07 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18619 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/HashSyntax in test/functional/issues_controller_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 13:06:47 +0000 (13:06 +0000)]
code cleanup: rubocop: fix Style/HashSyntax in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18618 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids
Toshi MARUYAMA [Mon, 7 Oct 2019 11:45:22 +0000 (11:45 +0000)]
use "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids

WikiPage#deleted_attachment_ids is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18617 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "attr_writer" instead of "attr_accessor" for QueryColumn#sortable
Toshi MARUYAMA [Mon, 7 Oct 2019 11:45:11 +0000 (11:45 +0000)]
use "attr_writer" instead of "attr_accessor" for QueryColumn#sortable

QueryColumn#sortable is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18616 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "attr_reader" instead of "attr_accessor" for CustomFieldValue#value
Toshi MARUYAMA [Mon, 7 Oct 2019 11:44:54 +0000 (11:44 +0000)]
use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value

CustomFieldValue#value= is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc...
Toshi MARUYAMA [Mon, 7 Oct 2019 11:44:42 +0000 (11:44 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc in test/unit/setting_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18614 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: fix source code comment in r18607
Toshi MARUYAMA [Mon, 7 Oct 2019 07:34:22 +0000 (07:34 +0000)]
code cleanup: fix source code comment in r18607

git-svn-id: http://svn.redmine.org/redmine/trunk@18613 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArray in test/functional/issues_controller_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 07:21:27 +0000 (07:21 +0000)]
code cleanup: rubocop: fix Layout/AlignArray in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18612 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceAfterColon in test/integration/wiki_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 07:21:14 +0000 (07:21 +0000)]
code cleanup: rubocop: fix Layout/SpaceAfterColon in test/integration/wiki_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18611 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in test/functional...
Toshi MARUYAMA [Mon, 7 Oct 2019 07:21:03 +0000 (07:21 +0000)]
code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18610 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceAfterColon in test/functional/issues_controlle...
Toshi MARUYAMA [Mon, 7 Oct 2019 07:20:50 +0000 (07:20 +0000)]
code cleanup: rubocop: fix Layout/SpaceAfterColon in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18609 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/functional/issues...
Toshi MARUYAMA [Mon, 7 Oct 2019 07:20:38 +0000 (07:20 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18608 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 07:20:26 +0000 (07:20 +0000)]
code cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18607 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentHeredoc in test/functional/documents_controll...
Toshi MARUYAMA [Mon, 7 Oct 2019 07:20:13 +0000 (07:20 +0000)]
code cleanup: rubocop: fix Layout/IndentHeredoc in test/functional/documents_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18606 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTraditional Chinese translation update (#32210).
Go MAEDA [Mon, 7 Oct 2019 04:08:08 +0000 (04:08 +0000)]
Traditional Chinese translation update (#32210).

Patch by ChunChang Lo.

git-svn-id: http://svn.redmine.org/redmine/trunk@18605 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/integration/attachments_test.rb from Layout/EmptyLinesAroundExce...
Toshi MARUYAMA [Mon, 7 Oct 2019 02:32:36 +0000 (02:32 +0000)]
rubocop: remove test/integration/attachments_test.rb from Layout/EmptyLinesAroundExceptionHandling fixed by r18593

git-svn-id: http://svn.redmine.org/redmine/trunk@18604 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/functional/issues_controller_test.rb from Layout/IndentHeredoc...
Toshi MARUYAMA [Mon, 7 Oct 2019 02:02:40 +0000 (02:02 +0000)]
rubocop: remove test/functional/issues_controller_test.rb from Layout/IndentHeredoc and Layout/IndentationConsistency fixed by r18593

git-svn-id: http://svn.redmine.org/redmine/trunk@18603 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoOptions in a drop-down overlap the down arrow when Alternate theme is used (#32206...
Go MAEDA [Mon, 7 Oct 2019 00:40:03 +0000 (00:40 +0000)]
Options in a drop-down overlap the down arrow when Alternate theme is used (#32206, #31147).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18602 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoJapanese wiki help translation update (#32207).
Go MAEDA [Sun, 6 Oct 2019 10:53:09 +0000 (10:53 +0000)]
Japanese wiki help translation update (#32207).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18601 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix that "Associated revisions" tab has no content when the user displays comments...
Go MAEDA [Sat, 5 Oct 2019 23:57:33 +0000 (23:57 +0000)]
Fix that "Associated revisions" tab has no content when the user displays comments in reverse chronological order (#32198, #3058).

Patch by José Esteves.

git-svn-id: http://svn.redmine.org/redmine/trunk@18598 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoJapanese translation update (#32202).
Go MAEDA [Sat, 5 Oct 2019 10:02:00 +0000 (10:02 +0000)]
Japanese translation update (#32202).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18597 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate locales (#17840).
Go MAEDA [Sat, 5 Oct 2019 09:48:15 +0000 (09:48 +0000)]
Update locales (#17840).

git-svn-id: http://svn.redmine.org/redmine/trunk@18596 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoOption to send email notification on "Target version updated" (#17840).
Go MAEDA [Sat, 5 Oct 2019 09:46:05 +0000 (09:46 +0000)]
Option to send email notification on "Target version updated" (#17840).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18595 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRedmine::VERSION::revision may return wrong value (#29601).
Go MAEDA [Sat, 5 Oct 2019 05:46:39 +0000 (05:46 +0000)]
Redmine::VERSION::revision may return wrong value (#29601).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18594 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix test failure due to missing call to set_tmp_attachments_directory (#32122).
Go MAEDA [Fri, 4 Oct 2019 11:17:33 +0000 (11:17 +0000)]
Fix test failure due to missing call to set_tmp_attachments_directory (#32122).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18593 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix incorrect headings example in Textile help (#32184).
Go MAEDA [Fri, 4 Oct 2019 00:18:30 +0000 (00:18 +0000)]
Fix incorrect headings example in Textile help (#32184).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18592 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN...
Go MAEDA [Thu, 3 Oct 2019 13:40:55 +0000 (13:40 +0000)]
Fix "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks (#32110).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18589 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove unnecessary requiring of "rexml/document" (#32189).
Go MAEDA [Thu, 3 Oct 2019 13:36:18 +0000 (13:36 +0000)]
Remove unnecessary requiring of "rexml/document" (#32189).

git-svn-id: http://svn.redmine.org/redmine/trunk@18588 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRounded corners on table.cal (#32165).
Go MAEDA [Thu, 3 Oct 2019 12:09:25 +0000 (12:09 +0000)]
Rounded corners on table.cal (#32165).

Patch by Antonio McDeal.

git-svn-id: http://svn.redmine.org/redmine/trunk@18587 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUse Redmine::MimeType.of instead of regexp to check if the attachment is Textile...
Go MAEDA [Thu, 3 Oct 2019 09:30:43 +0000 (09:30 +0000)]
Use Redmine::MimeType.of instead of regexp to check if the attachment is Textile (#29752).

git-svn-id: http://svn.redmine.org/redmine/trunk@18586 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd styles for Textile/Markdown attachments preview (#29752).
Go MAEDA [Thu, 3 Oct 2019 00:32:33 +0000 (00:32 +0000)]
Add styles for Textile/Markdown attachments preview (#29752).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18585 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRender Textile and Markdown attachments on the preview page (#29752).
Go MAEDA [Thu, 3 Oct 2019 00:09:28 +0000 (00:09 +0000)]
Render Textile and Markdown attachments on the preview page (#29752).

Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@18584 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRuboCop: Disable Layout/SpaceInsideHashLiteralBraces
Go MAEDA [Thu, 3 Oct 2019 00:08:02 +0000 (00:08 +0000)]
RuboCop: Disable Layout/SpaceInsideHashLiteralBraces

git-svn-id: http://svn.redmine.org/redmine/trunk@18583 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCode cleanup: RuboCop: Fix Performance/Count and Performance/Detect.
Go MAEDA [Wed, 2 Oct 2019 00:53:11 +0000 (00:53 +0000)]
Code cleanup: RuboCop: Fix Performance/Count and Performance/Detect.

This change corrects newly detected offenses after updating rubocop-performance to 1.5.0 in r18579.

git-svn-id: http://svn.redmine.org/redmine/trunk@18580 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate rubocop-performance to 1.5.0 (#31509).
Go MAEDA [Wed, 2 Oct 2019 00:27:19 +0000 (00:27 +0000)]
Update rubocop-performance to 1.5.0 (#31509).

git-svn-id: http://svn.redmine.org/redmine/trunk@18579 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix Redmine::Themes#scan_themes is not private
Toshi MARUYAMA [Tue, 1 Oct 2019 05:07:27 +0000 (05:07 +0000)]
fix Redmine::Themes#scan_themes is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18578 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix Watcher#prune_single_user is not private
Toshi MARUYAMA [Tue, 1 Oct 2019 05:07:16 +0000 (05:07 +0000)]
fix Watcher#prune_single_user is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18577 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate RuboCop to 0.75.0 (#31509).
Go MAEDA [Tue, 1 Oct 2019 03:18:39 +0000 (03:18 +0000)]
Update RuboCop to 0.75.0 (#31509).

git-svn-id: http://svn.redmine.org/redmine/trunk@18576 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix wrong markup in public/help/ja/wiki_syntax_detailed_(markdown|textile).html ...
Go MAEDA [Mon, 30 Sep 2019 13:31:26 +0000 (13:31 +0000)]
Fix wrong markup in public/help/ja/wiki_syntax_detailed_(markdown|textile).html (#32169).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18572 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd links to the detailed Wiki formatting help in Quick Reference (#32169).
Go MAEDA [Mon, 30 Sep 2019 13:28:50 +0000 (13:28 +0000)]
Add links to the detailed Wiki formatting help in Quick Reference (#32169).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18571 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd support for "start with" and "end with" operators to "Files" filter (#31879).
Go MAEDA [Mon, 30 Sep 2019 13:15:45 +0000 (13:15 +0000)]
Add support for "start with" and "end with" operators to "Files" filter (#31879).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18570 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_su...
Toshi MARUYAMA [Mon, 30 Sep 2019 12:47:52 +0000 (12:47 +0000)]
fix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_subtasks

git-svn-id: http://svn.redmine.org/redmine/trunk@18569 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/models/issue.rb from Layout/ElseAlignment fixed by previous revisions
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:59 +0000 (11:42 +0000)]
rubocop: remove app/models/issue.rb from Layout/ElseAlignment fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18568 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours...
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:48 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours method

git-svn-id: http://svn.redmine.org/redmine/trunk@18567 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:36 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method

git-svn-id: http://svn.redmine.org/redmine/trunk@18566 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition...
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:26 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition method

git-svn-id: http://svn.redmine.org/redmine/trunk@18565 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/helpers/application_hel...
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:15 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/helpers/application_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18564 e93f8b46-1217-0410-a6f0-8f06a7374b81