source.dussan.org Git

Andreas Beeker [Sat, 11 Feb 2017 00:57:39 +0000 (00:57 +0000)]

SonarQube fixes and removed redundant logger level checks, for simple String messages

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782548 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 10 Feb 2017 14:02:12 +0000 (14:02 +0000)]

Add a possible future TODO

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782472 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 10 Feb 2017 13:51:33 +0000 (13:51 +0000)]

Use long for the dummy stream, to permit >2gb streams

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782470 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 10 Feb 2017 12:55:55 +0000 (12:55 +0000)]

If a property refers to an invalid index, log + ignore rather than failing with a IndexOutOfBoundsException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782461 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 10 Feb 2017 11:43:01 +0000 (11:43 +0000)]

Update the big file test to use POIFSFileSystem.create(File), and tweak javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782454 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 9 Feb 2017 19:29:51 +0000 (19:29 +0000)]

Start on a unit test for #60670, work required to get it passing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782380 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 9 Feb 2017 19:29:15 +0000 (19:29 +0000)]

Unit test comment for possible future expansion

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782378 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 8 Feb 2017 18:35:04 +0000 (18:35 +0000)]

bug 59030: revert r1746625 and restore r1731257, where XWPFTableCell#getVerticalAlignment() returns null rather than a default value (XWPFVertAlign.TOP) if vertical alignment is not set

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782225 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 8 Feb 2017 18:32:53 +0000 (18:32 +0000)]

bug 59030: convert to junit4; whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782224 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 8 Feb 2017 09:23:04 +0000 (09:23 +0000)]

Per JavaDoc and tallison, XWPFTableCell#getVerticalAlignment() should return null if valign is not set. Patch from prasad-babu. This closes #30 on GitHub.
https://github.com/apache/poi/pull/30#issuecomment-186224438

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782130 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 8 Feb 2017 08:35:04 +0000 (08:35 +0000)]

bug 59227: set charset to UTF-8 to avoid editor problems

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782120 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 8 Feb 2017 08:29:18 +0000 (08:29 +0000)]

bug 59227: parse dates formatted in Japanese or Chinese. Change javac source encoding from ASCII to UTF-8 (same as build.gradle). Patch from jzhao. This closes #48 on Github.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782119 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 8 Feb 2017 08:24:35 +0000 (08:24 +0000)]

target version 3.16-beta3

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782118 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 8 Feb 2017 07:47:30 +0000 (07:47 +0000)]

Convert all *.java files to use native end of line character(s)
$ dos2unix `find -name *.java`
$ svn propset svn:eol-style native `find -name *.java`

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782114 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 8 Feb 2017 07:20:31 +0000 (07:20 +0000)]

bug 59983: correctly update shared formulas when shifting rows. Thanks to Luca Martini for the initial failing unit test with test file and Chiara Marcheschi for the patch

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782111 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 8 Feb 2017 07:04:55 +0000 (07:04 +0000)]

+svn:eol-style native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782109 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 8 Feb 2017 01:12:22 +0000 (01:12 +0000)]

#60625 - Rendering issue with background and shape overlayed by image

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782096 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 8 Feb 2017 01:01:51 +0000 (01:01 +0000)]

#60626 - ArrayIndexOutOfBoundsException in EvilUnclosedBRFixingInputStream

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782095 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 5 Feb 2017 22:34:50 +0000 (22:34 +0000)]

Jenkins DSL: Additionally disable node H12 for OpenJDK builds

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781824 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 5 Feb 2017 22:34:46 +0000 (22:34 +0000)]

Update JDK 9 build config to use correct add-opens for java.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781823 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 5 Feb 2017 22:34:40 +0000 (22:34 +0000)]

Revert previous changes enough to restore the case in the commoncrawl-corpus which is failing now, add a unit-test for this case, enable one disabled unit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781822 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 5 Feb 2017 22:34:09 +0000 (22:34 +0000)]

Adjust for JDK 9 ea152 and newer: certain whitespaces in XML may now be trimmed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781821 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Fri, 3 Feb 2017 20:19:33 +0000 (20:19 +0000)]

Bug 60677 -- handle multibyte encodings correctly in HwmfGraphics' drawString. Thanks to Dominik Stadler for finding this bug and a triggering doc via large scale regression testing.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781593 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 2 Feb 2017 00:48:03 +0000 (00:48 +0000)]

run release-prep0 with https URLs. This worked for kiwiwings.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781337 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 2 Feb 2017 00:45:21 +0000 (00:45 +0000)]

convert links to https

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781336 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 1 Feb 2017 01:24:02 +0000 (01:24 +0000)]

echo release version

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781195 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 1 Feb 2017 01:21:28 +0000 (01:21 +0000)]

ignore compile-lib/svnant

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781194 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 1 Feb 2017 00:59:20 +0000 (00:59 +0000)]

release-prep1 should abort if release tag already exists. It's likely that the version was entered incorrectly or copy-pasted from a template.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781191 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 30 Jan 2017 22:05:29 +0000 (22:05 +0000)]

use https links

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781001 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 27 Jan 2017 05:47:12 +0000 (05:47 +0000)]

prepare for 3.16-beta3

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780508 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 27 Jan 2017 05:41:13 +0000 (05:41 +0000)]

revert r1780499: wrong release-prep1 version (3.15-beta1)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780505 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 27 Jan 2017 05:27:01 +0000 (05:27 +0000)]

Revert r1780501: wrong release-prep1 version (3.15-beta1)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780502 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 27 Jan 2017 04:49:14 +0000 (04:49 +0000)]

prepare for 3.15-beta2

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780501 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 27 Jan 2017 04:47:49 +0000 (04:47 +0000)]

release prepare for 3.15-beta1 - updating build.xml and status.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780499 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 27 Jan 2017 04:23:56 +0000 (04:23 +0000)]

change copyright date to 2017; fix broken urls

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780495 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 20:59:49 +0000 (20:59 +0000)]

Adjust expected font-size in tests, XSSF seems to use slightly larger fonts on some machines

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780479 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:59:10 +0000 (19:59 +0000)]

Need a fifth addopens-parameter for JDK 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780457 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:59:05 +0000 (19:59 +0000)]

Finally enable test for bug 44937, we got the requested missing test-documents a long time ago already.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780456 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:58 +0000 (19:58 +0000)]

Don't wrap RuntimeException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780455 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:52 +0000 (19:58 +0000)]

Move test to base-test-class to run it for (S)XSSF as well
Also had to increase the numbers a bit as it fails locally for me otherwise

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780454 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:46 +0000 (19:58 +0000)]

IntelliJ warnings, Javadoc, Formatting
Changes for the RecordFormatException deprecation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780453 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:29 +0000 (19:58 +0000)]

Jenkins DSL: Run all tests in no-scratchpad to try to get similar coverage-numbers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780452 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:25 +0000 (19:58 +0000)]

Cover some dev-tools with a few simple tests, close resources correctly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780451 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 26 Jan 2017 19:58:18 +0000 (19:58 +0000)]

Bug 60031: Enhance test some more

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780450 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 23 Jan 2017 00:31:27 +0000 (00:31 +0000)]

fix eclipse warnings - close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779869 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 22 Jan 2017 22:01:22 +0000 (22:01 +0000)]

#59836 - Tracker: Replace primitives with enums
preparation for removing those many HSSFColor subclasses with an enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779866 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Fri, 20 Jan 2017 12:10:29 +0000 (12:10 +0000)]

Bug 60608 -- improve charset handling in Hwmf -- remove deprecated drawString(String...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779613 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:40:49 +0000 (05:40 +0000)]

fix assert message typo

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779567 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:37:12 +0000 (05:37 +0000)]

fix copy-paste typo in unit test found by Andrzej Witecki

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779565 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:35:57 +0000 (05:35 +0000)]

bug 60031: DataFormatter parses months incorrectly when put at the end of date segment. Thanks to Andrzej Witecki

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779564 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:04:57 +0000 (05:04 +0000)]

remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779563 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 05:00:29 +0000 (05:00 +0000)]

bug 60605: replace Workbook.SHEET_STATE_VERY_HIDDEN with SheetVisibility.VERY_HIDDEN

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779562 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 04:55:06 +0000 (04:55 +0000)]

bug 60605: remove code for enforcing rule that active sheet cannot be hidden

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779561 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 04:38:18 +0000 (04:38 +0000)]

pull out loop invariants, use List.indexOf to look up sheet index

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779560 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 04:23:42 +0000 (04:23 +0000)]

bug 60605: convert Workbook.SHEET_STATE_* to SheetVisibility enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779558 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 04:20:20 +0000 (04:20 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779557 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 20 Jan 2017 02:16:58 +0000 (02:16 +0000)]

make instance variable final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779551 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Thu, 19 Jan 2017 20:19:26 +0000 (20:19 +0000)]

Bug 60608 -- improve charset handling in Hwmf

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779519 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Thu, 19 Jan 2017 16:22:29 +0000 (16:22 +0000)]

Bug 60570 - Add rudimentary EMF read-only capability

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779493 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 19 Jan 2017 09:01:39 +0000 (09:01 +0000)]

bug 60601: unset hyperlinks after removing them individually from the DOM

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779437 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 19 Jan 2017 08:51:04 +0000 (08:51 +0000)]

bug 60601: allow SXSSFITestDataProvider.writeOutAndReadBack(Workbook wb) to work on SXSSFWorkbooks and XSSFWorkbooks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779433 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 19 Jan 2017 08:09:11 +0000 (08:09 +0000)]

bug 60601: hyperlinks have to be removed one by one to avoid other errors

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779429 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 19 Jan 2017 07:44:25 +0000 (07:44 +0000)]

bug 60601: unlink hyperlinks from a sheet if all hyperlinks have been removed. Patch from Joachim Piketz

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779426 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 18 Jan 2017 00:59:19 +0000 (00:59 +0000)]

SonarQube fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779285 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 16 Jan 2017 01:18:46 +0000 (01:18 +0000)]

fix eclipse warnings / close resources in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778958 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 15 Jan 2017 23:08:47 +0000 (23:08 +0000)]

fix eclipse warnings - close resources / type generics
cleanup sources - add parenthesis to statements

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778955 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 15 Jan 2017 19:03:17 +0000 (19:03 +0000)]

remove test output

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778940 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 15 Jan 2017 19:02:48 +0000 (19:02 +0000)]

Java9 fix - resource not found

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778939 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 15 Jan 2017 02:04:57 +0000 (02:04 +0000)]

#60586 - Support embedding OLE1.0 package in XSSF / SS Common

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778869 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Fri, 13 Jan 2017 20:55:04 +0000 (20:55 +0000)]

bug 60584 -- avoid NPE by checking for null/missing image in XSSFReader's getShapes().

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778664 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 12 Jan 2017 10:39:26 +0000 (10:39 +0000)]

bug 60260: parse unicode sheet names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778418 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Wed, 11 Jan 2017 16:01:32 +0000 (16:01 +0000)]

Bug 60574 prevent rare NPE in ListTables

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778320 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 8 Jan 2017 00:38:41 +0000 (00:38 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777855 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 7 Jan 2017 00:26:46 +0000 (00:26 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777739 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 6 Jan 2017 17:51:22 +0000 (17:51 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777669 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 6 Jan 2017 09:05:14 +0000 (09:05 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777541 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 5 Jan 2017 23:40:57 +0000 (23:40 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777526 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 5 Jan 2017 22:49:14 +0000 (22:49 +0000)]

Rename example class (typo)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777518 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 12:46:28 +0000 (12:46 +0000)]

add unit tests for MAPIMessage.get*Body()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777463 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 11:26:42 +0000 (11:26 +0000)]

junit improvements: assertEquals(null|true|false, ...) -> assertNull, assertTrue, assertFalse

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777450 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 11:17:44 +0000 (11:17 +0000)]

bug 60331: remove deprecated OutlookTextExtractor constructor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777447 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 10:41:23 +0000 (10:41 +0000)]

bug 60331: remove deprecated constructor and method in scratchpad o.a.p.hsmf.MAPIMessage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777444 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 08:36:06 +0000 (08:36 +0000)]

revert accidental commits in r1777435

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777436 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 08:32:07 +0000 (08:32 +0000)]

junit3 -> junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777435 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 08:01:58 +0000 (08:01 +0000)]

bug 60550: read ContentID chunks from mail attachments; unit test and test-data/hsmf/attachmet_msg_inlineImg.msg contributed by maoblackberry@gmail.com

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777429 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 07:59:27 +0000 (07:59 +0000)]

bug 60550: read ContentID chunks from mail attachments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777428 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 07:26:02 +0000 (07:26 +0000)]

whitespace: 3/4sp -> 4sp

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777427 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 5 Jan 2017 07:16:27 +0000 (07:16 +0000)]

junit improvements:
assertEquals(null, ...) -> assertNull(...)
attachment.getAttachFileName().toString() -> attachment.getAttachFileName().getValue()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777423 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 5 Jan 2017 01:10:45 +0000 (01:10 +0000)]

EmbeddedExtractor (for *SSF) - added OOXML support

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777394 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 4 Jan 2017 07:00:24 +0000 (07:00 +0000)]

github-44: reference BuiltinFormats in javadocs for CellStyle.getDataFormat and setDataFormat
This closes #44 github pull request from sixinli

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777260 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 4 Jan 2017 01:24:19 +0000 (01:24 +0000)]

relax timeout on performance test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777254 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 4 Jan 2017 01:06:30 +0000 (01:06 +0000)]

SonarQube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777252 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Tue, 3 Jan 2017 15:41:41 +0000 (15:41 +0000)]

Fix poor XPath performance when importing XSSF from XML

https://bz.apache.org/bugzilla/show_bug.cgi?id=60498

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777146 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 3 Jan 2017 04:35:54 +0000 (04:35 +0000)]

bug 60484: avoid NPE

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777063 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 3 Jan 2017 03:52:58 +0000 (03:52 +0000)]

use Collections.singletonList and Collections.emptyList where appropriate

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777056 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 3 Jan 2017 02:14:29 +0000 (02:14 +0000)]

refactor duplicated code in TestXSSFSheet#setColumnGroupCollapsed; remove unnecessary int to short casts

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777052 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Tue, 3 Jan 2017 01:02:33 +0000 (01:02 +0000)]

SonarQube fixes
add Iterable interface to EscherContainerRecord / deprecate getChildIterator()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777046 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 2 Jan 2017 23:23:16 +0000 (23:23 +0000)]

convert TestColumnHelper from junit3 to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777038 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 2 Jan 2017 23:14:53 +0000 (23:14 +0000)]

assertEquals(false, ...) -> assertFalse(...)
assertEquals(true, ...) -> assertTrue(...)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777037 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 2 Jan 2017 22:23:56 +0000 (22:23 +0000)]

use case-insensitive string startsWith/endsWith utility function

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777031 13f79535-47bb-0310-9956-ffa450edef68