Merge pull request #38917 from nextcloud/bugfix/talk-9558/plural-issue-with-some-language-locale-combinations

fix(l10n): Fix plural issue with different locale and language

Merge pull request #38747 from nextcloud/perf/early-exit-mkcol

perf: skip request without write permission

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38826 from nextcloud/enh/a11y-new-user

enh(a11y): New user modal

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #38924 from nextcloud/automated/update-engines/default

chore: update node engines to next LTS

Merge pull request #38927 from nextcloud/bugfix/noid/package.json-editorconfig

chore: Adjust editorconfig for package.json and package-lock.json

Signed-off-by: Joas Schilling <coding@schilljs.com>

chore: update node engines to next LTS (node 20 / npm 9)

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Merge pull request #38806 from nextcloud/feat/f2v/actions-1

chore: add `__tests__` and `__mocks__` to file checker and fix updated names

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

chore: update old codecov config

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: prepare jest coverage support

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(jest): replace mock with jest.spyOn

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add open folder action testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add download action testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add delete action testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add sidebar action testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: prepare jest upgrade and ts testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix: delete action import

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(l10n): Fix plural issue with different locale and language

We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #38915 from nextcloud/enh/noid/increase-https-warning

adjust admin setup check to increase warning to configure https

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

adjust admin setup check to increase warning to set up https

Signed-off-by: Simon L <szaimen@e.mail.de>

Merge pull request #38762 from fsamapoor/constructor_property_promotion_in_core_command_part1

Uses PHP8's constructor property promotion in core/Command/Encryption

Merge pull request #38768 from fsamapoor/constructor_property_promotion_in_core_command_part5

Uses PHP8's constructor property promotion in core/Command/Config and Group

Merge pull request #38639 from charno/bugfix/36644-pruneOutdatedSyncTokens-deletes-all-entries

Bugfix/36644 pruneOutdatedSyncTokens deletes all entries

Update core/Command/Encryption/DecryptAll.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/Encryption/EncryptAll.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Fixes php-cs error.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Uses PHP8's constructor property promotion in core/Command/Encryption classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Merge pull request #38638 from fsamapoor/constructor_property_promotion_part3

[3/3] Refactors /core controllers using constructor property promotion.

Merge pull request #35424 from nextcloud/cleanup/comments

Cleanup comments code

Throw if creation date is read before inserting into database

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Improve typing in ICommentsManager

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Cleanup comments code

- Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Update core/Controller/SetupController.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Applies agreed-upon indentation convention to the changed controllers.

Based on https://github.com/nextcloud/server/pull/38636#discussion_r1218167753

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Refactors controllers by using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Merge pull request #38774 from fsamapoor/constructor_property_promotion_in_core_command_part8

 Uses PHP8's constructor property promotion in core/Command/Log, /Security, and /SystemTag

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Uses PHP8's constructor property promotion in core/Command/Config and  core/Command/Group classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38888 from nextcloud/artonge/fix/dont_disable_action_during_save

Don't disable actions when saving share permissions

Merge pull request #38890 from nextcloud/obj-store-copy-list-source-cache

Merge pull request #38769 from fsamapoor/constructor_property_promotion_in_core_command_part6

 Uses PHP8's constructor property promotion core/Command/App,/Background, and /Broadcast

Merge pull request #38876 from Freiheitswolke/style/config/alphabetise-preview-providers

style(config): alphabetise preview providers

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

 Uses PHP8's constructor property promotion.
 in core/Command/Log, /Security, and /SystemTag classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Merge pull request #38767 from fsamapoor/constructor_property_promotion_in_core_command_part4

Uses PHP8's constructor property promotion in core/Command/Maintenance

Merge pull request #38764 from fsamapoor/constructor_property_promotion_in_core_command_part2

Uses PHP8's constructor property promotion in core/Command/Db classes.

Merge pull request #38766 from fsamapoor/constructor_property_promotion_in_core_command_part3

Uses PHP8's constructor property promotion in core/Command/User classes.

use source cache when listing folder during recursive copy

Signed-off-by: Robin Appelman <robin@icewind.nl>

perf: skip request without write permission

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #38865 from nextcloud/dependabot/npm_and_yarn/nextcloud/files-3.0.0-beta.10

bump @nextcloud/files from 3.0.0-beta.9 to 3.0.0-beta.10

Merge pull request #38773 from nextcloud/fix/noid/protect-oauth2-api-controller

Add bruteforce protection in OauthApiController

style(config): alphabetise preview providers

Signed-off-by: Joda Stößer <git@simjo.st>

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

 Uses PHP8's constructor property promotion.
 in core/Command/App, /Background, and /Broadcast classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Uses PHP8's constructor property promotion in core/Command/Maintenance classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Update core/Command/Db/ConvertType.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/Db/ConvertFilecacheBigInt.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/Db/Migrations/MigrateCommand.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/Db/Migrations/StatusCommand.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Uses PHP8's constructor property promotion in core/Command/Db classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Uses PHP8's constructor property promotion in core/Command/User classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Merge pull request #38637 from fsamapoor/constructor_property_promotion_part2

[2/3] Refactors /core controllers using constructor property promotion.

bump @nextcloud/files from 3.0.0-beta.9 to 3.0.0-beta.10

---
updated-dependencies:
- dependency-name: "@nextcloud/files"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Don't disable actions when saving share permissions

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #38868 from nextcloud/enh/noid/fix-mail-confusion

fix confusion around mail settings and improve layout a bit

Merge pull request #38878 from nextcloud/cleanup/controller-service-aliases

Cleanup controller service aliases

add bruteforce protection in OauthApiController

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Merge pull request #38776 from nextcloud/fix/app-menu-do-not-invert-text

fix(core): Do not invert app menu text color

Compile JS assets

Signed-off-by: Jonas <jonas@freesources.org>

fix(core): Do not invert app menu text color

* Also fixes other cypress test
* Build assets

Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

workflowengine: Stop using a service alias for controller

Signed-off-by: jld3103 <jld3103yt@gmail.com>

comments: Stop using a service alias for controller

Signed-off-by: jld3103 <jld3103yt@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix confusion around mail settings

Signed-off-by: Simon L <szaimen@e.mail.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Applies agreed-upon indentation convention to the changed controllers.

Based on https://github.com/nextcloud/server/pull/38636#discussion_r1218167753

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Fixes psalm error.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Fixes php-cs-fixer error.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Refactors controllers by using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Merge pull request #38843 from nextcloud/message-log-event-type

fix type in BeforeMessageLoggedEvent

Merge pull request #38823 from nextcloud/enh/noid/fix-icons

generate user themed favicon and touchicon

Merge pull request #38793 from Jenandra/fix-subadminsgroups-css-name

align subadmins css class name

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

generate user themed favicon and touchicon

Signed-off-by: Simon L <szaimen@e.mail.de>

Merge pull request #38841 from nextcloud/fix/code-ownders-vitor

fix: Removed invalid user from CODEOWNERS file

fix type in BeforeMessageLoggedEvent

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix: Removed invalid user from CODEOWNERS file

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #38830 from nextcloud/fix/files-api-route-names

Fix files API route names

Merge pull request #38827 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

duplicate css for subadmins to allow for both class names being used

Signed-off-by: Silke Suck <silke.suck@adacor.com>

align subadmins css class name with actually used class name subAdminsGroups to fix display issue when users are in many groups

Signed-off-by: Silke Suck <silke.suck@adacor.com>