source.dussan.org Git

Nick Burch [Thu, 31 Jul 2014 15:07:27 +0000 (15:07 +0000)]

Fix bug #56502 - When shifting XSSF rows with formula cells, if the formula can't be parsed, log + leave it unchanged rather than failing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614916 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 31 Jul 2014 14:55:04 +0000 (14:55 +0000)]

Fix bug #56527 - Avoid NPE from XSSFHyperLink when setting the cell
it references on a new link

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614914 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 31 Jul 2014 13:37:33 +0000 (13:37 +0000)]

Fix javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614886 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 31 Jul 2014 13:31:01 +0000 (13:31 +0000)]

Fix bug #53984 - Support the ColInfoRecord coming after the cells, rather than before as is normal, and also handle things so that if an unsupported BofRecord is found for a sheet, warn and skip rather than breaking

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614884 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 23:06:46 +0000 (23:06 +0000)]

Correct logic for the start-of-sheet missing rows, for event user model, and add tests for this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614789 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 23:05:58 +0000 (23:05 +0000)]

Generics fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614788 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 22:43:31 +0000 (22:43 +0000)]

Start on details tests for bug #53433

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614786 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 19:02:09 +0000 (19:02 +0000)]

Unit test to show that bug #53494 has already been fixed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614741 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 18:08:28 +0000 (18:08 +0000)]

#56132 Allow XSSF formula evaluation to also skip missing external workbook references, if requested

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614729 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 18:07:14 +0000 (18:07 +0000)]

Slightly modified test file for bug #56132 - xlsx file with inline references to other files (no external links used)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614728 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 17:53:54 +0000 (17:53 +0000)]

XSSF external workbook lookup support for in-line file:/// based book "numbers"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614724 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 16:56:31 +0000 (16:56 +0000)]

Convert the test to using interfaces

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614715 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 16:30:46 +0000 (16:30 +0000)]

SVN mimetypes for Word files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614705 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 16:26:42 +0000 (16:26 +0000)]

SVN mimetypes for PowerPoint files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614701 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 16:24:22 +0000 (16:24 +0000)]

More mimetype updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614700 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 16:21:16 +0000 (16:21 +0000)]

More Excel test file mimetypes in svn

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614699 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 16:18:26 +0000 (16:18 +0000)]

Correct the mimetype in svn for test spreadsheet files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614697 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 16:10:56 +0000 (16:10 +0000)]

Updated patch from Marc from #55927 - handle date formulas too

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614696 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 15:44:05 +0000 (15:44 +0000)]

Add row label getter for Pivot Tables, and use this in unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614691 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 15:27:09 +0000 (15:27 +0000)]

Patch from Sofia Larsson and Martin Andersson from bug #56020 - XSSF support for creating Pivot tables

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614684 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 12:53:19 +0000 (12:53 +0000)]

Exclude the release notes and readmes from the rat checks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614642 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 07:41:01 +0000 (07:41 +0000)]

Change XSSFSheetXMLHandler.SheetContentsHandler to require fewer backwards incompatible changes for #56023

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614576 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 30 Jul 2014 07:32:21 +0000 (07:32 +0000)]

Add a target to help with generating the release notes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614573 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 28 Jul 2014 19:10:54 +0000 (19:10 +0000)]

Add simple unit test to verify that Bug 42016 was fixed already by some other fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614135 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 27 Jul 2014 19:57:57 +0000 (19:57 +0000)]

Add unit test for bug 37625 which verifies that this file can now be loaded

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613837 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 27 Jul 2014 18:32:24 +0000 (18:32 +0000)]

Add/Fix some Javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613826 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 26 Jul 2014 22:39:16 +0000 (22:39 +0000)]

Unit test to show that bug #52111 (intersect formulas) was already solved

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613737 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 26 Jul 2014 15:20:06 +0000 (15:20 +0000)]

HSSF and XSSF Multi-Sheet formula reference tests from Radoslav from bug #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613654 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 16:42:31 +0000 (16:42 +0000)]

Complete evaluation support for multi-sheet references for bug #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613467 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 16:15:47 +0000 (16:15 +0000)]

Begin required interface + base-class support for multi-sheet area references for #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613460 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 15:55:49 +0000 (15:55 +0000)]

Allow XSSF to evaluate multi-sheet references too, for #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613455 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 15:49:35 +0000 (15:49 +0000)]

Split the reference and area tests for #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613454 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 15:46:05 +0000 (15:46 +0000)]

Update the RefEval method signature to cope with multi-sheet references, and have appropriate functions take advantage of this. For bug #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613453 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 14:50:44 +0000 (14:50 +0000)]

Start preparing LazyAreaEval and LazyRefEval to handle sheet ranges, for #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613443 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 14:23:21 +0000 (14:23 +0000)]

Update the XSSF getExternalSheet method signature, to start to prepare for sheet ranges

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613439 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 14:15:56 +0000 (14:15 +0000)]

More tests for #55906, and provide a new eval that lets you get at evals for many sheets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613438 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 13:59:07 +0000 (13:59 +0000)]

Areas can have multi-sheet references too, so add FormulaParser support to these as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613437 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 10:22:21 +0000 (10:22 +0000)]

Update Ref3DPxg to support multi-sheet ranges too, for #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613376 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 10:10:52 +0000 (10:10 +0000)]

Refactor to reduce clutter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613374 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 25 Jul 2014 10:05:57 +0000 (10:05 +0000)]

More progress towards #55906 - Have the ExternSheet references set up for multi-sheet references

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613373 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 22:44:51 +0000 (22:44 +0000)]

More progress towards #55906 - FormulaParser is able to identify and parse multi-sheet references, but not yet fully round-trip them. (No evaluation support yet either)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613317 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 21:35:47 +0000 (21:35 +0000)]

More internal method signature updates, for HSSF external sheets being possible ranges, for #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613307 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 21:25:45 +0000 (21:25 +0000)]

Rename some of the internal HSSF sheet lookup methods which deal with external sheet indicies, to make it clear when they return the first sheet name/index, and add support for getting the last one too (will be the same as the first if not a range)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613305 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 21:10:13 +0000 (21:10 +0000)]

#55906 Extern Sheet References can have a last as well as a first sheet

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613302 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 20:48:29 +0000 (20:48 +0000)]

Disabled unit tests for multi-sheet references, see bug #55906

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613282 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 20:13:54 +0000 (20:13 +0000)]

Patch from Shaun Kalley from bug #56023 - Allow XSSF event model to find + return comments, and use this for the event based .xlsx text extractor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613266 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 19:34:19 +0000 (19:34 +0000)]

Patch from thaichat04 from bug #56194 - HPSF thumbnail format tags are int not unit

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613256 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 18:58:27 +0000 (18:58 +0000)]

Patch from Raúl Wegmann from bug #56735 / GitHub Pull #10 - Rationalise POI temp file creation to the TempFile util class, and allow a system wide setting of where Temp files (eg for SXSSF) go, via TempFile / TempFileCreationStrategy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613246 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 17:14:00 +0000 (17:14 +0000)]

To avoid problems on strange platforms, tell xmlbeans to use UTF-8 for strings by default, for bug #56683

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613193 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 17:09:23 +0000 (17:09 +0000)]

XSSF table example, from Sofia Larsson from bug #55562

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613191 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 16:41:43 +0000 (16:41 +0000)]

For places where an ordered collection is created and used within the context of a single thread, and there are no thread safety concerns, use ArrayList not Vector. See bug #54838

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613186 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 16:26:34 +0000 (16:26 +0000)]

Fix javadoc warning

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613176 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 16:25:58 +0000 (16:25 +0000)]

Correct HSSFOptimiser logic for the case where the to-keep style wasn't previously in use. Fixes #54443

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613175 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 16:22:28 +0000 (16:22 +0000)]

Fix inconsistent whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613174 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 14:56:23 +0000 (14:56 +0000)]

When evaluating a name in another workbook, need to use an OperationEvaluationContext tied to that Workbook, and do so such that XSSF references work too

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613154 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 24 Jul 2014 14:37:09 +0000 (14:37 +0000)]

Don't fetch the name, convert to a ptg, then convert back again, instead simply return the name directly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613153 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 23 Jul 2014 19:09:45 +0000 (19:09 +0000)]

Get further with the XSSF formula reference evaluation testing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612926 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 23 Jul 2014 19:09:25 +0000 (19:09 +0000)]

Further XSSF external name evaluation lookup support

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612925 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 23 Jul 2014 17:41:40 +0000 (17:41 +0000)]

JaCoCo 0.7.x requires asm-5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612887 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 23 Jul 2014 07:55:48 +0000 (07:55 +0000)]

Fix test to make it work on different date as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612786 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 22 Jul 2014 12:31:56 +0000 (12:31 +0000)]

Bug 56688: Fix border cases in EDATE function: handle RefEval and BlankEval and also return #VALUE, not #REF if case of error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612557 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 22 Jul 2014 07:47:14 +0000 (07:47 +0000)]

Fix formatting of trailing comma in HexDumps, cover class fully with tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612496 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 21 Jul 2014 16:52:19 +0000 (16:52 +0000)]

Use the link table when looking up external xssf names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612347 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 21 Jul 2014 12:23:54 +0000 (12:23 +0000)]

Generalise the CollaboratingWorkbooksEnvironment setup, so that XSSF can use it too

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612254 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 21 Jul 2014 09:45:44 +0000 (09:45 +0000)]

Fix inconsistent whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612219 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 21 Jul 2014 09:44:21 +0000 (09:44 +0000)]

Allow creating a CollaboratingWorkbooksEnvironment from a Map too, not only a pair of arrays

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612218 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 21 Jul 2014 07:35:09 +0000 (07:35 +0000)]

Correct non-sheet-based NameXPxg formula rendering, and add tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612203 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 20 Jul 2014 19:24:42 +0000 (19:24 +0000)]

More unit tests for #56737 and #56752

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612157 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 20 Jul 2014 19:13:45 +0000 (19:13 +0000)]

Comments updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612156 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 20 Jul 2014 18:56:35 +0000 (18:56 +0000)]

Change how we update sheet names in XSSF formulas and names, when renaming sheets, to take advantage of the simpler structure that Pxg now offers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612151 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 20 Jul 2014 18:53:27 +0000 (18:53 +0000)]

XSSF Pxgs must escape sheet names where required when generating the formula string

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612150 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 20 Jul 2014 18:48:48 +0000 (18:48 +0000)]

Common interface across the XSSF Ptg / Pxg classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612149 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 20 Jul 2014 18:14:47 +0000 (18:14 +0000)]

Rename missing from previous commit

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612140 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 20 Jul 2014 17:51:51 +0000 (17:51 +0000)]

Update the formula evaluator to support XSSF style external named ranges too

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612133 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 21:27:28 +0000 (21:27 +0000)]

Better reporting on why a test is failing, and partial NameXPxg eval

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611969 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 21:00:21 +0000 (21:00 +0000)]

Complete the XSSF Formula Parser tests for #56737

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611963 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 20:51:23 +0000 (20:51 +0000)]

Move towards supporting same workbook named ranges in external style for xssf

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611961 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 20:30:31 +0000 (20:30 +0000)]

Start to add XSSF specific handling for NameX (named ranges or functions from another file) #56737

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611958 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 19:42:07 +0000 (19:42 +0000)]

Provide XSSF-style external sheet support for areas, similar to the recent cell reference support. #56737

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611950 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 19:23:13 +0000 (19:23 +0000)]

Fix inconsistent indents/whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611949 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 19:19:06 +0000 (19:19 +0000)]

Start to update how the formula parser looks up sheets from formula ptgs, to account for the differences in how HSSF and XSSF store references to external sheets. For #56737

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611948 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 19:11:54 +0000 (19:11 +0000)]

Fix inconsistent indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611947 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 19:10:47 +0000 (19:10 +0000)]

The Event User Model fake-workbook for formula evaluations needs to know about the sheet names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611946 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 19:00:09 +0000 (19:00 +0000)]

Fix Generics warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611944 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 12:49:41 +0000 (12:49 +0000)]

The way that HSSF and XSSF stores references to external sheets are rather different, so begin to reflect that in how we parse their formulas into Ptgs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611906 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 11:27:46 +0000 (11:27 +0000)]

There can be more than one linked ExternalLinks table for a workbook #56744

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611890 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 10:09:00 +0000 (10:09 +0000)]

Turns out that .xlsx files can have multiple link tables, add a test file which shows this (support to follow)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611878 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 19 Jul 2014 10:08:20 +0000 (10:08 +0000)]

Convert test to junit 4, and stub out the additional 3d ref tests we need to pass for #56737

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611877 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Jul 2014 23:02:51 +0000 (23:02 +0000)]

Stub the unit test which is the next thing to need to work for progress on #56737

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611833 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Jul 2014 22:50:54 +0000 (22:50 +0000)]

Bit more towards XSSF name support for #56737, will need some deeper changes though to fully implement

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611830 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Jul 2014 22:48:59 +0000 (22:48 +0000)]

Initial support for XSSF External Links tables, which hold references to other workbooks referenced by formulas and names. #56744

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611828 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Jul 2014 18:30:54 +0000 (18:30 +0000)]

Leave part disabled for now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611755 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Jul 2014 18:30:16 +0000 (18:30 +0000)]

Start to support formula parsing of sheet-specified named ranges, required for a full fix to bug #56737

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611753 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Jul 2014 17:27:37 +0000 (17:27 +0000)]

Update bug reference numbers, and bring over part of a test from unfixed that is now working (rest remains broken)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611728 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Jul 2014 16:58:38 +0000 (16:58 +0000)]

Have WorkbookEvaluator process NameXPtgs, rather than returning a NameXEval which later places didn't handle. Largely allows us to process the .xls version of the test file for #56737 (but filenames aren't quite the same as in Excel)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611711 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 18 Jul 2014 15:59:55 +0000 (15:59 +0000)]

#56737 Sometimes Excel writes an internal reference to a local name in an odd way, without an ExternalNameRecord, try to detect and work around those

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611681 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 17 Jul 2014 16:18:39 +0000 (16:18 +0000)]

Add disabled unit tests for bug #56737, which currently fails (differently) for HSSF and XSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611400 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 14 Jul 2014 18:53:39 +0000 (18:53 +0000)]

Fix for #56702 - If a cell is of type numeric but has an empty <v/> tag, return as 0

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1610482 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 3 Jul 2014 14:46:32 +0000 (14:46 +0000)]

This bug has been fixed, so re-enable the unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607662 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 3 Jul 2014 14:30:47 +0000 (14:30 +0000)]

Add a disabled unit test for bug #56420

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607661 13f79535-47bb-0310-9956-ffa450edef68