]> source.dussan.org Git - sonarqube.git/log
sonarqube.git
12 months agoSONAR-20424 - Store rules impact within issue
antoine.vinot [Tue, 12 Sep 2023 14:59:23 +0000 (16:59 +0200)]
SONAR-20424 - Store rules impact within issue

12 months agoSONAR-20480 Fix security hotspot code snippet header border thickness
7PH [Wed, 20 Sep 2023 14:04:01 +0000 (16:04 +0200)]
SONAR-20480 Fix security hotspot code snippet header border thickness

12 months agoSONAR-20511 Fix multiline syntax highlighting in rule description line diffs
Ambroise C [Tue, 19 Sep 2023 14:35:41 +0000 (16:35 +0200)]
SONAR-20511 Fix multiline syntax highlighting in rule description line diffs

12 months agoSONAR-20496 Make smooth ecperience of security hotspots header when scroll
stanislavh [Tue, 19 Sep 2023 09:40:30 +0000 (11:40 +0200)]
SONAR-20496 Make smooth ecperience of security hotspots header when scroll

12 months agoSONAR-20336 Users page - change wording on managed info banner
Viktor Vorona [Wed, 20 Sep 2023 09:51:35 +0000 (11:51 +0200)]
SONAR-20336 Users page - change wording on managed info banner

12 months agoSONAR-20348 Improve axios + cover users endpoints with axios
Viktor Vorona [Fri, 15 Sep 2023 14:01:11 +0000 (16:01 +0200)]
SONAR-20348 Improve axios + cover users endpoints with axios

12 months agoSONAR-20481 fixed the issue where removing a branch was removing a project too
lukasz-jarocki-sonarsource [Tue, 19 Sep 2023 14:42:51 +0000 (16:42 +0200)]
SONAR-20481 fixed the issue where removing a branch was removing a project too

12 months agoNO-JIRA make test independent of running container
Steve Marion [Wed, 20 Sep 2023 08:23:36 +0000 (10:23 +0200)]
NO-JIRA make test independent of running container

12 months agoSONAR-20447 Add new "Open in IDE" button for Issues
David Cho-Lerat [Tue, 19 Sep 2023 12:38:14 +0000 (14:38 +0200)]
SONAR-20447 Add new "Open in IDE" button for Issues

12 months agoSONAR-20475 Ignore allowUsersToSignUp parameter on managed instance
Antoine Vigneau [Tue, 19 Sep 2023 10:18:47 +0000 (12:18 +0200)]
SONAR-20475 Ignore allowUsersToSignUp parameter on managed instance

12 months ago[NO JIRA] Custom eslint rule to not allow imports from api folder
Viktor Vorona [Tue, 5 Sep 2023 12:48:29 +0000 (14:48 +0200)]
[NO JIRA] Custom eslint rule to not allow imports from api folder

12 months agoSONAR-20482 Fix flaky FE tests QualityProfileApp-it.tsx
David Cho-Lerat [Fri, 15 Sep 2023 15:33:19 +0000 (17:33 +0200)]
SONAR-20482 Fix flaky FE tests QualityProfileApp-it.tsx

12 months agoSONAR-20297 Adjust styles for CCT tour component
stanislavh [Mon, 18 Sep 2023 12:09:19 +0000 (14:09 +0200)]
SONAR-20297 Adjust styles for CCT tour component

12 months agoSONAR-20337 Validation fixes for QG
Kevin Silva [Mon, 18 Sep 2023 09:41:23 +0000 (11:41 +0200)]
SONAR-20337 Validation fixes for QG

12 months agoSONAR-20337 Layout changes for quality gate main content
Revanshu Paliwal [Thu, 14 Sep 2023 14:36:01 +0000 (16:36 +0200)]
SONAR-20337 Layout changes for quality gate main content

12 months agoSONAR-20337 Migrating quality gate header to MIUI
Revanshu Paliwal [Thu, 14 Sep 2023 08:52:57 +0000 (10:52 +0200)]
SONAR-20337  Migrating quality gate header to MIUI

12 months agoSONAR-20337 Fixing formatting error
Revanshu Paliwal [Thu, 14 Sep 2023 08:56:49 +0000 (10:56 +0200)]
SONAR-20337 Fixing formatting error

12 months agoSONAR-20337 - Quality gate project list adopts new UI
Kevin Silva [Mon, 11 Sep 2023 16:39:19 +0000 (17:39 +0100)]
SONAR-20337 - Quality gate project list adopts new UI

12 months agoSONAR-20337 Updating modals for quality gate's conditions
Revanshu Paliwal [Mon, 11 Sep 2023 15:46:51 +0000 (17:46 +0200)]
SONAR-20337 Updating modals for quality gate's conditions

12 months agoSONAR-20337 - Quality gate left menu should adpot new uI
Kevin Silva [Tue, 5 Sep 2023 15:13:00 +0000 (17:13 +0200)]
SONAR-20337 - Quality gate left menu should adpot new uI

12 months agoSONAR-20337 Migrating quality gate condition list to adopt new UI
Revanshu Paliwal [Tue, 5 Sep 2023 10:56:28 +0000 (12:56 +0200)]
SONAR-20337 Migrating quality gate condition list to adopt new UI

12 months agoSONAR-20337 migrate Permissions section to new UI
Jeremy Davis [Tue, 5 Sep 2023 13:07:01 +0000 (15:07 +0200)]
SONAR-20337 migrate Permissions section to new UI

12 months agoSONAR-20487 Fix dropdown accessibility and drop isPortal usage
7PH [Mon, 18 Sep 2023 12:18:07 +0000 (14:18 +0200)]
SONAR-20487 Fix dropdown accessibility and drop isPortal usage

12 months agoNO-JIRA Remove `eslint-local-rules` symlink in design-system
Ambroise C [Mon, 18 Sep 2023 12:07:28 +0000 (14:07 +0200)]
NO-JIRA Remove `eslint-local-rules` symlink in design-system

12 months agoSONAR-20486 Fix 10.2 migration on MSSQL, when auto-provisioning is ON
Aurelien Poscia [Mon, 18 Sep 2023 07:30:01 +0000 (09:30 +0200)]
SONAR-20486 Fix 10.2 migration on MSSQL, when auto-provisioning is ON

12 months agoSONAR-20382 Prevent page from refreshing
Jeremy Davis [Mon, 18 Sep 2023 09:04:19 +0000 (11:04 +0200)]
SONAR-20382 Prevent page from refreshing

12 months agoUpdate README with new Clean code link from Marketing
David Cho-Lerat [Fri, 15 Sep 2023 15:57:40 +0000 (17:57 +0200)]
Update README with new Clean code link from Marketing

13 months agoSONAR-20366 Fix disabled option styling
Wouter Admiraal [Fri, 15 Sep 2023 14:33:41 +0000 (16:33 +0200)]
SONAR-20366 Fix disabled option styling

13 months ago[NO JIRA] Don't allow a profile to select itself as parent
Wouter Admiraal [Fri, 15 Sep 2023 14:27:13 +0000 (16:27 +0200)]
[NO JIRA] Don't allow a profile to select itself as parent

13 months agoSONAR-20355 Update quality profile BBT to test rule deactivation
7PH [Fri, 15 Sep 2023 11:57:12 +0000 (13:57 +0200)]
SONAR-20355 Update quality profile BBT to test rule deactivation

13 months agoSONAR-20392 Update wording
Viktor Vorona [Fri, 15 Sep 2023 13:15:59 +0000 (15:15 +0200)]
SONAR-20392 Update wording

13 months ago SONAR-20359 add quality profile to projects in telemetry
Benjamin Campomenosi [Fri, 15 Sep 2023 14:20:23 +0000 (16:20 +0200)]
 SONAR-20359 add quality profile to projects in telemetry

13 months agoSONAR-20392 Web API v2 doc improvement with new PATCH media type
Viktor Vorona [Fri, 15 Sep 2023 09:42:23 +0000 (11:42 +0200)]
SONAR-20392 Web API v2 doc improvement with new PATCH media type

13 months agoSONAR-20392 Do not show save when setting is set to initial state in GitHub Authentic...
Mathieu Suen [Fri, 15 Sep 2023 07:30:57 +0000 (09:30 +0200)]
SONAR-20392 Do not show save when setting is set to initial state in GitHub Authentication page

13 months agoSONAR-20392 Avoid saving additional settings when switching GitHub provisioning mode
Mathieu Suen [Thu, 14 Sep 2023 14:11:08 +0000 (16:11 +0200)]
SONAR-20392 Avoid saving additional settings when switching GitHub provisioning mode

13 months agoSONAR-20392 Add Edit mapping button for auto-provisioning
Viktor Vorona [Wed, 13 Sep 2023 09:54:16 +0000 (11:54 +0200)]
SONAR-20392 Add Edit mapping button for auto-provisioning

13 months agoSONAR-20392: Mapping modal
Viktor Vorona [Tue, 12 Sep 2023 12:27:07 +0000 (14:27 +0200)]
SONAR-20392: Mapping modal

13 months agoNO-JIRA fix json merge patch content type
Aurelien Poscia [Thu, 14 Sep 2023 12:52:00 +0000 (14:52 +0200)]
NO-JIRA fix json merge patch content type

13 months agoSONAR-20392 Add API v2 endpoint to update GitHub permission mapping.
Wojtek Wajerowicz [Wed, 13 Sep 2023 13:30:09 +0000 (15:30 +0200)]
SONAR-20392 Add API v2 endpoint to update GitHub permission mapping.

13 months agoSONAR-20392 Add apiv2 endpoint to fetch the Github permissions mapping
Antoine Vigneau [Mon, 11 Sep 2023 18:10:50 +0000 (20:10 +0200)]
SONAR-20392 Add apiv2 endpoint to fetch the Github permissions mapping

13 months agoSONAR-20392 Add events to audit logs when GH permissions mapping change
Aurelien Poscia [Mon, 11 Sep 2023 09:35:03 +0000 (11:35 +0200)]
SONAR-20392 Add events to audit logs when GH permissions mapping change

13 months agoSONAR-20392 Added GithubPermissionsMapping[Dao|Dto]
Aurelien Poscia [Wed, 6 Sep 2023 14:09:43 +0000 (16:09 +0200)]
SONAR-20392 Added GithubPermissionsMapping[Dao|Dto]

13 months agoSONAR-20392 Add default mappings in github_perms_mapping
Aurelien Poscia [Fri, 8 Sep 2023 10:05:00 +0000 (12:05 +0200)]
SONAR-20392 Add default mappings in github_perms_mapping

13 months agoSONAR-20392 Add github_perms_mapping table and unique index
Aurelien Poscia [Wed, 6 Sep 2023 13:40:04 +0000 (15:40 +0200)]
SONAR-20392 Add github_perms_mapping table and unique index

13 months agoNO-JIRA remove empty warn log assertion in test
Steve Marion [Fri, 15 Sep 2023 09:13:34 +0000 (11:13 +0200)]
NO-JIRA remove empty warn log assertion in test

13 months agoRevert "BUILD-2798 Implement suggested workaround for false positive in Travis CI"
Jeremy Davis [Tue, 12 Sep 2023 07:29:47 +0000 (09:29 +0200)]
Revert "BUILD-2798 Implement suggested workaround for false positive in Travis CI"

This reverts commits:
 - 32640f7dafa09f44dd85e552c70cc3493c24b086
 - 0a49278b4e6cacd9144e7149c116ad321ab0dd43
 - 1e4dfec8ec79a503d29ab1d9b9f2b9105d912ab9

13 months agoNO-JIRA raise yarn_check memory
Steve Marion [Fri, 15 Sep 2023 08:50:50 +0000 (10:50 +0200)]
NO-JIRA raise yarn_check memory

13 months agoSONAR-20355 Show deactivate button in rule details as well
Wouter Admiraal [Thu, 14 Sep 2023 11:15:18 +0000 (13:15 +0200)]
SONAR-20355 Show deactivate button in rule details as well

13 months agoSONAR-20355 Show warning when changing parent profile
Wouter Admiraal [Thu, 14 Sep 2023 09:56:04 +0000 (11:56 +0200)]
SONAR-20355 Show warning when changing parent profile

13 months agoSONAR-20356 Add message in QP copy, extend and create modal to warn user when a QP...
7PH [Thu, 14 Sep 2023 04:32:08 +0000 (06:32 +0200)]
SONAR-20356 Add message in QP copy, extend and create modal to warn user when a QP will not inherit from a built-in

13 months agoSONAR-20268 fix property enabling
Steve Marion [Thu, 14 Sep 2023 09:45:41 +0000 (11:45 +0200)]
SONAR-20268 fix property enabling

13 months agoSONAR-20355 Enable Desactivate button for inherited rules if allowed by settings
Wouter Admiraal [Tue, 12 Sep 2023 13:30:23 +0000 (15:30 +0200)]
SONAR-20355 Enable Desactivate button for inherited rules if allowed by settings

Co-authored-by: Benjamin Raymond <31401273+7PH@users.noreply.github.com>
13 months agoNO-JIRA Fix code smells in new code
Ambroise C [Thu, 14 Sep 2023 08:25:36 +0000 (10:25 +0200)]
NO-JIRA Fix code smells in new code

13 months agoSONAR-20359 Add quality profiles to telemetry data
Léo Geoffroy [Fri, 8 Sep 2023 13:31:08 +0000 (15:31 +0200)]
SONAR-20359 Add quality profiles to telemetry data

13 months agoSONAR-20355 Enable deactivation of inherited rules
Eric Giffon [Fri, 8 Sep 2023 10:24:21 +0000 (12:24 +0200)]
SONAR-20355 Enable deactivation of inherited rules

13 months agoSONAR-20355 Add and initialize property sonar.qualityProfiles.allowDisableInheritedRules
Benjamin Campomenosi [Wed, 13 Sep 2023 09:02:55 +0000 (11:02 +0200)]
SONAR-20355 Add and initialize property sonar.qualityProfiles.allowDisableInheritedRules

13 months agoSONAR-20327 Fix code smells following prettier upgrades
Ambroise C [Wed, 13 Sep 2023 15:24:05 +0000 (17:24 +0200)]
SONAR-20327 Fix code smells following prettier upgrades

Co-authored-by: David Cho-Lerat <david.cho-lerat@sonarsource.com>
13 months agoFix typo
David Cho-Lerat [Wed, 13 Sep 2023 13:45:07 +0000 (15:45 +0200)]
Fix typo

13 months agoSQDEVOPS-225 add datadog vault secret
jeremy cotineau [Wed, 6 Sep 2023 07:18:42 +0000 (09:18 +0200)]
SQDEVOPS-225 add datadog vault secret

13 months agoSONAR-20364 Migrate SelectList component to new UI
Jeremy Davis [Wed, 6 Sep 2023 15:56:30 +0000 (17:56 +0200)]
SONAR-20364 Migrate SelectList component to new UI

13 months agoSONAR-20393 Add provision project visibility option on auto provisioning
Mathieu Suen [Tue, 12 Sep 2023 13:44:08 +0000 (15:44 +0200)]
SONAR-20393 Add provision project visibility option on auto provisioning

13 months agoSONAR-20356 Add built-in QP encouragement flag message in quality profile page
7PH [Mon, 11 Sep 2023 11:42:52 +0000 (13:42 +0200)]
SONAR-20356 Add built-in QP encouragement flag message in quality profile page

13 months agoSONAR-20366 Migrate quality profile individual QP page to new UI
7PH [Mon, 11 Sep 2023 02:44:27 +0000 (04:44 +0200)]
SONAR-20366 Migrate quality profile individual QP page to new UI

13 months agoSONAR-20393 allow to deactivate GH project visibility sync
Aurelien Poscia [Mon, 11 Sep 2023 13:35:22 +0000 (15:35 +0200)]
SONAR-20393 allow to deactivate GH project visibility sync

13 months agoNO-JIRA fix typo
Pierre [Tue, 12 Sep 2023 07:26:47 +0000 (09:26 +0200)]
NO-JIRA fix typo

13 months agoSONAR-20327 Reduce cognitive complexity of function
David Cho-Lerat [Thu, 7 Sep 2023 15:28:36 +0000 (17:28 +0200)]
SONAR-20327 Reduce cognitive complexity of function

13 months agoSONAR-20327 Run new version of prettier on all files
Ambroise C [Mon, 11 Sep 2023 17:25:35 +0000 (19:25 +0200)]
SONAR-20327 Run new version of prettier on all files

13 months agoSONAR-20327 Upgrade FE dependency prettier
Ambroise C [Mon, 11 Sep 2023 17:24:49 +0000 (19:24 +0200)]
SONAR-20327 Upgrade FE dependency prettier

13 months agoSONAR-20451 Fix flakyness of RatioBasedRateLimitCheckerTest.checkRateLimit
Aurelien Poscia [Tue, 12 Sep 2023 09:34:46 +0000 (11:34 +0200)]
SONAR-20451 Fix flakyness of RatioBasedRateLimitCheckerTest.checkRateLimit

13 months agoSONAR-20402 Align authentication settings card verticaly
Mathieu Suen [Mon, 11 Sep 2023 10:05:25 +0000 (12:05 +0200)]
SONAR-20402 Align authentication settings card verticaly

13 months agoSONAR-20366 Migrate profile Delete modal to MIUI
Wouter Admiraal [Mon, 11 Sep 2023 08:32:58 +0000 (10:32 +0200)]
SONAR-20366 Migrate profile Delete modal to MIUI

13 months agoSONAR-20366 Migrate profile Change Parent modal to MIUI
Wouter Admiraal [Tue, 5 Sep 2023 15:13:52 +0000 (17:13 +0200)]
SONAR-20366 Migrate profile Change Parent modal to MIUI

13 months agoSONAR-20366 Migrate profile Copy/Extend/Rename modal to MIUI
Wouter Admiraal [Tue, 5 Sep 2023 14:57:52 +0000 (16:57 +0200)]
SONAR-20366 Migrate profile Copy/Extend/Rename modal to MIUI

13 months agoSONAR-20327 Upgrade FE dependency vite-plugin-dts
Ambroise C [Wed, 6 Sep 2023 15:04:28 +0000 (17:04 +0200)]
SONAR-20327 Upgrade FE dependency vite-plugin-dts

13 months agoSONAR-20327 Upgrade FE dependency jsdom
Ambroise C [Wed, 6 Sep 2023 14:31:00 +0000 (16:31 +0200)]
SONAR-20327 Upgrade FE dependency jsdom

13 months agoSONAR-20327 Upgrade FE dependency jest-axe
Ambroise C [Wed, 6 Sep 2023 14:02:32 +0000 (16:02 +0200)]
SONAR-20327 Upgrade FE dependency jest-axe

13 months agoBUILD-3759 Run Mend scan with the nightly cron
Philippe Perrin [Mon, 11 Sep 2023 09:44:06 +0000 (11:44 +0200)]
BUILD-3759 Run Mend scan with the nightly cron

13 months agoSONAR-20430 fix flaky elasticsearch test by simplifying the test to only verify we...
Pierre [Mon, 11 Sep 2023 09:39:11 +0000 (11:39 +0200)]
SONAR-20430 fix flaky elasticsearch test by simplifying the test to only verify we use the correct es client parameters, without testing elasticsearch itself

13 months agoSONAR-20328 Update com.h2database:h2 to 2.2.2.222
Matteo Mara [Mon, 11 Sep 2023 07:55:00 +0000 (09:55 +0200)]
SONAR-20328 Update com.h2database:h2 to 2.2.2.222

13 months agoSONAR-20421 Fix telemetry measures not fetched from main branch
Léo Geoffroy [Fri, 8 Sep 2023 09:28:02 +0000 (11:28 +0200)]
SONAR-20421 Fix telemetry measures not fetched from main branch

13 months agoNO-JIRA Fix quality gate failure
Léo Geoffroy [Fri, 8 Sep 2023 08:57:40 +0000 (10:57 +0200)]
NO-JIRA Fix quality gate failure

13 months agoSONAR-20328 upgrade jfrog artifactory
Pierre Guillot [Fri, 8 Sep 2023 10:36:20 +0000 (12:36 +0200)]
SONAR-20328 upgrade jfrog artifactory

13 months agoUpdate eslint-plugin-local-rules to 2.0.0
David Cho-Lerat [Thu, 7 Sep 2023 09:43:54 +0000 (11:43 +0200)]
Update eslint-plugin-local-rules to 2.0.0

13 months agoNO-JIRA Harden QGChangeEventListenersImplTest usage of LogTester
antoine.vinot [Thu, 7 Sep 2023 08:22:58 +0000 (10:22 +0200)]
NO-JIRA Harden QGChangeEventListenersImplTest usage of LogTester

13 months agoSONAR-20328 Upgrade sonar-orchestrator version and update affected tests from breakin...
Dimitris Kavvathas [Wed, 6 Sep 2023 13:44:34 +0000 (15:44 +0200)]
SONAR-20328 Upgrade sonar-orchestrator version and update affected tests from breaking changes.

13 months agoSONAR-20328 Update org.kohsuke:github-api to 1.316
Matteo Mara [Wed, 6 Sep 2023 13:15:04 +0000 (15:15 +0200)]
SONAR-20328 Update org.kohsuke:github-api to 1.316

13 months agoSONAR-20328 Update org.yaml:snakeyaml to 2.2
Matteo Mara [Wed, 6 Sep 2023 13:14:46 +0000 (15:14 +0200)]
SONAR-20328 Update org.yaml:snakeyaml to 2.2

13 months agoSONAR-20328 Update org.slf4j to 2.0.9
Matteo Mara [Wed, 6 Sep 2023 13:13:45 +0000 (15:13 +0200)]
SONAR-20328 Update org.slf4j to 2.0.9

13 months agoSONAR-20328 Update org.mockito:mockito-core to 5.5.0
Matteo Mara [Wed, 6 Sep 2023 13:13:20 +0000 (15:13 +0200)]
SONAR-20328 Update org.mockito:mockito-core to 5.5.0

13 months agoSONAR-20328 Update commons-codec:commons-codec to 1.16.0
Matteo Mara [Wed, 6 Sep 2023 13:13:02 +0000 (15:13 +0200)]
SONAR-20328 Update commons-codec:commons-codec to 1.16.0

13 months agoSONAR-20328 Update commons-dbutils:commons-dbutils to 1.8.0
Matteo Mara [Wed, 6 Sep 2023 13:12:46 +0000 (15:12 +0200)]
SONAR-20328 Update commons-dbutils:commons-dbutils to 1.8.0

13 months agoSONAR-20328 Update org.eclipse.jgit:org.eclipse.jgit to 6.6.1.202309021850-r
Matteo Mara [Wed, 6 Sep 2023 13:12:12 +0000 (15:12 +0200)]
SONAR-20328 Update org.eclipse.jgit:org.eclipse.jgit to 6.6.1.202309021850-r

13 months agoSONAR-20328 Update org.elasticsearch.plugin:transport-netty4-client to 7.17.12
Matteo Mara [Wed, 6 Sep 2023 13:11:53 +0000 (15:11 +0200)]
SONAR-20328 Update org.elasticsearch.plugin:transport-netty4-client to 7.17.12

13 months agoSONAR-20328 Update org.elasticsearch.client:elasticsearch-rest-high-level-client...
Matteo Mara [Wed, 6 Sep 2023 13:11:18 +0000 (15:11 +0200)]
SONAR-20328 Update org.elasticsearch.client:elasticsearch-rest-high-level-client to 7.17.12

13 months agoSONAR-20328 Update io.netty:netty-all to 4.1.97.Final
Matteo Mara [Wed, 6 Sep 2023 13:10:55 +0000 (15:10 +0200)]
SONAR-20328 Update io.netty:netty-all to 4.1.97.Final

13 months agoSONAR-20328 Update org.aspectj to 1.9.20.1
Matteo Mara [Wed, 6 Sep 2023 13:10:34 +0000 (15:10 +0200)]
SONAR-20328 Update org.aspectj to 1.9.20.1

13 months agoSONAR-20328 Update org.bouncycastle:bcpkix-jdk18on to 1.76
Matteo Mara [Wed, 6 Sep 2023 13:09:46 +0000 (15:09 +0200)]
SONAR-20328 Update org.bouncycastle:bcpkix-jdk18on to 1.76

13 months agoSONAR-20328 Update com.microsoft.sqlserver:mssql-jdbc to 12.4.1.jre11
Matteo Mara [Wed, 6 Sep 2023 13:06:22 +0000 (15:06 +0200)]
SONAR-20328 Update com.microsoft.sqlserver:mssql-jdbc to 12.4.1.jre11

13 months agoSONAR-20328 Update com.hazelcast to 5.3.2
Matteo Mara [Wed, 6 Sep 2023 13:06:02 +0000 (15:06 +0200)]
SONAR-20328 Update com.hazelcast to 5.3.2

13 months agoSONAR-20328 Update com.squareup.okio:okio to 3.5.0
Matteo Mara [Wed, 6 Sep 2023 13:05:43 +0000 (15:05 +0200)]
SONAR-20328 Update com.squareup.okio:okio to 3.5.0