]> source.dussan.org Git - poi.git/log
poi.git
7 years agoSonarCube fixes
Andreas Beeker [Sat, 12 Nov 2016 00:52:10 +0000 (00:52 +0000)]
SonarCube fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769366 13f79535-47bb-0310-9956-ffa450edef68

7 years ago- SonarCube fixes
Andreas Beeker [Fri, 11 Nov 2016 23:22:43 +0000 (23:22 +0000)]
- SonarCube fixes
- moved SecureTempFile classes to OOXML, because of duplicated code in test and examples packages

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769363 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60345 - Handle corrupt PICT streams
Andreas Beeker [Thu, 10 Nov 2016 23:04:25 +0000 (23:04 +0000)]
Bug 60345 - Handle corrupt PICT streams

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769226 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 59273 - Unable to create pptx file by potx file using Apache POI
Andreas Beeker [Thu, 10 Nov 2016 22:54:07 +0000 (22:54 +0000)]
Bug 59273 - Unable to create pptx file by potx file using Apache POI

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769220 13f79535-47bb-0310-9956-ffa450edef68

7 years agoKEYS file should only have public keys used to sign previous releases
Javen O'Neal [Wed, 9 Nov 2016 08:57:26 +0000 (08:57 +0000)]
KEYS file should only have public keys used to sign previous releases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768877 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 60321: add examples with encrypted temp data. Patch from PJ Fanning.
Javen O'Neal [Tue, 8 Nov 2016 17:32:38 +0000 (17:32 +0000)]
bug 60321: add examples with encrypted temp data. Patch from PJ Fanning.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768744 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd a way to exclude tests via Ant-properties, needed to check if ooxml-tests run...
Dominik Stadler [Mon, 7 Nov 2016 21:32:22 +0000 (21:32 +0000)]
Add a way to exclude tests via Ant-properties, needed to check if ooxml-tests run without scratchpad (except TestExtractorFactory)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768591 13f79535-47bb-0310-9956-ffa450edef68

7 years agoPull up one more test into BaseTestConditionalFormatting
Dominik Stadler [Mon, 7 Nov 2016 21:32:18 +0000 (21:32 +0000)]
Pull up one more test into BaseTestConditionalFormatting

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768590 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdjust imports, fix some Javadoc issues and ignore deprecation warnings in tests
Dominik Stadler [Mon, 7 Nov 2016 21:32:12 +0000 (21:32 +0000)]
Adjust imports, fix some Javadoc issues and ignore deprecation warnings in tests
Exclude some more non-tests in OOXMLLite

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768589 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd setFormattingRanges() to interface ConditionalFormatting, closes #42
Dominik Stadler [Mon, 7 Nov 2016 21:32:04 +0000 (21:32 +0000)]
Add setFormattingRanges() to interface ConditionalFormatting, closes #42

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768588 13f79535-47bb-0310-9956-ffa450edef68

7 years agoExample AligningCells: Use int instead of short for column-index, closes Github #35
Dominik Stadler [Mon, 7 Nov 2016 20:50:10 +0000 (20:50 +0000)]
Example AligningCells: Use int instead of short for column-index, closes Github #35
Also use more of the base classes where possible

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768584 13f79535-47bb-0310-9956-ffa450edef68

7 years agoPOI-60341, add test document (ugh, mea culpa), turn on test.
Tim Allison [Mon, 7 Nov 2016 12:10:46 +0000 (12:10 +0000)]
POI-60341, add test document (ugh, mea culpa), turn on test.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768505 13f79535-47bb-0310-9956-ffa450edef68

7 years agoMove XWPF examples to new package to clean up code coverage
Mark Murphy [Mon, 7 Nov 2016 05:35:18 +0000 (05:35 +0000)]
Move XWPF examples to new package to clean up code coverage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768437 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60337: XWPFTableRow.isRepeatHeader throws NullPointerException, setRepeatHeader does...
Mark Murphy [Sat, 5 Nov 2016 06:12:24 +0000 (06:12 +0000)]
60337: XWPFTableRow.isRepeatHeader throws NullPointerException, setRepeatHeader does not overwrite old value

Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=60337

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768153 13f79535-47bb-0310-9956-ffa450edef68

7 years agoPOI-60342: handle missing sdtcontentcell in an sdtcell
Tim Allison [Fri, 4 Nov 2016 15:21:51 +0000 (15:21 +0000)]
POI-60342: handle missing sdtcontentcell in an sdtcell

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768054 13f79535-47bb-0310-9956-ffa450edef68

7 years agoPOI-60341: handle missing sdtpr in an sdtbody
Tim Allison [Fri, 4 Nov 2016 15:06:17 +0000 (15:06 +0000)]
POI-60341: handle missing sdtpr in an sdtbody

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768048 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAs requested on StackOverflow, expose on CellStyle QuotePrefix/123Prefix
Nick Burch [Fri, 4 Nov 2016 11:11:09 +0000 (11:11 +0000)]
As requested on StackOverflow, expose on CellStyle QuotePrefix/123Prefix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768012 13f79535-47bb-0310-9956-ffa450edef68

7 years agoMore unit testing for XWPF list numbering complex cases, and some TODOs on improving...
Nick Burch [Fri, 4 Nov 2016 10:55:31 +0000 (10:55 +0000)]
More unit testing for XWPF list numbering complex cases, and some TODOs on improving it, inspired by users@ discussions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768005 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 60331: remove deprecated FormulaShifter.createForRowShift(). Require SpreadsheetV...
Javen O'Neal [Wed, 2 Nov 2016 16:37:12 +0000 (16:37 +0000)]
bug 60331: remove deprecated FormulaShifter.createForRowShift(). Require SpreadsheetVersion.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767728 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 60331: remove deprecated EntryUtils.copyNodes( DirectoryEntry, DirectoryEntry...
Javen O'Neal [Wed, 2 Nov 2016 16:25:18 +0000 (16:25 +0000)]
bug 60331: remove deprecated EntryUtils.copyNodes( DirectoryEntry, DirectoryEntry, List<String> excepts). Use EntryUtils.copyNodes( FilteringDirectoryEntry, FilteringDirectoryEntry ) instead.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767716 13f79535-47bb-0310-9956-ffa450edef68

7 years agoshow example of equivalent EntryUtils.copyNodes using FilteringDirectoryNode instead...
Javen O'Neal [Wed, 2 Nov 2016 16:22:04 +0000 (16:22 +0000)]
show example of equivalent EntryUtils.copyNodes using FilteringDirectoryNode instead of DirectoryNode with excepts list

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767715 13f79535-47bb-0310-9956-ffa450edef68

7 years agoHandle null returns of coerceValueToBoolean
Andreas Beeker [Tue, 1 Nov 2016 10:52:20 +0000 (10:52 +0000)]
Handle null returns of coerceValueToBoolean

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767474 13f79535-47bb-0310-9956-ffa450edef68

7 years agofindbugs fix
Andreas Beeker [Tue, 1 Nov 2016 10:29:02 +0000 (10:29 +0000)]
findbugs fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767473 13f79535-47bb-0310-9956-ffa450edef68

7 years agofindbugs fix
Andreas Beeker [Tue, 1 Nov 2016 09:24:50 +0000 (09:24 +0000)]
findbugs fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767457 13f79535-47bb-0310-9956-ffa450edef68

7 years agoJCE policy assumption fix
Andreas Beeker [Tue, 1 Nov 2016 09:18:55 +0000 (09:18 +0000)]
JCE policy assumption fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767456 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60320 - issue opening password protected xlsx
Andreas Beeker [Tue, 1 Nov 2016 01:30:48 +0000 (01:30 +0000)]
Bug 60320 - issue opening password protected xlsx

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767399 13f79535-47bb-0310-9956-ffa450edef68

7 years agoremove println
Tim Allison [Mon, 31 Oct 2016 19:03:06 +0000 (19:03 +0000)]
remove println

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767354 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60293 -- Handle illegal "Odd" header/footer in XWPF
Tim Allison [Mon, 31 Oct 2016 19:02:06 +0000 (19:02 +0000)]
60293 -- Handle illegal "Odd" header/footer in XWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767353 13f79535-47bb-0310-9956-ffa450edef68

7 years ago57366: XWPFTable to Header / Footer
Mark Murphy [Sun, 30 Oct 2016 18:49:16 +0000 (18:49 +0000)]
57366: XWPFTable to Header / Footer

Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=57366

This update contains a breaking change

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767175 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 53611: populate dimension of XSSF Worksheet when writing the document
Dominik Stadler [Sat, 29 Oct 2016 07:38:46 +0000 (07:38 +0000)]
Bug 53611: populate dimension of XSSF Worksheet when writing the document

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767096 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 59026: Add two null-checks to make exporting XLSX to XML work
Dominik Stadler [Fri, 28 Oct 2016 18:24:04 +0000 (18:24 +0000)]
Bug 59026: Add two null-checks to make exporting XLSX to XML work

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767057 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60315 -- allow 'yyyy-MM-dd' as a valid date format in metadata in OPCParser
Tim Allison [Fri, 28 Oct 2016 14:11:52 +0000 (14:11 +0000)]
60315 -- allow 'yyyy-MM-dd' as a valid date format in metadata in OPCParser

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767026 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60305 -- gracefully handle truncated images while reading pictstream
Tim Allison [Fri, 28 Oct 2016 13:39:40 +0000 (13:39 +0000)]
60305 -- gracefully handle truncated images while reading pictstream

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767023 13f79535-47bb-0310-9956-ffa450edef68

7 years agowhitespace clean up before fix for BUG-60305
Tim Allison [Fri, 28 Oct 2016 13:26:49 +0000 (13:26 +0000)]
whitespace clean up before fix for BUG-60305

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767021 13f79535-47bb-0310-9956-ffa450edef68

7 years agowhitespace clean up before fix for BUG-60305
Tim Allison [Fri, 28 Oct 2016 13:25:14 +0000 (13:25 +0000)]
whitespace clean up before fix for BUG-60305

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767020 13f79535-47bb-0310-9956-ffa450edef68

7 years agofix javadocs
Andreas Beeker [Wed, 26 Oct 2016 22:37:34 +0000 (22:37 +0000)]
fix javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766747 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60059 - Deprecate xslf.usermodel.Drawing* - was: Can't change text of DrawingPara...
Andreas Beeker [Wed, 26 Oct 2016 22:32:46 +0000 (22:32 +0000)]
Bug 60059 - Deprecate xslf.usermodel.Drawing* - was: Can't change text of DrawingParagraph

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766746 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix close warnings
Nick Burch [Tue, 25 Oct 2016 10:24:48 +0000 (10:24 +0000)]
Fix close warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766503 13f79535-47bb-0310-9956-ffa450edef68

7 years agoWhitespace
Nick Burch [Tue, 25 Oct 2016 10:23:15 +0000 (10:23 +0000)]
Whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766501 13f79535-47bb-0310-9956-ffa450edef68

7 years agov5 text extraction
Nick Burch [Tue, 25 Oct 2016 10:21:16 +0000 (10:21 +0000)]
v5 text extraction

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766497 13f79535-47bb-0310-9956-ffa450edef68

7 years agoInconsistent whitespace
Nick Burch [Tue, 25 Oct 2016 09:35:28 +0000 (09:35 +0000)]
Inconsistent whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766493 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRefactor child pointer logic to the factory
Nick Burch [Tue, 25 Oct 2016 09:33:37 +0000 (09:33 +0000)]
Refactor child pointer logic to the factory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766492 13f79535-47bb-0310-9956-ffa450edef68

7 years agoWork in progress - v5 pointer containers
Nick Burch [Tue, 25 Oct 2016 09:15:02 +0000 (09:15 +0000)]
Work in progress - v5 pointer containers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766487 13f79535-47bb-0310-9956-ffa450edef68

7 years agoPartial Visio v5 pointer support
Nick Burch [Tue, 25 Oct 2016 07:37:00 +0000 (07:37 +0000)]
Partial Visio v5 pointer support

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766480 13f79535-47bb-0310-9956-ffa450edef68

7 years agoTest visio v5 file from senthil from TIKA-1658
Nick Burch [Tue, 25 Oct 2016 07:14:09 +0000 (07:14 +0000)]
Test visio v5 file from senthil from TIKA-1658

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766478 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdds an example for building headers and footers in XWPF
Mark Murphy [Mon, 24 Oct 2016 23:56:21 +0000 (23:56 +0000)]
Adds an example for building headers and footers in XWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766459 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAllow more time for a unit-test when running on slow Gump VM
Dominik Stadler [Mon, 24 Oct 2016 12:07:15 +0000 (12:07 +0000)]
Allow more time for a unit-test when running on slow Gump VM

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766397 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60294 - Add "unknown" ShapeType for 4095
Andreas Beeker [Sat, 22 Oct 2016 19:34:47 +0000 (19:34 +0000)]
Bug 60294 - Add "unknown" ShapeType for 4095

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766227 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 60289: Fix handling of unicode escapes with lowercase hex-chars
Dominik Stadler [Fri, 21 Oct 2016 16:31:51 +0000 (16:31 +0000)]
Bug 60289: Fix handling of unicode escapes with lowercase hex-chars

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766065 13f79535-47bb-0310-9956-ffa450edef68

7 years agoCorrectly handle all types of old files, not just word
Dominik Stadler [Fri, 21 Oct 2016 16:31:43 +0000 (16:31 +0000)]
Correctly handle all types of old files, not just word

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766064 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix some IDE warnings, JavaDoc, ...
Dominik Stadler [Fri, 21 Oct 2016 16:31:37 +0000 (16:31 +0000)]
Fix some IDE warnings, JavaDoc, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766063 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 60288: remove defensive copy for internal relationships. Patch from Tim Helmstedt...
Javen O'Neal [Fri, 21 Oct 2016 07:29:40 +0000 (07:29 +0000)]
bug 60288: remove defensive copy for internal relationships. Patch from Tim Helmstedt. This closes #38.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765935 13f79535-47bb-0310-9956-ffa450edef68

8 years agofix integration-tests
Andreas Beeker [Thu, 20 Oct 2016 22:31:50 +0000 (22:31 +0000)]
fix integration-tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765900 13f79535-47bb-0310-9956-ffa450edef68

8 years agoExclude new BIFF5 file in some unit tests
Dominik Stadler [Thu, 20 Oct 2016 20:31:57 +0000 (20:31 +0000)]
Exclude new BIFF5 file in some unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765876 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd some missing close() calls
Dominik Stadler [Thu, 20 Oct 2016 20:31:50 +0000 (20:31 +0000)]
Add some missing close() calls

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765875 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG-60286 avoid NPE XWPFRun. Didn't add unit test or document...didn't seem to be...
Tim Allison [Thu, 20 Oct 2016 18:58:47 +0000 (18:58 +0000)]
BUG-60286 avoid NPE XWPFRun.  Didn't add unit test or document...didn't seem to be worth it.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765863 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG-60285 avoid NPE if missing relationship id
Tim Allison [Thu, 20 Oct 2016 18:45:03 +0000 (18:45 +0000)]
BUG-60285 avoid NPE if missing relationship id

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765861 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG-60284 -- need to update dev tests <face_palm/>
Tim Allison [Thu, 20 Oct 2016 18:39:47 +0000 (18:39 +0000)]
BUG-60284 -- need to update dev tests <face_palm/>

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765859 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG-60284 -- throw EncryptedDocumentException for password protected OldExcel files
Tim Allison [Thu, 20 Oct 2016 15:13:16 +0000 (15:13 +0000)]
BUG-60284 -- throw EncryptedDocumentException for password protected OldExcel files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765829 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace
Javen O'Neal [Thu, 20 Oct 2016 02:24:50 +0000 (02:24 +0000)]
whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765741 13f79535-47bb-0310-9956-ffa450edef68

8 years agoupgrade to junit4
Javen O'Neal [Thu, 20 Oct 2016 02:24:17 +0000 (02:24 +0000)]
upgrade to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765740 13f79535-47bb-0310-9956-ffa450edef68

8 years agoEclipse automated refactor/cleanup: add final modifier to private fields to unit...
Javen O'Neal [Thu, 20 Oct 2016 02:21:14 +0000 (02:21 +0000)]
Eclipse automated refactor/cleanup: add final modifier to private fields to unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765739 13f79535-47bb-0310-9956-ffa450edef68

8 years agoclose resource
Javen O'Neal [Thu, 20 Oct 2016 02:05:42 +0000 (02:05 +0000)]
close resource

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765737 13f79535-47bb-0310-9956-ffa450edef68

8 years agoEclipse automated refactor/cleanup: convert for loops to for-each loops
Javen O'Neal [Thu, 20 Oct 2016 01:54:56 +0000 (01:54 +0000)]
Eclipse automated refactor/cleanup: convert for loops to for-each loops

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765736 13f79535-47bb-0310-9956-ffa450edef68

8 years agoremove *_dump directory
Andreas Beeker [Wed, 19 Oct 2016 23:43:42 +0000 (23:43 +0000)]
remove *_dump directory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765734 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 55714 - Background image ignored on slide copy
Andreas Beeker [Wed, 19 Oct 2016 23:25:51 +0000 (23:25 +0000)]
Bug 55714 - Background image ignored on slide copy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765733 13f79535-47bb-0310-9956-ffa450edef68

8 years agoStringUtil.count was renamed to StringUtil.countMatches
Javen O'Neal [Wed, 19 Oct 2016 23:06:35 +0000 (23:06 +0000)]
StringUtil.count was renamed to StringUtil.countMatches

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765732 13f79535-47bb-0310-9956-ffa450edef68

8 years agoEclipse automated refactor/cleanup: convert for loops to for-each loops
Javen O'Neal [Wed, 19 Oct 2016 23:04:39 +0000 (23:04 +0000)]
Eclipse automated refactor/cleanup: convert for loops to for-each loops

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765731 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd StringUtil.count, inspired by Apache Commons Lang StringUtils#countMatches and...
Javen O'Neal [Wed, 19 Oct 2016 23:04:16 +0000 (23:04 +0000)]
add StringUtil.count, inspired by Apache Commons Lang StringUtils#countMatches and Python's str.count(substr)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765730 13f79535-47bb-0310-9956-ffa450edef68

8 years agoEclipse automated refactor/cleanup: convert for loops to for-each loops
Javen O'Neal [Wed, 19 Oct 2016 22:28:07 +0000 (22:28 +0000)]
Eclipse automated refactor/cleanup: convert for loops to for-each loops

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765728 13f79535-47bb-0310-9956-ffa450edef68

8 years agoEclipse automated refactor/cleanup: add missing @Override and @Deprecated annotations
Javen O'Neal [Wed, 19 Oct 2016 21:52:31 +0000 (21:52 +0000)]
Eclipse automated refactor/cleanup: add missing @Override and @Deprecated annotations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765726 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG-59302 --add minimal support for VBAMacro extraction to HSLF; credit to Andreas...
Tim Allison [Wed, 19 Oct 2016 18:44:46 +0000 (18:44 +0000)]
BUG-59302 --add minimal support for VBAMacro extraction to HSLF; credit to Andreas Beeker for this patch.  Problems are mine.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765696 13f79535-47bb-0310-9956-ffa450edef68

8 years agoclose pkg
Javen O'Neal [Wed, 19 Oct 2016 09:04:01 +0000 (09:04 +0000)]
close pkg

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765561 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd @Override decorators to SheetIterator, move code outside of for-loop
Javen O'Neal [Wed, 19 Oct 2016 08:38:19 +0000 (08:38 +0000)]
add @Override decorators to SheetIterator, move code outside of for-loop

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765556 13f79535-47bb-0310-9956-ffa450edef68

8 years agoreenable unit test for bug 58648 that passes now
Javen O'Neal [Wed, 19 Oct 2016 08:03:57 +0000 (08:03 +0000)]
reenable unit test for bug 58648 that passes now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765548 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 60255: use actual number of package parts rather than hard-coding an upper-bound
Javen O'Neal [Wed, 19 Oct 2016 07:47:07 +0000 (07:47 +0000)]
bug 60255: use actual number of package parts rather than hard-coding an upper-bound

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765546 13f79535-47bb-0310-9956-ffa450edef68

8 years agoremove @deprecated annotation from Enum-returning getters. These will be deprecated...
Javen O'Neal [Wed, 19 Oct 2016 07:43:18 +0000 (07:43 +0000)]
remove @deprecated annotation from Enum-returning getters. These will be deprecated after the int-returning getters are removed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765545 13f79535-47bb-0310-9956-ffa450edef68

8 years agodisabled unit tests are now passing for bug 48703
Javen O'Neal [Wed, 19 Oct 2016 07:37:47 +0000 (07:37 +0000)]
disabled unit tests are now passing for bug 48703

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765544 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix some IDE warnings/javadoc/...
Dominik Stadler [Wed, 19 Oct 2016 06:52:44 +0000 (06:52 +0000)]
Fix some IDE warnings/javadoc/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765538 13f79535-47bb-0310-9956-ffa450edef68

8 years agomake code more similar between default case and indexed case
Javen O'Neal [Wed, 19 Oct 2016 06:44:09 +0000 (06:44 +0000)]
make code more similar between default case and indexed case

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765536 13f79535-47bb-0310-9956-ffa450edef68

8 years agoon Windows, a directory cannot contain a file and a directory with the same name
Javen O'Neal [Wed, 19 Oct 2016 05:18:48 +0000 (05:18 +0000)]
on Windows, a directory cannot contain a file and a directory with the same name

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765531 13f79535-47bb-0310-9956-ffa450edef68

8 years agofindbugs: Switch statement found in org.apache.poi.sl.draw.DrawShape.applyTransform...
Javen O'Neal [Wed, 19 Oct 2016 05:07:30 +0000 (05:07 +0000)]
findbugs: Switch statement found in org.apache.poi.sl.draw.DrawShape.applyTransform(Graphics2D) where default case is missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765530 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd data type to UTF_16LE
Javen O'Neal [Wed, 19 Oct 2016 05:06:49 +0000 (05:06 +0000)]
add data type to UTF_16LE

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765529 13f79535-47bb-0310-9956-ffa450edef68

8 years agoremove java.nio.charset.StandardCharsets which is not available until Java 7
Javen O'Neal [Wed, 19 Oct 2016 05:00:07 +0000 (05:00 +0000)]
remove java.nio.charset.StandardCharsets which is not available until Java 7

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765528 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG 60273 -- Use codepageutil to get correct charset in VBAMacroReader
Tim Allison [Tue, 18 Oct 2016 18:24:39 +0000 (18:24 +0000)]
BUG 60273 -- Use codepageutil to get correct charset in VBAMacroReader

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765490 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG 59858 -- avoid npe when there's a collision of record names...doh. Fix unit test.
Tim Allison [Tue, 18 Oct 2016 16:54:12 +0000 (16:54 +0000)]
BUG 59858 -- avoid npe when there's a collision of record names...doh. Fix unit test.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765482 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG 59858 -- avoid npe when there's a collision of record names
Tim Allison [Tue, 18 Oct 2016 16:43:20 +0000 (16:43 +0000)]
BUG 59858 -- avoid npe when there's a collision of record names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765479 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG 59830 -- incorrect reading of unicode stream name
Tim Allison [Tue, 18 Oct 2016 15:47:38 +0000 (15:47 +0000)]
BUG 59830 -- incorrect reading of unicode stream name

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765468 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBUG 60158 -- AIOOBE in VBAMacroReader
Tim Allison [Tue, 18 Oct 2016 12:55:34 +0000 (12:55 +0000)]
BUG 60158 -- AIOOBE in VBAMacroReader

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765433 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 53191 - Problems with line style when converting ppt to png
Andreas Beeker [Sun, 16 Oct 2016 22:48:25 +0000 (22:48 +0000)]
Bug 53191 - Problems with line style when converting ppt to png

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765196 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 60259: Add missing dispose() call
Dominik Stadler [Sat, 15 Oct 2016 19:07:04 +0000 (19:07 +0000)]
Bug 60259: Add missing dispose() call

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765100 13f79535-47bb-0310-9956-ffa450edef68

8 years agoUpdate to japicmp-gradle-plugin:0.1.2 and enable newly added properties
Dominik Stadler [Sat, 15 Oct 2016 07:09:13 +0000 (07:09 +0000)]
Update to japicmp-gradle-plugin:0.1.2 and enable newly added properties

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765020 13f79535-47bb-0310-9956-ffa450edef68

8 years agoClose temp-file in test to not leak file-handles and fail deleting the file on Windows
Dominik Stadler [Sat, 15 Oct 2016 06:54:26 +0000 (06:54 +0000)]
Close temp-file in test to not leak file-handles and fail deleting the file on Windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765019 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 60029: apply suggested fix and fix some IntelliJ warnings
Dominik Stadler [Sat, 15 Oct 2016 06:54:20 +0000 (06:54 +0000)]
Bug 60029: apply suggested fix and fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765018 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 60134: Add initial tasks for running japicmp to the Gradle build
Dominik Stadler [Fri, 14 Oct 2016 20:46:30 +0000 (20:46 +0000)]
Bug 60134: Add initial tasks for running japicmp to the Gradle build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764960 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd length sanity check for length of embedded OLE10Native (BUG 60256)
Tim Allison [Fri, 14 Oct 2016 14:57:29 +0000 (14:57 +0000)]
add length sanity check for length of embedded OLE10Native (BUG 60256)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764927 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd ignored test and triggering document for BUG 60256
Tim Allison [Fri, 14 Oct 2016 13:22:23 +0000 (13:22 +0000)]
add ignored test and triggering document for BUG 60256

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764890 13f79535-47bb-0310-9956-ffa450edef68

8 years agoExclude broken hand-crafted test file
Nick Burch [Fri, 14 Oct 2016 13:03:53 +0000 (13:03 +0000)]
Exclude broken hand-crafted test file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764887 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#60255 When creating a XSSF drawing, find the next available document part, even...
Nick Burch [Fri, 14 Oct 2016 10:44:03 +0000 (10:44 +0000)]
#60255 When creating a XSSF drawing, find the next available document part, even if another type has pinched the next number

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764863 13f79535-47bb-0310-9956-ffa450edef68

8 years agoTest file for #60255
Nick Burch [Fri, 14 Oct 2016 10:39:16 +0000 (10:39 +0000)]
Test file for #60255

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764859 13f79535-47bb-0310-9956-ffa450edef68