]> source.dussan.org Git - poi.git/log
poi.git
8 years agoSome warnings/improvements suggested by IntelliJ
Dominik Stadler [Mon, 18 Jul 2016 09:34:59 +0000 (09:34 +0000)]
Some warnings/improvements suggested by IntelliJ

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68

8 years ago59106: WorkdayFunction does not read the area with holidays correctly to calculate...
Dominik Stadler [Sun, 17 Jul 2016 21:18:27 +0000 (21:18 +0000)]
59106: WorkdayFunction does not read the area with holidays correctly to calculate work days

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753125 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdjust unused local variables to also make FindBugs happy
Dominik Stadler [Sun, 17 Jul 2016 21:18:19 +0000 (21:18 +0000)]
Adjust unused local variables to also make FindBugs happy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753124 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix one more place where stream were left open when an exception is thrown
Dominik Stadler [Sun, 17 Jul 2016 21:18:12 +0000 (21:18 +0000)]
Fix one more place where stream were left open when an exception is thrown

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753123 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
Dominik Stadler [Sun, 17 Jul 2016 21:18:07 +0000 (21:18 +0000)]
Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68

8 years agoEnable reproducer test for bug 56880 after it was fixed.
Dominik Stadler [Sun, 17 Jul 2016 21:17:51 +0000 (21:17 +0000)]
Enable reproducer test for bug 56880 after it was fixed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753121 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd commented reproducer for bug 57603
Dominik Stadler [Sun, 17 Jul 2016 21:17:45 +0000 (21:17 +0000)]
Add commented reproducer for bug 57603

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753120 13f79535-47bb-0310-9956-ffa450edef68

8 years agoonly calculate getTextHeight if it will be used
Javen O'Neal [Sun, 17 Jul 2016 20:33:32 +0000 (20:33 +0000)]
only calculate getTextHeight if it will be used

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68

8 years agoreduce statement complexity in drawContent, also has fewer FLOPS
Javen O'Neal [Sun, 17 Jul 2016 20:29:34 +0000 (20:29 +0000)]
reduce statement complexity in drawContent, also has fewer FLOPS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753114 13f79535-47bb-0310-9956-ffa450edef68

8 years agoif ever combined, VerticalAlignment and HorizontalAlignment would likely end up at...
Javen O'Neal [Sun, 17 Jul 2016 20:27:57 +0000 (20:27 +0000)]
if ever combined, VerticalAlignment and HorizontalAlignment would likely end up at org.apache.poi.common.usermodel

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753113 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 57919: add performance note to javadocs about using BufferedOutputStreams on...
Javen O'Neal [Sun, 17 Jul 2016 20:25:37 +0000 (20:25 +0000)]
bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68

8 years agomake instance variables final where possible
Javen O'Neal [Sun, 17 Jul 2016 20:24:14 +0000 (20:24 +0000)]
make instance variables final where possible

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753111 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#57919 Provide an initial in-place write method for HSSFWorkbook
Nick Burch [Sun, 17 Jul 2016 19:02:58 +0000 (19:02 +0000)]
#57919 Provide an initial in-place write method for HSSFWorkbook

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSl...
Javen O'Neal [Sun, 17 Jul 2016 13:25:02 +0000 (13:25 +0000)]
bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59170: remove deprecated TableSprmUncompressor#uncompressTAP(byte[] grpprl, int...
Javen O'Neal [Sun, 17 Jul 2016 13:12:27 +0000 (13:12 +0000)]
bug 59170: remove deprecated TableSprmUncompressor#uncompressTAP(byte[] grpprl, int offset) method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753070 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59170: fix compile error from r1753052 when removing deprecated TAP_TYPE constant
Javen O'Neal [Sun, 17 Jul 2016 13:11:18 +0000 (13:11 +0000)]
bug 59170: fix compile error from r1753052 when removing deprecated TAP_TYPE constant

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753069 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58190: add unit tests for XMLSlideShow#addPicture and XMLSlideShow#findPicture
Javen O'Neal [Sun, 17 Jul 2016 12:16:58 +0000 (12:16 +0000)]
bug 58190: add unit tests for XMLSlideShow#addPicture and XMLSlideShow#findPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753065 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum
Javen O'Neal [Sun, 17 Jul 2016 11:56:13 +0000 (11:56 +0000)]
bug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753062 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59264,59833,59837: upgrade deprecated methods in examples and testcases
Javen O'Neal [Sun, 17 Jul 2016 11:45:40 +0000 (11:45 +0000)]
bug 59264,59833,59837: upgrade deprecated methods in examples and testcases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753061 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59264,59833,59837: upgrade deprecated methods in examples and testcases
Javen O'Neal [Sun, 17 Jul 2016 11:43:50 +0000 (11:43 +0000)]
bug 59264,59833,59837: upgrade deprecated methods in examples and testcases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753060 13f79535-47bb-0310-9956-ffa450edef68

8 years agoclose workbook to avoid resource leak
Javen O'Neal [Sun, 17 Jul 2016 10:27:44 +0000 (10:27 +0000)]
close workbook to avoid resource leak

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753053 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59170: remove deprecated constants, make private variables final, whitespace
Javen O'Neal [Sun, 17 Jul 2016 10:27:18 +0000 (10:27 +0000)]
bug 59170: remove deprecated constants, make private variables final, whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753052 13f79535-47bb-0310-9956-ffa450edef68

8 years agoHexDump.writeHex is similar to Long#toHexString. Consider consolidating.
Javen O'Neal [Sun, 17 Jul 2016 10:22:43 +0000 (10:22 +0000)]
HexDump.writeHex is similar to Long#toHexString. Consider consolidating.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753050 13f79535-47bb-0310-9956-ffa450edef68

8 years agolog on unsupported Sprm operation, save operand to variable to reduce duplicated...
Javen O'Neal [Sun, 17 Jul 2016 10:10:21 +0000 (10:10 +0000)]
log on unsupported Sprm operation, save operand to variable to reduce duplicated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753048 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace (tabs to spaces)
Javen O'Neal [Sun, 17 Jul 2016 10:08:06 +0000 (10:08 +0000)]
whitespace (tabs to spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753047 13f79535-47bb-0310-9956-ffa450edef68

8 years agoHWPF SectionProperties implements Cloneable
Javen O'Neal [Sun, 17 Jul 2016 10:07:06 +0000 (10:07 +0000)]
HWPF SectionProperties implements Cloneable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753046 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58802: javadoc fix
Javen O'Neal [Sun, 17 Jul 2016 09:52:04 +0000 (09:52 +0000)]
bug 58802: javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753044 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59873: javadoc fix
Javen O'Neal [Sun, 17 Jul 2016 09:48:36 +0000 (09:48 +0000)]
bug 59873: javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753043 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59873: javadoc fix
Javen O'Neal [Sun, 17 Jul 2016 09:44:26 +0000 (09:44 +0000)]
bug 59873: javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753042 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
Javen O'Neal [Sun, 17 Jul 2016 09:42:13 +0000 (09:42 +0000)]
bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753041 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
Javen O'Neal [Sun, 17 Jul 2016 09:32:29 +0000 (09:32 +0000)]
bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753040 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 58802: HWPF: Allow reading of footnote and endnote properties
Dominik Stadler [Sun, 17 Jul 2016 09:27:17 +0000 (09:27 +0000)]
Bug 58802: HWPF: Allow reading of footnote and endnote properties

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753039 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos...
Dominik Stadler [Sun, 17 Jul 2016 09:27:07 +0000 (09:27 +0000)]
Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum
Javen O'Neal [Sun, 17 Jul 2016 09:20:21 +0000 (09:20 +0000)]
bug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753035 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace
Javen O'Neal [Sun, 17 Jul 2016 08:45:55 +0000 (08:45 +0000)]
whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753032 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace (tabs to spaces)
Javen O'Neal [Sun, 17 Jul 2016 08:45:00 +0000 (08:45 +0000)]
whitespace (tabs to spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753031 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd cause to exceptions, log exceptions that are caught and suppressed
Javen O'Neal [Sun, 17 Jul 2016 08:41:52 +0000 (08:41 +0000)]
add cause to exceptions, log exceptions that are caught and suppressed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753030 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace
Javen O'Neal [Sun, 17 Jul 2016 08:26:51 +0000 (08:26 +0000)]
whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753028 13f79535-47bb-0310-9956-ffa450edef68

8 years agojavadocs fix
Javen O'Neal [Sun, 17 Jul 2016 07:48:48 +0000 (07:48 +0000)]
javadocs fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753020 13f79535-47bb-0310-9956-ffa450edef68

8 years agomake private maps final
Javen O'Neal [Sun, 17 Jul 2016 07:29:40 +0000 (07:29 +0000)]
make private maps final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753018 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd @Override annotations to CreationHelper classes
Javen O'Neal [Sun, 17 Jul 2016 07:14:49 +0000 (07:14 +0000)]
add @Override annotations to CreationHelper classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753017 13f79535-47bb-0310-9956-ffa450edef68

8 years agothrow exception if hyperlink is invalid type when validating hyperlink
Javen O'Neal [Sun, 17 Jul 2016 06:04:56 +0000 (06:04 +0000)]
throw exception if hyperlink is invalid type when validating hyperlink

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753016 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59872: add @since annotation to Sheet#getHyperlink(CellAddress)
Javen O'Neal [Sun, 17 Jul 2016 05:47:03 +0000 (05:47 +0000)]
bug 59872: add @since annotation to Sheet#getHyperlink(CellAddress)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753015 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59775: correctly create XSSFHyperlinks when target is a URL containing a hash...
Javen O'Neal [Sun, 17 Jul 2016 05:43:03 +0000 (05:43 +0000)]
bug 59775: correctly create XSSFHyperlinks when target is a URL containing a hash mark; patch contributed by Guillermo Alvarez

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753013 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59775: fix cell address index error
Javen O'Neal [Sun, 17 Jul 2016 04:59:12 +0000 (04:59 +0000)]
bug 59775: fix cell address index error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753011 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59872: add Sheet.getHyperlink(CellAddress)
Javen O'Neal [Sun, 17 Jul 2016 04:41:20 +0000 (04:41 +0000)]
bug 59872: add Sheet.getHyperlink(CellAddress)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68

8 years agouse real TempFile
Andreas Beeker [Sun, 17 Jul 2016 00:27:52 +0000 (00:27 +0000)]
use real TempFile

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753004 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#59841 - OOXML: enable custom zip streams via OPCPackage.open(ZipEntrySource)
Andreas Beeker [Sun, 17 Jul 2016 00:14:06 +0000 (00:14 +0000)]
#59841 - OOXML: enable custom zip streams via OPCPackage.open(ZipEntrySource)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753003 13f79535-47bb-0310-9956-ffa450edef68

8 years agoApply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on...
Dominik Stadler [Sat, 16 Jul 2016 20:52:39 +0000 (20:52 +0000)]
Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 59733: Narrow down testcase some more, after the first shift, removing the first...
Dominik Stadler [Sat, 16 Jul 2016 20:52:28 +0000 (20:52 +0000)]
Bug 59733: Narrow down testcase some more, after the first shift, removing the first row is sufficient to trigger the problem

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752996 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd a test to check for a NullPointerException in XSLFTableCell
Dominik Stadler [Fri, 15 Jul 2016 18:24:11 +0000 (18:24 +0000)]
Add a test to check for a NullPointerException in XSLFTableCell

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752862 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 59861: Adjust testcase, it works now for me. Also combine the two TestProper...
Dominik Stadler [Fri, 15 Jul 2016 18:24:02 +0000 (18:24 +0000)]
Bug 59861: Adjust testcase, it works now for me. Also combine the two TestProper classes into one

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752861 13f79535-47bb-0310-9956-ffa450edef68

8 years agoJDK8 javadocs fixes
Javen O'Neal [Fri, 15 Jul 2016 10:13:58 +0000 (10:13 +0000)]
JDK8 javadocs fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752812 13f79535-47bb-0310-9956-ffa450edef68

8 years agoreplace for-loop over index with for-each loop
Javen O'Neal [Fri, 15 Jul 2016 07:41:26 +0000 (07:41 +0000)]
replace for-loop over index with for-each loop

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752788 13f79535-47bb-0310-9956-ffa450edef68

8 years agoannotate purpose of each PROPER() function test case, add a few more test cases,...
Javen O'Neal [Fri, 15 Jul 2016 07:25:16 +0000 (07:25 +0000)]
annotate purpose of each PROPER() function test case, add a few more test cases, identify some problems with ß handling

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752786 13f79535-47bb-0310-9956-ffa450edef68

8 years agoJDK8 javadocs
Javen O'Neal [Fri, 15 Jul 2016 06:35:21 +0000 (06:35 +0000)]
JDK8 javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752781 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFunction PROPER: Don't use a regular expression syntax that is not available on Andro...
Dominik Stadler [Fri, 15 Jul 2016 06:32:45 +0000 (06:32 +0000)]
Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s)
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59858: describe why VBA macro reading failed
Javen O'Neal [Fri, 15 Jul 2016 06:12:37 +0000 (06:12 +0000)]
bug 59858: describe why VBA macro reading failed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752778 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59858: add disabled unit test for bug 59858; file from Brooke
Javen O'Neal [Fri, 15 Jul 2016 05:28:29 +0000 (05:28 +0000)]
bug 59858: add disabled unit test for bug 59858; file from Brooke

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752776 13f79535-47bb-0310-9956-ffa450edef68

8 years ago"cannot not" presumably means "cannot"
David North [Wed, 13 Jul 2016 16:40:47 +0000 (16:40 +0000)]
"cannot not" presumably means "cannot"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752452 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix name of new OLE2ScratchpadExtractorFactory
Dominik Stadler [Tue, 12 Jul 2016 15:40:18 +0000 (15:40 +0000)]
Fix name of new OLE2ScratchpadExtractorFactory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752304 13f79535-47bb-0310-9956-ffa450edef68

8 years agoRemove un-used imports
Nick Burch [Mon, 11 Jul 2016 23:00:40 +0000 (23:00 +0000)]
Remove un-used imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752229 13f79535-47bb-0310-9956-ffa450edef68

8 years agoLast bit of reflection - get back to the full OOXML-enabled factory if we can
Nick Burch [Mon, 11 Jul 2016 22:57:42 +0000 (22:57 +0000)]
Last bit of reflection - get back to the full OOXML-enabled factory if we can

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752228 13f79535-47bb-0310-9956-ffa450edef68

8 years agoExceptions
Nick Burch [Mon, 11 Jul 2016 22:53:22 +0000 (22:53 +0000)]
Exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752227 13f79535-47bb-0310-9956-ffa450edef68

8 years agoStart moving logic over into the main and scratchpad jars for OLE2
Nick Burch [Mon, 11 Jul 2016 22:47:02 +0000 (22:47 +0000)]
Start moving logic over into the main and scratchpad jars for OLE2

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752226 13f79535-47bb-0310-9956-ffa450edef68

8 years agoPull Scratchpad Extractor logic to own class
Nick Burch [Mon, 11 Jul 2016 22:27:02 +0000 (22:27 +0000)]
Pull Scratchpad Extractor logic to own class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752225 13f79535-47bb-0310-9956-ffa450edef68

8 years agoStart to pull out some of the OLE2 logic, so we can then split some Scratchpad parts out
Nick Burch [Mon, 11 Jul 2016 22:20:51 +0000 (22:20 +0000)]
Start to pull out some of the OLE2 logic, so we can then split some Scratchpad parts out

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752223 13f79535-47bb-0310-9956-ffa450edef68

8 years agoNotes on use
Nick Burch [Mon, 11 Jul 2016 22:17:34 +0000 (22:17 +0000)]
Notes on use

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752222 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd BaseTestCellUtil unit tests to cover setting cell style properties with an invali...
Javen O'Neal [Sun, 10 Jul 2016 11:37:22 +0000 (11:37 +0000)]
add BaseTestCellUtil unit tests to cover setting cell style properties with an invalid value and using both valid Short and Enum values

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752079 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59837: update CellUtil to handle VerticalAlignment and HorizontalAlignment enums
Javen O'Neal [Sun, 10 Jul 2016 11:18:55 +0000 (11:18 +0000)]
bug 59837: update CellUtil to handle VerticalAlignment and HorizontalAlignment enums

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752077 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59837: replace CellStyle.ALIGN_ and CellStyle.VERTICAL_ constants with Horizontal...
Javen O'Neal [Sun, 10 Jul 2016 08:29:02 +0000 (08:29 +0000)]
bug 59837: replace CellStyle.ALIGN_ and CellStyle.VERTICAL_ constants with HorizontalAlignment and VerticalAlignment enums

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752066 13f79535-47bb-0310-9956-ffa450edef68

8 years agojavadoc fixes
Javen O'Neal [Sun, 10 Jul 2016 06:54:36 +0000 (06:54 +0000)]
javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752063 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59264: Unify interface for setting cell border line styles using BorderStyle...
Javen O'Neal [Sun, 10 Jul 2016 06:52:16 +0000 (06:52 +0000)]
bug 59264: Unify interface for setting cell border line styles using BorderStyle enum instead of short code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752062 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd comments describing Outlook .msg DirectoryNode names
Javen O'Neal [Sun, 10 Jul 2016 01:41:15 +0000 (01:41 +0000)]
Add comments describing Outlook .msg DirectoryNode names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752054 13f79535-47bb-0310-9956-ffa450edef68

8 years agomove string literals out to array that can be for-looped over
Javen O'Neal [Sun, 10 Jul 2016 01:29:30 +0000 (01:29 +0000)]
move string literals out to array that can be for-looped over

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752053 13f79535-47bb-0310-9956-ffa450edef68

8 years agojavadocs fixes (jdk8)
Andreas Beeker [Sat, 9 Jul 2016 18:52:26 +0000 (18:52 +0000)]
javadocs fixes (jdk8)
eclipse source clean-ups (final members, override annotations, for-each loops)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752037 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd 2^x to POWER2 comments
Javen O'Neal [Sat, 9 Jul 2016 08:54:07 +0000 (08:54 +0000)]
add 2^x to POWER2 comments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751992 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 52949,59830: move module storage and decompressing into a standalone function
Javen O'Neal [Sat, 9 Jul 2016 08:51:57 +0000 (08:51 +0000)]
bug 52949,59830: move module storage and decompressing into a standalone function

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751990 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 52949,59830: move module storage and decompressing into a standalone function
Javen O'Neal [Sat, 9 Jul 2016 08:18:29 +0000 (08:18 +0000)]
bug 52949,59830: move module storage and decompressing into a standalone function

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751987 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59830: attach context to any IOException (likely a result of reaching EOF on...
Javen O'Neal [Sat, 9 Jul 2016 08:05:43 +0000 (08:05 +0000)]
bug 59830: attach context to any IOException (likely a result of reaching EOF on input stream)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751986 13f79535-47bb-0310-9956-ffa450edef68

8 years agoremove Internal UnhandledDataStructure.copyOfRange because function is available...
Javen O'Neal [Sat, 9 Jul 2016 06:38:16 +0000 (06:38 +0000)]
remove Internal UnhandledDataStructure.copyOfRange because function is available in JDK 1.6+ and we no longer support JDK 1.5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751984 13f79535-47bb-0310-9956-ffa450edef68

8 years agoclose streams if an exception is throw
Javen O'Neal [Sat, 9 Jul 2016 06:30:12 +0000 (06:30 +0000)]
close streams if an exception is throw

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751983 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59830: add context to why no more bytes could be read from input stream
Javen O'Neal [Sat, 9 Jul 2016 05:39:56 +0000 (05:39 +0000)]
bug 59830: add context to why no more bytes could be read from input stream

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751982 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59833: add getFillPatternEnum and setFillPattern(FillPatternType) to CellStyle...
Javen O'Neal [Fri, 8 Jul 2016 22:28:28 +0000 (22:28 +0000)]
bug 59833: add getFillPatternEnum and setFillPattern(FillPatternType) to CellStyle; consolidate duplicated FillPattern constants in CellStyle to FillPatternType enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751972 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 55555: set fill pattern, foreground color, and background color order correctly...
Javen O'Neal [Fri, 8 Jul 2016 18:45:15 +0000 (18:45 +0000)]
bug 55555: set fill pattern, foreground color, and background color order correctly to follow HSSFCellStyle's order requirement; patch from Qualtagh. This closes #33 on Github

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751955 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 56154: rename setLastModifiedBy to setLastModifiedByUser
Javen O'Neal [Fri, 8 Jul 2016 18:05:02 +0000 (18:05 +0000)]
bug 56154: rename setLastModifiedBy to setLastModifiedByUser

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751950 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 56154: add @since annotations to getLastModifiedBy and setLastModifiedBy methods
Javen O'Neal [Fri, 8 Jul 2016 17:59:01 +0000 (17:59 +0000)]
bug 56154: add @since annotations to getLastModifiedBy and setLastModifiedBy methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751949 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 56154: get and set last modified by user property; patch from Danil Lopatin
Javen O'Neal [Fri, 8 Jul 2016 17:56:54 +0000 (17:56 +0000)]
bug 56154: get and set last modified by user property; patch from Danil Lopatin

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751948 13f79535-47bb-0310-9956-ffa450edef68

8 years agoconvert OPC Compliance unit tests to junit4
Javen O'Neal [Fri, 8 Jul 2016 12:07:20 +0000 (12:07 +0000)]
convert OPC Compliance unit tests to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751891 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace and +svn:eol-style=native
Javen O'Neal [Fri, 8 Jul 2016 11:55:21 +0000 (11:55 +0000)]
whitespace and +svn:eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751890 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAllOpenXML4JInternalTests no longer needed in AllOpenXML4JTests suite because it...
Javen O'Neal [Fri, 8 Jul 2016 11:53:28 +0000 (11:53 +0000)]
AllOpenXML4JInternalTests no longer needed in AllOpenXML4JTests suite because it was upgraded to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751889 13f79535-47bb-0310-9956-ffa450edef68

8 years agofix regular expression example
Javen O'Neal [Fri, 8 Jul 2016 11:42:01 +0000 (11:42 +0000)]
fix regular expression example

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751885 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 59826: ant script to apply patch.tar.gz files from bugzilla
Javen O'Neal [Fri, 8 Jul 2016 11:32:52 +0000 (11:32 +0000)]
bug 59826: ant script to apply patch.tar.gz files from bugzilla

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751883 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd crude unit test for ZipPackagePropertiesMarshaller
Javen O'Neal [Fri, 8 Jul 2016 09:10:03 +0000 (09:10 +0000)]
add crude unit test for ZipPackagePropertiesMarshaller

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751872 13f79535-47bb-0310-9956-ffa450edef68

8 years agoconvert to junit4
Javen O'Neal [Fri, 8 Jul 2016 08:53:34 +0000 (08:53 +0000)]
convert to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751870 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace and +svn:eol-style=native
Javen O'Neal [Fri, 8 Jul 2016 08:38:28 +0000 (08:38 +0000)]
whitespace and +svn:eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751867 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd @Internal annotations to implementations of Internal EvaluationWorkbook and Evalu...
Javen O'Neal [Thu, 7 Jul 2016 23:20:34 +0000 (23:20 +0000)]
add @Internal annotations to implementations of Internal EvaluationWorkbook and EvaluationSheet interfaces; added @since annotations to clearAllCachedResultValues added in r1751836.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751843 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMi...
Javen O'Neal [Thu, 7 Jul 2016 23:00:07 +0000 (23:00 +0000)]
add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMissingWorkbooks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751841 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd getters for setIgnoreMissingWorkbooks and setDebugEvaluationOutputForNextEval...
Javen O'Neal [Thu, 7 Jul 2016 22:46:06 +0000 (22:46 +0000)]
add getters for setIgnoreMissingWorkbooks and setDebugEvaluationOutputForNextEval; add internal decorator; getSupportedFunctionNames and getNotSupportedFunctionNames should return unmodifiable collections

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751840 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace (3sp to 4sp)
Javen O'Neal [Thu, 7 Jul 2016 22:38:09 +0000 (22:38 +0000)]
whitespace (3sp to 4sp)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751839 13f79535-47bb-0310-9956-ffa450edef68