fix AuthSourceLdap#get_attr is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18692 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/diff.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18691 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18690 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: disable Style/TrailingCommaInArrayLiteral

git-svn-id: http://svn.redmine.org/redmine/trunk@18689 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: add db/schema.rb to global exclude

git-svn-id: http://svn.redmine.org/redmine/trunk@18688 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: move Style/IdenticalConditionalBranches files from .rubocop_todo.yml to .rubocop.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18687 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/AccessModifierIndentation in lib/redmine/wiki_formatting/textile/formatter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18686 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18685 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18684 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/BlockAlignment in test/unit/lib/redmine/menu_manager/menu_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18683 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: remove lib/redmine/wiki_formatting/textile/redcloth3.rb from Layout/EmptyLinesAroundArguments fixed by r18678

git-svn-id: http://svn.redmine.org/redmine/trunk@18682 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: remove lib/redmine/wiki_formatting/textile/redcloth3.rb from Style/OneLineConditional fixed by r18680

git-svn-id: http://svn.redmine.org/redmine/trunk@18681 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Style/IfWithSemicolon in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18680 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/IndentAssignment in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18679 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in lib/redmine/wiki_formatting/textile/redcloth3.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18678 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/BlockAlignment in test/unit/lib/redmine/menu_manager/mapper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18677 e93f8b46-1217-0410-a6f0-8f06a7374b81

code layout clean up test/unit/project_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18676 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/models/version.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18675 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs and Layout/EmptyLines in app/models/version.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18674 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/mailer_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18673 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: use AllowAdjacentOneLineDefs of Layout/EmptyLineBetweenDefs

git-svn-id: http://svn.redmine.org/redmine/trunk@18672 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: remove files from Layout/EmptyLines fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18671 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: remove app/helpers/application_helper.rb from Style/WhenThen fixed by r18664

git-svn-id: http://svn.redmine.org/redmine/trunk@18670 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_priority.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18669 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/ElseAlignment in app/models/issue_import.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18668 e93f8b46-1217-0410-a6f0-8f06a7374b81

code layout clean up ApplicationHelper#parse_wiki_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18667 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: remove app/helpers/application_helper.rb from Layout/ElseAlignment fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18666 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_redmine_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18665 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/ElseAlignment in ApplicationHelper#parse_wiki_links

git-svn-id: http://svn.redmine.org/redmine/trunk@18664 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/CaseIndentation in app/helpers/versions_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18663 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/CaseIndentation in test/test_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18662 e93f8b46-1217-0410-a6f0-8f06a7374b81

use full text in fill_in at Issue system "update issue with form update" test

git-svn-id: http://svn.redmine.org/redmine/trunk@18661 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/users_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18660 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/settings_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18659 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/email_addresses_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18658 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/SpaceAfterSemicolon in app/models/mail_handler.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18657 e93f8b46-1217-0410-a6f0-8f06a7374b81

add new "update issue status" test to Issue system test

git-svn-id: http://svn.redmine.org/redmine/trunk@18656 e93f8b46-1217-0410-a6f0-8f06a7374b81

use "test do" syntax for Issue system test "update issue with form update"

git-svn-id: http://svn.redmine.org/redmine/trunk@18655 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/user_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18654 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18653 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/my_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18652 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/attachments_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18651 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/files_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18650 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/IndentHeredoc and Layout/IndentationConsistency in test/integration/api_test/custom_fields_attribute_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18649 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/project_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18648 e93f8b46-1217-0410-a6f0-8f06a7374b81

add additional assert to Issue system "test_update_issue_with_form_update"

git-svn-id: http://svn.redmine.org/redmine/trunk@18647 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18646 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/SpaceAroundBlockParameters in test/unit/query_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18645 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/IndentationConsistency in test/helpers/application_helper_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18644 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: remove test/functional/project_enumerations_controller_test.rb from Lint/Void fixed by r18636

git-svn-id: http://svn.redmine.org/redmine/trunk@18643 e93f8b46-1217-0410-a6f0-8f06a7374b81

Add TOC to Markdown Wiki formatting help (#32119).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18642 e93f8b46-1217-0410-a6f0-8f06a7374b81

Add TOC to Textile Wiki formatting help (#32119).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18641 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/IndentationConsistency in app/models/attachment.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18640 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: remove test/functional/project_enumerations_controller_test.rb from Layout/IndentationConsistency fixed by r18636

git-svn-id: http://svn.redmine.org/redmine/trunk@18639 e93f8b46-1217-0410-a6f0-8f06a7374b81

fix assert_equal parameter is broken in test/functional/project_enumerations_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18636 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/ElseAlignment in app/models/changeset.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18633 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: add Style/AsciiComments to .rubocop_todo.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18632 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Style/AsciiComments in lib/redmine/search.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18631 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Style/AsciiComments in test/unit/mail_handler_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18630 e93f8b46-1217-0410-a6f0-8f06a7374b81

Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError (#32223).

git-svn-id: http://svn.redmine.org/redmine/trunk@18629 e93f8b46-1217-0410-a6f0-8f06a7374b81

code layout clean up test/unit/issue_status_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18628 e93f8b46-1217-0410-a6f0-8f06a7374b81

code layout clean up test/functional/issue_statuses_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18627 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Style/RedundantBegin in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18626 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fix wong link destinations in wiki_syntax_markdown.html (#32169).

git-svn-id: http://svn.redmine.org/redmine/trunk@18625 e93f8b46-1217-0410-a6f0-8f06a7374b81

add additional assert to Issue system "test_update_issue_with_form_update"

git-svn-id: http://svn.redmine.org/redmine/trunk@18624 e93f8b46-1217-0410-a6f0-8f06a7374b81

reduce sleep seconds of Issue system "test_update_journal_notes_with_preview"

git-svn-id: http://svn.redmine.org/redmine/trunk@18623 e93f8b46-1217-0410-a6f0-8f06a7374b81

code layout clean up app/views/issues/_action_menu.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@18622 e93f8b46-1217-0410-a6f0-8f06a7374b81

code layout clean up app/views/issues/_attributes.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@18621 e93f8b46-1217-0410-a6f0-8f06a7374b81

code clean up test/integration/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18620 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18619 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Style/HashSyntax in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18618 e93f8b46-1217-0410-a6f0-8f06a7374b81

use "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids

WikiPage#deleted_attachment_ids is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18617 e93f8b46-1217-0410-a6f0-8f06a7374b81

use "attr_writer" instead of "attr_accessor" for QueryColumn#sortable

QueryColumn#sortable is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18616 e93f8b46-1217-0410-a6f0-8f06a7374b81

use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value

CustomFieldValue#value= is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc in test/unit/setting_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18614 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: fix source code comment in r18607

git-svn-id: http://svn.redmine.org/redmine/trunk@18613 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/AlignArray in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18612 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/SpaceAfterColon in test/integration/wiki_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18611 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18610 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/SpaceAfterColon in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18609 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18608 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18607 e93f8b46-1217-0410-a6f0-8f06a7374b81

code cleanup: rubocop: fix Layout/IndentHeredoc in test/functional/documents_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18606 e93f8b46-1217-0410-a6f0-8f06a7374b81

Traditional Chinese translation update (#32210).

Patch by ChunChang Lo.

git-svn-id: http://svn.redmine.org/redmine/trunk@18605 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: remove test/integration/attachments_test.rb from Layout/EmptyLinesAroundExceptionHandling fixed by r18593

git-svn-id: http://svn.redmine.org/redmine/trunk@18604 e93f8b46-1217-0410-a6f0-8f06a7374b81

rubocop: remove test/functional/issues_controller_test.rb from Layout/IndentHeredoc and Layout/IndentationConsistency fixed by r18593

git-svn-id: http://svn.redmine.org/redmine/trunk@18603 e93f8b46-1217-0410-a6f0-8f06a7374b81

Options in a drop-down overlap the down arrow when Alternate theme is used (#32206, #31147).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18602 e93f8b46-1217-0410-a6f0-8f06a7374b81

Japanese wiki help translation update (#32207).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18601 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fix that "Associated revisions" tab has no content when the user displays comments in reverse chronological order (#32198, #3058).

Patch by José Esteves.

git-svn-id: http://svn.redmine.org/redmine/trunk@18598 e93f8b46-1217-0410-a6f0-8f06a7374b81

Japanese translation update (#32202).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18597 e93f8b46-1217-0410-a6f0-8f06a7374b81

Update locales (#17840).

git-svn-id: http://svn.redmine.org/redmine/trunk@18596 e93f8b46-1217-0410-a6f0-8f06a7374b81

Option to send email notification on "Target version updated" (#17840).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18595 e93f8b46-1217-0410-a6f0-8f06a7374b81

Redmine::VERSION::revision may return wrong value (#29601).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18594 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fix test failure due to missing call to set_tmp_attachments_directory (#32122).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18593 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fix incorrect headings example in Textile help (#32184).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18592 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fix "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks (#32110).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18589 e93f8b46-1217-0410-a6f0-8f06a7374b81

Remove unnecessary requiring of "rexml/document" (#32189).

git-svn-id: http://svn.redmine.org/redmine/trunk@18588 e93f8b46-1217-0410-a6f0-8f06a7374b81

Rounded corners on table.cal (#32165).

Patch by Antonio McDeal.

git-svn-id: http://svn.redmine.org/redmine/trunk@18587 e93f8b46-1217-0410-a6f0-8f06a7374b81

Use Redmine::MimeType.of instead of regexp to check if the attachment is Textile (#29752).

git-svn-id: http://svn.redmine.org/redmine/trunk@18586 e93f8b46-1217-0410-a6f0-8f06a7374b81

Add styles for Textile/Markdown attachments preview (#29752).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18585 e93f8b46-1217-0410-a6f0-8f06a7374b81