Leif Åstrand [Fri, 30 Aug 2013 10:43:34 +0000 (13:43 +0300)]
Merge changes from origin/7.1
4f3e81a Use <code> instead of {@code} for sample containing { and } (#12311) c7a48ae Delay sending DateField popup value to server until popup is closed #6252 dc491a4 Reset waitingForFilteringResponse flag to false inside onBlur (#12325) 4fb775a Fixed a typo in FieldGroup.isModified() JavaDoc. (#12172) aa47197 Add a chapter on installing IvyDE (for #12359) eaec281 GWT requires max 1.6 compiler compliance level currently - #12345 f72be69 Terminate JVM if server.close() has no effect (#12363) 36413cb Make sure that no fileIds are replayed to the client (#12330) 7182665 Fix scrollbar for Window under WebKit browsers (#11994) 61dbe9c Search only remaining message for delimiter (#12404) b5a212a Report min and max times from Profiler (#12409) 7220ca8 Fixed DragAndDropWrapper using wrong drop target in IE8 #12406 c87772b Escape markup in CustomLayout's JavaDoc (#12410) f5b67af Optimize ComputedStyle.getIntProperty() (#12411) 0473036 Add more detailed profiling for some client side hotspots (#12418) 7dfe5ae Fixed test broken by fixes to drag&drop #12406 234ed1c Fixed test broken by PopupDateField communication change #6252 c7a8c3f Fixed failing TabKeyboardNavigation test #12433 fac9ff6 Optimize resetting of state when detaching components (#10899, #11284) af995de Optimize large Vertical/HorizontalLayout client side (#12420, #10899) 39fd5fc Fix bug for spacing on first widget (#12420) bd4442b Fixed broken test due to changes in drop position by #12406 b83240f Optimize CssLayout hierarchy update (#11284) a52b286 Added controlDirective to ifContentStatement. Fixes ticket #12105. 8ce45c7 Disable slow sanity check when not in debug mode (#12463) 232eb42 Enable use of profiler without debug window (#12465) 6dc46c5 Use the add() path of CssLayout only when appending to the end (#11284) bea7fa3 Only consider caption tooltips for own slots (#12469) dce63d1 Allow creating session for Portlet UI init request (#12473) ad669c3 Adds junit to the ide configuration for the theme-compiler module.
Henri Sara [Wed, 28 Aug 2013 09:34:53 +0000 (12:34 +0300)]
Use the add() path of CssLayout only when appending to the end (#11284)
This should get the benefits of the previous optimization on initial
rendering without negatively affecting the performance when modifying a
layout with complex non-leaf children.
Henri Sara [Thu, 22 Aug 2013 08:55:38 +0000 (11:55 +0300)]
Optimize large Vertical/HorizontalLayout client side (#12420, #10899)
Spacing is now only handled at the beginning and end of hierarchy
updates, not for every component separately.
Some more profiling data on potential hotspots is also generated when
Profiler is used.
Henri Sara [Thu, 22 Aug 2013 08:03:47 +0000 (11:03 +0300)]
Optimize resetting of state when detaching components (#10899, #11284)
This has a significant impact on some older browsers, especially IE8.
This change also adds hierarchy update profiling statements to
help find hotspots.
John Ahlroos [Thu, 22 Aug 2013 08:10:18 +0000 (11:10 +0300)]
Fixed failing TabKeyboardNavigation test #12433
The test fails on Opera 12 since the assertText is done before the
tabsheet has had time to change the tab content. Added a small waiting
period after the tab is changed before the assert is made to fix the
issue.
John Ahlroos [Wed, 21 Aug 2013 11:51:50 +0000 (14:51 +0300)]
Fixed test broken by PopupDateField communication change #6252
After #6252 the value is no longer communicated to the server
immediatly but only once the popup is closed. Changed the test to assume
the new behaviour.
John Ahlroos [Wed, 21 Aug 2013 10:34:37 +0000 (13:34 +0300)]
Fixed test broken by fixes to drag&drop #12406
Due to the fixes to the VDragAndDropManager the drop location became a
lot more accurate and so changed where the drops were made in the test.
To fix it I adjusted the pixel position within the drop target element to account for the
changed accuracy.
John Ahlroos [Tue, 20 Aug 2013 10:30:47 +0000 (13:30 +0300)]
Fixed DragAndDropWrapper using wrong drop target in IE8 #12406
VDragAndDropManager was assuming that the target element will always be
inside the cloned "drag image" element while dragging. This assumption
is false since the "drag image" can be 0x0px or transparent effectivly
disabling dragging.
Since Testbench 2 is also very flaky in using the Vaadin locators with
the drag/drop commands I replaced the locators with shorter locators
using a debug id to make the test more readable and stable.
Artur Signell [Mon, 19 Aug 2013 14:31:46 +0000 (17:31 +0300)]
Merge changes from origin/7.1
16d17f9 Fix native scrolling regression in iOS 6 homescreen apps (#12295) 7212e02 Fix race in VaadinService.lockSession() (#12282) 2d5a107 Update "lastRequestedFirstvisible" field value right away (#10666). 325cdf9 Disable failing calendar Actions Menu Test (#12181) 8ba4117 Split UiAccess test (#12332)
Artur Signell [Mon, 19 Aug 2013 09:37:52 +0000 (12:37 +0300)]
Merge changes from origin/7.1
7cb49d1 Fix invisible calendar actions menu #12181 44aacf4 Clarify Embedded javadoc (#12290) 59a043b Fix actions in action menu appearing in random order #12250 5d57129 Fix calendar click events on context menu #12297 f5e3663 Document multiple load semantics in @StyleSheet and @JavaScript (#12200) 17bb700 Add optional OSGi Import-Package for javax.validation (#12301) ea148c8 Disable all logging if production mode is enabled (#12299) 326bbb5 Fixes parsing of multiple push messages in streaming mode (#12197) 7fc1054 Ensure StringToIntegerConverter rejects values outside range of int (#12230) f587298 Improve URI fragment listener javadocs (#12296) d97cfbc Refine handling of null and empty URI fragments (#12207) 99c7d0b Show tooltips for ordered layout captions (#10046)
Artur Signell [Mon, 19 Aug 2013 09:34:29 +0000 (12:34 +0300)]
Merge changes from origin/7.1
a53d487 Verify the connector hierarchy if assertions are enabled (#12271) e9f3fcc Fix issue with hidden component cells in Table and TreeTable #12119 cbab936 Fixes light theme window sprites #12171 938d412 Fixes button :active state on firefox #12126 4219227 Fixed wrong classname in WindowThemes TB test #12171
John Ahlroos [Thu, 15 Aug 2013 13:27:27 +0000 (16:27 +0300)]
Fixed WAI-ARIA test related to #11820 which never has succeeded
Due to Testbench bug #12375 the test had never succeed on IE9/IE10.
To circumvent the issue I changed the way the test was done by
substituting the /@class assertion with an xpath statement instead which
works on all supported browsers.
Henrik Paul [Thu, 15 Aug 2013 05:59:03 +0000 (08:59 +0300)]
Make sure that no fileIds are replayed to the client (#12330)
Due to how ProxyReceivers are constructed and serialized, we don't want
to resend the ProxyReceivers for files that already are in the queue.
Either we needed to change the way ProxyReceivers behave, or just make
sure that they aren't resent. I chose the double-check method.
John Ahlroos [Thu, 15 Aug 2013 09:39:46 +0000 (12:39 +0300)]
Fixed WAI-ARIA test related to #11821 which never has succeeded
Due to Testbench bug #12375 the test had never succeed on IE9/IE10.
To circumvent the issue I changed the way the test was done by
substituting the /@class assertion with an xpath statement instead which
works on all supported browsers.
John Ahlroos [Thu, 15 Aug 2013 06:32:54 +0000 (09:32 +0300)]
Fixes tests broken by accessability fixes #11874 and #11820
Both WAI-ARIA fixes improves the accessability by adding a hidden
element into the dom for the screen readers. Unfortunatly this
broke tests based on a certain DOM path.
Matti Hosio [Mon, 15 Jul 2013 12:56:07 +0000 (15:56 +0300)]
Support for null intermediate beans in NestedMethodProperty (#11435)
Allows intermediate beans to return null in the NestedMethodProperty.
The feature is not enabled by default and thus should be fully backwards
compatible.
Disable failing calendar Actions Menu Test (#12181)
This test cannot be completed in a smart fashion until TestBench 3 is in
use, because of differences in the DOM structure created by GWT for IE
and Opera, versus Webkit and Gecko browsers. TB2 requires identical DOM
structure for assertion queries to work.
The session might be invalidated before lockSession() acquires the lock.
Check if the session is still valid after locking and ensure
SessionExpiredException is thrown if not.
Fabian Lange [Wed, 17 Jul 2013 09:44:57 +0000 (11:44 +0200)]
Fixes parsing of multiple push messages in streaming mode (#12197)
The current atmosphere code can handle messages split up using the message
length header. But it does not handle the case where the header is actually
split up itself.
This patch solves it by making sure the length header stays intact.
Corresponding atmosphere ticket:
https://github.com/Atmosphere/atmosphere/issues/1199
Jarno Rantala [Wed, 26 Jun 2013 11:56:54 +0000 (14:56 +0300)]
BeanValidator changed to throw exception with array of causes (#11324)
BeanValidator was modified to throw InvalidValueException with array of causes
instead of exception with one message including HTML. This way
AbstractErrorMessage is able to create correct error notification message with
multiple lines.
John Ahlroos [Fri, 26 Jul 2013 08:07:36 +0000 (11:07 +0300)]
Fixes button :active state on firefox #12126
When doing event.preventDefault() firefox will not trigger the :active
selector intentionally (see
https://bugzilla.mozilla.org/show_bug.cgi?id=771241).
Event.preventDefault() was added to prevent text selection in #10917
but it actually is not needed since the button also uses the
user-select:none css attribute which effectivly prevents the text selection.
Also now applying the previously browser specific (ie,opera) .v-pressed
classname to all browsers to make styling of the pressed state a bit easier
to do for all browsers and not reliant on the :active pseudo-class which is a
non-standard pseudo-class.
John Ahlroos [Thu, 25 Jul 2013 06:53:50 +0000 (09:53 +0300)]
Fixes light theme window sprites #12171
The close buttons images for the Window black theme was mistakenly
added to the white theme sprite and ended up in the middle of the
light theme window. Moved the black theme button images to the
black theme sprite.
3229847 Fix lost focus in Table when refreshing row cache (#12231) 654d570 Don't close an unbound VaadinSession for GAEVaadinServlet (#12209) 2ea19f3 Make VaadinService.closeInactiveUIs set UI threadlocals (#12186) 7f5a0a7 Add Require-Bundle for our rebased atmosphere bundle (#12195)
419c6c7 Implemented Focusable in MenuBar (#7674) a4f1277 Fixed NPE in ApplicationRunnerServlet (#12145) 08d365a Fixed slider value initialization on HSV and RGB tabs of ColorPicker. (#7863) da480bd Fix VaadinService.findUI to throw Error if UIConstants.UI_ID_PARAMETER is not set (#11943) 6291a50 Ensure that Slider diffstate always contains "value" (#12133) 7e7e698 32x32 favicons added, replacing the old favicons (#12143) 1702059 Replace printStackTrace with getLogger().log() (#12147) b421d6e Updated Javadoc for Table.getColumnAlignment fixing #6810 414e3bf Fixed an error in CustomComponent JavaDoc (#10038), and some improvements. 4583d07 Fix NPE in Like.java (#10167) 6c4da29 Ensure table's cells aren't refreshed if table is detached. (#9138) e37464c #11638: Ending an imported SCSS file with a comment causes an error in the Sass 478eeb5 Test using Jetty 9 (#12124) f7cc72d Close only combobox on escape, not the window (#12163) 9a9b0a5 Automatic test for escape closing window from combobox (#12163) ae565a2 Fix bug in PopupDateField where locale was retained incorrectly if changed while popup was open (#12153) d7a64fd Enable native scrolling in home screen apps on iOS 6+ (#12149) 4a04f00 Add test case for testing ClickEvent after dragging button (#7690) 775c969 Make UploadInterruptedException visible (#12070) 6a4bbe5 Set heartbeat response Content-Type to text/plain (#12182) e4011c6 When InputStream cannot be opened while writing static resource response, display 404 instead of 500 (#10920) 20162db Set current instances when calling UI.push from VaadinSession.unlock (#12168) 94c0f86 Ensure VaadinSession.service is set up by storeInSession (#12204) 23ed487 Attempt to get GAE lock for UIDL requests (#12211) 7f52b2e Improved AbstractClientConnector performance (#12219) a934261 Improving performance of ConnectorTracker (#12218)