Fix comparison of PHP versions

Use the builtin function `version_compare` to check an app's
compatibility with the available PHP version, instead of reusing
the `OC\App\CompareVersion::isCompatible` method which is intended
to compare Nextcloud versions. PHP version strings do not always
necessarily follow the simple Major.Minor.Patch format used by
Nextcloud and therefore cannot be properly compared by that method.

Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>

Merge pull request #25085 from nextcloud/dependabot/submodules/3rdparty-1381d28

Merge pull request #25131 from nextcloud/fix/imports

Fix @nextcloud/vue imports

Bump 3rdparty from `7bbfe82` to `1381d28`

Bumps [3rdparty](https://github.com/nextcloud/3rdparty) from `7bbfe82` to `1381d28`.
- [Release notes](https://github.com/nextcloud/3rdparty/releases)
- [Commits](https://github.com/nextcloud/3rdparty/compare/7bbfe82c51aa168683ae6e47e3da7d3e587f6ca4...1381d2869a8c75fbe103a13b7a7223f9a11583f9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Fix @nextcloud/vue imports

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Merge pull request #25091 from nextcloud/enhancement/ocp-db-exception-abstraction

Add our own DB exception abstraction

Merge pull request #25084 from rfc2822/patch-2

Update DAVx5 in AuthToken.vue

Merge pull request #25114 from nextcloud/dismiss-reminder-notifications-from-passed-events

Dismiss reminder notifications from passed events

Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2

respect DB restrictions on number of arguments in statements and queries

Merge pull request #25110 from nextcloud/fix/24970/dashboard-greetings

Fix night condition in dashboard greeting

Update DAVx5 in AuthToken.vue

1. It's named DAVx5 (only very old clients have DAVdroid in the User-Agent)
2. Use passive matching (?:droid|x5) because otherwise, "x5" is recognized and shown as operating system
3. Also include the version postfix which contains information like "-beta2", which is important for the user

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #25065 from nextcloud/version/21/beta6

21 beta6

Dismiss reminder notifications from passed events

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

[tx-robot] updated from transifex

refs #24970 fix night condition in dashboard greeting

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>

silence psalm false positive

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #25105 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Add our own DB exception abstraction

Right now our API exports the Doctrine/dbal exception. As we've seen
with the dbal 3 upgrade, the leakage of 3rdparty types is problematic as
a dependency update means lots of work in apps, due to the direct
dependency of what Nextcloud ships. This breaks this dependency so that
apps only need to depend on our public API. That API can then be vendor
(db lib) agnostic and we can work around future deprecations/removals in
dbal more easily.

Right now the type of exception thrown is transported as "reason". For
the more popular types of errors we can extend the new exception class
and allow apps to catch specific errors only. Right now they have to
catch-check-rethrow. This is not ideal, but better than the dependnecy
on dbal.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #25089 from nextcloud/enhancement/ocp-db-types

Add our own db column types via the public API

Merge pull request #25088 from nextcloud/fix/allow_app_updates_again

Allow installing/updating of apps again

Migrate internal classes to the OCP db col types

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Add our own constants for db column types

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #24606 from hosting-de/feature/allow-symlinks-configurable

Add 'allow Symlinks' as an option to config.php

Fix option in the client code itself as well

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Allow installing/updating of apps again

The Guzzle API changed. We shall now use sink

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25080 from nextcloud/fix/file-scan-db

Fix database connection usage in the files scanner

Add 'allow Symlinks' as an option to config.php

Signed-off-by: Johannes Leuker <j.leuker@hosting.de>

Merge pull request #25087 from nextcloud/techdebt/noid/update-psalm-baseline-as-recommended.xml

Update psalm baseline to remove obsolete stuff

Fix casing of MySQLPlatform class name

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Update psalm baseline to remove obsolete stuff

As seen in CI static checks, some blocks in the baseline were not needed any
more.

This will fix static checks in CI.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

[tx-robot] updated from transifex

Merge pull request #25038 from nextcloud/bugfix/noid/install-mysql8-with-php8

Don't try a transaction for the migrator on MySQL

Fix database connection usage in the files scanner

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #25039 from nextcloud/fix/libxml-use-internal-errors-deprecated

Only use libxml_disable_entity_loader on php older than 8

Only rollback when not MySQL

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #25048 from nextcloud/dependabot/npm_and_yarn/webdav-3.6.2

Merge pull request #25034 from nextcloud/bugfix/noid/load-authentication-for-app-upgrades

Make sure to do priority app upgrades first

Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db

Add setup check to verify that the used DB version is still supported…

Merge pull request #25073 from nextcloud/psalm/24521/remove-unneeded-casts

Remove unneeded casts that were found by Psalm

Bump webdav from 3.6.1 to 3.6.2

Bumps [webdav](https://github.com/perry-mitchell/webdav-client) from 3.6.1 to 3.6.2.
- [Release notes](https://github.com/perry-mitchell/webdav-client/releases)
- [Changelog](https://github.com/perry-mitchell/webdav-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/perry-mitchell/webdav-client/compare/v3.6.1...v3.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

DB: warn on parameter number constraints

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

respect DB limits limit per statement and query

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #25070 from nextcloud/feature/noid/card-ros-definitions

Deck Rich-Object-String definitions for deck boards and cards

Merge pull request #24910 from nextcloud/dependachristoph/composer/scss-1.4.0

Bump scssphp/scssphp from 1.0.3 to 1.4.0

Merge pull request #25069 from nextcloud/bugfix/noid/regression-dont-touch-assignable-column

Don't remove assignable column for now

Remove unneeded casts that were found by Psalm

In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Unquote string when removing the hash from a color

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Make SCSS compliant

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Bump scssphp/scssphp from 1.0.3 to 1.4.0

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Deck Rich-Object-String definitions for deck boards and cards

Signed-off-by: Joas Schilling <coding@schilljs.com>

Don't remove assignable column for now

It causes side effects.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #25049 from nextcloud/dependabot/npm_and_yarn/webpack-4.45.0

Bump webpack from 4.44.2 to 4.45.0

Bumps [webpack](https://github.com/webpack/webpack) from 4.44.2 to 4.45.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.44.2...v4.45.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #24661 from nextcloud/external-storage-cant-edit

dont offer to edit external config settings if we can't edit them

21 beta6

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Merge pull request #25050 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #25047 from nextcloud/dependabot/npm_and_yarn/sinon-9.2.3

[tx-robot] updated from transifex

Bump sinon from 9.2.2 to 9.2.3

Bumps [sinon](https://github.com/sinonjs/sinon) from 9.2.2 to 9.2.3.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v9.2.2...v9.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Only use libxml_disable_entity_loader on php older than 8

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Don't try a transaction for the migrator on MySQL

As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
CREATE TABLE statements automatically commit always. The only reason
this worked in the past was that PHPs PDO connection didn't check the
actual state on commit, but only checked their internal state.
But in PHP8 this was fixed:
https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450
So now commit() fails because the internal PDO connection implicitly
commited already.

Signed-off-by: Joas Schilling <coding@schilljs.com>

adjust tests

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #24951 from nextcloud/version/21/beta5

21 beta5

dont offer to edit external config settings if we can't edit them

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #24948 from nextcloud/dependabot/composer/doctrine/dbal-3.0.0

Bump doctrine/dbal from 2.12.0 to 3.0.0

Merge pull request #22992 from nextcloud/password-urlencode

allow authenticating using urlencoded passwords

Update baseline.xml

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add setup check to verify that the used DB version is still supported in the next major release

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Use specific docker image tags to allow drone to cache them and not run into docker pull rate limits

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #25017 from nextcloud/fix-clearing-the-label-of-a-share

Fix clearing the label of a share

Make sure to do priority app upgrades first

Otherwise those apps might not be loaded when the others app migrations
are running. The previous loading of authentication apps in the upgrade
step never worked as it just returns in maintenance mode

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Rollback failed transactions in TestCase.php to not break followup tests

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Remove "primary" option from schema builder argument $options as it is not used anymore and triggers an exception

See https://github.com/doctrine/dbal/commit/138eb85234a1faeaa2e6a32cd7bcc66bb51c64e8#diff-300f55366adb50a32a40882ebdc95c163b141f64cba5f45f20bda04a907b3eb3L82

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Bump doctrine/dbal from 2.12.0 to 3.0.0

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #25031 from nextcloud/revert-25020-fix/noid/limitied-allowed-items-db-in

Revert "(LDAP) respect DB limits of arguments in an IN statement"

Revert "(LDAP) respect DB limits of arguments in an IN statement"

Fix clearing the label of a share

When the label is being edited its value is stored in "newLabel", and
the original label is shown only if "newLabel" is not set. However, as
it was checked against any falsy value instead of only undefined when
the label was cleared and thus it has an empty value the original label
was shown instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #25029 from nextcloud/rakekniven-patch-1

Change defaultapp in config.sample.php to dashboard to improve docs and align it to source code

Change defaultapp to dashboard

Result of discussion at https://help.nextcloud.com/t/enable-dashboard-on-per-user-basis/94872

Code reference:
https://github.com/nextcloud/server/blob/db86bea18ce41ad73e9c1a06f2b2d89d8d4f2ef8/lib/private/legacy/OC_Util.php#L1106

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>

Merge pull request #25015 from nextcloud/fix/no-double-intl-polyfill

Replace patchwork/utf8 with symfony-polyfill-*

Merge pull request #25020 from nextcloud/fix/noid/limitied-allowed-items-db-in

(LDAP) respect DB limits of arguments in an IN statement

Merge pull request #25021 from nextcloud/enhancement/occ-install-exception-trace

Print an exception trace for setup exceptions

Merge pull request #25025 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Merge pull request #24892 from nextcloud/fix/use-symfony-dispatcher-correctly

Use the Symfony dispatcher correctly

Merge pull request #23261 from nextcloud/enh/external-storage-session-type

Expose session based authentication through mount point type

Replace patchwork/utf8 with symfony-polyfill-*

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #24989 from nextcloud/scanner-ignore-non-readable

ignore files that have no read permissions during scanning

Add more previous exceptions to database setup code

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

respect DB limits of arguments in a IN list

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #24934 from nextcloud/max_file_uploads

Remove useless ini_set calls

Print an exception trace for setup exceptions

Right now any setup error will just result in the exception message
being printed. In some cases this doesn't give any insights into what
went wrong. This adds some dedicated logic to print the exception trace
and any previous exceptions to the CLI.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #24969 from nextcloud/dependabot/npm_and_yarn/core-js-3.8.2

Bump core-js from 3.8.1 to 3.8.2

Merge pull request #25018 from nextcloud/fix-name-of-avatar-integration-tests-in-drone

Fix name of avatar integration tests in Drone