]> source.dussan.org Git - tigervnc.git/log
tigervnc.git
8 years agoRemove clipboard code from vncconfig
Pierre Ossman [Tue, 12 Jan 2016 17:57:37 +0000 (18:57 +0100)]
Remove clipboard code from vncconfig

The clipboard is handled internally in the server now, so the
code in vncconfig is no longer useful.

8 years agoMove server to client clipboard out of vncconfig
Pierre Ossman [Tue, 12 Jan 2016 17:40:23 +0000 (18:40 +0100)]
Move server to client clipboard out of vncconfig

Also handle clipboard transactions from the server to the client
directly in the server without the help of vncconfig.

8 years agoMove client to server clipboard out of vncconfig
Pierre Ossman [Tue, 12 Jan 2016 16:33:32 +0000 (17:33 +0100)]
Move client to server clipboard out of vncconfig

Handle the clipboard directly in the server, avoiding the
dependency on vncconfig. This commit adds support for clipboard
from the client to the server. Handling of the other direction
will follow.

8 years agoRemove legacy Windows code
Pierre Ossman [Tue, 12 Jan 2016 11:32:15 +0000 (12:32 +0100)]
Remove legacy Windows code

We have lots of code that deals with Windows versions that we no
longer support anyway. Clean out all of this old cruft.

8 years agoRemove stub mirror driver code
Pierre Ossman [Tue, 12 Jan 2016 11:29:32 +0000 (12:29 +0100)]
Remove stub mirror driver code

We don't have any meaningful code for the mirror driver, so
remove the confusing stub and interface for it.

8 years agoShorten service identifier
Pierre Ossman [Tue, 12 Jan 2016 09:14:49 +0000 (10:14 +0100)]
Shorten service identifier

The identifier is used to compute the registry path, and should
ideally be kept short and without spaces.

8 years agoProvide description for services
Pierre Ossman [Tue, 12 Jan 2016 09:13:17 +0000 (10:13 +0100)]
Provide description for services

The argument named "desc" was not actually the description, but
rather the short "display name". Add handling for the actual
description to reduce confusion.

8 years agoBetter check for on screen visibility
Pierre Ossman [Mon, 11 Jan 2016 15:06:26 +0000 (16:06 +0100)]
Better check for on screen visibility

The check for visible drawables didn't account for compositing
which can place a window off-screen. Put all of these checks in
a common place and make sure it detects things properly.

8 years agoInstall viewer .desktop file and icons on all Unix systems
Pierre Ossman [Mon, 11 Jan 2016 11:38:32 +0000 (12:38 +0100)]
Install viewer .desktop file and icons on all Unix systems

These files are not Red Hat or Ubuntu specific, so install them
on all Unix systems where the viewer is installed.

8 years agoUbuntu package fixes
Brian P. Hinz [Sat, 9 Jan 2016 04:04:51 +0000 (23:04 -0500)]
Ubuntu package fixes

Adds missing build dependencies and fixes java compile issues
caused by non-ascii characters in comments.

8 years agoAllow Ubuntu 12.04 packages to build on any architecture
Brian P. Hinz [Wed, 6 Jan 2016 10:21:54 +0000 (05:21 -0500)]
Allow Ubuntu 12.04 packages to build on any architecture

Updating control file per suggestion in #258

8 years agoDebian package updates
Brian P. Hinz [Wed, 6 Jan 2016 04:07:13 +0000 (23:07 -0500)]
Debian package updates

[re #258] Add missing build-deps and allow deb to build on any arch

8 years agoBlock signals from being handled on worker threads
Pierre Ossman [Mon, 4 Jan 2016 13:19:15 +0000 (14:19 +0100)]
Block signals from being handled on worker threads

8 years agoCompile common code with -fPIC on all non-Windows platforms
Pierre Ossman [Mon, 4 Jan 2016 13:10:25 +0000 (14:10 +0100)]
Compile common code with -fPIC on all non-Windows platforms

There are more platforms than x86_64 that need -fPIC, so include
it whenever possible.

8 years agoDelete unnecessary patch files
Brian P. Hinz [Mon, 4 Jan 2016 03:08:54 +0000 (22:08 -0500)]
Delete unnecessary patch files

8 years agoRemove uncessary Xauth cookie patch from deb & rpm packages
Brian P. Hinz [Mon, 4 Jan 2016 03:04:02 +0000 (22:04 -0500)]
Remove uncessary Xauth cookie patch from deb & rpm packages

Obsoleted by 7461517

8 years agoUpdate Swedish translation
Göran Uddeborg [Tue, 29 Dec 2015 14:39:55 +0000 (15:39 +0100)]
Update Swedish translation

8 years agoFix race problem with detecting listening inetd sockets
Tristan Schmelcher [Fri, 2 Sep 2011 22:29:25 +0000 (15:29 -0700)]
Fix race problem with detecting listening inetd sockets

The previous detection would fail if the socket closed before we
had time to inspect it, which got us stuck in a loop as we would
try (and fail) to do accept() on a non-listening socket.

8 years agoAdd workaround for Vino's VeNCrypt implementation
Pierre Ossman [Tue, 29 Dec 2015 14:02:11 +0000 (15:02 +0100)]
Add workaround for Vino's VeNCrypt implementation

8 years agoSet up Xauthority using a single invokation
Pierre Ossman [Tue, 29 Dec 2015 13:30:32 +0000 (14:30 +0100)]
Set up Xauthority using a single invokation

8 years agoUse mcookie to generate X server cookie
Pierre Ossman [Tue, 29 Dec 2015 13:27:07 +0000 (14:27 +0100)]
Use mcookie to generate X server cookie

8 years agoCheck that xauth is in PATH
Pierre Ossman [Tue, 29 Dec 2015 13:24:55 +0000 (14:24 +0100)]
Check that xauth is in PATH

The rest of the code assumes xauth is in PATH, so let's check for
that instead.

8 years agoSuppress/eliminate JDK warnings
Brian P. Hinz [Sun, 27 Dec 2015 02:49:49 +0000 (21:49 -0500)]
Suppress/eliminate JDK warnings

8 years agoUpgrade in-tree jsch and jzlib to latest upstream versions
Brian P. Hinz [Sun, 27 Dec 2015 02:48:11 +0000 (21:48 -0500)]
Upgrade in-tree jsch and jzlib to latest upstream versions

8 years agoAdd snap tag to el7 packages
Brian P. Hinz [Fri, 25 Dec 2015 04:13:43 +0000 (23:13 -0500)]
Add snap tag to el7 packages

8 years agoAdd support for building RPM packages for RHEL 7 derivatives
Brian P. Hinz [Thu, 24 Dec 2015 23:27:26 +0000 (18:27 -0500)]
Add support for building RPM packages for RHEL 7 derivatives

8 years agoUpdate French translation
Stéphane Aulery [Wed, 23 Dec 2015 09:17:27 +0000 (10:17 +0100)]
Update French translation

8 years agoUpdate Brazilian Portuguese translation
Rafael Fontenelle [Fri, 18 Dec 2015 10:20:05 +0000 (11:20 +0100)]
Update Brazilian Portuguese translation

8 years agoUse --host and --build to prevent buildhost-specific optimizations
Brian P. Hinz [Sat, 12 Dec 2015 04:01:59 +0000 (23:01 -0500)]
Use --host and --build to prevent buildhost-specific optimizations

8 years agoOnly show sendPrimary on X11 platforms
Pierre Ossman [Thu, 10 Dec 2015 20:24:08 +0000 (21:24 +0100)]
Only show sendPrimary on X11 platforms

Primary selection is inherently a X11 concept so there is no point
showing the settings related to it on other platforms.

8 years agoInclude class keyword for friend declaration
Pierre Ossman [Tue, 8 Dec 2015 14:27:24 +0000 (15:27 +0100)]
Include class keyword for friend declaration

Only C++11 allows omitting the class keyword, so include it so
the code compiles with older compilers.

8 years agoInit socket subsystem before parsing filters
Pierre Ossman [Mon, 7 Dec 2015 11:13:20 +0000 (12:13 +0100)]
Init socket subsystem before parsing filters

Parsing a filter might be the first thing we do so we need to
make sure the socket subsystem is running so that we can look
up names.

8 years agoMerge branch 'master' of https://github.com/hackonteur/tigervnc
Pierre Ossman [Mon, 7 Dec 2015 10:10:03 +0000 (11:10 +0100)]
Merge branch 'master' of https://github.com/hackonteur/tigervnc

8 years agoUpdate German translation
Mario Blättermann [Mon, 7 Dec 2015 10:03:33 +0000 (11:03 +0100)]
Update German translation

8 years agoUpdate Danish translation
Joe Hansen [Mon, 7 Dec 2015 10:03:17 +0000 (11:03 +0100)]
Update Danish translation

8 years agoUpdate Dutch translation
Benno Schulenberg [Mon, 7 Dec 2015 10:02:59 +0000 (11:02 +0100)]
Update Dutch translation

8 years agoReplace external wget with native Python version 246/head
Scott Roland [Sat, 5 Dec 2015 00:06:48 +0000 (00:06 +0000)]
Replace external wget with native Python version

This makes it easier to handle common exceptions. I was motivated
because the Mesa URL is currently broken and wasn't handled well.

Implementation mostly copied from here:
  http://stackoverflow.com/questions/22676/how-do-i-download-a-file-over-http-using-python

8 years agoFix coding to be utf-8 instead of UTF-8
Scott Roland [Fri, 4 Dec 2015 20:03:31 +0000 (20:03 +0000)]
Fix coding to be utf-8 instead of UTF-8

Old UTF-8 resulted in this error from GNU Emacs:
  Warning (mule): Invalid coding system `UTF-8' is specified
  for the current buffer/file by the :coding tag.
  It is highly recommended to fix it before writing to a file.

8 years agoUpdate Bulgarian translation
Alexander Shopov [Fri, 4 Dec 2015 11:26:50 +0000 (12:26 +0100)]
Update Bulgarian translation

8 years agoUpdate Finnish translation
Jorma Karvonen [Fri, 4 Dec 2015 11:26:22 +0000 (12:26 +0100)]
Update Finnish translation

8 years agoUpdate Swedish translation
Göran Uddeborg [Thu, 3 Dec 2015 09:06:34 +0000 (10:06 +0100)]
Update Swedish translation

8 years agoUpdate Ukrainian translation
Yuri Chornoivan [Wed, 2 Dec 2015 15:36:08 +0000 (16:36 +0100)]
Update Ukrainian translation

8 years agoMerge branch 'multicore' of https://github.com/CendioOssman/tigervnc
Pierre Ossman [Wed, 2 Dec 2015 15:22:37 +0000 (16:22 +0100)]
Merge branch 'multicore' of https://github.com/CendioOssman/tigervnc

8 years agoPerformance analysis of multi-core decoder 242/head
Pierre Ossman [Wed, 2 Dec 2015 15:16:01 +0000 (16:16 +0100)]
Performance analysis of multi-core decoder

8 years agoGracefully handle empty CopyArea operations
Pierre Ossman [Mon, 30 Nov 2015 12:08:19 +0000 (13:08 +0100)]
Gracefully handle empty CopyArea operations

8 years agoMerge branch 'master' of https://github.com/hackonteur/tigervnc
Pierre Ossman [Mon, 30 Nov 2015 09:49:22 +0000 (10:49 +0100)]
Merge branch 'master' of https://github.com/hackonteur/tigervnc

8 years agoModularized el5 & el6 RPM specs
Brian P. Hinz [Sun, 29 Nov 2015 16:56:53 +0000 (11:56 -0500)]
Modularized el5 & el6 RPM specs

Split the static library pre-reqs into a static-devel package
so that they don't need to be rebuilt everytime tigervnc's
sources change.

8 years agoFix relative PATH to SRCDIR 241/head
Scott Roland [Sun, 29 Nov 2015 23:41:22 +0000 (23:41 +0000)]
Fix relative PATH to SRCDIR

8 years agoOptimised shortcut for decoding on single CPU systems
Pierre Ossman [Tue, 24 Nov 2015 16:15:16 +0000 (17:15 +0100)]
Optimised shortcut for decoding on single CPU systems

8 years agoLimit the number of decoder threads to 4
Pierre Ossman [Fri, 20 Nov 2015 15:14:48 +0000 (16:14 +0100)]
Limit the number of decoder threads to 4

They just end up burning CPU fighting each other without much
improvement to the decoding time beyond four threads.

8 years agoThrottle overlapping screen updates
Pierre Ossman [Wed, 18 Nov 2015 15:24:16 +0000 (16:24 +0100)]
Throttle overlapping screen updates

We need to make sure the display server has finished reading our
previous update before we overwrite the buffer with the next update.

8 years agoConsolidate how to run the FLTK loop in one place
Pierre Ossman [Wed, 18 Nov 2015 15:23:21 +0000 (16:23 +0100)]
Consolidate how to run the FLTK loop in one place

8 years agoPropagate exceptions from worker threads back to main thread
Pierre Ossman [Tue, 17 Nov 2015 08:37:57 +0000 (09:37 +0100)]
Propagate exceptions from worker threads back to main thread

8 years agoEstimate CPU core usage in performance tests
Pierre Ossman [Mon, 16 Nov 2015 08:37:46 +0000 (09:37 +0100)]
Estimate CPU core usage in performance tests

This is based on comparing CPU time with elapsed time, which means
that the tests can be heavily influenced by other load on the test
machine.

8 years agoProtect PlatformPixelBuffer from simultaneous access
Pierre Ossman [Fri, 13 Nov 2015 13:09:27 +0000 (14:09 +0100)]
Protect PlatformPixelBuffer from simultaneous access

The damage tracking region needs to be protected from multiple
threads accessing it at once. The rest should be fine though.

8 years agoCreate one decode thread for each CPU
Pierre Ossman [Fri, 13 Nov 2015 13:07:52 +0000 (14:07 +0100)]
Create one decode thread for each CPU

We can start creating more decoding threads now that we handle
rect ordering properly. No point in creating more threads than
there are CPUs though.

8 years agoAdd option to enable thread sanitizer
Pierre Ossman [Fri, 13 Nov 2015 13:06:35 +0000 (14:06 +0100)]
Add option to enable thread sanitizer

8 years agoAllow parallel decoding of Tight JPEG rects
Pierre Ossman [Fri, 13 Nov 2015 10:16:33 +0000 (11:16 +0100)]
Allow parallel decoding of Tight JPEG rects

The cost is some more load on malloc(), but it should be small
compared to the gains of spreading the CPU heavy JPEG decoding
over multiple CPUs.

8 years agoAllow conditional dependencies between rects when decoding
Pierre Ossman [Fri, 13 Nov 2015 09:47:28 +0000 (10:47 +0100)]
Allow conditional dependencies between rects when decoding

Some encodings only cause dependencies between rects some of the
time. Make sure we can allow parallel decoding of those rect that
aren't dependent on each other.

8 years agoDecode rectangles in order if needed
Pierre Ossman [Thu, 12 Nov 2015 12:18:22 +0000 (13:18 +0100)]
Decode rectangles in order if needed

Some encodings must be handled in the order they are received.
Make sure we respect this in the decode manager.

8 years agoDecode overlapping rectangles in order
Pierre Ossman [Thu, 12 Nov 2015 12:17:42 +0000 (13:17 +0100)]
Decode overlapping rectangles in order

8 years agoAdd flags member to decoders
Pierre Ossman [Thu, 12 Nov 2015 12:07:42 +0000 (13:07 +0100)]
Add flags member to decoders

Allows us to add attributes later that affect of the decoder
manager deals with the decoders.

8 years agoMake the decoder multi-threaded
Pierre Ossman [Thu, 12 Nov 2015 11:21:58 +0000 (12:21 +0100)]
Make the decoder multi-threaded

This implements the basic infrastructure for multi-threaded
decoding of rects. However there is just one thread reading data
and one thread decoding it. More logic is needed to safely decode
multiple rects at the same time.

8 years agoLet CConnection intercept more callbacks
Pierre Ossman [Thu, 12 Nov 2015 11:20:05 +0000 (12:20 +0100)]
Let CConnection intercept more callbacks

We need more callbacks for correct operation of multi-threaded
rect decoding.

8 years agoAdd abstraction classes for system thread primitives
Pierre Ossman [Thu, 12 Nov 2015 11:16:08 +0000 (12:16 +0100)]
Add abstraction classes for system thread primitives

8 years agoRaise system requirement on Windows to Vista/2008
Pierre Ossman [Thu, 12 Nov 2015 11:17:34 +0000 (12:17 +0100)]
Raise system requirement on Windows to Vista/2008

We need the newer versions of Windows to get access to better
thread primitives.

8 years agoFix copy-paste error for the secTypeX509Vnc security type
Pierre Ossman [Wed, 11 Nov 2015 12:12:45 +0000 (13:12 +0100)]
Fix copy-paste error for the secTypeX509Vnc security type

8 years agoClear up ZlibInStream::reset() behaviour
Pierre Ossman [Wed, 11 Nov 2015 12:11:09 +0000 (13:11 +0100)]
Clear up ZlibInStream::reset() behaviour

It previously only did a reset of the ZlibInStream object, not the
underlying zlib stream. It also had the side effect of flushing
the underlying stream and disassociating from it.

Clear things up by changing the naming, and introducing a proper
reset function (which is needed by the Tight decoder).

8 years agoSplit decoders into a read and decode step
Pierre Ossman [Tue, 10 Nov 2015 16:17:34 +0000 (17:17 +0100)]
Split decoders into a read and decode step

We need to split these steps up in preparation for multi-core
support. Reading needs to be done in a serial manner, whilst
decoding can be done in parallel.

This also involved a rather large cleanup of the Tight decoder.

8 years agoAdd efficient method to copy data between two streams
Pierre Ossman [Tue, 10 Nov 2015 16:13:27 +0000 (17:13 +0100)]
Add efficient method to copy data between two streams

8 years agoRemove unneeded virtual qualifiers on stream methods
Pierre Ossman [Tue, 10 Nov 2015 16:12:56 +0000 (17:12 +0100)]
Remove unneeded virtual qualifiers on stream methods

8 years agoRemove CMsgReader::getImageBuf() as nothing uses it
Pierre Ossman [Tue, 10 Nov 2015 12:03:26 +0000 (13:03 +0100)]
Remove CMsgReader::getImageBuf() as nothing uses it

8 years agoDecouple decoders from CConnection
Pierre Ossman [Tue, 10 Nov 2015 12:02:12 +0000 (13:02 +0100)]
Decouple decoders from CConnection

8 years agoMake ConnParams useful when const
Pierre Ossman [Tue, 10 Nov 2015 11:58:49 +0000 (12:58 +0100)]
Make ConnParams useful when const

8 years agoDelegate decoder object management to a separate class
Pierre Ossman [Mon, 9 Nov 2015 15:34:54 +0000 (16:34 +0100)]
Delegate decoder object management to a separate class

Done in preparation for multi-core decoding. Keeps the complexity
out of the other classes. This also moves ownership of the
framebuffer in to CConnection. It's the CConnection object that is
aware of the threads and how to synchronise with them. Therefore
the ownership of the framebuffer must also be there to make sure
it isn't deleted whilst threads are working.

8 years agoUpdate RPM dependency sources to latest versions
Brian P. Hinz [Thu, 26 Nov 2015 15:41:47 +0000 (10:41 -0500)]
Update RPM dependency sources to latest versions

Several of the pre-requisites have outstanding CVEs.

8 years agoChange development version to 1.6.80
Pierre Ossman [Thu, 26 Nov 2015 11:39:02 +0000 (12:39 +0100)]
Change development version to 1.6.80

8 years agoUpdate translation template file
Pierre Ossman [Thu, 26 Nov 2015 11:35:39 +0000 (12:35 +0100)]
Update translation template file

9 years agoFix inverted logic in ProcVncExtSetParam. 236/head
Michal Srb [Thu, 12 Nov 2015 13:03:28 +0000 (15:03 +0200)]
Fix inverted logic in ProcVncExtSetParam.

9 years agoClean out unused dependencies from CConnection.h
Pierre Ossman [Mon, 9 Nov 2015 14:48:19 +0000 (15:48 +0100)]
Clean out unused dependencies from CConnection.h

9 years agoInclude kernel time in CPU usage measurement
Pierre Ossman [Mon, 9 Nov 2015 14:29:30 +0000 (15:29 +0100)]
Include kernel time in CPU usage measurement

Time spent executing in the kernel is as much of a performance problem
as time spent in userspace. Make sure both numbers are included.

9 years agoRemove old Windows CE code
Pierre Ossman [Mon, 9 Nov 2015 14:28:50 +0000 (15:28 +0100)]
Remove old Windows CE code

9 years agoUse mingw's gettimeofday()
Pierre Ossman [Mon, 9 Nov 2015 14:27:54 +0000 (15:27 +0100)]
Use mingw's gettimeofday()

mingw has a perfectly functional gettimeofday() so use that instead
of having multiple copies of our own version.

9 years agoRemove unused deleteReaderAndWriter() method
Pierre Ossman [Mon, 9 Nov 2015 14:26:56 +0000 (15:26 +0100)]
Remove unused deleteReaderAndWriter() method

9 years agooption -xstartup added 231/head
Llorenç Garcia Martinez [Fri, 30 Oct 2015 10:11:56 +0000 (11:11 +0100)]
option -xstartup added

9 years agooption -xstartup added
Llorenç Garcia Martinez [Fri, 30 Oct 2015 10:07:40 +0000 (11:07 +0100)]
option -xstartup added

9 years agoMerge branch 'patch-1' of https://github.com/Siot/tigervnc
Pierre Ossman [Fri, 30 Oct 2015 09:38:00 +0000 (10:38 +0100)]
Merge branch 'patch-1' of https://github.com/Siot/tigervnc

9 years agoXvnc.man: remove -i option 229/head
Kirill Kolyshkin [Thu, 29 Oct 2015 00:01:07 +0000 (17:01 -0700)]
Xvnc.man: remove -i option

Xvnc does not understand -i as an alias to -interface anymore (since commit f8e3b34c69)
but it is still listed in the man page.

Fix man accordingly

Signed-off-by: Kir Kolyshkin <kir@openvz.org>
9 years agoMerge branch 'master' of https://github.com/graysky2/tigervnc
Pierre Ossman [Tue, 27 Oct 2015 13:31:39 +0000 (14:31 +0100)]
Merge branch 'master' of https://github.com/graysky2/tigervnc

9 years agoAllow BUILD_TIMESTAMP to be set statically
DRC [Sat, 17 Oct 2015 23:55:08 +0000 (18:55 -0500)]
Allow BUILD_TIMESTAMP to be set statically

9 years agoAllow static linking against only the GCC libs
DRC [Sat, 17 Oct 2015 23:13:05 +0000 (18:13 -0500)]
Allow static linking against only the GCC libs

9 years agoMerge branch 'jpeg_includes' of https://github.com/dcommander/tigervnc
Pierre Ossman [Tue, 27 Oct 2015 13:08:32 +0000 (14:08 +0100)]
Merge branch 'jpeg_includes' of https://github.com/dcommander/tigervnc

9 years agoAdded -noxstartup 226/head
Llorenç Garcia Martinez [Fri, 23 Oct 2015 11:42:13 +0000 (13:42 +0200)]
Added -noxstartup

9 years agonew option -noxstartup to not load any xstartup script file
Llorenç Garcia Martinez [Fri, 23 Oct 2015 11:37:42 +0000 (13:37 +0200)]
new option -noxstartup to not load any xstartup script file

9 years agoprovide a systemd user service unit for vncserver 221/head
graysky [Mon, 19 Oct 2015 12:27:27 +0000 (08:27 -0400)]
provide a systemd user service unit for vncserver

9 years agoupdate manpage teaching about ~/.vnc/config
graysky [Mon, 19 Oct 2015 12:26:44 +0000 (08:26 -0400)]
update manpage teaching about ~/.vnc/config

9 years agoupdate vncserver to parse a config file
graysky [Mon, 19 Oct 2015 12:24:14 +0000 (08:24 -0400)]
update vncserver to parse a config file

9 years agoFlush entire JPEG buffer, ignoring state
Pierre Ossman [Fri, 16 Oct 2015 11:03:14 +0000 (13:03 +0200)]
Flush entire JPEG buffer, ignoring state

libjpeg doesn't update the buffer state before calling the
empty_output_buffer() callback so we need to flush everything,
not just the apparent size.

9 years agoEnsure that libjpeg-turbo headers are included 222/head
DRC [Fri, 16 Oct 2015 08:28:58 +0000 (03:28 -0500)]
Ensure that libjpeg-turbo headers are included

On some systems, the build was picking up jpeglib.h from the system
include directories, and if the system's version of libjpeg[-turbo] used
a different API/ABI version than the one specified in JPEG_LIBRARY, this
led to a "Wrong JPEG library version" error at run time.

9 years agoMerge pull request #219 from astrand/master
astrand [Wed, 14 Oct 2015 11:58:12 +0000 (13:58 +0200)]
Merge pull request #219 from astrand/master

Meta no longer sends Super.