]> source.dussan.org Git - aspectj.git/log
aspectj.git
10 months agoAdd runtime and weaver API javadocs to installer again
Alexander Kriegisch [Sat, 6 Jan 2024 05:49:48 +0000 (12:49 +0700)]
Add runtime and weaver API javadocs to installer again

Closes #271.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoDocs: Create separate CSS files, do not embed into HTML
Alexander Kriegisch [Sat, 6 Jan 2024 05:47:44 +0000 (12:47 +0700)]
Docs: Create separate CSS files, do not embed into HTML

TODO: There still is one set of CSS files per subdirectory due to the
way the docs directories are organised. It would be better to have them
just once. But to achieve that, the ADOC-to-HTML conversion would have
to be changed, e.g. using one central directory for images and
reorganisation of the overall directory structure and build options.
See https://github.com/asciidoctor/asciidoctor-maven-plugin/issues/729.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoBugfix: AspectJ installer extracts text files as US-ASCII
Alexander Kriegisch [Fri, 5 Jan 2024 07:35:24 +0000 (14:35 +0700)]
Bugfix: AspectJ installer extracts text files as US-ASCII

When extracting text or HTML files, special characters like German
umlauts "ÄÖÜäöüß" or copyright symbol "©" were destroyed while unpacking
the installer archive. As our files in Git SCM are all UTF-8, the
installer now also uses UTF-8 to read and write text files.

Fixes #270.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMinor changes in IDE.md
Alexander Kriegisch [Fri, 5 Jan 2024 05:00:32 +0000 (12:00 +0700)]
Minor changes in IDE.md

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoRename doc generation profiles, making Asciidoctor the default
Alexander Kriegisch [Fri, 5 Jan 2024 04:30:00 +0000 (11:30 +0700)]
Rename doc generation profiles, making Asciidoctor the default

The Docbook etc. Ant task profile is now called 'create-docs-LEGACY' and
will go away with the cut-over to the new doc generator logic.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoAsciidoc: Create PDFs from multi-page guides
Alexander Kriegisch [Fri, 5 Jan 2024 04:28:07 +0000 (11:28 +0700)]
Asciidoc: Create PDFs from multi-page guides

Using Asciidoctor Maven, we now produce PDFs (which are also linked to
from the main documentation index page) for
  - Programming Guide,
  - AspectJ 5 Developer's Notebook,
  - Development Environment Guide,
  - Problem Diagnosis Guide,
  - AspectJ Design Overview.

Attention! PDF generation alone takes 3+ minutes, almost 4 minutes
including asciidoc to HTML conversion. Just deactivate the 'create-docs'
profile if you do not need docs during the build.

Closes #272.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoReplace docs GIFs by PNGs
Alexander Kriegisch [Fri, 5 Jan 2024 01:37:14 +0000 (08:37 +0700)]
Replace docs GIFs by PNGs

Follow-up on previous rename-only commit. This time, the binaries are
real PNGs. The asciidoc and other references to them have also been
replaced. File figures_classes.png in the teaching materials also was
rotated by 90° to display it correctly.

Background: The Asciidoctor PDF back-end cannot handle GIFs directly
without an additional Ruby Gem. It is easier to only use PNGs and JPEGs.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoRename docs GIF to PNG
Alexander Kriegisch [Fri, 5 Jan 2024 01:22:27 +0000 (08:22 +0700)]
Rename docs GIF to PNG

The files are still GIFs for now. In the next steps after the rename,
they will be replaced by real PNGs.

Background: The Asciidoctor PDF back-end cannot handle GIFs directly
without an additional Ruby Gem. It is easier to only use PNGs and JPEGs.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoFix some broken/invalid ADOC links
Alexander Kriegisch [Thu, 4 Jan 2024 08:08:24 +0000 (15:08 +0700)]
Fix some broken/invalid ADOC links

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoREADME.md: Beautify link to Maven Central
Alexander Kriegisch [Thu, 4 Jan 2024 06:46:57 +0000 (13:46 +0700)]
README.md: Beautify link to Maven Central

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoFix warning in Asciidoctor Maven by JRuby version bump
Alexander Kriegisch [Thu, 4 Jan 2024 06:42:52 +0000 (13:42 +0700)]
Fix warning in Asciidoctor Maven by JRuby version bump

Warning "Native subprocess control requires open access to the JDK IO
subsystem" can be avoided by upgrading JRuby, see
https://github.com/asciidoctor/asciidoctor-maven-plugin/issues/553.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMove image used in IDE.md to images subfolder
Alexander Kriegisch [Thu, 4 Jan 2024 06:26:23 +0000 (13:26 +0700)]
Move image used in IDE.md to images subfolder

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoDelete some unused images from docs
Alexander Kriegisch [Thu, 4 Jan 2024 06:25:55 +0000 (13:25 +0700)]
Delete some unused images from docs

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMove progguide images to subfolder
Alexander Kriegisch [Thu, 4 Jan 2024 06:18:25 +0000 (13:18 +0700)]
Move progguide images to subfolder

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoRename Visio files for images used in compiler-weaver.adoc
Alexander Kriegisch [Thu, 4 Jan 2024 06:15:09 +0000 (13:15 +0700)]
Rename Visio files for images used in compiler-weaver.adoc

to match the GIF file names, so it is easy to recognise which Visio file
was used to create which GIF, even if no Visio viewer is available.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoAdjust image links in compiler-weaver.adoc
Alexander Kriegisch [Thu, 4 Jan 2024 06:13:43 +0000 (13:13 +0700)]
Adjust image links in compiler-weaver.adoc

After move in previous commit, now the paths have been fixed, too.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMove compiler-weaver.adoc up one directory level
Alexander Kriegisch [Thu, 4 Jan 2024 06:07:07 +0000 (13:07 +0700)]
Move compiler-weaver.adoc up one directory level

Also rename ADOC on the way and move images to subdirectory.
This makes the Maven Resource execution superfluous.

TODO: Adjust image links in compiler-weaver.adoc in next commit.
Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMove main license and readme files to docs root directory
Alexander Kriegisch [Thu, 4 Jan 2024 06:01:55 +0000 (13:01 +0700)]
Move main license and readme files to docs root directory

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoReformat asciidoc source for main docs page
Alexander Kriegisch [Thu, 4 Jan 2024 05:01:19 +0000 (12:01 +0700)]
Reformat asciidoc source for main docs page

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoLink to Java version compatibility matrix from main docs page
Alexander Kriegisch [Thu, 4 Jan 2024 04:42:35 +0000 (11:42 +0700)]
Link to Java version compatibility matrix from main docs page

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoChange syntax in JavaVersionCompatibility.adoc to asciidoc
Alexander Kriegisch [Thu, 4 Jan 2024 04:28:09 +0000 (11:28 +0700)]
Change syntax in JavaVersionCompatibility.adoc to asciidoc

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoRename JavaVersionCompatibility.md to .adoc
Alexander Kriegisch [Thu, 4 Jan 2024 04:27:13 +0000 (11:27 +0700)]
Rename JavaVersionCompatibility.md to .adoc

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMove JavaVersionCompatibility.md to release directory
Alexander Kriegisch [Thu, 4 Jan 2024 04:22:40 +0000 (11:22 +0700)]
Move JavaVersionCompatibility.md to release directory

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoFix referenced images in README-1.6.7
Alexander Kriegisch [Thu, 4 Jan 2024 03:40:11 +0000 (10:40 +0700)]
Fix referenced images in README-1.6.7

Before, only one image was referenced, consisting of a screenshot of two
diagrams. The other image file, containing just one of the diagrams, was
not used. Now, both images have been cropped correctly and are both
referenced separately from the release notes.

Better late than never...

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMove release notes README-*.adoc to separate directory
Alexander Kriegisch [Thu, 4 Jan 2024 03:37:45 +0000 (10:37 +0700)]
Move release notes README-*.adoc to separate directory

Also move two more release-related documents.
All referenced images are now in a common subdirectory.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMove quick reference DOC/PDF files to separate directory
Alexander Kriegisch [Thu, 4 Jan 2024 03:20:29 +0000 (10:20 +0700)]
Move quick reference DOC/PDF files to separate directory

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMove docs examples directory two levels up
Alexander Kriegisch [Thu, 4 Jan 2024 03:12:59 +0000 (10:12 +0700)]
Move docs examples directory two levels up

Now, the location more closely resembles where it is on the website.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoBulk-rename release read-me files to version numbers with dots
Alexander Kriegisch [Thu, 4 Jan 2024 01:29:34 +0000 (08:29 +0700)]
Bulk-rename release read-me files to version numbers with dots

Also rename references. E.g.
  - RELEASE-11   -> RELEASE-1.1
  - RELEASE-1810 -> RELEASE-1.8.10
  - RELEASE-1921 -> RELEASE-1.9.21

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoDelete 50+ XML DocBook resource files
Alexander Kriegisch [Thu, 4 Jan 2024 01:13:04 +0000 (08:13 +0700)]
Delete 50+ XML DocBook resource files

in favour of the already existing asciidoc ones.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoFix/add more links for multi-page docs
Alexander Kriegisch [Wed, 3 Jan 2024 07:14:35 +0000 (14:14 +0700)]
Fix/add more links for multi-page docs

In each case, link both to multi- and single-page docs separately.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoAdjust design overview docs to other multi-page docs
Alexander Kriegisch [Wed, 3 Jan 2024 07:05:32 +0000 (14:05 +0700)]
Adjust design overview docs to other multi-page docs

- Link to other pages in index.adoc
- Include other pages in design-overview.adoc

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoRemove references and docs about obsolete tools
Alexander Kriegisch [Wed, 3 Jan 2024 07:03:53 +0000 (14:03 +0700)]
Remove references and docs about obsolete tools

- AspectJ Browser (ajbrowser)
- Forte IDE integration
- JBuilder IDE integration
- Emacs integration

All this information was old and outdated. Ajbrowser was removed from
AspectJ a while ago. If the other tools even still exist, any possibly
existing AspectJ support is not part of AspectJ itself.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoRemove 'imagesdir' from Asciidoctor Maven config
Alexander Kriegisch [Wed, 3 Jan 2024 06:52:35 +0000 (13:52 +0700)]
Remove 'imagesdir' from Asciidoctor Maven config

User relative paths for images instead.

In one case, we need to copy images from a subdirectory one level up,
because otherwise the images are only found in the included document,
but not in the single-page one including it from the subdirectory. In
all other cases, included ADOCs are located in the same directory as the
including document.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoFix most xref/link URLs in main documentation index
Alexander Kriegisch [Wed, 3 Jan 2024 03:43:34 +0000 (10:43 +0700)]
Fix most xref/link URLs in main documentation index

To do:
  - API docs (javadoc)
  - all-in-one guides
  - Eclipse website links
  - add links to markdown files (maybe convert md to adoc)

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMove main documentation index for website to root directory
Alexander Kriegisch [Wed, 3 Jan 2024 03:40:26 +0000 (10:40 +0700)]
Move main documentation index for website to root directory

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoAdd asciidoc release notes up to 1.9.21
Alexander Kriegisch [Tue, 2 Jan 2024 03:48:51 +0000 (10:48 +0700)]
Add asciidoc release notes up to 1.9.21

and fix some minor punctuation issues in older release notes.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoAdd README-198.adoc, README-199.adoc
Alexander Kriegisch [Sat, 9 Oct 2021 07:43:49 +0000 (09:43 +0200)]
Add README-198.adoc, README-199.adoc

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoRename '*GuideDB' directories to their actual HTML site target names
Alexander Kriegisch [Sat, 8 Jan 2022 04:50:55 +0000 (11:50 +0700)]
Rename '*GuideDB' directories to their actual HTML site target names

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoExperimentally add asciidoctor-maven-plugin to 'docs' module
Alexander Kriegisch [Sat, 8 Jan 2022 04:49:07 +0000 (11:49 +0700)]
Experimentally add asciidoctor-maven-plugin to 'docs' module

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoRemove all references to AOSD, but mention Spring
Alexander Kriegisch [Tue, 10 Aug 2021 01:31:57 +0000 (08:31 +0700)]
Remove all references to AOSD, but mention Spring

- The website is just a front page.
- I failed to contact anyone via:
    * fb9553b7471df638478bbf918044bf52.gdrp@customers.whoisprivacycorp.com
    * info@aosd.net
    * admin@aosd.net
- The discuss@aosd.net mailing list had its last post 6 years ago and
  the last one concerning AspectJ 11 years ago according to the archive
  at https://discuss.aosd.narkive.com/.

Mention Spring support for native AspectJ an Spring AOP as a real world
example in the FAQ.

Also remove an FAQ link to a no longer existing PARC website about
AspectJ and fix a small typo.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoAsciiDoc: updates in main index and FAQ (WIP)
Alexander Kriegisch [Sat, 24 Jul 2021 05:12:40 +0000 (12:12 +0700)]
AsciiDoc: updates in main index and FAQ (WIP)

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoGlobally fix spelling error "dependancy/dependancies"
Alexander Kriegisch [Fri, 23 Jul 2021 04:33:47 +0000 (11:33 +0700)]
Globally fix spelling error "dependancy/dependancies"

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoGlobally replace HTTP links to eclipse.org by HTTPS
Alexander Kriegisch [Fri, 23 Jul 2021 04:31:13 +0000 (11:31 +0700)]
Globally replace HTTP links to eclipse.org by HTTPS

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoRemove outdated JDeveloper links from AsciiDocs
Alexander Kriegisch [Tue, 20 Jul 2021 07:58:05 +0000 (14:58 +0700)]
Remove outdated JDeveloper links from AsciiDocs

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMore AsciiDoc formatting improvements (WIP)
Alexander Kriegisch [Mon, 19 Jul 2021 05:12:37 +0000 (12:12 +0700)]
More AsciiDoc formatting improvements (WIP)

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoImprove release notes formatting
Alexander Kriegisch [Mon, 19 Jul 2021 05:11:38 +0000 (12:11 +0700)]
Improve release notes formatting

Also unify the way copyright and release date is displayed

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoFinish AsciiDoc improvements in ADK Developer's Notebook (WIP)
Alexander Kriegisch [Sat, 17 Jul 2021 04:42:41 +0000 (11:42 +0700)]
Finish AsciiDoc improvements in ADK Developer's Notebook (WIP)

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoMore AsciiDoc improvements, mostly about code formatting (WIP)
Alexander Kriegisch [Fri, 16 Jul 2021 11:45:52 +0000 (18:45 +0700)]
More AsciiDoc improvements, mostly about code formatting (WIP)

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoFix more AsciiDoc links and code blocks (WIP)
Alexander Kriegisch [Fri, 16 Jul 2021 03:48:06 +0000 (10:48 +0700)]
Fix more AsciiDoc links and code blocks (WIP)

- Add Java syntax highlighting to AspectJ and Java files
- Add XML syntax highlighting to XML files (Ant, LTW etc.)
- Dedent and remove empty lines, where necessary
- Enclose in-line line numbers for Java code in /*23*/ comments in order
  to enable Java formatting

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoFix some AsciiDoc links (WIP)
Alexander Kriegisch [Tue, 13 Jul 2021 05:07:45 +0000 (12:07 +0700)]
Fix some AsciiDoc links (WIP)

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
10 months agoAdd initial set of AsciiDoc files, converted from HTML/XML
Alexander Kriegisch [Tue, 29 Jun 2021 06:18:25 +0000 (13:18 +0700)]
Add initial set of AsciiDoc files, converted from HTML/XML

Some originals have been deleted already. Others, especially the user
guides, still exist in both formats because they have not been
proof-read and probably lots of links do not function as expected. But I
want to see what the files look like directly on GitHun.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoAdd minimal JRE version check to Main.runMain
Alexander Kriegisch [Fri, 15 Dec 2023 07:56:50 +0000 (14:56 +0700)]
Add minimal JRE version check to Main.runMain

Use new constant Main.MINIMAL_JRE_VERSION (currently = 17) and
SourceVersion.latest().ordinal() to check, if the minimal JRE version
requirement for AJC is met. If not, then exit with code -1 and error
message "The AspectJ compiler needs at least Java runtime 17".

Relates to #269.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoDepend on JDT Core 1.9.21.1-SNAPSHOT
Alexander Kriegisch [Fri, 15 Dec 2023 05:19:28 +0000 (12:19 +0700)]
Depend on JDT Core 1.9.21.1-SNAPSHOT

The new version is compiled to target 17. This should avoid the strange
"NoSuchFieldError: RELEASE_17" error message in AJC.

Closes #269.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoSet version to 1.9.21.1-SNAPSHOT
Alexander Kriegisch [Fri, 15 Dec 2023 04:52:41 +0000 (11:52 +0700)]
Set version to 1.9.21.1-SNAPSHOT

Currently, the situation looks more like a Java 21 maintenance release
than directly a Java 22 release.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoRemove some TODOs from tests after upstream JDT Core fixes
Alexander Kriegisch [Thu, 14 Dec 2023 13:17:51 +0000 (20:17 +0700)]
Remove some TODOs from tests after upstream JDT Core fixes

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoAdd info about #269 to 1.9.21 release notes
Alexander Kriegisch [Thu, 14 Dec 2023 13:16:27 +0000 (20:16 +0700)]
Add info about #269 to 1.9.21 release notes

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoJavaVersionCompatibility.md: Update for AspectJ 1.9.21
Alexander Kriegisch [Thu, 14 Dec 2023 11:19:08 +0000 (18:19 +0700)]
JavaVersionCompatibility.md: Update for AspectJ 1.9.21

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoIDE.md: Add Eclipse 2023-12 update sites for AJDT
Alexander Kriegisch [Tue, 12 Dec 2023 04:35:29 +0000 (11:35 +0700)]
IDE.md: Add Eclipse 2023-12 update sites for AJDT

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoFix typo in README-1921.html
Alexander Kriegisch [Mon, 11 Dec 2023 04:22:42 +0000 (11:22 +0700)]
Fix typo in README-1921.html

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoSet version to 1.9.22-SNAPSHOT
Alexander Kriegisch [Mon, 11 Dec 2023 03:07:25 +0000 (10:07 +0700)]
Set version to 1.9.22-SNAPSHOT

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoRelease AspectJ 1.9.21 V1_9_21
Alexander Kriegisch [Mon, 11 Dec 2023 03:05:53 +0000 (10:05 +0700)]
Release AspectJ 1.9.21

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoAdd AspectJ 1.9.21 release notes
Alexander Kriegisch [Mon, 11 Dec 2023 02:49:02 +0000 (09:49 +0700)]
Add AspectJ 1.9.21 release notes

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoAdd tests for Java 21 unnamed classes and instance methods
Alexander Kriegisch [Mon, 11 Dec 2023 02:13:40 +0000 (09:13 +0700)]
Add tests for Java 21 unnamed classes and instance methods

TODO: Activate the unnamed class test after
https://github.com/eclipse-jdt/eclipse.jdt.core/issues/1106 is done.
Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoAdd tests for Java 21 unnamed patterns
Alexander Kriegisch [Sun, 10 Dec 2023 09:55:33 +0000 (16:55 +0700)]
Add tests for Java 21 unnamed patterns

TODO: Activate after
https://github.com/eclipse-jdt/eclipse.jdt.core/issues/893 is done.
Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoAdd tests for Java 21 string patterns
Alexander Kriegisch [Sun, 10 Dec 2023 06:53:15 +0000 (13:53 +0700)]
Add tests for Java 21 string patterns

TODO: Due to eclipse-jdt/eclipse.jdt.core#1719, one line per test is
currently rendered incorrectly. After the upstream fix, change
"\Bill \Duck" to "Bill Duck".

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoMake OutputSpec::getTrimmedLines work for empty lines on Windows
Alexander Kriegisch [Sun, 10 Dec 2023 06:28:37 +0000 (13:28 +0700)]
Make OutputSpec::getTrimmedLines work for empty lines on Windows

Improve the regex splitting lines to actually remove CR characters on
Windows.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoSimple regression test unit test for #266
Alexander Kriegisch [Sun, 10 Dec 2023 02:31:35 +0000 (09:31 +0700)]
Simple regression test unit test for #266

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoSet exception root cause in ExtensibleURLClassLoader::findClass
Andy Russell [Fri, 8 Dec 2023 20:20:45 +0000 (15:20 -0500)]
Set exception root cause in ExtensibleURLClassLoader::findClass

Fixes #266.

11 months agoRELEASE.md: simplify '-DskipTests' command docs
Alexander Kriegisch [Sat, 2 Dec 2023 02:40:08 +0000 (09:40 +0700)]
RELEASE.md: simplify '-DskipTests' command docs

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoSet version to 1.9.21-SNAPSHOT again
Alexander Kriegisch [Sat, 2 Dec 2023 02:21:40 +0000 (09:21 +0700)]
Set version to 1.9.21-SNAPSHOT again

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoRelease candidate 1.9.21.RC1 V1_9_21_RC1
Alexander Kriegisch [Sat, 2 Dec 2023 02:08:59 +0000 (09:08 +0700)]
Release candidate 1.9.21.RC1

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoBump JDT Core to 1.9.21.RC1 java-21 261/head
Alexander Kriegisch [Sat, 2 Dec 2023 01:56:20 +0000 (08:56 +0700)]
Bump JDT Core to 1.9.21.RC1

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoBump ECJ to 23b713ce (01Dec2023)
Alexander Kriegisch [Sat, 2 Dec 2023 00:28:16 +0000 (07:28 +0700)]
Bump ECJ to 23b713ce (01Dec2023)

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoAdjust to API changes in ECJ 4dc7b558 (01Dec2023)
Alexander Kriegisch [Fri, 1 Dec 2023 13:13:12 +0000 (20:13 +0700)]
Adjust to API changes in ECJ 4dc7b558 (01Dec2023)

Mostly StringBuffer -> StringBuilder API changes

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoBump AJC version string to c13b03ceabf0c1
Alexander Kriegisch [Mon, 27 Nov 2023 04:20:30 +0000 (11:20 +0700)]
Bump AJC version string to c13b03ceabf0c1

More exactly:
Eclipse Compiler c13b03ceabf0c1 (26Nov2023) - Java21

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoReactivate some tests on JDK 21 after upstream fix
Alexander Kriegisch [Mon, 27 Nov 2023 04:17:27 +0000 (11:17 +0700)]
Reactivate some tests on JDK 21 after upstream fix

https://github.com/eclipse-jdt/eclipse.jdt.core/issues/1466 has finally
been fixed.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoAllTests19 suite: add AllTestsAspectJ1921
Alexander Kriegisch [Mon, 27 Nov 2023 04:15:40 +0000 (11:15 +0700)]
AllTests19 suite: add AllTestsAspectJ1921

Until now, the CI build did not run Java 21 tests, but they look OK
locally. Now, let's find out what GitHub Actions says.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
11 months agoAdd missing file RecordPatternsPreview1ExhaustivenessOK1.java for JDK 21
Alexander Kriegisch [Mon, 27 Nov 2023 04:14:04 +0000 (11:14 +0700)]
Add missing file RecordPatternsPreview1ExhaustivenessOK1.java for JDK 21

This file was missing, which did not trigger an error in CI builds,
because AllTestsAspectJ1921 was not part of the AllTests19 suite before.
The latter will be fixed in the next commit.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
12 months agoAjcTaskTest: Be more lenient with aspectjrt version warning
Alexander Kriegisch [Tue, 21 Nov 2023 00:51:58 +0000 (07:51 +0700)]
AjcTaskTest: Be more lenient with aspectjrt version warning

Filter out a warning which occurs, if the current release does not match
the stored binary in lib/test:

  bad version number found in aspectjrt.jar
  expected 1.9.21.M1 found 1.9.20.1

If e.g. we run tests for a milestone release a.b.5.M1 and afterwards
switch back to a.b.5-SNAPSHOT, we do not want to update lib/test for a
single commit, just to make this test pass. Hence, we ignore this
warning here.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
12 months agoAjcTaskTest: unwrap redundant if statement
Alexander Kriegisch [Tue, 21 Nov 2023 00:48:37 +0000 (07:48 +0700)]
AjcTaskTest: unwrap redundant if statement

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
12 months agoRELEASE.md: Add '--add-opens' info for Nexus Staging 'rc:release'
Alexander Kriegisch [Sun, 19 Nov 2023 06:48:26 +0000 (13:48 +0700)]
RELEASE.md: Add '--add-opens' info for Nexus Staging 'rc:release'

Sonatype has not solved the problems in Nexus Staging Maven Plugin for
years, so it makes sense to document them.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
12 months agoSet version 1.9.21-SNAPSHOT
Alexander Kriegisch [Sun, 19 Nov 2023 06:26:39 +0000 (13:26 +0700)]
Set version 1.9.21-SNAPSHOT

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
12 months agoRelease milestone 1.9.21.M1 V1_9_21_M1
Alexander Kriegisch [Sun, 19 Nov 2023 06:22:14 +0000 (13:22 +0700)]
Release milestone 1.9.21.M1

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
12 months agoEnable some tests after J19 problems were fixed for J21
Alexander Kriegisch [Sun, 5 Nov 2023 03:03:23 +0000 (10:03 +0700)]
Enable some tests after J19 problems were fixed for J21

Two test classes which had redundant default clauses for switch with
record patterns were copied from the java19 to the java21 directory and
the redundant clauses deactivated, i.e. the test now run as originally
intended. For older JDK versions, the old tests still stay active in
order to document the old state of affairs.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
12 months agoSwitch CI build to Temurin JDK 21 final (from EA)
Alexander Kriegisch [Wed, 1 Nov 2023 01:52:44 +0000 (08:52 +0700)]
Switch CI build to Temurin JDK 21 final (from EA)

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
12 months agoAdjust to latest changes in JDT Core
Alexander Kriegisch [Wed, 1 Nov 2023 01:50:17 +0000 (08:50 +0700)]
Adjust to latest changes in JDT Core

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoMake all existing tests run on JDK 21
Alexander Kriegisch [Thu, 5 Oct 2023 04:29:04 +0000 (11:29 +0700)]
Make all existing tests run on JDK 21

This mostly affects pattern matching for switch and record patterns.

Two tests which were working before for pattern matching for switch
(preview 4), started to fail, so the corresponding code was commented
out and https://github.com/eclipse-jdt/eclipse.jdt.core/issues/1466
recorded.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoMove some 1.9.20.1 bug tests to correct directory
Alexander Kriegisch [Thu, 5 Oct 2023 04:24:28 +0000 (11:24 +0700)]
Move some 1.9.20.1 bug tests to correct directory

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoAjcTestCase: Make sure main methods can be called in Java 21
Alexander Kriegisch [Thu, 5 Oct 2023 04:22:13 +0000 (11:22 +0700)]
AjcTestCase: Make sure main methods can be called in Java 21

Since JDK 21, a public main method of a non-public (e.g. default-scoped)
class can no longer be invoked without making it accessible first.
Because many test sources contain multiple aspects and classes in one
file, this is a frequent use case.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoAdd test infrastructure for Java 21 (WIP)
Alexander Kriegisch [Thu, 5 Oct 2023 01:09:24 +0000 (08:09 +0700)]
Add test infrastructure for Java 21 (WIP)

The tests and their XML definitions are still copy & paste and need to
be cleaned up. Separate Java 21 feature tests do not exist yet.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoBeautify sanity tests using bytecode level constants
Alexander Kriegisch [Thu, 5 Oct 2023 01:00:47 +0000 (08:00 +0700)]
Beautify sanity tests using bytecode level constants

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoBump ASM to 9.6 (new Opcodes.V22 constant for Java 22)
Alexander Kriegisch [Thu, 5 Oct 2023 00:17:06 +0000 (07:17 +0700)]
Bump ASM to 9.6 (new Opcodes.V22 constant for Java 22)

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoAntSpec: Improve filter for warning "Archived non-system classes are disabled"
Alexander Kriegisch [Sun, 1 Oct 2023 06:46:30 +0000 (13:46 +0700)]
AntSpec: Improve filter for warning "Archived non-system classes are disabled"

In JDK 21, the prefix has changed once again, no longer being a JVM
specifier like "OpenJDK 64-Bit Server VM" or "Java HotSpot(TM) 64-Bit
Server VM" but rather something like "[0.016s][warning][cds]".

Even worse, before J21, the warning appears on stdErr, but in J21+, it
appears on stdOut.

Fixes LTWTests.testJ14LTWWithXML, which started failing on Java 21.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoAjLookupEnvironment: readability refactoring
Alexander Kriegisch [Sun, 1 Oct 2023 05:56:22 +0000 (12:56 +0700)]
AjLookupEnvironment: readability refactoring

While trying to understand the code a bit better in order to fix failing
builds, I applied some cosmetic refactoring and reformatting. This
commit does not change any functionality.

Whether the static import of CompilationAndWeavingContext.* is a good
thing or not is debatable, but I like the code to be less chatty than it
was before, assuming that every developer uses an IDE helping to find
out where static methods and constants come from.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoAjLookupEnvironment: add new phase CONNECT_TYPE_HIERARCHY2
Alexander Kriegisch [Thu, 28 Sep 2023 03:51:38 +0000 (10:51 +0700)]
AjLookupEnvironment: add new phase CONNECT_TYPE_HIERARCHY2

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoIgnore AspectJ core dumps
Alexander Kriegisch [Wed, 27 Sep 2023 02:13:11 +0000 (09:13 +0700)]
Ignore AspectJ core dumps

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoRemove old '.cvsignore' files
Alexander Kriegisch [Wed, 27 Sep 2023 02:10:47 +0000 (09:10 +0700)]
Remove old '.cvsignore' files

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoCI build: remove JDK 11 build, switch 21 to 21-ea
Alexander Kriegisch [Wed, 27 Sep 2023 01:49:06 +0000 (08:49 +0700)]
CI build: remove JDK 11 build, switch 21 to 21-ea

Background: JDT Core dependencies now contain hundreds of Java 17 class
files, i.e. Ajc now requires Java 17+ runtime environment. :-(
For more details, see:
https://github.com/eclipse-aspectj/aspectj/issues/260#issuecomment-1736540176

Adoptium Java 21 release is not available yet, so we need to run on EA.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoBump JDT Core to 1.9.21-SNAPSHOT
Alexander Kriegisch [Tue, 26 Sep 2023 06:45:32 +0000 (13:45 +0700)]
Bump JDT Core to 1.9.21-SNAPSHOT

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
13 months agoUpgrade CI build to JDK 21
Alexander Kriegisch [Tue, 26 Sep 2023 06:43:00 +0000 (13:43 +0700)]
Upgrade CI build to JDK 21

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>