]> source.dussan.org Git - nextcloud-server.git/log
nextcloud-server.git
11 years agore-enable test in SecurityMiddlewareTest
Thomas Müller [Wed, 16 Oct 2013 14:33:56 +0000 (16:33 +0200)]
re-enable test in SecurityMiddlewareTest

11 years agoMerge branch 'master' into fixing-appframework-master
Thomas Müller [Wed, 16 Oct 2013 13:45:55 +0000 (15:45 +0200)]
Merge branch 'master' into fixing-appframework-master

Conflicts:
lib/private/appframework/middleware/security/securitymiddleware.php
tests/lib/appframework/middleware/security/SecurityMiddlewareTest.php

11 years agoMerge pull request #5067 from owncloud/urlParams_fix
Thomas Müller [Wed, 16 Oct 2013 13:42:09 +0000 (06:42 -0700)]
Merge pull request #5067 from owncloud/urlParams_fix

Get urlParams registered before Request is instantiated

11 years agoMerge pull request #5353 from owncloud/files-dndtodirbroken
Morris Jobke [Wed, 16 Oct 2013 11:52:35 +0000 (04:52 -0700)]
Merge pull request #5353 from owncloud/files-dndtodirbroken

Fixed drag and drop to subfolder and breadcrumb

11 years agoMerge pull request #5325 from owncloud/setup-fs-on-apache-auth-backend
Thomas Müller [Wed, 16 Oct 2013 11:23:45 +0000 (04:23 -0700)]
Merge pull request #5325 from owncloud/setup-fs-on-apache-auth-backend

file system is now initialized with apache authentication as well

11 years agoMerge pull request #5329 from owncloud/enc_fix_unencrypted_size
Björn Schießle [Wed, 16 Oct 2013 09:25:28 +0000 (02:25 -0700)]
Merge pull request #5329 from owncloud/enc_fix_unencrypted_size

try to fix unencrypted file size if it doesn't look plausible

11 years agorevert last changes
Bjoern Schiessle [Wed, 16 Oct 2013 09:24:56 +0000 (11:24 +0200)]
revert last changes

11 years agoMerge pull request #5354 from owncloud/enc_tests
Morris Jobke [Wed, 16 Oct 2013 09:14:35 +0000 (02:14 -0700)]
Merge pull request #5354 from owncloud/enc_tests

added simple test for getFileSize proxy

11 years ago6.0 alpha 2 v6.0.0alpha2
Frank Karlitschek [Wed, 16 Oct 2013 08:51:44 +0000 (10:51 +0200)]
6.0 alpha 2

11 years agoMerge pull request #5333 from owncloud/avater_with_encryption
Björn Schießle [Wed, 16 Oct 2013 08:34:05 +0000 (01:34 -0700)]
Merge pull request #5333 from owncloud/avater_with_encryption

avatars should also work with encryption after pr #5332 was merged

11 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Wed, 16 Oct 2013 04:31:48 +0000 (00:31 -0400)]
[tx-robot] updated from transifex

11 years agoadded another test, if unencrypted size and encrypted size are equal we can also...
Bjoern Schiessle [Tue, 15 Oct 2013 15:52:06 +0000 (17:52 +0200)]
added another test, if unencrypted size and encrypted size are equal we can also assume that something is wrong

11 years agofix comment
Bjoern Schiessle [Tue, 15 Oct 2013 15:36:52 +0000 (17:36 +0200)]
fix comment

11 years agoadded simple test for getFileSize proxy
Bjoern Schiessle [Tue, 15 Oct 2013 15:33:31 +0000 (17:33 +0200)]
added simple test for getFileSize proxy

11 years agoFix avatar unittest
kondou [Tue, 15 Oct 2013 15:23:47 +0000 (17:23 +0200)]
Fix avatar unittest

11 years agoMerge pull request #5334 from owncloud/files-sharing-actionsafterupload
Morris Jobke [Tue, 15 Oct 2013 15:11:17 +0000 (08:11 -0700)]
Merge pull request #5334 from owncloud/files-sharing-actionsafterupload

Files sharing actions + navigation fixes

11 years agoMerge pull request #5350 from owncloud/files-preventdeletemountpoint
Vincent Petry [Tue, 15 Oct 2013 14:24:14 +0000 (07:24 -0700)]
Merge pull request #5350 from owncloud/files-preventdeletemountpoint

Prevent renaming/deleting mount points

11 years agoFixed drag and drop upload to breadcrumb
Vincent Petry [Tue, 15 Oct 2013 14:14:23 +0000 (16:14 +0200)]
Fixed drag and drop upload to breadcrumb

11 years agoFixed drag and drop onto folders
Vincent Petry [Tue, 15 Oct 2013 13:54:16 +0000 (15:54 +0200)]
Fixed drag and drop onto folders

Fixes #5351

11 years agoPrevent renaming/deleting mount points
Vincent Petry [Tue, 15 Oct 2013 12:55:38 +0000 (14:55 +0200)]
Prevent renaming/deleting mount points

Fixed permissions returned for mount points to not include update and
delete permissions.

Fixes #5291

11 years agoMerge pull request #5295 from owncloud/show-eye-in-personal
Raghu Nayyar [Tue, 15 Oct 2013 09:59:53 +0000 (02:59 -0700)]
Merge pull request #5295 from owncloud/show-eye-in-personal

Shows The Eye permanently in the Confirm Password field in Personal Settings

11 years agoMerge branch 'master' into avater_with_encryption
Bjoern Schiessle [Tue, 15 Oct 2013 09:53:51 +0000 (11:53 +0200)]
Merge branch 'master' into avater_with_encryption

11 years agotest should work now
Bjoern Schiessle [Tue, 15 Oct 2013 09:53:32 +0000 (11:53 +0200)]
test should work now

11 years agoMerge pull request #5332 from owncloud/enc_run_proxy_only_for_files
Morris Jobke [Tue, 15 Oct 2013 09:44:14 +0000 (02:44 -0700)]
Merge pull request #5332 from owncloud/enc_run_proxy_only_for_files

check if we are writing to user/files, otherwise skip encryption

11 years agoMerge pull request #5269 from owncloud/ocs_share_api_add_received_from
Björn Schießle [Tue, 15 Oct 2013 09:17:23 +0000 (02:17 -0700)]
Merge pull request #5269 from owncloud/ocs_share_api_add_received_from

ocs share api: add "received_from" and "received_from_displayname" field

11 years agoRemoves Bogus showpassword js. thx @PVince81
raghunayyar [Tue, 15 Oct 2013 09:11:18 +0000 (14:41 +0530)]
Removes Bogus showpassword js. thx @PVince81

11 years agoMerge pull request #5341 from owncloud/fix-logout-link-html
Vincent Petry [Tue, 15 Oct 2013 07:33:00 +0000 (00:33 -0700)]
Merge pull request #5341 from owncloud/fix-logout-link-html

Fix logout link HTML.

11 years agoShould Display PasswordToggle Eye Everywhere.
raghunayyar [Tue, 15 Oct 2013 06:06:44 +0000 (11:36 +0530)]
Should Display PasswordToggle Eye Everywhere.

11 years agoMerge pull request #5340 from owncloud/fixing-5251-master
icewind1991 [Mon, 14 Oct 2013 21:29:36 +0000 (14:29 -0700)]
Merge pull request #5340 from owncloud/fixing-5251-master

streamCopy() should return proper structure.

11 years agoFix logout link HTML.
Andreas Fischer [Mon, 14 Oct 2013 20:30:38 +0000 (22:30 +0200)]
Fix logout link HTML.

<a id="logout" href=/projects/owncloud/core/index.php?logout=true>

11 years agostreamCopy() should return proper structure.
Thomas Müller [Mon, 14 Oct 2013 19:33:23 +0000 (21:33 +0200)]
streamCopy() should return proper structure.

Callers of streamCopy() expect an array to be returned containing count and result.

11 years agoMerge pull request #5330 from owncloud/files-removedfileactionsbkg
Vincent Petry [Mon, 14 Oct 2013 16:23:06 +0000 (09:23 -0700)]
Merge pull request #5330 from owncloud/files-removedfileactionsbkg

Removed extra bkg color on file actions when row is selected/hovered on

11 years agoDisabled ajax mode for public files view
Vincent Petry [Mon, 14 Oct 2013 15:47:38 +0000 (17:47 +0200)]
Disabled ajax mode for public files view

Ajax loading is not supported yet for public files view.
This fix disabled the history API, ajax loading and ajax directory
switch in public mode until it is implemented properly.

11 years agoavatars should also work with encryption after pr #5332 was merged
Bjoern Schiessle [Mon, 14 Oct 2013 15:30:24 +0000 (17:30 +0200)]
avatars should also work with encryption after pr #5332 was merged

11 years agoFixed file permissions after public upload
Vincent Petry [Mon, 14 Oct 2013 15:28:23 +0000 (17:28 +0200)]
Fixed file permissions after public upload

Fixes #5328

11 years agocheck if we are writing to user/files, otherwise skip encryption
Bjoern Schiessle [Mon, 14 Oct 2013 15:13:14 +0000 (17:13 +0200)]
check if we are writing to user/files, otherwise skip encryption

11 years agoRemoved extra bkg color on file actions when row is selected/hovered on
Vincent Petry [Mon, 14 Oct 2013 15:05:24 +0000 (17:05 +0200)]
Removed extra bkg color on file actions when row is selected/hovered on

11 years agofix array key
Bjoern Schiessle [Mon, 14 Oct 2013 14:43:18 +0000 (16:43 +0200)]
fix array key

11 years agotry to fix unencrypted file size if it doesn't look plausible
Bjoern Schiessle [Mon, 14 Oct 2013 14:34:14 +0000 (16:34 +0200)]
try to fix unencrypted file size if it doesn't look plausible

11 years agoMerge pull request #4867 from owncloud/fixing-4546-master
Thomas Müller [Mon, 14 Oct 2013 13:39:32 +0000 (06:39 -0700)]
Merge pull request #4867 from owncloud/fixing-4546-master

Adding detection of aborted uploads for chunked uploads

11 years agoMerge pull request #5323 from owncloud/files-external-missinggridstyle
Frank Karlitschek [Mon, 14 Oct 2013 13:31:35 +0000 (06:31 -0700)]
Merge pull request #5323 from owncloud/files-external-missinggridstyle

Added missing "grid" class on external storage's table

11 years agothere shall be tabs
Thomas Müller [Mon, 14 Oct 2013 12:51:25 +0000 (14:51 +0200)]
there shall be tabs

11 years agofile system is now initialized with apache authentication as well
Thomas Müller [Mon, 14 Oct 2013 12:46:43 +0000 (14:46 +0200)]
file system is now initialized with apache authentication as well

11 years agoAdded missing "grid" class on external storage's table
Vincent Petry [Mon, 14 Oct 2013 10:12:26 +0000 (12:12 +0200)]
Added missing "grid" class on external storage's table

11 years agoMerge pull request #5297 from owncloud/quota-style
Jan-Christoph Borchardt [Mon, 14 Oct 2013 10:59:51 +0000 (03:59 -0700)]
Merge pull request #5297 from owncloud/quota-style

Fixes Default Quota Style in User Management.

11 years agoMerge pull request #5320 from owncloud/fix_app_sorting
Vincent Petry [Mon, 14 Oct 2013 09:29:27 +0000 (02:29 -0700)]
Merge pull request #5320 from owncloud/fix_app_sorting

Fix app sorting

11 years agocase insensitive sort
Frank Karlitschek [Mon, 14 Oct 2013 09:15:04 +0000 (11:15 +0200)]
case insensitive sort

11 years agofix style
Frank Karlitschek [Mon, 14 Oct 2013 08:57:00 +0000 (10:57 +0200)]
fix style

11 years agoMerge branch 'master' into fixing-4546-master
Thomas Müller [Mon, 14 Oct 2013 08:56:50 +0000 (10:56 +0200)]
Merge branch 'master' into fixing-4546-master

Conflicts:
lib/private/connector/sabre/file.php

11 years agofinally fix the app sorting
Frank Karlitschek [Mon, 14 Oct 2013 08:54:38 +0000 (10:54 +0200)]
finally fix the app sorting

11 years agoFixes Default Quota Style in User Management.
raghunayyar [Fri, 11 Oct 2013 13:41:01 +0000 (19:11 +0530)]
Fixes Default Quota Style in User Management.

11 years ago[tx-robot] updated from transifex
Jenkins for ownCloud [Mon, 14 Oct 2013 00:33:30 +0000 (20:33 -0400)]
[tx-robot] updated from transifex

11 years agoMerge pull request #5318 from owncloud/show_channel
Raghu Nayyar [Sun, 13 Oct 2013 20:16:24 +0000 (13:16 -0700)]
Merge pull request #5318 from owncloud/show_channel

show the channel. Also mark git as git channel so that someone can see

11 years agoMerge pull request #5253 from owncloud/externalstorage-adminstatusindicator
Morris Jobke [Sun, 13 Oct 2013 20:03:02 +0000 (13:03 -0700)]
Merge pull request #5253 from owncloud/externalstorage-adminstatusindicator

Fixed external storage status indicator in admin page

11 years agoshow the channel. Also mark git as git channel so that someone can see where this...
Frank Karlitschek [Sun, 13 Oct 2013 19:51:47 +0000 (21:51 +0200)]
show the channel. Also mark git as git channel so that someone can see where this build comes from

11 years agoMerge pull request #5299 from owncloud/settings-ie8-tablegridstyles
Thomas Müller [Sat, 12 Oct 2013 10:51:01 +0000 (03:51 -0700)]
Merge pull request #5299 from owncloud/settings-ie8-tablegridstyles

Fixed table grid styles for IE8

11 years agoShows The Eye permanently in the Confirm Password field in Personal Settings - fix...
raghunayyar [Fri, 11 Oct 2013 13:02:43 +0000 (18:32 +0530)]
Shows The Eye permanently in the Confirm Password field in Personal Settings - fix #5167

11 years agoMerge pull request #5303 from owncloud/fix-unlogged-session-error
Thomas Müller [Sat, 12 Oct 2013 10:35:33 +0000 (03:35 -0700)]
Merge pull request #5303 from owncloud/fix-unlogged-session-error

Log an error when session initialization fails before ownCloud is intalled

11 years agoMerge pull request #5290 from owncloud/fixing-5191-master
Morris Jobke [Sat, 12 Oct 2013 10:28:44 +0000 (03:28 -0700)]
Merge pull request #5290 from owncloud/fixing-5191-master

Installation. Show advanced section on error. Fixes #5191

11 years agoMerge pull request #5272 from mrflix/master
Thomas Müller [Sat, 12 Oct 2013 08:41:30 +0000 (01:41 -0700)]
Merge pull request #5272 from mrflix/master

fix label to checkbox binding in admin -> force-https

11 years agoMerge pull request #5287 from owncloud/core-layoutviewportdirective
Thomas Müller [Sat, 12 Oct 2013 08:36:20 +0000 (01:36 -0700)]
Merge pull request #5287 from owncloud/core-layoutviewportdirective

Fixed viewport layout using commas instead of semicolons

11 years agoMerge pull request #5301 from owncloud/versioning_preview_shared
Thomas Müller [Sat, 12 Oct 2013 08:32:25 +0000 (01:32 -0700)]
Merge pull request #5301 from owncloud/versioning_preview_shared

versioning preview also for shared files

11 years agoMerge branch 'master' of github.com:owncloud/core into fix-unlogged-session-error
Tom Needham [Sat, 12 Oct 2013 08:15:59 +0000 (09:15 +0100)]
Merge branch 'master' of github.com:owncloud/core into fix-unlogged-session-error

11 years agoInclude exception message in log entry when session fails to start
Tom Needham [Sat, 12 Oct 2013 08:15:08 +0000 (09:15 +0100)]
Include exception message in log entry when session fails to start

11 years agoMerge pull request #5280 from owncloud/shorten_controller_namespace
Thomas Müller [Fri, 11 Oct 2013 19:51:07 +0000 (12:51 -0700)]
Merge pull request #5280 from owncloud/shorten_controller_namespace

OCP\AppFramework\Controller\Controller => OCP\AppFramework\Controller

11 years agoMerge pull request #5304 from owncloud/files-deleteiconpositionfix
Morris Jobke [Fri, 11 Oct 2013 19:39:33 +0000 (12:39 -0700)]
Merge pull request #5304 from owncloud/files-deleteiconpositionfix

Fixed position of "delete" icon in files app

11 years agoMerge pull request #5296 from owncloud/remove-chosen-hack
Morris Jobke [Fri, 11 Oct 2013 19:30:59 +0000 (12:30 -0700)]
Merge pull request #5296 from owncloud/remove-chosen-hack

Removes the Bogus Label

11 years agoMerge pull request #5207 from owncloud/fixing-4011-part2-master
Thomas Müller [Fri, 11 Oct 2013 17:35:17 +0000 (10:35 -0700)]
Merge pull request #5207 from owncloud/fixing-4011-part2-master

[OC6] file upload exception handling

11 years agoHandle ownCloud logging when data dir not created
Tom Needham [Fri, 11 Oct 2013 16:16:37 +0000 (17:16 +0100)]
Handle ownCloud logging when data dir not created

11 years agoFixed position of "delete" icon in files app
Vincent Petry [Fri, 11 Oct 2013 16:01:15 +0000 (18:01 +0200)]
Fixed position of "delete" icon in files app

There was an issue where only Chrome allows setting position: relative
on a td element.

This fix now works in IE8, Firefox and Chrome.

Fixes #5056

11 years agoLog the session exception when ownCloud is not installed
Tom Needham [Fri, 11 Oct 2013 15:45:58 +0000 (16:45 +0100)]
Log the session exception when ownCloud is not installed

11 years agoMerge pull request #5302 from owncloud/files-missingfileactionsafteradd
Vincent Petry [Fri, 11 Oct 2013 15:45:42 +0000 (08:45 -0700)]
Merge pull request #5302 from owncloud/files-missingfileactionsafteradd

File actions are now updated after create/upload file

11 years agoMerge pull request #5274 from owncloud/files-ie8-deletecheckbox
Vincent Petry [Fri, 11 Oct 2013 15:24:57 +0000 (08:24 -0700)]
Merge pull request #5274 from owncloud/files-ie8-deletecheckbox

Fixed delete icon alignment in IE8

11 years agoFile actions are now updated after create/upload file
Vincent Petry [Fri, 11 Oct 2013 15:06:01 +0000 (17:06 +0200)]
File actions are now updated after create/upload file

The file actions must explicitly be updated by calling
FileActions.display() on the file element after creating or uploading a
file.

Fixes #4971 and #4993

11 years agoremove debug output
Bjoern Schiessle [Fri, 11 Oct 2013 15:06:43 +0000 (17:06 +0200)]
remove debug output

11 years agoMerge branch 'master' into versioning_preview_shared
Bjoern Schiessle [Fri, 11 Oct 2013 15:00:21 +0000 (17:00 +0200)]
Merge branch 'master' into versioning_preview_shared

11 years agoMerge pull request #5261 from owncloud/versioning_no_glob
Björn Schießle [Fri, 11 Oct 2013 14:57:14 +0000 (07:57 -0700)]
Merge pull request #5261 from owncloud/versioning_no_glob

versioning: don't use glob() and getLocalFile()

11 years agoMerge pull request #5298 from owncloud/enc_fix_setting_dialog_headlines
Björn Schießle [Fri, 11 Oct 2013 14:15:58 +0000 (07:15 -0700)]
Merge pull request #5298 from owncloud/enc_fix_setting_dialog_headlines

fix setting dialog headlines for the encryption app

11 years agoFixed table grid styles for IE8
Vincent Petry [Fri, 11 Oct 2013 13:58:15 +0000 (15:58 +0200)]
Fixed table grid styles for IE8

The selector :not() isn't supported in IE8, replaced it with the "grid"
class.

- Fixes the log table style in IE8 (#5057)
- Fixes the users table layout bug in IE8

11 years agofix setting dialog headlines for the encryption app
Bjoern Schiessle [Fri, 11 Oct 2013 13:56:08 +0000 (15:56 +0200)]
fix setting dialog headlines for the encryption app

11 years agoMerge pull request #5292 from owncloud/enc_block_file_access_if_key_is_missing
Björn Schießle [Fri, 11 Oct 2013 13:37:53 +0000 (06:37 -0700)]
Merge pull request #5292 from owncloud/enc_block_file_access_if_key_is_missing

encryption: block file access if share keys are missing

11 years agoImprove expand/collapse logic
Victor Dubiniuk [Fri, 11 Oct 2013 13:35:59 +0000 (16:35 +0300)]
Improve expand/collapse logic

11 years agofix another typo
Bjoern Schiessle [Fri, 11 Oct 2013 13:26:30 +0000 (15:26 +0200)]
fix another typo

11 years agochange error code to 403
Bjoern Schiessle [Fri, 11 Oct 2013 13:24:49 +0000 (15:24 +0200)]
change error code to 403

11 years agofix typo in error message and change error code to 403
Bjoern Schiessle [Fri, 11 Oct 2013 13:23:12 +0000 (15:23 +0200)]
fix typo in error message and change error code to 403

11 years agoIncludes <optgroup> tag
raghunayyar [Fri, 11 Oct 2013 13:22:27 +0000 (18:52 +0530)]
Includes <optgroup> tag

11 years agoPuts the language divider in place. thanks @Kondou-ger ;)
raghunayyar [Fri, 11 Oct 2013 13:16:59 +0000 (18:46 +0530)]
Puts the language divider in place. thanks @Kondou-ger ;)

11 years agoRemoves the Bogus Label
raghunayyar [Fri, 11 Oct 2013 13:12:02 +0000 (18:42 +0530)]
Removes the Bogus Label

11 years agoMerge pull request #5294 from owncloud/personal-multiselect
Raghu Nayyar [Fri, 11 Oct 2013 13:07:43 +0000 (06:07 -0700)]
Merge pull request #5294 from owncloud/personal-multiselect

Uniform Styles and Indentation Fixes for Personal Settings

11 years agoMerge pull request #5293 from owncloud/files-ie8-datemisaligned
Morris Jobke [Fri, 11 Oct 2013 12:38:08 +0000 (05:38 -0700)]
Merge pull request #5293 from owncloud/files-ie8-datemisaligned

Fixed IE8 misaligned date

11 years agoUniform Styles and Indentation Fixes for Personal Block
raghunayyar [Fri, 11 Oct 2013 12:33:53 +0000 (18:03 +0530)]
Uniform Styles and Indentation Fixes for Personal Block

11 years agoFixed IE8 misaligned date
Vincent Petry [Fri, 11 Oct 2013 12:23:37 +0000 (14:23 +0200)]
Fixed IE8 misaligned date

Removed display: block to let the element be displayed inline and let
itself aligned by vertical-align: middle of the parent

This works in IE8 and other browsers.

Fixes #5288

11 years agoblock file access if share keys are missing
Bjoern Schiessle [Fri, 11 Oct 2013 12:20:46 +0000 (14:20 +0200)]
block file access if share keys are missing

11 years agoMoved IE8 inline styles in files.css
Vincent Petry [Fri, 11 Oct 2013 12:10:00 +0000 (14:10 +0200)]
Moved IE8 inline styles in files.css

11 years agoShow advanced section on error. Fixes #5191
Victor Dubiniuk [Fri, 11 Oct 2013 11:47:28 +0000 (14:47 +0300)]
Show advanced section on error. Fixes #5191

11 years agoMerge pull request #5281 from owncloud/settings-ie8-changedisplaynamefix
Morris Jobke [Fri, 11 Oct 2013 11:46:26 +0000 (04:46 -0700)]
Merge pull request #5281 from owncloud/settings-ie8-changedisplaynamefix

Fixed display name change for IE8

11 years agoMerge pull request #5133 from owncloud/js_vcategories_to_tags
Thomas Tanghus [Fri, 11 Oct 2013 11:17:59 +0000 (04:17 -0700)]
Merge pull request #5133 from owncloud/js_vcategories_to_tags

Js vcategories to tags

11 years agoFixed viewport layout using commas instead of semicolons
Vincent Petry [Fri, 11 Oct 2013 10:51:40 +0000 (12:51 +0200)]
Fixed viewport layout using commas instead of semicolons

Fixes #5285

11 years agoNow using smaller spinner image for status indicator
Vincent Petry [Fri, 11 Oct 2013 10:36:30 +0000 (12:36 +0200)]
Now using smaller spinner image for status indicator

To make the status indicator appear smaller, even in IE8 that doesn't
support background-size, there is no a smaller animated gif
"loading-small" for that purpose.

11 years agoFixed display name change for IE8
Vincent Petry [Fri, 11 Oct 2013 08:48:30 +0000 (10:48 +0200)]
Fixed display name change for IE8

After saving the display name, the oldDisplayName field's value was
wrongly set with text(), which would append the text inside the input
element which is considered as an invalid operation in IE8.

This fix for #5054 correctly puts the old value into the field with a val() call.