fix: Clean-up some remaining readdir calls with undesirable false evaluation potential

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
[skip ci]

Merge pull request #49206 from nextcloud/backport/48736/stable29

[stable29] fix: log a warning when we can't build a background job

Merge pull request #49221 from nextcloud/backport/49218/stable29

fix(files_external): cast storage id int

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Merge pull request #49159 from nextcloud/backport/49146/stable29

Merge pull request #49162 from nextcloud/backport/49150/stable29

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: log a warning when we can't build a background job

Signed-off-by: Robin Appelman <robin@icewind.nl>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(files): edit locally buttons

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Merge pull request #49156 from nextcloud/backport/49153/stable29

fix(files_sharing): note icon color on public pages

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Fix Undefined variable: response notice in case of non-404 error

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Merge pull request #49137 from nextcloud/backport/49112/stable29

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(theming): Return default theme if the user never selected a theme

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48797 from nextcloud/backport/48425/stable29

[stable29] fix(files): Ensure renaming state is correctly reset

chore: Compile assets

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

test: Adjust Cypress setup to support mainline JS syntax

TODO: Drop when we support Node 22.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Ensure renaming state is correctly reset

Problem: Is a node is renamed and the new name is out of the current
visible list of nodes the component will be recycled, this means
the props will change, so when the `onRename` functions is about to reset
the state the `this.source` will point to a different node.

To fix this, but also to separate business logic from visual representation,
the logic is moved into the renaming store and the component is only
responsible for rendering.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #49119 from nextcloud/release/29.0.9

build(hub): 29.0.9

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #49092 from nextcloud/release/29.0.9_rc2

Merge pull request #49068 from nextcloud/backport/49065/stable29

Merge pull request #49095 from nextcloud/chore/nextcloud-dialogs-stable29

Merge pull request #49085 from nextcloud/backport/49076/stable29

chore: Compile assets

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore(deps): Update `@nextcloud/dialogs` to v5.3.8

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

build(hub): 29.0.9 RC2

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(owncloud): Fix ownCloud migration with oauth2 app

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #49055 from nextcloud/backport/48684/stable29

[stable29] chore: request review from groupware when changing the card- and cald…

chore: Fix maintainer of federation app

Signed-off-by: Joas Schilling <coding@schilljs.com>

chore: Change Fenn-CS to nfebe

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>

chore: rename julius

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

chore: update groupware code owners

Ref https://github.com/nextcloud/groupware?tab=readme-ov-file#components-and-roles

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

chore: Update CODEOWNERS

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

docs: update overwrite.cli.url wording

Signed-off-by: Simon L. <szaimen@e.mail.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48995 from nextcloud/release/29.0.9_rc1

Merge pull request #48998 from nextcloud/backport/47986/stable29

[stable29] perf(ObjectStoreStorage): Improve (slow) move on same object bucket

Merge pull request #49021 from nextcloud/backport/49017/stable29

[stable29] fix(ShareEntryLinkList): Append new links to the end of list

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(ShareEntryLinkList): Append new links to the end of list

Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : https://github.com/nextcloud/server/issues/48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

fix(tests): Fix most obvious errors in ObjectStore tests

Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #49029 from nextcloud/backport/49009/49009-stable29

[stable29] fix(files-external): set password as sensitive

fix(files-external): set password as sensitive

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Merge pull request #48969 from nextcloud/backport/48766/stable29

[stable29] Fix disabled user list for subadmins

fix(provisioning_api): Fix getting disabled users for group admins

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore(provisioning_api): Add tests for getDisabledUserDetails

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #49012 from nextcloud/backport/48991/stable29

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48471 from nextcloud/backport/48466/stable29

[stable29] ci: fail psalm when baseline update required

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files_sharing): Password field must not be required if already set

If there is already a password, there is no need to require the password
in the setting ('newPassword'). It is only required for new shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore: update psalm baseline

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

chore: update psalm

To ensure we have a stable baseline

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

ci: fail psalm when baseline update required

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #49006 from nextcloud/backport/48992/stable29

[stable29] fix: add PasswordConfirmationRequired to saveGlobalCredentials

Merge pull request #48700 from nextcloud/fix/cachebuster-stable30

[stable29] fix: Shipped apps should include the Nextcloud version in the cache buster

fix: resolve conflict add PasswordConfirmationRequired to saveGlobalCredentials

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: add PasswordConfirmationRequired to saveGlobalCredentials

Co-authored-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
[skip ci]

Merge pull request #48745 from nextcloud/backport/46124/stable29

fix: Shipped apps should include the Nextcloud version in the cache buster

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48473 from nextcloud/backport/47846/stable29

Merge pull request #48488 from nextcloud/backport/48235/stable29

perf(ObjectStoreStorage): Improve (slow) move on same object bucket

This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>

Merge pull request #48980 from nextcloud/backport/48632/stable29

build(hub): 29.0.9 RC1

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48968 from nextcloud/backport/47847/stable29

Merge pull request #48973 from nextcloud/backport/48788/stable29

[stable29] fix: add PasswordConfirmationRequired to the external storages mentioned in review

fix(files): Do not jump to top when fileId is set to currentFolder

Fix https://github.com/nextcloud/server/issues/48545

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix: conflicts resolved by adding PasswordConfirmationRequired to update method

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: cs fix namespace

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: add PasswordConfirmationRequired to the eternal storages mentioned in review

Signed-off-by: yemkareems <yemkareems@gmail.com>

test: add test for nested jail cross-storage move

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix: Fix copying or moving from shared groupfolders

When copying or moving between two local storages the source path (on
disk) to copy or move from is got from the unjailed path of the source
storage. However, if the source storage has more than one jail getting
the unjailed path resolves the most external jail, but the source path
needs to be got from the most internal jail instead (the one closer to
the local storage).

This can happen, for example, with a shared groupfolder: in that case
there is an external jail for the shared storage, and one internal jail
for the groupfolder storage wrapped by the shared storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #48570 from nextcloud/backport/48532/stable29

Merge pull request #48958 from nextcloud/backport/48921/stable29

ci(psalm): Add missing imagick extension

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48889 from nextcloud/backport/48887/stable29

Merge pull request #48934 from nextcloud/backport/48625/stable29

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files_sharing): federated shares avatar

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore(assets): Recompile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

refactor(files): migrate to @nextcloud/sharing

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(files): handle empty view with error

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(files): migrate davUtils to TS

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Merge pull request #48949 from nextcloud/backport/48947/stable29

[stable29] fix(config): Mark more configs as sensitive

Merge pull request #48940 from nextcloud/backport/48915/stable29

[stable29] fix: encrypt and store password, decrypt and retrieve the same

fix(config): Mark more configs as sensitive

Signed-off-by: Joas Schilling <coding@schilljs.com>