]>
source.dussan.org Git - gitea.git/log
Lunny Xiao [Fri, 18 Oct 2019 08:14:37 +0000 (16:14 +0800)]
fix bug pull request files will be broken if head repo was transfered to another user or orgnization (#8571)
zeripath [Wed, 16 Oct 2019 16:05:23 +0000 (17:05 +0100)]
Add missed close in ServeBlobLFS (#8527) (#8543)
zeripath [Sun, 13 Oct 2019 20:01:52 +0000 (21:01 +0100)]
Fixes #8369: Create .ssh dir as necessary (#8486) (#8489)
* Ensure .ssh dir exists before rewriting public keys
* Ensure .ssh dir exists before appending to authorized_keys
* Log the error because it would be useful to know where it is trying to MkdirAll
* Only try to create RootPath if it's not empty
zeripath [Sun, 13 Oct 2019 17:23:43 +0000 (18:23 +0100)]
IsBranchExist: return false if provided name is empty (#8485) (#8492)
* IsBranchExist: return false if provided name is empty
* Ensure that the reference returned is actually of a valid type
guillep2k [Sun, 13 Oct 2019 15:17:53 +0000 (12:17 -0300)]
Backport: Ignore mentions for users with no access (#8395) (#8484)
* Ignore mentions for users with no access
* Fix fmt
zeripath [Sun, 13 Oct 2019 04:40:13 +0000 (05:40 +0100)]
Restore functionality for early gits (#7775) (#8476)
* Change tests to make it possible to run TestGit with 1.7.2
* Make merge run on 1.7.2
* Fix tracking and staging branch name problem
* Ensure that git 1.7.2 works on tests
* ensure that there is no chance for conflicts
* Fix-up missing merge issues
* Final rm
* Ensure LFS filters run on the tests
* Do not sign commits from temp repo
* Apply suggestions from code review
* Update modules/repofiles/temp_repo.go
guillep2k [Sat, 12 Oct 2019 05:31:12 +0000 (02:31 -0300)]
Add check for empty set when dropping indexes during migration (#8475)
zeripath [Fri, 11 Oct 2019 16:11:06 +0000 (17:11 +0100)]
Ensure Request Body Readers are closed in LFS server (#8454) (#8459)
zeripath [Fri, 11 Oct 2019 12:41:55 +0000 (13:41 +0100)]
Ensure that LFS files are relative to the LFS content path (#8455) (#8458)
6543 [Tue, 8 Oct 2019 17:54:58 +0000 (19:54 +0200)]
Changelog for v1.9.4 (#8422)
* changelog
* Update CHANGELOG.md
We ned to revert this then ...
Co-Authored-By: Lauris BH <lauris@nix.lv>
Lauris BH [Tue, 8 Oct 2019 16:12:41 +0000 (19:12 +0300)]
Revert "[Backport] Fix issues/pr list broken when there are man… (#8425)
This reverts commit
0ea4b786cb99054a381f3005f11f4cf413214617 .
6543 [Tue, 8 Oct 2019 11:35:00 +0000 (13:35 +0200)]
[Backport] Fix issues/pr list broken when there are many repositories (#8409) (#8418)
* Fix issues/pr list broken when there are many repositories (#8409)
* fix issues/pr list broken when there are many repositories
* remove unused codes
* fix counting error on issues/prs
* keep the old logic
* fix panic
* fix tests
* rm unused import
6543 [Mon, 7 Oct 2019 04:58:35 +0000 (06:58 +0200)]
fix bug when migrating a private repository (#7917) (#8403)
6543 [Mon, 7 Oct 2019 04:20:07 +0000 (06:20 +0200)]
Change general form binding to gogs form (#8334) (#8402)
6543 [Mon, 7 Oct 2019 03:41:46 +0000 (05:41 +0200)]
feat: highlight issue references with : (#8101) (#8404)
* feat: highlight issue references with :
e.g. #1287: my commit msg
e.g. ABC-1234: my commit msg
* ref: update model regex to consistent with issueNumericPattern
* test: check highlight issue with : in commits messages
6543 [Mon, 7 Oct 2019 03:03:43 +0000 (05:03 +0200)]
Fix milestone num_issues (#8221) (#8400)
* fix milestone num_issues
* update missing completeness
* only update milestone closed number when closed issue is assigned a new milestone or clear milestone
* fix tests
* fix update milestone num
* fix completeness calculate
* make completeness calucation more clear
6543 [Mon, 7 Oct 2019 01:28:18 +0000 (03:28 +0200)]
Fix editor commit to new branch if PR disabled (#8375) (#8401)
guillep2k [Sun, 6 Oct 2019 20:52:25 +0000 (17:52 -0300)]
Allow users with explicit read access to give approvals (#8398)
6543 [Sun, 6 Oct 2019 04:10:47 +0000 (06:10 +0200)]
fix version-validation (because of 1.12 -> 1.13 switch) (#8389)
* fix depenedency
* make vendor first
Elias Norberg [Tue, 1 Oct 2019 17:16:45 +0000 (19:16 +0200)]
Backport of commit status fixes in PR #8316 and PR #8321 to v1.9 (#8339)
* Use correct index when fetching commit status
Signed-off-by: Elias Norberg <elias@aisle.se>
* Compare against base repo to avoid mismatch when merging from fork
Signed-off-by: Elias Norberg <elias@aisle.se>
* Fix pull request commit status in user dashboard list
David Svantesson [Thu, 26 Sep 2019 13:16:47 +0000 (15:16 +0200)]
Fix API for edit and delete release attachment (#8290)
* Add logging for when user requested attachment doesn't belong to the specified release.
* Fix API to use correct variable for release asset (attachment)
Daniel Fonseca de Lira [Wed, 25 Sep 2019 19:50:54 +0000 (16:50 -0300)]
Fix assets on release webhook (#8283)
Daniel Fonseca de Lira [Thu, 19 Sep 2019 15:15:19 +0000 (12:15 -0300)]
Fix release API URL generation (#8239)
guillep2k [Thu, 19 Sep 2019 08:58:47 +0000 (05:58 -0300)]
Allow registration when button is hidden (#8238)
Bjoern Petri [Wed, 18 Sep 2019 08:51:13 +0000 (10:51 +0200)]
MS Teams webhook misses commit messages (#8225)
The current webhook just shows the amount of commits, but misses the actual commit description. While the code is actually there to include the description, it is just not included.
Signed-off-by: Bjoern Petri <bjoern.petri@sundevil.de>
Mura Li [Tue, 17 Sep 2019 09:40:28 +0000 (17:40 +0800)]
Fix data race (#8206)
* Fix data race
* Fix data race in modules/log
* Make the scope of lock finner-grained
* Use syc.Map
* Fix missing change in the test
* Do not export LoggerMap
Lunny Xiao [Tue, 17 Sep 2019 03:23:40 +0000 (11:23 +0800)]
Fix team user api (#8172) (#8188)
* fix team user api
* fix tests
* fix api
* fix team user api
* change user convert
* fix tests
* fix tests
Mura Li [Mon, 16 Sep 2019 17:27:05 +0000 (01:27 +0800)]
Fix pull merge 500 error caused by git-fetch breaking behaviors (#8194)
Jakob Ackermann [Mon, 16 Sep 2019 01:41:30 +0000 (03:41 +0200)]
[ssh] fix the config specification in the authorized_keys template (#8031) (#8193)
The gitea flags must appear in front of the gitea command. Otherwise
they are ignored.
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
(cherry picked from commit
89648746a5acd4892a026d2962ff217280dbdf5b )
Filip Navara [Sun, 15 Sep 2019 21:59:08 +0000 (23:59 +0200)]
[backport/v1.9] Fix reading git notes from nested trees (#8189)
* Fix reading notes from nested trees
The GIT documentation for notes states "Permitted pathnames have the
form ab/cd/ef/.../abcdef...: a sequence of directory names of two
hexadecimal digits each followed by a filename with the rest of
the object ID."
* Add test case
* Fix new lines
jaqra [Fri, 13 Sep 2019 21:58:31 +0000 (00:58 +0300)]
[fix #7384] make show private icon when repo avatar set (#8144) (#8175)
guillep2k [Thu, 12 Sep 2019 21:52:33 +0000 (18:52 -0300)]
Add reviewrs as participants (#8124)
Antoine GIRARD [Thu, 12 Sep 2019 19:58:09 +0000 (21:58 +0200)]
Backport: Use vendored go-swagger (#8087) (#8165)
* Use vendored go-swagger (#8087)
* Use vendored go-swagger
* vendor go-swagger
* revert un wanteed change
* remove un-needed GO111MODULE
* Update Makefile
Co-Authored-By: techknowlogick <matti@mdranta.net>
* re-generate swagger file
Matti R [Sat, 7 Sep 2019 16:40:52 +0000 (12:40 -0400)]
target go1.12
guillep2k [Fri, 6 Sep 2019 16:25:24 +0000 (13:25 -0300)]
Changelog for v1.9.3 (#8117)
* Changelog for 1.9.3
* Fix ref to 8071
* Correct punctuation
Co-Authored-By: techknowlogick <matti@mdranta.net>
Rutger Broekhoff [Fri, 6 Sep 2019 13:59:03 +0000 (15:59 +0200)]
Fix Go 1.13 private repository go get issue (#8100)
* Fix Go 1.13 invalid import path creation
Signed-off-by: Rutger Broekhoff <rutger@viasalix.nl>
* Apply suggested changes from #8100
Signed-off-by: Rutger Broekhoff <rutger@viasalix.nl>
guillep2k [Wed, 4 Sep 2019 14:37:09 +0000 (11:37 -0300)]
Backport: Strict name matching for Repository.GetTagID() (#8082)
* Strict name matching for Repository.GetTagID()
* Add test for GetTagID()
Mura Li [Tue, 3 Sep 2019 19:58:19 +0000 (03:58 +0800)]
Avoid ambiguity of branch/directory names for the git-diff-tree command (#8066) (#8070)
Mario Lubenka [Tue, 3 Sep 2019 16:05:47 +0000 (18:05 +0200)]
Bugfix/deformed emoji in commit message (backport 1.9) (#8071)
* Fixes deformed emoji in pull request comments or reviews
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
* Generate css via command
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
guillep2k [Tue, 3 Sep 2019 03:39:53 +0000 (00:39 -0300)]
Add change title notification for issues (#8064)
Tamal Saha [Mon, 2 Sep 2019 05:55:33 +0000 (01:55 -0400)]
Run CORS handler first for /api routes (#7967) (#8053)
Signed-off-by: Tamal Saha <tamal@appscode.com>
Mario Lubenka [Sat, 31 Aug 2019 13:12:08 +0000 (15:12 +0200)]
Evaluate emojis in commit messages in list view (#7906) (#8044)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
(cherry picked from commit
08c63190c68ca63f99f510f7f2c6cda41d531343 )
Lunny Xiao [Wed, 28 Aug 2019 06:11:41 +0000 (14:11 +0800)]
keep blame view buttons sequence consistent with normal view when view a file (#8007) (#8009)
Richard Mahn [Tue, 27 Aug 2019 05:01:16 +0000 (01:01 -0400)]
Backport for #7945 (#7994)
Gary Kim [Tue, 27 Aug 2019 04:24:26 +0000 (04:24 +0000)]
backport: Fix adding default Telegram webhook (#7992)
Signed-off-by: Gary Kim <gary@garykim.dev>
David Svantesson [Sun, 25 Aug 2019 00:59:21 +0000 (02:59 +0200)]
Abort syncrhonization from LDAP source if there is some error. (#7965)
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
(cherry picked from commit
b2d23a138942179d62f9bffdb3df272e9300e35b )
Lunny Xiao [Thu, 22 Aug 2019 13:36:40 +0000 (21:36 +0800)]
Add release notes of 1.9.2 (#7934)
* Add release notes of 1.9.2
* add missing issue
Mura Li [Wed, 21 Aug 2019 02:14:09 +0000 (10:14 +0800)]
Fix pull creation with empty changes (#7920) (#7926)
* Logs the stderr of git-apply
* Add an integration test
* Skip testPatch when patch is empty
Lunny Xiao [Tue, 20 Aug 2019 17:42:14 +0000 (01:42 +0800)]
fix wrong sender when send slack webhook (#7918) (#7924)
Lunny Xiao [Sat, 17 Aug 2019 12:59:36 +0000 (20:59 +0800)]
upload support text/plain; charset=utf8 (#7899)
Antoine GIRARD [Thu, 15 Aug 2019 22:13:24 +0000 (00:13 +0200)]
drone/docker: prepare multi-arch release + provide arm64 image (#7571) (#7884)
* drone/docker: prepare multi-arch release
* Add docker-linux-arm64 pipeline
* add arm 64 build to manifest
* tag dry-run + indent
* Fix notify dependency
Antoine GIRARD [Thu, 15 Aug 2019 10:53:20 +0000 (12:53 +0200)]
lfs/lock: round locked_at timestamp to second (#7872) (#7875)
* lfs/lock: round locked_at timestamp to second
* test returned locked_at values
* tests: use time RFC3339
Lanre Adelowo [Thu, 15 Aug 2019 01:37:59 +0000 (02:37 +0100)]
fix non existent milestone with 500 error (#7867) (#7873)
Lunny Xiao [Wed, 14 Aug 2019 13:26:58 +0000 (21:26 +0800)]
Add changelog of v1.9.1 (#7859)
* add changelog of v1.9.1
* Update CHANGELOG.md
Co-Authored-By: Lauris BH <lauris@nix.lv>
* mention releases build by go1.12.8
* Update CHANGELOG.md
Co-Authored-By: Lauris BH <lauris@nix.lv>
zeripath [Wed, 14 Aug 2019 11:02:04 +0000 (12:02 +0100)]
Fix local runs of ssh-requiring integration tests (#7857)
zeripath [Wed, 14 Aug 2019 09:43:02 +0000 (10:43 +0100)]
Attempt to fix hook problem (#7856)
Antoine GIRARD [Wed, 14 Aug 2019 02:59:10 +0000 (04:59 +0200)]
gpg/bugfix: Use .ExpiredUnix.IsZero to display green color of forever valid gpg key (#7846) (#7850)
* Use .ExpiredUnix.IsZero for display green color of gpg key
* remove useless parentheses
Mura Li [Tue, 13 Aug 2019 11:03:01 +0000 (19:03 +0800)]
Do not fetch all refs (#7837)
Which would unnecessarily slow down the pull compare operation.
Antoine GIRARD [Mon, 12 Aug 2019 01:53:26 +0000 (03:53 +0200)]
Fix duplicate call of webhook (#7821) (#7824)
Mario Lubenka [Sun, 11 Aug 2019 20:32:03 +0000 (22:32 +0200)]
Enable switching to a different source branch when PR already exists (#7823)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
David Svantesson [Sun, 11 Aug 2019 09:45:45 +0000 (11:45 +0200)]
Rewrite existing repo units if setting is not included in api body (#7811)
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
Gary Kim [Fri, 9 Aug 2019 18:40:16 +0000 (18:40 +0000)]
Prevent Commit Status and Message From Overflowing On Branch Page (#7800) (#7808)
Signed-off-by: Gary Kim <gary@garykim.dev>
Antoine GIRARD [Fri, 9 Aug 2019 13:18:46 +0000 (15:18 +0200)]
api: fix multiple bugs with statuses endpoints (#7785) (#7807)
* fix commit statuses api url
* search refs before passing sha
* adjust tests
* directly search tags and branches names + remove un-needed check in NewCommitStatus
* fix comment
* de-duplicate code
* test: use relative setting.AppURL
* Update routers/api/v1/repo/status.go
Co-Authored-By: Lauris BH <lauris@nix.lv>
* remove return
* Update routers/api/v1/repo/status.go
Co-Authored-By: Lauris BH <lauris@nix.lv>
WGH [Wed, 7 Aug 2019 15:57:08 +0000 (18:57 +0300)]
Fix Slack webhook fork message (#7774) (#7783)
The order of forkee and fork was mixed up.
Lunny Xiao [Wed, 7 Aug 2019 07:24:01 +0000 (15:24 +0800)]
Fix approvals counting (#7757) (#7777)
* fix approvals counting
* fix tests
* fmt
Lunny Xiao [Tue, 6 Aug 2019 07:41:26 +0000 (15:41 +0800)]
fix rename failed when rewrite public keys (#7761) (#7769)
zeripath [Tue, 6 Aug 2019 04:35:54 +0000 (05:35 +0100)]
Fix dropTableColumns sqlite implementation (#7710) (#7765)
* Fix dropTableColumns sqlite implementation
* use droptables and its index dropping support in v78 and v85
* golang-ci fixes
* Add migration from gitea 1.3.3 for sqlite which reveals the droptables bug - thus showing this works
zeripath [Tue, 6 Aug 2019 02:05:48 +0000 (03:05 +0100)]
Be more strict with git arguments (#7715) (#7762)
* Be more strict with git arguments
* fix-up commit test
* use bindings for branch name
Lunny Xiao [Mon, 5 Aug 2019 04:08:57 +0000 (12:08 +0800)]
add pagination for admin api get orgs and fix only list public orgs bug (#7742) (#7752)
guillep2k [Sun, 4 Aug 2019 07:00:03 +0000 (04:00 -0300)]
Backport: fix repo_index_status lingering when deleting a repository (#7738)
Lauris BH [Sun, 4 Aug 2019 01:29:17 +0000 (04:29 +0300)]
Fix milestone completness calculation when migrating (#7725) (#7732)
guillep2k [Sat, 3 Aug 2019 18:42:54 +0000 (15:42 -0300)]
Fixes indexed repos keeping outdated indexes when files grow too large (#7731)
* Fixes indexed repos keeping outdated indexes when files grow too large
Co-Authored-By: zeripath <art27@cantab.net>
guillep2k [Fri, 2 Aug 2019 14:40:15 +0000 (11:40 -0300)]
Backport: skip non-regular files (e.g. submodules) on repo indexing (#7717)
* Backport: skip non-regular files (e.g. submodules) on repo indexing
* Include "executable" files in the index, as they are not necessarily binary
Lunny Xiao [Thu, 1 Aug 2019 15:40:00 +0000 (23:40 +0800)]
improve branches list performance and fix protected branch icon when no-login (#7695) (#7704)
zeripath [Wed, 31 Jul 2019 21:13:15 +0000 (22:13 +0100)]
Correct wrong datetime format for git (#7689) (#7690)
techknowlogick [Wed, 31 Jul 2019 13:29:31 +0000 (09:29 -0400)]
1.9.0 Changelog (#7676)
Lunny Xiao [Wed, 31 Jul 2019 11:39:34 +0000 (19:39 +0800)]
fix duplicated webhook when creating issue with assignees (#7681) (#7684)
Lunny Xiao [Wed, 31 Jul 2019 09:09:29 +0000 (17:09 +0800)]
upgrade macaron/captcha to fix random error problem (#7407) (#7683)
David Svantesson [Wed, 31 Jul 2019 08:19:14 +0000 (10:19 +0200)]
Backport of #7675. (#7682)
Move add to hook queue for created repo to outside xorm session.
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
6543 [Tue, 30 Jul 2019 14:48:53 +0000 (16:48 +0200)]
Show protection symbol if needed on default branch (#7660) (#7668)
* backport issue showing portection symbol if needet at default branch
* sugestion to use range .Branches
https://github.com/go-gitea/gitea/pull/7668/files/
d57973a8041a741fdb7e77bc6ab18431bbf95ba4
6543 [Mon, 29 Jul 2019 21:20:39 +0000 (23:20 +0200)]
hide delete/restore button on archived repos [backport] (#7660)
* hide delete/restore button on archived repos
close issue #7653
* backport vor v1.9
* hide column also
* move protected icon to first colum
backport parts of https://github.com/go-gitea/gitea/pull/7461
* backport comit divergenze fix
https://github.com/go-gitea/gitea/issues/7625
Lunny Xiao [Mon, 29 Jul 2019 16:08:24 +0000 (00:08 +0800)]
fix bug on migrating milestone from github (#7665) (#7666)
Antoine GIRARD [Mon, 29 Jul 2019 13:05:53 +0000 (15:05 +0200)]
css: use flex to fix floating paginate (#7656) (#7662)
Lunny Xiao [Mon, 29 Jul 2019 04:15:13 +0000 (12:15 +0800)]
change length of some repository's columns (#7652) (#7655)
renothing [Sat, 27 Jul 2019 14:25:16 +0000 (22:25 +0800)]
fix wrong email when use gitea as OAuth2 provider (#7640) (#7647)
when you use gitea as OAuth2 provider, the /api/v1/user should return
user primary email as identifier, which is unique in OAuth2 clients.
this patch use convert.ToUser replace all u.APIFormat in api requests,
return primary email when caller is yourself or admin.
Andreas Shimokawa [Fri, 26 Jul 2019 20:37:31 +0000 (22:37 +0200)]
reserve .well-known username (#7638)
silverwind [Fri, 26 Jul 2019 06:12:35 +0000 (08:12 +0200)]
Fix syntax highlight initialization (#7617) (#7626)
* Fix syntax highlight initialization
Previously hljs was initialized via a function that relies on the
DOMContentLoaded event, registerd after jQuery's 'ready' event. I assume
that with the recent jQuery update, DOMContentLoaded may not be
guaranteed to fire after 'ready'. Fixed this via vanilla JS initalization.
Fixes: https://github.com/go-gitea/gitea/issues/7559
* semicolon
Lunny Xiao [Fri, 26 Jul 2019 01:22:20 +0000 (09:22 +0800)]
Fix bug create/edit wiki pages when code master branch protected (#7580) (#7623)
* fix bug create/edit wiki pages when code master branch protected
* improve FullPushingEnvironment function
zeripath [Thu, 25 Jul 2019 21:23:52 +0000 (22:23 +0100)]
Fix panic on push at #7611 (#7615) (#7618)
* Fix panic in #7611
Use pr.IssueID instead of pr.Issue.ID as Issue may not be loaded and is unnecessary
* Only fetch the head branch from the remote
zeripath [Tue, 23 Jul 2019 21:06:10 +0000 (22:06 +0100)]
Handle ErrUserProhibitLogin in http git (#7586, #7591) (#7590)
* Handle ErrUserProhibitLogin in http git (#7586)
* Use 403
zeripath [Tue, 23 Jul 2019 19:53:13 +0000 (20:53 +0100)]
fix #7568 (#7587) (#7589)
silverwind [Tue, 23 Jul 2019 06:18:39 +0000 (08:18 +0200)]
Fix file header overflow in file and blame views (#7562) (#7579)
Richard Mahn [Mon, 22 Jul 2019 21:38:38 +0000 (17:38 -0400)]
Fixes #7564 - Malformed URLs in API git/commits response (#7565) (#7567)
silverwind [Mon, 22 Jul 2019 16:23:49 +0000 (18:23 +0200)]
Fix empty commits now showing in repo overview (#7521) (#7563)
* Fix empty commits now showing in repo overview
* add test
* make fmt
Lunny Xiao [Mon, 22 Jul 2019 11:27:47 +0000 (19:27 +0800)]
Fix markdown invoke sequence (#7513) (#7560)
Lunny Xiao [Fri, 19 Jul 2019 06:40:16 +0000 (14:40 +0800)]
Fix repository's pull request count error (#7518) (#7524)
* fix pr count error
* fix tests
Lunny Xiao [Thu, 18 Jul 2019 13:20:35 +0000 (21:20 +0800)]
remove duplicated webhook trigger (#7511) (#7516)
Antoine GIRARD [Thu, 18 Jul 2019 04:32:29 +0000 (06:32 +0200)]
Backport drone fix from #7480 and #7496 (#7504)
* don't make release-version deps on transalations since translations is only triggered by push on master (#7496)
* drone/docker: Use a more standard format (#7480)
* drone/docker: Use a more standard format
Based on the plugin drone structure itself : https://github.com/drone-plugins/drone-docker/blob/
ebce953fc443371d79b5a019fcc9c1976f60a09a /.drone.yml#L9
Use autotag : http://plugins.drone.io/drone-plugins/drone-docker/#autotag
* use latest plugins/docker:linux-amd64
* remove useless cache_from
* Don't depends on translations step
Richard Mahn [Thu, 18 Jul 2019 01:11:55 +0000 (21:11 -0400)]
Fixes #7474 - Handles all redirects for Web UI File CRUD (#7478) (#7507)
* Fixes #7474 - Handles all redirects for Web UI File CRUD
* Fixes lint errors
* Typo fix
* Adds unit tests for a few helper functions
* Fixes per review
* Fix for new branch creation and to unit test
* Fixes the template used for errors on delete
Richard Mahn [Tue, 16 Jul 2019 04:45:38 +0000 (00:45 -0400)]
Backport for #7475 - settings error (#7483)