Merge pull request #20505 from nextcloud/fix/noid/system-creds

do not advertise nulled userId for for systemwide credentials

Merge pull request #20511 from nextcloud/fix/cs-fixer-ldap

PHP-CS-Fixer green

Merge pull request #16946 from exussum12/patch-1

Increase max read

Merge pull request #20246 from nextcloud/fix/untranslated_mail_footer

Provide the proper language to the mailer

PHP-CS-Fixer green

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Provide the proper language to the mailer

Else we can't properly translate the footer in the recipients e-mail
language.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #20506 from nextcloud/version/19/beta4

19 beta 4

Merge pull request #20509 from nextcloud/revert-20050-bugfix/noid/mysql-equal-trims-shock

Revert "Make sure MySQL is not saying 'this' = 'this ' is true"

[tx-robot] updated from transifex

Revert "Make sure MySQL is not saying 'this' = 'this ' is true"

19 beta 4

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #20503 from nextcloud/fix/noid/dav-catch-throwable

DAV's exception logger should deal with any Throwable

Merge pull request #20386 from nextcloud/version/19/beta3

19 beta 3

Merge pull request #20501 from nextcloud/fix/noid/run-cs-fix

Run cs:fix and fix HashWrapper code

Update View.php

fix credentialsManager documentation and ensure userId to be used as string

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #20502 from nextcloud/techdebt/cs-check-diff

Print diff in cs:check command

add DB tests for credentials manager

these are actually expected to FAIL, because NULL as a userid is not
allowed in the schema, but documented to be used on the source

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

DAV's exception logger should deal with any Throwable

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #20037 from nextcloud/fix/19127/deprecated-ldap_control_paged_result_1

do not use deprecated API for LDAP paged results

Print diff in cs:check command

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Run cs:fix and fix HashWrapper code

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #20500 from nextcloud/update-editor-config

Update editor config for .yml files

Merge pull request #19540 from jlutran/fixKeystoneV3Auth

Fix issues with Keystone auth v3 in files_external app

Update editor config for .yml files

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #20481 from ACTom/add-mindmap-mimetype

Add mindmap mimetype.

Merge pull request #20050 from nextcloud/bugfix/noid/mysql-equal-trims-shock

Make sure MySQL is not saying 'this' = 'this ' is true

Merge pull request #20138 from nextcloud/bugfix/noid/make-remote-checking-more-generic

Make remote checking more generic

Merge pull request #20401 from nextcloud/fix/login-sso-redirct

Fix absolute redirect

Merge pull request #19191 from laurisb/patch-1

Improve Opcache detection

Merge pull request #20361 from nextcloud/write-stream-close-on-exception

Close the streams in `writeStream` even when there is an exception

Fix issues with Keystone auth v3 in files_external app

Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>

Merge pull request #19351 from nextcloud/dav-upload-hash

Return hashes of uploaded content for dav uploads

Make sure MySQL is not saying 'this' = 'this ' is true

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #20476 from nextcloud/techdebt/php-cs-check-action

Add php-cs check action

Allow local remotes in integration tests

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix unit tests

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Show a hint for the php-cs fix when the check fails

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20474 from nextcloud/update-crl

Update root.crl due to revocation of spgverein.crt

Merge pull request #19936 from nextcloud/bugfix/noid/handle-unset-owner-in-sharing

Handle unset owner in sharing

Add mindmap mimetype.

Signed-off-by: ACTom <i@actom.me>

Merge pull request #20181 from nextcloud/bugfix/noid/dont-break-on-path-null

Also bail out when the path is actually null

Also disallow ; in remote urls

Signed-off-by: Joas Schilling <coding@schilljs.com>

Check all remotes for local access

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix php-cs formatting

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Add php-cs check action

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20472 from nextcloud/fix/19848/make-sure-destination-is-not-a-directory

Verify that destination is not a directory.

Update root.crl due to revocation of spgverein.crt

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #20470 from nextcloud/fix/noid/karma-coverage

Fix jsunit tests

use serverControls directly with LDAP calls, fixes 19127

- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Verify that destination is not a directory.

Otherwise file_put_contents will fail later.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix jsunit tests

JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #20469 from nextcloud/fix/sidebar/sharing/password-error-message

Properly display share error messages

Properly display share error messages

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

[tx-robot] updated from transifex

Merge pull request #20444 from nextcloud/dependabot/npm_and_yarn/url-loader-4.1.0

Bump url-loader from 4.0.0 to 4.1.0

Merge pull request #19852 from nextcloud/dav/provide-dav-setting-for-default-calendar

Provide dav setting for user's default calendar

Merge pull request #20460 from nextcloud/fix-app-not-listed-in-provisioning-integration-test

Fix app not listed in provisioning integration test

Bump url-loader from 4.0.0 to 4.1.0

Bumps [url-loader](https://github.com/webpack-contrib/url-loader) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/webpack-contrib/url-loader/releases)
- [Changelog](https://github.com/webpack-contrib/url-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/url-loader/compare/v4.0.0...v4.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #20218 from nextcloud/dependabot/npm_and_yarn/marked-0.8.2

Bump marked from 0.8.1 to 0.8.2

Bump marked from 0.8.1 to 0.8.2

Bumps [marked](https://github.com/markedjs/marked) from 0.8.1 to 0.8.2.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Commits](https://github.com/markedjs/marked/compare/v0.8.1...v0.8.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #20445 from nextcloud/dependabot/npm_and_yarn/nextcloud/paths-1.1.2

Bump @nextcloud/paths from 1.1.1 to 1.1.2

Fix app not listed in provisioning integration test

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Only delete the default calendar setting when the default calendar
itself is deleted

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Provide dav setting for user's default calendar

And add tests to handle schedule-default-calendar-URL

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Bump @nextcloud/paths from 1.1.1 to 1.1.2

Bumps @nextcloud/paths from 1.1.1 to 1.1.2.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #20446 from nextcloud/dependabot/npm_and_yarn/css-loader-3.5.2

Bump css-loader from 3.4.1 to 3.5.2

Merge pull request #20427 from nextcloud/bug/noid/fix-password-reset-activity

Fix password reset saying Admin changed my password when reset from login page

Bump css-loader from 3.4.1 to 3.5.2

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.4.1 to 3.5.2.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.4.1...v3.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #20442 from nextcloud/dependabot/npm_and_yarn/build/jsdoc-3.6.4

Bump jsdoc from 3.6.3 to 3.6.4 in /build

dont set headers for cli

Signed-off-by: Robin Appelman <robin@icewind.nl>

Return hashes of uploaded content for dav uploads

hashes are set in "X-Hash-MD5", "X-Hash-SHA1" and "X-Hash-SHA256" headers.

these headers are set for file uploads and the MOVE request at the end of a multipart upload.

Signed-off-by: Robin Appelman <robin@icewind.nl>

[tx-robot] updated from transifex

Merge pull request #20418 from nextcloud/dependabot/npm_and_yarn/sinon-9.0.2

Bump sinon from 9.0.1 to 9.0.2

Merge pull request #20421 from nextcloud/fix/20393/recommendend_webauthn_mods

Show setup check for recommended php modules

Increase max read

8kb is very low, especially given this will be local files

Signed-off-by: Scott Dutton <scott@exussum.co.uk>

Merge pull request #20439 from nextcloud/Valdnet-patch-3

Changing the translation catalog for "Share"

[tx-robot] updated from transifex

Changing the translation catalog for "Share"

Change "files" to "files_sharing".

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Bump jsdoc from 3.6.3 to 3.6.4 in /build

Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.3 to 3.6.4.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.4/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.3...3.6.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #20035 from nextcloud/bugfix/group-encode

Make sure group management works with all types of group names

Add tests for encoded group id

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Make sure the group id parameter gets properly encoded when used in URLs

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Make the groupId url encoded

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #20185 from azul/open-new_tab

Modify do_action so default ctrl-click opens tab

Merge pull request #20426 from nextcloud/techdebt/psr2

It is done

Merge pull request #20419 from nextcloud/dependabot/npm_and_yarn/various

Bump p-limit from 2.2.2 to 2.3.0, @nextcloud/auth from 1.2.2 to 1.2.3, @babel/preset-env from 7.8.7 to 7.9.5, @nextcloud/event-bus from 1.1.3 to 1.1.4, @nextcloud/password-confirmation from 1.0.0 to 1.0.1, @nextcloud/l10n from 1.2.2 to 1.2.3, @nextcloud/initial-state from 1.1.1 to 1.1.2, core-js from 3.6.4 to 3.6.5 …

[tx-robot] updated from transifex

Fix password reset saying Admin changed my password when reset from
login page

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Bump acceptance tests

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Bump coding standard lib for PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Format code according to PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Add visibility to all constants

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Add visibility to all methods and position of static keyword

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Add visibility to all properties and move static keyword

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20422 from nextcloud/techdebt/format-control-structs-classes-methods

Format control structures, classes, methods and function

Merge pull request #19495 from nextcloud/preview-generate-batch

optimize batch generation of previews

Bump core-js from 1.4.1 to 1.5.0

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Format control structures, classes, methods and function

To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>